[00:05:20] chrismcmahon: The VE "Chrome in betalabs" is re-running now, so I'll see if we get the same behaviors twice in a row (I'm really hoping that we don't….) [00:06:55] JeffHall: sounds good. I'm about to take off, drop me a line if there's anything that needs attention first thing tomorrow. [00:07:08] chrismcmahon: OK, will do [00:09:29] Yippee, build fixed! [00:09:30] Project browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_9 build #442: FIXED in 24 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_9/442/ [01:55:08] I'm concerned we don't have enough channels. [03:10:42] Yippee, build fixed! [03:10:42] Project browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_10 build #348: FIXED in 4 min 56 sec: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_10/348/ [03:26:59] Project browsertests-en.wikipedia.beta.wmflabs.org-linux-chrome build #532: FAILURE in 16 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-linux-chrome/532/ [05:03:57] Yippee, build fixed! [05:03:58] Project browsertests-test2.wikipedia.org-windows-internet_explorer_10 build #336: FIXED in 27 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-windows-internet_explorer_10/336/ [06:03:11] Yippee, build fixed! [06:03:12] Project Flow-en.wikipedia.beta.wmflabs.org-linux-chrome build #111: FIXED in 5 min 42 sec: https://wmf.ci.cloudbees.com/job/Flow-en.wikipedia.beta.wmflabs.org-linux-chrome/111/ [08:46:20] Project VisualEditor-test2.wikipedia.org-linux-chrome build #185: STILL FAILING in 48 min: https://wmf.ci.cloudbees.com/job/VisualEditor-test2.wikipedia.org-linux-chrome/185/ [09:12:05] Project VisualEditor-test2.wikipedia.org-linux-firefox build #210: STILL FAILING in 54 min: https://wmf.ci.cloudbees.com/job/VisualEditor-test2.wikipedia.org-linux-firefox/210/ [09:41:11] Tobi_WMDE: can you take a look at this commit and add your comments? https://gerrit.wikimedia.org/r/#/c/100591/ [09:45:09] (CR) Zfilipin: [C: 2] "Merging since the commit got two +1 reviews." [selenium] - https://gerrit.wikimedia.org/r/100375 (owner: Zfilipin) [09:45:11] (Merged) jenkins-bot: Make it possible to run tests on Cloudbees using PhantomJS [selenium] - https://gerrit.wikimedia.org/r/100375 (owner: Zfilipin) [09:49:37] morning [09:59:52] ChanServ: help [10:46:44] (03PS1) 10Zfilipin: Bump patch version to 0.1.14 [selenium] - 10https://gerrit.wikimedia.org/r/101193 [11:53:14] hi zeljkof [11:53:33] hi mayankmadan [11:53:47] what about that task list? [11:54:36] zeljkof, ^ [11:56:05] mayankmadan: sorry, I was really busy, did not have the time to add new tasks [11:56:13] no problem [11:56:16] but I got a few tasks from language group [11:56:19] let me find them [11:56:25] language group? [11:56:47] zeljkof: I've commented on the change https://gerrit.wikimedia.org/r/#/c/100591/ - also tested it locally for me that it should work when all my comments are addressed. [11:57:23] Tobi_WMDE: thanks! :) [11:57:46] mayankmadan: we have a language team that is also participating in code-in (I am in testing/qa team) [11:58:02] zeljkof: only problem left is that the selenium user on beta does not have rights to delete pages. [11:58:16] have to figure out how to change that [11:58:19] Tobi_WMDE: ok, that is out of scope for this task [11:58:45] when the student fixes problems on his end we can close the task, and then figure out how to fix selenium user [12:01:58] mayankmadan: go to the pad, I will post links there [12:03:26] zeljkof: yes, of course thats out of this task. I have to generally find out how to get the rights, will need it for other things too [12:03:45] Tobi_WMDE: I remember seeing bug about that... [12:04:27] zeljkof, i really wanted to do the fake http header task [12:04:38] but im not sure i have got the full idea of what that is [12:04:40] mayankmadan: ok, but? [12:04:52] mayankmadan: I can explain :) [12:04:53] but im not sure i have got the full idea of what that is [12:04:56] okay [12:05:09] did you read the bug it links to? [12:05:49] zeljkof, what is zero [12:07:39] zeljkof, or is it zero team? [12:07:42] zeljkof: do you know how to set env-variables on cloudbees and not writing them out to the console.. (setting e.g. login credentials) [12:08:14] Tobi_WMDE, mayankmadan: I am in a meeting with Amir, sorry [12:08:27] no problem [12:08:28] nP [12:08:53] hi Tobi_WMDE [12:08:56] you free? [12:09:32] mayankmadan: I have pasted a few links in your tab, take a look, I wil be free in 2 hours or so [12:10:04] okey doke [13:11:09] zeljkof, ping me when you are free [13:12:13] mayankmadan: will do [14:01:19] zeljkof: thanks for the comments, I'll take care of them right away [14:03:09] zeljkof: also, yes I am running the test localy an I get these erros but I didn't knew how to resolve them, my first thought was to modify the config.yml file [14:16:27] vandrew_, mayankmadan: will be back in 30 minutes [14:16:30] * zeljkof is out to lunch [14:19:38] enjoy [14:39:56] vandrew_: I am back [14:40:07] vandrew_: do you know what to do, or are you stuck? [14:41:27] zeljkof: I am doing good right now, I'll also add the other tests as well [14:41:44] vandrew_: ok, ping me if you get stuck [14:41:49] I should be here for the next 1-2 hours [14:54:15] zeljkof, online? [14:54:24] mayankmadan: yes! :) [14:54:28] (finally) [14:54:42] would you like to start with your new task? [14:56:21] mayankmadan: (had to restart irc client, if you asked something, I did not see it) [15:00:47] zeljkof, im ready [15:01:34] mayankmadan: do you know how to start? [15:01:40] nope [15:01:42] :) [15:03:15] mayankmadan: did you read the bug report? [15:04:36] mayankmadan: sorry, had to restart chrome [15:04:43] np [15:05:09] mayankmadan: did you read the bug report? [15:06:23] zeljkof, yep [15:06:36] do you have questions? [15:06:57] zeljkof, dont know what to ask as didny understand much [15:07:35] ok, did you read about http headers? [15:07:46] do you know what that is? [15:07:56] zeljkof, http headers are basically http codes right? [15:07:57] zeljkof for what it is worth, beta is dead [15:08:06] hashar: :) [15:08:11] like 200 for everything ok [15:08:15] zeljkof: got a fix though :] [15:08:19] hashar: thanks for letting me know [15:08:29] hashar: is beta down now? I [15:08:33] mayankmadan: https://en.wikipedia.org/wiki/List_of_HTTP_header_fields [15:08:47] hashar: all 503 in all browsers? [15:09:01] chrismcmahon: yes, hashar just let us know that beta is down, he is working on it [15:09:19] thanks zeljkof [15:09:39] mayankmadan: you can inspect headers that browser sends and receives with a browser dev tools [15:10:17] mayankmadan: wikipedia zero team needs to set custom headers for testing [15:10:17] https://www.mediawiki.org/wiki/Wikipedia_Zero [15:10:25] http://wikimediafoundation.org/wiki/Wikipedia_Zero [15:10:33] https://en.wikipedia.org/wiki/Wikipedia_Zero [15:10:50] mayankmadan: so this task is to find a tool that can do that [15:11:02] chrismcmahon: yeah I killed beta sorry [15:11:11] it should be easy, since I think the tool we already use can already do that (selenium) [15:11:31] chrismcmahon: applied some firewall rules to solve a long lasting issue we had but forgot to allow port 80 on apaches :-] [15:11:37] mayankmadan: the tricky part of the task is to find out what zero team needs and to implement at least one simple test [15:11:44] mayankmadan: proving that the solution you found works [15:12:09] similar to what you did for pdf tests, you found two ways how to test generating pdfs, with firefox and with chrome [15:12:10] hashar: np, I just got a little excited about being able to capture the headers that cause a 503 ;-) [15:12:28] mayankmadan: do you know how to proceed? [15:12:39] chrismcmahon: I haven't looked at the varnishlog today though :( [15:12:53] but I have the feeling that now apaches no more randomly restart, there should be less 503 [15:13:14] zeljkof, nope :) [15:13:44] mayankmadan: hashar, chrismcmahon, do you know where wikipedia zero team hangs out? [15:14:11] zeljkof: try #wikimedia-mobile [15:14:33] chrismcmahon: thanks, already did, I thought they have separate one [15:14:44] zeljkof: no clue, I would ask in #wikimedia-mobile [15:14:50] zeljkof: some of them are not even on IRC though [15:15:13] BETA BACK uP!!! [15:15:29] mayankmadan: the first step is to go to #wikimedia-mobile, find somebody there that can write a simple cucumber (given-when-then) scenario that you will implement [15:15:52] zeljkof, cucumber test for what? [15:16:04] mayankmadan: for faking http header [15:16:14] ok [15:16:17] we need to find out what they need to do [15:16:24] I am asking in the bug report right now [15:17:34] mayankmadan: feel free to ask at the bug report if you have any questions [15:24:34] mayankmadan: do you know what to do now, or are you stuck? [15:25:19] zeljkof, well i havent started anything yet [15:25:31] mayankmadan: do you know where to start? [15:25:48] zeljkof, not really :) [15:26:06] (03PS1) 10Cmcmahon: failing on Chrome, need some when_present statements [qa/browsertests] - 10https://gerrit.wikimedia.org/r/101211 [15:26:09] ok, until zero team replies, read about http, http headers and wikipedia zero [15:26:15] okay [15:27:16] mayankmadan: also, play with this, trying to set different headers [15:27:37] zeljkof, play with what? [15:27:52] mayankmadan: http://stackoverflow.com/a/20568647/17469 [15:31:53] (03PS1) 10Cmcmahon: wait for login to finish, see https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-windows-internet_explorer_9/650/testReport/junit/(root)/Edit/Go_to_edit_page/ [qa/browsertests] - 10https://gerrit.wikimedia.org/r/101212 [15:32:08] mayankmadan: do you know what to do now? :) [15:32:32] zeljkof, was reading the wikipedia page about http headers [15:32:47] mayankmadan: ok, great [15:32:57] if you get stuck, ask here or at the bug report, or qa list [15:37:20] (03PS1) 10Zfilipin: Fix Accept-Language feature[1] for PhantomJS [selenium] - 10https://gerrit.wikimedia.org/r/101213 [15:40:10] (03PS1) 10Zfilipin: Bump patch version to 0.1.15 [selenium] - 10https://gerrit.wikimedia.org/r/101214 [15:43:13] (03CR) 10Jhall: [C: 031] Bump patch version to 0.1.15 [selenium] - 10https://gerrit.wikimedia.org/r/101214 (owner: 10Zfilipin) [15:45:21] zeljkof, so there should be seperate page where the headers are defined [15:45:33] mayankmadan: I do not know yet [15:45:39] depending on what zero team needs [15:45:49] (03CR) 10Jhall: [C: 031] Bump patch version to 0.1.14 [selenium] - 10https://gerrit.wikimedia.org/r/101193 (owner: 10Zfilipin) [15:46:00] mayankmadan: but you probably do not need a separate page just to set a few headers [15:48:23] (03CR) 10Jhall: [C: 031] failing on Chrome, need some when_present statements [qa/browsertests] - 10https://gerrit.wikimedia.org/r/101211 (owner: 10Cmcmahon) [15:50:49] (03CR) 10Jhall: [C: 031] wait for login to finish, see https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-windows-internet_explorer_9/650/testReport/j [qa/browsertests] - 10https://gerrit.wikimedia.org/r/101212 (owner: 10Cmcmahon) [15:54:26] (03CR) 10Zfilipin: "Tests are green! https://wmf.ci.cloudbees.com/job/free-style-UniversalLanguageSelector-sandbox.translatewiki.net-linux-phantomjs/2/testRep" [selenium] - 10https://gerrit.wikimedia.org/r/101213 (owner: 10Zfilipin) [16:02:57] (03PS2) 10Zfilipin: wait for login to finish, see https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-windows-internet_explorer_9/650/testReport/junit/(root)/Edit/Go_to_edit_page/ [qa/browsertests] - 10https://gerrit.wikimedia.org/r/101212 (owner: 10Cmcmahon) [16:03:45] (03CR) 10Zfilipin: [C: 032] Wait for login to finish [qa/browsertests] - 10https://gerrit.wikimedia.org/r/101212 (owner: 10Cmcmahon) [16:06:53] (03CR) 10Zfilipin: [C: 032] failing on Chrome, need some when_present statements [qa/browsertests] - 10https://gerrit.wikimedia.org/r/101211 (owner: 10Cmcmahon) [16:07:54] (03PS2) 10Cmcmahon: Bump patch version to 0.1.14 [selenium] - 10https://gerrit.wikimedia.org/r/101193 (owner: 10Zfilipin) [16:08:14] (03CR) 10Cmcmahon: [C: 032] "update" [selenium] - 10https://gerrit.wikimedia.org/r/101193 (owner: 10Zfilipin) [16:08:34] (03PS2) 10Cmcmahon: Bump patch version to 0.1.15 [selenium] - 10https://gerrit.wikimedia.org/r/101214 (owner: 10Zfilipin) [16:09:25] (03CR) 10Cmcmahon: [C: 032] "update for PhantomJS" [selenium] - 10https://gerrit.wikimedia.org/r/101214 (owner: 10Zfilipin) [16:09:41] (03PS2) 10Cmcmahon: Fix Accept-Language feature[1] for PhantomJS [selenium] - 10https://gerrit.wikimedia.org/r/101213 (owner: 10Zfilipin) [16:10:04] (03CR) 10Cmcmahon: [C: 032] Fix Accept-Language feature[1] for PhantomJS [selenium] - 10https://gerrit.wikimedia.org/r/101213 (owner: 10Zfilipin) [16:33:25] zeljkof, online? [16:33:31] mayankmadan: in a meeting [16:33:40] zeljkof, ping me when free? [16:33:41] but ask, I will reply later [16:33:45] mayankmadan: sure [16:57:22] (03PS26) 10Cmcmahon: Added a test for downloading pdf from a random page [qa/browsertests] - 10https://gerrit.wikimedia.org/r/98160 (owner: 10Mayankmadan) [16:57:39] (03PS5) 10Cmcmahon: Adding tests for collapsing and expanding sidebar sections [qa/browsertests] - 10https://gerrit.wikimedia.org/r/100795 (owner: 10Mayankmadan) [16:59:52] (03CR) 10Cmcmahon: [C: 032] "reviewed" [qa/browsertests] - 10https://gerrit.wikimedia.org/r/100795 (owner: 10Mayankmadan) [17:01:00] (03PS27) 10Cmcmahon: Added a test for downloading pdf from a random page [qa/browsertests] - 10https://gerrit.wikimedia.org/r/98160 (owner: 10Mayankmadan) [17:04:06] (03CR) 10Zfilipin: [C: 04-1] Added a test for downloading pdf from a random page (031 comment) [qa/browsertests] - 10https://gerrit.wikimedia.org/r/98160 (owner: 10Mayankmadan) [18:18:17] Yippee, build fixed! [18:18:17] Project browsertests-en.wikipedia.beta.wmflabs.org-linux-chrome build #533: FIXED in 17 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-linux-chrome/533/ [18:19:27] chrismcmahon: When you have a free minute, I have a question about one of the existing Visual Editor browser tests [18:19:41] JeffHall: what's up? [18:20:16] chrismcmahon: So I was investigating failures with the "bullets and numbering" test: https://github.com/wikimedia/mediawiki-extensions-VisualEditor/blob/master/modules/ve-mw/test/browser/features/step_definitions/bullets_steps.rb [18:20:49] chrismcmahon: In line 10 of that test, we send a "return" after we inject a new line of text [18:21:11] ah yeah, I remember this [18:21:23] chrismcmahon: and the "return" seems to cause the bullet or numbering to be appiled to the following line, not the new line that the test injected [18:21:36] chrismcmahon: But that line must have been added for a reason.... [18:22:15] chrismcmahon: So I was tempted to remove line 10, but figured you might know some history on that? [18:22:15] JeffHall: yeah, we originally had ':enter' but it didn't do the right thing, VE didn't honor ':enter' properly but did honor ':return' properly. Has that now changed? [18:22:50] chrismcmahon: Ah, perhaps there has been a change in VE - OK, I need to dig in and investigate that [18:23:11] JeffHall: so is the test currently failing on that line? that might be a recent thing. [18:24:02] JeffHall: all the cursoring actions have been a pita with VE, :return, :enter, : arrow_right, etc. etc. [18:24:03] chrismcmahon: It fails during the "Review Changes" step, since it wants the text markup to be applied to the new line of text, when it's actually applied to a following line of text [18:25:03] JeffHall: does the test work in it's current form if you un-comment the sleep() on line 18? [18:25:18] JeffHall: that was another pita with this test that I never got around to fixing [18:25:49] chrismcmahon: I haven't tried modifying that "sleep" statement - let me give that a shot and see what happens [18:26:30] JeffHall: yeah, not sure but I think the test might be failing for you locally because the wrong line gets highlighted, because race condition on faster hosts [18:27:06] chrismcmahon: Yeah, that would make sense, since the same tests running via SauceLabs will be sluggish [18:27:40] JeffHall: yep, that one never failed on Sauce but often failed for me locally, thus the sleep() [18:28:17] chrismcmahon: Great, thanks for the pointers - I should be able to get this thing working.... [18:30:05] JeffHall: on a general note, we remain intensely interested in cursor operations, I'm still not sure VE has that nailed [18:30:58] chrismcmahon: So the cursor issue is with the VE implementation, rather than a browser (or wedriver) issue? [18:34:34] JeffHall: dunno. what I do know is that no one in the Selenium community is complaining about :arrow_right or :arrow_down or :enter not working correctly; except for VisualEditor :-) [18:55:16] JeffHall: did you intend to uncomment the 'sleep 1' in https://gerrit.wikimedia.org/r/#/c/101245? [18:55:55] chrismcmahon: Yes, because making that change did indeed fox the issue with running the test locally (where the text markup was being applied to the wrong line) [18:56:29] JeffHall: OK, I'll go with that. We should make a note to get rid of that sleep with something more elegant though. [18:56:50] chrismcmahon: Agreed! [18:57:55] see you in a bit [20:00:18] Yippee, build fixed! [20:00:18] Project browsertests-test2.wikipedia.org-linux-chrome build #780: FIXED in 22 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-linux-chrome/780/ [20:30:15] Project browsertests-test2.wikipedia.org-windows-internet_explorer_10 build #337: FAILURE in 29 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-windows-internet_explorer_10/337/ [20:40:29] Project browsertests-test2.wikipedia.org-windows-internet_explorer_6 build #594: FAILURE in 30 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-windows-internet_explorer_6/594/ [20:45:02] (03CR) 10Krinkle: [C: 031] Make mwext-Scribunto-jslint voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/100712 (owner: 10Krinkle) [21:02:50] Yippee, build fixed! [21:02:50] Project browsertests-test2.wikipedia.org-windows-internet_explorer_7 build #598: FIXED in 32 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-windows-internet_explorer_7/598/ [21:19:02] Project Flow-en.wikipedia.beta.wmflabs.org-linux-chrome build #112: FAILURE in 5 min 42 sec: https://wmf.ci.cloudbees.com/job/Flow-en.wikipedia.beta.wmflabs.org-linux-chrome/112/ [21:23:35] chrismcmahon: Do you have suggestions for Gerrit reviewers for a browser test change to the MobileFrontend repo? [21:24:02] JeffHall: me and zeljko for right now [21:24:13] chrismcmahon: OK, thanks [21:25:01] Project Flow-test2-wikipedia-org-linux-chrome build #8: FAILURE in 5 min 58 sec: https://wmf.ci.cloudbees.com/job/Flow-test2-wikipedia-org-linux-chrome/8/ [21:35:29] (03PS1) 10Cmcmahon: update test for modern times, prevent false failures [qa/browsertests] - 10https://gerrit.wikimedia.org/r/101445 [21:37:07] JeffHall: I'm comfortable self-merging this, but I put you as reviewer if you'd like to look it over. it's an intermittent failure for IE10 and overdue for overhaul https://gerrit.wikimedia.org/r/#/c/101445/ [21:38:11] chrismcmahon: Yep, looks fine to me [21:38:18] (03CR) 10Jhall: [C: 032] update test for modern times, prevent false failures [qa/browsertests] - 10https://gerrit.wikimedia.org/r/101445 (owner: 10Cmcmahon) [21:38:29] ah, I find refactoring calming :-) [21:39:38] so nice that we had a Cucumber step "the the new page should have..." [21:41:36] (03Merged) 10jenkins-bot: update test for modern times, prevent false failures [qa/browsertests] - 10https://gerrit.wikimedia.org/r/101445 (owner: 10Cmcmahon) [21:49:37] JeffHall: just saw the new Nearby test, nice going! [21:50:20] chrismcmahon: It's very limited because of betalabs content, but hopefully it works well enough [21:50:48] JeffHall: understood, I'd like to make sure Jon has a good look at it [21:51:23] chrismcmahon: Yep, will try to chat with him later today [21:52:21] JeffHall: I added Arthur to the review list. In the context of your earlier question, awjr is the Mobile team's 'scrum master' and he's really good about context for new frontiers and all [21:52:43] chrismcmahon: Great, sounds good to me [22:03:44] just btw, I think Nik and Chad are updating all the CirrusSearch indexes in the whole world, so Search tests might fail for a bit [23:38:14] chrismcmahon: Is there a Bugzilla ticket for the Selenium Chrome cursor issues in Visual Editor? [23:41:16] JeffHall: no, but there is a Chromedriver ticket, just a sec... [23:41:42] JeffHall: https://code.google.com/p/chromedriver/issues/detail?id=636 [23:41:47] not much traction [23:42:27] chrismcmahon: OK, great, I'll try creating an equivalent Java Selenium script to see if the Java bindings repro the same problem [23:42:37] JeffHall: thanks [23:45:00] JeffHall: if there is a difference, that would be great (because we could get a Ruby bug fixed), but I'm not holding out much hope [23:46:02] JeffHall: otoh, a repro in Java would get more attention from Chromedriver devs [23:46:30] chrismcmahon: If I can just figure out how to dismiss the beta warning in Java, we should be able to get an answer! [23:53:26] JeffHall: oh, shoot, I was going to futz with that today and I forgot [23:55:07] JeffHall: I'll run a brute-force thing by you here in a minute... [23:55:24] chrismcmahon: OK, sounds good - thanks!