[00:02:01] JeffHall: are the beta warning errors only on test2? I think we actually need to dismiss the fundraising banner [00:03:25] * chrismcmahon .oO(and why are we raising funds on test2wiki anyway?) [00:03:27] chrismcmahon: No, beta warnings also appear in beta labs [00:03:45] JeffHall: but are we dismissing them properly on beta? [00:04:14] chrismcmahon: Yes, as far as I know we are, unless you've seen recent test failures with that (I haven't) [00:04:58] JeffHall: I think we might be dismissing the beta warnings correctly on beta labs, but the fundraising banners are killing the tests on test2 (we are SO BAD at naming things!) [00:05:30] chrismcmahon: OK, that does make sense, since I think the fundraising banner only showed up recently in test2 [00:06:00] JeffHall: 'tis the season. for Fundraising. but fundraising banners on test2wiki are just silly :-) [00:10:22] (03CR) 10Hashar: "Well done!" [selenium] - 10https://gerrit.wikimedia.org/r/101213 (owner: 10Zfilipin) [00:17:39] JeffHall: I think the VE test failures just now are legit because of https://bugzilla.wikimedia.org/show_bug.cgi?id=58406 [00:18:16] chrismcmahon: Yep, we're getting close to going green in CloudBees, at least for beta labs [00:19:17] JeffHall: Monday let's see if we can get the fundraising banner turned off for test2wiki, that is just dumb [00:20:46] chrismcmahon: Sounds good to me! [00:24:23] fundraising warning on top of a beta feature warning on top of an anon edit warning: http://imgur.com/oUTrFSl [00:27:07] Sort of like the warnings on a pack of cigarettes - Visual Editor can be harmful to your health! [00:29:01] (03PS1) 10Subramanya Sastry: Added Jenkins tests for commits to new Parsoid repo. [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/101460 [00:49:44] (03CR) 10GWicke: [C: 04-1] "I think the checks themselves will need to be adapted too. Paths are now different (js/ prefix is gone), the contrib repo is no longer nec" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/101460 (owner: 10Subramanya Sastry) [01:00:59] (03PS1) 10Krinkle: Add 'npm' macro and jobs for oojs [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/101461 [01:01:06] (03PS1) 10Krinkle: Clean up: Remove a few redundant 'scm' properties [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/101462 [03:52:36] Yippee, build fixed! [03:52:36] Project browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_6 build #417: FIXED in 22 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_6/417/ [04:47:12] Project browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_9 build #445: FAILURE in 27 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_9/445/ [05:21:41] Yippee, build fixed! [05:21:41] Project browsertests-test2.wikipedia.org-windows-internet_explorer_10 build #338: FIXED in 34 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-windows-internet_explorer_10/338/ [05:32:17] Yippee, build fixed! [05:32:18] Project browsertests-test2.wikipedia.org-windows-internet_explorer_6 build #595: FIXED in 27 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-windows-internet_explorer_6/595/ [05:52:40] Project browsertests-test2.wikipedia.org-windows-internet_explorer_7 build #599: FAILURE in 30 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-windows-internet_explorer_7/599/ [06:11:38] Yippee, build fixed! [06:11:39] Project Flow-test2-wikipedia-org-linux-chrome build #9: FIXED in 4 min 39 sec: https://wmf.ci.cloudbees.com/job/Flow-test2-wikipedia-org-linux-chrome/9/ [07:08:23] Project MobileFrontend-en.m.wikipedia.org-linux-firefox build #210: FAILURE in 20 min: https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.org-linux-firefox/210/ [08:18:33] hi zeljkof [08:18:42] hi mayankmadan [08:20:24] zeljkof, how can be header values pass as url params? [08:20:31] *parameters [08:20:32] :) [08:20:39] for now, ignore url parameters [08:20:45] just try to send headers [08:21:02] url parameters are a workaround that zero team implemented [08:21:09] since they did not have a tool to send custom headers [08:22:21] zeljkof, so my task is to write a test that would send custom headers? [08:23:22] mayankmadan: the task is to write at least one test that sends custom headers and inspects the page that comes back [08:23:29] checking if the response is correct [08:23:53] if we manage to do that, then another task can be writing more tests [08:24:04] but this task is research if we can do that at all :) [08:24:35] zeljkof, inspect the page for what? [08:29:40] mayankmadan: when you send a request to a server (with custom headers), the server will send back a page [08:29:46] the page should have some contents [08:30:02] and you should inspect if the contents of the page are correct or not [08:30:13] but I am not sure what is correct and what is not correct [08:30:17] zeljkof, like if i set the language header to some language then the server should send content in that language? [08:30:25] yes [08:30:27] something like that [08:30:43] but you have to ask at the bug report how to do that for wikipedia zero [08:30:52] what needs to be sent and what needs to get back [08:37:56] did you manage to send custom headers at all? [08:46:26] zeljkof, i havent [08:48:10] mayankmadan: did you try and fail, or you did not try yet? [08:49:00] zeljkof, i tried and failed [08:53:12] zeljkof, what am i supposed to do? [08:53:35] did you see link to stack overflow question I have posted to the bug report? [08:53:58] zeljkof, i tried the solution [08:54:00] it didnt work [08:54:18] mayankmadan: terminal output or it did not happen :) [08:54:33] zeljkof, everything worked fine :) [08:54:42] zeljkof, but the browser didnt show expected results [08:54:54] I did not understand that [08:55:21] after setting Accept-Language header to 'ru-RU' like it said on stack overflow [08:55:40] but wikipedia was still in en [08:55:45] zeljkof, ^ [08:56:14] mayankmadan: I see [08:56:22] not every site responds to headers [08:56:25] try with this site [08:56:32] sandbox.translatewiki.org [08:56:35] no, it is net [08:56:45] sandbox.translatewiki.net [08:56:49] try with that site [08:59:38] zeljkof, does it only work with phantomjs [08:59:50] setting custom headers? [08:59:56] I do not know [09:00:11] we can change accept-language headers for firefox, chrome and phantomjs [09:00:25] I am not sure if we can change other headers for browsers [09:00:31] that is for you to figure out :) [09:01:09] zeljkof, it didnt work [09:01:22] sandbox.translatewiki.net is still in en [09:01:27] and [09:01:45] mayankmadan: terminal output or it did not happen :) [09:01:53] the page that was in stackoverflow which displays headers still displays en [09:01:55] maybe you made a typo somewhere [09:03:49] zeljkof, i didnt get any of your messages if you sent any [09:03:51] i disconnected [09:05:25] zeljkof, ? [09:05:49] mayankmadan_: I am here [09:06:11] you can always check channel logs here http://bots.wmflabs.org/~wm-bot/logs/%23wikimedia-qa/ [09:06:18] ok :) [09:06:29] mayankmadan_: I said: terminal output or it did not happen :) [09:06:46] zeljkof, everything was fine with terminal :) [09:06:52] the output wasnt correct [09:07:31] mayankmadan_: ok [09:07:41] but I still do not know what was the problem [09:07:56] you have to help me, so I am able to help you :) [09:08:05] zeljkof, the custom header wont set [09:08:10] even after following all the steps [09:08:11] you have to explain what you did, so I know what went wrong [09:08:27] ok, paste terminal output to the pad [09:08:31] zeljkof, i am going to paste all the commands to pad [09:08:43] mayankmadan_: excellent :) that is the way to go [09:13:15] zeljkof, pasted [09:14:05] looking [09:15:09] what is your phantomjs version? [09:15:54] zeljkof, i forgot to replace phantomjs to chrome there [09:16:10] mayankmadan_: what is phantomjs version? [09:16:51] mayankmadan_: and yes, that is for chrome, I am not sure if that works [09:17:00] try with phantomjs, and let me know the version [09:17:10] exactly like I did in stack overflow answer [09:17:12] zeljkof, i dont use phantomjs [09:17:24] mayankmadan_: but you should! :) [09:17:33] I am not sure if it will work with any other browser [09:17:38] okay [09:17:40] for this task you have to use phantomjs [09:17:59] well, at least until you figure out if it works there [09:18:19] when you get it working in phantomjs, I do not care if you decide to make it work in another browser [09:18:25] it would be great, but that is optional [09:18:34] okay [09:18:55] also, you are free to try making it work with other browsers from start, but then the task will be much harder :) [09:19:12] since I do not know if it is possible to fake headers for other browsers [09:28:54] zeljkof, phantomjs doesnt display anything? [09:29:07] mayankmadan_: phantomjs is a headless browser! :) [09:29:13] nice [09:29:24] meaning, yes, by default it does not display anything [09:29:29] using browser_variable.text works [09:29:31] but you can take a screenshot, or ask for html [09:29:40] *browser_variable.html [09:29:47] how can i take a screenshot? [09:29:53] mayankmadan_: ok, so it works now? setting browser headers? [09:30:03] didnt try yet [09:30:03] browser.screenshot.save "file_name.png" [09:33:42] zeljkof, it worked with phantomjs [09:33:57] mayankmadan_: see? :) terminal output helped [09:34:07] yes it did [09:34:34] trying to explain a problem to somebody will cause you in 50% to figure out yourself what is worng [09:34:37] wrong [09:35:25] zeljkof, it worked even with google.com [09:35:35] :) [09:35:44] if you want, try with another browser now [09:35:53] but keep in mind that it might not work [09:36:01] zeljkof, it wasnt working with firefox or chrome [09:36:12] or it might work, but you have to change something else in browser settings [09:36:24] zeljkof, huh? [09:37:38] what is not clear? [09:37:51] change something? [09:54:50] zeljkof, ^ [09:54:56] different browser might have headers settings in a different place [09:55:00] that is all [10:11:46] zeljkof, is there a way to run js using webdriver [10:11:52] js commands [10:12:19] of course :) [10:12:34] but I do not know js, so I do not know how [10:12:59] zeljkof, so i can execute js in the web console using irb? [10:13:09] take a look at this page [10:13:09] https://code.google.com/p/selenium/wiki/WebDriverJs [10:13:34] I am not sure what you mean by js in web console using irb :) [10:13:43] but, if you open irb, and start a browser [10:13:50] then you can run any javascript, like this [10:14:04] zeljkof, web console is there in developer options in almost every browser [10:14:06] browser.execute_script "javascript-goes-here;" [10:14:23] mayankmadan_: yes, but irb is not there, right? :) [10:14:38] zeljkof, irb is not there but we are controlling the browser from it [10:14:53] ok [10:14:57] what was the question, again? [10:15:13] you can inspect the browser from dev tools, and you can control the browser from irb [10:15:21] but I am not sure what are you asking [11:01:05] zeljkof, can you explain to me whats the task again? :) [11:01:34] mayankmadan_: sure [11:01:47] so, zero team needs to test something [11:01:58] the test involves sending custom headers to a server [11:02:18] when the server replies, the test should check the reply and verify is it correct or not [11:02:25] zeljkof, got it [11:02:28] your task is to implement at least one simple tests [11:02:29] test [11:02:41] send custom headers to a server that zero team cares about [11:02:45] receive reply [11:02:50] can i do this just for phantomjs and for chrome and firefox later? [11:02:52] parse reply and determine is it good or not [11:03:03] I do not care :) [11:03:13] but I think it will be the easier in phantomjs [11:03:27] yep [11:03:30] and if you make it work, I will ask zero team if they would like more tests [11:03:36] so that can be another task or tow [11:03:37] two [11:03:50] and if they would like to use another browser, that can be another task [11:04:00] great [11:04:00] so, for now, just create one simple test [11:04:19] and when they see the test, they will probably want more, but I do not know for sure [11:04:29] zeljkof, so i need to ask yurik in wikimedia-mobile for the test and the targeted server right? [11:04:46] yes, he is one of the people working on zer [11:04:47] zero [11:04:59] okay [11:05:00] he already left a comment in bugzilla, did you see it? [11:05:05] yep [11:05:12] I am not sure if he provided all data that you need [11:05:21] but you can also ask at the bug report for more data [11:05:26] it made things even worse when i read it :) [11:10:10] mayankmadan_: you did not understand the reply? [11:10:18] ask for clarifications [11:10:43] he might not be aware of the fact that you are high school student that is new to wikimedia [11:10:49] say that in the bug report [11:10:54] and ask for a simple explicit example [11:15:36] zeljkof, i understood the reply but the reply doesnt say what he wants [11:15:47] mayankmadan_: then ask for more information :) [11:15:51] :) [11:15:58] part of this task is getting the information :) [11:16:05] I also do not know what they do [11:16:18] ill leave a comment in the bugzilla [11:16:23] sounds good [11:16:31] you can create a simple test using google or any other site [11:16:39] and ask them is that something like what they need [11:16:53] okay [11:16:54] so, give them an example and ask them to change it [11:17:42] zeljkof, where is the @browser variable defined in the repo? [11:17:58] I did not understand the question [11:18:19] when running tests in general, where is the variable defined? [11:18:50] zeljkof, yes, @browser is used for the browser that is being controlled by webdriver [11:18:53] right? [11:18:58] so where is it defined [11:19:01] yes [11:19:07] page-object gem defines it somewhere [11:19:14] but I am not sure where, never checked [11:19:17] okay [11:19:19] why do you ask? [11:19:25] just out of curiosity? [11:19:32] or do you need it for something? [11:19:50] mostly but i was thinking how am i going to supply the params for customHeader [11:20:56] zeljkof, ^ [11:21:06] custom header [11:21:11] ok [11:21:14] let me think [11:21:46] for now, in a step, start the browser yourself [11:22:29] @browser = Watir::Browser.new :phantomjs, :headers = "headers" [11:22:34] something like that [11:22:45] when you get it working I will figure out where to put it [11:22:58] ok [11:58:11] zeljkof, can a variable defined in a block be used in another block? [11:58:18] mayankmadan_: yes [11:58:23] but it has to be instance variable [11:58:28] like if i define a variable in given can i use it in then? [11:58:29] meaning it begins with @ [11:58:35] ok [11:59:01] what is the function of an instance variable? [11:59:29] zeljkof, ^ [12:02:08] zeljkof, the test that i made passes and works expectedly [12:02:14] should i push it to gerrit? [12:02:28] mayankmadan_: of course! :) [12:02:37] and add yuri as a reviewer [12:02:41] (and me) [12:02:47] and what is instance variable? [12:02:52] what is its function? [12:05:19] (03PS1) 10Mayankmadan: Adding a test to check if supplying custom headers works [qa/browsertests] - 10https://gerrit.wikimedia.org/r/101485 [12:13:16] zeljkof, pushed and added you [12:13:44] mayankmadan_: great [12:13:52] let me take a quick look [12:15:10] mayankmadan_: looks good to me [12:15:19] let's see what zero people say [12:15:28] ok [12:15:46] zeljkof, anybody else that you know is in zero team? [12:15:57] mayankmadan_: no, but let me check [12:16:21] mayankmadan_: this page lists all people that work for wikimedia foundation [12:16:21] http://wikimediafoundation.org/wiki/Staff_and_contractors?showall=1 [12:17:06] but people listed there as zero team are not developers, as far as I can see [12:17:23] zeljkof, do i manually need to close the phantomjs everytime i run the test or it closes automatically after test is complete? [12:17:32] mayankmadan_: I do not know :) [12:17:45] mayankmadan_: you should probably explicitly close the browser, just in case [12:18:09] but there is no process named phantomjs that i can kill and it doesnt show itself up [12:19:05] mayankmadan_: just do @browser.close [12:20:25] (03PS2) 10Mayankmadan: Adding a test to check if supplying custom headers works [qa/browsertests] - 10https://gerrit.wikimedia.org/r/101485 [12:31:19] (03PS3) 10Mayankmadan: Adding a test to check if supplying custom headers works [qa/browsertests] - 10https://gerrit.wikimedia.org/r/101485 [12:50:02] zeljkof, i think @browser is permenantly changed to run phantomjs [12:50:16] zeljkof, it shouldnt have but clearly it is [12:50:51] zeljkof, nevermind my last message [18:50:29] Project browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_6 build #418: FAILURE in 22 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_6/418/ [19:40:51] Yippee, build fixed! [19:40:51] Project browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_9 build #446: FIXED in 24 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_9/446/ [20:07:55] Project browsertests-test2.wikipedia.org-windows-internet_explorer_10 build #339: FAILURE in 27 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-windows-internet_explorer_10/339/ [20:38:52] Yippee, build fixed! [20:38:52] Project browsertests-test2.wikipedia.org-windows-internet_explorer_7 build #600: FIXED in 30 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-windows-internet_explorer_7/600/ [21:52:56] Yippee, build fixed! [21:52:56] Project MobileFrontend-en.m.wikipedia.org-linux-firefox build #211: FIXED in 16 min: https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.org-linux-firefox/211/