[00:10:58] chrismcmahon: Are you going to be around at all next week? [00:12:52] chrismcmahon: Flow IE9 job has been in "Executor starvation" for 3 hours and 29 minutes. :-( I'm pretty sure this contravenes some Geneva convention :) [00:13:15] JeffHall: I should be around except for Christmas [00:14:08] chrismcmahon: Great - would love to schedule a pairing session with you to talk more about waiting for DOM changes, as per your response to Amir earlier today [00:15:28] JeffHall: OK. my experience is that almost every problem yields to a wait_until(), but that wait_while_present() sure did come in handy that one time. [00:16:09] chrismcmahon: Yeah, I've run into another case where only a "sleep" statement seems to work, so I must not be using the "wait" methods properly [00:16:51] JeffHall: yeah, every once in a while sleep() is either a necessary evil OR actually the right thing to do. In fact, another example, one sec... [00:21:45] JeffHall: I'd argue that sleep() is the right thing to do for Flow here https://github.com/wikimedia/mediawiki-extensions-Flow/blob/master/tests/browser/features/step_definitions/collapse_steps.rb (line 13) https://github.com/wikimedia/mediawiki-extensions-Flow/blob/master/tests/browser/features/collapse.feature (line 8) [00:22:13] * chrismcmahon goes to add that to the email thread [00:24:35] chrismcmahon: Yeah, that Flow case definitely makes sense, but I've found cases where "sleep" works when the "wait" methods seem more appropriate to me, but they just aren't behaving as I want them to :( [00:27:15] JeffHall: the thing to avoid is where you have sleep() statements that add up to big performance hits before discovering that the test failed. [00:27:50] chrismcmahon: Yeah, that definitely makes sense [00:27:51] JeffHall: e.g. wait_until(30) is far more acceptable than sleep(30) [00:28:40] JeffHall: so a sleep(1) here and there is not that big a deal in the service of a good cause :-) [00:29:15] JeffHall: Zejko might disagree :-) [03:31:53] Project browsertests-en.wikipedia.beta.wmflabs.org-linux-firefox build #527: FAILURE in 21 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-linux-firefox/527/ [04:17:09] Project browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_8 build #432: FAILURE in 25 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_8/432/ [04:36:44] Yippee, build fixed! [04:36:44] Project browsertests-test2.wikipedia.org-linux-chrome build #795: FIXED in 19 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-linux-chrome/795/ [05:30:45] Project browsertests-test2.wikipedia.org-windows-internet_explorer_7 build #613: FAILURE in 27 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-windows-internet_explorer_7/613/ [05:42:09] Yippee, build fixed! [05:42:10] Project browsertests-test2.wikipedia.org-windows-internet_explorer_8 build #633: FIXED in 29 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-windows-internet_explorer_8/633/ [06:04:16] Project Flow-en.wikipedia.beta.wmflabs.org-linux-chrome build #128: FAILURE in 5 min 24 sec: https://wmf.ci.cloudbees.com/job/Flow-en.wikipedia.beta.wmflabs.org-linux-chrome/128/ [06:29:35] Yippee, build fixed! [06:29:35] Project MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome build #148: FIXED in 15 min: https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/148/ [06:46:09] Project MobileFrontend-test2.m.wikipedia.org-linux-firefox build #153: FAILURE in 16 min: https://wmf.ci.cloudbees.com/job/MobileFrontend-test2.m.wikipedia.org-linux-firefox/153/ [15:01:54] hi zeljkof [15:02:00] hi mayankmadan__ [15:32:44] zeljkof, are there any tasks about writing more tests? [15:32:56] let me see my list [15:33:31] this is my public todo list [15:33:31] https://bugzilla.wikimedia.org/buglist.cgi?cmdtype=dorem&remaction=run&namedcmd=qa&sharer_id=16205 [15:33:37] do you see anything interesting there? [15:36:10] there are new bugs :) [15:36:41] not that im happy because there are bugs but new bugs means more tasks :) [15:44:37] :) [15:44:50] feel free to pick anything and I will create a task in melange site [15:45:46] zeljkof, what is this line doing? ENV["MEDIAWIKI_PASSWORD"] = ENV[ENV["MEDIAWIKI_PASSWORD_VARIABLE"]] if ENV["MEDIAWIKI_PASSWORD_VARIABLE"] [15:45:50] in hooks.rb [15:45:57] in mediawiki-selenium repo [15:46:58] this? https://github.com/wikimedia/mediawiki-selenium/blob/master/lib/mediawiki/selenium/hooks.rb#L15 [15:47:39] zeljkof, yep [15:49:54] if environment variable MEDIAWIKI_PASSWORD_VARIABLE exists, then it's value is used to set the value of MEDIAWIKI_PASSWORD variable [15:50:17] it is a way of having password in env variable but not displayed in console output in jenkins [15:59:40] zeljkof, i dont understand this bug https://bugzilla.wikimedia.org/show_bug.cgi?id=55867 [16:00:58] there is a way to run tests in parallel [16:01:18] zeljkof, so? [16:01:21] for example [16:01:21] https://wmf.ci.cloudbees.com/view/fs/job/free-style-UniversalLanguageSelector-commons.wikimedia.beta.wmflabs.org-linux-phantomjs-parallel/ [16:03:21] so instead of running tests with: bundle exec cucumber (options) [16:03:47] you would run them: parallel_cucumber --test-options (options) [16:04:11] the reason is that instead of waiting 5 minutes for tests to run, you could wait 1 minute [16:04:26] if there are 5 tests and each takes a minute to run [16:04:35] now, if there are 100 tests... :) [16:04:57] a task could be similar to phantomjs one, but simpler [16:05:18] run all tests, find ones that break when running in parallel and tag them with something like @parallel-bug [16:05:24] sounds interesting? [16:06:04] I could also change phantomjs task to be more simple [16:06:14] just tagging the tests that fail with phantomjs [16:06:54] zeljkof, dont do it now [16:07:08] zeljkof, my current task is still to be reviewed by guillom [16:08:22] zeljkof, i think then a separate phantomjs task can be made for fixing the issues that are tagged [16:08:37] it will make things simpler [16:12:55] i was calculating task totals [16:13:01] i am 8th :P for wikimedia [16:13:13] GEOFBOT: almost in the top 5! :) [16:14:49] zeljkof, in this bug [16:14:49] https://bugzilla.wikimedia.org/show_bug.cgi?id=58720 [16:14:58] i know how to spoof location with firefox [16:15:06] but i dont know how to do it with chrome [16:15:09] will it be enough? [16:16:39] mayankmadan_: http://www.labnol.org/internet/geo-location/27878/ [16:17:22] GEOFBOT, i know that [16:17:34] but how do i do it using watir-webdriver [16:17:41] mayankmadan_: oh, lol sorry [16:19:39] mayankmadan_: you should ask jeff, he is the reported, I really do not know a lot about that bug [16:23:04] zeljkof, should i start working on phantomjs-bug tagging task? [16:23:17] mayankmadan_: if you would like to work on that, sure [16:23:25] I can create the task in melange [16:23:28] zeljkof, but ill just tag :) [16:23:32] should I do it? [16:23:35] zeljkof, dont add it now please [16:23:49] I am offline next week [16:23:54] guillom has still not reviewed my task yet [16:23:56] it is today or in a week [16:24:17] zeljkof, will jeff be online today? [16:24:21] not sure [16:24:24] probably now [16:24:26] not [16:24:35] but he should be online next week [16:24:53] zeljkof, lets do it next week [16:25:08] or i could ask jeff to add that task in the middle of the week [16:25:20] mayankmadan_: sure [16:25:29] ask jeff or chris, they are also admins [16:25:54] zeljkof, mentors or admins? [16:26:03] mayankmadan_: sorry, mentors [16:26:13] I think only Quim and Andre are admins [16:26:31] yeah [16:35:26] zeljkof: where do you want the test result page to be placed in the email? [16:35:45] GEOFBOT: you do not have to put the entire test result page [16:35:52] I have been thinking about the task [16:36:08] actually, I was playing with templates myself yesterday on my local jenkins installation [16:36:17] how are you testing the templates? [16:36:23] i have a local jenkins too [16:36:28] and i edit the template on windows [16:36:29] are you on linux? [16:36:33] oh, windows? [16:36:35] i upload it with sftp to my linux box [16:36:42] ok [16:36:46] and then i run the email tempalte testing on the jenkins proj page [16:36:57] how to you upload the template there? [16:37:08] sftp [16:37:16] it is your self-hosted jenkins? [16:37:24] or cloudbees hosted jenkins? [16:37:59] self hosted [16:38:08] because cloudbees has restrictions on uploading [16:38:16] GEOFBOT: yes, that is the problem [16:38:43] I was playing with sending mail from a jenkins machine hosted at my local desktop machine [16:38:53] anyway [16:39:23] all that we actually need in the e-mail is the list of tests that failed [16:39:32] the rest is not really important [16:39:42] and console output should be removed [16:39:44] ok [16:39:52] strip it down and condense it to focus on the tests [16:39:53] and there are a few images that are broken [16:40:08] that's because the images ink to the jenkins installation [16:40:11] and mines is LAN [16:40:12] those should be either removed (simple) or links should be fixed [16:40:22] just remove the images [16:40:24] so all the images are linking to 192.168.2 which no one else can acces ;) [16:40:25] ok [16:40:54] if the e-mail could look like this [16:40:55] https://wmf.ci.cloudbees.com/view/fs/job/free-style-UniversalLanguageSelector-commons.wikimedia.beta.wmflabs.org-linux-phantomjs-parallel/lastCompletedBuild/testReport/ [16:41:10] that would be great [16:41:38] it says how many tests, how many failed, how long the test run took [16:41:54] lists failed tests with links to the test results page [16:42:01] simple and nice [16:47:41] zeljkof: do you need to know if the build failed or not? [16:49:12] GEOFBOT: yes :) [16:49:28] GEOFBOT: sorry, that is the most important thing, forgot to say that [16:55:50] zeljkof: we don't need a description tho, right? [16:56:09] GEOFBOT: description of what? [16:56:29] the build description [16:56:35] i don't htink anybody reall yuses that here [16:56:38] what is that? :) [16:56:42] let me see [16:56:57] https://wmf.ci.cloudbees.com/view/fs/job/free-style-UniversalLanguageSelector-commons.wikimedia.beta.wmflabs.org-linux-phantomjs-parallel/lastCompletedBuild/testReport/ [16:56:59] if you look in the cod [16:57:06] you will see a "description" [16:57:08] but its empty [16:57:08] cod? [16:57:13] *code sorry :P [16:57:17] oh :) [16:57:33] yes, looks like we do not use it at all, just remove it from the template [17:07:42] zeljkof: i have the color bar set up :D [17:07:44] now for the text [17:07:54] GEOFBOT: you can remove the color bar :) [17:07:59] sorry, forgot to say that [17:08:12] zeljkof: do you need the stack traces? [17:08:21] well, feel free to leave it in, but that is completely optional (color bar) [17:08:34] GEOFBOT: stack traces? for each failed test? [17:08:39] yes [17:08:46] no, just the link to the page that has the stack trace [17:08:50] like it is on the results page [17:08:59] https://wmf.ci.cloudbees.com/view/fs/job/free-style-UniversalLanguageSelector-commons.wikimedia.beta.wmflabs.org-linux-phantomjs-parallel/lastCompletedBuild/testReport/ [17:09:23] ah, i see ok [17:09:33] GEOFBOT: the email should be short [17:09:37] but informative [17:09:45] sometimes there are a lot of failed tests [17:09:57] so having stack traces would make the e-mail really long [17:12:32] mayankmadan_: around? [17:12:39] yep [17:12:48] mayankmadan_: I have created 6 jobs https://maddiemadan.ci.cloudbees.com/ [17:12:57] 3 have names that end with master [17:13:28] those 3 will run tests for each site (commons, en.wikipedia, test2) for browsertests repository using phantomjs and the latest commit in master branch [17:13:50] the other 3 tests have names that end in 102634 [17:14:04] those 3 do exactly the same thing [17:14:11] but with one difference [17:14:18] instead of using the latest commit in master branch [17:14:40] they use patch set 11 from commit 102634 [17:14:43] https://gerrit.wikimedia.org/r/#/c/102634/11 [17:14:53] zeljkof, PS11 or latest patchset? [17:15:12] mayankmadan_: I could not find a way to use the latest patch set, so it is hard coded to 11 for now [17:15:17] but it is easy to change [17:15:26] just to go job configuration page, for example [17:15:29] https://maddiemadan.ci.cloudbees.com/job/commons.wikimedia.beta.wmflabs.org-102634/configure [17:15:34] and change [17:15:42] in execute shell box [17:15:47] git fetch https://gerrit.wikimedia.org/r/qa/browsertests refs/changes/34/102634/11 && git checkout FETCH_HEAD [17:15:58] change 11 to 12 or what ever it needs to be [17:16:08] save the configuration and run the job [17:16:18] also, if you decide to use another commit, and abandon this one [17:16:36] you go commit page [17:16:38] for example [17:16:38] https://gerrit.wikimedia.org/r/#/c/102634 [17:17:04] and copy the line from "download" [17:17:08] it is now [17:17:12] git fetch https://gerrit.wikimedia.org/r/qa/browsertests refs/changes/34/102634/11 && git checkout FETCH_HEAD [17:17:21] do you understand how it works? [17:18:06] yes [17:18:15] excellent [17:18:24] you can do exactly the same thing on your machine [17:18:35] but jenkins makes it easy to share the results with other peope [17:18:36] people [17:18:58] cloudbees people helped me to fix phantomjs install, so that should work now too [17:19:31] zeljkof: last thing, do you need the "all tests" table? [17:20:03] GEOFBOT: if it is not hard to put in, it would be nice to have, since it is short [17:20:16] if it is complicated to put in the template, skip it [17:24:39] zeljkof: ill add it, but im not sure how to include the diff part, so ill skip it [17:24:40] mayankmadan_: so in short, when all three 102634 jobs are green, your job is done :) [17:25:06] GEOFBOT: yes, what ever is hard to do, just skip it :) [17:25:26] the list of failed tests is all we need, else is nice to have, but not urgent for now [17:39:27] zeljkof: do you happen to know how to stretch a table accross the full page width ;)? [17:40:30] zeljkof: nvmd, got it [17:43:58] GEOFBOT: it think it is something like witdth=100% :) [17:45:19] zeljkof: im including the color bar because it looks cool :P [17:45:24] sending a sample [17:45:27] GEOFBOT: great :) [17:45:46] it looks really nice, but sometimes things like that are hard to do [17:46:00] sent [17:46:37] zeljkof: oops [17:46:41] wrong template used [17:46:42] sorry [17:47:31] GEOFBOT: :) [17:47:33] no problem [17:51:31] zeljkof: ok, sent for real this time :P [17:52:27] GEOFBOT: great [17:53:54] zeljkof: i should clean the code up first this time :P [17:57:39] just make it work :) [17:57:54] but clean code is appreciated :) [17:59:27] zeljkof, im gonna start doing the phantomjs tagging task [17:59:34] mayankmadan_: great [18:02:33] GEOFBOT: got the e-mail, looks great! :) [18:03:08] GEOFBOT: do you know how to push code to gerrit? [18:03:15] zeljkof: yes [18:03:36] GEOFBOT: could you please push the template to this repo https://gerrit.wikimedia.org/r/#/admin/projects/mediawiki/selenium [18:03:43] zeljkof: sure [18:03:58] into this folder [18:03:58] https://git.wikimedia.org/tree/mediawiki%2Fselenium/21a3b274a7de1c698196b88aa74348ef4166fc4a/docs [18:04:14] this is where jenkins docs are [18:04:35] if you push in the next few hours, I will take a look and close the task [18:05:50] zeljkof: silly tidy2 doesn't work for groovy lol [18:05:55] i will just use the dirty code [18:05:58] if that isn't a problem [18:07:05] zeljkof, why does the PS11 have only 4 modified files? [18:07:13] GEOFBOT: nobody knows groovy anyway :) [18:07:15] look at ps10 then ps11 [18:07:26] mayankmadan_: I do not know what you did :) [18:08:46] mayankmadan_: looks like you messed up when committing ps 11 :) [18:09:17] damn [18:09:54] zeljkof, should i start with a new patch? [18:10:05] GEOFBOT: let me know when you push the template, I would like to send it to cloudbees asap :) [18:10:12] mayankmadan_: what ever you prefer [18:10:24] do you know you can download ps 10 to your machine? [18:10:32] if that is where you want to continue? [18:10:40] zeljkof, that would be better [18:11:31] mayankmadan_: this page should have the docs on how to do it [18:11:31] http://www.mediawiki.org/wiki/Gerrit/git-review [18:11:34] if not, let me know [18:11:42] probably this [18:11:42] http://www.mediawiki.org/wiki/Gerrit/git-review#Downloading_a_change_with_git-review [18:12:01] zeljkof, shouldnt i just do git fetch ssh://mayankmadan@gerrit.wikimedia.org:29418/qa/browsertests refs/changes/34/102634/10 && git checkout FETCH_HEAD [18:12:17] probably something like git review -d commit_number/patchset_number [18:12:25] git review -d 1234/12 [18:12:57] ok [18:13:08] or here [18:13:09] http://www.mediawiki.org/wiki/Gerrit/Advanced_usage [18:16:01] zeljkof, how do i download a particular patchset of a commit using git review -d ? [18:17:01] this? git review -d 1234/12 [18:17:09] zeljkof, doesnt work [18:17:17] hm [18:17:26] I do not know then [18:17:31] there is probably a way [18:17:37] but git fetch should also work [18:18:47] ok [18:19:15] but git fetch will create a strange state of your repo [18:19:19] then just create a branch [18:19:33] git checkout -b branch-name [18:19:46] zeljkof: i named it jenkins-email.template, is that ok? [18:19:46] so you can do git review from there [18:20:13] GEOFBOT: sounds good to me :) [18:20:46] (03PS1) 10Sn1per: Add jenkins email template for better email notifications [selenium] - 10https://gerrit.wikimedia.org/r/103114 [18:21:22] zeljkof: shoot, there are dos line endings on there! [18:21:23] lol [18:21:24] sigh [18:21:47] GEOFBOT: how come? [18:22:13] zeljkof: i edited it on windows and forgot to run dos2unix before uplaoding ;) [18:22:21] GEOFBOT: oh [18:22:38] GEOFBOT: please also add bug number to commit message [18:23:20] (03PS2) 10Sn1per: Add jenkins email template for better email notifications [selenium] - 10https://gerrit.wikimedia.org/r/103114 [18:24:07] (03PS3) 10Sn1per: Add jenkins email template for better email notifications [selenium] - 10https://gerrit.wikimedia.org/r/103114 [18:24:41] zeljkof: is patchset3 good? [18:25:06] GEOFBOT: looking [18:27:02] GEOFBOT: looks good to me [18:27:11] will ask cloudbees to upload it [18:27:14] and test it there [18:28:40] Yippee, build fixed! [18:28:42] Project browsertests-en.wikipedia.beta.wmflabs.org-linux-firefox build #528: FIXED in 18 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-linux-firefox/528/ [18:29:24] GEOFBOT: sent templated to cloudbees, they will probably upload it on Monday [18:29:30] so I will be able to test it then [18:29:31] zeljkof: cool, thanks [18:29:54] GEOFBOT: I will close the task right now, so you can work on something else, the e-mail I got from your jenkins looks good to me [18:30:17] zeljkof: ok, thanks for your help [18:30:41] GEOFBOT: no problem, thanks for working with us :) [18:33:38] zeljkof, timed out after 5 seconds, waiting for {:title=>/Your user page/, :tag_name=>"a"} to become present (Watir::Wait::TimeoutError) [18:33:38] ./features/step_definitions/login_steps.rb:51:in `/^there should be a link to (.+)$/' [18:33:39] features/login.feature:47:in `Then there should be a link to Selenium user' [18:33:46] this error is just because of different username [18:34:02] i should ignore it right [18:34:16] if i use Selenium user it is going to work [18:34:50] mayankmadan_: tag it with @needs-custom-setup (or something like that) there is similar tag in the code [18:36:29] zeljkof, timed out after 5 seconds, waiting for {:text=>"Yes", :tag_name=>"span"} to become present (Watir::Wait::TimeoutError) [18:36:30] ./features/step_definitions/aftv5_steps.rb:38:in `block (2 levels) in ' [18:36:30] ./features/step_definitions/aftv5_steps.rb:37:in `/^AFTv5 should be there$/' [18:36:30] features/aftv5.feature:20:in `Then AFTv5 should be there' [18:36:43] jenkins is showing this error but i cant produce it on my machine [18:36:45] zeljkof, ^ [18:37:54] mayankmadan_: I really can not look into this now, in the middle of something else [18:38:06] I am not sure what the problem is [18:38:19] okay np [19:16:20] Yippee, build fixed! [19:16:21] Project browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_8 build #433: FIXED in 25 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_8/433/ [19:21:13] Project browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_9 build #460: FAILURE in 24 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_9/460/ [20:00:51] Yippee, build fixed! [20:00:52] Project browsertests-test2.wikipedia.org-windows-internet_explorer_10 build #353: FIXED in 26 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-windows-internet_explorer_10/353/ [20:30:11] Yippee, build fixed! [20:30:11] Project browsertests-test2.wikipedia.org-windows-internet_explorer_7 build #614: FIXED in 29 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-windows-internet_explorer_7/614/ [20:37:00] Project browsertests-test2.wikipedia.org-windows-internet_explorer_8 build #634: FAILURE in 28 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-windows-internet_explorer_8/634/ [20:59:43] Yippee, build fixed! [20:59:44] Project Flow-en.wikipedia.beta.wmflabs.org-linux-chrome build #129: FIXED in 5 min 45 sec: https://wmf.ci.cloudbees.com/job/Flow-en.wikipedia.beta.wmflabs.org-linux-chrome/129/ [21:11:23] Project Flow-test2-wikipedia-org-linux-chrome build #24: FAILURE in 5 min 13 sec: https://wmf.ci.cloudbees.com/job/Flow-test2-wikipedia-org-linux-chrome/24/ [21:48:01] Yippee, build fixed! [21:48:01] Project MobileFrontend-test2.m.wikipedia.org-linux-firefox build #154: FIXED in 16 min: https://wmf.ci.cloudbees.com/job/MobileFrontend-test2.m.wikipedia.org-linux-firefox/154/ [21:57:33] Yippee, build fixed! [21:57:34] Project TwnMainPage-sandbox.translatewiki.net-linux-firefox build #138: FIXED in 9 min 31 sec: https://wmf.ci.cloudbees.com/job/TwnMainPage-sandbox.translatewiki.net-linux-firefox/138/