[05:32:36] Project browsertests-test2.wikipedia.org-windows-internet_explorer_7 build #619: FAILURE in 29 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-windows-internet_explorer_7/619/ [07:00:35] Project TwnMainPage-sandbox.translatewiki.net-linux-firefox build #143: FAILURE in 9 min 39 sec: https://wmf.ci.cloudbees.com/job/TwnMainPage-sandbox.translatewiki.net-linux-firefox/143/ [07:38:55] yurik, online? [07:39:02] mayankmadan, nope [07:39:38] yurik, are you leaving? [07:39:49] i should, but i'm not :) [07:40:48] i dont know what that means :) [07:41:33] (03PS1) 10Siebrand: Add Jenkins jobs for TwoFactorAuthentication [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/103529 [08:32:50] yurik, still online? :) [08:33:08] mayankmadan, sadly, yes :) [08:33:14] i should be a sleep long ago :) [08:33:18] what's up! [08:33:28] yurik, You were talking about some c# tasks? [08:34:02] oh, well, i was wondering if it was possible to allow selenium driver to actually pass headers around [08:36:49] yurik, pass headers around? [08:37:04] the same as you did for phantom js [08:37:07] but in a generacl case [08:37:28] i dont get what pass around means? [08:37:49] pass headers around? [08:38:11] setting headers via webdriver in all the supported browsers [08:38:15] on the requset [08:40:26] oh [08:40:41] https://code.google.com/p/selenium/ [08:41:43] yurik, how is it different from what i did earlier [08:41:59] what you did supports just one browser - phantomJS [08:42:06] (which is not exactly a browser) [08:42:25] selenium allows a web site to be tested with ANY browser at all [08:44:57] ok [08:45:10] its not a trivial task... far from it :) [08:45:11] but its tricky to set headers on chrome and firefox [08:45:40] according to their dev, the trickies one is safari, followed by IE, while chrome is the easiest :) [08:45:55] i might have a stab at it at one point... :) [08:45:59] some day :) [08:46:35] yurik, I promise ill do this task but i wanted to do something different so that my chances of becoming one of the 2 grand prize winners will increase [08:47:03] no no, i don't think it's that easy if possible at all [08:47:26] i am not sure its even part of that [08:47:32] its a different project alltogether [08:47:41] i'm not sure about the prizes tell you the truth [08:47:45] i haven't read up on that [08:49:50] yurik, what is easy? [08:50:03] *what is not easy and not possible at all? [08:50:07] Project VisualEditor-test2.wikipedia.org-linux-firefox build #233: FAILURE in 58 min: https://wmf.ci.cloudbees.com/job/VisualEditor-test2.wikipedia.org-linux-firefox/233/ [08:50:37] selenium driver to support setting headers for all the browsers [08:50:48] oh [08:50:48] there is a huge discussion going on about it [08:51:39] but on the much simpler side, you might want to do testing for our project - develop full test coverage for the zero platform [08:51:55] just like that one test you did, but to ensure that all use-casses are covered [08:52:08] i think adam posted a link to the various configs we were looking at [08:55:30] yurik, where is that link? [08:57:09] https://www.mediawiki.org/wiki/Wikipedia_Zero/Test_cases [08:58:24] yurik, those are cucumber tests [08:58:31] right [08:58:47] can they use your phantomjs work? [08:58:59] yurik, why not? :) [08:59:11] than go for it :) [08:59:12] that way i could show off that my work is a part of something [08:59:28] yurik, but you said you wanted the tests in js [08:59:29] sure ,you will instantly be supporting 600+ million people :) [09:00:19] ^^ [09:00:23] mayankmadan, tell you the truth, as long as i can easily read and change it, i'm ok with whatever. But cucumber seems to be a good way to describe those tests, while providing the backend in any useful system. Also, it must easily be integratable with jenkins [09:00:52] since jenkins does all the continuous integration stuff [09:01:29] yurik, so first the zero repo needs to support cucumber [09:01:36] yep [09:02:49] you are welcome to restructure /test or /tests or however you want to call it :) [09:03:06] i think qa team has a standard for it [09:03:09] yurik, can you make different tasks for that(i kinda wanted to be a grand prize winner for wikimedia too) :) [09:03:42] mayankmadan, i really have no idea about any of the prizes or competitions - i'm just trying to make this world a bit better :) [09:04:01] yurik, you dont know about google code in? [09:04:13] i've heard of the GSOC [09:04:30] but not its structure, prizes, requirements, or any other relevant info [09:04:35] gsoc is for university students, wheras gci is for highschool students [09:04:42] oh, nice [09:04:50] but again - no idea :) [09:05:02] (apparently i know even less than i thought :)) [09:05:20] yurik, can i ask zeljko or jeff hall to make those tasks and then get onto working for zero [09:06:47] only if you dont have a problem [09:07:32] sure thing! [09:07:40] we can always use more help :D [09:09:33] ill get onto zero tests tomorrow [09:12:45] yurik, did you send any messages? [09:12:47] i disconnected so i didnt receive any [09:13:06] no, just said we can always use help :) [09:13:18] :) [09:19:31] yurik, i was thinking about writing the steps in python [09:19:59] mayankmadan_, it all depends on jenkins - if they can easily support it - go for it :) [09:20:04] talk to zelijko [09:25:31] mayankmadan_, and btw, i prefer python 3 if possible :) [09:30:46] ok [12:08:44] (03PS3) 10M4tx: Create additional browser test for Preferences "User Profile" tab [qa/browsertests] - 10https://gerrit.wikimedia.org/r/103497 [13:03:02] (03CR) 10Mayankmadan: [C: 04-1] "preferences_user_profile.rb should be named preferences_user_profile_page.rb" [qa/browsertests] - 10https://gerrit.wikimedia.org/r/103497 (owner: 10M4tx) [13:10:27] (03PS4) 10M4tx: Create additional browser test for Preferences "User Profile" tab [qa/browsertests] - 10https://gerrit.wikimedia.org/r/103497 [14:48:47] hi chrismcmahon [14:58:39] yurik, online? [15:07:33] chrismcmahon, yurik asked me to develop full test coverage for the zero platform [15:07:58] will it be possible for you guys to support python with jenkins [15:11:26] mayankmadan_: I don't know very much about Zero [15:21:25] Yippee, build fixed! [15:21:26] Project browsertests-test2.wikipedia.org-windows-internet_explorer_10 build #359: FIXED in 28 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-windows-internet_explorer_10/359/ [15:31:02] chrismcmahon, online? [16:12:11] JeffHall, yurik asked me to develop full test coverage for the zero platform [16:12:18] will it be possible for you guys to support python with jenkins [16:12:54] mayankmadan: Yes, we're in the process of setting up Python on Jenkins now [16:13:31] JeffHall, so can i add step definitions in python? [16:13:39] and setup cucumber with python too [16:14:03] mayankmadan: no, you won't be able to use Cucumber with python [16:14:11] chrismcmahon, why not? [16:14:51] mayankmadan: you should do some research on google about test frameworks [16:16:35] mayankmadan: There are Cucumber ports to Python, although I've never used them myself - Lettuce seems to be the most popular one [16:19:36] JeffHall, ill rather do it with ruby [16:31:08] mayankmadan: do you understand what Wikipedia Zero is? [16:31:33] chrismcmahon, wikipedia's version for mobile operators which provide free access to wikipedia ? [16:31:48] mayankmadan: and how would you test that? [16:33:19] chrismcmahon, https://www.mediawiki.org/wiki/Wikipedia_Zero/Test_cases [16:37:08] mayankmadan: and where would you test that? [16:37:35] chrismcmahon, i will test that after supplying fake header to phantomjs [16:51:31] chrismcmahon: ? [16:54:39] mayankmadan: I'm in a meeting for a while [16:54:52] ok [17:37:32] JeffHall, http://www.google-melange.com/gci/task/view/google/gci2013/5805605944033280 [17:55:14] hey JeffHall just realized I forgot the [browser test] bit for that commit [17:56:28] chrismcmahon: Ah, well, James is on vacation so he'll never know ;) [17:56:55] heh, works for me [17:57:06] mayankmadan: OK, looks like Quim assigned that GCI task to you [17:58:05] JeffHall, oh yeah [18:49:25] JeffHall, any help with python [18:50:14] mayankmadan: I can try, although I haven't used Python in a while - let me know what your question is [18:53:49] JeffHall, nevermind got it [19:02:22] JeffHall, i am almost done with this python task [19:02:35] mayankmadan_: OK, sounds good [19:02:45] after this im gonna claim the editing tab task [19:02:57] i submitted the patch for that yesterday [19:19:52] Project browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_8 build #438: FAILURE in 26 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_8/438/ [19:31:03] JeffHall, when i try to run upload-wizard_tests.py it says no module named wikitools found [19:31:38] i have written the code for generating new image with timestamp, it just needs to be deployed [19:31:47] but im getting that error whenever i try to run the test [19:36:20] maynakmadan_: You can install that with pip using the requirements file: http://www.pip-installer.org/en/latest/cookbook.html [19:39:00] Project browsertests-test2.wikipedia.org-linux-chrome build #802: FAILURE in 19 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-linux-chrome/802/ [19:43:26] JeffHall, requirements file? [19:43:49] mayankmadan_: requirements.txt [19:44:52] okay [19:46:28] JeffHall, i have added a test for checking for --gen_new_image flag [19:46:33] now how do i implement it? [19:46:44] i need a little help with it [19:49:02] mayankmadan_: You mean adding it to the ArgumentParser? [19:49:11] JeffHall, no i have done that [19:49:33] JeffHall, what do i do after checking if --gen--new--image is true? [19:52:12] mayankmadan_: Generate a new image file with a unique title, so that can be uploaded instead of the default "Test-image-rosa-mx-15x15.png" file [19:52:20] JeffHall, i have written the code which creates the image but where do i deploy it? [19:53:15] JeffHall, that code is in a separate file that i made just for checking [19:54:12] mayankmadan_: I assume the most logical solution is to add a new method to upload-wizard_tests.py [19:54:54] ok but how will i run that method? unittest.TestLoader().loadTestsFromTestCase(TestUploadWizardAPICalls) takes a class as argument [19:54:56] JeffHall, ^ [19:57:43] mayankmadan_: Hmmm… not sure about that, since I've been away from Python for a while. You might want to do a Google search and see what you can come up with [20:06:15] Project browsertests-test2.wikipedia.org-windows-internet_explorer_10 build #360: FAILURE in 27 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-windows-internet_explorer_10/360/ [20:38:37] Yippee, build fixed! [20:38:37] Project browsertests-test2.wikipedia.org-windows-internet_explorer_8 build #640: FIXED in 28 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-windows-internet_explorer_8/640/ [21:01:36] Project Flow-en.wikipedia.beta.wmflabs.org-linux-chrome build #134: FAILURE in 5 min 56 sec: https://wmf.ci.cloudbees.com/job/Flow-en.wikipedia.beta.wmflabs.org-linux-chrome/134/ [21:09:08] Project Flow-en.wikipedia.beta.wmflabs.org-linux-firefox build #131: FAILURE in 7 min 30 sec: https://wmf.ci.cloudbees.com/job/Flow-en.wikipedia.beta.wmflabs.org-linux-firefox/131/ [21:11:06] Yippee, build fixed! [21:11:06] Project browsertests-test2.wikipedia.org-windows-internet_explorer_9 build #675: FIXED in 35 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-windows-internet_explorer_9/675/ [22:01:23] Yippee, build fixed! [22:01:24] Project TwnMainPage-sandbox.translatewiki.net-linux-firefox build #144: FIXED in 10 min: https://wmf.ci.cloudbees.com/job/TwnMainPage-sandbox.translatewiki.net-linux-firefox/144/ [22:02:49] hi JeffHall [22:02:55] i have finally completed the task [22:03:29] without any help(except installing wikitools using pip) [22:05:44] JeffHall, http://www.google-melange.com/gci/task/view/google/gci2013/5805605944033280 [22:05:46] i have done it [22:05:49] can you close it [22:06:00] JeffHall, review it first? :) [22:07:14] mayankmadan_: Yep, will review here in a few minutes [22:07:28] ok [22:13:28] JeffHall, im gonna go now as its getting really late but please review my tasks :) [22:13:53] mayankmadan_: OK, will do [22:13:59] thanks [22:58:03] JeffHall: gah https://wmf.ci.cloudbees.com/job/VisualEditor-en.wikipedia.beta.wmflabs.org-linux-chrome/231/testReport/junit/(root)/VisualEditor%20general%20text%20markup%20features/VisualEditor_general_markup__outline_example_____Computer_Code____code_This_is_a_new_line__code____/ [22:58:16] JeffHall: failed to dismiss the beta warning [22:59:48] JeffHall: at $DayJob-2 we had method called click_up_to_times() that accepted any numeric value and would attempt to click that element over and over again for that many times without any errors or complaints. we might need one of those. [23:00:09] chrismcmahon: Let me look at that one... [23:03:31] chrismcmahon: Yeah, that's annoying - that never seems to happen when the tests are run locally, but adding a click_up_to_times() method sounds like a good solution! [23:07:19] chrismcmahon: So I assume that we would want such a new method to live in the mediawiki-selenium gem? [23:09:54] JeffHall: we might want to implement it locally first. even so, it's kind of dumb; a last-ditch effort to dismiss stuff you really don't care about (lemme tell you about $DayJob-2...) [23:13:21] chrismcmahon: Actually, couldn't we just handle that beta warning window via the Selenium "alert" method that we were looking at this morning? [23:14:31] JeffHall: not really, it is not an actual js alert, it is a wholly rendered page inside an iframe. [23:14:55] chrismcmahon: Ah, yeah - you're right - just looking at that now [23:18:29] JeffHall: I would like to influence the VE dev effort toward good design, which is why I resist the click_up_to_times() paradigm, but that is a singular case. [23:20:27] chrismcmahon: Yeah, and that beta warning isn't exactly core functionality for VE, so implementing a workaround method seems like a reasonable approach [23:20:45] JeffHall: yep [23:24:29] chrismcmahon: OK, I can work on implementing a click_up_to_times() method (just for the VE repo at this point) [23:26:52] JeffHall: fwiw, https://www.google.com/search?q=click_up_to_times [23:28:21] JeffHall: I are old: http://chrismcmahonsblog.blogspot.com/2009/12/selenesse-nee-webtest.html [23:30:54] chrismcmahon: Very cool! Looks like the logic is all there in SlimSeleniumDriver.java [23:31:38] JeffHall: open source ftw [23:41:51] Yippee, build fixed! [23:41:51] Project browsertests-commons.wikimedia.beta.wmflabs.org-linux-chrome build #548: FIXED in 3 min 32 sec: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-linux-chrome/548/ [23:51:07] JeffHall: I think what we're looking at is just... [23:51:25] begin [23:51:26] page.beta_warning_element.when_present.click [23:51:26] rescue [23:51:26] end [23:52:00] wrap that in a '10.times do' where '10' is a variable [23:52:20] chrismcmahon: Yeah, that seems to make sense