[03:27:35] Project browsertests-en.wikipedia.beta.wmflabs.org-linux-chrome build #570: FAILURE in 17 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-linux-chrome/570/ [03:53:16] Yippee, build fixed! [03:53:16] Project browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_10 build #384: FIXED in 25 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_10/384/ [04:23:13] Project browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_9 build #476: FAILURE in 24 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_9/476/ [05:07:10] Yippee, build fixed! [05:07:11] Project browsertests-test2.wikipedia.org-windows-internet_explorer_10 build #371: FIXED in 27 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-windows-internet_explorer_10/371/ [05:38:48] Yippee, build fixed! [05:38:49] Project browsertests-test2.wikipedia.org-windows-internet_explorer_7 build #631: FIXED in 31 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-windows-internet_explorer_7/631/ [06:13:44] Project browsertests-test2.wikipedia.org-windows-internet_explorer_9 build #686: FAILURE in 34 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-windows-internet_explorer_9/686/ [06:29:07] Project MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome build #167: FAILURE in 16 min: https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/167/ [06:54:34] Yippee, build fixed! [06:54:34] Project TwnMainPage-sandbox.translatewiki.net-linux-firefox build #155: FIXED in 9 min 43 sec: https://wmf.ci.cloudbees.com/job/TwnMainPage-sandbox.translatewiki.net-linux-firefox/155/ [07:42:42] yurik, online? [08:20:34] Project VisualEditor-en.wikipedia.beta.wmflabs.org-linux-firefox build #249: FAILURE in 1 hr 11 min: https://wmf.ci.cloudbees.com/job/VisualEditor-en.wikipedia.beta.wmflabs.org-linux-firefox/249/ [08:53:54] zeljkof, hi [08:54:20] mayankmadan: hi [08:55:10] zeljkof, how about implementing these tests? https://www.mediawiki.org/wiki/Wikipedia_Zero/Test_cases [08:55:22] in ZeroRatedAccess [09:00:29] just a minute, have to finish something [09:00:39] no problem [09:11:15] zeljkof, ping me when you are done [09:19:04] mayankmadan_: ok, I am back [09:22:49] mayankmadan_: can you send me the link to the task you are working on? [09:22:57] zeljkof, im not working on it [09:23:15] zeljkof, i had a talk with yurik [09:24:44] mayankmadan_: and? [09:24:52] just a second [09:27:05] zeljkof, he said that it would be good to develop full test coverage for the zero platform [09:27:26] zeljkof, and that would make some good tasks on melange [09:28:07] mayankmadan_: ok, makes sense [09:28:16] are you working on another task right now? [09:28:27] zeljkof, i am but it will be over soon [09:29:08] ok [09:29:17] I just came from vacation, have to catch up a bit [09:29:25] no problem [09:29:35] I can read the wiki page and create the task today, sounds good? [09:29:42] no [09:29:45] zeljkof, no [09:30:04] zeljkof, cant it be more that 1 task? [09:30:33] mayankmadan_: ok, I have to read the wiki page [09:30:41] I do not know how big task that is [09:31:17] mayankmadan_: I need 2-3 hours to catch up on email, is that too late for you? [09:31:34] zeljkof, no [09:31:55] mayankmadan_: I will be online for the next 6-8 hours, so we will figure out something today [09:32:08] how long will you be awake? [09:37:27] zeljkof, i live in utc+5:30 [09:37:57] zeljkof, and i will be awake for a long time today [09:38:09] mayankmadan_: code-in ends in a few days, right? [09:38:19] zeljkof, 1 week [09:38:31] and im slipping with the number of tasks [09:39:40] mayankmadan_: are you in the top 5? [09:39:45] zeljkof, yes [09:39:48] im 2nd [09:39:55] as far as I remember, that is the only important thing [09:40:22] mayankmadan_: you do not have to be the first to get elected as a winner, you know that, right? [09:40:25] zeljkof, but if i dont do more complex tasks, i wont have good chances [09:40:30] yes i know that [09:40:49] if you want complex tasks, why do you want small tasks? :) [09:40:59] so there are both a lot of tasks and they are hard? [09:41:35] zeljkof, i want lot of hard tasks :) [09:41:41] for now [09:41:52] mayankmadan_: but hard tasks take time to finish, right? [09:41:57] zeljkof, yep [09:42:00] remember phantomjs task? [09:42:04] yes [09:42:12] it took you days to just get started [09:42:21] you do not have time for a lot of those, right' [09:42:22] ? [09:42:24] just a few [09:43:46] zeljkof, but if i work really hard, maybe i can finish them quickly [09:44:15] mayankmadan_: well, you can try :) [09:44:48] zeljkof, the thing is that im really sick right now, severely dehydrated, high grade fever, swollen left eye, so i really wanted to make sure that i work hard [09:45:26] mayankmadan_: I think you should take at least a day or two and rest [09:45:35] zeljkof, no chance :) [09:45:57] lets setup the testing environment for wikipedia zer [09:46:00] *zero [09:46:02] zeljkof, ^ [09:46:27] mayankmadan_: I do not know how to do that [09:46:34] I have never tested zero [09:46:40] do you need help with that? [09:56:59] sorry i disconnected [09:57:11] zeljkof, did you send any messages [09:57:46] you can see the channel log here :) http://bots.wmflabs.org/~wm-bot/logs/%23wikimedia-qa/ [09:57:53] I am not sure what you saw last [09:58:39] zeljkof, yes i do [09:58:49] zeljkof, can i use https://rubygems.org/gems/browsermob-proxy [09:58:56] to fake headers in chrome? [09:59:00] mayankmadan: for what? [09:59:04] I see [09:59:17] feel free to try :) [09:59:24] zeljkof, like in the first faking headers task, i did it for phantomjs [09:59:24] I have not used the gem myself [09:59:40] why don't you use phantomjs? [09:59:50] since you know how to send custom headers with it? [10:00:07] zeljkof, yurik said that it needs to be implemented for chrome too [10:00:21] ok [10:00:28] zeljkof, ill ping you to create more tasks when im done with the current one [10:00:29] did you see a -1 for this commit? [10:00:30] https://gerrit.wikimedia.org/r/#/c/98160/ [10:01:36] zeljkof, the patch looks fine to me [10:01:51] mayankmadan: there is deprecation warning [10:01:58] do you see the last comment? [10:02:24] zeljkof, but it fails on chrome [10:02:28] i dont get it [10:03:04] ok, can you leave a comment then asking for more information [10:03:33] Jeff left -1, I did not have the time to review it yet [10:03:38] (03CR) 10Mayankmadan: "Can you provide some more information" [qa/browsertests] - 10https://gerrit.wikimedia.org/r/98160 (owner: 10Mayankmadan) [10:04:03] zeljkof, it is counted as complex to implement those tests, right? [10:04:31] mayankmadan: I am not sure what are you referring to? pdf tests? [10:04:37] zeljkof, yes [10:05:09] mayankmadan: I have no idea how the tasks will be judged [10:05:17] okay [10:05:22] I do not think I will be judging them [10:05:33] zeljkof, the mentors judge them [10:05:40] but yes, I think that was a complex task [10:05:49] thanks [15:08:38] mayankmadan_: so you have already finished this task? http://www.google-melange.com/gci/task/view/google/gci2013/5226543420801024 [15:08:58] without claiming it? [15:09:12] (catching up) [15:09:13] zeljkof, i havent done anything with that task [15:09:29] zeljkof, havent even commented on it [15:09:41] mayankmadan_: ? https://gerrit.wikimedia.org/r/#/c/103411/ [15:09:59] did you commit that? [15:10:04] zeljkof, i tried working on this but there were a lot of duplicate id's [15:10:07] ids [15:10:11] which shouldnt be there [15:10:18] cause ids are unique [15:10:53] mayankmadan_: ok, so that commit is work in progress? [15:10:58] kind of [15:11:00] or it should be abandonoed? [15:11:05] abandoned [15:11:17] abandoning it should be the best [15:11:27] mayankmadan_: ok, can you please abandon it then? [15:13:00] mayankmadan_: I have to do some cleanup before we can continue [15:14:47] (03PS30) 10Zfilipin: Added a test for downloading pdf from a random page [qa/browsertests] - 10https://gerrit.wikimedia.org/r/98160 (owner: 10Mayankmadan) [15:38:59] (03CR) 10Zfilipin: [C: 04-1] "When I run the tests using Firefox, there is one deprecation warning:" [qa/browsertests] - 10https://gerrit.wikimedia.org/r/98160 (owner: 10Mayankmadan) [15:39:12] mayankmadan_: ^ [15:39:34] zeljkof, but what about the failure on chrome [15:39:45] mayankmadan_: first things first :) [15:39:57] could you please abandon this commit? https://gerrit.wikimedia.org/r/#/c/103411/ [15:40:03] if you do not plan to work on it [15:40:40] and could you please get rid of deprecation warning for firefox here? https://gerrit.wikimedia.org/r/#/c/98160/ [15:40:55] okay [15:40:59] I am now testing the commit with chrome, I will leave comments for it as the tests are done [15:41:35] mayankmadan_: apologies for the delay, but I have to do some cleanup before we start with new tasks [15:41:47] okay [15:42:15] zeljkof, the chrome tests should only run on chrome [15:42:27] zeljkof, but they'll run on every browser [15:42:30] mayankmadan_: I am not sure what you mean by that [15:42:45] console output or it did not happen :) [15:43:03] zeljkof, the tests made specifically for the chrome should be only run on chrome [15:43:19] mayankmadan_: how do I know which tests are made only for chrome? [15:43:23] i.e there should be a check for ENV["BROWSER_LABEL"] [15:43:32] mayankmadan_: no no no :) [15:43:37] that is not how we do it [15:43:50] hello zeljkof, I hope you had a nice holiday [15:43:58] chrismcmahon: hi :) [15:44:09] holiday was really nice [15:44:38] chrismcmahon: could you take a look at this? https://gerrit.wikimedia.org/r/#/c/102209/ [15:44:49] zeljkof: quick question: have you ever used the @random_string value in a page.rb file? [15:44:53] chrismcmahon: and merge it if it looks good [15:45:06] chrismcmahon: I do not think that would work [15:45:18] (03PS2) 10Cmcmahon: Replacing single quotes with double quotes [selenium] - 10https://gerrit.wikimedia.org/r/102209 (owner: 10Zfilipin) [15:45:23] instance variables defined in steps are only available in steps [15:45:26] not in pages [15:45:30] (03CR) 10Cmcmahon: [C: 032] "maintenance" [selenium] - 10https://gerrit.wikimedia.org/r/102209 (owner: 10Zfilipin) [15:45:41] you have to pass the value to the page as an method argument [15:46:26] (03CR) 10Zfilipin: "Mayankmadan said he will abandon this commit." [qa/browsertests] - 10https://gerrit.wikimedia.org/r/103411 (owner: 10Mayankmadan) [15:48:15] Yippee, build fixed! [15:48:16] Project VisualEditor-en.wikipedia.beta.wmflabs.org-linux-firefox build #250: FIXED in 1 hr 11 min: https://wmf.ci.cloudbees.com/job/VisualEditor-en.wikipedia.beta.wmflabs.org-linux-firefox/250/ [15:53:37] mayankmadan_: can you abandon this? https://gerrit.wikimedia.org/r/#/c/103411/ [15:53:41] just to get started [15:53:46] (if you do not plan to work on it) [15:53:57] to get started with the cleanup [15:54:09] (03Abandoned) 10Mayankmadan: Additional browsertest for gadgets tab in preferences [qa/browsertests] - 10https://gerrit.wikimedia.org/r/103411 (owner: 10Mayankmadan) [15:54:31] mayankmadan_: thanks :) [15:56:03] (03CR) 10Zfilipin: "When running the tests in Chrome, I get this:" [qa/browsertests] - 10https://gerrit.wikimedia.org/r/98160 (owner: 10Mayankmadan) [15:56:41] mayankmadan_: see ^ for Chrome test run (for pdf tests) [15:56:49] zeljkof, all the tests wont run on chrome [15:56:57] mayankmadan_: why? [15:57:03] zeljkof, only the tests specified for chrome will run on chrome [15:57:38] mayankmadan_: how do I know which tests should run on chrome? [15:58:06] zeljkof, the scenarios which have "chrome" in the end are for chrome [15:58:16] ok, let me see [16:03:28] zeljkof: let me know if you have time to talk about using the @random_string in a page element definition. I'll play with it, but I am not sure I know how to do this properly. [16:03:43] chrismcmahon: I have time now [16:03:51] can you push the code to gerrit? [16:03:53] what you have so far [16:04:03] and make a comment on where you need random string [16:04:18] zeljkof: sure, one moment... [16:07:17] zeljkof: https://gerrit.wikimedia.org/r/#/c/104513 [16:07:25] mayankmadan_: ok, so just the last two scenarios should work in chrome? https://gerrit.wikimedia.org/r/#/c/98160/30/features/pdf.feature [16:07:40] yes [16:08:30] mayankmadan_: ok, that is not good :) [16:08:42] chrismcmahon: will comment inline [16:08:46] zeljkof, it was good when we were doing that task :) [16:08:51] thanks zeljkof [16:09:22] mayankmadan_: ok, I am not sure what the goal of the task was [16:09:38] zeljkof, to implement the pdf tasks for chrome [16:09:48] zeljkof, because its a little different with chrome [16:10:39] mayankmadan_: ok, just a second to comment on chrismcmahon's commit [16:12:39] chrismcmahon: commented at https://gerrit.wikimedia.org/r/#/c/104513/ [16:12:47] mayankmadan_: let me see the task [16:13:38] zeljkof: aha, thank you, I hadn't seen that, it makes sense [16:21:50] aha, actually, I have a better idea than using @random_string [16:28:03] chrismcmahon: ok, have to go for today [16:28:06] talk to you tomorrow [16:28:18] bye zeljkof see you [18:29:02] Yippee, build fixed! [18:29:03] Project browsertests-en.wikipedia.beta.wmflabs.org-linux-chrome build #571: FIXED in 18 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-linux-chrome/571/ [19:22:03] Project browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_8 build #450: FAILURE in 27 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_8/450/ [19:41:41] Project browsertests-test2.wikipedia.org-linux-chrome build #814: FAILURE in 19 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-linux-chrome/814/ [19:47:53] manybubbles: me should take a closer look, but this might be a regression bug in Search that just went to test2wiki: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-linux-chrome/lastCompletedBuild/testReport/(root)/Search/Search_with_accent_yields_result_page_with_accent/ [19:48:54] manybubbles: low priority though, it doesn't prevent search, it just shows slightly different results than it used to [19:49:34] chrismcmahon: huh [19:49:41] I think that behavior isn't new [19:50:08] manybubbles: I only just now saw the failure, have not looked very close yet [19:50:25] yeah [19:50:34] we've always flattened accents there [19:50:51] I * think* [19:54:52] Project browsertests-test2.wikipedia.org-linux-firefox build #789: FAILURE in 24 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-linux-firefox/789/ [20:07:08] manybubbles: fwiw, that test is passing locally for me now [20:07:31] huh [20:07:38] I wonder.... [20:07:45] the thing is, that is ordered by the number of incoming links [20:07:49] I wonder if I trashed that somehow [20:09:48] Project browsertests-test2.wikipedia.org-windows-internet_explorer_10 build #372: FAILURE in 28 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-windows-internet_explorer_10/372/ [20:11:12] eh, I'm a goof. manybubbles it passes on beta, fails on test2wiki [20:41:04] Project browsertests-test2.wikipedia.org-windows-internet_explorer_7 build #632: FAILURE in 31 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-windows-internet_explorer_7/632/ [20:54:47] Project browsertests-test2.wikipedia.org-windows-internet_explorer_8 build #652: FAILURE in 30 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-windows-internet_explorer_8/652/ [21:02:11] (03PS3) 10Cmcmahon: WIP Script to create new article with random page title [qa/browsertests] - 10https://gerrit.wikimedia.org/r/103764 (owner: 10Jhall) [21:28:13] Project MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome build #169: FAILURE in 9 min 24 sec: https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/169/ [21:34:26] Project MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox build #256: FAILURE in 9 min 0 sec: https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox/256/ [23:00:10] (03PS4) 10Jhall: WIP Script to create new article with random page title [qa/browsertests] - 10https://gerrit.wikimedia.org/r/103764 [23:00:56] (03PS5) 10Jhall: WIP Script to create new article with random page title [qa/browsertests] - 10https://gerrit.wikimedia.org/r/103764