[00:24:32] <spagewmf>	 chrismcmahon: re "do you want to revert the bit with BROWSER_LABEL?" No. Do you know how to access the browser_label object from within a test?
[00:25:35] <chrismcmahon>	 spagewmf: yes, but I'll have to change the scope of what is now a local variable across a lot of code to do it. 
[00:27:09] <spagewmf>	 OK, I'll propose a simpler patch in the meantime.  ( ENV['BROWSER_LABEL'] || 'some Selenium browser' )
[00:27:58] <chrismcmahon>	 spagewmf: actually, I'll revert that change and file a bug to do it properly.  In the meantime, if the browser is Chrome it edits the second topic on the page and any other browser edits the first topic. 
[00:48:43] <spagewmf>	 chrismcmahon: Yes I saw that, it took me a while to figure out what it's doing.  https://gerrit.wikimedia.org/r/#/c/104785/ adds comment
[00:48:54] <chrismcmahon>	 spagewmf: just merged that
[00:49:30] <spagewmf>	 too fast for me
[00:49:38] <chrismcmahon>	 :-)
[00:50:43] <chrismcmahon>	 spagewmf:  at some point I guess we'll be able to control Flow-able pages in a more configurable way
[00:51:28] <spagewmf>	 FWIW edit_existing passes for me with ( ENV['BROWSER_LABEL'] || 'some Selenium browser' ), http://ee-flow.wmflabs.org/wiki/Talk:Flow_QA . Some whitespace would be nice :)
[00:52:10] <chrismcmahon>	 spagewmf: OK, that's fine by me
[00:54:07] <spagewmf>	 chrismcmahon: you mean which pages are Flow boards?  Yes, it's on the list.  LiquidThreads uses {{#useliquidthreads:1}} in an otherwise regular page, so the page is a hybrid
[00:54:28] <chrismcmahon>	 spagewmf: nice, that will be helpful down the line. 
[00:58:44] <spagewmf>	 it's actually an insane amount of work to have a "page" that isn't a page of wikitext. Special:Import/Export, RecentChanges, watchlists, notifications, abuse and spam filters, bots, Special:WhatLinksHere, redlinks, #REDIRECTs ... so many things.
[01:01:20] <chrismcmahon>	 spagewmf: for sure.  at some point maybe we could pair-program one of these Flow tests.  I don't see any likely candidates right now at https://mingle.corp.wikimedia.org/projects/flow , but it might be a good exercise. 
[01:07:35] <spagewmf>	 chrismcmahon: I update the devs on the browser tests, but they're not sure what additional tests to have. "Make sure Flow pages work" :)  The bugs we've had are more low-level bad data, parsing [[Funny|stuff}}, etc. The browser tests could use "harder" input like <Déjà vu 北京 <tag & "OK" 'end' [[Main_Page|main]] {{SITENAME}}> to be more of a stress test
[01:14:50] <chrismcmahon>	 spagewmf: on beta labs just now:  PHP fatal error in /data/project/apache/common-local/php-master/extensions/Flow/includes/Redlinker.php line 285: 
[01:14:50] <chrismcmahon>	 Argument 1 passed to Flow\Redlinker::getInnerHtml() must be an instance of DOMNode, null given, called in /data/project/apache/common-local/php-master/extensions/Flow/includes/Redlinker.php on line 222 and defined
[03:27:23] <wmf-selenium-bot>	 Yippee, build fixed!
[03:27:24] <wmf-selenium-bot>	 Project browsertests-en.wikipedia.beta.wmflabs.org-linux-chrome build #574: FIXED in 17 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-linux-chrome/574/
[03:51:32] <wmf-selenium-bot>	 Yippee, build fixed!
[03:51:33] <wmf-selenium-bot>	 Project browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_10 build #388: FIXED in 24 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_10/388/
[03:56:54] <wmf-selenium-bot>	 Yippee, build fixed!
[03:56:55] <wmf-selenium-bot>	 Project browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_7 build #451: FIXED in 28 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_7/451/
[04:21:25] <wmf-selenium-bot>	 Project browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_9 build #480: FAILURE in 24 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_9/480/
[04:43:17] <wmf-selenium-bot>	 Project browsertests-test2.wikipedia.org-linux-firefox build #792: FAILURE in 21 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-linux-firefox/792/
[05:33:01] <wmf-selenium-bot>	 Yippee, build fixed!
[05:33:02] <wmf-selenium-bot>	 Project browsertests-test2.wikipedia.org-windows-internet_explorer_7 build #635: FIXED in 30 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-windows-internet_explorer_7/635/
[06:41:52] <wmf-selenium-bot>	 Yippee, build fixed!
[06:41:52] <wmf-selenium-bot>	 Project TwnMainPage-sandbox.translatewiki.net-linux-firefox build #160: FIXED in 11 min: https://wmf.ci.cloudbees.com/job/TwnMainPage-sandbox.translatewiki.net-linux-firefox/160/
[06:49:24] <wmf-selenium-bot>	 Yippee, build fixed!
[06:49:25] <wmf-selenium-bot>	 Project UniversalLanguageSelector-sandbox.translatewiki.net-linux-firefox build #146: FIXED in 1 min 13 sec: https://wmf.ci.cloudbees.com/job/UniversalLanguageSelector-sandbox.translatewiki.net-linux-firefox/146/
[07:00:19] <wmf-selenium-bot>	 Yippee, build fixed!
[07:00:20] <wmf-selenium-bot>	 Project UniversalLanguageSelector-commons.wikimedia.beta.wmflabs.org-linux-firefox build #233: FIXED in 18 min: https://wmf.ci.cloudbees.com/job/UniversalLanguageSelector-commons.wikimedia.beta.wmflabs.org-linux-firefox/233/
[08:52:58] <wmf-selenium-bot>	 Yippee, build fixed!
[08:52:59] <wmf-selenium-bot>	 Project VisualEditor-test2.wikipedia.org-linux-chrome build #224: FIXED in 1 hr 1 min: https://wmf.ci.cloudbees.com/job/VisualEditor-test2.wikipedia.org-linux-chrome/224/
[18:27:53] <wmf-selenium-bot>	 Project browsertests-en.wikipedia.beta.wmflabs.org-linux-chrome build #575: FAILURE in 17 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-linux-chrome/575/
[19:17:50] <wmf-selenium-bot>	 Project browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_8 build #454: FAILURE in 25 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_8/454/
[19:44:29] <wmf-selenium-bot>	 Yippee, build fixed!
[19:44:29] <wmf-selenium-bot>	 Project browsertests-test2.wikipedia.org-linux-firefox build #793: FIXED in 21 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-linux-firefox/793/