[03:29:19] Project browsertests-en.wikipedia.beta.wmflabs.org-linux-chrome build #604: UNSTABLE in 18 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-linux-chrome/604/ [03:54:28] Project browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_10 build #416: UNSTABLE in 24 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_10/416/ [04:24:20] Project browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_8 build #481: UNSTABLE in 26 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_8/481/ [04:47:52] Project browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_9 build #508: UNSTABLE in 23 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_9/508/ [06:21:57] Project Flow-en.wikipedia.beta.wmflabs.org-linux-firefox build #177: UNSTABLE in 2 min 33 sec: https://wmf.ci.cloudbees.com/job/Flow-en.wikipedia.beta.wmflabs.org-linux-firefox/177/ [06:29:32] Yippee, build fixed! [06:29:32] Project browsertests-test2.wikipedia.org-windows-internet_explorer_9 build #717: FIXED in 36 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-windows-internet_explorer_9/717/ [07:09:10] Project MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox build #287: UNSTABLE in 24 min: https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox/287/ [07:37:53] Project UniversalLanguageSelector-en.wikipedia.beta.wmflabs.org-linux-firefox build #127: UNSTABLE in 29 sec: https://wmf.ci.cloudbees.com/job/UniversalLanguageSelector-en.wikipedia.beta.wmflabs.org-linux-firefox/127/ [07:45:22] Project UniversalLanguageSelector-commons.wikimedia.beta.wmflabs.org-linux-firefox build #261: UNSTABLE in 8 min 3 sec: https://wmf.ci.cloudbees.com/job/UniversalLanguageSelector-commons.wikimedia.beta.wmflabs.org-linux-firefox/261/ [08:14:12] beta labs is down it seems [08:15:17] no ping even [09:44:47] a [10:27:07] b [10:27:40] hashar: did you fix it? [10:28:22] Nikerabbit: hi :-) What should I have fixed? [10:28:57] hashar: beta labs [10:29:03] it was not working earlier [11:03:17] Nikerabbit: no, abogott did [11:03:45] a virtual server had run out of disk (instance disks are overbooked) [11:05:12] Nemo_bis: again? [11:08:34] Nikerabbit: I think it was another kind of disk/storage failure last time, but yes I don't think any system was put in place to address overbooking [12:49:59] starting with setting up selenium for browser tests [12:50:17] I find that the folder browser doesn't is not there in my [12:50:19] tests/ [12:50:25] does it need to be cloned ? [12:55:16] hashar: Can you help me with setting up selenium ? [12:57:27] tonythomas01: have you followed the install steps described in the README.md file ? :) [12:58:17] hashar: I went. but for a start it says to go to /tests/browser [12:58:18] heck sorry [12:58:21] which is not there [12:58:22] https://github.com/wikimedia/mediawiki-selenium [12:58:32] hashar: actually I am on it [12:58:33] here ois the doc https://github.com/wikimedia/mediawiki-selenium/blob/master/README.md [12:58:43] hashar: I went through it [12:58:51] so mediawiki-selenium is a ruby gem [12:58:52] but, in the first step as I said [12:58:57] the browser folder [12:58:57] which is meant to be reused by other projects [12:59:10] ok [12:59:18] qa/browsertests is a set of tests meant to the the production wikis such as commons.wikimedia.org [12:59:22] or the tests wiki [12:59:50] hashar: ok. [13:00:11] you can skip the cd step [13:00:27] the qa/browsertests has a list of ruby gems that need to be installed in GemFile or Gem.lock or something like [13:00:28] that [13:00:32] you can get them installed using: [13:00:35] gem update --system [13:00:49] then you will need an utility named 'bundler' which you can install using: gem install bundler [13:00:50] hashar: that can be done anywhere ? [13:00:51] ok [13:01:04] do that at the root of your qa/browsertests working copy [13:01:08] then bundle install [13:01:12] should grab whatever is needed [13:01:39] ok. doing [13:01:45] then you will have to set up environment variable as described in mediawiki-selenium documentation [13:01:51] and: bundle exec cucumber [13:01:56] will run the tests [13:02:27] hashar: Ok. Tonight I have the Friday Program with Zeljko. and I'm preparing my system [13:02:43] yeah that is going to save you a lot of time [13:02:59] so qa/browsertests is mostly integration / smoke tests for the wikis Wikimedia maintains [13:03:00] hashar: of course. I have a little more doubts. Will tell shortly [13:03:08] we also have browser tests for some MediaWiki extensions [13:03:12] such as Flow or VisualEditor [13:04:32] hashar: We plan to work on this [13:04:32] https://bugzilla.wikimedia.org/show_bug.cgi?id=46887 [13:07:30] tonythomas01: I guess you can start out with qa/browsertests [13:07:48] VisualEditor and CirrusSearch extensions probably need some other software to be installed [13:08:05] maybe TwnMainPage is simple enough to install / setup [13:08:09] hashar: Oh. :( and is the vagrant necessary ? [13:08:26] tonythomas01: possibly [13:08:50] I haven't looked at the vagrant stuff yet, I think it provided a VM with all browser tests already setup [13:08:57] so you might want to have one installed [13:09:06] I have no idea where the doc is here though [13:09:18] potentially that should give you everything setup out of the box [13:09:24] doc https://www.mediawiki.org/wiki/Vagrant [13:09:36] maybe that is what zeljkof is using [13:09:40] hashar: I went through, downloaded it and stuff [13:10:07] but, I cant get http://127.0.0.1:8080 to find my mediawiki instance [13:10:30] that is only reachable from inside the virtual instance [13:10:50] and I am not sure how to use vagrant myself [13:11:05] seems there is a bunch of roles you can use ( vagrant list-roles ) [13:11:15] then you would have to pick one up with vagrant enable-role [13:11:47] ah some other documentation: https://www.mediawiki.org/wiki/Browser_testing/setup_instructions [13:12:11] ok ! I am going through [13:28:50] The documentation says [13:28:52] The admin password is vagrant. [13:28:58] but I gave the username as admin [13:29:13] and password as given, but its not getting logged in [13:29:22] * for Mediawiki-Vagrant [13:35:58] (03PS1) 10Hashar: explicitly define success/failure messages [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/107570 [13:36:12] (03CR) 10Hashar: [C: 032] explicitly define success/failure messages [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/107570 (owner: 10Hashar) [13:36:17] (03Merged) 10jenkins-bot: explicitly define success/failure messages [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/107570 (owner: 10Hashar) [14:02:47] tonythomas01: looks like my IRC client does not want to work today [14:10:15] tonythomas01: is this IRC client working? :) [14:10:32] zeljkof: of course yes [14:10:37] i can see you [14:10:55] this is the third one I have tried today, not sure what is going on [14:11:10] can you ping me on skype? I am zeljko.filipin [14:11:13] zeljkof: dont worry. Things are fine [14:11:31] zeljkof: looks like my campus firewall is completely screwed [14:12:55] tonythomas01 should we just talk here, looks like IRC works [14:13:04] zeljkof_: of course [14:13:06] we can [14:13:18] can we start [14:13:25] sure [14:13:35] so, you want to work on the bug https://bugzilla.wikimedia.org/show_bug.cgi?id=46887 [14:13:46] right? [14:14:06] zeljkof_: of course [14:14:13] zeljkof: of course [14:14:33] so, we should start with browsertests ? [14:14:44] how familiar are you with mediawiki? you have mentioned resolving a few bugs [14:14:54] can you give me the links so I can take a look? [14:15:28] zeljkof: ok ! https://github.com/wikimedia/mediawiki-core/commits?author=tonythomas01 [14:15:37] some of the ones I have done [14:15:50] zeljkof: simple only [14:16:12] tonythomas01 ok [14:16:37] zeljkof: and regarding messgaes https://gerrit.wikimedia.org/r/#/c/107360/ [14:18:59] zeljkof: looks like you are having serious network issues [14:19:10] I have to ask a few questions before we start, to know how familiar you are with different things [14:19:16] zeljkof: ok [14:19:16] how did you get involved? via internship (google summer of code, code-in…) or something else? [14:19:28] tonythomas01 sorry, not sure what is going on today [14:20:10] zeljkof: nothing like that. I am a second year CS Engineering student, just like contributing to Open source [14:20:22] ok [14:20:31] and therefore started in Mediawiki by fixing a few bugs [14:21:11] great [14:21:12] :) [14:21:20] zeljkof: Thanks. [14:21:28] are you familiar with ruby and selenium? [14:21:43] are you aware that we use ruby+selenium for browser tests? [14:22:02] zeljkof: I went through the links . Cloned them [14:22:13] zeljkof: but dont know much about ruby and selenium [14:22:36] ok, that is not a problem, but I have to know your background [14:22:56] you are familiar with php, right? [14:22:59] zeljkof: I know a bit of PHP, JS, HTML<, C++ [14:23:19] ok, that is good [14:23:32] zeljkof: I will try to keep in pace [14:24:03] it would be great if we cold do screen sharing, so I could show you how we write tests, but internet is not on our side today [14:24:19] zeljkof: of course ! bad day [14:24:30] zeljkof: do we have some other alternatives ? [14:24:35] what did you try so far? you said in the e-mail you had problem with vagrant [14:25:10] zeljkof: when I give sudo vagrant ip [14:25:14] zeljkof: when I give sudo vagrant up [14:25:24] I get he guest machine entered an invalid state while waiting for it [14:25:24] to boot. Valid states are 'starting, running'. The machine is in the [14:25:24] 'poweroff' state. Please verify everything is configured [14:25:24] properly and try again [14:25:29] error [14:25:40] but, anyway, I can boot into the VM in virtualbox [14:26:08] can you paste terminal output here? http://etherpad.wikimedia.org/p/tonythomas01 [14:26:53] why are you using "sudo vagrant up"? "vagrant up" should work without "sudo" [14:27:05] are you on linux? ubuntu? fedora? something else? [14:27:12] ubuntu [14:27:51] zeljkof: now when I give vagrant up [14:27:56] the virtualbox boots [14:27:57] up [14:28:07] ok, so it works fine now? [14:28:14] when you do not use sudo? [14:28:19] yes [14:28:21] looks like it [14:28:24] let me see [14:28:26] ok, progress :) [14:28:39] but, just like last time [14:28:50] i should give admin as the username ? [14:29:17] can you post output of your terminal session to the pad? here http://etherpad.wikimedia.org/p/tonythomas01 [14:29:32] I am having a hard time understanding the problem [14:29:36] terminal output will help [14:29:40] zeljkof: now, I get the login screen in terminal [14:29:47] but what should I give as username [14:30:26] let me show you what I mean [14:30:31] I have no idea what you are doing :) [14:30:50] so let me show you how I use vagrant virtual machine [14:30:53] go to the pad [14:30:54] http://etherpad.wikimedia.org/p/tonythomas01 [14:31:04] I will paste there output from my terminal [14:31:10] are you in the pad? [14:31:41] zeljkof: my mistake. I typed virtualbox vagrant up [14:31:47] thats how the virtualbox came up [14:31:50] i am in etherpad [14:32:12] ok, I can see you there [14:32:23] and hashar :) [14:32:27] :D [14:32:35] you saw my paste ? [14:32:42] tonythomas01: yes, I can see it [14:32:51] what is the problem? [14:33:04] zeljkof: I get this [14:33:10] zeljkof: that is not an error ? [14:33:25] does not look like an error to me :) [14:33:41] as far as I can see, you have pasted two lines, right? [14:33:54] zeljkof: Ok, then. Now next step should be http://127.0.0.1:1234/w/index.php [14:33:55] ? [14:34:04] zeljkof: of course [14:34:43] tonythomas01: are you following instructions from this page? [14:34:49] https://www.mediawiki.org/wiki/Mediawiki-Vagrant [14:34:52] or another one? [14:35:29] zeljkof: I started from that. Had to move to some other [14:35:36] anyawy in that now [14:35:54] it shows When Vagrant is done configuring your machine, browse to http://127.0.0.1:8080/ to find your MediaWiki instance [14:36:04] ok [14:36:06] did you do that? [14:36:25] i had some problems with 8080 [14:36:29] so had to change it to [14:36:30] 1234 [14:36:46] does it work? [14:37:06] Nah ! [14:37:17] ok [14:37:17] it just shows an endless Waiting screen [14:37:30] I would give up on vagrant for now [14:37:35] ok ! [14:37:37] :) [14:38:04] I have to go to another meeting in 25 minutes, and we have barely started [14:38:13] and I am not a vagrant expert anyway [14:38:21] zeljkof: Yeah. [14:38:36] so, we can start with some other area ? [14:38:47] did you install ruby? [14:38:54] on your machine [14:39:01] here are the instructions https://www.mediawiki.org/wiki/Quality_Assurance/Browser_testing/Setup_instructions#Ruby_on_Linux [14:39:11] ruby -v [14:39:12] shows [14:39:13] ruby 1.8.7 (2011-06-30 patchlevel 352) [x86_64-linux] [14:39:19] is that enough ? [14:39:21] tonythomas01 no [14:39:28] we use some ruby 1.9 features [14:39:54] I would highly recommend installing RVM [14:40:29] I did that earlier [14:40:35] but, on one of the steps [14:40:40] I got one more error message [14:40:53] anyway running rvm install ruby-2.0.0-p247 again [14:41:19] I will paste the error there [14:41:34] zeljkof: saw that ? [14:41:39] let me see [14:44:07] why are you installing ruby 1.8.7 via rvm? [14:45:40] I gave the command [14:45:42] rvm install ruby-2.0.0-p247 [14:45:46] and got this [14:46:03] can you paste the entire output to the pad? [14:46:08] from rvm install? [14:46:30] done [14:46:42] no [14:46:54] oh noes! :) [14:47:04] why are you using sudo all the time!? :) [14:47:25] ok, now try everything again, but _without_ sudo! :) [14:47:32] zeljkof: looks like it. Now trying without sudo [14:47:51] again I get the error [14:47:59] pasted ! [14:48:19] how did you install rvm? with sudo? [14:49:19] i dont think so [14:49:20] but now [14:49:26] \curl -L https://get.rvm.io | bash -s stable [14:49:40] are you running that right now? [14:49:44] gives some another error. Probably since I had done the thing earlier [14:49:55] ok [14:49:57] zeljkof: that was the step I used earlier to install rvm [14:50:02] please uninstall rvm [14:50:14] some command ? [14:50:26] rvm implode [14:50:29] that should do it [14:50:45] done [14:50:47] then open new terminal tab/window and install it again [14:50:54] now \curl -L https://get.rvm.io | bash -s stable ? [14:50:56] remember to open new tab/window [14:51:04] ok [14:51:25] this page has the latest instructions [14:51:26] http://rvm.io/ [14:51:37] looks like it shold be [14:51:38] should be [14:51:40] \curl -sSL https://get.rvm.io | bash -s stable [14:52:20] and think what ?> I get this new error [14:52:31] pasted ! [14:52:34] looks like bad day [14:52:43] but it went fine laast time [14:53:09] now following the commands in the linkl [14:54:29] can you paste more output [14:54:39] I do not see the command that you have entered [14:55:22] can you paste more output? [14:55:22] zeljkof: Now isntalling rvm [14:55:35] I can not see the command you entered [14:55:40] zeljkof: the installing going on fine [14:55:41] ok [14:56:05] pasted [14:56:07] oh [14:56:16] oh, so you had rvm installed via apt-get? [14:56:47] no. ! I followed the instructions in http://stackoverflow.com/questions/9056008/installed-ruby-1-9-3-with-rvm-but-command-line-doesnt-show-ruby-v/9056395#9056395 [14:56:58] zeljkof: Its ok right ? [14:57:11] I am not sure what you did :) [14:57:21] ok, I have to go to another meeting in 5 minutes [14:57:27] did you manage to install rvm? [14:57:34] please update the pad if you did [14:57:39] or if you had problems [14:58:00] my current terminal [14:58:07] is pasted there [14:58:53] looks like rvm installed [14:59:00] now doing \curl -sSL https://get.rvm.io | bash -s stable [14:59:19] it showed [14:59:30] i have pasted the output [14:59:34] looks good [15:00:19] ok, now install a recent ruby [15:00:19] zeljkof gave rvm install ruby-2.0.0-p247 [15:00:47] tonythomas01: I have to go to another meeting now [15:01:02] zeljkof: I will try to get rid of all these errors by today [15:01:05] let's continue via e-mail for now, and we can have another pairing session this or next week [15:01:12] maybe we can have another session ! [15:01:13] yeah [15:01:17] good luck :) [15:01:23] thanks :) [15:36:11] hashar: do you have a minute? [15:37:07] hashar, aharoni, Nikerabbit, spage, yurik: do you have a minute? Jeff and I have a javascript question :) [15:45:39] * Nikerabbit hides [16:04:44] zeljkof: still relevant? [16:05:57] JeffHall: can you ping aharoni and explain the problem? [16:06:27] zeljkof aharoni: Sure, will do [16:06:45] JeffHall: thanks [16:06:51] aharoni: I am in another meeting now [16:07:32] np, I'm available [16:08:06] aharoni: Basically what we're trying to do is define Javascript "bind" functionality for PhantomJS, which doesn't have it natively [16:08:57] aharoni: Timo pointed us to this workaround: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Function/bind?redirectlocale=en-US&redirectslug=JavaScript%2FReference%2FGlobal_Objects%2FFunction%2Fbind#Compatibility [16:10:10] I doubt think that I would be more expert than Timo... was there a problem with his suggestion? [16:10:13] aharoni: Zeljko and I were trying to figure out how to get that block of JS to execute via the PhantomJS console, but it returns parse errors, so we suspect it may not be valid JS [16:10:37] well, I can try to understand parse errors. [16:10:43] what's the error? [16:11:38] aharoni: Unfortunately, the PhantomJS console just returns "Parse error" - not very helpful! [16:11:58] aharoni: We get more detailed messages from some of the online JSLint tools [16:12:22] bah. curious challenge. [16:12:31] I can't promise anything, but let me try. [16:13:10] JeffHall: which version of phantomjs are you using? [16:13:45] aharoni: 1.9.2 [16:13:49] ok [16:19:18] JeffHall: are you just trying to run that code on that page? [16:19:30] under "Polyfill"? [16:20:10] aharoni: Yeah, our goal is to execute that Polyfill script when visiting any wiki page, in order to see the VisualEditor tab, which requires "bind" functionality [16:20:22] ok, I'm trying [16:21:26] aharoni: I tried running the Polyfill script through local JSLint on my machine, and it seems OK - not crititcal parsing errors, just some complaints about whitespace, etc [16:26:53] JeffHall: so, it may be silly, but I don't get a parse error, [16:27:09] now I actually have very little experience with phantomjs, [16:27:18] but I did this: [16:27:44] first I type `Function.prototype.bind` [16:27:48] and it was undefined. [16:27:55] aharoni: Ok, that makes sense [16:28:21] so I tried to paste the code, and got "Parse error", because the interactive is probably stupid about linebraks. [16:28:25] breaks. [16:28:48] So I removed the comment on line for, replaced all linebreaks with spaces, and pasted it, [16:28:55] it didn't give me a Parse error, [16:29:15] and if I type `Function.prototype.bind` now, I get the result {}, which is sensible. [16:29:39] aharoni: So that {} indicates that the function has been succecssfully define? [16:29:49] that is my understanding. [16:30:29] predefined JS functions give the same, for example `alert`, `setInterval`, etc. [16:30:33] aharoni: OK, excellent - this is very helpful - it was just those initial JS parsing errors that were throwing us off [16:30:41] glad to help. [16:31:01] aharoni: And I was just able to repro your workflow locally - this is great - thanks for the help! [16:31:22] you're welcome! [16:32:44] * aharoni is appalled about the amount of missed words and other grammar errors he made in this conversation. [16:33:17] IRC is not conducive to eloquent elocution ;) [19:55:46] (03PS1) 10Hashar: run operations/mediawiki-config tests in parallel [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/107629 [19:56:18] (03CR) 10Hashar: [C: 032] run operations/mediawiki-config tests in parallel [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/107629 (owner: 10Hashar) [19:56:24] (03Merged) 10jenkins-bot: run operations/mediawiki-config tests in parallel [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/107629 (owner: 10Hashar) [20:45:22] hello QA! I'm about to update elasticsearch in beta in preparation for updating it in production tomorrow. If anything becomes sad please let me know. I'll be watching it myself but I can't catch everything. [20:45:40] I've tested it locally and it is working fine but beta is a few orders of magnitude larger [21:28:12] (03PS1) 10Hashar: mwcore-docgen: GERRIT_BRANCH > ZUUL_BRANCH [integration/jenkins] - 10https://gerrit.wikimedia.org/r/107718 [21:28:33] (03CR) 10Hashar: [C: 032] mwcore-docgen: GERRIT_BRANCH > ZUUL_BRANCH [integration/jenkins] - 10https://gerrit.wikimedia.org/r/107718 (owner: 10Hashar) [21:28:36] (03Merged) 10jenkins-bot: mwcore-docgen: GERRIT_BRANCH > ZUUL_BRANCH [integration/jenkins] - 10https://gerrit.wikimedia.org/r/107718 (owner: 10Hashar) [21:43:30] manybubbles: Thanks! We'll keep an eye out for sadness in betalabs.... [21:44:39] JeffHall: cool. I finished the upgrade about half an hour ago. #Ozymandias [21:51:07] Project browsertests-test2.wikipedia.org-windows-internet_explorer_9 build #718: UNSTABLE in 37 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-windows-internet_explorer_9/718/ [22:34:28] Yippee, build fixed! [22:34:29] Project MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome build #200: FIXED in 19 min: https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/200/ [22:39:46] Yippee, build fixed! [22:39:46] Project MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox build #288: FIXED in 20 min: https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox/288/ [22:49:02] (03PS1) 10Jhall: Adding myself to e-mail output for VisualEditor jobs. [selenium] - 10https://gerrit.wikimedia.org/r/107731 [23:16:28] Yippee, build fixed! [23:16:28] Project UniversalLanguageSelector-en.wikipedia.beta.wmflabs.org-linux-firefox build #128: FIXED in 32 sec: https://wmf.ci.cloudbees.com/job/UniversalLanguageSelector-en.wikipedia.beta.wmflabs.org-linux-firefox/128/ [23:19:23] JeffHall: on first brush, I like your previous gig's system [23:20:03] greg-g: Yeah, it actually worked pretty well, even for a organization with multiple products and dev teams [23:20:15] * greg-g nods [23:32:03] Yippee, build fixed! [23:32:04] Project UniversalLanguageSelector-commons.wikimedia.beta.wmflabs.org-linux-firefox build #262: FIXED in 20 min: https://wmf.ci.cloudbees.com/job/UniversalLanguageSelector-commons.wikimedia.beta.wmflabs.org-linux-firefox/262/ [23:46:08] (03PS2) 10Jhall: Adding myself to e-mail notitifications for MobileFrontEnd and VisualEditor jobs. [selenium] - 10https://gerrit.wikimedia.org/r/107731