[00:00:15] (03PS1) 10MarkTraceur: Add MultimediaViewer doc jobs [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/108857 [00:00:34] spends ages on this: Using mini_portile (0.5.2) [00:00:45] (03CR) 10Hashar: [C: 032] Add jsduck jobs for MultimediaViewer [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/108854 (owner: 10MarkTraceur) [00:00:52] but what did you run? bundle install? [00:01:11] jgonera: yes, bundle install [00:01:20] I found the PageObject doc btw [00:01:29] http://rubydoc.info/github/cheezy/page-object/master/PageObject/Accessors [00:01:35] werdna, but did you check what gem list shows before bundle install? [00:01:56] yes [00:02:01] gemsets for ruby-2.1.0 (found in /Users/andrew/.rvm/gems/ruby-2.1.0) [00:02:02] (default) [00:02:02] => Flow [00:02:02] browsertests [00:02:02] global [00:02:28] no, not "rvm gemset list", "gem list" [00:02:36] (03CR) 10Hashar: [C: 032] Add jsduck jobs for MultimediaViewer [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/108854 (owner: 10MarkTraceur) [00:02:54] (03Merged) 10jenkins-bot: Add jsduck jobs for MultimediaViewer [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/108854 (owner: 10MarkTraceur) [00:02:59] (03CR) 10MarkTraceur: [C: 032] Add MultimediaViewer doc jobs [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/108857 (owner: 10MarkTraceur) [00:03:26] before: http://p.defau.lt/?IXV4Z7qPt01mwe08nKaQVA [00:03:35] werdna, gotta run for a moment, I can get back to you later. but it must be some PATH related problem, tests run for me in phantomjs [00:03:47] okay [00:03:55] (03PS2) 10MarkTraceur: Add MultimediaViewer doc jobs [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/108857 [00:03:59] what sort of PATH related problem do you suspect? phantomjs not being in PATH? [00:04:01] (03CR) 10MarkTraceur: [C: 032] Add MultimediaViewer doc jobs [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/108857 (owner: 10MarkTraceur) [00:04:05] (03Merged) 10jenkins-bot: Add MultimediaViewer doc jobs [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/108857 (owner: 10MarkTraceur) [00:04:06] or some phantomjs gem not being accessible? [00:04:12] try again after this bundle install if you need to run it again [00:04:36] I suppose page-object can't find phantomjs or something, page-object is what is raising this error [00:08:42] werdna: You might double-check that the "mediawiki-selenium" Rubygem is in the gem env for whatever repo you're working with - that "mediawiki-selenium" gem drives the browser selection for our Selenium infrastructure [00:14:52] Here's my gem list after: http://p.defau.lt/?JmCGv91_DfYPKNNROEt0XQ [00:16:18] werdna: That gem list looks pretty up-to-date to me. Are you not able to launch a "feature" test using phantomjs? [00:16:27] just trying now [00:17:14] still Unable to pick a platform for the provided browser (RuntimeError) [00:17:37] werdna: can you run a test if you do "export BROWSER_LABEL=firefox" ? [00:17:48] yep [00:17:53] if I leave BROWSER_LABEL= off, then it works fine [00:18:10] werdna: sounds like PhantomJS is messed up then. [00:18:33] yeah! It's just a question of how [00:18:44] $ phantomjs [00:18:44] phantomjs> [00:18:46] works fine [00:18:51] do I need to run it in a different shell or something? [00:18:58] or is there some glue code that I need to use? [00:19:27] do I need to specify the path to the executable somewhere? [00:19:38] It did feel a bit weird that all I needed was for the executable to be in the PATH [00:19:42] werdna: I tend to use FF/Chrome, let me see if I can bring up PhantomJS (I'm Ubuntu) [00:19:56] I would much prefer something backgrounded [00:20:02] I hate not being able to use my laptop while tests are running [00:20:09] windows keep popping up and intercepting my input! [00:22:10] werdna: OK, phantomjs is working for me still. [00:22:46] hmph [00:22:50] werdna, which shows something reasonable for you? I'm just pulling at straws here : $ which phantomjs [00:22:50] /usr/bin/phantomjs [00:22:58] /Users/andrew/bin/phantomjs [00:23:29] chrismcmahon: all I can think of to do now is to actually go through the code that calls phantomjs [00:23:48] I'm sure there's some undocumented dependency that I don't know about :p [00:25:33] werdna: that actually looks odd to me. on my Mac I have no /User/cmcmahon/bin, nor do I have anything like that in my $PATH [00:26:34] werdna: although my Mac isn't really set up for work stuff [00:26:48] chrismcmahon: well, I installed it by copying the executable there [00:26:53] that's all I did to install it [00:26:56] it doesn't need anything else [00:28:10] werdna: fwiw, if you haven't found it, the code that starts the browser is in https://github.com/cheezy/page-object/blob/f7649cf4b69e027027f8c45601688b7ba680599f/lib/page-object/loads_platform.rb (and we've asked Jeff to make a nicer failure message I think) [00:30:01] werdna: dunno. sounds like a PATH issue or a permissions issue or something preventing proper access to the phantomjs executable [00:32:31] For what it's worth, permissions for the phantomjs executable on my Mac are 755 (executable by everybody) [00:47:24] Project VisualEditor-en.wikipedia.beta.wmflabs.org-linux-firefox build #279: FAILURE in 47 min: https://wmf.ci.cloudbees.com/job/VisualEditor-en.wikipedia.beta.wmflabs.org-linux-firefox/279/ [00:49:04] (03PS1) 10MarkTraceur: Make jsduck voting on MultimediaViewer [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/108865 [00:49:55] (03CR) 10MarkTraceur: [C: 032] Make jsduck voting on MultimediaViewer [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/108865 (owner: 10MarkTraceur) [00:50:00] (03Merged) 10jenkins-bot: Make jsduck voting on MultimediaViewer [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/108865 (owner: 10MarkTraceur) [00:53:16] werdna, still fighting with it? [01:00:18] (03PS1) 10MarkTraceur: Move the right things for publishing MMV docs [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/108868 [01:00:31] (03CR) 10MarkTraceur: [C: 032] Move the right things for publishing MMV docs [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/108868 (owner: 10MarkTraceur) [01:00:51] (03Merged) 10jenkins-bot: Move the right things for publishing MMV docs [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/108868 (owner: 10MarkTraceur) [01:01:05] jgonera: went to standup [01:01:11] jgonera: everything's working okay except phantomjs now [01:01:52] werdna, hard to say... stop using macports and install phantomjs using brew? I guess homebrew is the recommended way nowadays [01:02:06] as I said, I'm not really a Mac user myself [01:02:07] jgonera: What are the prerequisites for phantomjs to work? [01:02:14] like, how does it integrate? [01:02:16] what calls phantomjs? [01:02:35] page-object or webdriver I'd guess [01:02:40] I mean, everybody else seems to use something called "poltergeist" to integrate cucumber / selenium / whatever [01:03:02] I don't think so, I think recent phantomjs has selenium built in [01:03:12] I think maybe even poltergeist was merged into phantomjs [01:03:38] werdna, no, I take it back [01:03:49] werdna, I have mistaken it for something else [01:04:01] (03PS1) 10MarkTraceur: Add link to MultimediaViewer docs [integration/docroot] - 10https://gerrit.wikimedia.org/r/108870 [01:04:03] you apparently pass a WebDriver into PageObject [01:04:05] werdna, poltergeist is for capybara, but we're not using that [01:04:11] "page-object supports both watir-webdriver and selenium-webdriver. The one used will be determined by which driver you pass into the constructor of your page object. The page object can be create like this" [01:04:23] assuming you pass a selenium-webdriver in [01:14:29] (03PS1) 10Hashar: gerrit-sync-ve: switch to jenkins-mwext-sync user [integration/jenkins] - 10https://gerrit.wikimedia.org/r/108874 [01:14:40] (03CR) 10Hashar: [C: 032] gerrit-sync-ve: switch to jenkins-mwext-sync user [integration/jenkins] - 10https://gerrit.wikimedia.org/r/108874 (owner: 10Hashar) [01:14:43] (03Merged) 10jenkins-bot: gerrit-sync-ve: switch to jenkins-mwext-sync user [integration/jenkins] - 10https://gerrit.wikimedia.org/r/108874 (owner: 10Hashar) [03:27:28] Yippee, build fixed! [03:27:28] Project browsertests-en.wikipedia.beta.wmflabs.org-linux-chrome build #618: FIXED in 17 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-linux-chrome/618/ [03:31:34] Project browsertests-en.wikipedia.beta.wmflabs.org-linux-firefox build #593: FAILURE in 21 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-linux-firefox/593/ [03:51:57] Yippee, build fixed! [03:51:58] Project browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_10 build #431: FIXED in 24 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_10/431/ [04:16:31] Project browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_9 build #522: FAILURE in 24 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_9/522/ [04:42:25] Yippee, build fixed! [04:42:26] Project browsertests-test2.wikipedia.org-windows-internet_explorer_10 build #416: FIXED in 25 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-windows-internet_explorer_10/416/ [05:09:28] Project browsertests-test2.wikipedia.org-windows-internet_explorer_8 build #696: FAILURE in 32 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-windows-internet_explorer_8/696/ [05:17:47] Yippee, build fixed! [05:17:48] Project browsertests-test2.wikipedia.org-windows-internet_explorer_9 build #731: FIXED in 35 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-windows-internet_explorer_9/731/ [05:29:21] Yippee, build fixed! [05:29:22] Project Flow-test2-wikipedia-org-linux-chrome build #70: FIXED in 5 min 15 sec: https://wmf.ci.cloudbees.com/job/Flow-test2-wikipedia-org-linux-chrome/70/ [06:18:26] Project MobileFrontend-en.m.wikipedia.org-linux-firefox build #259: FAILURE in 20 min: https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.org-linux-firefox/259/ [11:51:27] zeljkof: For todays pair programming, where should I clone exactly the links given in https://github.com/wikimedia/mediawiki-selenium#links [11:51:28] ? [12:16:02] tonythomas01: sorry, I was offline [12:16:21] tonythomas01: you can clone them where ever you store code on your machine [12:16:47] Tobi_WMDE: did you see this? http://lists.wikimedia.org/pipermail/qa/2014-January/000936.html [12:17:38] zeljkof: should it be something where the apache reaches for my mw core ? like /var/www/core/ ? [12:17:53] tonythomas01: no [12:17:56] zeljkof: it can be at any random place right ? [12:18:01] yes [12:18:06] zeljkof: ok [12:18:37] so, before we start, I should clone all those repos right ? [12:18:47] tonythomas01: you can start with one :) [12:18:57] I doubt we will have time to cover all of them today [12:19:05] zeljkof: I cloned the browsertest anyway [12:19:16] that should be enough for today [12:19:23] if there are any sleep statements there [12:19:27] zeljkof: ok :) [12:19:40] on which bug are you guys working on? [12:19:48] mayankmadan: https://bugzilla.wikimedia.org/show_bug.cgi?id=46887 [12:21:12] why exactly is sleep evil? [12:22:41] mayankmadan: join us in 90 minutes here [12:22:42] :) [12:22:57] I have to finish something, in 90 minutes we will have a pairing session here [12:22:58] zeljkof, can i do that? i want to but can i? [12:23:22] mayankmadan: can you join us in talking about the bug here? yes you can :) [12:23:29] great [12:23:44] it would be great :) [13:31:28] Project MultimediaViewer-en.wikipedia.beta.wmflabs.org-linux-firefox build #1: FAILURE in 1 min 16 sec: https://wmf.ci.cloudbees.com/job/MultimediaViewer-en.wikipedia.beta.wmflabs.org-linux-firefox/1/ [13:32:19] tonythomas01, zeljkof, there were 4 instances where sleep is used in browsertests repo [13:32:52] mayankmadan: excellent :) [13:33:01] there is probably more in other repositories [13:33:33] but lets have a look at the ones that are in browsertests [13:33:45] sure, we have to start somewhere [13:33:58] we start with the pairing session here in 27 minutes [13:34:03] ok [13:34:40] zeljkof: yeah [13:34:42] zeljkof: should we setup for a vedio conference in hangouts ? [13:35:11] (03PS1) 10Zfilipin: Created Jenkins job that runs MultimediaViewer Selenium tests [selenium] - 10https://gerrit.wikimedia.org/r/108908 [13:35:30] tonythomas01: I can do video if both of you can [13:35:34] that would be faster [13:35:36] i can [13:35:43] but audio only is also fine with me [13:35:45] or IRc [13:37:41] zeljkof, im fine with anything, so it depends on tonythomas01 and you [13:38:57] (03PS2) 10Zfilipin: Created Jenkins job that runs MultimediaViewer Selenium tests [selenium] - 10https://gerrit.wikimedia.org/r/108908 [13:39:47] tonythomas01_: around? [13:39:50] tonythomas01_, what do you say? [13:39:54] zeljkof: yes [13:40:00] let mayankmadan and me know if you can do audio or video [13:40:14] i can audio and vedio this time I think :) [13:40:15] mayankmadan: I will add you to the hangout [13:40:35] okay [13:42:54] mayankmadan: done [13:47:06] looks like I lost connection with http://webchat.freenode.net/ [13:47:06] :( [13:47:46] zeljkof:hangouts ? [13:48:06] tonythomas01: I did not understand the question [13:48:35] zeljkof:I meant, did you add me to the google hangout [13:48:51] tonythomas01: yes, you are added since I created the event [13:48:55] did you get the e-mail [13:48:56] ? [13:49:04] yes [13:49:09] if you are using google calendar, you should see the event there [13:49:21] is the link to the hangout in the e-mail? [13:49:29] let me see [13:49:59] yes. joined the vedio call [13:51:31] mayankmadan:you there ? [13:51:38] tonythomas01, yep [13:53:08] mayankmadan, tonythomas01: I will join you in time, in 10 minutes [13:53:11] have to finish something [13:53:34] okay, i also have to do something so ill be joining at about the same time [13:54:29] ok [14:01:51] ok im online [14:12:46] (03CR) 10Jhall: [C: 031] Created Jenkins job that runs MultimediaViewer Selenium tests [selenium] - 10https://gerrit.wikimedia.org/r/108908 (owner: 10Zfilipin) [14:19:53] zeljkof, can we just use wait_while_present ? [14:23:15] Yippee, build fixed! [14:23:15] Project MultimediaViewer-en.wikipedia.beta.wmflabs.org-linux-firefox build #2: FIXED in 2 min 4 sec: https://wmf.ci.cloudbees.com/job/MultimediaViewer-en.wikipedia.beta.wmflabs.org-linux-firefox/2/ [14:31:39] (03PS1) 10Zfilipin: Replaced sleep with page-object gem waiting API [qa/browsertests] - 10https://gerrit.wikimedia.org/r/108916 [14:36:10] (03CR) 10Jhall: [C: 031] Replaced sleep with page-object gem waiting API [qa/browsertests] - 10https://gerrit.wikimedia.org/r/108916 (owner: 10Zfilipin) [14:36:28] (03CR) 10Mayankmadan: [C: 031] "Test runs fine on my machine" [qa/browsertests] - 10https://gerrit.wikimedia.org/r/108916 (owner: 10Zfilipin) [14:59:46] (03PS1) 1001tonythomas: Removed sleep with waiting API in browsertests [qa/browsertests] - 10https://gerrit.wikimedia.org/r/108918 [15:05:38] (03CR) 10Zfilipin: [C: 031] Removed sleep with waiting API in browsertests [qa/browsertests] - 10https://gerrit.wikimedia.org/r/108918 (owner: 1001tonythomas) [15:08:55] zeljkof, is it possible for friday? [15:09:19] zeljkof, i have a chemistry class tomorrow [15:16:41] (03CR) 10Cmcmahon: [C: 032] "Thanks!" [qa/browsertests] - 10https://gerrit.wikimedia.org/r/108918 (owner: 1001tonythomas) [15:17:13] (03Merged) 10jenkins-bot: Removed sleep with waiting API in browsertests [qa/browsertests] - 10https://gerrit.wikimedia.org/r/108918 (owner: 1001tonythomas) [15:46:29] hi JeffHall https://bugzilla.wikimedia.org/show_bug.cgi?id=60346 fyi [15:50:28] chrismcmahon: Yeah, I disabled the CloudBees VE jobs for betalabs yesterday evening since it looked like VE was on the fritz again [15:51:50] JeffHall: also https://gerrit.wikimedia.org/r/#/c/108921 . I noticed that Chrome was still failing to clobber the beta warning in the other edit clause we have in tests. We did the 'try 10 times' in one edit clause but not in the other one. [15:52:39] chrismcmahon: You beat me to it - I was getting to commit that same change! [15:53:02] sorry! [15:53:22] chrismcmahon: No prob - that's an easy +2 [15:53:45] chrismcmahon: Now I jsut gotta figure out why Chrome still has problems with the transclusion test... [15:53:48] that beta warning continues to bug me, oh well [15:55:30] JeffHall: you mean like this one? https://wmf.ci.cloudbees.com/job/VisualEditor-test2.wikipedia.org-linux-chrome/lastCompletedBuild/testReport/(root)/VisualEditor%20Transclusion/Add_parameter_to_template/ [15:55:49] chrismcmahon: Yes, exactly [15:58:23] JeffHall: I can generally that the test is trying to click the "add_parameter" element, but there is a "down-arrow" element masking the add_parameter. Not sure about the details until VE starts working again. [15:59:14] chrismcmahon: Yeah, I'm trying to repo the problem locally to see if I can at least get a fix in [16:17:44] (03CR) 10Cmcmahon: [C: 032] "Thanks!" [qa/browsertests] - 10https://gerrit.wikimedia.org/r/108916 (owner: 10Zfilipin) [16:19:08] (03CR) 10Cmcmahon: [C: 032] "Thanks!" [selenium] - 10https://gerrit.wikimedia.org/r/108908 (owner: 10Zfilipin) [16:35:14] JeffHall: so using Firebug I can see the problem with Chrome [16:36:05] chrismcmahon: what did you find? [16:37:36] JeffHall: the bit of the VE toolbar where you select a heading, the part that shows "Paragraph"--- is floating "on top of" the Transclusion UI. This is true in both FF and Chrome, but it is only a problem for the test in Chrome. [16:38:10] chrismcmahon: Interesting.... [16:39:37] JeffHall: to see it it Firebug, walk through to where you add the parameter to the template; bring up Firebug and click anywhere in the page; search for oo-ui-indicatedElement-indicator in Firebug; Firebug highlights the Header down-arrow element, and clearly shows it above the Transclusion UI [16:40:19] JeffHall: I can't take a screen shot with Ubuntu tools but you could probably get one with cmd-shift-4 in MacOS [16:41:14] JeffHall: fwiw I think this is a bug in VE, but a minor one. looks like an abuse of z-index somehow. [16:41:26] since it happens for both FF and Chrome [16:44:00] chrismcmahon: OK, I do what you mean - that does seem like an odd behavior [16:45:28] (03PS1) 10Zfilipin: WIP Run UploadWizard API tests at CloudBees [selenium] - 10https://gerrit.wikimedia.org/r/108924 [17:14:39] JeffHall_away: I thought this might work but it didn't: [17:14:42] When(/^I add the parameter$/) do [17:14:42] on(VisualEditorPage).add_parameter_element.when_present.fire_event("onfocus") [17:14:42] on(VisualEditorPage).add_parameter_element.when_present.click [17:14:42] end [17:14:57] still get the z-axis problem [17:36:34] chrismcmahon: Just from watching changes to document.activeElement in Chrome, everything is working fine from my desktop - the Transclusion iframe gets focus when it should [17:37:23] chrismcmahon: But, document.activeElement.title is empty, which matches what the Transclusion test run via CloudBees is reporting for Chrome [17:48:45] JeffHall: browsers suck :-) [18:05:12] Is there a Ruby debugger? [18:17:10] werdna: There are several different debuggers for Ruby, but this one is "the standard": http://rubygems.org/gems/ruby-debug [18:18:07] might help me with my phantomjs woes [18:19:28] (03CR) 10Hashar: Add link to MultimediaViewer docs (031 comment) [integration/docroot] - 10https://gerrit.wikimedia.org/r/108870 (owner: 10MarkTraceur) [18:30:02] Project browsertests-en.wikipedia.beta.wmflabs.org-linux-chrome build #619: FAILURE in 18 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-linux-chrome/619/ [18:32:18] (03CR) 10MarkTraceur: Add link to MultimediaViewer docs (031 comment) [integration/docroot] - 10https://gerrit.wikimedia.org/r/108870 (owner: 10MarkTraceur) [18:32:28] werdna: have you tried putting/installing phantomjs in a different directory in your PATH? since Firefox works for you, I suspect something not Ruby is the root cause [18:34:24] andrew-macbook:browser andrew$ sudo mv ~/bin/phantomjs /usr/local/bin/ [18:34:35] and it still doesn't work [18:37:33] Yippee, build fixed! [18:37:34] Project browsertests-en.wikipedia.beta.wmflabs.org-linux-firefox build #594: FIXED in 22 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-linux-firefox/594/ [18:38:37] werdna: that's just weird. wish I had a better suggestion. [18:39:02] chrismcmahon: well, I mean, I want to find out if phantomjs is even being called [18:39:13] but Macs don't seem to have strace [18:39:15] OSX-- [20:57:46] chrismcmahon: https://www.mediawiki.org/wiki/User:Greg_%28WMF%29/dev_deploy_flow [21:29:10] chrismcmahon: I guess this meeting is going to be hard to follow for you :( [21:29:25] hasharMeeting: I got this :-) [21:29:56] hasharMeeting: I have the model in my mind in great detail [21:30:22] chrismcmahon: changed the camera orientation but i don't think it is going to help out :D [21:38:18] Project Translate-meta.wikimedia.org-linux-firefox build #103: FAILURE in 1 min 8 sec: https://wmf.ci.cloudbees.com/job/Translate-meta.wikimedia.org-linux-firefox/103/ [21:42:16] Project MobileFrontend-test2.m.wikipedia.org-linux-firefox build #216: FAILURE in 30 min: https://wmf.ci.cloudbees.com/job/MobileFrontend-test2.m.wikipedia.org-linux-firefox/216/