[01:25:09] (03CR) 10Ori.livneh: [C: 031] "Looks right to me. Hashar?" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/109430 (owner: 10Adamw) [08:10:49] While using vagrant, I cant get all the feature tests runing in my browser [08:12:14] vagrant should use the mediawiki hosted in my localhost right ? [12:18:59] (03PS1) 10Zfilipin: Removed Siebrand from e-mail notifications. [selenium] - 10https://gerrit.wikimedia.org/r/109467 [12:36:46] zeljkof: you there ? [12:36:55] hi tonythomas01 [12:37:05] hi mayankmadan_ [12:37:24] i was working on removing sleep from TwnMainPage [12:37:41] the sleep statement was in When(I click a message group$) [12:38:07] tonythomas01, can you send a github link to the file? [12:38:33] so, the corresponding feature codes where in line 54 - 59 in signed_in_and_approved_users.feature [12:38:34] wait [12:38:41] I will send the links [12:39:27] feture file https://github.com/wikimedia/mediawiki-extensions-TwnMainPage/blob/master/tests/browser/features/signed_in_and_approved_users.feature [12:39:42] ste[ fo;e https://github.com/wikimedia/mediawiki-extensions-TwnMainPage/blob/master/tests/browser/features/step_definitions/signed_in_and_approved_user_steps.rb [12:39:50] *step file [12:41:40] mayankmadan_: got that ? [12:42:00] tonythomas01, working on something else, will reply in 10-15mins [12:42:11] mayankmadan_: ok ;) [12:42:21] mayankmadan_: only one thing [12:42:36] all the default scenarios will give a pass when executed right ? [12:42:42] in the current state ? [12:43:04] tonythomas01, i really dont know much about TWN [12:43:21] tonythomas01, but they should if they are executed correctly [12:43:22] ok :) [12:43:32] mayankmadan_: but that's what not happening [12:43:52] when I give bundle exec cucumber features/signed_in_and_approved_users.feature:54 [12:43:58] it executes and give 1 failed [12:45:21] tonythomas01, can you post the output to etherpad? [12:45:40] mayankmadan_: doing a rerun again. will post the output in a while [12:46:41] mayankmadan_: http://etherpad.wikimedia.org/p/tonythomas01 [12:46:45] here it is [12:47:00] tonythomas01, are you running the tests on sandbox.translatewiki.net ? [12:47:09] nope [12:47:49] on MEDIAWIKI_URL=http://test2.wikipedia.org/wiki/ [12:47:54] tonythomas01, which webpage opens when you run the test? [12:47:57] mayankmadan_: thats correct [12:47:59] ? [12:48:15] tonythomas01, have a look at the top of the file [12:48:15] https://github.com/wikimedia/mediawiki-extensions-TwnMainPage/blob/master/tests/browser/features/signed_in_and_approved_users.feature [12:48:37] there is a cucumber tag specifying the server for it to run on [12:48:51] mayankmadan_: oh ! never saw that [12:49:04] only the URL needs to be changed right ? [12:49:06] tonythomas01, and i think it will still wont work [12:49:14] mayankmadan_: why ? [12:49:23] tonythomas01, the test is for approved users on translatewiki [12:49:40] im not sure [12:49:42] as i said [12:49:48] im not familiar with TWN [12:50:10] oh ~ :( let me register [12:54:01] mayankmadan_: now got 1 passed ;) [12:54:04] thanks [13:19:14] but scenarios 23:34:47 fails though [13:23:36] tonythomas01, maybe this is just for the approved users [13:36:42] zeljkof: does this one looks ok ?https://gerrit.wikimedia.org/r/#/c/109471/1/tests/browser/features/step_definitions/signed_in_and_approved_user_steps.rb [13:37:13] hi tonythomas01 [13:37:17] hi ! [13:37:20] just a second to finish something [13:37:26] zeljkof: ok [13:39:41] tonythomas01: I have left the comment in gerrit [13:39:59] I do not think this is valid ruby: when_visible(timeout = 5) [13:40:08] it should be: when_visible(5) [13:40:23] but I think 5 seconds it default, so it could just be: when_visible [13:40:25] zeljkof, but it should work without the timeout too [13:40:44] mayankmadan_: I did not understand your comment [13:41:05] zeljkof, the timeout argument doesnt need to be specified [13:41:11] mayankmadan_: correct [13:47:40] zeljkof: actually it worked without the timout too [13:47:52] tonythomas01: then remove everything :) [13:47:53] but, since sleep 5 was given , I gave it [13:48:10] what if my connection was slow, and the thing took more time [13:48:15] does things like that affect ? [13:48:27] tonythomas01: yes [13:48:52] zeljkof: thats why I was curious. I am in a considerable slow net today [13:50:36] zeljkof: and one more thing . when_visible(timeout = 5) is valid right ? [13:50:45] as given in https://github.com/cheezy/page-object/wiki/Ajax-Calls [13:51:16] tonythomas01: no [13:51:35] when defining a method this is validf [13:51:37] valid [13:51:51] def method_name(argument = default_value) [13:51:58] when calling a method [13:52:03] method_name [13:52:04] or [13:52:12] zeljkof: ok. got it. it should be when_visible(5) [13:52:16] method_name(something_else) [13:52:28] tonythomas01: yes, but 5 is the default [13:52:33] so it is redundant [13:54:29] tonythomas01: now testing with when_visible [13:58:01] zeljkof: test failed, but passed with when_visible(5) [13:58:17] tonythomas01: then leave (5) :) [13:58:38] ok. uploading new [13:59:38] done [14:04:55] zeljkof, i dont get it [14:05:06] when default timeout is 5, then why isnt it working without it [14:16:08] mayankmadan_: I do not know [14:16:14] I would have to see the test run [15:23:09] mayankmadan: you around [15:23:10] ? [15:24:16] tonythomas01, yep [15:25:15] now removing from VisualEditor [15:25:44] the one in here [15:25:44] https://github.com/wikimedia/mediawiki-extensions-VisualEditor/blob/master/modules/ve-mw/test/browser/features/step_definitions/transclusion_steps.rb#L31 [15:26:45] mayankmadan: the feature was called in line 21 in https://github.com/wikimedia/mediawiki-extensions-VisualEditor/blob/master/modules/ve-mw/test/browser/features/transclusion.feature [15:27:00] wait [15:27:13] the tests needs to be run in test2.wikipedia.org right ?