[08:16:55] hello [08:38:26] zeljkof: you have some ppt or other presentation items, you have prepared regarding to browser tests ? [08:38:41] tonythomas01: I do [08:38:53] zeljkof: can you please share it with me :) [08:38:53] did you check my blog? [08:38:56] filipin.eu? [08:39:04] in a minute [08:39:51] tonythomas01: there is more to come in the next few weeks [08:40:46] zeljkof: Thanks. I have a few students contributing to Mediawiki from my college. Will recommend those [08:41:08] also check QA category on mediawiki.org [08:41:21] zeljkof: hi! I have tagged mediawiki/selenium releases :-] [08:41:29] hashar: thanks :) [08:41:38] zeljkof: ok [08:41:49] zeljkof: and commented on the bug report. Maybe someone on qa list would be willing to write a tiny script to help you bump versions :D [08:43:00] hashar: I will probably write it eventually, but not at the moment [08:54:48] zeljkof: if it is in bugzilla, I am confident it will be done one day :-] [08:57:33] hashar: it would be great if somebody did it instead of me :) [09:02:33] I guess sending a mail to qa will make it happens :-D [10:51:41] (03PS1) 10Hashar: make some jslint voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/110535 [10:52:54] (03PS2) 10Hashar: make jslint voting by default [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/110385 [10:53:03] (03CR) 10Hashar: [C: 032] make jslint voting by default [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/110385 (owner: 10Hashar) [10:53:07] (03PS2) 10Hashar: make some jslint voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/110535 [10:53:10] (03Merged) 10jenkins-bot: make jslint voting by default [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/110385 (owner: 10Hashar) [10:53:13] (03CR) 10Hashar: [C: 032] make some jslint voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/110535 (owner: 10Hashar) [10:54:17] (03CR) 10Hashar: [C: 032] make some jslint voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/110535 (owner: 10Hashar) [10:54:22] (03Merged) 10jenkins-bot: make some jslint voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/110535 (owner: 10Hashar) [12:15:16] (03PS1) 10Hashar: experiment-gating-dependencies [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/110537 [12:15:35] (03CR) 10Hashar: [C: 032] experiment-gating-dependencies [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/110537 (owner: 10Hashar) [12:15:53] (03Merged) 10jenkins-bot: experiment-gating-dependencies [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/110537 (owner: 10Hashar) [12:17:35] (03PS1) 10Hashar: experiment-gating-dependencies [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/110538 [12:17:47] (03CR) 10Hashar: [C: 032] experiment-gating-dependencies [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/110538 (owner: 10Hashar) [12:17:51] (03Merged) 10jenkins-bot: experiment-gating-dependencies [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/110538 (owner: 10Hashar) [14:11:32] manybubbles|sick: hi :D [15:41:15] hi JeffHall got a minute? not sure what was up yesterday, but VE tests are running correctly for me now. otoh, HEADLESS is tanking for me now where it worked yesterday, I am not sure why. [15:42:07] JeffHall: was going to ask for a sanity on running HEADLESS [15:43:21] chrismcmahon: Yeah, I reverted one of ZelJko's changes, and everything started working fine after that (a few individual tests still failing, but I'l look into those this morning) [15:45:16] JeffHall: what I did: yesterday: installed Xvfb, 'gem install headless'. today: download fresh VE repo; edit Gemfile.lock for mediawiki-selenium 0.1.20; bundle install cucumber features/edit...; get "cannot install such file" for headless gem, even though it is installed. does any of that seem suspicious? [15:46:39] chrismcmahon: You got that error about a missing headless gem when you tried to execute one of the feature files? That behavior I have not seen, but like you, I want to start fresh this morning and re-test the HEADLESS support [15:47:49] JeffHall: yes: $ gem list ... headless (1.0.1), then: [15:48:09] $ bundle exec cucumber features/edit_utf8_logged_in.feature [15:48:09] cannot load such file -- headless (LoadError) [15:48:43] JeffHall: so I am a bit perplexed. that should work. [15:48:59] chrismcmahon: OK, I'm getting setup now, will see what happens on my end... [15:53:03] chrismcmahon: OK, I am indeed getting the same error as you - need to revisit the change that was reverted to see how that impacted HEADLESS support (it should not have done...) [15:56:58] JeffHall: what was the change? [15:57:20] JeffHall: I can see something wrong in bundler, but not sure where it went sideways [15:58:20] chrismcmahon: This was the change: https://gerrit.wikimedia.org/r/#/c/110493/1 [16:16:21] JeffHall: OK, I'm running headless properly now, I left out a line in Gemfile.lock. (the bad news is that somehow I have switched to running Ruby 1.9.1 and I'm not sure how I did that) [16:16:47] chrismcmahon: What did you have to drop from Gemfile.lock? [16:19:09] JeffHall: 3 changes to Gemfile.lock: a) add 'headless (1.0.1)' to the main list; b) change 'mediawiki-selenium (0.1.17)' to mediawiki-selenium (0.1.20); c) add 'headless' in the indented list under 'mediawiki-selenium (0.1.20)' [16:20:17] chrismcmahon: OK, that makes sense - I was just getting ready to re-add "headless" to my own local Gemfile.lock, so we're on the same path [16:25:14] chrismcmahon: The only other thing we'll need to redo is to remove the first 3 lines from hooks.rb - those came back as a result of the reversion yesterday evening [16:26:09] JeffHall: hmm, I figured out why I was using my system ruby instead of the RVM ruby, and I fixed, just not sure why it worked at all :-) [16:26:17] I fixed it [16:26:25] [16:26:28] chrismcmahon: Great! [16:26:58] JeffHall: now for the next trick, why did 110493 break the VE tests? [16:28:37] chrismcmahon: I spent over an hour last evening digging into that, and didn't uncover much - nothing was making sense. So with these new local changes, I want to run through all the VE browser tests, to make sure they really will pass [16:31:06] (03PS1) 10Hashar: remove pywikibot-core-tests (not working) [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/110586 [16:32:23] (03CR) 10Chad: [C: 032] remove pywikibot-core-tests (not working) [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/110586 (owner: 10Hashar) [16:32:27] (03Merged) 10jenkins-bot: remove pywikibot-core-tests (not working) [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/110586 (owner: 10Hashar) [18:47:34] chrismcmahon: I've run thru all the VE browser tests locally, and things seem to be fine now with this update: https://gerrit.wikimedia.org/r/#/c/110606/ [19:08:54] JeffHall: I'd like to wait to have Zeljko look that over before +2 [19:10:02] chrismcmahon: OK [19:10:39] JeffHall: because I think he wanted to something more specialer with versions, but I don't know the details [20:35:35] (03CR) 10Jhall: [C: 031] Moved Sauce Labs browser configuration to mediawiki-selenium Ruby gem [qa/browsertests] - 10https://gerrit.wikimedia.org/r/109897 (owner: 10Zfilipin) [20:36:24] JeffHall, I like this HEADLESS and would like to subscribe to your newsletter. is there doc for running cucumber headless? [20:36:52] spage: Yes, we just updated the wiki info on that - hold on a sec... [20:37:58] spage: It just boils down to a new HEADLESS environment variable, which is described here: https://www.mediawiki.org/wiki/Quality_Assurance/Browser_testing/Running_tests#Running_the_tests [20:38:55] spage: Note that it (unfortunately) only runs headlessly on Linux, not on Mac OS [20:39:04] JeffHall++ I occasionally try BROWSER_LABEL=phantomjs for the Flow tests but I if phantomjs is failing or the test. [20:39:12] s/I/I'm unsure / [20:40:02] spage: Yeah, we spent a lot of time trying to get phantomjs to do everything we wanted, and eventually gave up in favor of headless Chrome or Firefox [20:50:42] (03CR) 10Jhall: [C: 032] "Patch set 6 looks great - working as expected!" [qa/browsertests] - 10https://gerrit.wikimedia.org/r/103497 (owner: 10M4tx) [20:52:14] (03Merged) 10jenkins-bot: Create additional browser test for Preferences "User Profile" tab [qa/browsertests] - 10https://gerrit.wikimedia.org/r/103497 (owner: 10M4tx) [21:03:26] JeffHall: I rewrote for consistency, linked xvfb [21:04:21] spage: Excellent - thanks! [21:31:18] chrismcmahon, JeffHall : that reminds me, on Wed I rewrote https://www.mediawiki.org/wiki/Quality_Assurance/Browser_testing/Setup_instructions to explain what the heck rvm is doing [21:31:54] Now I realize I added it to #Ruby_on_Mac, fixing... [21:50:52] spage: also, apropos of your rvm experience, I added a final line to https://www.mediawiki.org/wiki/Quality_Assurance/Browser_testing/Setup_instructions#Ruby_on_Linux that might be helpful. It was documented only in an obscure page [22:09:54] chrismcmahon: yes, that shouldn't be necessary because rvm fiddles with your shell. But it takes new window, tweaking, etc. I put it all in one section in Linux, I have no idea how much applies to ruby on Mac. [23:35:07] (03PS1) 10Brian Wolff: Add Jack Phoenix. He's been here for about 6 years. [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/110658 [23:39:59] (03CR) 10Bartosz Dziewoński: [C: 031] Add Jack Phoenix. He's been here for about 6 years. [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/110658 (owner: 10Brian Wolff) [23:41:46] (03CR) 10Alex Monk: [C: 031] Add Jack Phoenix. He's been here for about 6 years. [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/110658 (owner: 10Brian Wolff) [23:58:58] (03PS1) 10Brian Wolff: Add several users who now have quite a few commits [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/110661