[06:02:33] (03CR) 10Krinkle: "Pushed 'mediawiki-core-jslint'." [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/111964 (owner: 10Krinkle) [06:02:37] (03CR) 10Krinkle: [C: 032] Separate job for mediawiki-core-jslint to use git-mwcore scm [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/111964 (owner: 10Krinkle) [06:02:56] (03Merged) 10jenkins-bot: Separate job for mediawiki-core-jslint to use git-mwcore scm [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/111964 (owner: 10Krinkle) [10:47:42] (03PS1) 10Zfilipin: Moved tests from root folder to tests/browser folder [qa/browsertests] - 10https://gerrit.wikimedia.org/r/111997 [10:55:27] Hi zeljkof_ [10:55:39] hi mayankmadan! :) [10:55:43] long time no see! [10:55:54] Was really busy with school exams [10:58:24] mayankmadan: we were also pretty busy [10:59:05] I still did not have the time to review your commits :( but it is on my todo list for this month [10:59:28] (03PS1) 10Zfilipin: Moved Selenium tests from root folder of qa/browsertests repository to tests/browser folder [selenium] - 10https://gerrit.wikimedia.org/r/111998 [11:00:25] (03CR) 10Zfilipin: "Please merge at the same time as https://gerrit.wikimedia.org/r/#/c/111997" [selenium] - 10https://gerrit.wikimedia.org/r/111998 (owner: 10Zfilipin) [11:00:38] (03CR) 10Zfilipin: [C: 032] Moved tests from root folder to tests/browser folder [qa/browsertests] - 10https://gerrit.wikimedia.org/r/111997 (owner: 10Zfilipin) [11:00:45] (03Merged) 10jenkins-bot: Moved tests from root folder to tests/browser folder [qa/browsertests] - 10https://gerrit.wikimedia.org/r/111997 (owner: 10Zfilipin) [11:02:20] (03CR) 10Zfilipin: "Apologies for self-merging this, I did not want to merge this, I wanted to leave a comment, but the new Gerrit UI got me confused. :(" [qa/browsertests] - 10https://gerrit.wikimedia.org/r/111997 (owner: 10Zfilipin) [11:18:15] (03CR) 10Zfilipin: "To make sure everything works fine, I have started one job:" [qa/browsertests] - 10https://gerrit.wikimedia.org/r/111997 (owner: 10Zfilipin) [11:48:23] (03PS1) 10Zfilipin: Renamed mediawiki-selenium Ruby gem to mediawiki_selenium [selenium] - 10https://gerrit.wikimedia.org/r/112005 [11:51:37] (03CR) 10KartikMistry: [C: 031] "LGTM." [selenium] - 10https://gerrit.wikimedia.org/r/112005 (owner: 10Zfilipin) [11:59:49] (03PS1) 10Zfilipin: Fixed several "gem build" warnings [selenium] - 10https://gerrit.wikimedia.org/r/112007 [12:08:53] (03PS1) 10Zfilipin: Marked gem as deprecated [selenium] - 10https://gerrit.wikimedia.org/r/112008 [12:11:26] (03Abandoned) 10Zfilipin: Marked gem as deprecated [selenium] - 10https://gerrit.wikimedia.org/r/112008 (owner: 10Zfilipin) [12:17:52] (03PS1) 10Zfilipin: Renamed mediawiki-selenium Ruby gem to mediawiki_selenium [qa/browsertests] - 10https://gerrit.wikimedia.org/r/112009 [13:27:49] (03CR) 10Manybubbles: [C: 032] "The linked bug gives the reasoning for this: the standard naming convention for gems is thing_thing not thing-thing." [selenium] - 10https://gerrit.wikimedia.org/r/112005 (owner: 10Zfilipin) [13:27:51] (03Merged) 10jenkins-bot: Renamed mediawiki-selenium Ruby gem to mediawiki_selenium [selenium] - 10https://gerrit.wikimedia.org/r/112005 (owner: 10Zfilipin) [13:59:53] hashar_: what is the current fix to be able to access e.g. beta from within another labs-instance? [14:00:14] Tobi_WMDE: we wrote a puppet class to workaround it [14:00:26] Tobi_WMDE: which apply some iptables NAT tweaks to let instances access the public IP [14:00:46] Tobi_WMDE: can't remember the bug # . Do you still have an issue? [14:01:49] hashar_: yes, I'm trying to run selenium tests on our wikidata-jenkins instance using phantomjs. [14:02:01] Tobi_WMDE: we have rules such as http://paste.debian.net/80643/ [14:02:15] so, phantomjs needs to access wikidata.beta.wmflabs.org [14:03:05] hashar_: ok. will try if I can get something like this to work [14:03:09] thx [14:04:54] ahhh [14:05:07] where is wikidata-jenkins instance ? In wmf labs? [14:09:59] hashar_: yes [14:11:06] So to apply the NAT fix one could apply the role::beta::natfix puppet class [14:11:33] hashar_: ok. we'll try that [14:11:34] the fw rules are managed by an utility named ferm [14:11:44] watchout: the default policy is to DROP packets by default [14:12:01] though ssh should still be allowed :D [14:14:21] hashar_: so we just try to do something similar to https://gerrit.wikimedia.org/r/#/c/101192/ right? [14:23:34] Tobi_WMDE: yup [14:23:42] Tobi_WMDE: and role::beta::natfix should achieve that for you [14:24:15] the rational is the first comment of https://bugzilla.wikimedia.org/show_bug.cgi?id=45868 [14:37:47] (03PS2) 10Manybubbles: Add option to take screenshot of failure [selenium] - 10https://gerrit.wikimedia.org/r/111840 [15:06:22] (03PS3) 10Manybubbles: Add option to take screenshot of failure [selenium] - 10https://gerrit.wikimedia.org/r/111840 [15:07:15] (03PS1) 10Manybubbles: Add a gemfile to force a good version of ruby [selenium] - 10https://gerrit.wikimedia.org/r/112027 [15:07:52] (03CR) 10Manybubbles: [C: 032] Fixed several "gem build" warnings [selenium] - 10https://gerrit.wikimedia.org/r/112007 (owner: 10Zfilipin) [15:07:54] (03Merged) 10jenkins-bot: Fixed several "gem build" warnings [selenium] - 10https://gerrit.wikimedia.org/r/112007 (owner: 10Zfilipin) [15:10:47] (03PS4) 10Manybubbles: Add option to take screenshot of failure [selenium] - 10https://gerrit.wikimedia.org/r/111840 [15:14:39] (03CR) 10Zfilipin: [C: 031] "Jeff, Chris, can you take a look? Do you think this should be added to the gem?" [selenium] - 10https://gerrit.wikimedia.org/r/111840 (owner: 10Manybubbles) [15:44:25] (03PS2) 10Zfilipin: Add a Gemfile to force a good version of Ruby [selenium] - 10https://gerrit.wikimedia.org/r/112027 (owner: 10Manybubbles) [15:46:25] (03CR) 10Zfilipin: "I have removed 'source "https://rubygems.org"' line. It is not needed, since we are not installing any gems, just using the file to switch" [selenium] - 10https://gerrit.wikimedia.org/r/112027 (owner: 10Manybubbles) [15:47:05] (03CR) 10Zfilipin: [C: 031] Add a Gemfile to force a good version of Ruby [selenium] - 10https://gerrit.wikimedia.org/r/112027 (owner: 10Manybubbles) [16:00:45] zeljkof: hello [16:01:00] hashar_: in a meeting with chrismcmahon [16:01:11] hi hashar_ [16:01:11] zeljkof: sorry I have been quiet for the last two days... Finally found the issue that prevented VE to reach Parsoid for the ve jenkins job :-] [16:01:50] (03CR) 10Cmcmahon: [C: 032] Renamed mediawiki-selenium Ruby gem to mediawiki_selenium [qa/browsertests] - 10https://gerrit.wikimedia.org/r/112009 (owner: 10Zfilipin) [16:03:54] hashar_: great news [16:07:09] (03PS2) 10Zfilipin: Moved Selenium tests from root folder of qa/browsertests repository to tests/browser folder [selenium] - 10https://gerrit.wikimedia.org/r/111998 [16:07:48] (03CR) 10Cmcmahon: [C: 032] Moved Selenium tests from root folder of qa/browsertests repository to tests/browser folder [selenium] - 10https://gerrit.wikimedia.org/r/111998 (owner: 10Zfilipin) [16:13:39] (03PS3) 10Manybubbles: Add a Gemfile to force a good version of Ruby [selenium] - 10https://gerrit.wikimedia.org/r/112027 [16:15:15] (03CR) 10Cmcmahon: [C: 032] Add a Gemfile to force a good version of Ruby [selenium] - 10https://gerrit.wikimedia.org/r/112027 (owner: 10Manybubbles) [16:20:40] (03PS6) 10Manybubbles: Add option to take screenshot of failure [selenium] - 10https://gerrit.wikimedia.org/r/111840 [16:20:45] (03CR) 10Cmcmahon: [C: 032] Add option to take screenshot of failure [selenium] - 10https://gerrit.wikimedia.org/r/111840 (owner: 10Manybubbles) [16:21:45] manybubbles1: it is great to see you enhancing the browser testing system :-] [16:21:59] I try [16:22:08] you might want to document SCREENSHOT_FAILURES though :-] [17:04:43] James_F: chrismcmahon: zeljkof: first VE browser tests in labs: http://integration.wikimedia.org/ci/job/Visualeditor-doitall/52/console :-] [17:04:58] they are not working yet but at least the basic Jenkins / labs env is set up [17:08:56] (03PS17) 10Hashar: (WIP) (WIP) visualeditor-doitall (WIP) (WIP) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/100800 [17:09:04] hashar_: those are running under Xvfb? [17:09:40] yes [17:09:44] with firefox headless [17:10:00] hashar_: awesome! [17:12:34] just a pity there is a bunch of things not working though :(- [17:18:25] hashar_: Awesome. :-) [17:18:46] And yes, timeouts not working make me sad. [17:19:43] still a work in progress [17:19:43] hashar_: Is there a particular reason https://gerrit.wikimedia.org/r/#/c/112034/ isn't based off master? It looks good to go from my POV… [17:20:03] James_F: ah yeah it depends on some change made by jeffhall [17:20:07] Ah, OK. [17:20:11] so I can ran the browser tests in jenkins including both changes [17:20:15] * James_F nods. [17:20:25] A change in the tests? [17:20:27] there is no urgency to get those patch merged in as i understand [17:20:42] 'Cos your code doesn't change the tests, and his doesn't change VE itself… :-) [17:20:48] yeah jeff added some more tests at https://gerrit.wikimedia.org/r/#/c/111890/2 [17:20:50] * James_F was just confused. [17:20:53] hehe [17:20:53] * James_F nods. [17:21:33] commented there [17:21:41] we have our quarterly review next week [17:21:50] * James_F nods. [17:21:53] really hope to have something more or less working when it happens [17:21:59] Absolutely. [17:40:29] i am off! [17:40:34] have a good day/afternoon/weekend [17:53:19] Bye hashar_ :-) [19:52:33] (03PS1) 10Krinkle: Create mediawiki-core-npm [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/112056 [19:54:44] (03CR) 10Krinkle: [C: 032] "Pushed 'mediawiki-core-npm' to Jenkins (not enabled anywhere, just for testing)." [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/112056 (owner: 10Krinkle) [19:55:01] (03Merged) 10jenkins-bot: Create mediawiki-core-npm [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/112056 (owner: 10Krinkle) [20:11:44] (03PS1) 10Hashar: python jobs for mediawiki/tools/scap [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/112058 [20:11:58] (03CR) 10Hashar: [C: 032] python jobs for mediawiki/tools/scap [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/112058 (owner: 10Hashar) [20:13:24] (03PS1) 10Hashar: python jobs for mediawiki/tools/scap [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/112059 [20:13:35] (03CR) 10jenkins-bot: [V: 04-1] python jobs for mediawiki/tools/scap [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/112059 (owner: 10Hashar) [20:13:38] (03Merged) 10jenkins-bot: python jobs for mediawiki/tools/scap [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/112058 (owner: 10Hashar) [20:15:16] (03PS2) 10Hashar: python jobs for mediawiki/tools/scap [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/112059 [20:15:40] (03CR) 10Hashar: [C: 032] python jobs for mediawiki/tools/scap [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/112059 (owner: 10Hashar) [20:15:46] (03Merged) 10jenkins-bot: python jobs for mediawiki/tools/scap [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/112059 (owner: 10Hashar) [23:12:32] (03PS1) 10Zfilipin: Bumped patch version to 0.2.1 [selenium] - 10https://gerrit.wikimedia.org/r/112138 [23:57:15] (03CR) 10Jhall: [C: 031] Bumped patch version to 0.2.1 [selenium] - 10https://gerrit.wikimedia.org/r/112138 (owner: 10Zfilipin)