[12:33:28] <grrrit-wm>	 (03PS5) 10Hashar: Adding DonationInterface test runner [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/71727 (owner: 10MarkTraceur)
[12:54:28] <grrrit-wm>	 (03PS6) 10Hashar: Adding DonationInterface test runner [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/71727 (owner: 10MarkTraceur)
[12:55:18] <grrrit-wm>	 (03CR) 10Hashar: "fixed up path to PHPUNIT" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/71727 (owner: 10MarkTraceur)
[13:00:28] <grrrit-wm>	 (03PS1) 10Hashar: trigger mwext-DonationInterface-testextensions-master [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/112440 
[13:01:39] <grrrit-wm>	 (03CR) 10Hashar: [C: 032] "Will try to get the DonationInterface tests to be runnable using:" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/112440 (owner: 10Hashar)
[13:01:43] <grrrit-wm>	 (03Merged) 10jenkins-bot: trigger mwext-DonationInterface-testextensions-master [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/112440 (owner: 10Hashar)
[13:02:43] <grrrit-wm>	 (03CR) 10Hashar: "Trying with the generic job Zuul triggers are https://gerrit.wikimedia.org/r/#/c/112440/" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/71727 (owner: 10MarkTraceur)
[13:33:14] <hashar>	 zeljkof: hello :-]
[13:33:24] <zeljkof>	 hi hashar
[13:33:48] <hashar>	 I fixed up the Visual editor browser test job
[13:33:56] <hashar>	 but it is failing because it can't find And I click Review your changes
[13:34:06] <hashar>	 i can't remember if I talked to you about it or if it was with jeff
[13:34:12] <hashar>	 log console http://integration.wikimedia.org/ci/job/Visualeditor-doitall/52/consoleFull
[13:34:14] <zeljkof>	 probably jeff
[13:34:36] <zeljkof>	 do you have a screen shot?
[13:34:39] <hashar>	 also manybubbles added support to capture screenshots, I am wondering if it could help us diagnose
[13:34:41] <hashar>	 hehe
[13:34:48] <zeljkof>	 hashar: yes, that could help
[13:34:49] <hashar>	 with firefox headless, I am not sure we can
[13:34:57] <zeljkof>	 sure we can :)
[13:35:00] <zeljkof>	 that is the poing
[13:35:02] <zeljkof>	 poing
[13:35:04] <hashar>	 point
[13:35:04] <zeljkof>	 point :)
[13:35:05] <hashar>	 ?
[13:35:06] <hashar>	 :D
[13:35:12] <hashar>	 any doc to configure it ?
[13:35:22] <hashar>	 I noticed the env variable has been added but no doc was attached to the change
[13:35:24] <zeljkof>	 it should be in the readme, let me see
[13:35:47] <hashar>	 would need a way to specify the destination dir as well
[13:36:00] <zeljkof>	 hashar: patches welcome :)
[13:36:30] <zeljkof>	 hashar: no docs, but the code says you should set SCREENSHOT_FAILURES env variable to true
[13:36:36] <zeljkof>	 https://github.com/wikimedia/mediawiki-selenium/blob/master/lib/mediawiki_selenium/hooks.rb#L32
[13:36:43] <hashar>	 is that in mediawiki/selenium ?
[13:36:48] <zeljkof>	 yes
[13:37:02] <zeljkof>	 https://gerrit.wikimedia.org/r/#/admin/projects/mediawiki/selenium
[13:37:41] <hashar>	 easy :D
[13:38:14] <hashar>	 btw, the fix was https://gerrit.wikimedia.org/r/#/c/112034/
[13:38:25] <hashar>	 on Jenkins we have MediaWiki to use a proxy
[13:38:37] <hashar>	 but it should not use the proxy to access the parsoid service (which is on localhosst)
[13:38:41] <hashar>	 took me a while to figure it out :(
[13:39:07] <zeljkof>	 wow
[13:41:07] <hashar>	 zeljkof: how does one update the Gemfile.lock ?
[13:41:37] <zeljkof>	 it gets updated automatically
[13:41:50] <hashar>	 yeah but which command should I run ? :D
[13:41:51] <zeljkof>	 when you run bundle update in the folder where Gemfile is located
[13:41:56] <hashar>	 ahh
[13:42:44] <grrrit-wm>	 (03Abandoned) 10Zfilipin: WIP moving code to the gem [qa/browsertests] - 10https://gerrit.wikimedia.org/r/93456 (owner: 10Zfilipin)
[13:43:18] <grrrit-wm>	 (03Abandoned) 10Zfilipin: WIP Move UploadWizard tests to UploadWizard repository [qa/browsertests] - 10https://gerrit.wikimedia.org/r/92875 (owner: 10Zfilipin)
[13:43:20] <hashar>	 Could not find gem 'mediawiki_ruby_api_client (>= 0) ruby' in the gems available on this machine.
[13:43:20] <hashar>	 :(
[13:43:39] <zeljkof>	 hashar: the gem is renamed to mediawiki_api
[13:43:55] <zeljkof>	 hashar: do you have the latest commit of the repo?
[13:43:59] <zeljkof>	 Gemfile should be updated
[13:44:42] <grrrit-wm>	 (03Abandoned) 10Zfilipin: WIP moving code to the gem [selenium] - 10https://gerrit.wikimedia.org/r/93437 (owner: 10Zfilipin)
[13:44:46] <hashar>	 I rebased the VE patch I was using
[13:45:28] <grrrit-wm>	 (03Abandoned) 10Zfilipin: WIP move shared login code to the gem [selenium] - 10https://gerrit.wikimedia.org/r/100376 (owner: 10Zfilipin)
[13:45:52] <grrrit-wm>	 (03Abandoned) 10Zfilipin: WIP moving login code to the gem [selenium] - 10https://gerrit.wikimedia.org/r/97036 (owner: 10Zfilipin)
[13:46:00] <zeljkof>	 hashar: works now?
[13:47:09] <grrrit-wm>	 (03PS1) 10Hashar: Document how to update Gemfile && Gemfile.lock [selenium] - 10https://gerrit.wikimedia.org/r/112445 
[13:47:40] <hashar>	 still working on it
[13:58:17] <grrrit-wm>	 (03PS1) 10Hashar: Doc for screenshot and let us specify destination [selenium] - 10https://gerrit.wikimedia.org/r/112446 
[13:58:23] <hashar>	 zeljkof: ^^^:D
[13:58:51] <zeljkof>	 hashar: will take a look later, in the middle of something else
[13:58:52] <hashar>	 might want to get others to look at it :D
[14:01:22] <grrrit-wm>	 (03PS18) 10Hashar: (WIP) (WIP) visualeditor-doitall (WIP) (WIP) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/100800 
[14:04:33] <grrrit-wm>	 (03PS1) 10Zfilipin: Moved files to support folder [selenium] - 10https://gerrit.wikimedia.org/r/112447 
[14:07:26] <hashar>	 00:01:00.525 uninitialized constant MediawikiRubyApiClient (NameError)
[14:07:28] <hashar>	 oh no :D
[14:08:47] <hashar>	 I guess I need to rename MediawikiRubyApiClient to MediawikiApi
[14:15:48] <grrrit-wm>	 (03PS2) 10Hashar: Doc for screenshot and let us specify destination [selenium] - 10https://gerrit.wikimedia.org/r/112446 
[14:18:40] <grrrit-wm>	 (03PS1) 10Zfilipin: Moved LoginPage class and URL module to mediawiki_selenium Ruby gem [qa/browsertests] - 10https://gerrit.wikimedia.org/r/112448 
[14:20:25] <grrrit-wm>	 (03PS1) 10Zfilipin: Moved LoginPage class and URL module to the gem [selenium] - 10https://gerrit.wikimedia.org/r/112449 
[14:23:55] <hashar>	 zeljkof: apparently it takes screenshots :D
[14:24:14] <zeljkof>	 hashar: of course it does :)
[14:28:40] <grrrit-wm>	 (03PS19) 10Hashar: (WIP) (WIP) visualeditor-doitall (WIP) (WIP) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/100800 
[14:29:06] <grrrit-wm>	 (03PS20) 10Hashar: (WIP) (WIP) visualeditor-doitall (WIP) (WIP) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/100800 
[14:29:52] <hashar>	 http://integration.wikimedia.org/ci/job/Visualeditor-doitall/ws/extensions/VisualEditor/modules/ve-mw/test/browser/screenshots/ :D
[14:31:24] <grrrit-wm>	 (03PS21) 10Hashar: (WIP) (WIP) visualeditor-doitall (WIP) (WIP) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/100800 
[14:54:53] <grrrit-wm>	 (03PS3) 10Manybubbles: Doc for screenshot and let us specify destination [selenium] - 10https://gerrit.wikimedia.org/r/112446 (owner: 10Hashar)
[14:56:09] <grrrit-wm>	 (03CR) 10Manybubbles: [C: 031] "Fixed a tab vs space issue, tested it (works), and changed example to drop screenshots into subdir of /tmp because I hate things that shoo" [selenium] - 10https://gerrit.wikimedia.org/r/112446 (owner: 10Hashar)
[14:56:42] <grrrit-wm>	 (03CR) 10Manybubbles: [C: 032] Document how to update Gemfile && Gemfile.lock [selenium] - 10https://gerrit.wikimedia.org/r/112445 (owner: 10Hashar)
[14:56:47] <grrrit-wm>	 (03Merged) 10jenkins-bot: Document how to update Gemfile && Gemfile.lock [selenium] - 10https://gerrit.wikimedia.org/r/112445 (owner: 10Hashar)
[14:58:01] <grrrit-wm>	 (03CR) 10Manybubbles: [C: 032] Moved files to support folder [selenium] - 10https://gerrit.wikimedia.org/r/112447 (owner: 10Zfilipin)
[14:58:04] <grrrit-wm>	 (03Merged) 10jenkins-bot: Moved files to support folder [selenium] - 10https://gerrit.wikimedia.org/r/112447 (owner: 10Zfilipin)
[15:09:22] <grrrit-wm>	 (03PS1) 10Zfilipin: Renamed remaining instances of mediawiki-selenium to mediawiki_selenium [selenium] - 10https://gerrit.wikimedia.org/r/112455 
[15:09:24] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Renamed remaining instances of mediawiki-selenium to mediawiki_selenium [selenium] - 10https://gerrit.wikimedia.org/r/112455 (owner: 10Zfilipin)
[15:09:48] <grrrit-wm>	 (03Abandoned) 10Zfilipin: Renamed remaining instances of mediawiki-selenium to mediawiki_selenium [selenium] - 10https://gerrit.wikimedia.org/r/112455 (owner: 10Zfilipin)
[15:11:32] <grrrit-wm>	 (03PS1) 10Zfilipin: Renamed remaining instances of mediawiki-selenium to mediawiki_selenium [selenium] - 10https://gerrit.wikimedia.org/r/112456 
[15:14:36] <grrrit-wm>	 (03CR) 10Manybubbles: [C: 032] Renamed remaining instances of mediawiki-selenium to mediawiki_selenium [selenium] - 10https://gerrit.wikimedia.org/r/112456 (owner: 10Zfilipin)
[15:31:49] <grrrit-wm>	 (03PS1) 10Zfilipin: Moved Given(/^I am logged in$/) step to the gem [selenium] - 10https://gerrit.wikimedia.org/r/112459 
[15:34:20] <grrrit-wm>	 (03PS1) 10Zfilipin: Moved Given(/^I am logged in$/) step to mediawiki_selenium Ruby gem [qa/browsertests] - 10https://gerrit.wikimedia.org/r/112460 
[15:35:50] <grrrit-wm>	 (03CR) 10KartikMistry: [C: 031] "LGTM." [selenium] - 10https://gerrit.wikimedia.org/r/112459 (owner: 10Zfilipin)
[15:37:02] <grrrit-wm>	 (03CR) 10Manybubbles: "Why merge still pending?" [selenium] - 10https://gerrit.wikimedia.org/r/112456 (owner: 10Zfilipin)
[15:39:13] <hashar>	 manybubbles: thank you :-]
[15:39:27] <hashar>	 manybubbles: the screenshot feature ends up working when using a headless  firefox \O/
[15:39:32] <manybubbles>	 yeah
[15:39:39] <manybubbles>	 I added it for that!
[15:39:49] <manybubbles>	 because it helps me debug headless errors without retrying unheadless
[16:28:30] <grrrit-wm>	 (03PS1) 10Zfilipin: Moved resetting preferences to the gem [selenium] - 10https://gerrit.wikimedia.org/r/112474 
[16:29:39] <grrrit-wm>	 (03PS2) 10Zfilipin: Moved resetting preferences to the gem [selenium] - 10https://gerrit.wikimedia.org/r/112474 
[16:31:09] <grrrit-wm>	 (03CR) 10Hashar: [C: 031] "Thank you Nik! Will let Zelkof/Chris/Jeff to merge this" [selenium] - 10https://gerrit.wikimedia.org/r/112446 (owner: 10Hashar)
[16:34:25] <grrrit-wm>	 (03PS2) 10Zfilipin: Moved Given(/^I am logged in$/) step to mediawiki_selenium Ruby gem [qa/browsertests] - 10https://gerrit.wikimedia.org/r/112460 
[16:36:01] <hashar>	 \O/
[16:47:29] <grrrit-wm>	 (03CR) 10KartikMistry: [C: 031] "LGTM" [selenium] - 10https://gerrit.wikimedia.org/r/112474 (owner: 10Zfilipin)
[19:42:22] <grrrit-wm>	 (03CR) 10Cmcmahon: "I understand why login_steps is moved to the shared gem, but the is the "Reset preferences" action required in more than one set of tests " [selenium] - 10https://gerrit.wikimedia.org/r/112474 (owner: 10Zfilipin)
[21:46:24] <JeffHall>	 chrismcmahon: For this commit, I'm not using the API create-user method only as a workaround until we actually get that method pulled into the mediawiki_api Rubygem: https://gerrit.wikimedia.org/r/#/c/111890/
[21:47:28] <chrismcmahon>	 JeffHall:  thanks, that's what I figured.  I'm just thinking that we don't merge that one until we have the API create_user for it. 
[21:48:07] <JeffHall>	 chrismcmahon: OK, once the dust settles with the creation of the new gem, I'll submit a pull request with the create-user method and away we go!