[06:10:53] <grrrit-wm>	 (03CR) 10KartikMistry: [C: 031] "LGTM" [qa/browsertests] - 10https://gerrit.wikimedia.org/r/112460 (owner: 10Zfilipin)
[09:06:54] <hashar_>	 :-]
[09:11:21] <zeljkof>	 hashar: I am ready
[09:11:28] <zeljkof>	 ping me when you can pair
[09:11:58] <gry>	 ?
[09:12:10] <gry>	 bluetooth?
[09:21:45] <hashar>	 zeljkof: yup sorry
[09:22:12] <hashar>	 for some reason the tests can't find the [review my changes] button when submitting an edit in VE
[09:22:23] <zeljkof>	 gry: yes, bluetooth :P
[09:22:34] <zeljkof>	 hashar: hangout, or here?
[09:22:40] <hashar>	 there
[09:22:44] <hashar>	 I am in my coworking place 
[09:22:46] <hashar>	 so not ideal
[09:22:47] <gry>	 aww, I wanted to see :p
[09:22:57] <hashar>	 example screenshot for the test "Basic edit": http://integration.wikimedia.org/ci/job/visualeditor-doitall/57/artifact/extensions/VisualEditor/modules/ve-mw/test/browser/screenshots/VisualEditor%3A_Basic_edit.png
[09:23:13] <hashar>	 and the colored console is http://integration.wikimedia.org/ci/job/visualeditor-doitall/57/console
[09:23:22] <hashar>	 And I click Review your changes    fails with a timeout
[09:23:32] <hashar>	 waiting for {:class=>"oo-ui-labeledElement-label", :text=>"Review your changes", :tag_name=>"span"} to become present 
[09:24:47] <zeljkof>	 hashar: ok, let me run the test on my machine
[09:26:26] <zeljkof>	 good news is that visual editor is there
[09:26:30] <zeljkof>	 a step forward
[09:26:38] <hashar>	 yup -]
[09:27:12] <hashar>	 on a previous build, it seems all features are failing on that exact same test
[09:27:33] <zeljkof>	 I am booting vagrant machine with visual editor
[09:27:40] <zeljkof>	 will try running the test there
[09:36:48] <zeljkof>	 hashar: will ping you when I have something, my vagrant vm is behaving strangely
[09:37:01] <zeljkof>	 had to destroy it and created again
[09:37:05] <zeljkof>	 so it is taking some time
[09:37:21] <hashar>	 zeljkof: unfortunate :D
[09:40:22] <grrrit-wm>	 (03CR) 10Zfilipin: "Chris, reset preferences step is used in UniversalLanguageSelector, ContentTranslation and Translate repositories. For this iteration of m" [selenium] - 10https://gerrit.wikimedia.org/r/112474 (owner: 10Zfilipin)
[09:43:45] <zeljkof>	 hashar: ok, VM with VE up and running :)
[09:47:23] <hashar>	 zeljkof: the jenkins job uses a firefox headless browser if that matters
[09:47:30] <zeljkof>	 hashar: should not matter
[09:47:49] <hashar>	 version 27.0
[09:48:18] <zeljkof>	 hashar: so, you checkout the latest VE, then apply this patch? https://gerrit.wikimedia.org/r/#/c/111890/
[09:49:16] <hashar>	 111890,7
[09:49:17] <hashar>	 yup
[09:53:37] <zeljkof>	 hashar: I think Jeff made it more complicated that it needs to be
[09:56:13] <hashar>	 :-D
[09:56:23] <hashar>	 zeljkof: are you reproducing the issue?
[09:56:38] <zeljkof>	 hashar: I am reviewing the code, trying to figure out what is going on
[09:56:52] <hashar>	 I can trigger the job against master
[09:56:52] <zeljkof>	 will try reproducing right now
[09:56:55] <hashar>	 it might fail as well
[09:57:12] <hashar>	 but as I understand it i need https://gerrit.wikimedia.org/r/#/c/111890/ to be able to run headless browser tests
[09:59:55] <zeljkof>	 hashar: ok, so one mistake that you did is this
[10:00:01] <zeljkof>	 ...bundle exec cucumber ...
[10:00:04] <zeljkof>	 it should be 
[10:01:13] <zeljkof>	 ...bundle exec cucumber --tags @clean...
[10:01:30] <zeljkof>	 only tests tagged @clean will pass on a clean wiki instance
[10:01:59] <zeljkof>	 so, just add " --tags @clean" after "cucumber" and it should help
[10:02:07] <zeljkof>	 let me run on my machine to see what happens
[10:02:14] <zeljkof>	 (still not there)
[10:03:42] <hashar>	 zeljkof: well that is going to exclude all tests I guess
[10:03:47] <hashar>	 but yeah you are right, should add it
[10:03:57] <zeljkof>	 hashar: but that is the point, right :)
[10:04:05] <zeljkof>	 most of the tests do not work on a clean wiki
[10:04:20] <zeljkof>	 so jeff has created this one special test that does work on a clean wiki
[10:04:28] <hashar>	 in this case it simply can't find the Review your changes
[10:04:50] <zeljkof>	 hashar: I would not go into details about what is wrong
[10:04:55] <zeljkof>	 let's get one test running fine
[10:04:57] <zeljkof>	 first
[10:05:13] <zeljkof>	 my machine
[10:05:14] <zeljkof>	 $ bundle exec cucumber --tags @clean
[10:05:21] <zeljkof>	 2 scenarios (1 failed, 1 passed)
[10:05:25] <zeljkof>	 let's see what is wrong
[10:05:51] <hashar>	 what is the failure reported?
[10:11:43] <zeljkof>	 hashar: http://etherpad.wikimedia.org/p/ve
[10:12:12] <grrrit-wm>	 (03PS1) 10Hashar: browsertests: replace -p ciwmf with --tags @clean [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/112654 
[10:13:08] <hashar>	 hehe
[10:14:12] <hashar>	 can you try one of the scenario which is failing on the jenkin job?
[10:14:15] <hashar>	 aka the Basic edit one
[10:14:34] <hashar>	 to see whether it can find the [Review your changes] button
[10:15:01] <zeljkof>	 hashar: will do, but let me fix this one first
[10:15:05] <grrrit-wm>	 (03CR) 10Hashar: [C: 032] "Updated jobs. Added reviewers for information." [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/112654 (owner: 10Hashar)
[10:16:47] <grrrit-wm>	 (03Merged) 10jenkins-bot: browsertests: replace -p ciwmf with --tags @clean [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/112654 (owner: 10Hashar)
[10:18:26] <grrrit-wm>	 (03PS22) 10Hashar: (WIP) (WIP) visualeditor-doitall (WIP) (WIP) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/100800 
[10:19:05] <grrrit-wm>	 (03CR) 10Hashar: "Rebased to include ( https://gerrit.wikimedia.org/r/112654 ) which removes the cucumber parameter '-p ciwmf' in favor of --tags @clean." [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/100800 (owner: 10Hashar)
[10:20:22] <zeljkof>	 hashar: ok, my mistake
[10:20:29] <zeljkof>	 forgot to export API_URL
[10:21:00] <zeljkof>	 now it is working fine
[10:21:19] <zeljkof>	 that it, both scenarios tagged @clean pass on my VM wiki
[10:21:44] <zeljkof>	 hashar: do you clean the wiki database for every jenkins job run?
[10:21:51] <hashar>	 yeah
[10:21:55] <hashar>	 entirely fresh db
[10:22:01] <zeljkof>	 ok
[10:22:08] <hashar>	 I am just not sure why it can't find the button
[10:22:10] <zeljkof>	 then this should work
[10:22:21] <zeljkof>	 run only @clean
[10:22:33] <zeljkof>	 I will test now with other scenarios
[10:22:41] <zeljkof>	 who knows what is wrong
[10:24:31] <hashar>	 retriggered job http://integration.wikimedia.org/ci/job/visualeditor-doitall/59/console
[10:24:42] <hashar>	 bundle exec cucumber --color --tags @clean --format pretty --format junit --out /mnt/jenkins-workspace/workspace/visualeditor-doitall/log --format html --out /mnt/jenkins-workspace/workspace/visualeditor-doitall/log/report.html
[10:24:43] <hashar>	 :D
[10:25:43] <zeljkof>	 you did not export API_URL
[10:25:45] <hashar>	 so yeah same issue
[10:25:51] <hashar>	 ??
[10:26:05] <zeljkof>	 hashar: something like this
[10:26:06] <zeljkof>	 $ export API_URL=http://127.0.0.1:8080/w/api.php
[10:26:10] <hashar>	 ahhh crazy
[10:26:17] <hashar>	 we should just give the mw base path
[10:26:26] <zeljkof>	 hashar: probably :)
[10:26:29] <hashar>	 but yeah , will update
[10:26:38] <zeljkof>	 we are just starting with using the API
[10:27:09] <zeljkof>	 not sure about this one
[10:27:09] <zeljkof>	 File name too long - screenshots/VisualEditor_on_a_fresh_Mediawiki_install
[10:27:58] <grrrit-wm>	 (03PS1) 10Hashar: browsertests: set API_URL to api.php [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/112657 
[10:29:00] <grrrit-wm>	 (03CR) 10Hashar: [C: 032] browsertests: set API_URL to api.php [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/112657 (owner: 10Hashar)
[10:29:25] <grrrit-wm>	 (03Merged) 10jenkins-bot: browsertests: set API_URL to api.php [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/112657 (owner: 10Hashar)
[10:29:45] <grrrit-wm>	 (03PS23) 10Hashar: (WIP) (WIP) visualeditor-doitall (WIP) (WIP) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/100800 
[10:30:32] <zeljkof>	 hashar: let's see about this one: timed out after 5 seconds, waiting for {:class=>"oo-ui-labeledElement-label", :text=>"Review your changes", :tag_name=>"span"} to become present (Watir::Wait::TimeoutError)
[10:31:21] <hashar>	 http://integration.wikimedia.org/ci/job/visualeditor-doitall/60/console
[10:31:23] <hashar>	 new run
[10:31:58] <hashar>	 OH MY GOD
[10:32:02] <hashar>	 ONE TEST PASSED !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
[10:32:04] <hashar>	 111BBQ
[10:32:44] <hashar>	 ah it already passed nm
[10:33:13] <hashar>	 yeah the second passed
[10:33:18] <hashar>	 API_URL for the win
[10:33:36] <zeljkof>	 hashar: :)
[10:33:43] <zeljkof>	 the rest of the tests are just to brittle :(
[10:33:55] <zeljkof>	 it would take me a lot of time to fix them to work with a fresh wiki
[10:33:58] <hashar>	 though the error reported at http://integration.wikimedia.org/ci/job/visualeditor-doitall/59/console  is not very clear
[10:34:07] <zeljkof>	 hashar: let me see...
[10:34:15] <hashar>	  must pass :url (ArgumentError)
[10:34:15] <hashar>	  ./features/step_definitions/fresh_wiki_install_steps.rb:22:in `/^I create a new wiki article (.+) with content (.+)$/'
[10:34:31] <hashar>	 should says to set API_URL
[10:34:37] <hashar>	 or skip the test saying API_URL is not set
[10:34:46] <hashar>	 but that is not a big deal for now
[10:35:20] <hashar>	 zeljkof: have you reproduced the tests not finding [review your changes] button ?
[10:35:34] <zeljkof>	 hashar: no, it failed even finding "edit" link :(
[10:35:40] <zeljkof>	 I do not have the time to fix that now
[10:35:41] <hashar>	 :-]
[10:35:46] <zeljkof>	 I will leave it to Jeff :)
[10:35:54] <hashar>	 well we have our showcase this evening
[10:36:05] <zeljkof>	 is the test passing now?
[10:36:11] <hashar>	 no clue
[10:36:20] <hashar>	 I made the job to use --tags @clean
[10:36:26] <zeljkof>	 great
[10:36:27] <hashar>	 so it is not running anything beside two tests
[10:36:31] <zeljkof>	 that is all we can do for now
[10:36:44] <hashar>	 will try with another change which will @clean the  Basic edit scenario
[10:36:48] <zeljkof>	 VE people (probably only Jeff) have to make sure the rest of the tests run on a clean wiki
[10:40:27] <hashar>	 https://gerrit.wikimedia.org/r/112659
[10:40:59] <hashar>	 and triggered at http://integration.wikimedia.org/ci/job/visualeditor-doitall/61/console
[10:42:56] <hashar>	 zeljkof: is there any parameters we can pass to dump the dom ?
[10:43:04] <hashar>	 or something that is a bit more verbose beside screenshots ?
[10:43:27] <zeljkof>	 hashar: sure :)
[10:43:35] <zeljkof>	 you can get page html, enough?
[10:43:56] <hashar>	 anyway I got : http://integration.wikimedia.org/ci/job/visualeditor-doitall/ws/extensions/VisualEditor/modules/ve-mw/test/browser/screenshots/VisualEditor%3A_Basic_edit.png
[10:44:02] <hashar>	 and it can't find the stupid button
[10:44:10] <hashar>	 maybe the text does not exactly match
[10:44:32] <zeljkof>	 hashar: yeah, who knows what is wrong there
[10:44:39] <zeljkof>	 I do not want to open that can of worms :)
[10:44:43] <hashar>	 :-(
[10:44:47] <zeljkof>	 VE tests are not the cleanest one we have
[10:44:54] <hashar>	 and I could not ping Jeff yesterday :-(
[10:45:10] <hashar>	 anyway, appointment, will be back around 2pm
[10:45:34] <zeljkof>	 hasharAway: I have a pairing session with Jeff today 5-6pm our time, feel free to join us
[10:45:50] <hasharAway>	 zeljkof: well need to reproduce the issue first :-]
[10:46:01] <zeljkof>	 hasharAway: good luck :)
[10:46:10] <hasharAway>	 I mean on another installation than the jenkins one 
[10:46:45] <hasharAway>	 if you could attempt running the tests with patch https://gerrit.wikimedia.org/r/#/c/112659/  , would be nice to confirm you have encounter the same error
[10:46:50] <hasharAway>	 will attempt to do that myself this afternoon
[10:46:55] <hasharAway>	 I am off for real now.
[13:22:04] <hashar>	 re
[13:33:12] <hashar>	 zeljkof: you released 0.2.2 of mediawiki/selenium gem but I can't find the version bump in the git repo :(
[13:33:24] <hashar>	 lib/mediawiki_selenium/version.rb still show 0.2.1
[13:33:46] <zeljkof>	 hashar: maybe it is not merged yet
[13:33:48] <zeljkof>	 let me see
[13:33:52] <hashar>	 ohh
[13:34:13] <zeljkof>	 hashar: here it is https://gerrit.wikimedia.org/r/#/c/112474/
[13:34:59] <grrrit-wm>	 (03CR) 10Manybubbles: [C: 032] "This looks just like the login code for Cirrus so I imagine it'll be easy to integrate and I trust the Zfilipin has tested it on his side." [selenium] - 10https://gerrit.wikimedia.org/r/112459 (owner: 10Zfilipin)
[13:37:46] <grrrit-wm>	 (03CR) 10Manybubbles: "Isn't here already a thing in ruby called URL?" [selenium] - 10https://gerrit.wikimedia.org/r/112449 (owner: 10Zfilipin)
[14:25:57] <hashar>	 zeljkof: is there a way to make cucumber a bit more verbose, i.e. to let it dumps what it is doing / expecting from the browser ?
[14:26:55] <zeljkof>	 of course :)
[14:27:09] <zeljkof>	 but I am in a meeting with Amir, can not talk now
[14:27:20] <zeljkof>	 hashar: create a bug :)
[14:35:10] <hashar>	 well
[14:35:15] <hashar>	 it is screwed beyond repair :-D
[14:38:41] <hashar>	 zeljkof: can we lower the 5 seconds timeout somehow ? :-D
[14:38:49] <zeljkof>	 hashar: of course :)
[14:38:57] <zeljkof>	 but please ping me later today, in an hour or so
[14:59:50] <grrrit-wm>	 (03PS1) 10Hashar: Revert "browsertests: replace -p ciwmf with --tags @clean" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/112681 
[15:00:01] <grrrit-wm>	 (03CR) 10Hashar: [C: 032] Revert "browsertests: replace -p ciwmf with --tags @clean" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/112681 (owner: 10Hashar)
[15:00:41] <grrrit-wm>	 (03PS2) 10Hashar: Revert "browsertests: replace -p ciwmf with --tags @clean" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/112681 
[15:00:46] <grrrit-wm>	 (03CR) 10Hashar: [C: 032] Revert "browsertests: replace -p ciwmf with --tags @clean" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/112681 (owner: 10Hashar)
[15:02:27] <hashar>	 had to
[15:02:38] <hashar>	 http://integration.wikimedia.org/ci/job/mwext-browsertests-UniversalLanguageSelector-phantomjs/ does not have any @clean tag :/
[15:20:26] <grrrit-wm>	 (03PS1) 10Hashar: browsertests: bundle install gems in shared dir [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/112682 
[15:20:29] <grrrit-wm>	 (03PS1) 10Hashar: browsertests: take screenshot on fail and archive them [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/112683 
[15:22:54] <grrrit-wm>	 (03CR) 10Hashar: [C: 032] browsertests: bundle install gems in shared dir [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/112682 (owner: 10Hashar)
[15:22:57] <grrrit-wm>	 (03CR) 10Hashar: [C: 032] browsertests: take screenshot on fail and archive them [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/112683 (owner: 10Hashar)
[15:23:10] <grrrit-wm>	 (03Merged) 10jenkins-bot: browsertests: bundle install gems in shared dir [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/112682 (owner: 10Hashar)
[15:23:26] <grrrit-wm>	 (03Merged) 10jenkins-bot: browsertests: take screenshot on fail and archive them [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/112683 (owner: 10Hashar)
[15:28:14] <grrrit-wm>	 (03PS4) 10Hashar: Doc for screenshot and let us specify destination [selenium] - 10https://gerrit.wikimedia.org/r/112446 
[15:28:39] <grrrit-wm>	 (03CR) 10Hashar: "Trivial rebase, conflict in README.md which received an update meanwhile." [selenium] - 10https://gerrit.wikimedia.org/r/112446 (owner: 10Hashar)
[16:14:21] <greg-g>	 chrismcmahon: I copy/massaged the etherpad notes for today's Showcase meeting here: https://www.mediawiki.org/wiki/Wikimedia_Release_and_QA_Team/Meetings
[16:14:53] <chrismcmahon>	 hi greg-g we were just talking abou that
[16:17:04] <greg-g>	 thoughts? :)
[16:18:23] <chrismcmahon>	 greg-g:  we might have a misunderstanding about what "showcase" means.  We were thinking we would  be demonstrating current work, e.g. the first VE headless browser test run under WMF Jenkins to go green:  http://integration.wikimedia.org/ci/job/visualeditor-doitall/60/console
[16:18:57] <grrrit-wm>	 (03CR) 10Jhall: [C: 032] Moved LoginPage class and URL module to the gem [selenium] - 10https://gerrit.wikimedia.org/r/112449 (owner: 10Zfilipin)
[16:19:00] <grrrit-wm>	 (03Merged) 10jenkins-bot: Moved LoginPage class and URL module to the gem [selenium] - 10https://gerrit.wikimedia.org/r/112449 (owner: 10Zfilipin)
[16:19:03] <grrrit-wm>	 (03Merged) 10jenkins-bot: Renamed remaining instances of mediawiki-selenium to mediawiki_selenium [selenium] - 10https://gerrit.wikimedia.org/r/112456 (owner: 10Zfilipin)
[16:19:05] <grrrit-wm>	 (03Merged) 10jenkins-bot: Moved Given(/^I am logged in$/) step to the gem [selenium] - 10https://gerrit.wikimedia.org/r/112459 (owner: 10Zfilipin)
[16:19:19] <chrismcmahon>	 greg-g:  also e.g. the first Flow regression test requested by the Flow team:  https://gerrit.wikimedia.org/r/#/c/112048/
[16:20:31] <greg-g>	 both great, feel free to replace any of the other things on that page with those
[16:21:27] <greg-g>	 I think the first 3 levelA bullets are fitting, the rest can be massaged with things like what you just said
[16:22:50] <hashar>	 zeljkof: back around ? :D
[16:23:12] <zeljkof>	 hashar: sorry, in a meeting with JeffHall and chrismcmahon now :(
[16:23:21] <hashar>	 zeljkof: could use a merge of the patch which created mediawiki_selenium 0.2.2  as well as a new release 0.2.3 which includes the screenshot path :D
[16:23:23] <hashar>	 ahhh
[16:23:34] <chrismcmahon>	 too many meetings today
[16:23:48] <hashar>	 :-]
[16:26:03] <greg-g>	 hashar: see above re /Meetings page
[16:28:48] <hashar>	 tis ok :-D
[16:28:50] <hashar>	 filling in bugs
[16:29:24] <greg-g>	 :)
[16:29:35] <hashar>	 I am really bad at browser testing :D
[16:29:59] <hashar>	 the cucumber/watir/selenium/phantoms/random extension  cause my brain to overflow
[16:46:34] <hashar>	 any idea what are the extensions supporting browsertests ? :D
[16:48:04] <greg-g>	 chrismcmahon: ^ :)
[16:49:39] <grrrit-wm>	 (03PS1) 10Hashar: Job mwext-browsertests-Flow-phantomjs [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/112702 
[16:49:41] <grrrit-wm>	 (03CR) 10Cmcmahon: [C: 032] Doc for screenshot and let us specify destination [selenium] - 10https://gerrit.wikimedia.org/r/112446 (owner: 10Hashar)
[16:49:55] <grrrit-wm>	 (03CR) 10Hashar: [C: 032] Job mwext-browsertests-Flow-phantomjs [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/112702 (owner: 10Hashar)
[16:50:59] <chrismcmahon>	 hashar: greg-g https://github.com/wikimedia/mediawiki-selenium#links
[16:51:14] <grrrit-wm>	 (03CR) 10Hashar: [C: 032] Job mwext-browsertests-Flow-phantomjs [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/112702 (owner: 10Hashar)
[16:51:31] <grrrit-wm>	 (03Merged) 10jenkins-bot: Job mwext-browsertests-Flow-phantomjs [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/112702 (owner: 10Hashar)
[16:51:32] <hashar>	 found out Flow has some browser tests :D
[16:51:59] <chrismcmahon>	 hashar:  I wrote the Flow tests, then S has done some also
[16:52:05] <hashar>	 awesome
[16:52:50] <grrrit-wm>	 (03PS3) 10Zfilipin: Moved resetting preferences to the gem [selenium] - 10https://gerrit.wikimedia.org/r/112474 
[16:54:08] <grrrit-wm>	 (03CR) 10Cmcmahon: [C: 032] "used by 3 Language repos" [selenium] - 10https://gerrit.wikimedia.org/r/112474 (owner: 10Zfilipin)
[17:03:01] <zeljkof>	 hashar: I am free now ;)
[17:06:29] <hashar>	 zeljkof: :-D
[17:06:38] <hashar>	 zeljkof: I filled a bunch of bugs for ULS browser tests failing
[17:06:43] <hashar>	 we will follow up tomorrow I guess :]
[17:06:51] <hashar>	 disconnecting IRC 
[17:36:34] <grrrit-wm>	 (03PS1) 10Hashar: Placeholders for mwext-browsertests [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/112709 
[17:36:47] <grrrit-wm>	 (03CR) 10Hashar: [C: 032] Placeholders for mwext-browsertests [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/112709 (owner: 10Hashar)
[17:37:07] <grrrit-wm>	 (03Merged) 10jenkins-bot: Placeholders for mwext-browsertests [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/112709 (owner: 10Hashar)
[20:03:44] <hashar>	 hiii
[20:31:54] <grrrit-wm>	 (03PS1) 10Hashar: experimental tox based python jobs [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/112795 
[20:32:06] <grrrit-wm>	 (03Abandoned) 10Hashar: experimental tox based python jobs [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/112795 (owner: 10Hashar)
[21:19:19] <grrrit-wm>	 (03PS1) 10Hashar: move pyflakes rule near the pep8 one [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/112807 
[21:19:22] <grrrit-wm>	 (03PS1) 10Hashar: pep8/pyflakes should trigger when setup.cfg is changed [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/112808 
[21:19:28] <grrrit-wm>	 (03CR) 10Hashar: [C: 032] move pyflakes rule near the pep8 one [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/112807 (owner: 10Hashar)
[21:19:32] <grrrit-wm>	 (03CR) 10Hashar: [C: 032] pep8/pyflakes should trigger when setup.cfg is changed [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/112808 (owner: 10Hashar)
[21:19:38] <grrrit-wm>	 (03Merged) 10jenkins-bot: move pyflakes rule near the pep8 one [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/112807 (owner: 10Hashar)
[21:19:40] <grrrit-wm>	 (03Merged) 10jenkins-bot: pep8/pyflakes should trigger when setup.cfg is changed [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/112808 (owner: 10Hashar)
[21:23:23] <grrrit-wm>	 (03CR) 10Jhall: [C: 032] Moved LoginPage class and URL module to mediawiki_selenium Ruby gem [qa/browsertests] - 10https://gerrit.wikimedia.org/r/112448 (owner: 10Zfilipin)
[21:23:36] <grrrit-wm>	 (03Merged) 10jenkins-bot: Moved LoginPage class and URL module to mediawiki_selenium Ruby gem [qa/browsertests] - 10https://gerrit.wikimedia.org/r/112448 (owner: 10Zfilipin)
[21:23:56] <grrrit-wm>	 (03CR) 10Jhall: [C: 032] Moved Given(/^I am logged in$/) step to mediawiki_selenium Ruby gem [qa/browsertests] - 10https://gerrit.wikimedia.org/r/112460 (owner: 10Zfilipin)
[21:24:02] <grrrit-wm>	 (03Merged) 10jenkins-bot: Moved Given(/^I am logged in$/) step to mediawiki_selenium Ruby gem [qa/browsertests] - 10https://gerrit.wikimedia.org/r/112460 (owner: 10Zfilipin)
[21:54:15] <hashar>	 \O/
[21:54:38] <hashar>	 JeffHall: I guess Zeljkof will release yet another version of mediawiki selenium gem tomorrow :D
[21:55:11] <JeffHall>	 hashar: Makes sense, since there were a bunch of related patch sets today
[21:55:33] <hashar>	 and we will be able to capture screenshot in the Jenkins builds :D
[21:55:59] <hashar>	 lame example: http://integration.wikimedia.org/ci/job/visualeditor-doitall/61/
[21:56:09] <hashar>	 that page shows the artifacts, including some screenshot
[21:56:18] <hashar>	 that will make devs life easier
[21:56:27] <JeffHall>	 hashar: Yeah, that will definitely be a useful addition!
[21:56:49] <hashar>	 for some reason they can't be shown in the report :/
[21:57:24] <hashar>	 while we are both around, I have been struck by the VE tests not being able to find the button for "Review your changes"
[21:57:29] <hashar>	 a trace is at http://integration.wikimedia.org/ci/job/visualeditor-doitall/61/artifact/log/report.html
[21:57:51] <hashar>	 I looked at the install and use the dev tool from my browser and the span is there with that class and apparently the same text
[21:57:58] <hashar>	 i have no clue why it can't find it :/
[21:58:53] <JeffHall>	 hashar: Chris, Zeljko, and I paired this morning, and Zeljko found the problem, and that code should be merged now (in the VisualEditor repo)
[21:59:21] <JeffHall>	 hashar: It had to do with updated iframe syntax in the Watir-WebDriver Rubygem
[22:03:02] <hashar>	 ah i noticed that iframe change
[22:03:11] <hashar>	 will give it a look again tomorrow and follow up with zeljkof :]
[22:03:26] <chrismcmahon>	 hi ryasmeen, I am around
[22:03:28] <hashar>	 I am really a newbie when it comes to watir/selenium :(
[22:03:48] <JeffHall>	 hashar: That iframe change should fix the "Review your changes" issue that you've been encountering
[22:23:32] <hashar>	 JeffHall: got to try :-]
[22:28:35] <grrrit-wm>	 (03PS1) 10Subramanya Sastry: Added Hardik Juneja to trusted users for check/test pipeline [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/112818 
[22:34:32] <grrrit-wm>	 (03CR) 10Hashar: [C: 04-1] Added Hardik Juneja to trusted users for check/test pipeline (031 comment) [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/112818 (owner: 10Subramanya Sastry)
[22:36:46] <hashar>	 JeffHall: that is still failing for me somehow. I guess I will check with zelkof tomorrow
[22:36:52] <hashar>	 too late for me to dig in it tonight :D
[22:37:06] <hashar>	 for what it is worth, the job console is http://integration.wikimedia.org/ci/job/Visualeditor-doitall/63/console
[22:37:36] <hashar>	 oh wait
[22:37:37] <hashar>	 no
[22:37:41] <grrrit-wm>	 (03PS2) 10Subramanya Sastry: Added Hardik Juneja to trusted users for check/test pipeline [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/112818 
[22:37:44] <hashar>	 Scenario: Article creation and editing             is fixed
[22:37:47] <hashar>	 thank you very much!!!
[22:38:04] <JeffHall>	 hashar: Great - glad to know that one is working!
[22:38:58] <hashar>	 yeah that is awesome
[22:39:53] <hashar>	 we are progressing
[22:40:27] <grrrit-wm>	 (03CR) 10Hashar: [C: 032] "nice :-]" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/112818 (owner: 10Subramanya Sastry)
[22:40:32] <grrrit-wm>	 (03Merged) 10jenkins-bot: Added Hardik Juneja to trusted users for check/test pipeline [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/112818 (owner: 10Subramanya Sastry)
[22:44:43] <hashar>	 and I am off to bed
[22:44:47] <hashar>	 have sweet dreams folks
[22:44:52] <JeffHall>	 Au revoir!
[22:45:35] <hashar>	 :-]
[22:45:37] <hashar>	 merci!