[06:05:01] (03CR) 10Krinkle: "fixme: The regex is now broken as it has trailing text after the regex that is not preceded by # for comment" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/110661 (owner: 10Brian Wolff) [06:07:26] (03PS1) 10Krinkle: Follows-up 5d5fe1bfd5: Fix invalid regex list item [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/113336 [06:08:06] (03CR) 10Krinkle: [C: 032] Follows-up 5d5fe1bfd5: Fix invalid regex list item [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/113336 (owner: 10Krinkle) [06:08:10] (03Merged) 10jenkins-bot: Follows-up 5d5fe1bfd5: Fix invalid regex list item [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/113336 (owner: 10Krinkle) [06:16:18] (03CR) 10Krinkle: "Fixed in Ie02531143511." [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/110661 (owner: 10Brian Wolff) [10:28:46] hello [10:36:19] hi hashar [10:36:29] stan: see you in 30 minutes? [10:41:43] zeljkof: cool [10:53:22] hi zeljkof :-] [10:53:27] will try to get some jobs triggered [10:53:36] and got to fill mooaaar bugs [10:57:45] (03PS1) 10Zfilipin: Create a Jenkins job to run UniversalLanguageSelector tests in Internet Explorer [selenium] - 10https://gerrit.wikimedia.org/r/113346 [10:59:05] (03PS1) 10Hashar: mathoidsvc-debian-glue [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/113347 [10:59:50] (03CR) 10Hashar: [C: 032] mathoidsvc-debian-glue [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/113347 (owner: 10Hashar) [11:00:06] (03Merged) 10jenkins-bot: mathoidsvc-debian-glue [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/113347 (owner: 10Hashar) [11:01:11] (03PS1) 10Hashar: Trigger mathoidsvc-debian-glue [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/113348 [11:01:23] stan: I will be a minute or two late, sorry [11:01:23] (03CR) 10Hashar: [C: 032] Trigger mathoidsvc-debian-glue [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/113348 (owner: 10Hashar) [11:01:27] (03Merged) 10jenkins-bot: Trigger mathoidsvc-debian-glue [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/113348 (owner: 10Hashar) [11:07:18] zeljkof: no problem, my standup overran also, ready when you are [11:10:32] stan: I am in the hangout, sorry about being late :( [11:10:38] you should get e-mail with the link [11:11:20] Tobi_WMDE: I do not see a hangout link for our meeting today [11:12:18] zeljkof: thx, I added one! [11:12:29] it is at 1, right? [11:12:41] Tobi_WMDE: yes, in 48 minutes :) [11:15:42] :) [11:15:43] zeljkof: hangout not working for me, saying can't join video call [11:15:50] can we do it on irc? [11:15:57] stan: sure [11:16:08] hangout tends to be faster, but irc works [11:16:37] yeah, i can imagine [11:16:52] stan: let me try inviting you from my personal account [11:17:25] also might help in you send invite to my gmail address - stan9v@gmail.com [11:17:48] stan: ok, will try that too [11:18:51] stan: ok, can you join the hangout now? email should be sent from my wikimedia account? [11:20:09] (03CR) 10KartikMistry: [C: 031] "LGTM" [selenium] - 10https://gerrit.wikimedia.org/r/113346 (owner: 10Zfilipin) [11:23:22] stan: https://www.mediawiki.org/wiki/Quality_Assurance/Getting_Started [11:23:34] steps 5 and 6 [11:23:57] stan: https://www.mediawiki.org/wiki/Quality_Assurance/Browser_testing/Setup_instructions [11:24:23] https://github.com/watir/watirbook/tree/master/installation [11:26:15] easy bugs https://bugzilla.wikimedia.org/buglist.cgi?cmdtype=dorem&remaction=run&namedcmd=qa-easy&sharer_id=16205 [11:29:07] zeljkof: "The search named qa-easy has not been made visible to you. " [11:29:41] stan: all qa bugs https://bugzilla.wikimedia.org/buglist.cgi?cmdtype=dorem&list_id=277103&namedcmd=qa&remaction=run&sharer_id=16205 [11:30:11] this one is not easy https://bugzilla.wikimedia.org/show_bug.cgi?id=46890 [11:43:28] gerrit https://bugzilla.wikimedia.org/show_bug.cgi?id=61067 [11:43:39] no, this one https://gerrit.wikimedia.org [11:52:37] zeljkof: will be ~5 mins ate [11:52:38] *late [11:52:57] (03PS2) 10Physikerwelt: Add MediaWiki extension MathSearch [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/112935 [11:55:32] (03CR) 10Hashar: [C: 032] "Will do the Zuul triggers" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/112935 (owner: 10Physikerwelt) [11:55:48] (03Merged) 10jenkins-bot: Add MediaWiki extension MathSearch [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/112935 (owner: 10Physikerwelt) [11:57:04] (03PS1) 10Hashar: Triggers mw/ext/MathSearch [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/113352 [11:57:47] (03CR) 10Hashar: [C: 032] Triggers mw/ext/MathSearch [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/113352 (owner: 10Hashar) [11:57:55] (03Merged) 10jenkins-bot: Triggers mw/ext/MathSearch [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/113352 (owner: 10Hashar) [12:00:02] (03CR) 10Hashar: "should be fine now hopefully test change is https://gerrit.wikimedia.org/r/113353" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/112935 (owner: 10Physikerwelt) [12:00:18] Tobi_WMDE: I am in another meeting, ping me when you are ready [12:00:44] zeljkof: ha, me too.. [12:04:51] (03PS1) 10Zfilipin: WIP Removed configuration of Sauce Labs browsers from the gem [selenium] - 10https://gerrit.wikimedia.org/r/113354 [12:06:29] (03PS2) 10Zfilipin: WIP Removed configuration of Sauce Labs browsers from the gem [selenium] - 10https://gerrit.wikimedia.org/r/113354 [12:08:04] zeljkof: are you ready? [12:08:18] just asking, then I'm leaving this meeting here [12:08:54] Tobi_WMDE: ready [12:09:47] Tobi_WMDE: I am in the hangout [12:51:28] zeljkof: can't hear you anymore [12:51:59] Tobi_WMDE: you dropped of the hangout [14:44:14] (03CR) 10Manybubbles: [C: 032] "Merged the tests to Cirrus repository so we can drop them here." [qa/browsertests] - 10https://gerrit.wikimedia.org/r/113115 (owner: 10Zfilipin) [14:44:23] (03Merged) 10jenkins-bot: Moved tests to CirrusSearch repository [qa/browsertests] - 10https://gerrit.wikimedia.org/r/113115 (owner: 10Zfilipin) [14:51:38] (03PS2) 10Zfilipin: Moved tests from browsertests repository to CirrusSearch repository [selenium] - 10https://gerrit.wikimedia.org/r/113138 [15:22:34] (03PS3) 10Zfilipin: WIP Removed configuration of Sauce Labs browsers from the gem [selenium] - 10https://gerrit.wikimedia.org/r/113354 [15:23:36] (03PS4) 10Zfilipin: WIP Removed configuration of Sauce Labs browsers from the gem [selenium] - 10https://gerrit.wikimedia.org/r/113354 [16:13:11] (03CR) 10Jhall: "Have we abandoned the idea of moving settings for browser version and operating system version to environment variables (as opposed to har" [selenium] - 10https://gerrit.wikimedia.org/r/113346 (owner: 10Zfilipin) [16:50:46] (03PS4) 10Zfilipin: Moved tests to UploadWizard repository [qa/browsertests] - 10https://gerrit.wikimedia.org/r/112894 [16:51:24] (03CR) 10Cmcmahon: [C: 032] Moved tests to UploadWizard repository [qa/browsertests] - 10https://gerrit.wikimedia.org/r/112894 (owner: 10Zfilipin) [16:51:30] (03Merged) 10jenkins-bot: Moved tests to UploadWizard repository [qa/browsertests] - 10https://gerrit.wikimedia.org/r/112894 (owner: 10Zfilipin) [16:56:47] (03PS4) 10Zfilipin: Moved tests from browsertests repository to UploadWizard repository [selenium] - 10https://gerrit.wikimedia.org/r/112899 [16:56:54] (03CR) 10Cmcmahon: [C: 032] Moved tests from browsertests repository to UploadWizard repository [selenium] - 10https://gerrit.wikimedia.org/r/112899 (owner: 10Zfilipin) [16:59:32] (03PS3) 10Zfilipin: Moved tests to WikiLove repository [qa/browsertests] - 10https://gerrit.wikimedia.org/r/113101 [18:53:22] Hi Jeff. [18:55:44] Rochan: Hi Rochan [18:56:39] Did you see my message yesterday in regards to the visualeditor on vagrant? [18:57:21] Rochan: No, you'll have to remind me ;) [18:58:59] Ok ok. So I had visualeditor role enabled. When I went to the Vagrant mediawiki instance at the 127.x.x.x. There's nothing happening when I click on the "edit" button on an article which calls ?veaction=edit. [19:00:18] Then I went into the VisualEditior directory on vagrant, under /lib/ve/ is an empty directory. [19:00:42] On the git repo, /lib/ve is a submodule [19:01:02] Rochan: Yeah, sounds like the submodule did not get deployed for some reason [19:01:12] I believe that would be the missing part. [19:01:45] Rochan: try runing 'git submodule update --init' to download it, and 'git submodule update' to update it after running git pull [19:01:49] The interesting thing is that, I didn't find any .git in any parent directory for the VisualEditor [19:03:23] Rochan: Yeah, that sounds odd if the .git is missing - I'll take a look on my local vagrant setup to see if I have the same issue [19:04:08] Because of that, I rm the VisualEditior dir and cloned it, then ran the submodule commands that you posted above. [19:05:16] Rochan: I do have a .git in /vagrant/mediawiki/extensions/VisualEditor on my vagrant setup, which is a bare-bones deploy, so I'm not sure why the .git was missing with your copy of the same [19:05:19] Now I am at a point where ?veacton=edit would trigger a parsoid call. Unfortunately, I am also getting error when running node api/server.js [19:05:41] Rochan: What errors are you getting from server.js? [19:05:52] Yeah, I might of messed up that step with the VisualEditor dir :( [19:06:26] Here is the stack [19:06:29] node.js:134 [19:06:30] throw e; // process.nextTick error, or 'error' event on first tick [19:06:30] ^ [19:06:31] TypeError: object is not a function [19:06:33] at Object.CALL_NON_FUNCTION (native) [19:06:35] at Cluster.fork (/usr/lib/nodejs/cluster.js:505:3) [19:06:37] at Object. (/home/vagrant/parsoid/js/api/server.js:16:11) [19:06:39] at Module._compile (module.js:411:26) [19:06:41] at Object..js (module.js:417:10) [19:06:43] at Module.load (module.js:343:31) [19:06:45] at Function._load (module.js:302:12) [19:06:47] at Array. (module.js:430:10) [19:06:49] at EventEmitter._tickCallback (node.js:126:26) [19:09:04] Rochan: On your vagrant VM, is parsoid really installed under /home/vagrant? The default location should be /srv/parsoid [19:15:24] I see parsoid under /srv/parsoid [19:16:02] Rochan: If you "ps -ef | grep parsoid", is the running process from /srv/parsoid? [19:16:55] www-data 932 812 0 15:22 ? 00:00:00 /usr/bin/nodejs /srv/parsoid/src/api/server.js [19:16:55] www-data 11150 812 0 17:34 ? 00:00:00 /usr/bin/nodejs /srv/parsoid/src/api/server.js [19:16:56] www-data 12526 812 0 18:02 ? 00:00:00 /usr/bin/nodejs /srv/parsoid/src/api/server.js [19:16:57] www-data 12529 812 0 18:03 ? 00:00:00 /usr/bin/nodejs /srv/parsoid/src/api/server.js [19:16:59] www-data 14116 812 0 18:28 ? 00:00:00 /usr/bin/nodejs /srv/parsoid/src/api/server.js [19:18:11] Rochan: That looks correct - are you able to hit the parsoid landing page with a web browser at http://127.0.0.1:8000 ? [19:19:21] Oh, I am using 8081 right now. [19:21:20] Rochan: Can you successfully get an HTTP 200 from the parsoid landing page at port 8081? [19:24:56] I am sorry, I am not following. What do you mean by the parsoid landing page? [19:26:16] Rochan: Try a curl command like the following - it shoudl return an HTTP 200: curl -I 'http://127.0.0.1:8081' [19:26:58] Rochan: If you've customized parsoid to use port 8081, that URL should load a parsoid welcome page [19:28:46] I am getting a 404. [19:29:20] Rochan: Try it with the default port for parsoid (8000) - does that work? [19:29:34] yeah, 200 [19:30:00] Rochan: OK, that sounds like parsoid is up-and-running at the default port, which is good [19:31:37] Rochan: So just have to figure out why VisualEditor isn't finding it. What does the following command return? [19:31:40] grep '$wgVisualEditorParsoidURL' /vagrant/mediawiki/extensions/VisualEditor/VisualEditor.php [19:36:01] $wgVisualEditorParsoidURL = 'http://localhost:8000'; [19:36:01] // that $wgVisualEditorParsoidURL be pointed to localhost if this setting is enabled. [19:36:47] Rochan: OK, that's all good - VisualEditor is looking for parsoid in the right place [19:37:57] Rochan: Next step would be to try an edit a wiki article using VisualEditor, and if it still doesn't work, enable the browser's JavaScript/error console to see what errors the browser is capturing when it tries to load VisualEditor [19:39:50] This is the pop up that I get when clicking on edit. [19:39:52] Error loading data from server: parsoidserver-http-curl-error: couldn't connect to host. Would you like to retry? [19:41:03] Rochan: Can you paste the full URL from the browser address bar that triggers that error message? [19:42:40] http://127.0.0.1:8081/wiki/Main_Page?veaction=edit [19:46:26] Rochan: Can you past the results of the following command? [19:46:27] grep 'parsoidConfig.setInterwiki' /srv/parsoid/src/api/localsettings.js [19:48:30] parsoidConfig.setInterwiki( 'localhost', 'http://127.0.0.1:8081/w/api.php' ); [19:51:16] Rochan: If you point your browser at http://127.0.0.1:8081/w/api.php, do it successfully load the "MediaWiki API documentation page"? [19:52:01] yes [19:52:48] btw. this is the only ps that's running [19:52:52] vagrant@mediawiki-vagrant:/srv/parsoid/src$ ps -ef | grep parsoid [19:52:53] vagrant 2068 1823 0 19:52 pts/0 00:00:00 grep --color=auto parsoid [19:54:41] Rochan: Ah, OK, so parsoid didn't startup for some reason. You can start it yourself if needed from /srv/parsoid/src using the "node api/server.js &" command [20:21:03] Yeah, getting the error when running server.js [20:21:05] vagrant@mediawiki-vagrant:/srv/parsoid/src$ node api/server.js [20:21:05] /srv/parsoid/src/package.json:2 [20:21:05] "name": "mediawiki-parsoid", [20:21:07] ^ [20:21:09] node.js:134 [20:21:11] throw e; // process.nextTick error, or 'error' event on first tick [20:21:13] ^ [20:21:15] SyntaxError: Unexpected token : [20:21:17] at Module._compile (module.js:406:25) [20:21:19] at Object..js (module.js:417:10) [20:21:21] at Module.load (module.js:343:31) [20:21:23] at Function._load (module.js:302:12) [20:21:25] at require (module.js:355:19) [20:21:28] at Object. (/srv/parsoid/src/api/server.js:50:10) [20:21:29] at Module._compile (module.js:411:26) [20:21:31] at Object..js (module.js:417:10) [20:21:33] at Module.load (module.js:343:31) [20:21:35] at Function._load (module.js:302:12) [20:35:17] Rochan, parsoid layout has been reorganized recently. When did you set up your MediaWiki-vagrant ? [21:01:57] Beginning of this week. [22:13:40] I am just wondering if I am at a point where I should restart from scratch :| [22:48:59] (03PS3) 10Zfilipin: WIP Feature: Cache [qa/browsertests] - 10https://gerrit.wikimedia.org/r/78234 [22:50:46] Ok, good news. Turn out that node version is old. [22:51:20] Upgraded from v.0.4.12 to v0.10.25 [22:52:15] Now server.js runs wtihout problem [22:52:41] Rochan: Great news - glad to hear you got that working! [22:53:32] so now when I run ps -ef | grep parsoid it has the 5 process of server.js [23:08:33] @Jeff, any suggestion on what to do next? [23:08:54] Basically, everything that you posted above works now except the edit part [23:10:48] Rochan: So are you still getting an error message in the browser when you try to edit an article in VisualEditor? [23:11:00] Hey [23:11:01] :) [23:11:40] JeffHall: I wasn't using vagrant before too much, I see that Rochan is accessing MediaWiki at 127.0.0.1:8081 on his local machine [23:12:04] Is there a port forwarding configured in vagrant? If so, is there similar redirect for Parsoid (port 8000)? [23:12:08] Yes, Jeff. [23:14:02] InezK: I haven't tried changing the default Mediawiki port in vagrant as Rochan has, so you might be right, that some port re-directs need to be setup [23:15:29] I think I know what it is [23:15:52] he point to MediaWiki as http://127.0.0.1:8081/w/api.php but should to http://127.0.0.1:8081/api.php [23:19:08] InezK: OK, so Rochan would need to correct that URL in parsoid's localsettings.js config file? [23:24:19] JeffHall: Yeah, it works now. There is different problem, but it is with VisualEditor itself, JS specific, I'm on it [23:26:16] InezK: Great, thanks! [23:26:25] Thank you for helping! [23:30:10] JeffHall: Is it straightforward to use master MediaWiki on the vagrant? [23:31:39] InezK: Yeah, generally quite easy to use, and mediawiki-core is installed by default. You can use the usual git commands to manage the local repo [23:31:49] InezK: I use it all the time for testing! [23:32:39] sweet