[03:23:20] (03PS1) 10Krinkle: jsduck: Set `--processes 0` to avoid ruby parallel from being run [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/114401 [03:24:19] (03CR) 10Krinkle: [C: 032] "Pushed mediawiki-core-jsduck to Jenkins." [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/114401 (owner: 10Krinkle) [03:24:38] (03Merged) 10jenkins-bot: jsduck: Set `--processes 0` to avoid ruby parallel from being run [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/114401 (owner: 10Krinkle) [08:34:41] zeljkof, good morning [08:34:55] spagewmf: morning! [08:35:07] I feel I'm following in your footsteps, http://stackoverflow.com/questions/9006223/watirexceptionmissingwayoffindingobjectexception-invalid-attribute-css [08:35:15] what are you doing up so late? :) [08:35:46] after I scrum master and help with lighting deploys, I put on my QA hat [08:36:24] spagewmf: it happens to me from time to time to google something and find my blog post or a question I have asked or answered at stack overflow :) [08:37:07] I tried to change a text_area PageObject element from class: to css: and got invalid attribute: :css (Watir::Exception::MissingWayOfFindingObjectException) [08:37:54] despite Cheezy docs claiming css works for everything :( [08:37:55] looks like you can use css only with a generic element [08:38:24] zeljkof: but the good news is https://github.com/watir/watir-webdriver/pull/244 , the fix was merged 13 days ago, I wonder when we can start using it [08:39:02] spagewmf: let me check, maybe it was released [08:40:05] no [08:40:14] % bundle list watir-webdriver [08:40:16] /home/spage/.rvm/gems/ruby-2.1.0@Flow/gems/watir-webdriver-0.6.7 [08:40:25] that was merged on feb 6, the latest release is feb 4 [08:40:37] so close :) [08:40:58] but if you leave a comment at that pull request, I am sure they will make the release these days [08:41:02] or ping jarib at #selenium [08:41:06] he should be up now [08:42:18] the fix is later than the latest release https://github.com/watir/watir-webdriver/commits/master [08:42:28] checked git log, just to make sure [08:42:36] ahh, I see https://github.com/watir/watir-webdriver/blob/master/lib/watir-webdriver/version.rb is earlier than that fix [08:42:46] yes [08:43:02] but just ping jarib or leave a comment at the pull request, releasing the gem is easy [08:43:07] if you need that fix [08:43:13] they will probably release [08:48:13] I did. I could switch it to xpath for a few days :-/ [08:50:03] xpath should not be a bad solution [08:50:12] but I prefer css when possible [09:06:00] zeljkof: yes. I didn't realize until tonight that css attribute is pretty close to jQuery selector, I thought the choices for PageObject were class and xpath [09:11:31] there is even something about jquery [09:11:33] let me see [09:13:20] https://plus.google.com/104565969450039850531/posts/A1E1paP4qTK [09:13:48] https://github.com/olore/watir-jquery [09:16:19] morning [09:16:29] Nikerabbit: moog? :) [09:22:04] zeljkof: is that related mooc or mmorpg? [09:22:58] Nikerabbit: I have no idea what those two mean :) [09:23:10] I thought moog was morning in one of the languages you speak [09:24:04] zeljkof: I +2d my own code in order to get results from Sauce Labs for tomorrow. [09:24:42] spagewmf: oh noes :) beware of self-merge [09:24:44] zeljkof: it's possible, but I don't know which one [09:25:17] spagewmf: ping me if you need a review, I have a backlog but if it something urgent I will probably have time to take a look [09:26:00] zeljkof: I added you to one of tonight's self-merges. cmcmahon does a good job of fixing my errors :) [09:26:32] spagewmf: I get a lot of requests for reviews, I tend to take a look when I have the time, but sometimes that means a few days [09:26:33] zeljkof: that jQuery thing is neat. A lot of nodejs webdrivers have Sizzle/jQuery support, e.g. https://github.com/camme/webdriverjs/issues/138 [09:26:40] spagewmf: but if something is urgent, ping me [09:27:17] spagewmf: we could even ask chezzy to add jquery support to page-object :) or make it ourselves [09:28:39] zeljkof: I know the feeling! I have patches to review for my 4th hat of Agora UI (making buttons consistent), but I must sleep [09:28:42] goodnight [09:29:15] spagewmf: good night [09:35:04] zeljkof: I lied about the goodnight. How long should I wait after +2ing a change before scheduling a cloudbees run against beta labs? I know beta labs checks out code "within a few minutes", but I'm not sure about cloudbees. [09:35:42] spagewmf: hashar should know, but I do not see him here [09:36:40] cloudbees gets the code from master branch of the repo (tests) and as soon as labs is updated (where the test site is) you can run the tests [09:38:12] zeljkof: right, the build #253 started and under "Changes" has my two changes. We'll see [09:38:29] spagewmf: good luck :) [09:40:51] spagewmf: so, if you just change the tests, you can run the job at cloudbees as soon as the code is merged into master [09:41:04] right, thanks [09:41:17] because the site itself does not have to be updated [09:55:29] wahoo, chrome passed on beta labs. boo, Firefox failed. The test wait_until 20 seconds to check page.text.include? "1 second ago" or page.text.include? "just now" [09:55:55] ... and the page displayed "3 seconds ago" [09:56:00] :) [10:11:19] Tobi_WMDE: which jenkins is wikidata using these days? http://wikidata-jenkins.wmflabs.org/ci/ or https://wikidata-cloudbees.ci.cloudbees.com/ ? or both? [10:11:54] (03PS1) 10Zfilipin: Fixed links to Jenkins jobs [selenium] - 10https://gerrit.wikimedia.org/r/114446 [10:13:23] (03CR) 10Zfilipin: Fixed links to Jenkins jobs (031 comment) [selenium] - 10https://gerrit.wikimedia.org/r/114446 (owner: 10Zfilipin) [10:13:47] Tobi_WMDE: feel free to answer here :) https://gerrit.wikimedia.org/r/#/c/114446/1/README.md [10:37:26] (03CR) 10Tobias Gritschacher: Fixed links to Jenkins jobs (031 comment) [selenium] - 10https://gerrit.wikimedia.org/r/114446 (owner: 10Zfilipin) [10:58:25] (03CR) 10Zfilipin: Fixed links to Jenkins jobs (031 comment) [selenium] - 10https://gerrit.wikimedia.org/r/114446 (owner: 10Zfilipin) [11:00:25] (03PS2) 10Zfilipin: Fixed links to Jenkins jobs [selenium] - 10https://gerrit.wikimedia.org/r/114446 [11:01:43] (03CR) 10Zfilipin: Fixed links to Jenkins jobs (031 comment) [selenium] - 10https://gerrit.wikimedia.org/r/114446 (owner: 10Zfilipin) [12:29:16] (03PS1) 10Zfilipin: WIP moved BROWSER_TIMEOUT implementation to the gem [selenium] - 10https://gerrit.wikimedia.org/r/114453 [12:45:35] hello [12:58:41] (03CR) 10Hashar: [C: 032] json-lint: fixing whitespaces [integration/jenkins] - 10https://gerrit.wikimedia.org/r/114161 (owner: 10Hashar) [12:58:44] (03Merged) 10jenkins-bot: json-lint: fixing whitespaces [integration/jenkins] - 10https://gerrit.wikimedia.org/r/114161 (owner: 10Hashar) [13:37:26] (03PS3) 10Zfilipin: Fixed links to Jenkins jobs [selenium] - 10https://gerrit.wikimedia.org/r/114446 [13:43:33] (03CR) 10Amire80: [C: 032] Fixed links to Jenkins jobs [selenium] - 10https://gerrit.wikimedia.org/r/114446 (owner: 10Zfilipin) [13:43:35] (03Merged) 10jenkins-bot: Fixed links to Jenkins jobs [selenium] - 10https://gerrit.wikimedia.org/r/114446 (owner: 10Zfilipin) [13:56:46] (03PS1) 10Hashar: Non voting jshint jobs now have a bug report [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/114460 [13:56:51] moaaar bugs https://bugzilla.wikimedia.org/showdependencytree.cgi?id=60619 [13:57:06] (03CR) 10Hashar: [C: 032] Non voting jshint jobs now have a bug report [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/114460 (owner: 10Hashar) [13:57:11] (03Merged) 10jenkins-bot: Non voting jshint jobs now have a bug report [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/114460 (owner: 10Hashar) [14:08:30] (03PS1) 10Hashar: json-lint.php: report json_last_error_msg() on error [integration/jenkins] - 10https://gerrit.wikimedia.org/r/114462 [14:08:41] (03CR) 10Hashar: [C: 032] json-lint.php: report json_last_error_msg() on error [integration/jenkins] - 10https://gerrit.wikimedia.org/r/114462 (owner: 10Hashar) [14:08:44] (03Merged) 10jenkins-bot: json-lint.php: report json_last_error_msg() on error [integration/jenkins] - 10https://gerrit.wikimedia.org/r/114462 (owner: 10Hashar) [14:11:21] (03CR) 10Tobias Gritschacher: [C: 031] WIP moved BROWSER_TIMEOUT implementation to the gem [selenium] - 10https://gerrit.wikimedia.org/r/114453 (owner: 10Zfilipin) [14:36:26] (03PS1) 10Hashar: mwext-ProofreadPage-jslint is now voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/114465 [14:36:42] (03CR) 10Hashar: [C: 032] mwext-ProofreadPage-jslint is now voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/114465 (owner: 10Hashar) [14:36:46] (03Merged) 10jenkins-bot: mwext-ProofreadPage-jslint is now voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/114465 (owner: 10Hashar) [15:10:14] (03PS1) 10Hashar: mwext-CleanChanges-jslint is now voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/114472 [15:10:31] (03CR) 10Hashar: [C: 032] mwext-CleanChanges-jslint is now voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/114472 (owner: 10Hashar) [15:10:36] (03Merged) 10jenkins-bot: mwext-CleanChanges-jslint is now voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/114472 (owner: 10Hashar) [15:28:15] (03PS1) 10Hashar: Jobs for mw/ext/Git2Pages [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/114477 [15:28:30] (03CR) 10Hashar: [C: 032] Jobs for mw/ext/Git2Pages [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/114477 (owner: 10Hashar) [15:28:52] (03Merged) 10jenkins-bot: Jobs for mw/ext/Git2Pages [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/114477 (owner: 10Hashar) [15:30:03] (03PS1) 10Hashar: Triggers for mw/ext/Git2Pages [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/114478 [15:30:40] (03CR) 10Hashar: [C: 032] Triggers for mw/ext/Git2Pages [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/114478 (owner: 10Hashar) [15:30:45] (03Merged) 10jenkins-bot: Triggers for mw/ext/Git2Pages [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/114478 (owner: 10Hashar) [15:41:10] (03PS2) 10Tobias Gritschacher: WIP moved BROWSER_TIMEOUT implementation to the gem [selenium] - 10https://gerrit.wikimedia.org/r/114453 (owner: 10Zfilipin) [15:52:20] (03PS3) 10Tobias Gritschacher: WIP moved BROWSER_TIMEOUT implementation to the gem [selenium] - 10https://gerrit.wikimedia.org/r/114453 (owner: 10Zfilipin) [16:16:03] (03CR) 10Cmcmahon: [C: 032] Moved tests to WikiLove repository [qa/browsertests] - 10https://gerrit.wikimedia.org/r/113101 (owner: 10Zfilipin) [16:46:28] chrismcmahon: Can you +2 this Gerrit change again? It needed a rebase, and I just did that: https://gerrit.wikimedia.org/r/#/c/111890/ [16:46:43] JeffHall: yep, one sec [16:46:55] chrismcmahon: Great, thanks! [19:34:46] (03PS1) 10Mattflaschen: Make jshint voting for WikimediaEvents [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/114519 [20:03:37] (03CR) 10Hashar: [C: 032] Make jshint voting for WikimediaEvents [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/114519 (owner: 10Mattflaschen) [20:03:41] (03Merged) 10jenkins-bot: Make jshint voting for WikimediaEvents [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/114519 (owner: 10Mattflaschen) [20:05:43] (03PS1) 10Hashar: mwext-RSS-jslint has no .js, make it voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/114526 [20:05:55] (03CR) 10Hashar: [C: 032] mwext-RSS-jslint has no .js, make it voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/114526 (owner: 10Hashar) [20:06:21] (03PS2) 10Hashar: mwext-RSS-jslint has no .js, make it voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/114526 [20:06:32] (03CR) 10Hashar: [C: 032] mwext-RSS-jslint has no .js, make it voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/114526 (owner: 10Hashar) [20:06:36] (03Merged) 10jenkins-bot: mwext-RSS-jslint has no .js, make it voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/114526 (owner: 10Hashar) [20:30:52] chrismcmahon, jeffhall: Just checking if you have https://gerrit.wikimedia.org/r/#/c/114398/ in your radar for review. No rush but the sooner we get it in the better, ;-). Thanx ! [20:31:06] thanks aarcos looking now [20:40:34] (03PS1) 10Hashar: analytics-kraken [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/114530 [20:42:15] (03CR) 10Hashar: [C: 032] analytics-kraken [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/114530 (owner: 10Hashar) [20:42:26] (03Merged) 10jenkins-bot: analytics-kraken [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/114530 (owner: 10Hashar) [20:46:24] aarcos: I gave it +2, but I do wonder if it is actually required to do fire_event("onfocus") for the next/previous/exit buttons. Sometimes that points to a cross-browser issue. [20:48:34] chrismcmahon: Kool !, thanx ! I will check that but I think that was the only way to make it work, cheers ! [21:36:02] (03PS1) 10Hashar: analytics-kraken maven job [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/114622 [21:39:34] (03CR) 10Hashar: "Hey Analytics folks. This configuration produce the job http://integration.wikimedia.org/ci/job/analytics-kraken/ which is now triggered " [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/114622 (owner: 10Hashar) [21:45:03] (03PS2) 10Hashar: analytics-kraken maven job [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/114622 [21:46:31] (03CR) 10Hashar: "I have removed the -Dmaven.test.skip=true option and simply invoke:" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/114622 (owner: 10Hashar) [21:52:37] (03CR) 10Hashar: "The tests failures already have a bug apparently https://bugzilla.wikimedia.org/show_bug.cgi?id=54046" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/114622 (owner: 10Hashar) [21:54:21] chrismcmahon: Just verified, no need for fire_event("onfocus"), sent https://gerrit.wikimedia.org/r/#/c/114631/ your way. Thanx for the suggestion ! [21:55:27] aarcos: yeah, Selenium *should* do the onfocus correctly for the test, if that doesn't happen, then something fishy is going on [21:56:38] aarcos: but now there is no need for the convenience methods :-) [21:57:40] chrismcmahon: Good point !, removing that too !, ;-). [22:03:27] (03CR) 10Hashar: "Workaround for https://bugzilla.wikimedia.org/show_bug.cgi?id=60138" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/114401 (owner: 10Krinkle) [22:05:30] chrismcmahon: Fixed, Jenkins is seg-faulting, probably unrelated. [22:08:44] aarcos: thanks! [22:12:23] chrismcmahon: Thank you !, ;-). [22:57:42] (03CR) 10Hashar: [C: 04-2] "I ran the linter on all mediawiki extensions and found some invalid json files (some progress in https://bugzilla.wikimedia.org/show_bug.c" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/113958 (owner: 10Hashar) [23:32:45] (03PS1) 10Krinkle: Create VisualEditor-jsduck job [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/114654 [23:37:31] (03CR) 10Krinkle: [C: 032] "Pushed 'VisualEditor-jsduck' to Jenkins." [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/114654 (owner: 10Krinkle) [23:37:48] (03Merged) 10jenkins-bot: Create VisualEditor-jsduck job [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/114654 (owner: 10Krinkle) [23:39:35] (03PS1) 10Krinkle: mwext-MultimediaViewer-doc-test: Remove redundant 'voting' setting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/114658 [23:40:30] (03PS1) 10Krinkle: Enable VisualEditor-jsduck [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/114659 [23:40:48] morre jsduck! [23:40:55] (03CR) 10Krinkle: [C: 032] mwext-MultimediaViewer-doc-test: Remove redundant 'voting' setting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/114658 (owner: 10Krinkle) [23:40:59] (03Merged) 10jenkins-bot: mwext-MultimediaViewer-doc-test: Remove redundant 'voting' setting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/114658 (owner: 10Krinkle) [23:41:00] hashar: Yay. :-) [23:41:11] (03CR) 10Krinkle: [C: 032] Enable VisualEditor-jsduck [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/114659 (owner: 10Krinkle) [23:41:15] (03Merged) 10jenkins-bot: Enable VisualEditor-jsduck [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/114659 (owner: 10Krinkle) [23:41:30] Krinkle: Were we not doing jsduck build in the npm module? [23:42:04] and I broke the npm jobs a few days ago :-(( ( [23:42:16] forgot to try a change in VE to make sure everything was till working [23:42:24] luckily, Timo showed up and fixed them :] [23:42:26] James_F: No, jsduck is ruby, and not part of grunt build either. [23:42:30] (nodejs/npm went outdate)d [23:43:26] Krinkle: Aaaah. [23:43:36] hashar: Isn't Krinkle wonderful. [23:43:47] he is :] [23:43:52] Also until recently it required special things that were only present in MediaWiki, so we couldn't build docs for oojs-ui or VE standalone [23:43:54] Now we can. [23:43:56] James_F: [23:44:24] oojs-core was special, in that I built that using jsduck 5, which is why we can build that locally, but not in production.. [23:44:48] (github/travis days..) [23:44:48] Krinkle: I think I will add something in Zuul to let us run a job on any repository [23:45:00] something like: project: mediawiki/extensions/* =-> extensions-doc-builder [23:45:09] Krinkle: Aha. [23:45:24] Krinkle: this way we would no more have to care about creating new jenkins jobs and adding triggers [23:45:26] hashar: Hm.. not sure. Don't we already have the mwext jobs templates defaults? [23:46:01] hashar: The one I'm doing at the moment isn't for an extension, besides we only have it for 2 extensions (MMV and VE), and both of them have custom scripts that don't fit the macro, which we're only using in core right now [23:47:02] use case is for extensions, there are hundreds of them, all jobs being a like. Still we have to craft bunch of jobs for them. [23:47:22] we could just have 4 or 5 jobs triggered by any extensions. [23:47:39] which mean any new extension will have jobs triggered automatically :-] [23:48:08] As long as there is a way for indivual projects to have a custom set if needed. [23:48:25] E.g. for modern projects that use npm, they have all tests inside of that using npm-test, not using separate jobs [23:48:59] hashar: I imagine one day we'll expand that to cover non-js projects as well via something like .travis.yaml like you described the other day. [23:49:34] Then we just have 1 job, run it in a vm, and the repository specifies what it should run based on templates. And also runnable locally as much as possible (so not too many, if any, dependnecies on environment) [23:49:54] yup :D [23:50:06] aka well known entry points [23:50:12] I started doing that for some python projects [23:50:24] aka run tox -e py27, tox -e doc, tox -e lint [23:51:17] We can still optimise by having certain packages be preinstalled, and e.g. by having an npmjs.org proxy for caching, but it would still work locally if you want to (just takes a little longer to setup/teardown) [23:52:38] Krinkle: can't you make npm to use a local cache ? [23:52:49] I mean a shared global local cache [23:52:51] It already does that right now [23:52:56] :-] [23:53:00] but once we start doing instance pooling, we'll lose that [23:53:04] and should [23:53:08] ahhh in the user homedir .npm directory [23:53:09] (to avoid polution between jobs) [23:53:12] Yep [23:53:19] Uses HTTP 304 [23:54:20] e.g. a random commit doing $ edit package.json: - npm test: grunt, + npm test: sudo echo "lala" > /home/jenkins/.npm/grunt/bin [23:54:33] (once we open up testing, which we can after we do instance pooling)