[00:19:23] chrismcmahon: hey, the mobile regrssion from this morning, was that caught by auto test or manual? [00:20:46] anyone else know? [00:20:47] :) [00:21:10] I see that the mobile frontend beta labs test is failing but... [00:31:02] greg-g: auto [00:31:27] greg-g: we have some other failures, but we saw this morning failures and were all like wtf happened overnight? [00:31:38] awesome [00:31:42] thanks [00:32:56] greg-g: some detail, we have some tests that go through create-account steps. those tanked because of behavior none of us had ever seen before out of MF [00:35:14] greg-g: the overnight build is my bellwether, but in this case I think Jon Robson caught the problem before me [00:39:01] * greg-g nods [00:45:07] greg-g: s/fast/early/ enough, but yeah [00:45:48] * greg-g nods [00:45:57] grammar and I have a love/hate relationship [00:47:27] anyway, this seems like pretty small potatoes actually. the original idea was kind of unpleasant, as Steven noted. but it's not really his cross to bear or fight to fight [00:49:21] Project UploadWizard-api-commons.wikimedia.beta.wmflabs.org build #160: SUCCESS in 1 min 37 sec: https://wmf.ci.cloudbees.com/job/UploadWizard-api-commons.wikimedia.beta.wmflabs.org/160/ [00:56:05] Project UploadWizard-api-commons.wikimedia.org build #147: SUCCESS in 1 min 24 sec: https://wmf.ci.cloudbees.com/job/UploadWizard-api-commons.wikimedia.org/147/ [00:56:05] l10n-bot: Localisation updates from https://translatewiki.net. [00:58:10] greg-g: btw, this is my first ever wikitech-l flamewar in over two years :-) [00:58:26] :) [01:04:46] greg-g: you need anything else from me today? I am toast, I still have a fever that started Sunday night. [01:04:56] go sleep [01:05:04] * chrismcmahon sleeps [01:05:06] see ya [01:21:24] sleep ? [01:21:31] I am still awake at 2am wtf! [01:21:46] have a good day, heading bed as well *wave* [07:57:18] Project VisualEditor-test2.wikipedia.org-linux-chrome build #354: STILL FAILING in 1 hr 1 min: https://wmf.ci.cloudbees.com/job/VisualEditor-test2.wikipedia.org-linux-chrome/354/ [07:57:18] jforrester: Update VE core submodule to master (beb5e43) [07:57:43] Project browsertests-test2.wikipedia.org-windows-internet_explorer_6 build #678: STILL FAILING in 21 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-windows-internet_explorer_6/678/ [07:57:44] zeljko.filipin: BROWSER_LABEL environment variable is renamed to BROWSER [07:59:12] Project UploadWizard-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_10 build #515: STILL FAILING in 1 min 37 sec: https://wmf.ci.cloudbees.com/job/UploadWizard-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_10/515/ [07:59:12] l10n-bot: Localisation updates from https://translatewiki.net. [08:03:35] Project browsertests-en.wikipedia.beta.wmflabs.org-linux-chrome build #708: STILL FAILING in 5 min 38 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-linux-chrome/708/ [08:03:36] zeljko.filipin: BROWSER_LABEL environment variable is renamed to BROWSER [08:06:45] Yippee, build fixed! [08:06:46] Project WikiLove-en.wikipedia.beta.wmflabs.org-linux-firefox build #33: FIXED in 2 min 57 sec: https://wmf.ci.cloudbees.com/job/WikiLove-en.wikipedia.beta.wmflabs.org-linux-firefox/33/ [08:23:20] Project browsertests-test2.wikipedia.org-windows-internet_explorer_7 build #698: FAILURE in 23 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-windows-internet_explorer_7/698/ [08:23:20] zeljko.filipin: BROWSER_LABEL environment variable is renamed to BROWSER [08:24:06] Project ZeroRatedMobileAccess-en.m.wikipedia.org-linux-phantomjs build #39: SUCCESS in 33 sec: https://wmf.ci.cloudbees.com/job/ZeroRatedMobileAccess-en.m.wikipedia.org-linux-phantomjs/39/ [08:24:07] zfilipin: Cloudbees Jenkins jobs are now created using Jenkins Job Builder [08:29:28] Project browsertests-test2.wikipedia.org-windows-internet_explorer_8 build #784: STILL FAILING in 22 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-windows-internet_explorer_8/784/ [08:29:29] zeljko.filipin: BROWSER_LABEL environment variable is renamed to BROWSER [08:32:32] Yippee, build fixed! [08:32:32] Project Flow-en.wikipedia.beta.wmflabs.org-linux-firefox build #286: FIXED in 8 min 25 sec: https://wmf.ci.cloudbees.com/job/Flow-en.wikipedia.beta.wmflabs.org-linux-firefox/286/ [08:32:33] l10n-bot: Localisation updates from https://translatewiki.net. [08:33:38] Project CirrusSearch-en.wikipedia.beta.wmflabs.org-linux-firefox build #45: SUCCESS in 1 min 6 sec: https://wmf.ci.cloudbees.com/job/CirrusSearch-en.wikipedia.beta.wmflabs.org-linux-firefox/45/ [08:33:38] * chadh: Index pages when they're imported [08:33:39] * neverett: If namespace doesn't have a weight default to .2 [08:33:39] * neverett: Make method signatures match core [08:33:40] * chadh: Minor code style tweak to simplify Result constructor [08:33:40] * chadh: Remove some pointless else statements [08:33:41] * aschulz: Return boolean from delete jobs [08:42:41] Project browsertests-test2.wikipedia.org-linux-chrome build #945: STILL FAILING in 13 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-linux-chrome/945/ [08:42:41] zeljko.filipin: BROWSER_LABEL environment variable is renamed to BROWSER [08:49:36] Project MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox build #395: STILL FAILING in 15 min: https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox/395/ [08:49:36] * jrobson: Hygiene: Updating getLeadSection() in application.js [08:49:37] * jrobson: QA: Fix breaking tests [08:49:37] * jrobson: QA: Rewrite tests for main menu navigation and footer links [08:49:38] * jrobson: Don't load mediawiki.ui.button by default in Minerva [08:53:47] Project Flow-test2.wikipedia.org-windows-internet-explorer-10 build #99: STILL FAILING in 10 min: https://wmf.ci.cloudbees.com/job/Flow-test2.wikipedia.org-windows-internet-explorer-10/99/ [08:53:48] l10n-bot: Localisation updates from https://translatewiki.net. [09:06:00] Project MobileFrontend-test2.m.wikipedia.org-linux-firefox build #302: STILL FAILING in 16 min: https://wmf.ci.cloudbees.com/job/MobileFrontend-test2.m.wikipedia.org-linux-firefox/302/ [09:06:01] * jrobson: Hygiene: Wrap QA arguments in quotes to match other test coding conventions [09:06:01] * jrobson: Hygiene: Consolidate steps for visiting pages [09:06:02] * jrobson: Hygiene: Correct wording of URL check in QA tests [09:06:02] * l10n-bot: Localisation updates from https://translatewiki.net. [09:06:03] * jrobson: Hygiene: Updating getLeadSection() in application.js [09:06:03] * jrobson: QA: Fix breaking tests [09:06:04] * jrobson: QA: Rewrite tests for main menu navigation and footer links [09:06:04] * jrobson: Don't load mediawiki.ui.button by default in Minerva [09:06:55] (03PS1) 10Nemo bis: Typofix [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/117389 [09:07:00] hello zeljkof [09:07:10] hi vikas [09:07:12] I am planning to work on https://bugzilla.wikimedia.org/show_bug.cgi?id=55867 [09:07:34] I checked out parallel_test and it works well in my system [09:07:45] are you on linux? ubuntu? [09:07:51] ubuntu [09:08:26] ok [09:08:35] that is a pretty open ended bug [09:08:55] I am not sure how fixing it would look like :) [09:09:03] we know tests could be run in parallel [09:09:05] ok [09:09:14] but a lot of tests break when running them in parallel [09:09:32] so, it is "just" a matter of fixing the tests :) [09:09:54] in short, probably not a good starting point [09:10:02] but feel free to work on it [09:10:22] it seems interesting :) [09:11:01] go ahead then [09:11:08] ping me if you get stuck [09:11:21] ok thank you [09:11:21] I have a lot of meetings today, but I should be able to answer questions [09:11:31] between meetings [09:11:43] haha thank you :) [09:27:15] Project browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_7 build #514: STILL FAILING in 21 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_7/514/ [09:27:15] zeljko.filipin: BROWSER_LABEL environment variable is renamed to BROWSER [09:31:02] woke up late ... [09:31:14] will be working later on this afternoon [09:50:38] zeljkof: I got it running in my local machine. almost all test passed except 3, reason being Net::ReadTimeout [09:51:07] Project UniversalLanguageSelector-commons.wikimedia.beta.wmflabs.org-linux-firefox build #333: STILL FAILING in 23 min: https://wmf.ci.cloudbees.com/job/UniversalLanguageSelector-commons.wikimedia.beta.wmflabs.org-linux-firefox/333/ [09:51:07] * l10n-bot: Localisation updates from https://translatewiki.net. [09:51:08] * jforrester: Put new compact language links Beta Feature behind a feature flag [09:51:08] * jforrester: Shorter, punchier text copy for the compact language links BetaFeature [09:51:09] * jforrester: Follow-up Ia268c3a49: Actually hide the BF behind a feature flag [09:51:10] vikas: ok [09:51:15] do you know what to do next? [09:51:33] is there anyway I can run it in cloudbees ?? [09:51:50] sure :) [09:52:01] ok, let me see if we have any documentation [09:52:26] but wait [09:52:31] why would you like to run it there? [09:52:42] all I did was add run time dependency to mediwiki_selenium gem [09:53:16] I think it is failing because of bad internet connection I have :P [09:53:31] I see [09:53:48] ok, so you can create a free cloudbees account and run the tests there [09:53:59] or you can run the tests on your local wiki [09:54:08] do you need help with any of those two options? [09:54:35] I think I will run it in my cloudbees account. I remember creating 1 account there. [09:54:45] ok [09:54:50] Will ask you if I am stuck :) [09:54:57] if you need help there, invite my wikimedia e-mail as a user there [09:55:03] so I can help out [09:55:10] ok thank you [09:55:27] meeting starts in 5 minutes, will be unavailable for 60 minutes [09:55:40] ok :) [10:15:40] Project Translate-sandbox.translatewiki.net-linux-firefox build #296: STILL FAILING in 24 min: https://wmf.ci.cloudbees.com/job/Translate-sandbox.translatewiki.net-linux-firefox/296/ [10:15:40] l10n-bot: Localisation updates from https://translatewiki.net. [10:26:42] Project Flow-en.wikipedia.beta.wmflabs.org-windows-internet-explorer-10 build #186: STILL FAILING in 10 min: https://wmf.ci.cloudbees.com/job/Flow-en.wikipedia.beta.wmflabs.org-windows-internet-explorer-10/186/ [10:26:42] l10n-bot: Localisation updates from https://translatewiki.net. [10:26:53] Project VisualEditor-en.wikipedia.beta.wmflabs.org-macos-firefox build #20: STILL FAILING in 1 hr 32 min: https://wmf.ci.cloudbees.com/job/VisualEditor-en.wikipedia.beta.wmflabs.org-macos-firefox/20/ [10:26:53] * esanders: Use en-us spelling 'focused' [10:26:54] * krinklemail: mw.ViewPageTarget: Check elementsThatHadOurAccessKey before accessing [10:26:54] * moriel: Get item data from change event in select widget items [10:26:55] * l10n-bot: Localisation updates from https://translatewiki.net. [10:26:55] * jforrester: Update VE core submodule to master (beb5e43) [10:37:28] Project TwnMainPage-sandbox.translatewiki.net-linux-firefox build #291: SUCCESS in 10 min: https://wmf.ci.cloudbees.com/job/TwnMainPage-sandbox.translatewiki.net-linux-firefox/291/ [10:38:23] ree [10:38:29] coworking at some friend home :-] [10:40:41] Project browsertests-test2.wikipedia.org-linux-firefox build #922: SUCCESS in 13 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-linux-firefox/922/ [10:40:41] zeljko.filipin: BROWSER_LABEL environment variable is renamed to BROWSER [10:45:05] Project UploadWizard-commons.wikimedia.beta.wmflabs.org-linux-firefox build #653: SUCCESS in 4 min 23 sec: https://wmf.ci.cloudbees.com/job/UploadWizard-commons.wikimedia.beta.wmflabs.org-linux-firefox/653/ [10:45:05] l10n-bot: Localisation updates from https://translatewiki.net. [10:46:16] Project CirrusSearch-test2.wikipedia.org-linux-firefox build #43: SUCCESS in 1 min 11 sec: https://wmf.ci.cloudbees.com/job/CirrusSearch-test2.wikipedia.org-linux-firefox/43/ [10:46:17] * chadh: Index pages when they're imported [10:46:17] * neverett: If namespace doesn't have a weight default to .2 [10:46:18] * neverett: Make method signatures match core [10:46:18] * chadh: Minor code style tweak to simplify Result constructor [10:46:19] * chadh: Remove some pointless else statements [10:46:19] * aschulz: Return boolean from delete jobs [10:47:35] Project MobileFrontend-en.m.wikipedia.org-linux-firefox build #343: STILL FAILING in 10 min: https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.org-linux-firefox/343/ [10:47:35] * jrobson: Hygiene: Wrap QA arguments in quotes to match other test coding conventions [10:47:35] * jrobson: Hygiene: Consolidate steps for visiting pages [10:47:36] * jrobson: Hygiene: Correct wording of URL check in QA tests [10:47:36] * l10n-bot: Localisation updates from https://translatewiki.net. [10:47:37] * jrobson: Hygiene: Updating getLeadSection() in application.js [10:47:37] * jrobson: QA: Fix breaking tests [10:47:38] * jrobson: QA: Rewrite tests for main menu navigation and footer links [10:47:38] * jrobson: Don't load mediawiki.ui.button by default in Minerva [11:00:24] (03PS2) 10Hashar: Enable JIT for unit tests in HHVM [integration/jenkins] - 10https://gerrit.wikimedia.org/r/117226 (owner: 10EBernhardson) [11:04:44] Yippee, build fixed! [11:04:44] Project browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_10 build #516: FIXED in 18 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_10/516/ [11:04:45] zeljko.filipin: BROWSER_LABEL environment variable is renamed to BROWSER [11:06:35] Project browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_8 build #582: STILL FAILING in 18 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_8/582/ [11:06:35] zeljko.filipin: BROWSER_LABEL environment variable is renamed to BROWSER [11:22:59] Project ContentTranslation-language-stage.wmflabs.org-linux-firefox build #1: FAILURE in 6 min 39 sec: https://wmf.ci.cloudbees.com/job/ContentTranslation-language-stage.wmflabs.org-linux-firefox/1/ [11:25:41] Project ContentTranslation-language-stage.wmflabs.org-linux-firefox build #2: STILL FAILING in 2 min 26 sec: https://wmf.ci.cloudbees.com/job/ContentTranslation-language-stage.wmflabs.org-linux-firefox/2/ [11:25:42] zeljko.filipin: Updated to the latest version of mediawiki_selenium Ruby gem. [11:28:20] (03CR) 10Hashar: [C: 032] "Lets try! :-]" [integration/jenkins] - 10https://gerrit.wikimedia.org/r/117226 (owner: 10EBernhardson) [11:28:23] (03Merged) 10jenkins-bot: Enable JIT for unit tests in HHVM [integration/jenkins] - 10https://gerrit.wikimedia.org/r/117226 (owner: 10EBernhardson) [11:28:45] (03CR) 10Hashar: "Note that change made to integration/jenkins.git repository can be deployed by anyone from tin /srv/deployment/integration/slave-scripts" [integration/jenkins] - 10https://gerrit.wikimedia.org/r/117226 (owner: 10EBernhardson) [11:33:57] zeljkof: you free now ? [11:34:12] sorry, still in a meeting with kart_ [11:34:20] ah never mind :) [11:42:55] Project ContentTranslation-language-stage.wmflabs.org-linux-firefox build #3: STILL FAILING in 3 min 44 sec: https://wmf.ci.cloudbees.com/job/ContentTranslation-language-stage.wmflabs.org-linux-firefox/3/ [11:42:56] zeljko.filipin: Fixed logging in for Selenium tests [11:44:05] (03PS1) 10Hashar: HHVM opcache in workspace [integration/jenkins] - 10https://gerrit.wikimedia.org/r/117405 [11:44:32] (03CR) 10Hashar: [C: 032] HHVM opcache in workspace [integration/jenkins] - 10https://gerrit.wikimedia.org/r/117405 (owner: 10Hashar) [11:44:35] (03Merged) 10jenkins-bot: HHVM opcache in workspace [integration/jenkins] - 10https://gerrit.wikimedia.org/r/117405 (owner: 10Hashar) [11:45:21] (03CR) 10Hashar: "A nice side effect is that the tests are passing, more precisely they no more segfault." [integration/jenkins] - 10https://gerrit.wikimedia.org/r/117226 (owner: 10EBernhardson) [11:45:43] vikas: I am free now [11:47:11] Thank you, zeljkof! [11:47:56] vikas: ooops, got disconnected [11:47:59] anyway, I am back [11:55:00] (03CR) 10Hashar: [C: 032] "Thanks!" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/117389 (owner: 10Nemo bis) [11:55:06] (03Merged) 10jenkins-bot: Typofix [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/117389 (owner: 10Nemo bis) [11:56:14] off for lunch [11:58:20] zeljkof: oops sorry I did not see it [12:01:33] zeljkof: I found this https://bugzilla.wikimedia.org/show_bug.cgi?id=48216 [12:01:36] 3rd link is not working [12:03:13] vikas: I have updated the buhg [12:03:15] bug [12:04:39] thank you [12:49:07] Project UploadWizard-api-commons.wikimedia.beta.wmflabs.org build #161: SUCCESS in 1 min 29 sec: https://wmf.ci.cloudbees.com/job/UploadWizard-api-commons.wikimedia.beta.wmflabs.org/161/ [12:55:54] Project UploadWizard-api-commons.wikimedia.org build #148: SUCCESS in 1 min 19 sec: https://wmf.ci.cloudbees.com/job/UploadWizard-api-commons.wikimedia.org/148/ [12:57:35] Muz, if you hare here, I am in the hangout [13:43:03] zeljkof: that link [3] redirects me here => https://saucelabs.com/docs/onboarding [13:43:14] vikas: sorry, in a meeting [13:43:22] ah sorry [14:28:17] manybubbles: I might be late a few minutes [14:28:23] sure! [14:29:20] reeeeee [14:52:51] hi zeljkof, I have something for us to think about today. something we've done has stopped all the MobileFrontend tests from running at all. no test ever opened a URL in the overnight run. https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox/ [14:54:03] zeljkof: late yesterday I saw a problem where all of the tests would type username correctly but for some reason did not have the value for password although sendkeys had an argument and sent it to the password field, it was not a valid value [14:55:57] chrismcmahon: in a meeting with manybubbles [14:56:06] if you need him I can drop [14:56:08] but I think I have fixed that problem, see bugzilla bug [14:56:21] oh yeah? thanks, looking [14:56:31] say hi to Nik for me :-) [15:03:17] thanks zeljkof I merged, will check it out [15:10:07] Project ContentTranslation-language-stage.wmflabs.org-linux-firefox build #4: STILL FAILING in 8 min 14 sec: https://wmf.ci.cloudbees.com/job/ContentTranslation-language-stage.wmflabs.org-linux-firefox/4/ [15:22:22] Project MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox build #396: STILL FAILING in 16 min: https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox/396/ [15:22:22] * zeljko.filipin: QA: Fixed Selenium tests that fail during login at Cloudbees [15:22:23] * amir.aharoni: Simplify a message [15:48:29] zeljkof: still have some sort of conflict in the mobile repo [15:48:43] chrismcmahon: what is the commit url? [15:49:33] zeljkof: I don't know. I merged your login fix which was fine and re-ran the suite. almost every test fails to get an initial URL, presents just a blank browser [15:50:11] ok, will take a look [15:50:17] zeljkof: at a guess, it's a conflict in env.rb [15:50:46] I will be 5-10 minutes late for our meeting, ok? [15:50:52] chrismcmahon: ^ [15:50:57] zeljkof: sure, np [15:51:29] chrismcmahon: thanks [15:51:54] de nada :-) (you know some Spanish, yes?) [15:52:18] chrismcmahon: I have spent a couple of months in Mexico, but it did not help :) [15:52:40] chrismcmahon: but google translate helps [15:52:52] "de nada" means like "no problem", literally "it's nothing" [15:54:33] hashar are you around? I'd like to make the beta fatals monitor a little nicer, and see if you think this is OK: https://gerrit.wikimedia.org/r/#/c/116146/ [16:00:23] chrismcmahon: helllo [16:00:53] chrismcmahon: my ruby is rather limited :/ [16:01:33] hashar: the change is more about file i/o and regular expressions [16:04:09] hashar: if you look at the diff view, this is going to create regular expression to grab the extension name; open the fatals file; read each line in the fatals file and if it gets an extension match, put that in an array; reduce the array to unique elements; dump the contents of the uniq'd array to string to include in the email message. [16:04:51] hashar: if you look at the diff view, this is going to create regular expression to grab the extension name; open the fatals file; read each line in the fatals file and if it gets an extension match, put that in an array; reduce the array to unique elements; dump the contents of the uniq'd array to string to include in the email message. [16:04:52] chrismcmahon: might get zeljkof to look at it maybe ? [16:05:51] hashar: I did :-). we discussed it yesterday. The reason I'd like you to look is a) is the user that runs that script allowed to open the fatals file in read-only mode? [16:06:28] hashar: where is the actual config for the wikimedia jenkins kept? i.e. the master config I guess, is it in a repo? puppet? hidden somewhere else? [16:15:38] chrismcmahon: the fatal log should be world readable. Let me check. [16:17:28] yeah that works [16:19:01] chrismcmahon: +1ed Gotta ask ops to merge the patch though :] [16:19:23] chrismcmahon: then puppet will eventually apply it on deployment-bastion.pmtpa.wmflabs [16:19:43] addshore: the config is only on the server :] [16:19:47] thanks hashar [16:19:55] hashar: I see :P [16:19:58] addshore: I wish we could handle Jenkins conf via puppet. It might be possible. [16:20:03] thats explains why I couldnt find it anywhere :P [16:20:13] addshore: indeed :] What were you looking for? [16:20:38] well just that! :P Im migrating our jenkins instance over to eqiad and am perfecting the puppet while Im at it [16:26:35] or I wonder if we should just do what you do ;p [16:26:56] hashar: so what would you do if all of your jenkins machines died? ;p [16:29:28] hashar: I upgraded Elasticsearch on the integration machine this morning [16:29:45] I figure it was a good idea since we did production last night [16:29:51] manybubbles: probably :-] [16:30:21] manybubbles: though the error leverage is most probably in the upgrade process itself when having a lot of data / servers et [16:30:32] manybubbles: good luck on the friday deploy! [16:30:50] addshore: if the master server dies I guess we are in some trouble :-D [16:31:58] addshore: nothing to worry that much. Would have to figure out all the plugins that need to be added, tweak a few settings, re add the Jenkins slaves [16:32:13] addshore: and of course we would lost all the build history. But that does not prevent me from sleeping. [16:32:43] friday? it wasn't friday for me:) [16:33:25] zeljkof: free ? [16:33:40] vikas: sorry, in a meeting with chrismcmahon [16:33:45] ok :) [16:42:59] chrismcmahon: mutante merged in the change :-] [16:43:12] awesome, thanks hashar [16:57:32] chrismcmahon: did you get the invite to the hangout? [17:40:56] Yippee, build fixed! [17:40:56] Project ContentTranslation-language-stage.wmflabs.org-linux-firefox build #5: FIXED in 7 min 39 sec: https://wmf.ci.cloudbees.com/job/ContentTranslation-language-stage.wmflabs.org-linux-firefox/5/ [17:49:53] Project MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox build #397: STILL FAILING in 25 min: https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox/397/ [17:49:53] zeljko.filipin: QA: Fixed Selenium tests that fail at Cloudbees [17:52:22] zeljkof: check out the MF test results: https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox/397/testReport/ [17:52:39] still getting some no-url results, and couple of the Sauce links are 404 [18:15:37] chrismcmahon: I pontificated again, you're corrections/additions welcome on wikitech-l ;) [18:16:22] greg-g: I thought it was accurate [18:16:46] sweet. [18:17:37] greg-g: the one thing I'd like to see someone bring up but I'm not brave enough: wtf are people doing messing with account creation workflow? that is like central to ALL THE THINGS [18:17:49] yeah..... [18:17:52] about that... [18:17:53] :) [18:19:05] greg-g: so we up-case the first character in a username. did you also know that we replace underscores with spaces, and for all I know a ton of other manipulations to usernames submitted by web? [18:19:17] and always have [18:19:29] yeah, that second one surprised me [18:20:15] there was a thread on design-l about it last week or so [18:20:49] greg-g: I know for a fact that ULS had an unpleasant bug once where it would treat what the user typed as the *wrong* string if it did not match the db username, even if it were an underscore or a lower-case first character or watever. [18:21:05] oh man [18:21:32] so, "what they typed when the registered" != "what's in the database" so "what they typed to login" failed.... wow [18:21:41] so for example, if I had known about that patch I would have -1'd it over and over, called in Mobile, called in Language, nipped that in the bud [18:21:47] yeah [18:21:55] let's be mean to our users [18:21:58] heh [18:23:08] well, it was just not a well-considered "enhancement". account creation is the center of the universe, Mobile depends on it, GettingStarted depends on it, CentralAuth depends on it, stats depends on it. messing with it in any way is fraught with risk. [18:24:06] Project MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox build #398: STILL FAILING in 27 min: https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox/398/ [18:24:07] and deserves more review than just Steven and Jared on design-l [18:24:27] +1000 [18:26:03] Project Translate-meta.wikimedia.org-linux-firefox build #195: SUCCESS in 1 min 40 sec: https://wmf.ci.cloudbees.com/job/Translate-meta.wikimedia.org-linux-firefox/195/ [18:26:37] greg-g: anyhoo, bottom line is that we should honor whatever the user types and make sure it works without any opaque "due to techical issues we're messing with you" messages popping up. [18:27:34] totally [18:28:39] Project UniversalLanguageSelector-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_10 build #46: STILL FAILING in 25 min: https://wmf.ci.cloudbees.com/job/UniversalLanguageSelector-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_10/46/ [18:28:39] niharikakohli29: Enable compact links feature when ULS position is "personal" [18:45:14] Project browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_9 build #611: STILL FAILING in 19 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_9/611/ [18:47:01] Project browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_6 build #456: STILL FAILING in 18 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_6/456/ [19:04:27] Project browsertests-test2.wikipedia.org-windows-internet_explorer_10 build #504: SUCCESS in 18 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-windows-internet_explorer_10/504/ [20:10:05] Project VisualEditor-test2.wikipedia.org-linux-firefox build #382: STILL FAILING in 1 hr 22 min: https://wmf.ci.cloudbees.com/job/VisualEditor-test2.wikipedia.org-linux-firefox/382/ [20:17:00] Project VisualEditor-en.wikipedia.beta.wmflabs.org-windows_xp-chrome build #20: STILL FAILING in 1 hr 12 min: https://wmf.ci.cloudbees.com/job/VisualEditor-en.wikipedia.beta.wmflabs.org-windows_xp-chrome/20/ [20:18:20] Project Flow-test2.wikipedia.org-linux-firefox build #162: STILL FAILING in 8 min 0 sec: https://wmf.ci.cloudbees.com/job/Flow-test2.wikipedia.org-linux-firefox/162/ [20:18:20] ebernhardson: Move Collection classes into collection namespace [20:18:46] (03PS2) 10Krinkle: Enable mediawiki-core-npm (runs jshint+jscs), disable mediawiki-core-jslint [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/116136 [20:18:52] (03PS5) 10Krinkle: Various clean up and refactor to make mediawiki-core-npm faster [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/116125 [20:21:03] Project Flow-en.wikipedia.beta.wmflabs.org-linux-chrome build #288: STILL FAILING in 4 min 2 sec: https://wmf.ci.cloudbees.com/job/Flow-en.wikipedia.beta.wmflabs.org-linux-chrome/288/ [20:21:03] ebernhardson: Move Collection classes into collection namespace [20:23:20] Project UploadWizard-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_9 build #628: SUCCESS in 4 min 48 sec: https://wmf.ci.cloudbees.com/job/UploadWizard-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_9/628/ [20:24:54] Project UniversalLanguageSelector-sandbox.translatewiki.net-linux-firefox build #275: SUCCESS in 1 min 33 sec: https://wmf.ci.cloudbees.com/job/UniversalLanguageSelector-sandbox.translatewiki.net-linux-firefox/275/ [20:24:54] niharikakohli29: Enable compact links feature when ULS position is "personal" [20:39:25] Project browsertests-en.wikipedia.beta.wmflabs.org-linux-firefox build #689: SUCCESS in 14 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-linux-firefox/689/ [20:43:30] Project browsertests-test2.wikipedia.org-windows-internet_explorer_9 build #819: STILL FAILING in 22 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-windows-internet_explorer_9/819/ [20:45:15] Project UploadWizard-commons.wikimedia.beta.wmflabs.org-linux-chrome build #695: STILL FAILING in 1 min 31 sec: https://wmf.ci.cloudbees.com/job/UploadWizard-commons.wikimedia.beta.wmflabs.org-linux-chrome/695/ [20:46:27] Project Flow-test2.wikipedia.org-linux-chrome build #160: STILL FAILING in 7 min 1 sec: https://wmf.ci.cloudbees.com/job/Flow-test2.wikipedia.org-linux-chrome/160/ [20:46:27] ebernhardson: Move Collection classes into collection namespace [21:09:31] Project MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome build #308: STILL FAILING in 22 min: https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/308/ [21:09:31] * zeljko.filipin: QA: Fixed Selenium tests that fail during login at Cloudbees [21:09:32] * amir.aharoni: Simplify a message [21:09:32] * zeljko.filipin: QA: Fixed Selenium tests that fail at Cloudbees [21:09:33] * jrobson: QA: Assure login step visits the Main Page [21:09:34] * kaldari: Making 'Contents' in TOC localizable in mobile [21:21:15] (03PS1) 10Hashar: Dependencies for Flow [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/117474 [22:01:38] chrismcmahon: I'm trying to get my head around how the VE tests work so I can fix a failing one, but I'm a little lost. Are you around for me to ask some (probably stupid) questions? [22:02:06] James_F: conveniently, I am about one or two steps away from turning the VE build green on beta [22:02:19] chrismcmahon: Ha! In that case I might hold off. [22:03:00] James_F: yeah, I've been making small fixes here and there, the Headings test was one, and I noticed there was only one test failing just now, I am shoring that one up as we speak [22:03:07] chrismcmahon: (The "Transclusion" feature needs re-working to add the new simple mode in front of the existing complex one, and the position or label of some of the buttons used may have changed.) [22:03:20] Brilliant. [22:03:42] James_F: exactly, I have the first 3 Transclusions scenarios passing, just tackling the fourth and last right now [22:03:48] Brill! [22:06:27] chrismcmahon: Though at some point I'd really like to learn how I can help fix these issues myself (ideally, in the same commit). [22:06:48] James_F: you're on [22:07:01] chrismcmahon: Excellent. [22:07:17] Project VisualEditor-en.wikipedia.beta.wmflabs.org-linux-firefox build #373: STILL FAILING in 1 hr 21 min: https://wmf.ci.cloudbees.com/job/VisualEditor-en.wikipedia.beta.wmflabs.org-linux-firefox/373/ [22:07:36] James_F: there is a lot of messy stuff in here, I'll put you on the review list when I commit this patch [22:09:30] (03CR) 10Hashar: [C: 032] Dependencies for Flow [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/117474 (owner: 10Hashar) [22:09:51] (03Merged) 10jenkins-bot: Dependencies for Flow [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/117474 (owner: 10Hashar) [22:14:27] chrismcmahon: Thanks. [22:19:32] (03PS1) 10Krinkle: Allow qunit jobs to run concurrent [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/117603 [22:19:35] (03PS1) 10Krinkle: Explicitly set concurrency to false for doxygen-publish [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/117604 [22:39:30] Project VisualEditor-en.wikipedia.beta.wmflabs.org-windows_xp-firefox build #20: STILL FAILING in 1 hr 29 min: https://wmf.ci.cloudbees.com/job/VisualEditor-en.wikipedia.beta.wmflabs.org-windows_xp-firefox/20/ [22:39:57] James_F: it's not the most elegant test in the world, but it's green: https://gerrit.wikimedia.org/r/#/c/117611 I'll be re-working some of these in the future for sure. [22:40:49] Project MultimediaViewer-en.wikipedia.beta.wmflabs.org-linux-firefox build #93: STILL FAILING in 1 min 18 sec: https://wmf.ci.cloudbees.com/job/MultimediaViewer-en.wikipedia.beta.wmflabs.org-linux-firefox/93/ [22:40:49] l10n-bot: Localisation updates from https://translatewiki.net. [22:56:21] Project VisualEditor-en.wikipedia.beta.wmflabs.org-linux-chrome build #360: STILL FAILING in 15 min: https://wmf.ci.cloudbees.com/job/VisualEditor-en.wikipedia.beta.wmflabs.org-linux-chrome/360/ [22:56:21] * jrobson: Re-enable VisualEditor's toolbar icons on mobile. [22:56:22] * l10n-bot: Localisation updates from https://translatewiki.net. [22:56:22] * l10n-bot: Localisation updates from https://translatewiki.net. [23:00:16] Project ContentTranslation-language-stage.wmflabs.org-linux-firefox build #6: SUCCESS in 3 min 42 sec: https://wmf.ci.cloudbees.com/job/ContentTranslation-language-stage.wmflabs.org-linux-firefox/6/ [23:00:17] l10n-bot: Localisation updates from https://translatewiki.net. [23:08:03] Project VisualEditor-test2.wikipedia.org-linux-chrome build #355: STILL FAILING in 1 hr 0 min: https://wmf.ci.cloudbees.com/job/VisualEditor-test2.wikipedia.org-linux-chrome/355/ [23:08:04] * jrobson: Re-enable VisualEditor's toolbar icons on mobile. [23:08:04] * l10n-bot: Localisation updates from https://translatewiki.net. [23:13:39] Yippee, build fixed! [23:13:39] Project UploadWizard-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_10 build #516: FIXED in 5 min 21 sec: https://wmf.ci.cloudbees.com/job/UploadWizard-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_10/516/ [23:13:40] l10n-bot: Localisation updates from https://translatewiki.net. [23:20:10] Project browsertests-en.wikipedia.beta.wmflabs.org-linux-chrome build #709: STILL FAILING in 6 min 31 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-linux-chrome/709/ [23:22:55] Project browsertests-test2.wikipedia.org-windows-internet_explorer_6 build #679: STILL FAILING in 22 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-windows-internet_explorer_6/679/ [23:26:17] Project WikiLove-en.wikipedia.beta.wmflabs.org-linux-firefox build #34: SUCCESS in 3 min 9 sec: https://wmf.ci.cloudbees.com/job/WikiLove-en.wikipedia.beta.wmflabs.org-linux-firefox/34/ [23:26:18] l10n-bot: Localisation updates from https://translatewiki.net. [23:37:13] (03CR) 10Krinkle: [C: 032] "Pushed 'mediawiki-core-qunit', 'mwext-TemplateData-qunit', 'mwext-VisualEditor-qunit', 'mwext-Wikibase-qunit', 'mwext-MobileFrontend-qunit" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/117603 (owner: 10Krinkle) [23:37:32] (03Merged) 10jenkins-bot: Allow qunit jobs to run concurrent [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/117603 (owner: 10Krinkle) [23:45:06] Project browsertests-test2.wikipedia.org-windows-internet_explorer_7 build #699: STILL FAILING in 24 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-windows-internet_explorer_7/699/ [23:45:46] Project ZeroRatedMobileAccess-en.m.wikipedia.org-linux-phantomjs build #40: FAILURE in 25 sec: https://wmf.ci.cloudbees.com/job/ZeroRatedMobileAccess-en.m.wikipedia.org-linux-phantomjs/40/ [23:45:47] * l10n-bot: Localisation updates from https://translatewiki.net. [23:45:47] * abaso: Instruct JavaScript modules in MobileFrontend to not show images. [23:45:53] (03CR) 10Krinkle: [C: 032] "Pushed 'mediawiki-core-doxygen-publish' (no difference, false is the default)" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/117604 (owner: 10Krinkle) [23:46:12] (03Merged) 10jenkins-bot: Explicitly set concurrency to false for doxygen-publish [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/117604 (owner: 10Krinkle) [23:50:32] Project browsertests-test2.wikipedia.org-windows-internet_explorer_8 build #785: STILL FAILING in 24 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-windows-internet_explorer_8/785/ [23:55:12] Project Flow-en.wikipedia.beta.wmflabs.org-linux-firefox build #287: SUCCESS in 9 min 25 sec: https://wmf.ci.cloudbees.com/job/Flow-en.wikipedia.beta.wmflabs.org-linux-firefox/287/ [23:55:12] * ebernhardson: Remove unnecessary branching in validation [23:55:13] * ebernhardson: Move Collection classes into collection namespace [23:55:13] * l10n-bot: Localisation updates from https://translatewiki.net. [23:55:14] * bsitu: No need to load workflow in formatters [23:55:14] * bsitu: wfProfileIn/Out -> ProfileSection [23:56:35] Project CirrusSearch-en.wikipedia.beta.wmflabs.org-linux-firefox build #46: SUCCESS in 1 min 22 sec: https://wmf.ci.cloudbees.com/job/CirrusSearch-en.wikipedia.beta.wmflabs.org-linux-firefox/46/ [23:56:35] * neverett: Drop 0.90 compatibility [23:56:36] * neverett: Handle old todo, Title objects have long since been removed [23:56:36] * neverett: Remove references to SearchUpdate class, we don't use that [23:56:37] * neverett: Hacky python script to reply production logs [23:56:37] * chadh: Bump CirrusSearch to 0.2 [23:56:38] * chadh: Use language fallbacks where they're available [23:56:38] * l10n-bot: Localisation updates from https://translatewiki.net.