[00:12:33] Project VisualEditor-en.wikipedia.beta.wmflabs.org-linux-chrome build #368: STILL FAILING in 1 hr 11 min: https://wmf.ci.cloudbees.com/job/VisualEditor-en.wikipedia.beta.wmflabs.org-linux-chrome/368/ [00:12:33] * jforrester: [Browser tests] Updates to transclusion tests should turn build green [00:12:34] * jforrester: Enable VisualEditor by default in NS_USER as well as $wgContentNamespaces [00:12:34] * l10n-bot: Localisation updates from https://translatewiki.net. [00:12:35] * krenair: Fix fatal when user switches from VE to the old editor and makes a null edit [00:12:35] * jforrester: [Browser tests] Remove dumb stuff from steps. [00:12:36] * roan.kattouw: Deal with images whose size is smalled than default [00:12:36] * roan.kattouw: Rename 'wasve' parameter to 'veswitched' [00:12:37] * krinklemail: mw.ViewPageTarget: Tag our state changes and reject foreign states [00:12:37] * krinklemail: mw.Target: Add class "mw-ve-editNotice" to edit notices [00:12:38] * roan.kattouw: ve.ui.MWPopupTool: Simplify code complexity [00:15:18] Project WikiLove-en.wikipedia.beta.wmflabs.org-linux-firefox build #44: SUCCESS in 2 min 41 sec: https://wmf.ci.cloudbees.com/job/WikiLove-en.wikipedia.beta.wmflabs.org-linux-firefox/44/ [00:20:20] Project browsertests-test2.wikipedia.org-windows-internet_explorer_7 build #709: STILL FAILING in 40 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-windows-internet_explorer_7/709/ [00:20:21] zeljko.filipin: Moved "I am at a random page" step to the mediawiki_selenium Ruby gem [00:20:49] Project ZeroRatedMobileAccess-en.m.wikipedia.org-linux-phantomjs build #50: STILL FAILING in 25 sec: https://wmf.ci.cloudbees.com/job/ZeroRatedMobileAccess-en.m.wikipedia.org-linux-phantomjs/50/ [00:20:50] * yurik: Add support for https partners [00:20:50] * abaso: Update cookie flags to reflect what we really want. [00:29:15] Project Flow-en.wikipedia.beta.wmflabs.org-linux-firefox build #298: FAILURE in 8 min 21 sec: https://wmf.ci.cloudbees.com/job/Flow-en.wikipedia.beta.wmflabs.org-linux-firefox/298/ [00:49:11] Yippee, build fixed! [00:49:11] Project browsertests-test2.wikipedia.org-linux-chrome build #956: FIXED in 19 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-linux-chrome/956/ [00:49:12] zeljko.filipin: Moved "I am at a random page" step to the mediawiki_selenium Ruby gem [00:50:37] Project CirrusSearch-en.wikipedia.beta.wmflabs.org-linux-firefox build #56: SUCCESS in 1 min 26 sec: https://wmf.ci.cloudbees.com/job/CirrusSearch-en.wikipedia.beta.wmflabs.org-linux-firefox/56/ [00:56:15] Yippee, build fixed! [00:56:16] Project browsertests-test2.wikipedia.org-windows-internet_explorer_8 build #795: FIXED in 40 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-windows-internet_explorer_8/795/ [00:56:16] zeljko.filipin: Moved "I am at a random page" step to the mediawiki_selenium Ruby gem [01:06:39] (03PS1) 10Chad: Clean up HHVM build [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/118418 [01:07:35] (03CR) 10Chad: [C: 032] "Already tested & live." [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/118418 (owner: 10Chad) [01:07:52] (03Merged) 10jenkins-bot: Clean up HHVM build [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/118418 (owner: 10Chad) [01:19:55] (03CR) 10Krinkle: "ping" [integration/jenkins] - 10https://gerrit.wikimedia.org/r/90428 (owner: 10Hashar) [01:23:23] Project MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox build #413: FAILURE in 32 min: https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox/413/ [01:23:23] * jrobson: Add password reset link from desktop on mobile [01:23:24] * jrobson: Hygiene: Make language browser tests more generic [01:28:25] Project MobileFrontend-test2.m.wikipedia.org-linux-firefox build #313: STILL FAILING in 32 min: https://wmf.ci.cloudbees.com/job/MobileFrontend-test2.m.wikipedia.org-linux-firefox/313/ [01:28:25] * jrobson: Add password reset link from desktop on mobile [01:28:26] * jrobson: Hygiene: Make language browser tests more generic [02:46:55] Project VisualEditor-en.wikipedia.beta.wmflabs.org-linux-firefox build #387: STILL FAILING in 1 hr 18 min: https://wmf.ci.cloudbees.com/job/VisualEditor-en.wikipedia.beta.wmflabs.org-linux-firefox/387/ [02:46:56] * jgonera: Add createSurface() to Target [02:46:56] * jforrester: Enable VisualEditor by default in NS_USER as well as $wgContentNamespaces [02:46:57] * krenair: Fix fatal when user switches from VE to the old editor and makes a null edit [02:46:57] * roan.kattouw: Deal with images whose size is smalled than default [02:46:58] * roan.kattouw: Rename 'wasve' parameter to 'veswitched' [02:46:58] * roan.kattouw: Fix JS error trying to access this.saveDialog from switch to source mode code path [02:46:59] * krinklemail: mw.ViewPageTarget: Tag our state changes and reject foreign states [02:46:59] * trevorparscal: Keep label and disabled state of transclusion dialog apply button in sync [02:47:00] * krinklemail: mw.Target: Add class "mw-ve-editNotice" to edit notices [02:47:00] * roan.kattouw: ve.ui.MWPopupTool: Simplify code complexity [02:47:01] * roan.kattouw: Update VE core submodule to master (8c017ae) [02:47:01] * jforrester: Add fallback template description with link to template page [02:47:02] * jforrester: Make references list dialog small, and vary 'insert' vs. 'apply' button text [02:47:02] * tparscal: Re-sort the i18n files alphabetically [02:47:03] * roan.kattouw: Actually make the save dialog grow when showing a diff [02:47:03] * jforrester: Make the reference dialog medium, not large [02:47:04] * kaldari: Adding a comment explaining where the i18n messages are [02:59:42] Project VisualEditor-en.wikipedia.beta.wmflabs.org-macos-firefox build #31: STILL FAILING in 1 hr 36 min: https://wmf.ci.cloudbees.com/job/VisualEditor-en.wikipedia.beta.wmflabs.org-macos-firefox/31/ [02:59:43] * jgonera: Add createSurface() to Target [02:59:43] * jforrester: Enable VisualEditor by default in NS_USER as well as $wgContentNamespaces [02:59:44] * krenair: Fix fatal when user switches from VE to the old editor and makes a null edit [02:59:44] * jforrester: [Browser tests] Remove dumb stuff from steps. [02:59:45] * roan.kattouw: Deal with images whose size is smalled than default [02:59:45] * roan.kattouw: Rename 'wasve' parameter to 'veswitched' [02:59:46] * roan.kattouw: Fix JS error trying to access this.saveDialog from switch to source mode code path [02:59:46] * krinklemail: mw.ViewPageTarget: Tag our state changes and reject foreign states [02:59:47] * trevorparscal: Keep label and disabled state of transclusion dialog apply button in sync [02:59:47] * krinklemail: mw.Target: Add class "mw-ve-editNotice" to edit notices [02:59:48] * roan.kattouw: ve.ui.MWPopupTool: Simplify code complexity [02:59:48] * roan.kattouw: Update VE core submodule to master (8c017ae) [02:59:49] * jforrester: Add fallback template description with link to template page [02:59:49] * jforrester: Make references list dialog small, and vary 'insert' vs. 'apply' button text [02:59:50] * tparscal: Re-sort the i18n files alphabetically [02:59:50] * roan.kattouw: Actually make the save dialog grow when showing a diff [02:59:51] * jforrester: Make the reference dialog medium, not large [03:02:08] Can we disable these changelog pings? Aside from it flooding the channel and pinging people, it is also repetative as it does it multiple times for the same changelog (once for each for the different wiki/project/browser jobs). [03:02:33] So I get pinged every few minutes for several hours long [03:02:58] There is a config option for it in Jenkins. [03:21:44] Project UniversalLanguageSelector-commons.wikimedia.beta.wmflabs.org-linux-firefox build #345: STILL FAILING in 22 min: https://wmf.ci.cloudbees.com/job/UniversalLanguageSelector-commons.wikimedia.beta.wmflabs.org-linux-firefox/345/ [03:23:47] Project UploadWizard-api-commons.wikimedia.beta.wmflabs.org build #179: SUCCESS in 1 min 58 sec: https://wmf.ci.cloudbees.com/job/UploadWizard-api-commons.wikimedia.beta.wmflabs.org/179/ [03:31:28] Project browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_7 build #525: STILL FAILING in 44 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_7/525/ [03:31:28] zeljko.filipin: Moved "I am at a random page" step to the mediawiki_selenium Ruby gem [03:32:48] Project UploadWizard-api-commons.wikimedia.org build #163: SUCCESS in 1 min 14 sec: https://wmf.ci.cloudbees.com/job/UploadWizard-api-commons.wikimedia.org/163/ [03:43:23] Project Flow-en.wikipedia.beta.wmflabs.org-windows-internet-explorer-10 build #197: STILL FAILING in 10 min: https://wmf.ci.cloudbees.com/job/Flow-en.wikipedia.beta.wmflabs.org-windows-internet-explorer-10/197/ [03:44:02] (03PS1) 10Mattflaschen: Test and publish jsduck for GuidedTour [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/118426 [03:44:13] (03CR) 10jenkins-bot: [V: 04-1] Test and publish jsduck for GuidedTour [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/118426 (owner: 10Mattflaschen) [03:46:21] Project Translate-sandbox.translatewiki.net-linux-firefox build #308: SUCCESS in 22 min: https://wmf.ci.cloudbees.com/job/Translate-sandbox.translatewiki.net-linux-firefox/308/ [03:51:12] (03PS2) 10Mattflaschen: Test and publish jsduck for GuidedTour [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/118426 [03:53:15] Project TwnMainPage-sandbox.translatewiki.net-linux-firefox build #303: SUCCESS in 9 min 47 sec: https://wmf.ci.cloudbees.com/job/TwnMainPage-sandbox.translatewiki.net-linux-firefox/303/ [03:53:16] amir.aharoni: Use agora button styles [03:59:57] (03PS3) 10Mattflaschen: Test and publish jsduck for GuidedTour [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/118426 [04:04:37] Project browsertests-test2.wikipedia.org-linux-firefox build #933: SUCCESS in 18 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-linux-firefox/933/ [04:04:37] zeljko.filipin: Moved "I am at a random page" step to the mediawiki_selenium Ruby gem [04:07:15] Project MobileFrontend-en.m.wikipedia.org-linux-firefox build #354: STILL FAILING in 13 min: https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.org-linux-firefox/354/ [04:07:15] * jrobson: Add password reset link from desktop on mobile [04:07:16] * jrobson: Hygiene: Make language browser tests more generic [04:08:58] Project CirrusSearch-test2.wikipedia.org-linux-firefox build #54: SUCCESS in 1 min 39 sec: https://wmf.ci.cloudbees.com/job/CirrusSearch-test2.wikipedia.org-linux-firefox/54/ [04:13:18] Project UploadWizard-commons.wikimedia.beta.wmflabs.org-linux-firefox build #666: SUCCESS in 8 min 41 sec: https://wmf.ci.cloudbees.com/job/UploadWizard-commons.wikimedia.beta.wmflabs.org-linux-firefox/666/ [04:13:19] zfilipin: Cloudbees Jenkins jobs are now created using Jenkins Job Builder [04:17:19] (03PS1) 10Mattflaschen: Add jobs for GuidedTour jsduck build [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/118428 [04:19:50] (03PS4) 10Mattflaschen: Test and publish jsduck for GuidedTour [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/118426 [04:27:12] (03PS2) 10Mattflaschen: Add jobs for GuidedTour jsduck build [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/118428 [04:35:58] (03CR) 10Krinkle: Add jobs for GuidedTour jsduck build (031 comment) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/118428 (owner: 10Mattflaschen) [04:42:01] Project browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_10 build #527: SUCCESS in 33 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_10/527/ [04:42:01] zeljko.filipin: Moved "I am at a random page" step to the mediawiki_selenium Ruby gem [04:52:15] Project UniversalLanguageSelector-language-browsertests.wmflabs.org-linux-firefox build #39: STILL FAILING in 10 min: https://wmf.ci.cloudbees.com/job/UniversalLanguageSelector-language-browsertests.wmflabs.org-linux-firefox/39/ [04:52:32] Project browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_8 build #593: STILL FAILING in 39 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_8/593/ [04:52:32] zeljko.filipin: Moved "I am at a random page" step to the mediawiki_selenium Ruby gem [04:54:51] Project Translate-meta.wikimedia.org-linux-firefox build #206: SUCCESS in 2 min 15 sec: https://wmf.ci.cloudbees.com/job/Translate-meta.wikimedia.org-linux-firefox/206/ [05:15:44] Project UniversalLanguageSelector-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_10 build #58: STILL FAILING in 23 min: https://wmf.ci.cloudbees.com/job/UniversalLanguageSelector-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_10/58/ [05:30:45] Project browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_9 build #622: SUCCESS in 35 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_9/622/ [05:44:50] Project browsertests-test2.wikipedia.org-windows-internet_explorer_10 build #516: SUCCESS in 29 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-windows-internet_explorer_10/516/ [06:48:15] Project VisualEditor-en.wikipedia.beta.wmflabs.org-windows_xp-chrome build #31: STILL FAILING in 1 hr 3 min: https://wmf.ci.cloudbees.com/job/VisualEditor-en.wikipedia.beta.wmflabs.org-windows_xp-chrome/31/ [06:48:15] * jgonera: Add createSurface() to Target [06:48:16] * jforrester: Enable VisualEditor by default in NS_USER as well as $wgContentNamespaces [06:48:16] * roan.kattouw: Fix JS error trying to access this.saveDialog from switch to source mode code path [06:48:17] * krinklemail: mw.ViewPageTarget: Tag our state changes and reject foreign states [06:48:17] * trevorparscal: Keep label and disabled state of transclusion dialog apply button in sync [06:48:18] * krinklemail: mw.Target: Add class "mw-ve-editNotice" to edit notices [06:48:18] * roan.kattouw: ve.ui.MWPopupTool: Simplify code complexity [06:48:19] * roan.kattouw: Update VE core submodule to master (8c017ae) [06:48:19] * jforrester: Add fallback template description with link to template page [06:48:20] * jforrester: Make references list dialog small, and vary 'insert' vs. 'apply' button text [06:48:20] * tparscal: Re-sort the i18n files alphabetically [06:48:21] * roan.kattouw: Actually make the save dialog grow when showing a diff [06:48:21] * jforrester: Make the reference dialog medium, not large [06:48:22] * kaldari: Adding a comment explaining where the i18n messages are [06:48:22] * krenair: More gracefully handle situations where Parsoid returns a timeout failure code (HTTP 504) [06:48:23] * jforrester: Create remaining meta items in DM [06:50:49] Project VisualEditor-test2.wikipedia.org-linux-firefox build #393: STILL FAILING in 1 hr 20 min: https://wmf.ci.cloudbees.com/job/VisualEditor-test2.wikipedia.org-linux-firefox/393/ [06:50:49] * jgonera: Add createSurface() to Target [06:50:50] * jforrester: Enable VisualEditor by default in NS_USER as well as $wgContentNamespaces [06:50:50] * roan.kattouw: Fix JS error trying to access this.saveDialog from switch to source mode code path [06:50:51] * krinklemail: mw.ViewPageTarget: Tag our state changes and reject foreign states [06:50:51] * trevorparscal: Keep label and disabled state of transclusion dialog apply button in sync [06:50:52] * krinklemail: mw.Target: Add class "mw-ve-editNotice" to edit notices [06:50:52] * roan.kattouw: ve.ui.MWPopupTool: Simplify code complexity [06:50:53] * roan.kattouw: Update VE core submodule to master (8c017ae) [06:50:53] * jforrester: Add fallback template description with link to template page [06:50:54] * jforrester: Make references list dialog small, and vary 'insert' vs. 'apply' button text [06:50:54] * tparscal: Re-sort the i18n files alphabetically [06:50:55] * roan.kattouw: Actually make the save dialog grow when showing a diff [06:50:55] * jforrester: Make the reference dialog medium, not large [06:50:56] * kaldari: Adding a comment explaining where the i18n messages are [06:50:56] * krenair: More gracefully handle situations where Parsoid returns a timeout failure code (HTTP 504) [06:50:57] * jforrester: Create remaining meta items in DM [06:55:17] Yippee, build fixed! [06:55:18] Project Flow-en.wikipedia.beta.wmflabs.org-linux-chrome build #299: FIXED in 7 min 2 sec: https://wmf.ci.cloudbees.com/job/Flow-en.wikipedia.beta.wmflabs.org-linux-chrome/299/ [06:59:54] Yippee, build fixed! [06:59:54] Project UploadWizard-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_9 build #639: FIXED in 9 min 0 sec: https://wmf.ci.cloudbees.com/job/UploadWizard-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_9/639/ [07:01:20] Project UniversalLanguageSelector-sandbox.translatewiki.net-linux-firefox build #287: SUCCESS in 1 min 26 sec: https://wmf.ci.cloudbees.com/job/UniversalLanguageSelector-sandbox.translatewiki.net-linux-firefox/287/ [07:20:19] Project browsertests-test2.wikipedia.org-windows-internet_explorer_9 build #831: STILL FAILING in 25 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-windows-internet_explorer_9/831/ [07:23:31] Yippee, build fixed! [07:23:31] Project browsertests-en.wikipedia.beta.wmflabs.org-linux-firefox build #700: FIXED in 22 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-linux-firefox/700/ [07:28:14] Project Flow-test2.wikipedia.org-linux-chrome build #169: STILL FAILING in 7 min 50 sec: https://wmf.ci.cloudbees.com/job/Flow-test2.wikipedia.org-linux-chrome/169/ [07:32:46] Yippee, build fixed! [07:32:46] Project UploadWizard-commons.wikimedia.beta.wmflabs.org-linux-chrome build #705: FIXED in 9 min 15 sec: https://wmf.ci.cloudbees.com/job/UploadWizard-commons.wikimedia.beta.wmflabs.org-linux-chrome/705/ [08:01:23] Project MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome build #318: STILL FAILING in 28 min: https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/318/ [08:01:24] jrobson: Hygiene: Make language browser tests more generic [08:47:02] Project VisualEditor-en.wikipedia.beta.wmflabs.org-linux-firefox build #388: STILL FAILING in 1 hr 18 min: https://wmf.ci.cloudbees.com/job/VisualEditor-en.wikipedia.beta.wmflabs.org-linux-firefox/388/ [08:47:03] jforrester: Create remaining meta items in DM [08:50:10] (03PS4) 10Zfilipin: Moved "page has no ResourceLoader errors" Cucumber step to mediawiki_selenium Ruby gem [qa/browsertests] - 10https://gerrit.wikimedia.org/r/118288 [09:02:13] (03PS1) 10Hashar: Disable mediawiki-core-regression-phpcs-HEAD [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/118434 [09:04:33] (03CR) 10Hashar: [C: 032] Disable mediawiki-core-regression-phpcs-HEAD [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/118434 (owner: 10Hashar) [09:04:37] (03Merged) 10jenkins-bot: Disable mediawiki-core-regression-phpcs-HEAD [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/118434 (owner: 10Hashar) [09:30:32] Project VisualEditor-en.wikipedia.beta.wmflabs.org-windows_xp-firefox build #31: STILL FAILING in 1 hr 29 min: https://wmf.ci.cloudbees.com/job/VisualEditor-en.wikipedia.beta.wmflabs.org-windows_xp-firefox/31/ [09:30:33] * jgonera: Add createSurface() to Target [09:30:33] * jforrester: Enable VisualEditor by default in NS_USER as well as $wgContentNamespaces [09:30:34] * roan.kattouw: Fix JS error trying to access this.saveDialog from switch to source mode code path [09:30:34] * krinklemail: mw.ViewPageTarget: Tag our state changes and reject foreign states [09:30:35] * trevorparscal: Keep label and disabled state of transclusion dialog apply button in sync [09:30:35] * krinklemail: mw.Target: Add class "mw-ve-editNotice" to edit notices [09:30:36] * roan.kattouw: ve.ui.MWPopupTool: Simplify code complexity [09:30:36] * roan.kattouw: Update VE core submodule to master (8c017ae) [09:30:37] * jforrester: Add fallback template description with link to template page [09:30:37] * jforrester: Make references list dialog small, and vary 'insert' vs. 'apply' button text [09:30:38] * tparscal: Re-sort the i18n files alphabetically [09:30:38] * roan.kattouw: Actually make the save dialog grow when showing a diff [09:30:39] * jforrester: Make the reference dialog medium, not large [09:30:39] * kaldari: Adding a comment explaining where the i18n messages are [09:30:40] * krenair: More gracefully handle situations where Parsoid returns a timeout failure code (HTTP 504) [09:30:40] * jforrester: Create remaining meta items in DM [09:36:49] Project MultimediaViewer-en.wikipedia.beta.wmflabs.org-linux-firefox build #105: SUCCESS in 6 min 15 sec: https://wmf.ci.cloudbees.com/job/MultimediaViewer-en.wikipedia.beta.wmflabs.org-linux-firefox/105/ [09:57:38] Project VisualEditor-test2.wikipedia.org-linux-chrome build #364: STILL FAILING in 1 hr 10 min: https://wmf.ci.cloudbees.com/job/VisualEditor-test2.wikipedia.org-linux-chrome/364/ [09:57:39] * jgonera: Add createSurface() to Target [09:57:39] * roan.kattouw: Fix JS error trying to access this.saveDialog from switch to source mode code path [09:57:40] * trevorparscal: Keep label and disabled state of transclusion dialog apply button in sync [09:57:40] * krinklemail: mw.Target: Add class "mw-ve-editNotice" to edit notices [09:57:41] * roan.kattouw: ve.ui.MWPopupTool: Simplify code complexity [09:57:41] * roan.kattouw: Update VE core submodule to master (8c017ae) [09:57:42] * jforrester: Add fallback template description with link to template page [09:57:42] * jforrester: Make references list dialog small, and vary 'insert' vs. 'apply' button text [09:57:43] * tparscal: Re-sort the i18n files alphabetically [09:57:43] * roan.kattouw: Actually make the save dialog grow when showing a diff [09:57:44] * jforrester: Make the reference dialog medium, not large [09:57:44] * kaldari: Adding a comment explaining where the i18n messages are [09:57:45] * krenair: More gracefully handle situations where Parsoid returns a timeout failure code (HTTP 504) [09:57:45] * jforrester: Create remaining meta items in DM [10:00:56] Project ContentTranslation-language-stage.wmflabs.org-linux-firefox build #17: SUCCESS in 3 min 12 sec: https://wmf.ci.cloudbees.com/job/ContentTranslation-language-stage.wmflabs.org-linux-firefox/17/ [10:10:12] Project UploadWizard-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_10 build #527: SUCCESS in 9 min 15 sec: https://wmf.ci.cloudbees.com/job/UploadWizard-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_10/527/ [10:28:16] hashar: do you have time to help me set up this gerrit repo? [10:28:34] https://gerrit.wikimedia.org/r/#/admin/projects/mediawiki/ruby/api [10:28:45] I need to make +2 merge commits [10:28:48] and all that jazz [10:29:28] zeljkof: hhaaaallo [10:29:37] hashar: good morning :) [10:29:48] ready for some jenkins/gerrit work? [10:31:12] zeljkof: yeah sure [10:31:18] I guess you want to run ruby lint on it ? [10:31:21] Project browsertests-en.wikipedia.beta.wmflabs.org-linux-chrome build #721: STILL FAILING in 21 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-linux-chrome/721/ [10:31:26] all the linters! :) [10:31:27] and probably build the gem as well [10:31:31] hm [10:31:47] the first step is to have jobs created in Jenkins [10:31:50] well, first, let's just make it merge the commit on +2 [10:32:24] hashar: should we create a hangout for this, or is irc good enough? [10:32:30] irc [10:32:39] I am at my coworking place with ton of folks around me sorry :/ [10:32:47] no problem [10:32:55] it is quite easy to do dont worry [10:33:07] have you cloned the configuration files? git clone ssh://gerrit.wikimedia.org:29418/integration/jenkins-job-builder-config.git [10:33:35] in there you will find the job defined for mediawiki/selenium.git which are in mediawiki-misc.yaml [10:33:46] you would need to copy paste a bit to define a project mediawiki-rubi-api [10:33:54] and define a job '{name}-ruby1.9.3lint' [10:34:05] hashar: let me get the latest for that repo [10:34:13] + need a mediawiki-ruby-api-gembuild job [10:34:31] I usually build the gem locally and push to rubygems [10:34:41] there is no need to do it from the jenkins job [10:35:10] by building the gem whenever a change is pushed to Gerrit, you ensure it is actually build able :] [10:35:22] hashar: hm [10:35:34] makes sense [10:35:44] so we just build the gem, but not push it rubygems then, right? [10:35:59] exactly [10:36:08] ok, makes sense [10:36:11] just like we can compile a debian package but not actually uploading it [10:36:19] let me clone the repo, looks like I do not have it [10:37:04] another question [10:37:15] how to I move my jjb-config to gerrit? [10:37:28] this one [10:37:28] https://github.com/zeljkofilipin/jenkins-job-builder-config [10:37:32] ah [10:37:40] that is for cloudbee right? [10:37:44] yes [10:37:57] should I leave it there until we move the jobs to wmf jenkins? [10:38:07] since that is the next step anyway [10:38:22] not necessarily, we can move the to the jjb-config repo in a dedicated branch named cloudbee for example [10:38:43] would it make it harder for people to contribute commits? [10:38:58] I am not sure how to push a commit to gerrit if it is not for the master branch :) [10:39:36] that is easy as well: git push gerrit HEAD:refs/for/cloudbee [10:39:50] the syntax is: refs/for/ [10:40:12] with git-review, we can set the .gitreview file to point to the cloudbee branch [10:40:17] it is not this? git review [10:40:24] ok [10:40:32] so you would just git-review [10:40:34] :] [10:40:51] since I do not know how to do it, my guess is that others will also have trouble with that :) [10:40:56] we can leave that for later [10:41:04] let's fix the gem first [10:41:12] I have the config repo cloned [10:41:19] looking at mediawiki-misc.yaml [10:45:10] uh oh [10:45:26] No such file or directory: 'jjb-output/VisualEditor-jsduck' [10:45:36] ok, I have to create the directory first :) [10:45:38] :-D [10:45:44] Project VisualEditor-en.wikipedia.beta.wmflabs.org-linux-chrome build #369: STILL FAILING in 1 hr 8 min: https://wmf.ci.cloudbees.com/job/VisualEditor-en.wikipedia.beta.wmflabs.org-linux-chrome/369/ [10:45:45] * jgonera: Add createSurface() to Target [10:45:45] * roan.kattouw: Fix JS error trying to access this.saveDialog from switch to source mode code path [10:45:46] * trevorparscal: Keep label and disabled state of transclusion dialog apply button in sync [10:45:46] * roan.kattouw: Update VE core submodule to master (8c017ae) [10:45:47] * jforrester: Add fallback template description with link to template page [10:45:47] yeah jjb should probably create it for you [10:45:47] * jforrester: Make references list dialog small, and vary 'insert' vs. 'apply' button text [10:45:48] * tparscal: Re-sort the i18n files alphabetically [10:45:48] * roan.kattouw: Actually make the save dialog grow when showing a diff [10:45:49] * jforrester: Make the reference dialog medium, not large [10:45:49] * kaldari: Adding a comment explaining where the i18n messages are [10:45:50] * krenair: More gracefully handle situations where Parsoid returns a timeout failure code (HTTP 504) [10:45:50] * jforrester: Create remaining meta items in DM [10:50:13] jjb is pretty fast [10:50:32] it takes just a few seconds to create 1.3k xml files [10:51:33] 14 seconds to be precise [10:51:36] impressive [10:51:47] I thought I would have to take a break until it generates stuff [10:55:00] yeah and it is still slow [10:55:16] I identified one slowdown that could cut that time down to a few seconds [10:55:26] but 15 seconds is good enough for now :] [10:55:38] you can get it even faster by passing the job name as a parameter [10:55:45] Project WikiLove-en.wikipedia.beta.wmflabs.org-linux-firefox build #45: SUCCESS in 9 min 56 sec: https://wmf.ci.cloudbees.com/job/WikiLove-en.wikipedia.beta.wmflabs.org-linux-firefox/45/ [10:55:48] something like: jjb -o output test/ my-jobname-here [11:00:04] (03PS1) 10Zfilipin: Run Ruby lint and build the gem for mediawiki/ruby/api repository [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/118441 [11:01:31] hashar: does this look good ^ [11:01:58] I have tested it locally, but I am not familiar enough with the jobs to know if the xml looks good or not [11:01:59] zeljkof: looking [11:02:15] yeah I hate the copy paste [11:02:21] but that is probably good enough for now :] [11:02:34] you can generate the jobs on the WMF Jenkins now [11:03:10] jenkins-jobs update config/ mediawiki-ruby-api-gembuild mediawiki-ruby-api-ruby1.9.3lint [11:03:38] hashar: yeah, we should refactor gembuild [11:03:46] but I just wanted to make it work for now :) [11:03:57] maybe that would do it: gem build *.gemspec [11:04:05] but yeah make it work first [11:04:08] refactor later on :] [11:04:08] ok, let my try pushing the jobs [11:04:37] I have to make the new jenkins-jobs.ini file [11:04:52] yeah [11:04:59] probably want to name it wmf-jenkins.ini [11:05:13] to avoid pushing wmf jobs to clouudbees [11:05:18] or cloud bees jobs on wmf ci :] [11:05:29] coffee break / nature's call .. [11:05:52] authentication is described at https://www.mediawiki.org/wiki/Continuous_integration/Jenkins_job_builder#JJB_Authentication [11:05:59] you need to grab the API token from wmf jenkins [11:06:00] brb [11:15:05] hashar: done all of that, let's try pushing the jobs [11:16:09] Project browsertests-test2.wikipedia.org-windows-internet_explorer_7 build #710: STILL FAILING in 44 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-windows-internet_explorer_7/710/ [11:16:29] hashar: so far so good http://etherpad.wikimedia.org/p/jjb [11:16:29] Project ZeroRatedMobileAccess-en.m.wikipedia.org-linux-phantomjs build #51: STILL FAILING in 15 sec: https://wmf.ci.cloudbees.com/job/ZeroRatedMobileAccess-en.m.wikipedia.org-linux-phantomjs/51/ [11:16:56] re [11:17:08] greaaa [11:17:17] !jenkins mediawiki-ruby-api-gembuild [11:17:17] hashar you may not issue bot commands in this chat! [11:17:21] .. [11:17:36] http://integration.wikimedia.org/ci/job/mediawiki-ruby-api-gembuild [11:17:45] zeljkof: you can attempt to build it manually [11:17:52] using the [Build with Parameters] link [11:18:03] that bring you to a web form https://integration.wikimedia.org/ci/job/mediawiki-ruby-api-gembuild/build?delay=0sec [11:18:18] a lot of parameters to input there :) [11:18:22] https://www.mediawiki.org/wiki/Continuous_integration/Tutorials/Trigger_a_job_manually [11:18:35] yeah that instruct the git plugin what to fetch [11:18:51] you can fill in : ZUUL_PROJECT -> mediawiki/rubi/api [11:19:13] then ZUUL_BRANCH ZUUL_REF and ZUUL_COMMIT set to 'master' [11:19:17] that should be good enough [11:20:06] :( https://integration.wikimedia.org/ci/job/mediawiki-ruby-api-gembuild/1/console [11:21:47] at least it started the build hehe [11:21:51] ah yeah [11:22:00] so the job are made to fetch the reference from the Zuul git repository [11:22:07] lets add the jobs to Zuul! [11:22:28] how is that done? [11:22:44] the conf is in ssh://gerrit.wikimedia.org:29418/integration/zuul-config.git [11:23:25] there is a single file there 'layout.yaml' [11:23:42] you can look at the mediawiki/selenium configuration there [11:23:49] and basically copy paste it :] [11:24:18] ok, let me try [11:24:39] the idea is to define the project [11:24:53] Yippee, build fixed! [11:24:54] Project Flow-en.wikipedia.beta.wmflabs.org-linux-firefox build #299: FIXED in 8 min 20 sec: https://wmf.ci.cloudbees.com/job/Flow-en.wikipedia.beta.wmflabs.org-linux-firefox/299/ [11:24:57] then there are various pipeline which define how/when the job will get triggered [11:25:12] check-voter runs the jobs when a patch is proposed in Gerrit and votes V+2 if it works [11:25:29] gate-and-submit executes jobs on CR+2 and merge the change for you if the jobs pass [11:25:39] postmerge runs the jobs after a change got merged [11:34:45] Project browsertests-test2.wikipedia.org-windows-internet_explorer_8 build #796: FAILURE in 38 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-windows-internet_explorer_8/796/ [11:35:57] Project CirrusSearch-en.wikipedia.beta.wmflabs.org-linux-firefox build #57: SUCCESS in 1 min 3 sec: https://wmf.ci.cloudbees.com/job/CirrusSearch-en.wikipedia.beta.wmflabs.org-linux-firefox/57/ [11:43:13] Project browsertests-test2.wikipedia.org-linux-chrome build #957: SUCCESS in 18 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-linux-chrome/957/ [11:44:22] (03PS1) 10Zfilipin: Zuul configuration for mediawiki/ruby/api repository [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/118454 [11:44:36] hashar: can you take a look? ^ [11:53:36] hashar: around? [11:53:49] ssorry [11:53:52] looking [11:54:18] letsss merge that [11:54:26] (03CR) 10Hashar: [C: 032] "\O/" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/118454 (owner: 10Zfilipin) [11:54:31] (03Merged) 10jenkins-bot: Zuul configuration for mediawiki/ruby/api repository [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/118454 (owner: 10Zfilipin) [11:54:34] deploying [11:55:21] test change https://gerrit.wikimedia.org/r/118455 [11:55:34] poor jenkins [11:56:26] success https://integration.wikimedia.org/ci/job/mediawiki-ruby-api-ruby1.9.3lint/1/console [11:56:26] :D [11:57:05] zeljkof: congratulations! [11:58:05] hashar: woohoooo :) [11:58:17] pairing with Tobi_WMDE at the moment on the gem [11:59:17] so, all is done? things will just work now for the api gem? [12:05:23] zeljkof: yup it should [12:05:33] hashar: looks like it is working [12:06:20] Project MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox build #414: STILL FAILING in 30 min: https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox/414/ [12:09:53] hashar: could you also merge this? https://gerrit.wikimedia.org/r/#/c/118441/ [12:10:11] sure ! [12:10:23] (03CR) 10Hashar: [C: 032] "Deployed by Zeljkof" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/118441 (owner: 10Zfilipin) [12:10:40] (03Merged) 10jenkins-bot: Run Ruby lint and build the gem for mediawiki/ruby/api repository [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/118441 (owner: 10Zfilipin) [12:11:00] Project MobileFrontend-test2.m.wikipedia.org-linux-firefox build #314: STILL FAILING in 27 min: https://wmf.ci.cloudbees.com/job/MobileFrontend-test2.m.wikipedia.org-linux-firefox/314/ [12:24:24] re [12:25:39] zeljkof: and now you get the gems generated for you when a change is merged [12:25:45] example https://integration.wikimedia.org/ci/job/mediawiki-ruby-api-gembuild/7/ [12:26:08] there might be a way to have gem build to include the sha1 in the version [12:30:58] hashar: great job done today [12:30:58] I have just reviewed and merged all pending patches for the api gem with Tobi_WMDE [12:30:58] releasing the gem right now [12:32:21] dont forget to tag ! [12:33:15] hashar: tag or it did not happen :) [12:34:46] Invalid gemspec in [mediawiki_api.gemspec]: Malformed version number string 0.0.0-11-g402740c [12:34:48] wth [12:43:35] hashar: try something like 0.0.0g402740c [12:43:38] that should work [12:44:36] yeah was wondering how to get spec.version to be filled with 'git describe --tags' [12:44:44] needs to replace dashes with dots [12:44:47] and insert 'pre' somewhere [12:44:59] aka 0.0.0.pre.11.g402740c [12:45:10] gave up :] [12:45:36] no [12:45:40] really, try this [12:45:45] 0.0.0sha [12:46:00] rubygems should not care about the string that comes after the patch [12:46:08] pre or beta or rc or sha, it should not care [12:46:23] but I think it only allows major.minor.patch format [12:46:27] so, two dots [12:56:05] Project browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_7 build #526: STILL FAILING in 45 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_7/526/ [13:18:44]