[00:09:18] Project UniversalLanguageSelector-commons.wikimedia.beta.wmflabs.org-linux-firefox build #384: SUCCESS in 24 min: https://wmf.ci.cloudbees.com/job/UniversalLanguageSelector-commons.wikimedia.beta.wmflabs.org-linux-firefox/384/ [00:09:19] * santhosh.thottingal: Simplify tofu detection cache [00:09:19] * amir.aharoni: Update the comment for $.fn.webfonts.defaults.fontSelector [00:09:19] * l10n-bot: Localisation updates from https://translatewiki.net. [00:09:57] Project browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_7 build #562: STILL FAILING in 33 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_7/562/ [00:10:44] Project UploadWizard-api-commons.wikimedia.beta.wmflabs.org build #258: SUCCESS in 1 min 25 sec: https://wmf.ci.cloudbees.com/job/UploadWizard-api-commons.wikimedia.beta.wmflabs.org/258/ [00:10:45] l10n-bot: Localisation updates from https://translatewiki.net. [00:12:02] Project UploadWizard-api-commons.wikimedia.org build #218: SUCCESS in 1 min 17 sec: https://wmf.ci.cloudbees.com/job/UploadWizard-api-commons.wikimedia.org/218/ [00:12:02] l10n-bot: Localisation updates from https://translatewiki.net. [00:22:41] Project TwnMainPage-sandbox.translatewiki.net-linux-firefox build #341: SUCCESS in 10 min: https://wmf.ci.cloudbees.com/job/TwnMainPage-sandbox.translatewiki.net-linux-firefox/341/ [00:22:42] l10n-bot: Localisation updates from https://translatewiki.net. [00:28:41] (03PS1) 10Krinkle: Zuul status page: Add support for highlighting a change by id [integration/docroot] - 10https://gerrit.wikimedia.org/r/123145 [00:29:07] (03CR) 10Krinkle: "http://i.imgur.com/AWnE8I3.png" [integration/docroot] - 10https://gerrit.wikimedia.org/r/123145 (owner: 10Krinkle) [00:34:26] Project Translate-sandbox.translatewiki.net-linux-firefox build #345: SUCCESS in 24 min: https://wmf.ci.cloudbees.com/job/Translate-sandbox.translatewiki.net-linux-firefox/345/ [00:34:26] l10n-bot: Localisation updates from https://translatewiki.net. [00:41:38] (03Abandoned) 10CSteipp: Disable gc during tests [integration/jenkins] - 10https://gerrit.wikimedia.org/r/121697 (owner: 10CSteipp) [00:45:49] Project browsertests-test2.wikipedia.org-linux-firefox build #968: SUCCESS in 23 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-linux-firefox/968/ [00:48:31] Project MobileFrontend-en.m.wikipedia.org-linux-firefox build #389: SUCCESS in 14 min: https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.org-linux-firefox/389/ [00:48:32] l10n-bot: Localisation updates from https://translatewiki.net. [00:49:40] Project CirrusSearch-test2.wikipedia.org-linux-firefox build #88: SUCCESS in 1 min 8 sec: https://wmf.ci.cloudbees.com/job/CirrusSearch-test2.wikipedia.org-linux-firefox/88/ [00:49:40] * chadh: Fix incorrect hook usage, second parameter is a reference [00:49:41] * chadh: Reattempt failed OtherIndexJobs [00:49:42] * chadh: More job reattempts, this time LinksUpdateJob(Prioritized) [00:49:42] * chadh: Doc update on updatePages() [00:49:43] * l10n-bot: Localisation updates from https://translatewiki.net. [00:53:54] Yippee, build fixed! [00:53:54] Project UploadWizard-commons.wikimedia.beta.wmflabs.org-linux-firefox build #701: FIXED in 8 min 4 sec: https://wmf.ci.cloudbees.com/job/UploadWizard-commons.wikimedia.beta.wmflabs.org-linux-firefox/701/ [00:53:55] l10n-bot: Localisation updates from https://translatewiki.net. [01:13:08] Project browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_10 build #562: STILL FAILING in 23 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_10/562/ [01:15:44] Project browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_8 build #627: STILL FAILING in 21 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_8/627/ [01:17:08] Project UploadWizard-api-commons.wikimedia.beta.wmflabs.org build #259: SUCCESS in 1 min 21 sec: https://wmf.ci.cloudbees.com/job/UploadWizard-api-commons.wikimedia.beta.wmflabs.org/259/ [01:18:28] Project UploadWizard-api-commons.wikimedia.org build #219: SUCCESS in 1 min 19 sec: https://wmf.ci.cloudbees.com/job/UploadWizard-api-commons.wikimedia.org/219/ [01:21:53] Project UniversalLanguageSelector-language-browsertests.wmflabs.org-linux-firefox build #64: SUCCESS in 8 min 43 sec: https://wmf.ci.cloudbees.com/job/UniversalLanguageSelector-language-browsertests.wmflabs.org-linux-firefox/64/ [01:21:54] * santhosh.thottingal: Simplify tofu detection cache [01:21:54] * santhosh.thottingal: Reorganize the compact links code, make it a jquery plugin [01:21:55] * santhosh.thottingal: Unhide a language instead of adding it [01:21:55] * amir.aharoni: Update the comment for $.fn.webfonts.defaults.fontSelector [01:21:56] * l10n-bot: Localisation updates from https://translatewiki.net. [03:08:57] Project Translate-meta.wikimedia.org-linux-firefox build #247: SUCCESS in 2 min 1 sec: https://wmf.ci.cloudbees.com/job/Translate-meta.wikimedia.org-linux-firefox/247/ [03:08:57] l10n-bot: Localisation updates from https://translatewiki.net. [03:32:51] Project browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_9 build #662: STILL FAILING in 23 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_9/662/ [03:37:33] Project UniversalLanguageSelector-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_10 build #102: STILL FAILING in 34 min: https://wmf.ci.cloudbees.com/job/UniversalLanguageSelector-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_10/102/ [03:37:33] l10n-bot: Localisation updates from https://translatewiki.net. [03:57:15] Project browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_6 build #504: STILL FAILING in 24 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_6/504/ [04:11:49] Project browsertests-test2.wikipedia.org-windows-internet_explorer_10 build #556: SUCCESS in 34 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-windows-internet_explorer_10/556/ [04:17:41] Project Flow-en.wikipedia.beta.wmflabs.org-linux-chrome build #341: STILL FAILING in 5 min 52 sec: https://wmf.ci.cloudbees.com/job/Flow-en.wikipedia.beta.wmflabs.org-linux-chrome/341/ [04:17:41] * bsitu: Move method isComparableTo() to parent class [04:17:42] * git: Make flow history wider [04:17:42] * git: There should be no diff-link for new posts, there's nothing to diff against [04:17:43] * l10n-bot: Localisation updates from https://translatewiki.net. [04:17:43] * ebernhardson: Remove Flow's mw-ui-button overrides [04:17:44] * ebernhardson: Reorganise flow-post-interaction link styling [04:29:07] Project UploadWizard-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_9 build #678: STILL FAILING in 11 min: https://wmf.ci.cloudbees.com/job/UploadWizard-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_9/678/ [04:29:08] l10n-bot: Localisation updates from https://translatewiki.net. [04:46:51] Yippee, build fixed! [04:46:51] Project VisualEditor-test2.wikipedia.org-linux-firefox build #433: FIXED in 49 min: https://wmf.ci.cloudbees.com/job/VisualEditor-test2.wikipedia.org-linux-firefox/433/ [04:46:52] * l10n-bot: Localisation updates from https://translatewiki.net. [04:46:52] * jforrester: Bump jscs to 0.4.1 [04:46:53] * esanders: Convert double quotes to single quotes in VisualEditor.php [04:46:53] * krinklemail: Add missing VE core themes/apex/ve.ui.Inspector.css to .docs/eg-iframe.html [04:48:15] Project UniversalLanguageSelector-sandbox.translatewiki.net-linux-firefox build #325: SUCCESS in 1 min 23 sec: https://wmf.ci.cloudbees.com/job/UniversalLanguageSelector-sandbox.translatewiki.net-linux-firefox/325/ [04:48:15] l10n-bot: Localisation updates from https://translatewiki.net. [05:03:21] Project browsertests-en.wikipedia.beta.wmflabs.org-linux-firefox build #742: STILL FAILING in 15 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-linux-firefox/742/ [05:07:24] Project browsertests-test2.wikipedia.org-windows-internet_explorer_9 build #870: STILL FAILING in 38 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-windows-internet_explorer_9/870/ [05:10:48] Project Flow-test2.wikipedia.org-linux-chrome build #207: STILL FAILING in 7 min 26 sec: https://wmf.ci.cloudbees.com/job/Flow-test2.wikipedia.org-linux-chrome/207/ [05:10:48] * bsitu: Move method isComparableTo() to parent class [05:10:49] * git: Make flow history wider [05:10:49] * git: There should be no diff-link for new posts, there's nothing to diff against [05:10:50] * ebernhardson: Remove Flow's mw-ui-button overrides [05:10:50] * ebernhardson: Reorganise flow-post-interaction link styling [05:15:55] Project UploadWizard-commons.wikimedia.beta.wmflabs.org-linux-chrome build #743: SUCCESS in 8 min 29 sec: https://wmf.ci.cloudbees.com/job/UploadWizard-commons.wikimedia.beta.wmflabs.org-linux-chrome/743/ [05:22:49] Project Flow-test2.wikipedia.org-windows-internet_explorer_10 build #132: STILL FAILING in 11 min: https://wmf.ci.cloudbees.com/job/Flow-test2.wikipedia.org-windows-internet_explorer_10/132/ [05:22:49] * bsitu: Move method isComparableTo() to parent class [05:22:50] * git: Make flow history wider [05:22:50] * git: There should be no diff-link for new posts, there's nothing to diff against [05:22:51] * ebernhardson: Remove Flow's mw-ui-button overrides [05:22:51] * ebernhardson: Reorganise flow-post-interaction link styling [05:34:39] Project VisualEditor-en.wikipedia.beta.wmflabs.org-linux-firefox build #436: STILL FAILING in 18 min: https://wmf.ci.cloudbees.com/job/VisualEditor-en.wikipedia.beta.wmflabs.org-linux-firefox/436/ [05:34:40] * jforrester: Bump jscs to 0.4.1 [05:34:41] * esanders: Convert double quotes to single quotes in VisualEditor.php [05:34:41] * krinklemail: Add missing VE core themes/apex/ve.ui.Inspector.css to .docs/eg-iframe.html [05:56:07] Project VisualEditor-en.wikipedia.beta.wmflabs.org-windows_xp-firefox build #68: STILL FAILING in 21 min: https://wmf.ci.cloudbees.com/job/VisualEditor-en.wikipedia.beta.wmflabs.org-windows_xp-firefox/68/ [05:56:08] * jforrester: Bump jscs to 0.4.1 [05:56:08] * esanders: Convert double quotes to single quotes in VisualEditor.php [05:56:09] * krinklemail: Add missing VE core themes/apex/ve.ui.Inspector.css to .docs/eg-iframe.html [05:56:14] Project MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome build #357: STILL FAILING in 33 min: https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/357/ [05:56:52] Project MultimediaViewer-en.wikipedia.beta.wmflabs.org-linux-firefox build #142: STILL FAILING in 44 sec: https://wmf.ci.cloudbees.com/job/MultimediaViewer-en.wikipedia.beta.wmflabs.org-linux-firefox/142/ [06:05:21] Project Flow-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_10 build #235: STILL FAILING in 8 min 27 sec: https://wmf.ci.cloudbees.com/job/Flow-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_10/235/ [06:15:04] Project VisualEditor-en.wikipedia.beta.wmflabs.org-linux-chrome build #409: STILL FAILING in 18 min: https://wmf.ci.cloudbees.com/job/VisualEditor-en.wikipedia.beta.wmflabs.org-linux-chrome/409/ [06:15:04] * jforrester: Bump jscs to 0.4.1 [06:15:05] * esanders: Convert double quotes to single quotes in VisualEditor.php [06:15:05] * krinklemail: Add missing VE core themes/apex/ve.ui.Inspector.css to .docs/eg-iframe.html [06:28:33] Project UploadWizard-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_10 build #564: SUCCESS in 13 min: https://wmf.ci.cloudbees.com/job/UploadWizard-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_10/564/ [06:43:13] Project browsertests-en.wikipedia.beta.wmflabs.org-linux-chrome build #760: STILL FAILING in 14 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-linux-chrome/760/ [06:47:45] Project browsertests-test2.wikipedia.org-windows-internet_explorer_6 build #723: STILL FAILING in 42 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-windows-internet_explorer_6/723/ [06:48:39] Project WikiLove-en.wikipedia.beta.wmflabs.org-linux-firefox build #84: STILL FAILING in 52 sec: https://wmf.ci.cloudbees.com/job/WikiLove-en.wikipedia.beta.wmflabs.org-linux-firefox/84/ [07:33:37] Project browsertests-test2.wikipedia.org-windows-internet_explorer_7 build #747: FAILURE in 50 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-windows-internet_explorer_7/747/ [07:34:12] Project ZeroRatedMobileAccess-en.m.wikipedia.org-linux-phantomjs build #88: SUCCESS in 33 sec: https://wmf.ci.cloudbees.com/job/ZeroRatedMobileAccess-en.m.wikipedia.org-linux-phantomjs/88/ [07:35:05] Yippee, build fixed! [07:35:05] Project browsertests-test2.wikipedia.org-windows-internet_explorer_8 build #833: FIXED in 46 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-windows-internet_explorer_8/833/ [07:40:17] Project Flow-en.wikipedia.beta.wmflabs.org-linux-firefox build #340: STILL FAILING in 6 min 5 sec: https://wmf.ci.cloudbees.com/job/Flow-en.wikipedia.beta.wmflabs.org-linux-firefox/340/ [07:41:35] Project CirrusSearch-en.wikipedia.beta.wmflabs.org-linux-firefox build #96: SUCCESS in 1 min 16 sec: https://wmf.ci.cloudbees.com/job/CirrusSearch-en.wikipedia.beta.wmflabs.org-linux-firefox/96/ [07:56:38] Yippee, build fixed! [07:56:39] Project browsertests-test2.wikipedia.org-linux-chrome build #994: FIXED in 21 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-linux-chrome/994/ [08:18:47] Project MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox build #466: STILL FAILING in 37 min: https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox/466/ [08:27:22] Project MobileFrontend-test2.m.wikipedia.org-linux-firefox build #351: STILL FAILING in 30 min: https://wmf.ci.cloudbees.com/job/MobileFrontend-test2.m.wikipedia.org-linux-firefox/351/ [08:50:57] Project UniversalLanguageSelector-commons.wikimedia.beta.wmflabs.org-linux-firefox build #385: FAILURE in 23 min: https://wmf.ci.cloudbees.com/job/UniversalLanguageSelector-commons.wikimedia.beta.wmflabs.org-linux-firefox/385/ [08:52:44] Project browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_7 build #563: STILL FAILING in 33 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_7/563/ [09:04:23] Project TwnMainPage-sandbox.translatewiki.net-linux-firefox build #342: SUCCESS in 11 min: https://wmf.ci.cloudbees.com/job/TwnMainPage-sandbox.translatewiki.net-linux-firefox/342/ [09:16:20] Project Translate-sandbox.translatewiki.net-linux-firefox build #346: SUCCESS in 24 min: https://wmf.ci.cloudbees.com/job/Translate-sandbox.translatewiki.net-linux-firefox/346/ [09:25:54] Project browsertests-test2.wikipedia.org-linux-firefox build #969: SUCCESS in 21 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-linux-firefox/969/ [09:29:25] Project MobileFrontend-en.m.wikipedia.org-linux-firefox build #390: FAILURE in 13 min: https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.org-linux-firefox/390/ [09:30:34] Project CirrusSearch-test2.wikipedia.org-linux-firefox build #89: SUCCESS in 1 min 8 sec: https://wmf.ci.cloudbees.com/job/CirrusSearch-test2.wikipedia.org-linux-firefox/89/ [09:33:10] (03PS4) 10Hashar: Add cxserver-npm job for mediawiki/services/cxserver [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/122715 (owner: 10Santhosh) [09:33:50] Project UploadWizard-commons.wikimedia.beta.wmflabs.org-linux-firefox build #702: SUCCESS in 7 min 55 sec: https://wmf.ci.cloudbees.com/job/UploadWizard-commons.wikimedia.beta.wmflabs.org-linux-firefox/702/ [09:34:49] (03CR) 10Hashar: [C: 032] "deployed :-]" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/122715 (owner: 10Santhosh) [09:34:50] (03PS3) 10Hashar: Use {name}-npm instead of {name}-npmtest for cxserver [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/122716 (owner: 10Santhosh) [09:35:04] (03CR) 10Hashar: [C: 032] Use {name}-npm instead of {name}-npmtest for cxserver [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/122716 (owner: 10Santhosh) [09:35:09] (03Merged) 10jenkins-bot: Use {name}-npm instead of {name}-npmtest for cxserver [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/122716 (owner: 10Santhosh) [09:35:12] (03Merged) 10jenkins-bot: Add cxserver-npm job for mediawiki/services/cxserver [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/122715 (owner: 10Santhosh) [09:53:03] Project browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_10 build #563: STILL FAILING in 22 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_10/563/ [09:58:52] Project browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_8 build #628: STILL FAILING in 25 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_8/628/ [10:00:21] Project UploadWizard-api-commons.wikimedia.beta.wmflabs.org build #260: SUCCESS in 1 min 27 sec: https://wmf.ci.cloudbees.com/job/UploadWizard-api-commons.wikimedia.beta.wmflabs.org/260/ [10:00:57] Project UniversalLanguageSelector-language-browsertests.wmflabs.org-linux-firefox build #65: SUCCESS in 7 min 52 sec: https://wmf.ci.cloudbees.com/job/UniversalLanguageSelector-language-browsertests.wmflabs.org-linux-firefox/65/ [10:01:42] Project UploadWizard-api-commons.wikimedia.org build #220: SUCCESS in 1 min 20 sec: https://wmf.ci.cloudbees.com/job/UploadWizard-api-commons.wikimedia.org/220/ [10:19:27] Zeljkof:Hi! thanks for the feedback..I needed some help from you to commit the new changes..I did a git pull origin master in my original branch of visual editor ..and then did git add and git commit --amend.. [10:21:20] But when i do git review I get a message :You are about to submit multiple commits. This is expected if you are [10:21:22] submitting a commit that is dependent on one or more in-review [10:21:24] commits. Otherwise you should consider squashing your changes into one [10:21:25] commit before submitting. [10:21:26] The outstanding commits are: [10:21:28] ←[33m3a2cb30←[m←[33m (←[1;36mHEAD←[m←[33m, ←[1;32mBug-63104←[m←[33m)←[m Merge b [10:21:29] anch 'master' of ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEd [10:21:31] tor into Bug-63104 [10:21:33] ←[33m66d8fc9←[m←[33m (←[1;32mmaster←[m←[33m)←[m Add missing VE core themes/apex [10:21:34] ve.ui.Inspector.css to .docs/eg-iframe.html [10:21:36] ←[33m68157a1←[m Merge "Bump jscs to 0.4.1" [10:21:37] ←[33m803a6af←[m Convert double quotes to single quotes in VisualEditor.php [10:21:38] ←[33mbf9f17d←[m Bump jscs to 0.4.1 [10:21:40] ←[33m7008501←[m Localisation updates from https://translatewiki.net. [10:21:41] ←[33m9e38caf←[m Remove constructive flag from return to save form button [10:21:43] ←[33m9c7c758←[m Localisation updates from https://translatewiki.net. [10:21:44] ←[33me9e8c02←[m WIP: Visual Editor adding long Target Links Bug: 63104 [10:21:46] Do you really want to submit the above commits? [10:21:47] Did I do anything wrong during commit.. [10:24:45] Jagori: can you please paste the output to a pad in etherpad? [10:25:04] it is hard to read here [10:25:08] for example http://etherpad.wikimedia.org/p/jagori [10:27:29] Zeljkof:Pasted the message there..Is it already shared ..or do I need to share it [10:53:48] hello zeljkof ! you free now ? [11:37:19] (03Abandoned) 10Zfilipin: WIP Passed Jenkins jobs have links to Sauce Labs jobs [qa/browsertests] - 10https://gerrit.wikimedia.org/r/110173 (owner: 10Zfilipin) [11:38:21] (03Abandoned) 10Zfilipin: WIP Passed Jenkins jobs have links to Sauce Labs jobs [selenium] - 10https://gerrit.wikimedia.org/r/110176 (owner: 10Zfilipin) [11:40:49] (03Draft2) 10Zfilipin: WIP $session_id requires that @browser is initialized [qa/browsertests] - 10https://gerrit.wikimedia.org/r/80967 [11:50:09] (03Abandoned) 10Zfilipin: WIP $session_id requires that @browser is initialized [qa/browsertests] - 10https://gerrit.wikimedia.org/r/80967 (owner: 10Zfilipin) [11:51:50] Zeljkof:Hi.are you available? [11:52:20] was wondering if git remote update would solve the problem [11:52:34] Jagori: I am here [11:52:46] git remote update will probably do nothing :) [11:52:52] :) ohh.. [11:52:57] can you paste your termilan output to the pad? [11:53:21] I did [11:53:26] were you able to view [11:53:37] looking [11:53:37] Do i have to share anything for you to view [11:53:47] no, pads are public [11:54:01] I am getting all unrelated commits.. [11:54:04] what did you do before that? [11:54:06] okay..thanks [11:54:12] I mean, before git review? [11:54:29] I first did a git pull origin master in my original branch [11:54:40] then I did a git add and git commit --amend [11:54:55] what do you mean by original branch? [11:55:05] in your topic branch? [11:55:20] From where I had committed my earlier code yes..Bug-31040..which i had created at my local [11:55:26] ok [11:55:30] so that was the mistake :) [11:55:34] :( [11:55:44] you should never do "git pull origin master" in your original branch [11:55:51] Ohh ..why [11:55:58] that pulled all commits from master branch to your topic branch [11:56:26] then what shud i have done? [11:56:29] the easiest thing would be do get the topic branch from gerrit again [11:56:42] and then do the changes to the commit one more time [11:56:45] bt that would create another branch then [11:56:55] you meant git review -d changeid [11:56:58] yes [11:57:00] try it [11:57:22] But am still not clear with the problem with what i did.. [11:57:32] you can delete that branch [11:57:41] or just ignore it :) [11:57:42] how do i upgrade my local with the master then [11:57:49] :) [11:58:00] you should checkout master branch "git checkout master" [11:58:08] and then, when you are in master branch [11:58:13] then "git pull origin master" [11:58:37] oh yes..that's what i did earlier you know..but then I thought that how would my branch have the files which are in master [11:59:00] I mean i was thinking that shudnt my branch too shud be in sync with master [11:59:07] apart from the file which i am working on [11:59:32] Zeljkof:I hope you got my question [12:00:29] (03Abandoned) 10Zfilipin: Fix failing tests on phantomjs [qa/browsertests] - 10https://gerrit.wikimedia.org/r/102634 (owner: 10Mayankmadan) [12:00:54] Jagori: I am not sure what you are asking [12:04:10] Zeljkof:What I meant was ..I synced my master branch by doing git pull origin master but does my bug-31040 branch too have the files which would be there in master or does it not matter.. [12:05:10] Jagori: no, your topic branch does not have to be up to date [12:05:32] I see.thats what I was confused of [12:05:34] :) [12:05:50] Thanks [12:06:00] no problem, git and gerrit tend to be confusing [12:06:04] it is easy to get lost [12:06:40] Thanks..sorry for asking too many questions on this [12:06:52] no problem [12:06:58] I was lost in the start too :) [12:07:03] :) [12:07:21] I really appreciate your patience [12:08:08] I am glad I could help [12:10:18] Jagori: I have just noticed that I did not review your other commit, will do it today [12:10:48] Which one the cucumber one [12:10:55] sorry i meant the preference one [12:10:58] merging preferences files [12:11:27] No issues..:) thanks [12:11:50] I have a backlog of commits to review, working on that today [12:12:57] Okay.. [12:13:30] Zeljkof:I did reply to your feedback too from gerrit..its a nice feature especially for code review purposes.. [12:13:48] comments in gerrit? [12:13:54] I hope you were able to view my responses [12:14:14] you had provided feedback to my cucumber code [12:14:29] and i had replied there..Did you not get it?? [12:15:18] Jagori: no [12:15:20] do not see them [12:15:30] when you comment, the comments are in draft mode [12:15:42] you have to click "reply" at the top of the commit [12:15:44] Yes..it was showing in draft [12:15:46] that will publish the commit [12:15:52] the comments [12:15:53] Uhhhh..:) [12:15:57] wait [12:16:08] yes, not the most intuitive thing to do [12:16:20] I checked the entire topic you know just to figure out how to remove the draft thing [12:16:24] :) [12:17:52] Zeljkof:Did you mean "Click to add file comment" [12:18:23] no, [12:18:25] here [12:18:26] https://gerrit.wikimedia.org/r/#/c/122400/ [12:18:39] there is "reply..." button at the top-midlle [12:19:04] when you click it, "send" button will appear [12:19:10] click that and comments will be published [12:19:15] a lot of steps, I know [12:19:34] :) [12:21:02] Zeljkof:But https://gerrit.wikimedia.org/r/#/c/122400/2//COMMIT_MSG in this URL if I paste some comments..would i again have to come to my parent issue [12:21:24] Jagori: yes [12:21:30] when you make all comments [12:21:34] on the files [12:21:40] go back to the parent commit [12:21:50] and then click "reply..." and then "send" [12:21:52] coz when am clicking Reply.. it shows me a blank textarea shud i leave it blank [12:21:59] :)Okay [12:22:11] Jagori: yes, if you have nothing to say about the commit itself, just leave it blank [12:22:16] and yes, it is confusing [12:22:32] now that I am explaining it, there are too much steps [12:22:40] :) [12:22:46] but it is like that right now [12:22:56] we will be probably changing tools soon [12:23:06] That's all right [12:23:07] so nobody is investing a lot in gerrit [12:23:09] no issues at all [12:23:53] Zeljkof:But if you could check once..what I did is it reflecting or not [12:24:23] Jagori: did you publish the comments? [12:24:25] let me see... [12:24:42] Zeljkof:How to publish them..:) [12:24:44] no [12:24:45] I didnot [12:24:51] "reply" then "send" [12:25:02] that will make your comments public [12:25:07] I did [12:25:11] until then, they are in draft mode, only you can see them [12:25:24] I replied from the parent issue ..left the textarea blank though and clicked Send [12:25:35] :) but I think the comments are still in draft mode [12:25:51] I can not see them [12:25:56] :( [12:26:10] and "history" part of this page should list your reply https://gerrit.wikimedia.org/r/#/c/122400/ [12:26:25] but the last thing is jenkins-bot [12:26:51] and this channel would be notified [12:26:55] wait, will show you [12:27:03] I am wondering why it didnt show [12:27:40] ok, this channel should not get notified, since that is VE repo [12:28:12] okay [12:28:57] But why is it still showing in draft mode:( [12:29:01] can you just go to that commit, click "reply", enter any text, and send the comments? [12:29:01] I just did that, my text was "testing replies", just to see if it works [12:29:04] would have to see [12:29:56] How come yours is showing not mine..Is it because I left the textarea blank [12:30:07] but then I have commented to all the feedbacks separately [12:30:50] Wait yes.. [12:31:39] yup it shows [12:31:47] works now? [12:32:01] I think probably then it's the individual comments which i had posted aren't showing [12:32:18] Jagori: hm, but I still do not see your comments, strange [12:32:40] a that's what it shows only the comment which I am making from the parent issue [12:33:01] and not the individual comments .. [12:35:08] yes, strange [12:35:11] not sure what is wrong [12:35:40] Ya..would have to look at it..meanwhile let me commit the new change atleast [12:41:48] Zeljkof:I have committed the file once more.. [12:42:26] you had mentioned regarding the commit message ,should I remove Visual Editor from there [12:42:36] yes [12:44:40] I think it is redundant, since the commit is in VE repo [12:48:14] Yes have changed it.. [12:49:21] Project UploadWizard-api-commons.wikimedia.beta.wmflabs.org build #261: SUCCESS in 1 min 37 sec: https://wmf.ci.cloudbees.com/job/UploadWizard-api-commons.wikimedia.beta.wmflabs.org/261/ [12:50:27] Zeljkof:Not able to figure out still why my individual feedbacks aren't showing ..they still show in draft mode [12:50:37] I know! :) [12:50:47] they are for a previous patch set! [12:51:36] let me see how to publish comments for a previous patch set [12:51:56] :) [12:52:20] Zeljkof:Another thing..which I actually wanted to know was I had confused Background with prerequisites [12:52:48] I thought that Background was actually likeprerequisites you have for in a testcase..that's why I had used Background [12:53:02] But now it's claer after your feedback [12:53:06] did you read the link I have provided? [12:53:06] *clear [12:53:47] which link? [12:53:56] I read all the feedbacks [12:54:04] did I provide link to cucumber backgrounds? [12:54:36] No..I think not [12:54:39] Jagori: oh, you still have the old gerrit interface, right? [12:54:51] no I have updated it [12:55:00] ok [12:55:09] this is cucumber background docs https://github.com/cucumber/cucumber/wiki/Background [12:55:31] Okay thanks [12:56:17] Project UploadWizard-api-commons.wikimedia.org build #221: SUCCESS in 1 min 33 sec: https://wmf.ci.cloudbees.com/job/UploadWizard-api-commons.wikimedia.org/221/ [12:57:03] Jagori: to get to an earlier patch set [12:57:13] click "revisions" on top-right [12:57:20] Ok [12:57:25] click the revision where you have made the comments [12:57:31] and then "reply > send" [12:57:33] try that [12:58:23] ok:)wait [13:00:44] Hey..i think this worked [13:00:46] :) [13:00:58] Zeljkof:Sorry..I think it should work [13:01:03] pls can you check once [13:02:28] Zeljkof:Thanks a lot..You are a wonderful mentor [13:02:32] :) [13:02:38] thanks :) [13:02:54] I can see the comments :) [13:03:11] hello zeljkof ! you free now ? [13:03:19] Zeljkof:I had just one more doubt..in the scenario outline and scenario.. [13:03:23] vikas: free as in free bird! :) [13:03:28] :) [13:04:03] zeljkof: free as in free from meetings :) [13:04:21] Zeljkof:what's the correct approach to write ..I mean can someone write in scenario: I type in text "xyz" or should it be mentioned under examples [13:04:45] vikas: yes, monday and wednesday are my no-meetings days [13:05:21] zeljkof: wow !! also do you have time to review ? [13:05:22] Jagori: cucumber is communication tool, and as with all communication tools, there is no right answer for every solution :) [13:05:37] :)Ok..got it [13:05:44] vikas: I am reviewing commits all day! :) [13:05:51] vikas: have one for me? [13:06:07] zeljkof: yes ! in visual editor => https://gerrit.wikimedia.org/r/#/c/121586/ [13:06:13] Zeljkof:thanks.. [13:06:19] logging out [13:06:28] zeljkof: I think I found a bug, I am not sure [13:06:36] Jagori: good night :) [13:06:36] Zeljkof:thanks for the help really [13:06:43] vikas: let me see... [13:06:43] goodnight:) [13:07:04] vikas: what is the bug? [13:08:12] zeljkof: when I used send_keys second time, and after that I linked it with old reference, The text appears again. [13:08:32] zeljkof: basically repetition of text [13:09:23] vikas: :) [13:09:36] I think you do not understand how the tool works [13:09:49] so, you have sent text twice to a textbox? [13:10:00] and you have expected the text to appear only once? [13:10:08] correct? [13:10:38] zeljkof: I sent it twice(not consecutive steps), but it comes thrice [13:10:53] I see [13:10:56] ok, let me check [13:11:01] just to finish another review first [13:11:13] ok :) [13:15:41] vikas: ok, looking at your commit [13:16:42] zeljkof: thank you :) [13:29:41] vikas: ok, the scenario is confusing to me [13:29:46] what is the scenario doing? [13:30:14] Reusing an existing reference [13:30:23] ok [13:30:29] let me step back [13:30:35] cucumber is a communication tool [13:30:56] so, if a test is reusing a reference, why isn't it clear from the scenario? :) [13:31:23] let me show you what I mean [13:31:26] ok [13:31:42] http://etherpad.wikimedia.org/p/vikas [13:33:17] zeljkof: yay that part. I agree I had plans of running it in background. But I was writing one more scenario which will be different from current one [13:35:07] Take a look at the pad [13:35:48] zeljkof: but there is no first reference initially, I have create that right ? [13:35:49] do you understand what I mean by cucumber is a communication tool now? [13:36:12] I see [13:36:23] ok, create it first [13:36:30] type into the pad [13:36:34] let me see what you mean [13:36:36] zeljkof: ok [13:37:00] let me know when you are ready, have to take a look at something else for a minute [13:37:20] zeljkof: ok [13:47:16] vikas: I have left a few comments in gerrit [13:48:55] zeljkof: I am done with etherpad [13:49:01]