[08:02:12] good morning [08:13:09] (03CR) 10Hashar: [C: 032] "Excellent!" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/124749 (owner: 10Yuvipanda) [08:13:24] (03CR) 10Hashar: [C: 032] "Deploying :-]" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/124748 (owner: 10Yuvipanda) [08:13:38] (03Merged) 10jenkins-bot: Add triggers for flake8 jobs for python scripts in wikipedia app [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/124748 (owner: 10Yuvipanda) [08:13:57] (03Merged) 10jenkins-bot: Add flake8 job for python scripts in Android app [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/124749 (owner: 10Yuvipanda) [08:41:18] morning [08:41:38] zeljkof: I am around if you need anything [08:41:47] hashar: morning [08:42:10] thanks, I have to finish some other more urgent stuff first :( [08:43:28] zeljkof: I might be able to help with the urgent stuff as well :-] [08:44:02] hashar: I need to review highly confidential code, you have to sign an NDA to see it :) [08:44:14] * hashar signs [08:44:14] (joking of course, about the NDA) [08:44:32] I got so many NDA pending even one from previous job :] [08:44:47] I think I have never signed one [08:45:04] oh really ? [08:45:17] I think it is mandatory whenever you get access on the cluster [08:45:18] I can not remember [08:45:33] I do not think I have access to any clusters :) [09:09:07] Zeljkof: Hi! just saw the feedback [09:09:21] Jagori: great [09:09:40] Jagori: I hope to have more time for reviewing other commits today [09:09:48] Zeljkof:Sorry just coulnot work on this for some days..wasnt well [09:09:54] No issues [09:10:46] Zeljkof:Just checked on one of the issues in patch 7 you had mentioned something related to whitespace [09:11:21] I thought the formatting wasnt proper..am sorry if I changed that and wasnt appropriate [09:11:42] (03PS1) 10Yuvipanda: Add java checklist job for Wikipedia Android app [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/124801 [09:11:45] (03CR) 10jenkins-bot: [V: 04-1] Add java checklist job for Wikipedia Android app [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/124801 (owner: 10Yuvipanda) [09:12:51] Jagori: no problem, you have just messed up some whitespace :) [09:13:05] probably rubymine did that, but you have to be careful when commiting [09:13:08] (03PS2) 10Yuvipanda: Add java checklist job for Wikipedia Android app [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/124801 [09:13:09] Ohh really,how am not sure..If you tell me [09:13:28] Zeljkof:Sorrywould keep in mind in future [09:15:08] Zeljkof:Which extra spaces did you speak of..? Ahh.. I didnt open Ruby Mine last few days..It's not opening [09:15:29] Zeljkof:Expired probably:( [09:16:34] (03PS1) 10Yuvipanda: Add Java checkstyle check for Wikipedia Android app [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/124802 [09:16:50] Zeljkof: Are there any other good editors ?Mine would expire in another 4 days [09:17:18] (03CR) 10jenkins-bot: [V: 04-1] Add Java checkstyle check for Wikipedia Android app [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/124802 (owner: 10Yuvipanda) [09:17:39] Jagori: there are a few [09:17:43] try this one [09:17:59] http://www.sublimetext.com/3 [09:18:07] okay [09:18:10] thanks:) [09:18:28] Am still confused with the spaces..it's indeed messed up [09:18:41] in some of the scenarios it's differently spaced [09:19:08] (03PS2) 10Yuvipanda: Add Java checkstyle check for Wikipedia Android app [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/124802 [09:20:13] Zeljkof:Its not free I think..trial version [09:20:26] Jagori: but the trial never ends :) [09:20:49] :) [09:20:57] :) [09:21:21] Jagori: You could also try http://brackets.io/ [09:21:41] Niharika:Thanks..sure:) [09:22:29] Niharika:this one's open source [09:22:43] Yes. [09:23:27] Niharika: I am not sure of the features,have you tried this ..should I then install this one [09:23:54] Jagori: It´s pretty cool. I have used this. :) [09:24:06] Niharika:Great..thanks for sharing:) [09:24:18] Jagori: :) [09:24:51] * zeljkof will be right back [09:35:44] Zeljkof:I am confused with the commit message actually..For each patch am submitting would I have to change the corresponding commit message.? [09:46:40] (03PS3) 10Yuvipanda: Add Java checkstyle check for Wikipedia Android app [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/124802 [09:54:37] (03CR) 10Hashar: [C: 04-1] Add Java checkstyle check for Wikipedia Android app (033 comments) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/124802 (owner: 10Yuvipanda) [09:55:34] (03PS3) 10Yuvipanda: Add java checklist job for Wikipedia Android app [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/124801 [09:56:44] (03PS4) 10Yuvipanda: Add Java checkstyle check for Wikipedia Android app [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/124802 [09:57:06] (03PS4) 10Yuvipanda: Add java checklist job for Wikipedia Android app [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/124801 [09:57:09] (03CR) 10Hashar: [C: 04-1] Add java checklist job for Wikipedia Android app (033 comments) [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/124801 (owner: 10Yuvipanda) [09:57:25] (03PS5) 10Yuvipanda: Add java checklist job for Wikipedia Android app [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/124801 [09:58:25] (03CR) 10Hashar: [C: 032] "Hurrah! Now get the job deployed :-]" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/124802 (owner: 10Yuvipanda) [09:59:11] (03CR) 10Hashar: [C: 032] Add java checklist job for Wikipedia Android app [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/124801 (owner: 10Yuvipanda) [09:59:51] (03Merged) 10jenkins-bot: Add Java checkstyle check for Wikipedia Android app [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/124802 (owner: 10Yuvipanda) [10:00:03] (03Merged) 10jenkins-bot: Add java checklist job for Wikipedia Android app [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/124801 (owner: 10Yuvipanda) [10:07:19] (03PS1) 10Yuvipanda: Look for checkstyle-results everywhere, not just root dir [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/124815 [10:07:37] hashar: ^ [10:07:46] hashar: I think it was looking for checkstyle results in root folder only [10:09:01] ah here you are :) [10:09:25] ah [10:09:28] yeah that might work [10:10:25] hashar: yeah, should. [10:10:30] I am not sure how the ant file patterns works fthough [10:10:31] hashar: and then I need to figure out the other maven issue :) [10:11:10] hashar: https://stackoverflow.com/questions/18722471/when-to-use-double-star-in-glob-syntax-within-java [10:11:58] trying [10:12:16] cause the checkstyle-xml macro is used on a bunch of other jobs [10:12:28] example: https://integration.wikimedia.org/ci/job/mwext-cldr-phpcs-strict-HEAD/ [10:12:45] Successfully parsed file /srv/ssd/jenkins-slave/workspace/mwext-cldr-phpcs-strict-HEAD/checkstyle-phpcs.xml [10:12:47] \O/ [10:13:08] with the double **? [10:13:44] (03PS2) 10Hashar: Look for checkstyle-results everywhere, not just root dir [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/124815 (owner: 10Yuvipanda) [10:14:22] saw update. COOL! [10:14:23] (03CR) 10Hashar: [C: 032] "Tested and it works fine. I am refreshing all the jobs." [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/124815 (owner: 10Yuvipanda) [10:14:47] apps-android-wikipedia-maven-checkstyle has been updated [10:14:51] you can retrigger it manually [10:14:59] head to http://integration.wikimedia.org/ci/job/apps-android-wikipedia-maven-checkstyle [10:15:05] login (top right) with your labs account [10:15:06] * yuvipanda goes [10:15:15] (03Merged) 10jenkins-bot: Look for checkstyle-results everywhere, not just root dir [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/124815 (owner: 10Yuvipanda) [10:15:20] then on the left browse to the build and then hit [Rebuild] [10:15:33] \O/ [10:15:41] sooo easy [10:17:09] poor jenkins is processing the check style report https://integration.wikimedia.org/ci/job/apps-android-wikipedia-maven-checkstyle/3/console [10:17:22] which ends up the build with some timeout bah [10:17:46] seems it is trying to access some remote URL :/ [10:18:22] hashar: yeah, that's toollabs. [10:18:29] hashar: for the maven artifacts. [10:18:41] hashar: I don't know why it is doing that for a simple checkstyle tho [10:18:51] hashar: also I still can't seem to accesss the file :( [10:19:06] ah [10:19:06] I can! [10:19:18] well [10:19:20] wonderful :) [10:19:25] lets bind that job to the Jenkins labs instance [10:19:49] hashar: hmm, so if I migrate that from toollabs to archiva.wikimedia.org it can run internally itself? [10:20:00] maybe :] [10:20:04] hehe [10:20:06] the job ran on lanthanum.eqiad.wmnet [10:20:10] which does not have direct access [10:20:16] it should use a web proxy [10:20:21] hmm, right. [10:20:42] hashar: well, checkstyle shouldn't be hitting anything other than maven central anyway, so I don't know why it is even attempting to do so [10:20:43] I will move the job to labsinstance [10:20:58] ok! [10:21:19] hashar: but gerrit will still get the reports, etc, right? [10:22:00] (03PS1) 10Hashar: Move maven checkstyle jobs to labs instance [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/124817 [10:22:44] hashar: also does $WORKSPACE refer to the checked out directory of the repo? [10:23:02] that is the jenkins workspace [10:23:18] you can see the whole path at the top of the console output https://integration.wikimedia.org/ci/job/apps-android-wikipedia-maven-checkstyle/4/console [10:23:21] 00:00:00.004 Building remotely on integration-slave1001 in workspace /mnt/jenkins-workspace/workspace/apps-android-wikipedia-maven-checkstyle [10:23:26] ie /mnt/jenkins-workspace/workspace/apps-android-wikipedia-maven-checkstyle [10:23:32] that is where your code is fetched out [10:23:51] hashar: so I want to pass a param to maven that is "CHECKOUT_DIR/checkstyle.xml" [10:23:55] how do I refer to $CHECKOUT_DIR? [10:24:01] $WORKSPACE [10:24:12] so $WORKSPACE/checkstyle.xml [10:24:14] but we have **/checkstyle-*.xml [10:24:20] so that doesn't seems to be needed [10:24:35] also whenever someone run the maven target, $WORKSPACE might not be defined and will end up to / [10:24:38] not a good idea :] [10:24:42] hashar: no, that is for the *result* [10:24:52] hashar: checkstyle.xml is for the coding standards. Similar to .jshintrc [10:25:28] (03CR) 10Hashar: [C: 032] "Deployed :-]" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/124817 (owner: 10Hashar) [10:25:36] ahhh [10:25:42] so yeah $WORKSPACE would do [10:25:46] but that is only for jenkins :] [10:25:51] ok :) [10:26:23] (03Merged) 10jenkins-bot: Move maven checkstyle jobs to labs instance [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/124817 (owner: 10Hashar) [10:28:02] (03PS1) 10Yuvipanda: Make maven checkstyle respect local checkstyle.xml [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/124818 [10:28:06] hashar: ^ [10:28:56] so labs instance times out as well https://integration.wikimedia.org/ci/job/apps-android-wikipedia-maven-checkstyle/4/console [10:28:57] :( [10:29:11] cause tools.wmflabs.org is not reachable from another labs instance hehe [10:29:33] aaaha! [10:29:34] dammit [10:29:43] dammit nova! :) [10:30:00] (03CR) 10Hashar: [C: 032] Make maven checkstyle respect local checkstyle.xml [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/124818 (owner: 10Yuvipanda) [10:30:12] hashar: let me deploy [10:30:31] deployed! [10:30:41] ahh [10:31:10] (03Merged) 10jenkins-bot: Make maven checkstyle respect local checkstyle.xml [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/124818 (owner: 10Yuvipanda) [10:32:07] so I know of an iptables hack that would point tools.wmflabs.org to the 10.0.0.0 instance IP [10:32:23] but that requires to redefined the whole security matrix for the jenkins slaves [10:32:55] right [10:33:04] cant we build the mediawiki api stuff with maven using the git repo ? [10:33:27] hashar: I could push it to maven central... [10:33:42] also we might want to have changes to the mediawiki/api project to run the wikipedia app to verify it works as well [10:33:44] hashar: I could also move it into the same repo, yeah. but we need an external repo for some external deps anyway (android libs) [10:34:00] hmm, no jenkins on https://gerrit.wikimedia.org/r/#/c/124812/ yet [10:34:19] it happened [10:34:23] https://integration.wikimedia.org/ci/job/apps-android-wikipedia-maven-checkstyle/5/console [10:34:41] ah, still running https://integration.wikimedia.org/ci/job/apps-android-wikipedia-maven-checkstyle/5/org.wikimedia$wikipedia/console [10:34:42] still choke on https://tools.wmflabs.org/android-maven-repo/org/mediawiki/api/json/1.0-SNAPSHOT/maven-metadata.xml :D [10:34:44] yeah [10:35:10] is that code you are writing ? [10:35:14] which gerrit repo is that? [10:35:21] hashar: android-maven-repo? [10:35:33] hashar: or org.mediawiki.api.json? [10:35:40] hashar: the latter is apps/android/java-mwapi [10:35:41] both ? [10:35:46] I am not sure what they are referring to hehe [10:35:58] android-maven-repo is just a bunch of JARs and POMs copied over to tool-labs [10:36:20] let me try move it to archiva [10:36:41] what we could potentially do [10:36:51] is have the wikipedia app to build the java-mwapi repo as well [10:37:14] and then have maven use that build instead of downloading from tools.wmflabs [10:37:17] hashar: I could just move the repo to archiva.wikimedia.org, and then this issue will 'go away' [10:37:24] hashar: since I think it can hit archiva.wikimedia.org [10:37:40] and we can get apps/android/java-mwapi to build the wikipedia app as well to make sure the java-mwapi doesn't break the wikipedia app [10:37:48] although I can't seem to reach https://archiva.wikimedia.org/ :| [10:37:55] yeah archiva.wikimedia.org would be reachable if it is not in labs :] [10:38:25] there is no https for it yet apparently :( [10:38:56] going to http://archiva.wikimedia.org redirects me [10:39:02] nice [10:39:19] hmm, nevermind [10:39:31] https everywhere ? :-D [10:39:52] hashar: must be a cahed thing. opening in incognito works [10:40:06] gotta ping ottomata to have https enabled [10:40:43] yeah [10:40:43] andddd you can get a maven job added for apps/android/java-mwapi :} [10:40:48] and to get me an account too [10:40:51] oh yeah, that too :) [10:40:57] ideally we would want the wikipedia app to build using the master branch of apps/android/java-mwapi [10:41:05] instead of the archiva version [10:41:12] or build it against both version [10:41:36] hashar: I could also just kill apps/android/java-mwapi as a repo and just move that into this [10:41:56] isn't it intended to be reusable by a lot of other projects? [10:42:26] ahhh [10:42:37] and maybe maven could be instructed to use a proxy [10:42:38] hmm [10:42:41] it is supposed to do it [10:42:43] hashar: it is, but nobody else is using it atm. [10:42:48] hashar: yeah, is there a proxy available? [10:43:02] I think I did that in the jenkins-slave user maven configuration [10:43:22] oh [10:43:39] hmm [10:44:15] the change was https://gerrit.wikimedia.org/r/#/c/114597/ [10:44:23] but it is not enabled on labs instance hehe [10:44:54] hashar: aah! [10:44:56] can it be? :) [10:49:18] fixing maven setting [10:51:26] https://gerrit.wikimedia.org/r/124822 [10:51:30] a bit crazy [10:51:39] don't waste your time on that change hehe [10:51:56] :) [10:52:05] I don't know enough about that puppet module anyway [10:52:42] it is a bunch of hack [10:52:47] the production and labs slaves slightly differ :( [10:53:02] the user running the jobs is different (jenkins-deploy vs jenkins-slave) [10:53:17] any specific reason? [10:53:22] and the home dir is different has well ( /mnt/home/jenkins-deploy vs /var/lib/jenkins-slave ) [10:53:38] I can't remember how I ended up with two different users :D [10:53:49] :D [10:54:04] the different home dir is that we want the jenkins user homedir to be on the labs instance extended disks (that used to be /dev/vdb on pmtpa) [10:54:13] so we mount the extended dir to /mnt/ [10:54:25] this way the maven cache (among other) is local to the instance [10:54:34] and did not hit GlusterFS [10:54:38] aaah, right [10:54:39] now it is not hitting NFS either [10:54:47] plus that isolate the hhomedir between instances [10:55:07] right. [10:55:13] rebuilding https://integration.wikimedia.org/ci/job/apps-android-wikipedia-maven-checkstyle/6/ [10:55:25] * hashar whistles [10:55:34] I never know if I am good at my job [10:55:54] or if keep creating new bugs that I fix later on and pretnted to be good at my job [10:55:57] I am sad [10:56:25] * yuvipanda gives hashar hugs :) [10:57:09] there is yet another exception brmgmglglglglglgl [10:57:36] it's the same one as before, and is unrelated to tools. [10:57:40] Could not find artifact org.wikimedia:wikipedia:apk:1.0-SNAPSHOT in tools-repository (https://tools.wmflabs.org/android-maven-repo/) -> [Help 1] [10:57:44] hmm, locally it seems to work fine. [10:58:00] hashar: that is because org.wikimedia:wikipedia:apk is what is built by the other pom file [10:58:08] so it is looking for it remotely when it shouldn't be [10:58:33] is that a bug in wikipedia app pom or in the jenkins job ? :D [10:59:01] it does work locally but let me use the exact command jenkins is using [11:05:13] hashar: ah, I see that issue locally too. so not a jenkins issue :) [11:05:19] ahhh [11:05:21] good to know [11:05:27] good luck configuring it out hehe [11:05:47] hashar: :) ty! [11:07:01] moving to some other pasturages let me know if you need anything [11:09:09] hashar: will do! Thanks for the help! [11:09:53] Jagori: depends [11:11:27] Zeljkof:Okay [11:12:20] Zeljkof:Have committed the same [11:12:33] Jagori: ok, will take a look [11:15:14] Zeljkof:No issues..Do let me know what to work upon next [11:15:30] Should i create step definitions file [11:19:21] Jagori: yes [11:19:26] do you know how to do that? [11:19:32] No:) [11:20:07] Zeljkof:If you could give me some ideas probably or should i look into the existing code [11:20:24] I am going thru the cucumber book too [11:20:34] great [11:20:41] the book will let you know what to do [11:20:45] ask if you get stuck [11:20:53] Sure.. [11:21:28] I will start on that.. then..would also have a look at the existing code [11:56:15] (03PS1) 10Yuvipanda: Fix Android Wikipedia app java checkstyles [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/124825 [11:56:21] hashar: ^ fixes most of the issues :) [11:56:41] hashar: I got it to run just checkstyle without needing to run other things, so it doesn't build anything. Just runs checkstyle [11:57:00] hashar: I have deployed it :) [11:57:34] hmm [11:57:45] checkstyle-xml: [11:57:45] pattern: "..." [11:57:47] I don't think that works [11:57:59] checkstyle-xml is a macro that probably does not have a pattern variable [11:58:25] yuvipanda: if you look at the diff https://integration.wikimedia.org/ci/job/integration-jjb-config-diff/97/console [11:58:35] the pattern parameter is not applied :] [11:58:43] hashar: oh, but it did kill an error :| [11:58:53] oh [11:59:38] just use check style there :) [12:00:06] hashar: hmm? [12:00:25] checkstyle-xml invokes checkstyle [12:00:31] with a bunch of non default parameters [12:00:44] aah [12:00:45] right [12:00:48] seems to be a workaround some jshintissue [12:00:49] yeah, let me just do that [12:01:01] (03CR) 10Hashar: Fix Android Wikipedia app java checkstyles (031 comment) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/124825 (owner: 10Yuvipanda) [12:03:20] (03PS2) 10Yuvipanda: Fix Android Wikipedia app java checkstyles [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/124825 [12:03:23] hashar: ^ [12:04:19] hmm, I should set them up [12:04:25] to fail for non zero errors [12:07:59] your call :-] [12:08:31] whenever you refresh the job with JJB, you can have a look at the job configuration in the web interface https://integration.wikimedia.org/ci/job/apps-android-wikipedia-maven-checkstyle/configure [12:08:47] that often helps refining the parameters [12:43:48] hashar: hmm, https://integration.wikimedia.org/ci/job/apps-android-wikipedia-maven-checkstyle/16/ says can't fetch from gerrit? [12:44:25] arf [12:44:29] !gerrit [12:44:31] !status [12:44:33] !status gerrit [12:44:50] ah yeah [12:44:56] stderr: fatal: remote error: access denied or repository not exported: /$ZUUL_PROJECT [12:45:01] ZUUL_PROJECT is not set :-] [12:45:03] h12:43:05 stderr: fatal: remote error: access denied or repository not exported: /$ZUUL_PROJECT [12:45:04] oh? [12:45:22] rebuild https://integration.wikimedia.org/ci/job/apps-android-wikipedia-maven-checkstyle/7/ [12:45:29] it is the last build triggered by Zuul [12:45:34] so it should have the proper parameters [12:45:42] ie https://integration.wikimedia.org/ci/job/apps-android-wikipedia-maven-checkstyle/7/parameters/? [12:45:48] ah, cool [12:45:53] i retriggered a build, works now [12:45:54] hopefuly [12:46:09] so Zuul pass to Jenkins a bunch of parameters for each jobs [12:46:18] one of them is the Gerrit project name which emitted the event [12:46:20] (03PS3) 10Yuvipanda: Fix Android Wikipedia app java checkstyles [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/124825 [12:46:22] hashar: right. So I tapped 'build' once which I guess messed things up [12:46:27] hashar: ^ is currently deployed :) [12:46:41] and the Jenkins jobs are made to fetch from something like git://zuul.eqiad.wmnet/git/$ZUUL_PROJECT [12:47:01] right [12:47:02] ah build pass! [12:47:07] indeed [12:47:10] Plug-in Result: Failed - 381 warnings of priority High Priority exceed the threshold of 1 by 380 [12:47:11] :D [12:47:15] hashar: yup! :) [12:47:21] hashar: but it's non-voting so all good [12:47:28] hashar: I'll try to make it voting by end of week [12:47:33] https://integration.wikimedia.org/ci/job/apps-android-wikipedia-maven-checkstyle/18/checkstyleResult/? [12:47:36] niceeeee [12:48:11] we can keep your JJB config patch open https://gerrit.wikimedia.org/r/#/c/124825/3/job-templates.yaml [12:48:15] while you refine the settings [12:49:02] or we can just merge and amend later hehe [12:49:40] yuvipanda: there are some steps skipped apparently [12:49:42] hashar: we should merge it :D The fixes need to happen in the code + checkstyle.xml in the code [12:49:43] in https://integration.wikimedia.org/ci/job/apps-android-wikipedia-maven-checkstyle/18/console [12:49:47] grep for SKIPPED [12:49:59] hashar: yes, it is skipping actually building them [12:50:02] and just running checkstyle instead [12:50:06] okk [12:50:28] so we can merge the maven-checkstyle job template right ? :] [12:50:46] ah wait [12:50:46] yep! :) [12:50:56] you also changed the goal [12:51:00] from checkstyle:checkstyle to checkstyle:checkstyle-aggregate [12:51:08] what is the difference ? [12:51:21] is the -aggregate one a well known target? [12:51:39] nitpicking because the template you created '{name}-maven-checkstyle' might end up being used by different projects [12:51:41] hashar: aggregate merges the two checkstyles on the children to just one file [12:51:45] which might thus miss the -aggregate target [12:51:48] hashar: ah, right. I think -aggregate is the one to use [12:52:27] hashar: https://maven.apache.org/plugins/maven-checkstyle-plugin/checkstyle-aggregate-mojo.html [12:52:30] \O/ [12:52:35] maven sounds amazing [12:52:42] so that is a standard command nice [12:52:45] hashar: it merges the individual checkstyle-result.xml into one big one which is what [12:52:57] and it would aggregate results of the wikipedia-it module right? [12:53:04] hashar: yup! [12:53:11] that sounds [12:53:15] good to me! [12:53:17] :-]]]]]]]]]]]]] [12:53:18] :D [12:53:38] if you know of other java repositories which might use some templates, poke their authors :-] [12:54:11] yeah, I will! [12:54:11] (03CR) 10Hashar: [C: 032] "Awesome Yuvi =)" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/124825 (owner: 10Yuvipanda) [12:54:14] -analytics is the guys :) [12:54:20] i'll poke them later [12:54:21] :D [12:54:24] I'll be off for a bit now [12:54:25] brb [12:54:30] hashar: thanks a lot :D [12:54:49] well [12:54:49] (03Merged) 10jenkins-bot: Fix Android Wikipedia app java checkstyles [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/124825 (owner: 10Yuvipanda) [12:54:51] you did all the work [12:55:01] and you did well :-] [14:02:28] hi zeljkof have you looked at the code we got from the QA Engineer candidate? [14:02:40] chrismcmahon: looking at it right now [14:02:53] did you try running it? [14:03:04] it does not work on my machine [14:03:21] I am debugging it now, trying to get it to work [14:04:55] aha [14:04:58] missing closing brackets :) [14:05:00] for me it parses (it has no errors when it runs) but I see no place where it could produce output or e.g. point to a target wiki [14:07:13] maybe I'm not reading it correctly [14:08:11] chrismcmahon: really? it runs on your machine? [14:08:46] $ ruby wiki.rb [14:08:46] cmcmahon@ubuntu:~/lib/wikimedia$ [14:08:56] that's what it does (or doesn't do) [14:08:59] line 10 of test_wiki_site_for_localization_tokens.rb has missing closing parentheses [14:09:05] no, you should run test_wiki_site_for_localization_tokens.rb [14:09:13] zeljkof: ?? I don' t have that file even [14:09:13] that is what the readme says [14:09:19] wait [14:09:21] or a README [14:09:23] it is in the root [14:09:40] where did you get the repo from? email from emily? [14:09:51] yes [14:10:00] this looks incomplete [14:10:16]