[00:48:06] Project UploadWizard-api-commons.wikimedia.beta.wmflabs.org build #4: SUCCESS in 23 sec: https://integration.wikimedia.org/ci/job/UploadWizard-api-commons.wikimedia.beta.wmflabs.org/4/ [00:55:04] Project UploadWizard-api-commons.wikimedia.org build #3: STILL FAILING in 20 sec: https://integration.wikimedia.org/ci/job/UploadWizard-api-commons.wikimedia.org/3/ [03:06:51] Project browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-linux-firefox build #4: STILL FAILING in 7.5 sec: https://integration.wikimedia.org/ci/job/browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-linux-firefox/4/ [03:06:52] * Gergő Tisza: Skip userinfo request if no message depends on the gender. [03:06:52] * l10n-bot: Localisation updates from https://translatewiki.net. [03:06:53] * Gergő Tisza: Make License.isCc() really return booleans [03:08:35] Project browsertests-UniversalLanguageSelector-sandbox.translatewiki.net-linux-firefox build #13: SUCCESS in 51 sec: https://integration.wikimedia.org/ci/job/browsertests-UniversalLanguageSelector-sandbox.translatewiki.net-linux-firefox/13/ [03:13:05] Project browsertests-MobileFrontend-en.m.wikipedia.org-linux-firefox build #3: STILL FAILING in 5 min 20 sec: https://integration.wikimedia.org/ci/job/browsertests-MobileFrontend-en.m.wikipedia.org-linux-firefox/3/ [03:13:05] * maxsem.wiki: Fix fatal in Special:MobileLanguages [03:13:06] * maxsem.wiki: Fix check for empty title [03:13:06] * jrobson: Pass undo message to JavaScript [03:13:06] * l10n-bot: Localisation updates from https://translatewiki.net. [03:13:07] * jdlrobson: Stop special-casing history views in shouldDisplayMobileView() [03:13:07] * maxsem.wiki: Hygiene: Fix tests isolation [03:13:08] * jgonera: Story 1904: Filters to reduce copyvios on mobile [03:21:36] Project browsertests-TwnMainPage-sandbox.translatewiki.net-linux-firefox build #16: STILL FAILING in 5 min 52 sec: https://integration.wikimedia.org/ci/job/browsertests-TwnMainPage-sandbox.translatewiki.net-linux-firefox/16/ [03:27:44] Project browsertests-ZeroRatedMobileAccess-en.m.wikipedia.org-linux-phantomjs build #6: STILL FAILING in 1 sec: https://integration.wikimedia.org/ci/job/browsertests-ZeroRatedMobileAccess-en.m.wikipedia.org-linux-phantomjs/6/ [03:28:46] Project browsertests-UniversalLanguageSelector-commons.wikimedia.beta.wmflabs.org-linux-firefox build #15: STILL FAILING in 9 min 2 sec: https://integration.wikimedia.org/ci/job/browsertests-UniversalLanguageSelector-commons.wikimedia.beta.wmflabs.org-linux-firefox/15/ [03:30:11] Project browsertests-UniversalLanguageSelector-language-browsertests.wmflabs.org-linux-firefox build #3: STILL FAILING in 1 min 27 sec: https://integration.wikimedia.org/ci/job/browsertests-UniversalLanguageSelector-language-browsertests.wmflabs.org-linux-firefox/3/ [03:30:11] Project browsertests-VisualEditor-test2.wikipedia.org-linux-firefox build #3: STILL FAILING in 17 min: https://integration.wikimedia.org/ci/job/browsertests-VisualEditor-test2.wikipedia.org-linux-firefox/3/ [03:30:12] * roan.kattouw: [Browser tests] Move "I can click the X on the save box" to shared_steps.rb [03:30:12] * roan.kattouw: [Browser tests] Fix typo in file name [03:30:13] * jforrester: [Browser tests] Do not display link to Sauce Labs when using local browser [03:30:13] * krenair: Check cascade protection and show notice if relevant [03:30:14] * krenair: Hide some tools when VE is open [03:30:14] * jforrester: Update jquery.uls from 601a5256b8 To 1932de9e347d [03:30:15] * jforrester: Update VE core submodule to master (6daeb19) [03:30:15] * roan.kattouw: Unbreak badtoken recovery on mobile [03:30:16] * krenair: Apply PST when generating diff [03:30:16] * l10n-bot: Localisation updates from https://translatewiki.net. [03:30:17] * krenair: Add support for SimpleCaptcha [03:30:17] * trevorparscal: Make citation dialog display like transclusion dialog in single mode [03:30:18] * roan.kattouw: Update VE core submodule to master (71f0151) [03:30:18] * jforrester: Enable the language tool as a Beta Feature [03:30:19] * catrope: Add AnnotationAction.test.js [03:30:19] * esanders: Fix docs in ve.ui.MWParameterSearchWidget.js [03:32:14] Project browsertests-en.wikipedia.beta.wmflabs.org-linux-firefox build #3: STILL FAILING in 10 min: https://integration.wikimedia.org/ci/job/browsertests-en.wikipedia.beta.wmflabs.org-linux-firefox/3/ [03:33:44] Project browsertests-VisualEditor-en.wikipedia.beta.wmflabs.org-linux-firefox build #25: STILL FAILING in 20 min: https://integration.wikimedia.org/ci/job/browsertests-VisualEditor-en.wikipedia.beta.wmflabs.org-linux-firefox/25/ [03:33:45] * krenair: Hide some tools when VE is open [03:33:46] * jforrester: Update VE core submodule to master (6daeb19) [03:33:46] * krenair: Add support for SimpleCaptcha [03:33:47] * trevorparscal: Make citation dialog display like transclusion dialog in single mode [03:33:47] * roan.kattouw: Update VE core submodule to master (71f0151) [03:33:48] * jforrester: Enable the language tool as a Beta Feature [03:33:48] * catrope: Add AnnotationAction.test.js [03:33:49] * esanders: Fix docs in ve.ui.MWParameterSearchWidget.js [03:33:49] * jforrester: Update VE core submodule to master (6ad2355) [03:33:50] * jforrester: Use core language search dialog [03:35:14] Project browsertests-ContentTranslation-language-stage.wmflabs.org-linux-firefox build #3: STILL FAILING in 5 min 31 sec: https://integration.wikimedia.org/ci/job/browsertests-ContentTranslation-language-stage.wmflabs.org-linux-firefox/3/ [03:35:15] l10n-bot: Localisation updates from https://translatewiki.net. [03:35:51] Project browsertests-Flow-test2.wikipedia.org-linux-firefox build #3: STILL FAILING in 7.5 sec: https://integration.wikimedia.org/ci/job/browsertests-Flow-test2.wikipedia.org-linux-firefox/3/ [03:35:51] l10n-bot: Localisation updates from https://translatewiki.net. [03:38:24] Yippee, build fixed! [03:38:24] Project browsertests-CirrusSearch-test2.wikipedia.org-linux-firefox build #16: FIXED in 40 sec: https://integration.wikimedia.org/ci/job/browsertests-CirrusSearch-test2.wikipedia.org-linux-firefox/16/ [03:38:25] l10n-bot: Localisation updates from https://translatewiki.net. [03:42:48] Project browsertests-CentralAuth-test2.wikipedia.org-linux-firefox build #3: STILL FAILING in 4.6 sec: https://integration.wikimedia.org/ci/job/browsertests-CentralAuth-test2.wikipedia.org-linux-firefox/3/ [03:42:48] * umherirrender: window.localStorage can be null in IE11 [03:42:49] * l10n-bot: Localisation updates from https://translatewiki.net. [03:43:51] Project browsertests-Flow-en.wikipedia.beta.wmflabs.org-linux-firefox build #4: STILL FAILING in 7.2 sec: https://integration.wikimedia.org/ci/job/browsertests-Flow-en.wikipedia.beta.wmflabs.org-linux-firefox/4/ [03:43:51] l10n-bot: Localisation updates from https://translatewiki.net. [03:47:23] Project browsertests-MobileFrontend-test2.m.wikipedia.org-linux-firefox build #3: STILL FAILING in 23 min: https://integration.wikimedia.org/ci/job/browsertests-MobileFrontend-test2.m.wikipedia.org-linux-firefox/3/ [03:47:24] * maxsem.wiki: Fix fatal in Special:MobileLanguages [03:47:24] * maxsem.wiki: Fix check for empty title [03:47:25] * jrobson: Pass undo message to JavaScript [03:47:25] * l10n-bot: Localisation updates from https://translatewiki.net. [03:47:25] * jdlrobson: Stop special-casing history views in shouldDisplayMobileView() [03:47:26] * maxsem.wiki: Hygiene: Fix tests isolation [03:47:27] * jgonera: Story 1904: Filters to reduce copyvios on mobile [03:51:02] Project browsertests-Translate-meta.wikimedia.org-linux-firefox build #14: SUCCESS in 1 min 18 sec: https://integration.wikimedia.org/ci/job/browsertests-Translate-meta.wikimedia.org-linux-firefox/14/ [03:51:02] l10n-bot: Localisation updates from https://translatewiki.net. [03:52:02] Project browsertests-Translate-sandbox.translatewiki.net-linux-firefox build #14: STILL FAILING in 19 min: https://integration.wikimedia.org/ci/job/browsertests-Translate-sandbox.translatewiki.net-linux-firefox/14/ [03:52:02] l10n-bot: Localisation updates from https://translatewiki.net. [03:54:18] Yippee, build fixed! [03:54:18] Project browsertests-CirrusSearch-en.wikipedia.beta.wmflabs.org-linux-firefox build #16: FIXED in 34 sec: https://integration.wikimedia.org/ci/job/browsertests-CirrusSearch-en.wikipedia.beta.wmflabs.org-linux-firefox/16/ [03:54:19] l10n-bot: Localisation updates from https://translatewiki.net. [03:54:49] Project browsertests-UploadWizard-commons.wikimedia.beta.wmflabs.org-linux-firefox build #3: STILL FAILING in 6.1 sec: https://integration.wikimedia.org/ci/job/browsertests-UploadWizard-commons.wikimedia.beta.wmflabs.org-linux-firefox/3/ [04:04:19] Project browsertests-test2.wikipedia.org-linux-firefox build #3: STILL FAILING in 5 min 35 sec: https://integration.wikimedia.org/ci/job/browsertests-test2.wikipedia.org-linux-firefox/3/ [04:32:12] Project browsertests-MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox build #3: STILL FAILING in 40 min: https://integration.wikimedia.org/ci/job/browsertests-MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox/3/ [04:32:13] * maxsem.wiki: Fix check for empty title [04:32:13] * jrobson: Pass undo message to JavaScript [04:32:14] * l10n-bot: Localisation updates from https://translatewiki.net. [04:32:14] * jdlrobson: Stop special-casing history views in shouldDisplayMobileView() [04:32:15] * maxsem.wiki: Hygiene: Fix tests isolation [04:32:15] * jgonera: Story 1904: Filters to reduce copyvios on mobile [06:48:07] Project UploadWizard-api-commons.wikimedia.beta.wmflabs.org build #5: SUCCESS in 23 sec: https://integration.wikimedia.org/ci/job/UploadWizard-api-commons.wikimedia.beta.wmflabs.org/5/ [06:55:03] Project UploadWizard-api-commons.wikimedia.org build #4: STILL FAILING in 19 sec: https://integration.wikimedia.org/ci/job/UploadWizard-api-commons.wikimedia.org/4/ [08:09:46] (03PS2) 10Hashar: Use YAML anchors and alias to maintain emails lists [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/129200 [08:10:32] (03CR) 10Hashar: "Added Niklas to the /browsertests-ContentTranslation-language-stage.wmflabs.org-linux-firefox job by using the emails-ULS alias." [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/129200 (owner: 10Hashar) [08:26:43] 3Wikimedia / 3Continuous integration: VisualEditor-doc-publish jobs are failing - 10https://bugzilla.wikimedia.org/64352 (10Niklas Laxström) 3NEW p:3Unprio s:3normal a:3None See for example https://integration.wikimedia.org/ci/job/mwext-VisualEditor-doc-publish/2336/console from https://gerrit.wikime... [10:17:57] (03CR) 10Zfilipin: [C: 032] Use YAML anchors and alias to maintain emails lists [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/129200 (owner: 10Hashar) [10:18:22] (03Merged) 10jenkins-bot: Use YAML anchors and alias to maintain emails lists [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/129200 (owner: 10Hashar) [12:09:32] re [12:14:12] 3Wikimedia / 3Continuous integration: VisualEditor-doc-publish jobs are failing - 10https://bugzilla.wikimedia.org/64352#c1 (10Antoine "hashar" Musso) a:3Antoine "hashar" Musso Caused by https://gerrit.wikimedia.org/r/#/c/125546/2/mediawiki-extensions.yaml,unified which uses a a dest dir: $$WORKSPACE/docs... [12:14:21] (03CR) 10Hashar: "$$WORKSPACE is not going to work. Causes bug https://bugzilla.wikimedia.org/show_bug.cgi?id=64352" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/125546 (owner: 10Jforrester) [12:16:13] (03PS1) 10Hashar: Revert "mwext-VisualEditor-doc-publish: Simplify rsync calls" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/129401 [12:16:17] (03PS2) 10Hashar: Revert "mwext-VisualEditor-doc-publish: Simplify rsync calls" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/129401 [12:16:28] (03PS3) 10Hashar: Revert "mwext-VisualEditor-doc-publish: Simplify rsync calls" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/129401 [12:16:41] 3Wikimedia / 3Continuous integration: VisualEditor-doc-publish jobs are failing - 10https://bugzilla.wikimedia.org/64352#c2 (10Gerrit Notification Bot) Change 129401 had a related patch set uploaded by Hashar: Revert "mwext-VisualEditor-doc-publish: Simplify rsync calls" https://gerrit.wikimedia.org/r/129401 [12:21:15] (03CR) 10Hashar: [C: 032] "Job managed to pass https://integration.wikimedia.org/ci/job/mwext-VisualEditor-doc-publish/2337/console" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/129401 (owner: 10Hashar) [12:21:37] (03Merged) 10jenkins-bot: Revert "mwext-VisualEditor-doc-publish: Simplify rsync calls" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/129401 (owner: 10Hashar) [12:21:56] 3Wikimedia / 3Continuous integration: VisualEditor-doc-publish jobs are failing - 10https://bugzilla.wikimedia.org/64352#c3 (10Gerrit Notification Bot) Change 129401 merged by jenkins-bot: Revert "mwext-VisualEditor-doc-publish: Simplify rsync calls" https://gerrit.wikimedia.org/r/129401 [12:22:11] 3Wikimedia / 3Continuous integration: VisualEditor-doc-publish jobs are failing - 10https://bugzilla.wikimedia.org/64352#c4 (10Antoine "hashar" Musso) 5PAT>3RES/FIX Job is now passing: https://integration.wikimedia.org/ci/job/mwext-VisualEditor-doc-publish/2337/console [12:48:06] Project UploadWizard-api-commons.wikimedia.beta.wmflabs.org build #6: SUCCESS in 22 sec: https://integration.wikimedia.org/ci/job/UploadWizard-api-commons.wikimedia.beta.wmflabs.org/6/ [12:55:04] Project UploadWizard-api-commons.wikimedia.org build #5: STILL FAILING in 20 sec: https://integration.wikimedia.org/ci/job/UploadWizard-api-commons.wikimedia.org/5/ [13:45:16] zeljkof: :] [13:45:31] hashar: what's up? :) [13:46:02] gi11es: your multimedia browser tests would need a @firefox tag :-D [13:46:02] https://www.mediawiki.org/wiki/Manual:Coding_conventions/Selenium#Required_tags Zeljkof replied to your email [13:46:14] zeljkof: not much [13:46:16] hi zeljkof and hashar how's it going with Jenkins? I notice a funny thing with the VisualEditor builds: no failures on one build, then 17 failures, then 1 failure, then 22 failures (basically all the tests fail) [13:46:19] why does it need one? doesn't work on phantom? [13:46:26] gi11es: no clue [13:46:34] maybe we can switch it to phantomjs [13:47:17] chrismcmahon: no clue :/ [13:48:20] chrismcmahon: there is a bunch of "could not find text node matching: This is a new line (Selenium::WebDriver::Error::JavascriptError)" [13:48:32] gi11es: I will create a phantomjs job and see what happens [13:48:45] Unable to pick a platform for the provided browser (RuntimeError) at least once [13:48:52] it's alright I can mark as firefox, I've been working with the firefox driver locally [13:49:04] https://integration.wikimedia.org/ci/job/browsertests-VisualEditor-en.wikipedia.beta.wmflabs.org-linux-firefox/25/testReport/junit/(root)/VisualEditor%20general%20text%20markup%20features/VisualEditor_general_markup__outline_example_____Computer_Code____code_This_is_a_new_line__code____/ [13:49:17] we shouldn't be getting those in individual tests [13:50:37] gi11es: feel free to mark them with both tags (firefox and phantomjs [13:50:54] tag added to that changeset: https://gerrit.wikimedia.org/r/#/c/127477/ in case you missed my update chrismcmahon the issue you ran into with the chrome driver is actually a Media Viewer bug in chrome (with a fix pending review) [13:53:21] gi11es: I saw that, thanks [13:54:00] a small race condition or timing thing as I understand [13:54:40] difference in browser behavior, chrome seems to reset the window scroll after popstate handlers have run [13:54:56] we were restoring it during one handler [13:54:59] browsers are bizarre [13:56:26] with the chrome driver being so much faster, why aren't we using that on the new jenkins runner? [13:57:07] gi11es: still working out issues with the builds themselves. that's coming soon I think. [13:58:10] gi11es: also putting diagnostics in place like screenshots, etc. I don't know what exactly hashar and zeljkof do overnight :-) but there are a lot of details [13:58:35] totally unrelated, for our mutant performance test I'm going to start fitlering the eventlogging stats based on useragent, because I only wanted the results from cloudbees graphed, not local runs happening development. would be great if there's a way to customize the user agent for the runner of a given test [13:58:51] *during development [13:58:51] well I am mostly a browser test newbie :] [13:58:58] I am merely Jenkins assistant to Zeljkof hehe [13:59:17] gi11es: we actually have a custom useragent in one of the MobileFrontend tests [13:59:25] nice! I'll check that out [14:00:03] gi11es: are you in San Francisco? [14:00:13] no, I am geographically challenged [14:00:33] gi11es: where exactly? (we're all over the place also) [14:00:41] CET timezone, south of france [14:01:28] gi11es: both hashar and I are in that time zone, he is even _in_ France [14:01:45] I know [14:01:53] (03PS1) 10Hashar: Rename default to 'browsertest' [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/129420 [14:01:56] (03PS1) 10Hashar: Rename build 'default' to 'browsertest-website' [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/129421 [14:02:18] zeljkof: and gilles is in the same TZ as us :-]  So if need be we can probably pair altogether (you will have to learn french though) [14:02:56] hashar: you would hear a lot of "Pardon my French" from me :) [14:03:29] zeljkof: can we setup a chrome job for MultimediaViewer ? [14:03:39] hashar: sure [14:03:49] if the firefox/phantomjs are running fine, why not [14:04:00] or is only chrome needed? [14:04:38] Ubuntu Precise has version 33.0.1650.152 (no idea what it is) [14:05:17] is it chrome, or chromium? [14:05:22] chromium [14:05:54] and it is installed on the slaves [14:06:13] hashar: I will have to modify the gem to point to chromium instead of chrome [14:06:23] chrismcmahon: I've looked at the config of all the MobileFrontend tests and couldn't find the custom user agent string, is it defined in the tests' source code? [14:06:24] or we could use sauce labs to drive chrome [14:06:33] zeljkof: or make it an alias? [14:06:42] gi11es: let me check [14:08:39] hashar: even better [14:08:56] the point is that selenium by default tries to run chrome [14:09:34] so if you could create alias that would be in a place where chrome is usually and if it pointed to chromium, then that is all that needs to happen [14:09:51] we could then just pretend to drive chrome [14:11:20] gi11es: look a no_javascript_site.feature and 'I am using user agent...' in common_steps.rb in the MF repo [14:11:27] thanks [14:11:38] gi11es: also, that bug got fixed, I need to update the comment [14:11:46] (this is why we don't have comments) [14:15:19] mmm, I've just realized this won't really solve my problem, because I want to tell apart local runs and jenkins runs [14:15:44] if I add that in the source code and run against mediawiki.org while developing, I'll hit EventLogging with that user agent too [14:16:05] I'll need to set it to an env variable [14:16:28] I imagine those are easy to read from ruby, I imagine that's how you made the ones we define in config work? [14:20:14] gi11es: yes, just string interpolation, we do stuff like page.login_with(ENV["MEDIAWIKI_USER"], ENV["MEDIAWIKI_PASSWORD"]) all over [14:21:08] zeljkof: [14:21:17] zeljkof: mind reviewing the two tiny changes I made to the cloud bees branch ? [14:21:24] hashar: sure [14:21:30] did you push them to gerrit? [14:21:34] https://gerrit.wikimedia.org/r/#/q/status:open+project:integration/jenkins-job-builder-config+branch:cloudbees,n,z [14:21:35] yeah [14:21:50] basically renaming 'default' occurrences to something more meaningful [14:21:59] hashar: :) [14:22:16] the diffs don't output anything, so they are noop [14:22:48] I will send a few more [14:23:16] (03CR) 10Zfilipin: [C: 032] Rename build 'default' to 'browsertest-website' [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/129421 (owner: 10Hashar) [14:24:11] (03CR) 10Zfilipin: [C: 032] Rename default to 'browsertest' [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/129420 (owner: 10Hashar) [14:24:26] hashar: +2d both commits [14:24:30] ping me when you have more [14:24:56] (03Merged) 10jenkins-bot: Rename default to 'browsertest' [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/129420 (owner: 10Hashar) [14:24:59] (03Merged) 10jenkins-bot: Rename build 'default' to 'browsertest-website' [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/129421 (owner: 10Hashar) [14:32:11] zeljkof: is the VERSION really needed ? [14:32:24] hashar: yes, for sauce labs [14:32:35] it should be BROWSER_VERSION [14:32:38] so we should probably rename the jobs [14:32:46] hashar: how? [14:32:49] to use something like: linux-firefox-27 linux-firefox-3.6 etc [14:33:08] not sure :] [14:33:19] hashar: we usually only run on one version of ff [14:33:24] or any other browser [14:33:32] 27 for ff at the moment, I think [14:33:40] so when we upgrade, we just upgrade [14:33:42] so I guess we can set the version based on the browser [14:33:52] and we do not have to rename jobs [14:34:02] yeah make sense [14:34:02] hashar: what do you mean? [14:34:25] let me push [14:34:27] (03PS1) 10Hashar: Make the job template to vary by browser [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/129429 [14:34:42] that change above change the template name: [14:34:42] - name: 'browsertests-{name}' [14:34:42] + name: 'browsertests-{name}-{browser}' [14:34:51] so for each projects we will be able to do something like: [14:34:58] browser: [14:34:58] - firefox [14:34:58] - chrome [14:36:01] can do some if else :-] [14:40:12] hashar: how would we generate a job for ff 27 and chrome 33? [14:40:30] got another patch for that :] [14:40:50] ok, merging this one then [14:41:31] basically dropping version: entirely [14:41:40] and use a case "$BROWSER" to set the version [14:41:42] ie [14:41:46] if we get firefox -> version=27 [14:41:48] and so on [14:42:43] hashar: makes sense [14:42:57] we do not really need to set the version separately [14:43:26] (03CR) 10Zfilipin: [C: 032] Make the job template to vary by browser [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/129429 (owner: 10Hashar) [14:43:30] (03PS1) 10Hashar: Drop version parameter entirely [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/129436 [14:43:32] and there [14:43:33] untested [14:43:49] probably want to use that patchset 129436, reconfigure one of the job and see if it works fine [14:44:37] I need to flee [14:44:47] I would like to had the '{hostname}' in the job template next [14:45:06] so we can define several jobs having different hostnames based on a single project definition [14:45:19] hashar: sounds good [14:45:25] same for the operating system [14:45:49] err platform [14:45:56] well you can do it if you want :] [14:46:00] that is the same as https://gerrit.wikimedia.org/r/#/c/129429/ [14:46:09] i.e. add {platform} in the job template name, fix up all the occurences [14:46:11] hashar: in the middle of something else at the moment [14:46:21] and since the projects have platform: something, that will be passed to the job template [14:46:24] yeah yeha :] [14:46:35] I am off, gotta fix my bike. Will be back this evening to continue [14:46:40] else we can pair tomorrow morning [14:46:45] hashar: see you later or tomorrow [14:46:49] \O/ [15:28:50] (03CR) 10Zfilipin: "recheck" [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/129436 (owner: 10Hashar) [15:46:23] (03Merged) 10jenkins-bot: Make the job template to vary by browser [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/129429 (owner: 10Hashar) [16:13:39] hashar: can we upgrade phantomjs on jenkins slaves? [16:14:31] I think zero job is failing because the feature we need is not in an old version of phantomjs https://integration.wikimedia.org/ci/view/BrowserTests/job/browsertests-ZeroRatedMobileAccess-en.m.wikipedia.org-linux-phantomjs/ [16:15:59] 3Wikimedia / 3Continuous integration: Update CodeSniffer rules automatically on machines running tests - 10https://bugzilla.wikimedia.org/64371 (10Siebrand Mazeland) 3NEW p:3Unprio s:3normal a:3None Gerrit 127863 was merged 48 hours ago, but the test runners are still using an older rule set, as is c... [16:19:53] zeljkof: baaah that is lame [16:20:06] zeljkof: we need to upgrade the phantomjs package so [16:20:35] 1.9.0-1 0 1001 http://apt.wikimedia.org/wikimedia/ precise-wikimedia/universe amd64 Packages [16:20:35] 1.4.0+dfsg-1 0 500 http://ubuntu.wikimedia.org/ubuntu/ precise/universe amd64 Packages [16:20:40] i.e. we get 1.9.0-1 [16:21:47] the package is out of date :-( http://packages.qa.debian.org/p/phantomjs.html [16:23:15] zeljkof: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=732376 :D [16:23:20] I guess we should use some other way [16:23:22] maybe via npm [17:06:13] 3Wikimedia / 3Continuous integration: Get JSDuck on MobileFrontend jenkins build - 10https://bugzilla.wikimedia.org/64374 (10Jon) 3NEW p:3Unprio s:3normal a:3None MobileFrontend is now using JSDuck. We would like it to run via Jenkins on all patches but for the time being we want it to be non-voting... [17:18:11] 3Wikimedia / 3Continuous integration: Jenkins: Set up jsduck test and publish jsduck for MobileFrontend - 10https://bugzilla.wikimedia.org/64374 (10Krinkle) [17:18:12] 3Wikimedia / 3Continuous integration: Jenkins: Set up jsduck test and publish jobs for MobileFrontend - 10https://bugzilla.wikimedia.org/64374 (10Krinkle) [18:06:16] Project browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-linux-firefox build #5: STILL FAILING in 11 sec: https://integration.wikimedia.org/ci/job/browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-linux-firefox/5/ [18:08:01] Project browsertests-UniversalLanguageSelector-sandbox.translatewiki.net-linux-firefox build #14: SUCCESS in 57 sec: https://integration.wikimedia.org/ci/job/browsertests-UniversalLanguageSelector-sandbox.translatewiki.net-linux-firefox/14/ [18:09:22] chrismcmahon: Flow browser tests will always be flakey while bug 64082 (edit existing feature) is outstanding. Where are the @flags documented so we can disable it in automated tests? [18:12:13] Project browsertests-MobileFrontend-en.m.wikipedia.org-linux-firefox build #4: STILL FAILING in 5 min 8 sec: https://integration.wikimedia.org/ci/job/browsertests-MobileFrontend-en.m.wikipedia.org-linux-firefox/4/ [18:12:13] * maxsem.wiki: Hygiene: remove deadbeef, fix returns [18:12:13] * cmcmahon: QA: comment is obsolete, bug is fixed, tag is added [18:13:39] spagewmf: I'll flip it or fix it [18:14:58] chrismcmahon: it's hard to fix, maybe we can chat about it after this meeting. Either need complicated xpath selector or target a particular post. [18:15:44] spagewmf: OK, looking right now [18:21:10] Project browsertests-TwnMainPage-sandbox.translatewiki.net-linux-firefox build #17: STILL FAILING in 6 min 5 sec: https://integration.wikimedia.org/ci/job/browsertests-TwnMainPage-sandbox.translatewiki.net-linux-firefox/17/ [18:25:33] Project browsertests-VisualEditor-test2.wikipedia.org-linux-firefox build #4: STILL FAILING in 13 min: https://integration.wikimedia.org/ci/job/browsertests-VisualEditor-test2.wikipedia.org-linux-firefox/4/ [18:25:34] jforrester: Update VE core submodule to master (d21c272) [18:26:34] Project browsertests-UniversalLanguageSelector-commons.wikimedia.beta.wmflabs.org-linux-firefox build #16: STILL FAILING in 7 min 30 sec: https://integration.wikimedia.org/ci/job/browsertests-UniversalLanguageSelector-commons.wikimedia.beta.wmflabs.org-linux-firefox/16/ [18:27:05] Project browsertests-ZeroRatedMobileAccess-en.m.wikipedia.org-linux-phantomjs build #7: STILL FAILING in 1.5 sec: https://integration.wikimedia.org/ci/job/browsertests-ZeroRatedMobileAccess-en.m.wikipedia.org-linux-phantomjs/7/ [18:28:49] actually spagewmf I think that test is finding a bug [18:29:38] chrismcmahon: no doubt, but I'm pretty sure about the targeting flaw [18:30:47] spagewmf: I'm going to play with the selector, I've fixed these before for VE and MF. if that fails I'll turn it off [18:32:10] Project browsertests-UniversalLanguageSelector-language-browsertests.wmflabs.org-linux-firefox build #4: STILL FAILING in 3 min 37 sec: https://integration.wikimedia.org/ci/job/browsertests-UniversalLanguageSelector-language-browsertests.wmflabs.org-linux-firefox/4/ [18:32:54] Project browsertests-en.wikipedia.beta.wmflabs.org-linux-firefox build #4: STILL FAILING in 11 min: https://integration.wikimedia.org/ci/job/browsertests-en.wikipedia.beta.wmflabs.org-linux-firefox/4/ [18:33:39] Project browsertests-VisualEditor-en.wikipedia.beta.wmflabs.org-linux-firefox build #26: STILL FAILING in 20 min: https://integration.wikimedia.org/ci/job/browsertests-VisualEditor-en.wikipedia.beta.wmflabs.org-linux-firefox/26/ [18:33:40] jforrester: Update VE core submodule to master (d21c272) [18:35:25] Project browsertests-Translate-sandbox.translatewiki.net-linux-firefox build #15: STILL FAILING in 2 min 27 sec: https://integration.wikimedia.org/ci/job/browsertests-Translate-sandbox.translatewiki.net-linux-firefox/15/ [18:35:38] Project browsertests-Flow-test2.wikipedia.org-linux-firefox build #4: STILL FAILING in 10 sec: https://integration.wikimedia.org/ci/job/browsertests-Flow-test2.wikipedia.org-linux-firefox/4/ [18:35:38] ebernhardson: Remove period from end of revision comments [18:38:40] Project browsertests-CirrusSearch-test2.wikipedia.org-linux-firefox build #17: FAILURE in 1 min 35 sec: https://integration.wikimedia.org/ci/job/browsertests-CirrusSearch-test2.wikipedia.org-linux-firefox/17/ [18:39:11] Project browsertests-ContentTranslation-language-stage.wmflabs.org-linux-firefox build #4: STILL FAILING in 6 min 57 sec: https://integration.wikimedia.org/ci/job/browsertests-ContentTranslation-language-stage.wmflabs.org-linux-firefox/4/ [18:39:12] * amir.aharoni: Place the entry point dialog 5px before the content text [18:39:12] * kartik.mistry: Fix the tests for the entry point dialog [18:42:07] Project browsertests-CentralAuth-test2.wikipedia.org-linux-firefox build #4: STILL FAILING in 3.9 sec: https://integration.wikimedia.org/ci/job/browsertests-CentralAuth-test2.wikipedia.org-linux-firefox/4/ [18:43:15] Project browsertests-Flow-en.wikipedia.beta.wmflabs.org-linux-firefox build #5: STILL FAILING in 11 sec: https://integration.wikimedia.org/ci/job/browsertests-Flow-en.wikipedia.beta.wmflabs.org-linux-firefox/5/ [18:43:16] ebernhardson: Remove period from end of revision comments [18:47:30] Project UploadWizard-api-commons.wikimedia.beta.wmflabs.org build #7: SUCCESS in 26 sec: https://integration.wikimedia.org/ci/job/UploadWizard-api-commons.wikimedia.beta.wmflabs.org/7/ [18:47:45] Project browsertests-MobileFrontend-test2.m.wikipedia.org-linux-firefox build #4: STILL FAILING in 24 min: https://integration.wikimedia.org/ci/job/browsertests-MobileFrontend-test2.m.wikipedia.org-linux-firefox/4/ [18:47:46] * maxsem.wiki: Hygiene: remove deadbeef, fix returns [18:47:46] * cmcmahon: QA: comment is obsolete, bug is fixed, tag is added [18:49:38] Project browsertests-Translate-meta.wikimedia.org-linux-firefox build #15: SUCCESS in 34 sec: https://integration.wikimedia.org/ci/job/browsertests-Translate-meta.wikimedia.org-linux-firefox/15/ [18:53:40] Project browsertests-CirrusSearch-en.wikipedia.beta.wmflabs.org-linux-firefox build #17: SUCCESS in 36 sec: https://integration.wikimedia.org/ci/job/browsertests-CirrusSearch-en.wikipedia.beta.wmflabs.org-linux-firefox/17/ [18:54:09] Project browsertests-UploadWizard-commons.wikimedia.beta.wmflabs.org-linux-firefox build #4: STILL FAILING in 5.3 sec: https://integration.wikimedia.org/ci/job/browsertests-UploadWizard-commons.wikimedia.beta.wmflabs.org-linux-firefox/4/ [18:54:29] Project UploadWizard-api-commons.wikimedia.org build #6: STILL FAILING in 25 sec: https://integration.wikimedia.org/ci/job/UploadWizard-api-commons.wikimedia.org/6/ [19:04:04] Project browsertests-test2.wikipedia.org-linux-firefox build #4: STILL FAILING in 6 min 0 sec: https://integration.wikimedia.org/ci/job/browsertests-test2.wikipedia.org-linux-firefox/4/ [19:14:14] 3Wikimedia / 3Quality Assurance: move Flow builds to use modern tags - 10https://bugzilla.wikimedia.org/64380 (10Chris McMahon) 3NEW p:3Unprio s:3normal a:3None because of Bug 64082 and Bug 64378 we need to stop edit_existing.feature from running for Chrome right now [19:27:25] chrismcmahon: it sounds like bug 64378 is for edit title, 64082 is for edit post failing. [19:29:54] spagewmf: yes, the test for edit post fails here: Then I should be able to edit the title field with Title edited # features/step_definitions/edit_existing_steps.rb:18 [19:29:54] And I should be able to save the new title # features/step_definitions/edit_existing_steps.rb:26 [19:29:54] unknown error: Element is not clickable at point (828, 678). Other element would receive the click:

...

[19:31:34] Project browsertests-MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox build #4: STILL FAILING in 40 min: https://integration.wikimedia.org/ci/job/browsertests-MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox/4/ [19:31:35] * jrobson: Fix style guide [19:31:35] * jrobson: Hygiene: Introduce cloaked-element class [19:31:36] * maxsem.wiki: Hygiene: remove deadbeef, fix returns [19:31:36] * cmcmahon: QA: comment is obsolete, bug is fixed, tag is added [19:31:37] * jrobson: QA: Fix the diff test [19:31:37] * jrobson: Hygiene: JSDuck cleanup [19:31:38] * jdlrobson: Hygiene: Cleanup blockquote rules [19:31:51] spagewmf: because upon clicking Edit Title, the flow-datestamp behaves as if it were "above" the Change Title button, not below it (in a z-index way). Chrome has a hard time with those. [19:32:47] chrismcmahon: OK, but that change only appeared 3 days ago [19:33:33] spagewmf: yep, and the build for Chrome was green: https://wmf.ci.cloudbees.com/job/Flow-en.wikipedia.beta.wmflabs.org-linux-chrome/382/ [19:38:48] chrismcmahon: ah, good news then we're working on a fix. But I think bug 64082 is why e.g. https://wmf.ci.cloudbees.com/view/flow/job/Flow-test2.wikipedia.org-linux-firefox/185/testReport/%28root%29/Edit%20existing%20title/Edit_existing_post/ failing for a long time [19:39:27] Project UploadWizard-api-commons.wikimedia.beta.wmflabs.org build #8: SUCCESS in 22 sec: https://integration.wikimedia.org/ci/job/UploadWizard-api-commons.wikimedia.beta.wmflabs.org/8/ [19:39:27] l10n-bot: Localisation updates from https://translatewiki.net. [19:39:59] spagewmf: looking now [19:56:47] spagewmf: https://bugzilla.wikimedia.org/show_bug.cgi?id=64386 [19:56:56] spagewmf: pretty sure that's new [20:03:29] chrismcmahon: yikes, no title! [20:03:53] such bug. titles no. wow [20:08:19] spagewmf: are there any Flow pages on mw.o? [20:08:38] sure, mw:Talk:Sandbox, reproduced there. We're on it [20:08:46] schweet [20:15:41] 3Wikimedia / 3Continuous integration: Update CodeSniffer rules automatically on machines running tests - 10https://bugzilla.wikimedia.org/64371#c1 (10Antoine "hashar" Musso) As I stated on the Gerrit change: [..]. Whenever this is merged, one will have to update the related submodule in integration/jenkins.... [20:33:11] 3Wikimedia / 3Continuous integration: Update CodeSniffer rules automatically on machines running tests - 10https://bugzilla.wikimedia.org/64371#c2 (10Chad H.) I did do that. [21:00:56] 3Wikimedia / 3Continuous integration: Update CodeSniffer rules automatically on machines running tests - 10https://bugzilla.wikimedia.org/64371#c3 (10Antoine "hashar" Musso) Bah the job uses a different git-deploy target sorry. phpcs has for option: --standard=/srv/deployment/integration/mediawiki-tools-cod... [21:02:56] 3Wikimedia / 3Continuous integration: Update CodeSniffer rules automatically on machines running tests - 10https://bugzilla.wikimedia.org/64371#c4 (10Antoine "hashar" Musso) And the job pass now! https://integration.wikimedia.org/ci/job/mediawiki-core-phpcs-strict-HEAD/9654/console [22:10:00] (03PS3) 10BryanDavis: Add git submodule update to hhvm build [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/129090 [22:10:13] (03PS4) 10BryanDavis: Add git submodule update to hhvm build [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/129090 [22:15:52] (03CR) 10BryanDavis: "Built with JJB and pushed to Jenkins." [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/129090 (owner: 10BryanDavis) [23:33:36] (03CR) 10BryanDavis: [C: 032] "Seems to be working in Jenkins." [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/129090 (owner: 10BryanDavis) [23:34:40] (03Merged) 10jenkins-bot: Add git submodule update to hhvm build [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/129090 (owner: 10BryanDavis)