[00:47:26] Project UploadWizard-api-commons.wikimedia.beta.wmflabs.org build #9: SUCCESS in 22 sec: https://integration.wikimedia.org/ci/job/UploadWizard-api-commons.wikimedia.beta.wmflabs.org/9/ [00:54:24] Project UploadWizard-api-commons.wikimedia.org build #7: STILL FAILING in 20 sec: https://integration.wikimedia.org/ci/job/UploadWizard-api-commons.wikimedia.org/7/ [00:54:24] l10n-bot: Localisation updates from https://translatewiki.net. [03:06:32] Yippee, build fixed! [03:06:32] Project browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-linux-firefox build #6: FIXED in 28 sec: https://integration.wikimedia.org/ci/job/browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-linux-firefox/6/ [03:06:33] * gdubuc: Set correct license link location in E2E test [03:06:33] * gdubuc: User custom user agent to identify production test runs [03:06:34] * l10n-bot: Localisation updates from https://translatewiki.net. [03:07:52] Project browsertests-UniversalLanguageSelector-sandbox.translatewiki.net-linux-firefox build #15: SUCCESS in 48 sec: https://integration.wikimedia.org/ci/job/browsertests-UniversalLanguageSelector-sandbox.translatewiki.net-linux-firefox/15/ [03:07:52] l10n-bot: Localisation updates from https://translatewiki.net. [03:11:52] Project browsertests-MobileFrontend-en.m.wikipedia.org-linux-firefox build #5: STILL FAILING in 4 min 48 sec: https://integration.wikimedia.org/ci/job/browsertests-MobileFrontend-en.m.wikipedia.org-linux-firefox/5/ [03:11:53] * jrobson: Fix style guide [03:11:53] * jrobson: Hygiene: Introduce cloaked-element class [03:11:54] * jrobson: QA: Fix the diff test [03:11:54] * jrobson: Hygiene: JSDuck cleanup [03:11:55] * jdlrobson: Hygiene: Cleanup blockquote rules [03:11:55] * l10n-bot: Localisation updates from https://translatewiki.net. [03:11:56] * jrobson: Fix talk overlay for new pages [03:11:56] * maxsem.wiki: Hygiene: remove unused parameter [03:11:57] * kaldari: Improve error reporting for image uploads [03:11:57] * jdlrobson: QA: Fix failing photo copyvio browser test [03:21:18] Project browsertests-TwnMainPage-sandbox.translatewiki.net-linux-firefox build #18: STILL FAILING in 6 min 13 sec: https://integration.wikimedia.org/ci/job/browsertests-TwnMainPage-sandbox.translatewiki.net-linux-firefox/18/ [03:25:53] Project browsertests-VisualEditor-test2.wikipedia.org-linux-firefox build #5: STILL FAILING in 13 min: https://integration.wikimedia.org/ci/job/browsertests-VisualEditor-test2.wikipedia.org-linux-firefox/5/ [03:25:54] * jforrester: Image frame icons [03:25:54] * l10n-bot: Localisation updates from https://translatewiki.net. [03:27:05] Project browsertests-ZeroRatedMobileAccess-en.m.wikipedia.org-linux-phantomjs build #8: STILL FAILING in 1 sec: https://integration.wikimedia.org/ci/job/browsertests-ZeroRatedMobileAccess-en.m.wikipedia.org-linux-phantomjs/8/ [03:27:54] Project browsertests-UniversalLanguageSelector-commons.wikimedia.beta.wmflabs.org-linux-firefox build #17: STILL FAILING in 8 min 50 sec: https://integration.wikimedia.org/ci/job/browsertests-UniversalLanguageSelector-commons.wikimedia.beta.wmflabs.org-linux-firefox/17/ [03:27:55] l10n-bot: Localisation updates from https://translatewiki.net. [03:31:19] Project browsertests-UniversalLanguageSelector-language-browsertests.wmflabs.org-linux-firefox build #5: STILL FAILING in 3 min 15 sec: https://integration.wikimedia.org/ci/job/browsertests-UniversalLanguageSelector-language-browsertests.wmflabs.org-linux-firefox/5/ [03:31:19] l10n-bot: Localisation updates from https://translatewiki.net. [03:32:26] Project browsertests-en.wikipedia.beta.wmflabs.org-linux-firefox build #5: STILL FAILING in 11 min: https://integration.wikimedia.org/ci/job/browsertests-en.wikipedia.beta.wmflabs.org-linux-firefox/5/ [03:33:27] Project browsertests-VisualEditor-en.wikipedia.beta.wmflabs.org-linux-firefox build #27: STILL FAILING in 20 min: https://integration.wikimedia.org/ci/job/browsertests-VisualEditor-en.wikipedia.beta.wmflabs.org-linux-firefox/27/ [03:33:27] * jforrester: Image frame icons [03:33:28] * l10n-bot: Localisation updates from https://translatewiki.net. [03:35:15] Project browsertests-Flow-test2.wikipedia.org-linux-firefox build #5: STILL FAILING in 10 sec: https://integration.wikimedia.org/ci/job/browsertests-Flow-test2.wikipedia.org-linux-firefox/5/ [03:35:15] * wctaiwan: Darken input box placeholder text colour [03:35:16] * l10n-bot: Localisation updates from https://translatewiki.net. [03:35:16] * bsitu: postsummary_revId should be topicsummary_revId [03:35:17] * ebernhardson: Revert "Implement multiPut method." [03:35:17] * bsitu: Provide better URLs to IRC rcfeed [03:35:18] Project browsertests-ContentTranslation-language-stage.wmflabs.org-linux-firefox build #5: STILL FAILING in 6 min 11 sec: https://integration.wikimedia.org/ci/job/browsertests-ContentTranslation-language-stage.wmflabs.org-linux-firefox/5/ [03:35:18] l10n-bot: Localisation updates from https://translatewiki.net. [03:37:57] Yippee, build fixed! [03:37:58] Project browsertests-CirrusSearch-test2.wikipedia.org-linux-firefox build #18: FIXED in 53 sec: https://integration.wikimedia.org/ci/job/browsertests-CirrusSearch-test2.wikipedia.org-linux-firefox/18/ [03:37:58] * neverett: Improved experimental highlighter settings [03:37:59] * neverett: Use some analysis plugins if installed [03:37:59] * ori.livneh: Add script to check if Cirrus needs to be rebuilt [03:42:08] Project browsertests-CentralAuth-test2.wikipedia.org-linux-firefox build #5: STILL FAILING in 4.3 sec: https://integration.wikimedia.org/ci/job/browsertests-CentralAuth-test2.wikipedia.org-linux-firefox/5/ [03:43:11] Project browsertests-Flow-en.wikipedia.beta.wmflabs.org-linux-firefox build #6: STILL FAILING in 7.1 sec: https://integration.wikimedia.org/ci/job/browsertests-Flow-en.wikipedia.beta.wmflabs.org-linux-firefox/6/ [03:43:11] * wctaiwan: Darken input box placeholder text colour [03:43:12] * l10n-bot: Localisation updates from https://translatewiki.net. [03:43:12] * bsitu: postsummary_revId should be topicsummary_revId [03:43:13] * ebernhardson: Revert "Implement multiPut method." [03:43:13] * bsitu: Provide better URLs to IRC rcfeed [03:46:34] Project browsertests-MobileFrontend-test2.m.wikipedia.org-linux-firefox build #5: STILL FAILING in 23 min: https://integration.wikimedia.org/ci/job/browsertests-MobileFrontend-test2.m.wikipedia.org-linux-firefox/5/ [03:46:34] * jrobson: Fix style guide [03:46:35] * jrobson: Hygiene: Introduce cloaked-element class [03:46:36] * jrobson: QA: Fix the diff test [03:46:36] * jrobson: Hygiene: JSDuck cleanup [03:46:36] * jdlrobson: Hygiene: Cleanup blockquote rules [03:46:37] * l10n-bot: Localisation updates from https://translatewiki.net. [03:46:38] * jrobson: Fix talk overlay for new pages [03:46:38] * maxsem.wiki: Hygiene: remove unused parameter [03:46:38] * kaldari: Improve error reporting for image uploads [03:46:39] * jdlrobson: QA: Fix failing photo copyvio browser test [03:50:28] Project browsertests-Translate-meta.wikimedia.org-linux-firefox build #16: FAILURE in 1 min 24 sec: https://integration.wikimedia.org/ci/job/browsertests-Translate-meta.wikimedia.org-linux-firefox/16/ [03:50:29] Project browsertests-Translate-sandbox.translatewiki.net-linux-firefox build #16: STILL FAILING in 18 min: https://integration.wikimedia.org/ci/job/browsertests-Translate-sandbox.translatewiki.net-linux-firefox/16/ [03:53:37] Project browsertests-CirrusSearch-en.wikipedia.beta.wmflabs.org-linux-firefox build #18: SUCCESS in 32 sec: https://integration.wikimedia.org/ci/job/browsertests-CirrusSearch-en.wikipedia.beta.wmflabs.org-linux-firefox/18/ [03:53:37] * neverett: Improved experimental highlighter settings [03:53:38] * neverett: Use some analysis plugins if installed [03:53:38] * ori.livneh: Add script to check if Cirrus needs to be rebuilt [03:54:10] Project browsertests-UploadWizard-commons.wikimedia.beta.wmflabs.org-linux-firefox build #5: STILL FAILING in 6.4 sec: https://integration.wikimedia.org/ci/job/browsertests-UploadWizard-commons.wikimedia.beta.wmflabs.org-linux-firefox/5/ [03:54:11] l10n-bot: Localisation updates from https://translatewiki.net. [04:03:37] Project browsertests-test2.wikipedia.org-linux-firefox build #5: STILL FAILING in 5 min 32 sec: https://integration.wikimedia.org/ci/job/browsertests-test2.wikipedia.org-linux-firefox/5/ [04:31:33] Project browsertests-MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox build #5: STILL FAILING in 40 min: https://integration.wikimedia.org/ci/job/browsertests-MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox/5/ [04:31:33] * l10n-bot: Localisation updates from https://translatewiki.net. [04:31:34] * jrobson: Fix talk overlay for new pages [04:31:34] * maxsem.wiki: Hygiene: remove unused parameter [04:31:35] * kaldari: Improve error reporting for image uploads [04:31:35] * jdlrobson: QA: Fix failing photo copyvio browser test [06:41:11] 3Wikimedia / 3Continuous integration: split phpcs in voting and non-voting sniffs - 10https://bugzilla.wikimedia.org/46500 (10Andre Klapper) 5PAT>3NEW [06:43:16] 3Wikimedia / 3Quality Assurance: Investigate VisualEditor browser test failures for "headings" test run via CloudBees - 10https://bugzilla.wikimedia.org/61398#c3 (10Andre Klapper) All patches merged - is there more work left to do here (if yes: please reset the bug report status to NEW or ASSIGNED), or can y... [06:47:31] Project UploadWizard-api-commons.wikimedia.beta.wmflabs.org build #10: SUCCESS in 26 sec: https://integration.wikimedia.org/ci/job/UploadWizard-api-commons.wikimedia.beta.wmflabs.org/10/ [06:51:26] 3Wikimedia / 3Continuous integration: browsertests: triggers for Flow - 10https://bugzilla.wikimedia.org/58401#c9 (10Andre Klapper) 5PAT>3NEW Resetting ticket status as patch was merged [06:52:57] 3Wikimedia / 3Continuous integration: [upstream] Jenkins: MediaWiki unit tests segfault on gallium - 10https://bugzilla.wikimedia.org/43972#c38 (10Andre Klapper) 5PAT>3NEW All patches merged; resetting ticket status [06:54:33] Project UploadWizard-api-commons.wikimedia.org build #8: STILL FAILING in 29 sec: https://integration.wikimedia.org/ci/job/UploadWizard-api-commons.wikimedia.org/8/ [08:25:41] 3Wikimedia / 3Quality Assurance: Investigate VisualEditor browser test failures for "headings" test run via CloudBees - 10https://bugzilla.wikimedia.org/61398#c4 (10Željko Filipin) Chris, since we are moving away from Cloudbees, do you plan to investigate this or should be close it? [08:31:54] zeljkof: good morning :] [08:33:52] hashar: morning! :) [08:34:09] I would like to test the removal of the version from the jobs https://gerrit.wikimedia.org/r/#/c/129436/ [08:34:20] not sure which job to use for testing though. Any idea ? :] [08:34:33] any job would do [08:34:47] pick one that is green and short to run [08:34:52] probably one of cirrus ones [08:34:57] good idea [08:35:28] https://integration.wikimedia.org/ci/view/BrowserTests/job/browsertests-CirrusSearch-en.wikipedia.beta.wmflabs.org-linux-firefox/19/ [08:35:43] 08:35:23 + export VERSION=27 [08:35:43] 08:35:23 + VERSION=27 [08:35:44] \O/ [08:35:56] Project browsertests-CirrusSearch-en.wikipedia.beta.wmflabs.org-linux-firefox build #19: SUCCESS in 32 sec: https://integration.wikimedia.org/ci/job/browsertests-CirrusSearch-en.wikipedia.beta.wmflabs.org-linux-firefox/19/ [08:36:08] we actually do not even need VERSION at the moment [08:36:13] (03CR) 10Hashar: [C: 031 V: 032] "Tested on https://integration.wikimedia.org/ci/view/BrowserTests/job/browsertests-CirrusSearch-en.wikipedia.beta.wmflabs.org-linux-firefox" [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/129436 (owner: 10Hashar) [08:36:15] since we are not running anything on sauce [08:36:19] hashar: ^ [08:36:20] yeah that is what I understood eventually [08:36:28] but we can keep the version around for later [08:36:29] but we will need it soon [08:36:35] since we will want to run some jobs in sauce labs right? [08:36:41] yes [08:36:44] IE jobs [08:36:50] we have no windows slaves, right [08:36:52] ? [08:37:13] at wikimedia, none [08:37:17] so we will have to use sauce labs for that [08:37:25] in that case, sauce is the wqy to go [08:37:28] way to go [08:37:40] yeah we can vary based on the platform [08:37:46] i.e. linux locally, windows deported to saucelabs [08:37:59] (03CR) 10Hashar: [C: 032] "jobs deployed!" [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/129436 (owner: 10Hashar) [08:38:04] hashar: yes, when the jobs are created, we can decide [08:38:16] I am abstracting out platform now [08:38:17] we will kill cloudbees jobs, so we do not have to care about that [08:38:20] and will do the hostname next [08:38:38] you can also remove platform from job names [08:38:45] (03Merged) 10jenkins-bot: Drop version parameter entirely [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/129436 (owner: 10Hashar) [08:38:51] well we will need it for windows platforms dont we ? :] [08:39:01] hashar: yes, leave it in for now [08:39:12] another possibility would be to use matrix jobs [08:39:26] but I am not really sure how to properly describe all the combinaisons [08:39:31] that will be for later on [08:39:46] hashar: yes, something to decide once we see how many jobs we need [08:40:09] *agrees* [08:42:24] ahh [08:42:34] zeljkof: do we care about the case for the platform? Ie Linux versus linux ? [08:43:32] in the env variable? [08:43:34] lemme see [08:43:44] hashar: https://saucelabs.com/platforms [08:43:47] the mediawiki selenium just read the env [08:44:04] caps.platform = 'Linux' [08:44:09] that is what sauce docs say [08:44:26] indeed [08:44:30] it is possible that it would work with Linux, linux and :linux, but did not try :) [08:44:36] but the jenkins jobs are named with a all lower case do [08:44:37] doh [08:44:47] feel free to rename [08:44:57] we do not care about job names [08:45:05] do you have a simple way to test out whether caps['platform'] = 'linux' works ? [08:45:15] I am too lazy to rename all the jobs hehe [08:45:16] hashar: sure, just a minute [08:45:28] hashar: I can rename the jobs, if needed [08:45:42] well, just delete existing ones and deploy renamed ones :) [08:45:47] we do not care about history [08:45:54] if you say so :-D [08:57:53] hashar: yes, both "linux" and "Linux" works [08:57:59] zeljkof: awesome! [08:58:39] hashar: and as I thought, even symbol :linux is valid :) [08:59:17] and :Linux :) [09:01:24] and I found a bug that prevented the Wikilove from being generated! [09:02:35] (03PS1) 10Hashar: Restore WikiLove job! [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/129647 [09:02:54] nasty bug [09:03:30] (03CR) 10Hashar: [C: 031] "Job deployed https://integration.wikimedia.org/ci/view/BrowserTests/job/browsertests-WikiLove-en.wikipedia.beta.wmflabs.org-linux-firefox/" [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/129647 (owner: 10Hashar) [09:04:08] nice it seems to be passing [09:04:27] Project browsertests-WikiLove-en.wikipedia.beta.wmflabs.org-linux-firefox build #1: SUCCESS in 1 min 36 sec: https://integration.wikimedia.org/ci/job/browsertests-WikiLove-en.wikipedia.beta.wmflabs.org-linux-firefox/1/ [09:16:38] (03PS1) 10Hashar: Vary VisualEditor and ZeroRatedMobileAccess by browser [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/129649 [09:16:41] (03PS1) 10Hashar: Make platform all lower case [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/129650 [09:16:44] (03PS1) 10Hashar: Make the job templates to vary by platform [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/129651 [09:17:18] zeljkof: added you as a reviewer to the changes above [09:17:33] most of them are not doing any modifications to the jobs. Just adjusting the templates names :-] [09:17:47] and Wikilove pass!!!!! [09:17:56] hashar: will take a look [09:18:40] the diff job should make them obvious hehe [09:23:45] ah the qa/browsertests are a bit more challenging [09:24:07] I think I will rename them smoke-{hostname} [09:24:11] and vary all the jobs by hostname [09:24:16] that is going to be a massive change [09:24:32] qa/browsertests will be smaller and smaller with time [09:24:49] we are moving tests from there to extension repos [09:24:50] would you qualify them as being smoke tests ? [09:25:00] not sure [09:25:52] I am willing to rename eg browsertests-test2.wikipedia.org-linux-firefox to [09:25:56] browsertests-smoke-test2.wikipedia.org-linux-firefox [09:25:58] or [09:26:04] browsertests-qa-linux-firefox [09:26:08] err [09:26:11] browsertests-qa-test2.wikipedia.org-linux-firefox [09:26:23] the aim is to add {mediawiki_url} in the job templates [09:26:28] sure [09:26:30] go ahead [09:26:39] qa is better than smoke [09:26:44] sold [09:38:57] (03PS1) 10Hashar: Prefix the two qa/browsertests jobs with 'qa-' [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/129654 [09:39:19] I have renamed the two jobs [09:40:17] (03PS2) 10Hashar: Prefix the two qa/browsertests jobs with 'qa-' [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/129654 [09:41:54] (03CR) 10Zfilipin: [C: 032] Restore WikiLove job! [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/129647 (owner: 10Hashar) [09:42:19] (03Merged) 10jenkins-bot: Restore WikiLove job! [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/129647 (owner: 10Hashar) [09:45:07] (03CR) 10Zfilipin: [C: 032] Vary VisualEditor and ZeroRatedMobileAccess by browser [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/129649 (owner: 10Hashar) [09:45:30] (03Merged) 10jenkins-bot: Vary VisualEditor and ZeroRatedMobileAccess by browser [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/129649 (owner: 10Hashar) [09:46:15] (03CR) 10Zfilipin: [C: 032] Make platform all lower case [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/129650 (owner: 10Hashar) [09:46:38] (03Merged) 10jenkins-bot: Make platform all lower case [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/129650 (owner: 10Hashar) [09:47:15] zeljkof: let me know if you have any question :] [09:47:23] hashar: so far so good :) [09:48:55] (03CR) 10Zfilipin: [C: 032] Make the job templates to vary by platform [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/129651 (owner: 10Hashar) [09:49:20] (03Merged) 10jenkins-bot: Make the job templates to vary by platform [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/129651 (owner: 10Hashar) [09:50:17] (03CR) 10Zfilipin: [C: 032] Prefix the two qa/browsertests jobs with 'qa-' [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/129654 (owner: 10Hashar) [09:50:25] that is a bit cleaner [09:50:49] (03Merged) 10jenkins-bot: Prefix the two qa/browsertests jobs with 'qa-' [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/129654 (owner: 10Hashar) [09:51:01] now I would like to be able to define a project such as CirrusSearch and pass it two different mediawiki_url [09:51:02] ie: [09:51:40] - project: [09:51:40] name: CirrusSearch [09:51:41] mediawiki_url: [09:51:41] - test2.wikipedia.org [09:51:41] - en.wikipedia.beta.wmflabs.org [09:51:59] but we will have to vary the mediawiki_user and mediawiki_password_variable based on the project and hostname targetted [09:52:04] that is going to be a lot of mess [09:52:28] we can automatically generate usernames and/or passwords [09:52:52] I mean, we can set up users and passwords so jjb script is simpler [09:53:02] we do not have to use current users/passwords [09:55:45] we have 5 different usernames (1 Bttesting, 3 Selenium, 1 Selenium-Translate, 17 Selenium_user and 1 TranslatorToDa ) [09:56:04] and 7 different password variables duh [09:56:57] hashar: all grew up organically [09:57:03] I can imagine [09:57:05] be we can demand convention [09:57:13] so the script can be simple [09:57:56] (jjb script) [09:59:09] The one running on language-browsertests.wmflabs.org which uses Bttesting [09:59:43] http://language-browsertests.wmflabs.org/wiki/index.php/Special:ListUsers [10:00:30] we could create a new user named Selenium_user just like the beta cluster [10:00:38] and reuse the password defined in MEDIAWIKI_PASSWORD_SELENIUM_USER_WMFLABS_ORG [10:01:04] hashar: a simple solution would be [10:01:12] all users have the same password [10:01:29] yeah probably :] [10:01:32] a) all jobs use the same user (not practical) [10:01:55] b) every repository has a different user browsertests+repo_name [10:02:14] c) maybe even every job has a separate user browsertests+job_name [10:02:20] something like that [10:02:34] b) is probably the most practical [10:09:59] ahhhhh [10:10:19] the UploadWizard-api test jobs have different pollscm values [10:10:27] for prod: pollscm: '0 5 31 2 *' [10:10:38] whereas for beta it is '* * * * *' [10:19:46] I am going to drop the poll scm [10:19:50] the job already run twice per day [10:23:41] hashar: that job needs to be configured to run differently [10:23:45] let me check [10:23:52] I am refactoring it slightly [10:23:54] dropping the poll scm [10:24:11] and setting the username and password depending on the target hostname [10:24:21] hashar: https://bugzilla.wikimedia.org/show_bug.cgi?id=63105 [10:24:58] ah so it should be triggered after an update of core on beta right? [10:25:23] we might be able to trigger it from Zuul as well [10:26:21] hashar: you should ask upload wizard people [10:28:03] (03PS1) 10Hashar: Refactor UploadWizard-API job to use a single template [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/129661 [10:28:30] 06:54:31 + DEV/bin/python tests/api/upload-wizard_tests.py --username Selenium_user --api_url http://commons.wikimedia.org/w/api.php [10:28:30] 06:54:32 error: username and password required. Pass these values with the corresponding flags or set the env variables: MEDIAWIKI_USER and MEDIAWIKI_PASSWORD or MEDIAWIKI_PASSWORD_VARIABLE (points to env var with password value) [10:28:31] :( [10:28:33] https://integration.wikimedia.org/ci/view/BrowserTests/job/UploadWizard-api-commons.wikimedia.org/8/console [10:28:37] the prod job does not work bah [10:29:09] I am just going to refresh both jobs, run them and see what happens hehe [10:29:16] :) [10:29:32] off to a meeting with kart_, ping me if something is urgent, back in an hour [10:29:37] okkk [10:31:03] Project UploadWizard-api-commons.wikimedia.beta.wmflabs.org build #11: FAILURE in 18 sec: https://integration.wikimedia.org/ci/job/UploadWizard-api-commons.wikimedia.beta.wmflabs.org/11/ [10:33:00] Project UploadWizard-api-commons.wikimedia.beta.wmflabs.org build #12: STILL FAILING in 20 sec: https://integration.wikimedia.org/ci/job/UploadWizard-api-commons.wikimedia.beta.wmflabs.org/12/ [10:36:53] Project UploadWizard-api-commons.wikimedia.beta.wmflabs.org build #13: STILL FAILING in 19 sec: https://integration.wikimedia.org/ci/job/UploadWizard-api-commons.wikimedia.beta.wmflabs.org/13/ [10:37:29] Project UploadWizard-api-commons.wikimedia.org build #9: STILL FAILING in 19 sec: https://integration.wikimedia.org/ci/job/UploadWizard-api-commons.wikimedia.org/9/ [10:46:23] hashar: can you join kart_ and me in a pairing session? [10:46:54] we are trying to change http://language-stage.wmflabs.org/index.php/Main_Page to http://language-stage.wmflabs.org/wiki/Main_Page [10:47:51] hashar: the url is https://plus.google.com/hangouts/_/wikimedia.org/kmistry-zfilipi?authuser=1 [10:48:00] sure [10:48:17] I broke the upload wizard api tests :-( [11:08:41] \O/ [11:12:55] hashar: can you come back to the hangout? :) [11:13:07] kart_ can not connect to the instance [11:13:36] bahh [11:18:33] Project UploadWizard-api-commons.wikimedia.beta.wmflabs.org build #16: STILL FAILING in 19 sec: https://integration.wikimedia.org/ci/job/UploadWizard-api-commons.wikimedia.beta.wmflabs.org/16/ [11:18:38] ahhh [11:18:46] authentication is broken on beta apparently [11:51:50] Project browsertests-WikiLove-en.wikipedia.beta.wmflabs.org-linux-firefox build #2: FAILURE in 28 sec: https://integration.wikimedia.org/ci/job/browsertests-WikiLove-en.wikipedia.beta.wmflabs.org-linux-firefox/2/ [11:52:22] :-( [11:52:32] Project browsertests-WikiLove-en.wikipedia.beta.wmflabs.org-linux-firefox build #3: STILL FAILING in 17 sec: https://integration.wikimedia.org/ci/job/browsertests-WikiLove-en.wikipedia.beta.wmflabs.org-linux-firefox/3/ [12:01:21] ohh [12:01:27] zeljkof: we have a CentralAuth browser test [12:01:33] but it has no test/browser directory :] [12:01:40] 03:42:07 /tmp/hudson5362726927493402372.sh: line 30: cd: tests/browser/: No such file or directory [12:01:42] hashar: it is waiting to get merged [12:01:46] ahh [12:01:56] and login on beta is broken right now [12:01:58] hashar: https://gerrit.wikimedia.org/r/#/c/125740/ [12:02:02] great! [12:02:16] did not have the time to fix the commit so it could get merged [12:03:45] out for half an hour or so, need some groceries [12:03:46] brb [12:22:23] Yippee, build fixed! [12:22:24] Project UploadWizard-api-commons.wikimedia.beta.wmflabs.org build #17: FIXED in 22 sec: https://integration.wikimedia.org/ci/job/UploadWizard-api-commons.wikimedia.beta.wmflabs.org/17/ [12:23:04] \O/ [12:25:46] (03PS2) 10Hashar: Refactor UploadWizard-API job to use a single template [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/129661 [12:28:00] Project UploadWizard-api-commons.wikimedia.org build #10: STILL FAILING in 18 sec: https://integration.wikimedia.org/ci/job/UploadWizard-api-commons.wikimedia.org/10/ [12:28:08] stupid test bah [12:28:25] hashar: did you see http://deployment.wikimedia.beta.wmflabs.org/wiki/User_talk:Hashar [12:28:48] Nemo_bis: I dont read my talk pages [12:28:59] and definitely not the ones on beta hehe [12:29:22] Nemo_bis: bug fill it against Wikimedia > deployment-prep (beta cluster) [12:30:01] I am not entirely sure how to add you to the group :D [12:31:06] zeljkof: we would need the prod password to be set, Ie MEDIAWIKI_PASSWORD_SELENIUM_USER_WIKIPEDIA_ORG [12:31:17] should fix the job https://integration.wikimedia.org/ci/view/BrowserTests/job/UploadWizard-api-commons.wikimedia.org/ [12:32:46] (03CR) 10Hashar: "The beta job pass. the prod one still fails because we do not define MEDIAWIKI_PASSWORD_SELENIUM_USER_WIKIPEDIA_ORG yet" [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/129661 (owner: 10Hashar) [12:40:37] hashar: [[special:userrights/Nemo_bis]] :) [12:47:25] Project UploadWizard-api-commons.wikimedia.beta.wmflabs.org build #18: SUCCESS in 21 sec: https://integration.wikimedia.org/ci/job/UploadWizard-api-commons.wikimedia.beta.wmflabs.org/18/ [12:54:23] Project UploadWizard-api-commons.wikimedia.org build #11: STILL FAILING in 19 sec: https://integration.wikimedia.org/ci/job/UploadWizard-api-commons.wikimedia.org/11/ [13:05:58] 3Wikimedia / 3Continuous integration: Update CodeSniffer rules automatically on machines running tests - 10https://bugzilla.wikimedia.org/64371 (10Sam Reed (reedy)) s:5normal>3enhanc [13:34:53] hasharAway: will do [13:35:25] manybubbles: I am in the hangout [13:35:32] apologies for being late [13:44:49] baaaack [13:46:15] kart_: still around ? [13:47:10] kart_: the http://language-stage.wmflabs.org/wiki/Special:ListUsers has a user TranslatorToDa for the browser tests. I would rather use 'Selenium_user' to standardize our jobs :-] [13:48:31] same for language-browsertests.wmflabs.org which uses Bttesting :D [13:49:38] http://language-browsertests.wmflabs.org/wiki/Main_Page is fixed now :) [13:49:50] great! [13:50:05] hashar: will do. Need to check with aharoni on why we used TranslatorToDa [13:50:11] aharoni: ^ [13:50:22] kart_: http://language-browsertests.wmflabs.org/wiki/Special:ListUsers gives me a database error :D [13:50:30] eh [13:50:35] let me check [13:50:41] maybe it can access the /data/ dir [13:50:42] kart_: hashar - because I wanted translators to several languages [13:50:46] or it is not writable by the apache user [13:50:50] but that's not very important any more. [13:51:07] because in every scenario we clean the preferences anyway. [13:51:17] aharoni: can we standardize the user / password being used to Selenium_user and the pass used on beta cluster so ? [13:51:36] hashar: fixed db [13:51:54] kart_: works for me :] [13:52:19] kart_: so I guess on language-browsertests we want to use Selenium_user as well instead of Bttesting user [13:52:31] Yes we can. [13:54:14] created the account Selenium_user on language-browsertests with zeljkof email address [13:56:32] hashar: thanks [13:57:02] we will see what happens [13:58:28] (03PS1) 10Hashar: Normalize user/pass for language-browsertests instance [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/129686 [13:58:45] bah [13:58:46] https://integration.wikimedia.org/ci/job/browsertests-UniversalLanguageSelector-language-browsertests.wmflabs.org-linux-firefox/6/console [13:58:47] times out [13:58:48] :-D [14:00:13] Project browsertests-UniversalLanguageSelector-language-browsertests.wmflabs.org-linux-firefox build #6: STILL FAILING in 3 min 15 sec: https://integration.wikimedia.org/ci/job/browsertests-UniversalLanguageSelector-language-browsertests.wmflabs.org-linux-firefox/6/ [14:04:26] oh my god [14:04:27] can't fix it [14:04:28] :-( [14:04:59] both language-stage.wmflabs.org and language-browsertests.wmflabs.org points to the shared proxy grrr [14:21:00] fixed up by https://gerrit.wikimedia.org/r/#/c/129687/ [14:22:58] kart_: aharoni: https://integration.wikimedia.org/ci/job/browsertests-UniversalLanguageSelector-language-browsertests.wmflabs.org-linux-firefox/7/console is now running properly! :-] [14:23:03] with Selenium_user [14:23:07] * hashar dance [14:23:26] ta-pa-ta-pa-tam. [14:24:52] (03CR) 10Hashar: [C: 032] "The job has a bunch of green at https://integration.wikimedia.org/ci/job/browsertests-UniversalLanguageSelector-language-browsertests.wmfl" [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/129686 (owner: 10Hashar) [14:25:13] Yippee, build fixed! [14:25:14] Project browsertests-UniversalLanguageSelector-language-browsertests.wmflabs.org-linux-firefox build #7: FIXED in 3 min 33 sec: https://integration.wikimedia.org/ci/job/browsertests-UniversalLanguageSelector-language-browsertests.wmflabs.org-linux-firefox/7/ [14:25:18] (03Merged) 10jenkins-bot: Normalize user/pass for language-browsertests instance [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/129686 (owner: 10Hashar) [14:25:30] mouahahahha [14:27:01] kart_: aharoni got another job around https://integration.wikimedia.org/ci/job/browsertests-ContentTranslation-language-stage.wmflabs.org-linux-firefox/6/console [14:27:10] kart_: aharoni : that one fails because the paths are too long [14:27:21] when taking screenshots it uses the long description of the featureS. [14:27:32] Project browsertests-ContentTranslation-language-stage.wmflabs.org-linux-firefox build #6: STILL FAILING in 1 min 20 sec: https://integration.wikimedia.org/ci/job/browsertests-ContentTranslation-language-stage.wmflabs.org-linux-firefox/6/ [14:27:32] santhosh.thottingal: Some cleanup on html before saving [14:27:49] that fixed by mediawiki-selenium gem 0.2.22 [14:30:44] hi hashar do you have any ideas why this build has such a wild swing of failures in the test result trend? https://integration.wikimedia.org/ci/view/BrowserTests/job/browsertests-VisualEditor-en.wikipedia.beta.wmflabs.org-linux-firefox/ [14:31:00] hashar: it's like something goes wrong with Jenkins every other run or so. [14:31:45] chrismcmahon: na havent looked at it sorry. Visual Editor scares me [14:31:52] but we made good progress on the other jobs! [14:32:54] (03PS1) 10Hashar: Normalize user/pass for language-stage instance [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/129691 [14:33:29] chrismcmahon: are you familiar with the ContentTranslation extension browser tests ? [14:33:39] Project browsertests-ContentTranslation-language-stage.wmflabs.org-linux-firefox build #7: STILL FAILING in 1 min 21 sec: https://integration.wikimedia.org/ci/job/browsertests-ContentTranslation-language-stage.wmflabs.org-linux-firefox/7/ [14:33:45] we need the mediawiki-selenium gem 0.2.22+ [14:33:51] and I am not sure how to update it [14:33:52] ah. [14:33:58] or maybe kart can hehe [14:34:07] hashar: VisualEditor doesn't seem to be the problem, it's the build itself has all kinds of crazy errors every other run [14:34:15] :) [14:34:27] hashar: what repo needs 2.22? [14:34:37] ContentTranslation apparently [14:34:44] the job https://integration.wikimedia.org/ci/job/browsertests-ContentTranslation-language-stage.wmflabs.org-linux-firefox/7/ fails [14:34:57] because it attempts to write a screenshot named based on the feature long description [14:35:03] that is a bit too long (and contains newlines) [14:35:10] we spot that one later this week with Zeljkof [14:35:22] that is fixed by 0.2.22 * fa6c523 - (HEAD, tag: 0.2.22, gerrit/master, gerrit/HEAD, master) Fixed "File name too long" error message (2 days ago) <Željko Filipin> [14:35:42] related gerrit diff is https://gerrit.wikimedia.org/r/#/c/129141/ [14:38:17] * zeljkof is out to lunch [14:38:20] hashar: https://gerrit.wikimedia.org/r/#/c/129693/ has updated gems for ContentTranslation [14:38:41] greaat [14:40:01] chrismcmahon: I will just merge it [14:43:10] Project browsertests-ContentTranslation-language-stage.wmflabs.org-linux-firefox build #8: STILL FAILING in 1 min 52 sec: https://integration.wikimedia.org/ci/job/browsertests-ContentTranslation-language-stage.wmflabs.org-linux-firefox/8/ [14:43:10] cmcmahon: QA: update Ruby gems [14:43:30] chrismcmahon: that is better. thank you! [14:43:33] gotta fix the password now :/ [14:48:19] chrismcmahon: looking at the VE test, I am sorry i have no idea what all those errors mean :( [14:49:45] hashar: I can point to some of the weird ones, but are there any other builds where one is normal, the next has problems, the next is normal, the next has problems, like that? [14:50:14] chrismcmahon: yeah it might happen if one of the slave behave differently [14:50:27] but we had success and errors on the slave node (integration-slave1002.eqiad.wmflabs ) [14:50:35] also, login got broken for most of the day on beta cluster [14:50:38] it is fixednow [14:50:42] maybe retrigger them? :( [14:51:41] hashar: e.g. build 22 is good, 23 is bad, 24 is good, then 25 26 27 are all bad [14:52:05] ah. login would explain why 26 is bad [14:52:14] maybe [14:52:39] hashar: but yeah, every other build for the VE build is hosed. I think it is the overnight runs (my time) that are the bad ones [14:58:04] 4:57:48 expected: "Selenium_user" [14:58:05] 14:57:48 got: "Selenium user" (using == [14:58:06] seriously [14:58:50] Project browsertests-ContentTranslation-language-stage.wmflabs.org-linux-firefox build #9: STILL FAILING in 1 min 33 sec: https://integration.wikimedia.org/ci/job/browsertests-ContentTranslation-language-stage.wmflabs.org-linux-firefox/9/ [14:59:12] hashar: yes [14:59:18] you have to put spaces [14:59:22] no underscores [14:59:27] I converted that job to use mediawiki_user: Selenium_user [14:59:29] mediawiki normalizes user names [14:59:30] just like all the other jobs [14:59:43] they should all be "Selenium user" [14:59:47] with the beta cluster password [15:00:52] Then(/^I see the username at the top of the page$/) do [15:00:52] on(ContentTranslationPage).user_name_element.text.should == ENV["MEDIAWIKI_USER"] [15:00:52] end [15:00:56] ahh [15:01:48] hashar: I got e-mail from http://language-browsertests.wmflabs.org/wiki/Special:ConfirmEmail/ in French :) [15:02:06] zeljkof: ahah nice [15:02:14] zeljkof: I think that one is fixed now [15:02:26] I changed the language-stage password as well [15:02:30] soo [15:02:37] hashar: going to a meeting with chrismcmahon, back in an hour [15:02:38] the doc says to export MEDIAWIKI_USER=Selenium_user [15:02:39] in a bunch of place [15:03:51] zeljkof: the username should really use underscores. It is used in a bunch of random place that probably expect an underscore. [15:03:55] I will try to fix the feature :] [15:13:15] (03CR) 10Hashar: [C: 032] "The job manages to login. It fails due to a faulty comparaison fixed by https://gerrit.wikimedia.org/r/129696" [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/129691 (owner: 10Hashar) [15:13:30] back [15:13:56] (03Merged) 10jenkins-bot: Normalize user/pass for language-stage instance [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/129691 (owner: 10Hashar) [15:22:09] Project browsertests-ZeroRatedMobileAccess-en.m.wikipedia.org-linux-phantomjs build #9: STILL FAILING in 10 sec: https://integration.wikimedia.org/ci/job/browsertests-ZeroRatedMobileAccess-en.m.wikipedia.org-linux-phantomjs/9/ [15:23:26] (03PS1) 10Hashar: ZeroRatedMobileAccess had a cloudbees phantomjs install [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/129700 [15:23:37] (03CR) 10Hashar: [C: 032] ZeroRatedMobileAccess had a cloudbees phantomjs install [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/129700 (owner: 10Hashar) [15:23:59] (03Merged) 10jenkins-bot: ZeroRatedMobileAccess had a cloudbees phantomjs install [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/129700 (owner: 10Hashar) [15:25:02] poor ZeroRatedMobileAccess fails for some reason :/ [15:30:02] movving out [15:30:06] might be there later tonight [15:34:09] Project browsertests-Flow-test2.wikipedia.org-linux-firefox build #6: STILL FAILING in 3 min 5 sec: https://integration.wikimedia.org/ci/job/browsertests-Flow-test2.wikipedia.org-linux-firefox/6/ [15:34:09] zeljko.filipin: Added required Cucumber tags [15:35:09] Project browsertests-Flow-en.wikipedia.beta.wmflabs.org-linux-firefox build #7: STILL FAILING in 4 min 4 sec: https://integration.wikimedia.org/ci/job/browsertests-Flow-en.wikipedia.beta.wmflabs.org-linux-firefox/7/ [15:35:10] zeljko.filipin: Added required Cucumber tags [15:41:47] (03PS1) 10Zfilipin: Take screen shot only if browser is opened [selenium] - 10https://gerrit.wikimedia.org/r/129704 [15:50:53] (03CR) 10Cmcmahon: [C: 032] Take screen shot only if browser is opened [selenium] - 10https://gerrit.wikimedia.org/r/129704 (owner: 10Zfilipin) [15:58:36] Project browsertests-Flow-test2.wikipedia.org-linux-firefox build #7: STILL FAILING in 3 min 4 sec: https://integration.wikimedia.org/ci/job/browsertests-Flow-test2.wikipedia.org-linux-firefox/7/ [15:58:36] zeljko.filipin: Updated Ruby gems [16:11:36] Project browsertests-Flow-en.wikipedia.beta.wmflabs.org-linux-firefox build #8: STILL FAILING in 3 min 59 sec: https://integration.wikimedia.org/ci/job/browsertests-Flow-en.wikipedia.beta.wmflabs.org-linux-firefox/8/ [16:11:37] zeljko.filipin: Updated Ruby gems [16:11:37] Project browsertests-Flow-test2.wikipedia.org-linux-firefox build #8: STILL FAILING in 3 min 58 sec: https://integration.wikimedia.org/ci/job/browsertests-Flow-test2.wikipedia.org-linux-firefox/8/ [16:15:06] (03PS3) 10Zfilipin: Refactor UploadWizard-API job to use a single template [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/129661 (owner: 10Hashar) [17:21:22] Yippee, build fixed! [17:21:23] Project browsertests-qa-en.wikipedia.beta.wmflabs.org-linux-firefox build #6: FIXED in 9 min 26 sec: https://integration.wikimedia.org/ci/job/browsertests-qa-en.wikipedia.beta.wmflabs.org-linux-firefox/6/ [17:27:28] one down [17:30:28] Project browsertests-VisualEditor-en.wikipedia.beta.wmflabs.org-linux-firefox build #28: STILL FAILING in 22 min: https://integration.wikimedia.org/ci/job/browsertests-VisualEditor-en.wikipedia.beta.wmflabs.org-linux-firefox/28/ [17:35:16] Project browsertests-qa-test2.wikipedia.org-linux-firefox build #6: STILL FAILING in 10 min: https://integration.wikimedia.org/ci/job/browsertests-qa-test2.wikipedia.org-linux-firefox/6/ [17:47:39] Project browsertests-qa-test2.wikipedia.org-linux-firefox build #7: STILL FAILING in 10 min: https://integration.wikimedia.org/ci/job/browsertests-qa-test2.wikipedia.org-linux-firefox/7/ [17:59:35] Yippee, build fixed! [17:59:35] Project browsertests-qa-test2.wikipedia.org-linux-firefox build #8: FIXED in 9 min 35 sec: https://integration.wikimedia.org/ci/job/browsertests-qa-test2.wikipedia.org-linux-firefox/8/ [18:00:09] two down [18:04:44] Yippee, build fixed! [18:04:45] Project browsertests-WikiLove-en.wikipedia.beta.wmflabs.org-linux-firefox build #4: FIXED in 1 min 20 sec: https://integration.wikimedia.org/ci/job/browsertests-WikiLove-en.wikipedia.beta.wmflabs.org-linux-firefox/4/ [18:05:14] three down [18:05:27] hi RoanKattouw [18:05:38] Heya [18:05:46] Writing a commit message, one second [18:06:17] RoanKattouw: take your tiime [18:06:29] Project browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-linux-firefox build #7: SUCCESS in 25 sec: https://integration.wikimedia.org/ci/job/browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-linux-firefox/7/ [18:06:30] pau.giner: Images for zoom [18:08:06] Alright lemme grab my notes [18:08:16] Project browsertests-UniversalLanguageSelector-sandbox.translatewiki.net-linux-firefox build #16: SUCCESS in 1 min 12 sec: https://integration.wikimedia.org/ci/job/browsertests-UniversalLanguageSelector-sandbox.translatewiki.net-linux-firefox/16/ [18:08:17] amir.aharoni: Update jquery.uls from upstream [18:08:26] So I went through every single .feature file and tried to run it [18:08:31] ok [18:08:41] And made some observations along the way [18:08:57] I ran them in Firefox, with reuse enabled (which is SO much faster) [18:09:15] PhantomJS doesn't seem to work very well but given that you seem to have gotten things working in headless Firefox, we don't really need it [18:09:46] My main observations were that 1) the sleeps you've been sprinkling across the code are actually needed in some places (and uinnecessary in only a handful) [18:09:49] RoanKattouw: yeah, I'd rather use a real browser. I'm hoping we can get Chrome headless rsn [18:10:05] 2) we're very very obsessive about logging in [18:10:22] RoanKattouw: there are 4 sleeps in place, I'd like to get rid of them, but they're not doing much harm right now [18:10:31] What that means is that 2a) many tests will log in repeatedly, which actually breaks because the login form is prepopulated, so you get an error, and eventually your IP gets blocked from logging in temporarily [18:10:36] refactoring the sleeps is on my list [18:10:55] Project browsertests-MobileFrontend-en.m.wikipedia.org-linux-firefox build #6: STILL FAILING in 6 min 3 sec: https://integration.wikimedia.org/ci/job/browsertests-MobileFrontend-en.m.wikipedia.org-linux-firefox/6/ [18:11:08] RoanKattouw: we only get IPs blocked in prod, it hasn't been an issue in beta/test2wiki [18:11:17] 2b) most tests don't need to log in at all [18:11:42] RoanKattouw: they do on beta labs [18:11:48] ? [18:12:01] Surely if you just open the editor, try to make a change, preview it, then don't save, you don't need to log in? [18:12:09] ?veaction=edit works even if you're anonymous [18:13:27] RoanKattouw: heh. wish I'd known that a bit earlier. [18:13:42] didn't even think about it, actually [18:14:09] It took me a while to realize after watching the tests run for a while [18:14:26] It's mostly because I have a terrible habit of never logging in and using the URL hack to avoid having to do so [18:14:29] RoanKattouw: OK, that will make things much nicer. [18:14:43] and, you know, try to edit protected pages and stuff :) [18:16:04] RoanKattouw: my biggest headache with these tests boils down to performance. seems like especially when invoking the save dialog [18:17:10] 5s waiting for "Review your changes" https://integration.wikimedia.org/ci/view/BrowserTests/job/browsertests-VisualEditor-en.wikipedia.beta.wmflabs.org-linux-firefox/28/testReport/(root)/VisualEditor%20general%20text%20markup%20features/VisualEditor_general_markup__outline_example_____Subscript____sub_This_is_a_new_line__sub____/ [18:17:53] 10s waiting to click "This is a minor edit" https://integration.wikimedia.org/ci/view/BrowserTests/job/browsertests-VisualEditor-en.wikipedia.beta.wmflabs.org-linux-firefox/28/testReport/(root)/VisualEditor/Edit_with_strings__outline_example_____Editing_with_%C3%84%C3%8B%C3%8F%C3%96%C3%9C___Editing_with_%C3%84%C3%8B%C3%8F%C3%96%C3%9C___/ [18:18:48] Is that on beta labs though? [18:18:51] RoanKattouw: yes [18:18:53] Because on localhost this stuff is pretty snappy for me [18:20:14] RoanKattouw: I am in the position of being able to say that if it is an issue on beta labs, it is an issue, period. [18:20:38] Yeah [18:20:48] I don't know exactly why [18:21:03] But I do know that opening dialogs in Firefox is a bit slow due to specifics in how Firefox deals with iframes [18:21:08] In Chrome is should be faster [18:21:20] RoanKattouw: seems mysterious to me also. Parsoid is on a separate host, but the hosts are all labs hosts, should be pretty zippy [18:21:26] What I would really love us to do is run headless Firefox against a local MW install from Jenkins [18:21:35] Project browsertests-TwnMainPage-sandbox.translatewiki.net-linux-firefox build #19: STILL FAILING in 6 min 30 sec: https://integration.wikimedia.org/ci/job/browsertests-TwnMainPage-sandbox.translatewiki.net-linux-firefox/19/ [18:22:16] Or at least some subset of thme [18:22:32] chrismcmahon: Do you run tests with REUSE_BROWSER=true ? [18:23:20] I do when I'm developing or running a lot on the local host. But usually I'm only running a single line that failed. [18:23:25] RoanKattouw: [18:23:38] Right [18:24:26] OK so here are a few things that I'd like to work on soon [18:24:29] RoanKattouw: e.g. you get a message that the test failed on line 12, you can run " bundle exec cucumber features/foo.feature:12" and just hit that bit of the test [18:24:36] oooooh that's neat [18:24:44] So tell me if these things are sane: [18:27:14] Project browsertests-ZeroRatedMobileAccess-en.m.wikipedia.org-linux-phantomjs build #10: STILL FAILING in 9.2 sec: https://integration.wikimedia.org/ci/job/browsertests-ZeroRatedMobileAccess-en.m.wikipedia.org-linux-phantomjs/10/ [18:27:33] * Remove login from tests where not needed (verifying they keep passing locally and in beta labs) [18:28:13] * Tag tests that I have confirmed to work locally so they're easy to run [18:28:14] RoanKattouw: totally. Out of curiosity, how long has the URL trick worked? [18:28:44] Since some time last year, but a while after you guys started working on this [18:28:53] In hindsight we totally should have told you; I'm very sorry we didn't [18:29:05] RoanKattouw: you can add any tags you like to any .feature. as long as you don't remove any, they'll be no-op in the builds [18:29:10] It was done because someone asked for it for completely different reasons [18:29:12] Awesome [18:29:47] * Fix stacking of annotations in general_markup.feature (right now it produces crazy nested stuff like blah) [18:30:06] * Maybe merge indent_outdent.feature and bullets.feature [18:30:55] RoanKattouw: istr there was a good reason to separate indent_outdent from bullets (beside that I was working with the GSoC intern on those all that time ago) [18:31:10] I'll look though. [18:31:13] OK [18:31:18] I'm happy to keep it separate too [18:31:23] And lastly, [18:31:29] * Find out how to run headless Firefox locally :) [18:31:40] That's probably enough tasks for me for now [18:31:41] Oh and [18:31:53] * Figure out why waiting for save dialog things is so slow on beta labs [18:31:54] Project browsertests-qa-en.wikipedia.beta.wmflabs.org-linux-firefox build #7: SUCCESS in 10 min: https://integration.wikimedia.org/ci/job/browsertests-qa-en.wikipedia.beta.wmflabs.org-linux-firefox/7/ [18:32:14] Project browsertests-UniversalLanguageSelector-commons.wikimedia.beta.wmflabs.org-linux-firefox build #18: STILL FAILING in 13 min: https://integration.wikimedia.org/ci/job/browsertests-UniversalLanguageSelector-commons.wikimedia.beta.wmflabs.org-linux-firefox/18/ [18:32:15] amir.aharoni: Update jquery.uls from upstream [18:32:15] RoanKattouw: running headless FF locally should be possible, there is a nice gem for it. Send a message to the qa list for that one? [18:32:30] Well, is it documented anywhere? [18:32:33] RoanKattouw: yep, a performance review of VE on beta labs would be welcome [18:33:00] Project browsertests-UniversalLanguageSelector-language-browsertests.wmflabs.org-linux-firefox build #8: FAILURE in 4 min 56 sec: https://integration.wikimedia.org/ci/job/browsertests-UniversalLanguageSelector-language-browsertests.wmflabs.org-linux-firefox/8/ [18:33:01] amir.aharoni: Update jquery.uls from upstream [18:33:04] RoanKattouw: it's a gem. we have it set up so if I'm not mistaken you have an env var "HEADLESS" and it will Just Work. [18:33:10] OK [18:33:23] So if I export HEADLESS=true it should just start working? [18:33:32] Zeljko and Antoine probably wrote it down somewhere [18:34:25] Xvfb not found on your system (Headless::Exception) [18:34:29] Well I'm getting /somewhere/ :) [18:34:39] Project browsertests-Translate-sandbox.translatewiki.net-linux-firefox build #17: STILL FAILING in 2 min 21 sec: https://integration.wikimedia.org/ci/job/browsertests-Translate-sandbox.translatewiki.net-linux-firefox/17/ [18:34:58] RoanKattouw: wfm oddly enough. $ export HEADLESS=true, run a test, seems to be going [18:35:06] Holy crap it's running now [18:35:11] (I had to do apt-get install xvfb) [18:35:16] Project browsertests-ContentTranslation-language-stage.wmflabs.org-linux-firefox build #10: STILL FAILING in 4 min 43 sec: https://integration.wikimedia.org/ci/job/browsertests-ContentTranslation-language-stage.wmflabs.org-linux-firefox/10/ [18:35:35] RoanKattouw: test tools in Ruby tend to be pretty mature [18:35:52] and we have some sane mediawiki gems to manage them across our repos [18:36:55] oh, and I still want to kill those sleeps. [18:37:35] Yeah there's some sleeps lying around, some of them I wasn't able to remove easily [18:37:44] In some cases the sleep isn't necessary but in others it is [18:37:51] Well [18:37:58] "necessary" as in "if I remove it it breaks" [18:38:04] Project browsertests-CirrusSearch-test2.wikipedia.org-linux-firefox build #19: SUCCESS in 1 min 0 sec: https://integration.wikimedia.org/ci/job/browsertests-CirrusSearch-test2.wikipedia.org-linux-firefox/19/ [18:38:05] neverett: Bail early if another script is queueing jobs [18:38:39] yep. I just need to think about what exactly to wait for in those cases. basically those 4 sleeps are me saying "I'm tired of thinking about this" and moving on [18:39:05] Project browsertests-VisualEditor-en.wikipedia.beta.wmflabs.org-linux-firefox build #29: STILL FAILING in 26 min: https://integration.wikimedia.org/ci/job/browsertests-VisualEditor-en.wikipedia.beta.wmflabs.org-linux-firefox/29/ [18:40:04] Project browsertests-VisualEditor-test2.wikipedia.org-linux-firefox build #6: STILL FAILING in 27 min: https://integration.wikimedia.org/ci/job/browsertests-VisualEditor-test2.wikipedia.org-linux-firefox/6/ [18:40:06] something is still wrong with the WMF Jenkins build for VE [18:40:17] Yeah. :-( [18:41:06] might have to do with Jenkins slaves, I was talking to Antoine earlier today [18:41:26] because the failures cycle between massive and being OK [18:41:34] Project browsertests-Flow-test2.wikipedia.org-linux-firefox build #9: STILL FAILING in 6 min 30 sec: https://integration.wikimedia.org/ci/job/browsertests-Flow-test2.wikipedia.org-linux-firefox/9/ [18:42:07] Project browsertests-CentralAuth-test2.wikipedia.org-linux-firefox build #6: STILL FAILING in 3.4 sec: https://integration.wikimedia.org/ci/job/browsertests-CentralAuth-test2.wikipedia.org-linux-firefox/6/ [18:42:08] legoktm: Fix typo in message key [18:43:44] oh RoanKattouw one other thing I want to do with the VE tests is remove the dependency on article pages existing in the target wiki. we can do that via the API now [18:43:47] chrismcmahon: So once I finish this round of clean-up, the next thing I'd like to do (probably in collaboration with Krinkle|detached ) is come up with a way to run a subset of the tests against a local VE instance from Jenkins, so we can have pre-merge tests [18:43:52] chrismcmahon: Oooh nice [18:43:56] Yeah that bothered me [18:44:04] In my notes there's this rant about cursor.feature [18:44:16] RoanKattouw: exactly why use the API. we do this all over in the MobileFrontend tests as of recently [18:44:18] About how it hardcodes the user name, browser, page name and makes assumptions about the page's contents [18:45:16] RoanKattouw: https://www.mediawiki.org/wiki/Browser_testing/shared_features [18:46:36] chrismcmahon: OK so what other cool things are you guys working on that I should know about? [18:47:27] Project UploadWizard-api-commons.wikimedia.beta.wmflabs.org build #19: SUCCESS in 22 sec: https://integration.wikimedia.org/ci/job/UploadWizard-api-commons.wikimedia.beta.wmflabs.org/19/ [18:47:30] RoanKattouw: building from WMF Jenkins. first we're doing headless Firefox, then trying to add headless Chrome, then I'm negotiating a new deal with SauceLabs [18:47:46] Nice [18:47:59] Project browsertests-Flow-en.wikipedia.beta.wmflabs.org-linux-firefox build #9: STILL FAILING in 4 min 55 sec: https://integration.wikimedia.org/ci/job/browsertests-Flow-en.wikipedia.beta.wmflabs.org-linux-firefox/9/ [18:48:17] So that's browser tests still hitting beta labs and running post-merge, but being run from WMF Jenkins rather than Cloudbees? [18:48:30] RoanKattouw: Sauce will give us 10 simultaneous VMS with 10 admin users, but I don't have the credentials for the account quite yet. [18:48:33] Is this already semi-working in that wmf-insecte is reporting stuff here (mostly failures though)? [18:48:57] RoanKattouw: FF builds: https://integration.wikimedia.org/ci/view/BrowserTests/ [18:49:19] Nice [18:49:46] RoanKattouw: some builds are set up to take snapshots of FF at the moment of failure, but it's not in place yet for all of them [18:50:00] RoanKattouw: Sauce is always going to provide the best diagnostic tools. [18:50:21] Project browsertests-Translate-meta.wikimedia.org-linux-firefox build #17: STILL FAILING in 1 min 16 sec: https://integration.wikimedia.org/ci/job/browsertests-Translate-meta.wikimedia.org-linux-firefox/17/ [18:50:25] Right so it's still using Saucelabs VMs [18:50:37] But we're moving the management from Cloudbees to WMF Jenkins? [18:50:38] RoanKattouw: no, all of these are running FF headless. [18:50:45] OK [18:50:46] that you see on WMF Jenkins [18:50:49] Oh nice [18:51:08] So once that's working I'll be extremely close to my goal [18:51:25] All I'd need is to run against a localhost with an unmerged change checked out, rather than beta labs, and I'm in business [18:51:50] RoanKattouw: but yeah in the next probably couple of weeks we'll leave Cloudbees behind and do a combination of some tests locally headless on WMF Jenkins hosts and some tests hitting Sauce VMs [18:52:22] Project browsertests-MobileFrontend-test2.m.wikipedia.org-linux-firefox build #6: STILL FAILING in 29 min: https://integration.wikimedia.org/ci/job/browsertests-MobileFrontend-test2.m.wikipedia.org-linux-firefox/6/ [18:52:25] RoanKattouw: talk to the MF folks about hitting a local dev env, they've had that for a very long time [18:53:37] Project browsertests-CirrusSearch-en.wikipedia.beta.wmflabs.org-linux-firefox build #20: SUCCESS in 33 sec: https://integration.wikimedia.org/ci/job/browsertests-CirrusSearch-en.wikipedia.beta.wmflabs.org-linux-firefox/20/ [18:53:37] neverett: Bail early if another script is queueing jobs [18:54:11] Project browsertests-UploadWizard-commons.wikimedia.beta.wmflabs.org-linux-firefox build #6: STILL FAILING in 6.7 sec: https://integration.wikimedia.org/ci/job/browsertests-UploadWizard-commons.wikimedia.beta.wmflabs.org-linux-firefox/6/ [18:54:15] chrismcmahon: I have my local dev env set up now [18:54:19] So I can run things locally, which is good [18:54:29] Yippee, build fixed! [18:54:29] Project UploadWizard-api-commons.wikimedia.org build #12: FIXED in 24 sec: https://integration.wikimedia.org/ci/job/UploadWizard-api-commons.wikimedia.org/12/ [18:54:36] But I'd like Jenkins/Zuul to do that automatically for a subset of tests on every proposed change in Gerrit, blocking merge [18:55:18] So that when our devs make changes that break the browser tests (usually for some stupid reason like we changed a class name), we'll know immediately [18:55:38] and make ourselves responsible for fixing those things, taking the maintenance burden from you [18:56:20] we've been talking vaguely about something like that, but nobody has any concrete ideas about how to implement it [18:56:25] first things first [18:59:30] Yeah [18:59:56] It's my long term goal, I know I'm not gonna have it up and running next week :) [19:01:37] Project browsertests-WikiLove-en.wikipedia.beta.wmflabs.org-linux-firefox build #5: SUCCESS in 1 min 32 sec: https://integration.wikimedia.org/ci/job/browsertests-WikiLove-en.wikipedia.beta.wmflabs.org-linux-firefox/5/ [19:07:31] Project browsertests-qa-test2.wikipedia.org-linux-firefox build #9: SUCCESS in 9 min 27 sec: https://integration.wikimedia.org/ci/job/browsertests-qa-test2.wikipedia.org-linux-firefox/9/ [19:13:15] RoanKattouw: it probably won't even be all that long. things are moving pretty quickly with these recent advances. [19:31:58] Project browsertests-MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox build #6: STILL FAILING in 40 min: https://integration.wikimedia.org/ci/job/browsertests-MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox/6/ [19:38:00] chrismcmalunch: we have a bunch of unable to bind to locking port 7054 within 45 seconds [19:38:17] I guess that is caused by different browsertests running concurrently :-( [19:39:32] or maybe firefox just takes too long to startup :( [21:10:39] chrismcmahon et al: FYI the Compact Personal Bar beta feature breaks "Given I am logged in", because it puts :href=>/Special:UserLogout in a pop-up menu [21:10:57] yes, yes it does. [21:11:48] spagewmf: the other Winter thing isn't very nice either, the new tab format. [21:22:31] hashar: How would I go about updating the jenkins qunit job for VisualEditor to know that they will now depend on the Parsoid PHP extension? Is it trivially somewhere inside JJB? [21:24:20] (03PS1) 10BryanDavis: Use trigger publisher instead of trigger-builds builder [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/129822 [21:24:54] (03CR) 10jenkins-bot: [V: 04-1] Use trigger publisher instead of trigger-builds builder [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/129822 (owner: 10BryanDavis) [21:26:12] James_F: yeah there is a few examples. Does VE has any PHPUnit tests now ? [21:26:31] hashar: No, this is JS qunit. [21:27:20] (03PS2) 10BryanDavis: Use trigger publisher instead of trigger-builds builder [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/129822 [21:28:43] James_F: there is a bunch of examples in JJB config: mediawiki-extensions.yaml [21:28:52] example: [21:28:52] - '{name}-{ext-name}-qunit': [21:28:53] ext-name: Wikibase [21:28:53] dependencies: 'Diff,DataValues,DataTypes,WikibaseDataModel,Scribunto' [21:29:08] you could copy paste that [21:29:12] replace Wikibase with VisualEditor [21:29:15] then dependencies: Parsoid [21:29:18] that might work :] [21:29:27] too late for me to break it tonight though :-( [21:33:03] * James_F grins. [21:33:58] hashar: we'll break stuff on Monday [21:35:18] James_F: sorry :-( [21:35:38] James_F: but do ping somewhere in a bugzilla queue and will be happy to try it out monday. Or try to catch timo :) [21:35:51] chrismcmahon: jenkins job builder!!! [21:35:53] hashar: I'm writing the generic banana tester job template that you asked for. [21:36:02] chrismcmahon: will work on the unit testing tech talk monday morning [21:36:25] (03PS1) 10Jforrester: [WIP] Generic banana linter job template [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/129826 [21:36:38] James_F: I would like to set up a gerrit/zuul/jenkins instance in labs so folks can try their templates there [21:36:42] (03PS1) 10Jforrester: Add the Parsoid PHP extension as a dependency for VisualEditor's qunit test [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/129827 [21:36:47] * James_F nods. [21:36:49] hashar: ^^^ [21:36:54] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Generic banana linter job template [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/129826 (owner: 10Jforrester) [21:36:57] hashar: I can ask Krinkle|detached to review if you want? [21:37:02] James_F: got swamped with someZuul issues though this week. And of course super busy migrating the browsertests to our jenkins :D [21:37:17] hashar: Yeah, it's awesome to make so much progress. No worries. :-) [21:38:06] the VE browser tests are unstable though :-( [21:38:12] maybe a race conditions [21:38:13] I've noticed. [21:38:15] * James_F nods. [21:38:18] I blame Timo. ;-) [21:38:19] or the browser taking too long to boot / respond whatever [21:38:25] gotta debug that with zeljkof next week [21:38:44] and we really want to phaseout cloudbees entirely. [21:39:18] That will be great. [21:43:51] hashar: I should have info for a new SauceLabs account real soon now. we should have 10 simultaneous VMs for it. [21:44:27] chrismcmahon: great! [21:44:44] chrismcmahon: I want to get the existing jenkins templates to support multiple os / browser easily [21:44:57] so people can add a new combinaison by simply adding one or two lines at most [21:45:16] will have to integrate sauce of course, but I am not worried about it :] [21:47:10] hashar: I think Sauce will be great for two reasons: testing IE sure, but the diagnostic tools are great: snapshots, a video replay, console logs, are all really helpful to figure out problems [21:47:31] hashar: for example, I could see sending all newly written tests to Sauce first. [21:47:33] (03CR) 10Hashar: [WIP] Generic banana linter job template (031 comment) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/129826 (owner: 10Jforrester) [21:48:04] James_F: you will need to define the commands needed to run banana (I guess it is some magic grunt command :D) [21:48:22] James_F: commented on your change. You can look at macro.yaml for some custom builder examples [21:48:43] chrismcmahon: the idea was more or less to use phantomjs because it is super fast [21:49:03] chrismcmahon: then if it pass, trigger different browser/os combianison in Sauce [21:49:25] my idea was to avoid running a bunch of sauce jobs when we know the tests are not going to pass (via phantomjs) [21:49:37] aka fails early [21:49:48] hashar: but so many fail in phantomjs because they need a real browser [21:50:09] eh, we'll work it out [21:51:50] firefox headless might be a good fail early tests [21:51:56] then if it pass we launch the rest [21:56:52] chrismcmahon: James_F: I off to rest. Follow up on monday! [21:57:22] James_F: if you have doc regarding banana push it to me and I can continue based on whatever you finished this afternoon then we can catch up monday [22:29:00] (03PS2) 10Jforrester: [WIP] Generic banana linter job template [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/129826 [22:29:26] 3Wikimedia / 3Continuous integration: Create generic banana jenkins job template for comparing en.json and qqq.json entries - 10https://bugzilla.wikimedia.org/64045#c2 (10Gerrit Notification Bot) Change 129826 had a related patch set uploaded by Jforrester: [WIP] Generic banana linter job template https://g... [22:30:03] (03CR) 10Jforrester: [WIP] Generic banana linter job template (031 comment) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/129826 (owner: 10Jforrester) [22:40:13] 3Wikimedia / 3Continuous integration: Create generic banana jenkins job template for comparing en.json and qqq.json entries - 10https://bugzilla.wikimedia.org/64045 (10James Forrester) a:3James Forrester [23:34:56] 3Wikimedia / 3Continuous integration: Create generic banana jenkins job template for comparing en.json and qqq.json entries - 10https://bugzilla.wikimedia.org/64045#c3 (10Krinkle) Why as a separate job template with its own working copy and grunt pipeline? I was going to phase out the wmfgrunt madness, not i... [23:36:16] 3Wikimedia / 3Continuous integration: Create generic banana jenkins job template for comparing en.json and qqq.json entries - 10https://bugzilla.wikimedia.org/64045#c4 (10Krinkle) Ah, never mind. I overreacted based on the code in this change: https://gerrit.wikimedia.org/r/#/c/129826/2/macro.yaml Made it... [23:58:19] Krinkle: Re. 129826 – how do you want this to work instead? [23:58:38] the way we did it in mwcore, ve and oojsui [23:58:58] Krinkle: hashar explicitly said he didn't want to do that.