[03:10:00] Project MultimediaViewer-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_10 build #10: SUCCESS in 2 min 42 sec: https://wmf.ci.cloudbees.com/job/MultimediaViewer-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_10/10/ [03:28:30] Project UniversalLanguageSelector-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_10 build #198: STILL FAILING in 25 min: https://wmf.ci.cloudbees.com/job/UniversalLanguageSelector-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_10/198/ [03:28:30] l10n-bot: Localisation updates from https://translatewiki.net. [03:43:14] Project browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_9 build #730: FAILURE in 33 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_9/730/ [03:58:23] Project browsertests-test2.wikipedia.org-windows-internet_explorer_10 build #651: STILL FAILING in 29 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-windows-internet_explorer_10/651/ [04:06:11] Project Flow-test2.wikipedia.org-linux-firefox build #254: STILL FAILING in 7 min 45 sec: https://wmf.ci.cloudbees.com/job/Flow-test2.wikipedia.org-linux-firefox/254/ [04:13:55] Yippee, build fixed! [04:13:55] Project VisualEditor-test2.wikipedia.org-linux-firefox build #528: FIXED in 30 min: https://wmf.ci.cloudbees.com/job/VisualEditor-test2.wikipedia.org-linux-firefox/528/ [04:13:56] * matma.rex: Whitelist Opera 15+ [04:13:57] * krenair: Update beta warning to refer to 'Switch to source editing' [04:13:57] * krenair: Update wikitext-warning to refer to 'Switch to source editing' [04:13:58] * krenair: Remove edit tab from the DOM if it's hidden [04:13:58] * krenair: On file pages, only replace the (local) image description when saving [04:13:59] * krenair: Use OOUI confirmation dialog rather than native confirm() for switching to source editing [04:13:59] * esanders: Initialise save panel on 'ready' so focus works [04:14:00] * esanders: Fix styling on save dialog [04:14:00] * cmcmahon: [browser test] use css for Template selector [04:14:01] * krinklemail: MWTransclusionDialog: Remove setMode() call from teardown() [04:14:01] * l10n-bot: Localisation updates from https://translatewiki.net. [04:14:02] * roan.kattouw: Set flags for confirm dialog buttons [04:14:02] * roan.kattouw: Set flags for confirm dialog buttons for switching to source mode [04:14:03] * moriel: Image model and the media edit dialog [04:15:18] Project Flow-en.wikipedia.beta.wmflabs.org-linux-chrome build #438: SUCCESS in 9 min 5 sec: https://wmf.ci.cloudbees.com/job/Flow-en.wikipedia.beta.wmflabs.org-linux-chrome/438/ [04:25:16] Project UploadWizard-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_9 build #773: STILL FAILING in 11 min: https://wmf.ci.cloudbees.com/job/UploadWizard-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_9/773/ [04:25:17] * rillke: Wait until iframe is fully loaded before submitting form [04:25:17] * rillke: UploadWizard: Check for duplicate titles [04:32:49] Project Flow-test2.wikipedia.org-linux-chrome build #288: STILL FAILING in 7 min 30 sec: https://wmf.ci.cloudbees.com/job/Flow-test2.wikipedia.org-linux-chrome/288/ [04:35:15] Project browsertests-en.wikipedia.beta.wmflabs.org-linux-firefox build #840: SUCCESS in 19 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-linux-firefox/840/ [04:39:11] Hello! I'm new here and I'd like to help with selenium browsertests if it's needed. Is there anything for newcomers? I've found only one bug nobody work on (https://bugzilla.wikimedia.org/show_bug.cgi?id=60347) and it's setup seems too complicated to start. [04:41:16] Project UploadWizard-commons.wikimedia.beta.wmflabs.org-linux-chrome build #838: SUCCESS in 8 min 26 sec: https://wmf.ci.cloudbees.com/job/UploadWizard-commons.wikimedia.beta.wmflabs.org-linux-chrome/838/ [04:41:17] * rillke: Wait until iframe is fully loaded before submitting form [04:41:17] * rillke: UploadWizard: Check for duplicate titles [05:16:05] Yippee, build fixed! [05:16:05] Project MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome build #456: FIXED in 34 min: https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/456/ [05:16:06] * jrobson: Add iOS hover bug fix [05:16:06] * jrobson: Hygiene: Use truncated text class in overlay headers [05:16:07] * maxsem.wiki: mobileview: handle pages redirecting to special/media [05:16:07] * jrobson: Fix VE performance by cleaning up ui.less now universal header [05:16:08] * jrobson: Hygiene: Browser test cleanup [05:16:08] * l10n-bot: Localisation updates from https://translatewiki.net. [05:49:34] Project MultimediaViewer-en.wikipedia.beta.wmflabs.org-linux-firefox build #239: SUCCESS in 1 min 49 sec: https://wmf.ci.cloudbees.com/job/MultimediaViewer-en.wikipedia.beta.wmflabs.org-linux-firefox/239/ [06:00:45] Yippee, build fixed! [06:00:46] Project VisualEditor-test2.wikipedia.org-linux-chrome build #435: FIXED in 44 min: https://wmf.ci.cloudbees.com/job/VisualEditor-test2.wikipedia.org-linux-chrome/435/ [06:00:46] * matma.rex: Whitelist Opera 15+ [06:00:47] * krenair: Update beta warning to refer to 'Switch to source editing' [06:00:47] * krenair: Update wikitext-warning to refer to 'Switch to source editing' [06:00:48] * krenair: Remove edit tab from the DOM if it's hidden [06:00:48] * krenair: On file pages, only replace the (local) image description when saving [06:00:49] * krenair: Use OOUI confirmation dialog rather than native confirm() for switching to source editing [06:00:49] * esanders: Initialise save panel on 'ready' so focus works [06:00:50] * esanders: Fix styling on save dialog [06:00:50] * cmcmahon: [browser test] use css for Template selector [06:00:51] * krinklemail: MWTransclusionDialog: Remove setMode() call from teardown() [06:00:51] * l10n-bot: Localisation updates from https://translatewiki.net. [06:00:52] * roan.kattouw: Set flags for confirm dialog buttons [06:00:52] * roan.kattouw: Set flags for confirm dialog buttons for switching to source mode [06:00:53] * moriel: Image model and the media edit dialog [06:12:58] Yippee, build fixed! [06:12:58] Project UploadWizard-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_10 build #660: FIXED in 12 min: https://wmf.ci.cloudbees.com/job/UploadWizard-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_10/660/ [06:12:59] rillke: UploadWizard: Check for duplicate titles [06:33:21] Yippee, build fixed! [06:33:21] Project browsertests-en.wikipedia.beta.wmflabs.org-linux-chrome build #857: FIXED in 20 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-linux-chrome/857/ [06:35:28] Project MultimediaViewer-en.wikipedia.beta.wmflabs.org-linux-chrome build #11: SUCCESS in 2 min 6 sec: https://wmf.ci.cloudbees.com/job/MultimediaViewer-en.wikipedia.beta.wmflabs.org-linux-chrome/11/ [06:37:18] Project MultimediaViewer-mediawiki.org-linux-firefox build #69: SUCCESS in 2 min 38 sec: https://wmf.ci.cloudbees.com/job/MultimediaViewer-mediawiki.org-linux-firefox/69/ [06:37:26] Project WikiLove-en.wikipedia.beta.wmflabs.org-linux-firefox build #180: SUCCESS in 1 min 58 sec: https://wmf.ci.cloudbees.com/job/WikiLove-en.wikipedia.beta.wmflabs.org-linux-firefox/180/ [06:37:35] Project ZeroRatedMobileAccess-en.m.wikipedia.org-linux-phantomjs build #184: STILL FAILING in 16 sec: https://wmf.ci.cloudbees.com/job/ZeroRatedMobileAccess-en.m.wikipedia.org-linux-phantomjs/184/ [06:46:31] Project Flow-en.wikipedia.beta.wmflabs.org-linux-firefox build #438: SUCCESS in 9 min 4 sec: https://wmf.ci.cloudbees.com/job/Flow-en.wikipedia.beta.wmflabs.org-linux-firefox/438/ [06:57:38] Project browsertests-test2.wikipedia.org-linux-chrome build #1090: STILL FAILING in 20 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-linux-chrome/1090/ [07:29:34] Yippee, build fixed! [07:29:34] Project MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox build #573: FIXED in 43 min: https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox/573/ [07:29:35] * jrobson: Hygiene: Use truncated text class in overlay headers [07:29:35] * jrobson: Hygiene: Browser test cleanup [07:29:36] * l10n-bot: Localisation updates from https://translatewiki.net. [07:32:21] Project MultimediaViewer-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_9 build #11: SUCCESS in 2 min 47 sec: https://wmf.ci.cloudbees.com/job/MultimediaViewer-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_9/11/ [07:34:08] Project MobileFrontend-test2.m.wikipedia.org-linux-firefox build #448: STILL FAILING in 36 min: https://wmf.ci.cloudbees.com/job/MobileFrontend-test2.m.wikipedia.org-linux-firefox/448/ [07:34:08] * jrobson: Hygiene: Use truncated text class in overlay headers [07:34:09] * jrobson: Hygiene: Browser test cleanup [07:34:09] * l10n-bot: Localisation updates from https://translatewiki.net. [07:44:33] Project MobileFrontend-en.m.wikipedia.org-linux-firefox build #483: SUCCESS in 10 min: https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.org-linux-firefox/483/ [07:44:34] * jrobson: Hygiene: Use truncated text class in overlay headers [07:44:34] * jrobson: Hygiene: Browser test cleanup [07:52:13] Project browsertests-test2.wikipedia.org-linux-firefox build #1067: STILL FAILING in 19 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-linux-firefox/1067/ [07:52:54] Yippee, build fixed! [07:52:55] Project UploadWizard-commons.wikimedia.beta.wmflabs.org-linux-firefox build #796: FIXED in 8 min 20 sec: https://wmf.ci.cloudbees.com/job/UploadWizard-commons.wikimedia.beta.wmflabs.org-linux-firefox/796/ [07:52:55] * mtraceur: jshint fixes for mw.UploadWizardDeed.js [07:52:56] * rillke: UploadWizard: Check for duplicate titles [07:57:17] (03PS1) 10Hashar: Flake8 job for analytics/multimedia.git [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/134306 [07:57:42] (03CR) 10Hashar: [C: 032] Flake8 job for analytics/multimedia.git [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/134306 (owner: 10Hashar) [07:58:38] (03Merged) 10jenkins-bot: Flake8 job for analytics/multimedia.git [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/134306 (owner: 10Hashar) [07:59:48] (03PS1) 10Hashar: Flake8 job for analytics/multimedia.git [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/134307 [07:59:58] (03PS2) 10Hashar: Flake8 job for analytics/multimedia.git [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/134307 [08:00:22] (03CR) 10Hashar: [C: 032] Flake8 job for analytics/multimedia.git [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/134307 (owner: 10Hashar) [08:00:30] (03Merged) 10jenkins-bot: Flake8 job for analytics/multimedia.git [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/134307 (owner: 10Hashar) [08:24:54] Yippee, build fixed! [08:24:54] Project browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_10 build #662: FIXED in 32 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_10/662/ [08:25:48] Project UniversalLanguageSelector-language-browsertests.wmflabs.org-linux-firefox build #158: STILL FAILING in 53 sec: https://wmf.ci.cloudbees.com/job/UniversalLanguageSelector-language-browsertests.wmflabs.org-linux-firefox/158/ [08:25:49] yeahhhh [08:27:04] Project UploadWizard-api-commons.wikimedia.beta.wmflabs.org build #488: SUCCESS in 1 min 14 sec: https://wmf.ci.cloudbees.com/job/UploadWizard-api-commons.wikimedia.beta.wmflabs.org/488/ [08:27:05] mtraceur: jshint fixes for mw.UploadWizardDeed.js [08:28:17] Project UploadWizard-api-commons.wikimedia.org build #404: SUCCESS in 1 min 13 sec: https://wmf.ci.cloudbees.com/job/UploadWizard-api-commons.wikimedia.org/404/ [08:28:18] mtraceur: jshint fixes for mw.UploadWizardDeed.js [08:30:54] Project browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_8 build #697: STILL FAILING in 37 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_8/697/ [08:58:11] (03PS1) 10Hashar: Flake8 job for analytics/wp-zero [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/134312 [09:01:38] (03PS1) 10Hashar: Flake8 job for analytics/wp-zero.git (non voting) [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/134313 [09:03:58] (03CR) 10Hashar: [C: 032] "That will run the flake8 job for analytics/wp-zero.git" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/134313 (owner: 10Hashar) [09:04:06] (03Merged) 10jenkins-bot: Flake8 job for analytics/wp-zero.git (non voting) [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/134313 (owner: 10Hashar) [09:04:38] (03CR) 10Hashar: [C: 032] "Defines the flake8 job for analytics/wp-zero.git :-)" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/134312 (owner: 10Hashar) [09:05:36] (03Merged) 10jenkins-bot: Flake8 job for analytics/wp-zero [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/134312 (owner: 10Hashar) [12:03:49] (03PS1) 10Hashar: Flake8 job for analytics/wp-geowiki [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/134336 [12:05:34] (03PS1) 10Hashar: Flake8 job for analytics/geowiki [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/134337 [12:08:25] (03CR) 10Hashar: [C: 032] "I have deployed the analytics-geowiki-tox-flake8 job." [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/134336 (owner: 10Hashar) [12:09:02] (03CR) 10Hashar: [C: 032] "Triggers analytics-geowiki-tox-flake8 albeit non voting till flake8 issues are fixed." [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/134337 (owner: 10Hashar) [12:09:10] (03Merged) 10jenkins-bot: Flake8 job for analytics/geowiki [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/134337 (owner: 10Hashar) [12:09:13] (03Merged) 10jenkins-bot: Flake8 job for analytics/wp-geowiki [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/134336 (owner: 10Hashar) [12:49:29] Project UploadWizard-api-commons.wikimedia.beta.wmflabs.org build #489: SUCCESS in 1 min 20 sec: https://wmf.ci.cloudbees.com/job/UploadWizard-api-commons.wikimedia.beta.wmflabs.org/489/ [12:56:25] Project UploadWizard-api-commons.wikimedia.org build #405: SUCCESS in 1 min 18 sec: https://wmf.ci.cloudbees.com/job/UploadWizard-api-commons.wikimedia.org/405/ [13:13:13] (03PS1) 10Krinkle: JSHint: Upgrade from v2.4.4 to v2.5.0 [integration/jenkins] - 10https://gerrit.wikimedia.org/r/134351 [13:13:16] (03CR) 10jenkins-bot: [V: 04-1] JSHint: Upgrade from v2.4.4 to v2.5.0 [integration/jenkins] - 10https://gerrit.wikimedia.org/r/134351 (owner: 10Krinkle) [13:14:35] (03PS2) 10Krinkle: JSHint: Upgrade from v2.4.4 to v2.5.0 [integration/jenkins] - 10https://gerrit.wikimedia.org/r/134351 [13:16:57] (03CR) 10Hashar: "Nice :-)" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/131338 (owner: 10Krinkle) [13:18:55] (03CR) 10Krinkle: [C: 032] JSHint: Upgrade from v2.4.4 to v2.5.0 [integration/jenkins] - 10https://gerrit.wikimedia.org/r/134351 (owner: 10Krinkle) [13:18:58] (03Merged) 10jenkins-bot: JSHint: Upgrade from v2.4.4 to v2.5.0 [integration/jenkins] - 10https://gerrit.wikimedia.org/r/134351 (owner: 10Krinkle) [13:34:50] (03CR) 10Phuedx: "Ping Hashar/Krinkle." [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/132211 (owner: 10Phuedx) [13:34:54] (03PS2) 10Hashar: Adds to ProofreadPage a dependance to LabeledSectionTranclusion [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/134204 (owner: 10Tpt) [13:36:21] (03CR) 10Hashar: [C: 032] "Deployed mwext-ProofreadPage-testextensions-master" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/134204 (owner: 10Tpt) [13:37:04] (03Merged) 10jenkins-bot: Adds to ProofreadPage a dependance to LabeledSectionTranclusion [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/134204 (owner: 10Tpt) [13:38:48] (03PS3) 10Hashar: Add the mwext-GettingStarted-testextensions-master job [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/132211 (owner: 10Phuedx) [13:40:16] (03CR) 10Hashar: [C: 032] "Updated job. Will add triggers in Zuul as well." [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/132211 (owner: 10Phuedx) [13:40:43] (03PS1) 10Hashar: Trigger GettingStarted tests jobs [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/134353 [13:40:51] (03CR) 10Hashar: "Zuul change is https://gerrit.wikimedia.org/r/134353" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/132211 (owner: 10Phuedx) [13:41:00] (03Merged) 10jenkins-bot: Add the mwext-GettingStarted-testextensions-master job [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/132211 (owner: 10Phuedx) [13:41:13] (03CR) 10Hashar: [C: 032] "Job added by https://gerrit.wikimedia.org/r/#/c/132211/" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/134353 (owner: 10Hashar) [13:41:21] (03Merged) 10jenkins-bot: Trigger GettingStarted tests jobs [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/134353 (owner: 10Hashar) [13:42:19] (03CR) 10Phuedx: "Thanks Hashar. I was completely unaware of having to change the Zuul config!" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/132211 (owner: 10Phuedx) [14:01:23] (03CR) 10Hashar: "I found out most people don't know about recheck so I thought highlighting it on check pipelines would advertise it nicely. Any suggestio" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/134098 (https://bugzilla.wikimedia.org/50327) (owner: 10Hashar) [14:13:59] (03PS2) 10Krinkle: Report pipeline name in build status message [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/134098 (https://bugzilla.wikimedia.org/50327) (owner: 10Hashar) [14:20:25] (03PS3) 10Krinkle: Report pipeline name in build status message [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/134098 (https://bugzilla.wikimedia.org/50327) (owner: 10Hashar) [14:20:37] (03CR) 10Krinkle: "Something like this?" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/134098 (https://bugzilla.wikimedia.org/50327) (owner: 10Hashar) [14:29:41] Krinkle: sounds good :-] [14:29:52] Krinkle: maybe we could add a link to a wiki page later on [14:31:44] (03CR) 10Hashar: [C: 031] "I wanted to have each check pipelines to have a slightly different messages to help end users. Maybe I overthought it." [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/134098 (https://bugzilla.wikimedia.org/50327) (owner: 10Hashar) [14:47:32] (03CR) 10Krinkle: [C: 031] Report pipeline name in build status message [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/134098 (https://bugzilla.wikimedia.org/50327) (owner: 10Hashar) [14:47:45] Krinkle: lets deploy it :-) [14:47:51] Go for it [14:48:00] (03CR) 10Hashar: [C: 032] "Good enough for now. We can always amend later on :-)" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/134098 (https://bugzilla.wikimedia.org/50327) (owner: 10Hashar) [14:48:13] (03Merged) 10jenkins-bot: Report pipeline name in build status message [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/134098 (https://bugzilla.wikimedia.org/50327) (owner: 10Hashar) [14:48:14] Krinkle: your comment about jshint confused me a ton :-( [14:48:28] I was expecting it to merge the .jshintrc content with whatever defaults ship with jshint [14:48:39] we had a bunch of repositories providing empty jshintrc, aka {} [14:48:51] so I guess that disabled a ton of check on those repos :-( [14:49:02] Yes, I did tell you many times how much I dislike empty object files [14:49:09] Don't worry though, I got rid of each one [14:49:14] \o: [14:49:16] \O/ [14:49:17] :-D [14:49:28] actually, empty object might be an exception [14:49:33] That makes it use the defaults [14:49:41] we use that to undo the docroot/.jshintrc leak [14:49:59] ohh [14:50:08] 3Wikimedia / 3Continuous integration: Zuul: should report pipeline name in build status message - 10https://bugzilla.wikimedia.org/50327#c9 (10Antoine "hashar" Musso) 5PAT>3RES/FIX Change deployed and Zuul reloaded. We can tweak the message latter on since good placeholders are already in place. [14:50:11] but it's still a bad practice because you don't want to use magic "defaults" as your jshintrc config. That makes it unusable in IDEs', grunt, command line etc. [14:50:47] Because then whenever someone uses a different jshint version, or has defaults in in ~/.jshintrc, or in their editor, things don't work as they should. [14:50:54] :-( [14:50:57] Like jscs or phpcs, you have a complete config and that's the one used. [14:51:36] on a different subject, have you had the opportunity to read the rather long RFC for test isolation? [15:02:00] (03PS1) 10Hashar: mwext-OggHandler-jslint is now voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/134368 (https://bugzilla.wikimedia.org/65487) [15:02:46] (03CR) 10Hashar: [C: 032] mwext-OggHandler-jslint is now voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/134368 (https://bugzilla.wikimedia.org/65487) (owner: 10Hashar) [15:03:11] (03Merged) 10jenkins-bot: mwext-OggHandler-jslint is now voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/134368 (https://bugzilla.wikimedia.org/65487) (owner: 10Hashar) [15:22:16] hashar: which RFC? [15:22:40] greg-g: a draft I wrote to isolate our jenkins tests [15:22:58] only ori and timo are cced to it though :] [15:23:14] ahh, I was looking at https://www.mediawiki.org/wiki/Requests_for_comment and couldn't find it [15:23:36] shared in google drive with your @wikimedia email [15:24:01] ty [15:29:58] hashar: wow, SWOT analyses! [15:30:08] yeah hmm [15:30:18] Haven't seen/done those in a long time :) [15:30:22] I am also missing a few pyramids [16:00:19] greg-g: joining [16:05:41] (03PS1) 10Hashar: mw-sort-wmf-branches: sort wmf branchs numerically [integration/jenkins] - 10https://gerrit.wikimedia.org/r/134376 (https://bugzilla.wikimedia.org/62509) [16:06:56] (03PS2) 10Hashar: mw-sort-wmf-branches: sort wmf branchs numerically [integration/jenkins] - 10https://gerrit.wikimedia.org/r/134376 (https://bugzilla.wikimedia.org/62509) [16:07:16] bd808: if you have any spare cycles to review my lame python code : https://gerrit.wikimedia.org/r/#/c/134376/ :-D [16:07:23] that is for chris [16:07:30] (03PS3) 10Hashar: mw-sort-wmf-branches: sort wmf branchs numerically [integration/jenkins] - 10https://gerrit.wikimedia.org/r/134376 (https://bugzilla.wikimedia.org/62509) [16:10:15] hasharConfCall: Yeah I'll look at it. I think I have something similar in scap somewhere [16:19:27] (03CR) 10Hashar: [C: 032] mw-sort-wmf-branches: sort wmf branchs numerically [integration/jenkins] - 10https://gerrit.wikimedia.org/r/134376 (https://bugzilla.wikimedia.org/62509) (owner: 10Hashar) [16:19:32] (03Merged) 10jenkins-bot: mw-sort-wmf-branches: sort wmf branchs numerically [integration/jenkins] - 10https://gerrit.wikimedia.org/r/134376 (https://bugzilla.wikimedia.org/62509) (owner: 10Hashar) [16:31:15] bd808: will have to look at that git caching as well [16:31:25] bd808: family back so I am off for now [16:31:34] hasharConfCall: Cool. THanks. [16:32:48] git + memcached seems like a good post dinner activity :-] [16:32:52] * hasharConfCall waves [16:50:30] (03CR) 10BryanDavis: mw-sort-wmf-branches: sort wmf branchs numerically (031 comment) [integration/jenkins] - 10https://gerrit.wikimedia.org/r/134376 (https://bugzilla.wikimedia.org/62509) (owner: 10Hashar) [16:58:47] (03PS1) 10BryanDavis: mw-sort-wmf-branches: simplify implementation [integration/jenkins] - 10https://gerrit.wikimedia.org/r/134385 [18:09:47] Project MultimediaViewer-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_10 build #11: SUCCESS in 2 min 28 sec: https://wmf.ci.cloudbees.com/job/MultimediaViewer-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_10/11/ [18:09:48] krinklemail: Use example.{com,net,org} instead of proprietary domains [18:32:24] Project UniversalLanguageSelector-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_10 build #199: STILL FAILING in 29 min: https://wmf.ci.cloudbees.com/job/UniversalLanguageSelector-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_10/199/ [18:47:08] Project browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_9 build #731: STILL FAILING in 37 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_9/731/ [19:02:56] Project browsertests-test2.wikipedia.org-windows-internet_explorer_10 build #652: STILL FAILING in 30 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-windows-internet_explorer_10/652/ [19:11:03] Project Flow-test2.wikipedia.org-linux-firefox build #255: STILL FAILING in 8 min 5 sec: https://wmf.ci.cloudbees.com/job/Flow-test2.wikipedia.org-linux-firefox/255/ [19:19:11] Project VisualEditor-test2.wikipedia.org-linux-firefox build #529: FAILURE in 32 min: https://wmf.ci.cloudbees.com/job/VisualEditor-test2.wikipedia.org-linux-firefox/529/ [19:20:23] Project Flow-en.wikipedia.beta.wmflabs.org-linux-chrome build #439: SUCCESS in 9 min 18 sec: https://wmf.ci.cloudbees.com/job/Flow-en.wikipedia.beta.wmflabs.org-linux-chrome/439/ [19:20:23] l10n-bot: Localisation updates from https://translatewiki.net. [19:33:18] Yippee, build fixed! [19:33:19] Project UploadWizard-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_9 build #774: FIXED in 14 min: https://wmf.ci.cloudbees.com/job/UploadWizard-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_9/774/ [19:33:19] * mtraceur: jshint fixes for mw.UploadWizardDeed.js [19:33:20] * l10n-bot: Localisation updates from https://translatewiki.net. [19:37:22] aude: What file did you need touched? [19:39:44] extensions/Wikidata/extensions/Wikibase/lib/resources/wikibase.utilities/wikibase.utilities.GuidGenerator.js [19:39:58] it looks like it was updated a couple days ago, so should not be a problem [19:40:28] and then the table of contents is unstyled on http://wikidata.beta.wmflabs.org/wiki/Q2558 [19:41:00] Project Flow-test2.wikipedia.org-linux-chrome build #289: STILL FAILING in 7 min 41 sec: https://wmf.ci.cloudbees.com/job/Flow-test2.wikipedia.org-linux-chrome/289/ [19:41:00] l10n-bot: Localisation updates from https://translatewiki.net. [19:41:13] i get "TypeError: invalid 'in' operand obj" when adding a string [19:41:52] aude: Touched and scapped [19:41:59] Project browsertests-en.wikipedia.beta.wmflabs.org-linux-firefox build #841: SUCCESS in 21 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-linux-firefox/841/ [19:42:00] ok [19:42:19] i wonder why i don't have permission now [19:42:22] always did [19:42:48] I did `sudo -u mwdeploy -- touch extensions/Wikidata/extensions/Wikibase/lib/resources/wikibase.utilities/wikibase.utilities.GuidGenerator.js` [19:43:03] Followed by `/usr/local/bin/wmf-beta-scap` [19:43:03] that's what i tried [19:43:42] "Sorry, user aude is not allowed to execute ...." [19:44:05] Hmm.. The sudo rules want you to bin in the wikidev group [19:44:13] I may have done that... [19:44:40] Oh. It would come from using the production puppet rules [19:45:11] aude: I think you may have the problem where your ldap account is too old [19:45:19] You are in the svn group rather than wikidev [19:45:22] oh [19:45:27] how do we fix it? [19:46:06] `sudo sudo -u mwdeploy ...`? [19:47:17] nope [19:48:20] I guess we need to add a realm==labs clause to modules/mediawiki/manifests/users.pp to grant svn the same rights as wikidev [19:48:52] Open a bug and assign to me. It should be an easyish fix. [19:49:08] * bd808 needs to go eat [19:49:12] ok [19:49:50] Project UploadWizard-commons.wikimedia.beta.wmflabs.org-linux-chrome build #839: SUCCESS in 8 min 47 sec: https://wmf.ci.cloudbees.com/job/UploadWizard-commons.wikimedia.beta.wmflabs.org-linux-chrome/839/ [19:49:50] * mtraceur: jshint fixes for mw.UploadWizardDeed.js [19:49:51] * l10n-bot: Localisation updates from https://translatewiki.net. [19:51:33] https://bugzilla.wikimedia.org/show_bug.cgi?id=65548 [19:57:45] (03PS1) 10Hashar: mw-api-siteinfo: compat with requests 0.8.2 [integration/jenkins] - 10https://gerrit.wikimedia.org/r/134477 [19:58:01] (03CR) 10Hashar: [C: 032] mw-api-siteinfo: compat with requests 0.8.2 [integration/jenkins] - 10https://gerrit.wikimedia.org/r/134477 (owner: 10Hashar) [19:58:04] (03Merged) 10jenkins-bot: mw-api-siteinfo: compat with requests 0.8.2 [integration/jenkins] - 10https://gerrit.wikimedia.org/r/134477 (owner: 10Hashar) [20:03:43] chrismcmahon: heeyo :-) [20:05:22] hi hashar [20:05:50] I am testing my patch to get the browser test to checkout whatever branch is used on the target wiki [20:06:17] ok... [20:06:38] using browsertests-CentralAuth-test2.wikipedia.org-linux-firefox as a sandbox :-] [20:06:44] I removed the email notification [20:07:08] hashar: sounds good to me [20:10:11] chrismcmahon: bah CentralAuth doesn't even have a tests/browser directory hehe [20:10:18] but at least [20:10:18] https://integration.wikimedia.org/ci/job/browsertests-CentralAuth-test2.wikipedia.org-linux-firefox/60/console [20:10:23] * hashar managed to fetch the wmf branch [20:10:28] git checkout -f wmf/1.24wmf5 [20:10:33] ha. nice [20:11:22] (03PS2) 10Hashar: Get mw branch from target URL and check it out [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/134236 (https://bugzilla.wikimedia.org/62509) [20:11:42] (03CR) 10Hashar: "just checkout the branch instead of origin/... Git is smart enough." [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/134236 (https://bugzilla.wikimedia.org/62509) (owner: 10Hashar) [20:13:36] testing browsertests-WikiLove-en.wikipedia.beta.wmflabs.org-linux-firefox :D [20:14:06] it uses master \O/ [20:16:08] chrismcmahon: I am refreshing all the jobs to use the proper branch. [20:16:30] (03CR) 10Hashar: [C: 032] "Updated all jobs. A few tests show that it seems to work properly." [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/134236 (https://bugzilla.wikimedia.org/62509) (owner: 10Hashar) [20:17:20] (03Merged) 10jenkins-bot: Get mw branch from target URL and check it out [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/134236 (https://bugzilla.wikimedia.org/62509) (owner: 10Hashar) [20:17:25] aharhgh [20:17:33] of course qa/browsertests.git does not have wmf branches :/ [20:26:21] Project MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome build #457: FAILURE in 36 min: https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/457/ [20:26:22] * jgonera: Regression: Fix styling of page lists [20:26:22] * jgonera: Fix margins in page list and search [20:26:23] * florian.schmidt.welzow: Add check for permission to create a new account [20:26:23] * jgonera: Fix trailing whitespace check in pre-commit [20:26:24] * jrobson: Fix edit link when VisualEditor is not available [20:26:24] * l10n-bot: Localisation updates from https://translatewiki.net. [20:27:46] (03PS1) 10Hashar: Fallback to master branch when test repo miss branch [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/134483 (https://bugzilla.wikimedia.org/62509) [20:28:28] (03CR) 10Hashar: [C: 032] "That let us fallback to 'master' whenever the git repo is missing wmf branches." [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/134483 (https://bugzilla.wikimedia.org/62509) (owner: 10Hashar) [20:29:06] (03Merged) 10jenkins-bot: Fallback to master branch when test repo miss branch [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/134483 (https://bugzilla.wikimedia.org/62509) (owner: 10Hashar) [20:29:55] (03PS1) 10Krinkle: Create rcstream-pep8 and rcstream-pyflakes jobs [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/134484 [20:30:19] 3Wikimedia / 3Quality Assurance: investigate updating test2 Jenkins builds weekly to pull by branch - 10https://bugzilla.wikimedia.org/62509#c21 (10Antoine "hashar" Musso) 5PAT>3ASS I tested it on a few change and it seems to be working fine. The qa/browsertests.git is missing wmf branches, so I have ad... [20:31:49] chrismcmahon: some more bike shed for you, we could use a mailing list to send browsertests notifications too :-) I filled a bug for it https://bugzilla.wikimedia.org/show_bug.cgi?id=64610 [20:32:06] not sure whether it is a good idea nor which name to give it [20:32:25] (03CR) 10Krinkle: [C: 032] "Deployed rcstream-pep8 and rcstream-pyflakes." [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/134484 (owner: 10Krinkle) [20:32:52] (03Merged) 10jenkins-bot: Create rcstream-pep8 and rcstream-pyflakes jobs [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/134484 (owner: 10Krinkle) [20:34:02] bd808: $wgDebugLogFile = 'php://stdout'; :-))))))) [20:34:10] bd808: in eval.php that is a nice trick [20:34:20] (03PS1) 10Krinkle: Enable rcstream-pep8 and rcstream-pyflakes [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/134485 [20:34:25] hashar: Yeah. Brad showed me that one. [20:34:37] (03CR) 10Krinkle: [C: 032] Enable rcstream-pep8 and rcstream-pyflakes [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/134485 (owner: 10Krinkle) [20:34:48] (03Merged) 10jenkins-bot: Enable rcstream-pep8 and rcstream-pyflakes [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/134485 (owner: 10Krinkle) [20:34:57] bd808: I sometime hate how our eval.php lacks interactivity like the python / ruby consoles have :/ [20:35:41] We could write a fancier one I suppose. phpsh is written in python :) [20:35:53] OH MY GOD [20:35:55] dont tempt me [20:35:59] https://github.com/facebookarchive/phpsh [20:36:24] I had a patch ages ago that added autocompletion [20:36:39] so you could: $wgRequest-> [20:36:53] and it would show a list of properties/methods public methods [20:37:03] Neat. [20:37:08] lost :-( [20:38:54] bd808: looking at your bug report on https://bugzilla.wikimedia.org/show_bug.cgi?id=53972#c17 [20:39:07] I am super confused [20:40:02] Me too. [20:40:29] Anything I might be able to explain? DId you look at the core patch? [20:41:10] https://gerrit.wikimedia.org/r/#/c/130498/ is the changes I made to GitInfo [20:41:49] na I havent looked at anything yet :-( [20:42:06] No worries. [20:42:13] to be honest, I only looked at your comment #17. I should read the bug report probably [20:44:17] The commands I did in comment 17 were trying to reproduce what I think SpecialVersion does to compute the data for a given extension. [20:44:37] ok lets focus in this channel [20:46:48] bd808: the good old way would be to add a bunch of wfDebug() statements around [20:47:59] Yeah. I thought about doing that as a hot patch on one of the apache hosts [20:49:49] Part of my difficult is that this is really hard to test in a vagrant vm [20:51:05] hmm [20:51:22] some logic might be flawed [20:51:32] when accessing the Special:Version there is a bunch of get like: [20:51:36] commonswiki-5de121a8: 1.8454 16.5M [memcached] get(commonswiki:specialversion-ext-version-text:/srv/common-local/php-master/extensions/WikimediaMessages/WikimediaLicenseTexts.php:cbd8ec6dde468f6f8529f100cd1e8a625c5bec15) [20:51:41] Project MultimediaViewer-en.wikipedia.beta.wmflabs.org-linux-firefox build #240: SUCCESS in 1 min 56 sec: https://wmf.ci.cloudbees.com/job/MultimediaViewer-en.wikipedia.beta.wmflabs.org-linux-firefox/240/ [20:51:42] krinklemail: Use example.{com,net,org} instead of proprietary domains [20:51:48] which are misses, and then a set [20:51:53] that is done for all extensions [20:52:22] but the sha1 is the one from mw/core.git ( in this case cbd8ec6dde468f6f8529f100cd1e8a625c5bec15 which is https://gerrit.wikimedia.org/r/#/c/134406/ ) [20:52:34] so I guess an update of core invalidate the whole cache [20:52:50] anyway, the key is never set apparently [20:55:22] I think I was occasionally getting a cache hit when I was testing yesterday, but the cache object was always [false,null,null] [20:56:38] ah [20:56:43] list( $vcsVersion, $vcsLink, $vcsDate ) = $cache->get( $memcKey ); [20:56:55] so that would mean memcached get() can't find the value i guess [20:58:00] That would make sense. Hmm... so maybe I'm not constructing the right cache key in my tests. [20:58:03] hashar: did you just kill Parsoid in beta labs? Getting a 503 editing with VE, for example http://en.wikipedia.beta.wmflabs.org/wiki/0.24433043495962647_Moved?veaction=edit [20:58:37] bd808: and maybe the cache is weird/not working [20:58:45] chrismcmahon: havent touched it [20:59:06] chrismcmahon: maybe it was being restarted because a patch just got merged? [21:00:03] bd808: also the cache vary by $wgDBname when we should probably vary simply by the core HEAD commit. but that is a nitpick [21:01:32] mwscript mcc.php --wiki=commonswiki [21:01:37] > get 'commonswiki:specialversion-ext-version-text:/srv/common-local/php-master/extensions/ZeroRatedMobileAccess/ZeroRatedMobileAccess.php:cbd8ec6dde468f6f8529f100cd1e8a625c5bec15' [21:01:37] Getting 'commonswiki:specialversion-ext-version-text:/srv/common-local/php-master/extensions/ZeroRatedMobileAccess/ZeroRatedMobileAccess.php:cbd8ec6dde468f6f8529f100cd1e8a625c5bec15'[] [21:01:37] MemCached error [21:01:37] > [21:01:38] :( [21:02:03] We could really rip the caching out entirely if this works. It was added not too long ago because beta was so slow. [21:02:41] that might just be mcc being broken [21:03:30] Krenair added the caching in https://gerrit.wikimedia.org/r/#/c/95878/ [21:04:03] * bd808 shakes his head that it took 5 months to merge that [21:04:27] yeah we are terrible at reviewing patches [21:04:28] :-( [21:06:18] bd808: when i do mw.loader.getVersion('wikibase.utilities.ClaimGuidGenerator'); [21:06:22] what is the date suppoesd to be? [21:06:31] the version from memcached? [21:06:50] mw.loader.getVersion('wikibase.utilities.GuidGenerator'); gives me today, so maybe not important [21:07:12] If it's working correctly the date would be the date of the HEAD commit [21:07:41] mw.loader.store.get('wikibase.utilities.GuidGenerator'); [21:07:45] gives old code [21:07:51] At least if it's using GitInfo under the hood [21:07:54] ok [21:08:23] Oh. So you've still got stale cache issues in beta? [21:08:27] yeah [21:08:35] and similar issue with gadgets in firefox on wikidata [21:09:01] how do we get localstorage cache to invalidate and get new stuff? [21:09:15] "ask ori" :) [21:09:19] ok [21:09:24] thank goodness this issue is beta only [21:09:38] means can't add new stuff on beta wikidata [21:10:24] bd808: sorry nothing obvious for me right now :-( [21:10:29] will crash to bed soon :/ [21:10:39] hashar: Thanks for looking. [21:11:09] you might want to double check the found git sha1 for an extension is properly saved in memcached [21:11:22] then verify the code use the same key to get it [21:11:29] beta might have some weird memcached issue [21:12:27] Yeah. I think I'll slip some debug logging in there and see what I find out [21:13:08] Project VisualEditor-test2.wikipedia.org-linux-chrome build #436: FAILURE in 46 min: https://wmf.ci.cloudbees.com/job/VisualEditor-test2.wikipedia.org-linux-chrome/436/ [21:13:09] l10n-bot: Localisation updates from https://translatewiki.net. [21:18:47] hashar: bd808 this is a little strange: https://bugzilla.wikimedia.org/show_bug.cgi?id=65553 [21:19:33] I just saw something related to that in #-operations [21:20:19] It was a casualty of the grant uid unification project that andrewbogott has been working on [21:20:29] gotcha [21:20:31] *grand uid unification [21:26:25] Project UploadWizard-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_10 build #661: SUCCESS in 13 min: https://wmf.ci.cloudbees.com/job/UploadWizard-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_10/661/ [21:26:25] * mtraceur: jshint fixes for mw.UploadWizardDeed.js [21:26:26] * l10n-bot: Localisation updates from https://translatewiki.net. [21:28:47] happy to see parsoid got fixed :-] [21:28:57] I am off to bed for real now. See you tomorrow! [21:37:33] Project MultimediaViewer-en.wikipedia.beta.wmflabs.org-linux-chrome build #12: SUCCESS in 2 min 13 sec: https://wmf.ci.cloudbees.com/job/MultimediaViewer-en.wikipedia.beta.wmflabs.org-linux-chrome/12/ [21:37:34] krinklemail: Use example.{com,net,org} instead of proprietary domains [21:40:43] Project MultimediaViewer-mediawiki.org-linux-firefox build #70: SUCCESS in 3 min 9 sec: https://wmf.ci.cloudbees.com/job/MultimediaViewer-mediawiki.org-linux-firefox/70/ [21:40:43] krinklemail: Use example.{com,net,org} instead of proprietary domains [21:43:03] Project WikiLove-en.wikipedia.beta.wmflabs.org-linux-firefox build #181: SUCCESS in 2 min 19 sec: https://wmf.ci.cloudbees.com/job/WikiLove-en.wikipedia.beta.wmflabs.org-linux-firefox/181/ [21:43:03] l10n-bot: Localisation updates from https://translatewiki.net. [21:43:23] Project ZeroRatedMobileAccess-en.m.wikipedia.org-linux-phantomjs build #185: STILL FAILING in 19 sec: https://wmf.ci.cloudbees.com/job/ZeroRatedMobileAccess-en.m.wikipedia.org-linux-phantomjs/185/ [21:47:25] Project browsertests-en.wikipedia.beta.wmflabs.org-linux-chrome build #858: SUCCESS in 20 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-linux-chrome/858/ [21:54:44] Project Flow-en.wikipedia.beta.wmflabs.org-linux-firefox build #439: SUCCESS in 11 min: https://wmf.ci.cloudbees.com/job/Flow-en.wikipedia.beta.wmflabs.org-linux-firefox/439/ [21:54:45] l10n-bot: Localisation updates from https://translatewiki.net. [22:08:53] Project browsertests-test2.wikipedia.org-linux-chrome build #1091: STILL FAILING in 21 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-linux-chrome/1091/ [22:10:17] Project UploadWizard-api-commons.wikimedia.beta.wmflabs.org build #490: SUCCESS in 1 min 22 sec: https://wmf.ci.cloudbees.com/job/UploadWizard-api-commons.wikimedia.beta.wmflabs.org/490/ [22:10:17] l10n-bot: Localisation updates from https://translatewiki.net. [22:13:07] Project MultimediaViewer-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_9 build #12: SUCCESS in 2 min 49 sec: https://wmf.ci.cloudbees.com/job/MultimediaViewer-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_9/12/ [22:13:07] krinklemail: Use example.{com,net,org} instead of proprietary domains [22:14:25] Project UploadWizard-api-commons.wikimedia.org build #406: SUCCESS in 1 min 18 sec: https://wmf.ci.cloudbees.com/job/UploadWizard-api-commons.wikimedia.org/406/ [22:14:26] l10n-bot: Localisation updates from https://translatewiki.net. [22:34:58] Project browsertests-test2.wikipedia.org-linux-firefox build #1068: STILL FAILING in 20 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-linux-firefox/1068/ [22:39:16] Project MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox build #574: FAILURE in 44 min: https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox/574/ [22:39:16] * jrobson: Hygiene: Cleanup edit switcher css [22:39:17] * jgonera: Regression: Fix styling of page lists [22:39:17] * jgonera: Fix margins in page list and search [22:39:18] * florian.schmidt.welzow: Add check for permission to create a new account [22:39:18] * jgonera: Fix trailing whitespace check in pre-commit [22:39:19] * jrobson: Fix edit link when VisualEditor is not available [22:39:19] * jrobson: QA: Don't run protected pages tests on test2wiki. [22:39:20] * l10n-bot: Localisation updates from https://translatewiki.net. [22:39:20] * maxsem.wiki: Fix username handling on Special:Uploads [22:45:59] Project MobileFrontend-en.m.wikipedia.org-linux-firefox build #484: FAILURE in 10 min: https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.org-linux-firefox/484/ [22:45:59] * jrobson: Style search button as icon for non-JS users [22:46:00] * jrobson: Hygiene: Cleanup edit switcher css [22:46:00] * jgonera: Regression: Fix styling of page lists [22:46:01] * jgonera: Fix margins in page list and search [22:46:01] * florian.schmidt.welzow: Add check for permission to create a new account [22:46:02] * jgonera: Fix trailing whitespace check in pre-commit [22:46:02] * jrobson: Fix edit link when VisualEditor is not available [22:46:03] * jrobson: QA: Don't run protected pages tests on test2wiki. [22:46:03] * l10n-bot: Localisation updates from https://translatewiki.net. [22:46:04] * maxsem.wiki: Fix username handling on Special:Uploads [22:46:04] * jgonera: Removing header margin and associated hacks [22:47:42] Project UploadWizard-commons.wikimedia.beta.wmflabs.org-linux-firefox build #797: FAILURE in 8 min 25 sec: https://wmf.ci.cloudbees.com/job/UploadWizard-commons.wikimedia.beta.wmflabs.org-linux-firefox/797/ [22:47:43] l10n-bot: Localisation updates from https://translatewiki.net. [23:17:43] Project browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_10 build #663: FAILURE in 31 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_10/663/ [23:19:04] Project UploadWizard-api-commons.wikimedia.beta.wmflabs.org build #491: SUCCESS in 1 min 18 sec: https://wmf.ci.cloudbees.com/job/UploadWizard-api-commons.wikimedia.beta.wmflabs.org/491/ [23:23:11] Project browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_8 build #698: STILL FAILING in 35 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_8/698/ [23:27:13] Yippee, build fixed! [23:27:14] Project UploadWizard-commons.wikimedia.beta.wmflabs.org-linux-firefox build #798: FIXED in 8 min 9 sec: https://wmf.ci.cloudbees.com/job/UploadWizard-commons.wikimedia.beta.wmflabs.org-linux-firefox/798/ [23:49:11] @chrismcmahon: Hi Chris [23:49:32] hi Jagori [23:49:32] Hi [23:49:53] @Chris:thanks for your mail.I had another query.. [23:50:06] sure [23:50:19] the tests when I run now..opens a separate page Links_VisualEditor [23:50:27] and would it then not require to login [23:50:38] tests do run on those but login is not required? [23:51:37] Jagori: there is a feature I just found out about recently, that if you open a page with a URL that ends with "?veaction=edit" then you can bypass login to use VE. It is much faster and more reliable, so that's what the tests do now. [23:52:01] Ahh I see [23:52:03] thats wonderful [23:52:21] so what is happing right now is there's this source page which gets created on the fly [23:52:28] Jagori: yes. it seems the VE developers added that a few months ago, but I only just found out about it. [23:53:03] Jagori: yes, each VE test now creates or updates its own page at run time using the API [23:53:08] So this happens via the MediawikiAPI [23:53:13] okay [23:53:33] but can I define my own target page [23:53:37] or source page [23:53:46] I mean is the source and target page fixed [23:53:50] which will be generated [23:53:51] Jagori: that way these tests can run on against any wiki, not just ones with reliable target pages in place in advance [23:54:30] Yes..I was going through the acceptance tests and smoke tests you had written and sent a mail [23:55:52] Jagori: take a look in the VE repo at shared_steps.rb, you'll see how the API is called there at line 10 [23:56:16] @chris:What I wanted to know was..is the link source page same for each of my tests [23:56:20] Okay sure [23:57:09] Jagori: I think you'll see the answer about the page names when you see how the code works [23:57:25] Yes..I am looking into it [23:58:05] Oh yes [23:58:10] its clear now absolutely [23:58:12] How good [23:58:13] :) [23:59:08] where do I see APIPage ?sorry for asking this..I am trying to be familar with the entire flow