[00:49:42] Project UploadWizard-api-commons.wikimedia.beta.wmflabs.org build #588: SUCCESS in 1 min 23 sec: https://wmf.ci.cloudbees.com/job/UploadWizard-api-commons.wikimedia.beta.wmflabs.org/588/ [01:11:34] Project UploadWizard-api-commons.wikimedia.org build #487: SUCCESS in 1 min 20 sec: https://wmf.ci.cloudbees.com/job/UploadWizard-api-commons.wikimedia.org/487/ [03:09:38] Project MultimediaViewer-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_10 build #52: SUCCESS in 2 min 35 sec: https://wmf.ci.cloudbees.com/job/MultimediaViewer-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_10/52/ [03:09:39] * tgr.huwiki: Use original URL when setting download for original [03:09:39] * l10n-bot: Localisation updates from https://translatewiki.net. [03:09:40] * gtisza: Icon adjustments [03:35:30] Project browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_9 build #772: FAILURE in 26 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_9/772/ [03:40:24] Project browsertests-test2.wikipedia.org-windows-internet_explorer_10 build #693: STILL FAILING in 29 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-windows-internet_explorer_10/693/ [03:48:00] Project Flow-test2.wikipedia.org-linux-firefox build #296: STILL FAILING in 7 min 34 sec: https://wmf.ci.cloudbees.com/job/Flow-test2.wikipedia.org-linux-firefox/296/ [03:48:00] * git: POST actions can also be rendered [03:48:01] * ebernhardson: Provide a comment for the RCFeeds [03:48:01] * l10n-bot: Localisation updates from https://translatewiki.net. [03:55:31] Project Flow-en.wikipedia.beta.wmflabs.org-linux-chrome build #480: SUCCESS in 7 min 29 sec: https://wmf.ci.cloudbees.com/job/Flow-en.wikipedia.beta.wmflabs.org-linux-chrome/480/ [03:55:32] * git: POST actions can also be rendered [03:55:32] * l10n-bot: Localisation updates from https://translatewiki.net. [04:08:42] Yippee, build fixed! [04:08:42] Project UploadWizard-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_9 build #815: FIXED in 13 min: https://wmf.ci.cloudbees.com/job/UploadWizard-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_9/815/ [04:15:58] Project Flow-test2.wikipedia.org-linux-chrome build #330: STILL FAILING in 7 min 16 sec: https://wmf.ci.cloudbees.com/job/Flow-test2.wikipedia.org-linux-chrome/330/ [04:15:58] * git: POST actions can also be rendered [04:15:59] * l10n-bot: Localisation updates from https://translatewiki.net. [04:17:18] (03CR) 1001tonythomas: "Ping! on this patch. We need this to get fixed in pace, as https://gerrit.wikimedia.org/r/#/c/135290/ Jenkins directly depends on this" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/136897 (owner: 10Hashar) [04:21:33] Project browsertests-en.wikipedia.beta.wmflabs.org-linux-firefox build #883: SUCCESS in 16 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-linux-firefox/883/ [04:24:41] Project UploadWizard-commons.wikimedia.beta.wmflabs.org-linux-chrome build #880: SUCCESS in 8 min 40 sec: https://wmf.ci.cloudbees.com/job/UploadWizard-commons.wikimedia.beta.wmflabs.org-linux-chrome/880/ [04:51:04] Project VisualEditor-en.wikipedia.beta.wmflabs.org-linux-firefox build #48: FAILURE in 29 min: https://wmf.ci.cloudbees.com/job/VisualEditor-en.wikipedia.beta.wmflabs.org-linux-firefox/48/ [04:51:05] * krenair: Send language when making API requests [04:51:05] * l10n-bot: Localisation updates from https://translatewiki.net. [04:51:06] * esanders: Update VE core submodule to master (3a80662) [04:51:06] * jforrester: Adding ext.visualEditor.mwimage.core to ext.visualEditor.mobileViewTarget [04:51:07] * roan.kattouw: Followup bd49f97: prevent MWExtensionNodes from having children [04:51:07] * jforrester: Update VE core submodule to master (5f10e73) [05:03:15] Project MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome build #500: STILL FAILING in 38 min: https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/500/ [05:03:16] * maxsem.wiki: Hygiene: remove old b/c code that was there since October [05:03:16] * florian.schmidt.welzow: Hygiene: Update/Create doc for php in diff and modules [05:03:17] * kaldari: Make sure images are properly aligned in Mobile VisualEditor [05:03:17] * jrobson: Slight tweak to quotebox template [05:03:18] * jrobson: Make `make message` work again. [05:03:18] * maxsem.wiki: Throw a couple more Android UAs at tests [05:27:46] Project MultimediaViewer-en.wikipedia.beta.wmflabs.org-linux-firefox build #281: SUCCESS in 1 min 48 sec: https://wmf.ci.cloudbees.com/job/MultimediaViewer-en.wikipedia.beta.wmflabs.org-linux-firefox/281/ [05:27:46] gtisza: Icon adjustments [05:48:00] (03PS1) 10Krinkle: macro: Rename 'jsduck' to 'jsduck-conf' and create new 'jsduck' [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/138538 [05:54:29] Project UploadWizard-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_10 build #702: STILL FAILING in 11 min: https://wmf.ci.cloudbees.com/job/UploadWizard-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_10/702/ [06:10:50] Project browsertests-en.wikipedia.beta.wmflabs.org-linux-chrome build #899: SUCCESS in 16 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-linux-chrome/899/ [06:12:59] Project MultimediaViewer-en.wikipedia.beta.wmflabs.org-linux-chrome build #53: SUCCESS in 2 min 8 sec: https://wmf.ci.cloudbees.com/job/MultimediaViewer-en.wikipedia.beta.wmflabs.org-linux-chrome/53/ [06:13:00] gtisza: Icon adjustments [06:14:13] Project MultimediaViewer-mediawiki.org-linux-firefox build #111: SUCCESS in 2 min 43 sec: https://wmf.ci.cloudbees.com/job/MultimediaViewer-mediawiki.org-linux-firefox/111/ [06:14:14] gtisza: Icon adjustments [06:14:40] Project ZeroRatedMobileAccess-en.m.wikipedia.org-linux-phantomjs build #226: STILL FAILING in 25 sec: https://wmf.ci.cloudbees.com/job/ZeroRatedMobileAccess-en.m.wikipedia.org-linux-phantomjs/226/ [06:14:46] Project WikiLove-en.wikipedia.beta.wmflabs.org-linux-firefox build #222: SUCCESS in 1 min 45 sec: https://wmf.ci.cloudbees.com/job/WikiLove-en.wikipedia.beta.wmflabs.org-linux-firefox/222/ [06:21:48] 3Wikimedia / 3Continuous integration: Improper deletion of fiwiki from beta.wmflabs.org - 10https://bugzilla.wikimedia.org/66401 (10Nemo) 3NEW p:3Unprio s:3normal a:3None Sorry! This site is experiencing technical difficulties. Try waiting a few minutes and reloading. (Cannot contact the database se... [06:22:48] Project Flow-en.wikipedia.beta.wmflabs.org-linux-firefox build #480: SUCCESS in 8 min 6 sec: https://wmf.ci.cloudbees.com/job/Flow-en.wikipedia.beta.wmflabs.org-linux-firefox/480/ [06:25:30] Project MultimediaViewer-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_9 build #53: SUCCESS in 2 min 41 sec: https://wmf.ci.cloudbees.com/job/MultimediaViewer-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_9/53/ [06:25:30] gtisza: Icon adjustments [06:27:48] 3Wikimedia / 3Continuous integration: Import some content on beta.wmflabs.org wikis - 10https://bugzilla.wikimedia.org/66402 (10Nemo) 3NEW p:3Unprio s:3normal a:3None When trying to use beta.wmflabs.org to test (https://www.mediawiki.org/wiki/Thread:Talk:PDF_rendering/Test_instance_and_bug_triage ),... [06:32:23] Project browsertests-test2.wikipedia.org-linux-chrome build #1132: STILL FAILING in 17 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-linux-chrome/1132/ [06:41:04] 3Wikimedia / 3Continuous integration: Improper deletion of fiwiki from beta.wmflabs.org - 10https://bugzilla.wikimedia.org/66401#c1 (10Nemo) Forgot the URL... This happens on my account because I have a local account on the wiki, created when it existed. [06:41:56] (03CR) 10Krinkle: [C: 032] "No difference in compilation output so nothing that can be deployed to Jenkins. This is merely an internal change." [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/138538 (owner: 10Krinkle) [06:42:41] Project browsertests-test2.wikipedia.org-linux-firefox build #1109: STILL FAILING in 17 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-linux-firefox/1109/ [06:43:01] Project MobileFrontend-en.m.wikipedia.org-linux-firefox build #525: STILL FAILING in 10 min: https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.org-linux-firefox/525/ [06:43:02] * florian.schmidt.welzow: Hygiene: Update/Create doc for php in diff and modules [06:43:02] * kaldari: Make sure images are properly aligned in Mobile VisualEditor [06:43:03] * jrobson: Slight tweak to quotebox template [06:43:03] * jrobson: Make `make message` work again. [06:43:04] * maxsem.wiki: Throw a couple more Android UAs at tests [06:43:25] (03Merged) 10jenkins-bot: macro: Rename 'jsduck' to 'jsduck-conf' and create new 'jsduck' [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/138538 (owner: 10Krinkle) [06:50:43] Project UploadWizard-commons.wikimedia.beta.wmflabs.org-linux-firefox build #839: SUCCESS in 7 min 58 sec: https://wmf.ci.cloudbees.com/job/UploadWizard-commons.wikimedia.beta.wmflabs.org-linux-firefox/839/ [07:09:17] Project browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_10 build #704: FAILURE in 26 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_10/704/ [07:10:34] Project UploadWizard-api-commons.wikimedia.beta.wmflabs.org build #589: SUCCESS in 1 min 15 sec: https://wmf.ci.cloudbees.com/job/UploadWizard-api-commons.wikimedia.beta.wmflabs.org/589/ [07:11:46] Project UploadWizard-api-commons.wikimedia.org build #488: SUCCESS in 1 min 12 sec: https://wmf.ci.cloudbees.com/job/UploadWizard-api-commons.wikimedia.org/488/ [07:18:49] Project browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_8 build #739: FAILURE in 28 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_8/739/ [08:08:45] 3Wikimedia / 3Continuous integration: Import some content on beta.wmflabs.org wikis - 10https://bugzilla.wikimedia.org/66402#c1 (10Antoine "hashar" Musso) The beta cluster is not powerful enough to be a close copy of the production wikis. En and de would definitely not fit on the small database server. More... [08:38:29] 3Wikimedia / 3Continuous integration: Import some content on beta.wmflabs.org wikis - 10https://bugzilla.wikimedia.org/66402#c2 (10Nemo) (In reply to Antoine "hashar" Musso from comment #1) > If there is a specific need, one can export pages they are interested in and > manually import them on the wikis. Th... [10:14:55] (03PS1) 10Hashar: python lint jobs for the slander repo [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/138563 [10:17:08] (03CR) 10Hashar: [C: 032] "Jenkins jobs added with https://gerrit.wikimedia.org/r/#/c/138563/" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/138360 (owner: 10Awight) [10:17:15] (03CR) 10Hashar: [C: 032] python lint jobs for the slander repo [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/138563 (owner: 10Hashar) [10:17:44] (03PS1) 10Hashar: Revert "Fix Zuul success/failure messages" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/138565 [10:17:49] (03PS2) 10Hashar: Revert "Fix Zuul success/failure messages" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/138565 [10:17:55] (03CR) 10Hashar: [C: 032] Revert "Fix Zuul success/failure messages" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/138565 (owner: 10Hashar) [10:18:36] (03Merged) 10jenkins-bot: python lint jobs for the slander repo [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/138563 (owner: 10Hashar) [10:18:39] (03Merged) 10jenkins-bot: Revert "Fix Zuul success/failure messages" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/138565 (owner: 10Hashar) [10:20:46] (03PS2) 10Hashar: python lint jobs for the slander repo [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/138360 (owner: 10Awight) [10:20:51] (03CR) 10Hashar: [C: 032] python lint jobs for the slander repo [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/138360 (owner: 10Awight) [10:21:03] (03Merged) 10jenkins-bot: python lint jobs for the slander repo [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/138360 (owner: 10Awight) [10:23:56] (03CR) 10Hashar: "I created a dummy change: https://gerrit.wikimedia.org/r/#/c/138566/" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/138360 (owner: 10Awight) [10:28:31] kart_: around? [12:03:40] aharoni: I am in the hangout [12:03:49] coming soon [12:14:42] hashar: could you please take a look at this? https://gerrit.wikimedia.org/r/#/c/138351/ [12:14:50] hello [12:14:50] Chris and I made it work but it is a mess [12:15:02] zeljkof: I am doing my coworker reviews this afternoon so .. no sorry :( [12:15:03] we could pair these days to clean it up [12:15:14] there is no rush [12:15:19] when ever you have the tiem [12:15:20] time [12:15:38] zeljkof: we can definitely polish them during one of our mornings. Drop me an invitation :) I am at home this week [12:15:48] hashar: will do :) [12:24:41] zeljkof: Hi!are you busy/ [12:24:44] ? [12:25:03] Jagori: sorry, in a meeting with aharoni [12:25:06] I went through 66369,but am not able to assign that issue to myself [12:25:10] Ahh sorry [12:25:13] not a problem [12:25:17] will talk later [12:48:47] Project UploadWizard-api-commons.wikimedia.beta.wmflabs.org build #590: SUCCESS in 1 min 22 sec: https://wmf.ci.cloudbees.com/job/UploadWizard-api-commons.wikimedia.beta.wmflabs.org/590/ [12:55:46] Project UploadWizard-api-commons.wikimedia.org build #489: SUCCESS in 1 min 21 sec: https://wmf.ci.cloudbees.com/job/UploadWizard-api-commons.wikimedia.org/489/ [12:56:16] zeljkof da li moramo ovde na engleskom pricati? [12:56:41] Kolega2357: yes, only English here :) [12:56:47] but I am in a meeting right now [13:27:03] aharoni: https://bugzilla.wikimedia.org/show_bug.cgi?id=66415 [13:37:11] zeljkof: feel free to talk in non english. That will be easier for Kolega2357 I guess [13:41:25] hashar: Kolega2357 has to practice English :) [13:41:36] you are mean! [13:41:37] :D [13:44:00] hashar Yes [13:45:10] hashar, Kolega2357: I am teaching him how to catch a fish :) [13:52:16] zeljkof: good point [13:57:45] hashar I am agree with you. [14:59:27] (03PS1) 10Jackmcbarn: Add Scribunto as a dependency for FlaggedRevs [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/138612 [15:24:19] zeljkof: here is a puzzle: this build should have run 36 tests and it only ran 12 https://integration.wikimedia.org/ci/view/BrowserTests/job/browsertests-MobileFrontend-en.m.wikipedia.org-linux-firefox/87/testReport/(root)/ [15:24:32] zeljkof: the tags for Cucumber look correct to me [15:27:30] chrismcmahon: will take a look [15:40:46] chrismcmahon: 29 scenarios (29 passed) ?: D [15:41:02] that is still not 36 though :( [15:41:26] there is also a: 15:04:16 * features/support/pages/watchlist_page.rb [15:41:26] 15:04:16 Failed to load 'sqlite' programming language for file features/support/permissions.sqlite: cannot load such file -- cucumber/sqlite_support/sqlite_language [15:41:33] 15:04:16 * features/support/permissions.sqlite [NOT SUPPORTED] [15:41:58] maybe it is missing a gem to bring sqlite support [15:42:24] hashar: cc chrismcmahon, no, the file should not be in folder named support [15:42:25] ok I am tired. That is because that is a .sqlite database.. Forget me [15:42:48] cucumber tries to require all files in that folder, and fails if the file is not a ruby file [15:43:28] chrismcmahon: hm, that job runs 29 tests, not 12 https://integration.wikimedia.org/ci/view/BrowserTests/job/browsertests-MobileFrontend-en.m.wikipedia.org-linux-firefox/87/testReport/ [15:43:35] says: total 29 [15:43:45] https://integration.wikimedia.org/ci/view/BrowserTests/job/browsertests-MobileFrontend-en.m.wikipedia.org-linux-firefox/87/console [15:43:47] says [15:43:52] 29 scenarios (29 passed) [15:47:03] chrismcmahon: take a look at this [15:47:04] http://etherpad.wikimedia.org/p/chrismcmahon [15:47:38] yeah, don't worry about the sqlite thing, it's a legacy [15:48:18] zeljkof: bah. needs to be cleaned up [15:50:43] chrismcmahon: take a look at the pad now [15:50:54] zeljkof: those undefined steps are actually in the mediawiki-selenium gem, I thought they were gone from the local repo [15:51:02] why do you think 36 tests should run? [15:51:23] cucumber says those tags catch 31 scenarios [15:52:54] Project MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome build #501: STILL FAILING in 43 min: https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/501/ [15:55:11] $ grep -r '@firefox' * |wc -l [15:55:11] 36 [15:55:14] zeljkof: I'm probably wrong [15:55:25] chrismcmahon: :) [15:59:20] joining [16:28:46] 3Wikimedia / 3Continuous integration: Cannot merge code in MobileFrontend and other places - 10https://bugzilla.wikimedia.org/66429 (10Jon) 3NEW p:3Unprio s:3blocke a:3None QUnit is complaining whenever I try and +2 code and it is preventing merges from happened e.g. https://gerrit.wikimedia.org/r/#/... [16:33:19] zeljkof: there still are not enough features in that dry-run: https://git.wikimedia.org/tree/mediawiki%2Fextensions%2FMobileFrontend/fb152040a765980a205f4966d21da7d31fc66e2a/tests%2Fbrowser%2Ffeatures [16:39:44] 3Wikimedia / 3Continuous integration: Cannot merge code in MobileFrontend and other places - 10https://bugzilla.wikimedia.org/66429#c1 (10Kunal Mehta (Legoktm)) (In reply to Jon from comment #0) > https://integration.wikimedia.org/ci/job/mwext-MobileFrontend-qunit/6228/ Since Modern is no longer in core, w... [16:41:29] 3Wikimedia / 3Continuous integration: Cannot merge code in MobileFrontend and other places - 10https://bugzilla.wikimedia.org/66429#c2 (10Antoine "hashar" Musso) https://gerrit.wikimedia.org/r/#/c/135429/ added a warning message whenever an old skin is found under Mediawiki /skins/ . The skins have been remo... [16:44:44] 3Wikimedia / 3Continuous integration: Cannot merge code in MobileFrontend and other places - 10https://bugzilla.wikimedia.org/66429#c4 (10Antoine "hashar" Musso) We could clean up the /skins/ directory in all workspaces potentially, but I can't remember whether the same job could use a REL1_*** codebase whic... [16:50:59] 3Wikimedia / 3Continuous integration: Cannot merge code in MobileFrontend and other places - 10https://bugzilla.wikimedia.org/66429#c5 (10Kunal Mehta (Legoktm)) (In reply to Antoine "hashar" Musso from comment #2) > The reason is that since mediawiki/core.git is so huge to clone, we are > using git archive t... [16:54:44] 3Wikimedia / 3Continuous integration: Cannot merge code in MobileFrontend and other places - 10https://bugzilla.wikimedia.org/66429#c6 (10Antoine "hashar" Musso) Sorry Kunal :-( And you have no idea how much it piss me off to have to revert such a patch from core :-( [17:25:30] 3Wikimedia / 3Continuous integration: Cannot merge code in VisualEditor, MobileFrontend and other places - 10https://bugzilla.wikimedia.org/66429 (10James Forrester) p:5Unprio>3Highes [17:31:14] 3Wikimedia / 3Continuous integration: Cannot merge code in VisualEditor, MobileFrontend and other places - 10https://bugzilla.wikimedia.org/66429#c7 (10Krinkle) Taking mwext-VisualEditor-qunit as a usecase there's a couple facts: 1) As being a repo not having the target git repo (VE) at its root, it has git... [17:32:29] 3Wikimedia / 3Continuous integration: Jenkins: Extension jobs are not reset properly (files no longer present in mediawiki-core@master still persist) - 10https://bugzilla.wikimedia.org/66429#c8 (10Krinkle) Rephrasing bug summary. For the record, this only affects files that have actually landed in master. We... [17:36:14] 3Wikimedia / 3Continuous integration: Jenkins: Extension jobs are not reset properly (files no longer present in mediawiki-core@master still persist) - 10https://bugzilla.wikimedia.org/66429#c9 (10Ryan Kaldari) p:5Highes>3High s:5blocke>3major I went ahead and merged Jon's revert so that mobile and V... [17:54:30] 3Wikimedia / 3Continuous integration: Jenkins: Extension jobs are not reset properly (files no longer present in mediawiki-core@master still persist) - 10https://bugzilla.wikimedia.org/66429#c11 (10Jon) 5PATC>3NEW Let's get this issue fixed now so we can work towards merging Bartosz's patch again. [17:55:15] Project MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome build #502: STILL FAILING in 45 min: https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/502/ [18:04:44] 3Wikimedia / 3Continuous integration: Jenkins: Extension jobs are not reset properly (files no longer present in mediawiki-core@master still persist) - 10https://bugzilla.wikimedia.org/66429#c12 (10Krinkle) (In reply to Krinkle from comment #7) > Taking mwext-VisualEditor-qunit as a usecase there's a couple... [18:08:57] Project MultimediaViewer-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_10 build #53: SUCCESS in 2 min 34 sec: https://wmf.ci.cloudbees.com/job/MultimediaViewer-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_10/53/ [18:09:18] (03PS1) 10Krinkle: defaults: Make values for 'wipe-workspace' and 'clean' explicit [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/138648 [18:09:51] (03CR) 10Krinkle: [C: 032] defaults: Make values for 'wipe-workspace' and 'clean' explicit [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/138648 (owner: 10Krinkle) [18:10:02] (03PS2) 10Krinkle: defaults: Make values for 'wipe-workspace' and 'clean' explicit [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/138648 (https://bugzilla.wikimedia.org/66429) [18:33:43] Yippee, build fixed! [18:33:43] Project browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_9 build #773: FIXED in 25 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_9/773/ [18:36:54] Project browsertests-test2.wikipedia.org-windows-internet_explorer_10 build #694: STILL FAILING in 26 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-windows-internet_explorer_10/694/ [18:40:19] 3Wikimedia / 3Continuous integration: Make RSS feeds public - 10https://bugzilla.wikimedia.org/66443 (10Jon) 3NEW p:3Unprio s:3normal a:3None https://integration.wikimedia.org/ci/job/browsertests-MobileFrontend-en.m.wikipedia.org-linux-firefox/rssAll and https://integration.wikimedia.org/ci/job/brows... [18:43:52] (03PS1) 10Krinkle: mw-core-get: Clean workspace first [integration/jenkins] - 10https://gerrit.wikimedia.org/r/138657 (https://bugzilla.wikimedia.org/66429) [18:44:18] (03CR) 10Krinkle: [C: 031] "See comment in file for documentation." [integration/jenkins] - 10https://gerrit.wikimedia.org/r/138657 (https://bugzilla.wikimedia.org/66429) (owner: 10Krinkle) [18:44:30] (03CR) 10Krinkle: [C: 032] mw-core-get: Clean workspace first [integration/jenkins] - 10https://gerrit.wikimedia.org/r/138657 (https://bugzilla.wikimedia.org/66429) (owner: 10Krinkle) [18:45:32] 3Wikimedia / 3Continuous integration: Jenkins: Extension jobs are not reset properly (files no longer present in mediawiki-core@master still persist) - 10https://bugzilla.wikimedia.org/66429 (10Krinkle) a:3Krinkle [18:45:45] Project Flow-test2.wikipedia.org-linux-firefox build #297: STILL FAILING in 8 min 48 sec: https://wmf.ci.cloudbees.com/job/Flow-test2.wikipedia.org-linux-firefox/297/ [18:45:46] * legoktm: Relay some API methods to the actual submodule [18:45:46] * ebernhardson: (bug 61939) Topic-titles not displaying in some topics (disappearing?) [18:45:47] * legoktm: Split out POST-specific logic from ApiFlowBase & add a new one for GET [18:45:47] * legoktm: Add ApiFlowViewHeader [18:45:48] * legoktm: Add ApiFlowViewTopicSummary [18:45:48] * legoktm: Display a proper error when an invalid workflow is provided [18:45:49] * legoktm: Add ApiFlowViewPost [18:45:49] * legoktm: Add ApiFlowViewTopic [18:45:50] * legoktm: Add ApiFlowViewTopicList [18:45:50] * legoktm: Deprecate existing read API [18:50:45] (03Merged) 10jenkins-bot: mw-core-get: Clean workspace first [integration/jenkins] - 10https://gerrit.wikimedia.org/r/138657 (https://bugzilla.wikimedia.org/66429) (owner: 10Krinkle) [18:53:08] Krinkle: you are awesome :-D [18:53:11] https://gerrit.wikimedia.org/r/#/c/138657/1/bin/mw-core-get.sh [18:53:26] Krinkle: and that extglob trick is rather nice [18:54:38] Project Flow-en.wikipedia.beta.wmflabs.org-linux-chrome build #481: SUCCESS in 8 min 50 sec: https://wmf.ci.cloudbees.com/job/Flow-en.wikipedia.beta.wmflabs.org-linux-chrome/481/ [18:54:38] * legoktm: Relay some API methods to the actual submodule [18:54:39] * ebernhardson: (bug 61939) Topic-titles not displaying in some topics (disappearing?) [18:54:39] * legoktm: Split out POST-specific logic from ApiFlowBase & add a new one for GET [18:54:40] * legoktm: Add ApiFlowViewHeader [18:54:40] * legoktm: Add ApiFlowViewTopicSummary [18:54:41] * legoktm: Display a proper error when an invalid workflow is provided [18:54:41] * legoktm: Add ApiFlowViewPost [18:54:42] * legoktm: Add ApiFlowViewTopic [18:54:42] * legoktm: Add ApiFlowViewTopicList [18:54:43] * legoktm: Deprecate existing read API [19:05:18] hashar: thx, I was going to ask you to yjoin ir [19:05:21] hashar: irc* [19:05:29] hashar: gonna deploy now [19:05:46] Krinkle: I would move the rm in the git-archive macro though [19:06:43] hashar: which macro? [19:06:50] Project UploadWizard-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_9 build #816: FAILURE in 12 min: https://wmf.ci.cloudbees.com/job/UploadWizard-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_9/816/ [19:07:17] Krinkle: looking [19:07:24] might be a shell script [19:07:37] hashar: you mean add an inline shell to macro get-mw-core? [19:07:41] - builder: [19:07:41] name: get-mw-core [19:07:41] builders: [19:07:41] - shell: "/srv/deployment/integration/slave-scripts/bin/mw-core-get.sh {branch}" [19:07:45] yes that one [19:07:47] Yes, hence I"m adding it to that script :) [19:07:55] and so I can roll it out at once [19:08:03] it is a bit nasty [19:08:03] I agree [19:08:11] since it either use git archive from the Gerrit replica [19:08:23] and fallback to the tarball on labs instances since they do not have the Gerrit replica [19:08:32] it needs to be cleaned either way though [19:08:40] so you could put the ext glob trick and rm -fR in that mw-core-get.sh script [19:08:52] That's what I just did [19:09:38] LOL [19:09:41] sorry timo [19:09:49] I though I was reviewing a JJB config change hehe [19:09:54] Tell me if I'm misssing something! [19:10:01] Alrighty [19:10:05] (03CR) 10Hashar: "+3 excellent Timo :-)" [integration/jenkins] - 10https://gerrit.wikimedia.org/r/138657 (https://bugzilla.wikimedia.org/66429) (owner: 10Krinkle) [19:10:09] no it is excellent [19:10:26] I'll get back to prepping dinner now, ppl are waiting [19:10:30] thx, kbye :) [19:10:32] that is well done, nicely commented and super trivial [19:10:38] have a good dinner! [19:14:14] 3Wikimedia / 3Continuous integration: Jenkins: Extension jobs are not reset properly (files no longer present in mediawiki-core@master still persist) - 10https://bugzilla.wikimedia.org/66429#c16 (10Krinkle) 5PATC>3RESO/FIX Confirmed fix by seeing that old files in skins/* are gone in workspaces on galliu... [19:14:56] hashar [19:16:09] Project Flow-test2.wikipedia.org-linux-chrome build #331: STILL FAILING in 8 min 16 sec: https://wmf.ci.cloudbees.com/job/Flow-test2.wikipedia.org-linux-chrome/331/ [19:16:10] * legoktm: Relay some API methods to the actual submodule [19:16:10] * ebernhardson: (bug 61939) Topic-titles not displaying in some topics (disappearing?) [19:16:11] * legoktm: Split out POST-specific logic from ApiFlowBase & add a new one for GET [19:16:11] * legoktm: Add ApiFlowViewHeader [19:16:12] * legoktm: Add ApiFlowViewTopicSummary [19:16:12] * legoktm: Display a proper error when an invalid workflow is provided [19:16:13] * legoktm: Add ApiFlowViewPost [19:16:13] * legoktm: Add ApiFlowViewTopic [19:16:14] * legoktm: Add ApiFlowViewTopicList [19:16:14] * legoktm: Deprecate existing read API [19:25:53] Project UploadWizard-commons.wikimedia.beta.wmflabs.org-linux-chrome build #881: SUCCESS in 9 min 41 sec: https://wmf.ci.cloudbees.com/job/UploadWizard-commons.wikimedia.beta.wmflabs.org-linux-chrome/881/ [19:27:16] Project browsertests-en.wikipedia.beta.wmflabs.org-linux-firefox build #884: SUCCESS in 20 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-linux-firefox/884/ [19:44:29] I upgraded Jenkins by mistake so it is busy restarting now :- [19:44:30] ( [19:44:35] and might end up being broken [20:00:47] 3Wikimedia / 3Continuous integration: browser test Jenkins host performance issue for timed builds - 10https://bugzilla.wikimedia.org/66449 (10Chris McMahon) 3NEW p:3Unprio s:3normal a:3None It seems that when we launch all the browser test builds that use headless Firefox at the same time, we are st... [20:12:09] Yippee, build fixed! [20:12:09] Project MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome build #503: FIXED in 44 min: https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/503/ [20:12:10] * jrobson: Alpha: Avoid multiple title parameters when rewriting url [20:12:10] * jrobson: Documentation: Add summary blocks to files in api directory [20:12:11] * jrobson: QA: Fix failing builds [20:12:11] * jrobson: Update file summary for phpdoc [20:12:12] * florian.schmidt.welzow: Respect Upload Settings on Special:Uploads [20:12:12] * jrobson: QA: Updating mobile VisualEditor browser test - alpha->beta [20:12:13] * kaldari: Migrate float and clear styles from parsoid styles to mobile [20:12:13] * kaldari: Fixing styling of full-size (non-thumbnail) images in mobile [20:38:29] 3Wikimedia / 3Continuous integration: Jenkins: Extension jobs are not reset properly (files no longer present in mediawiki-core@master still persist) - 10https://bugzilla.wikimedia.org/66429#c17 (10Bartosz DziewoƄski) Thank you! [20:44:46] 3Wikimedia / 3Continuous integration: Make RSS feeds public - 10https://bugzilla.wikimedia.org/66443#c1 (10Antoine "hashar" Musso) Jenkins is fundamentally screwed with our current setup. Whenever the RSS URLs are accessed it will attempt to parse all the build history to figure out the status of builds. S... [20:52:16] 3Wikimedia / 3Quality Assurance: stop using Net:HTTP:Persistent? - 10https://bugzilla.wikimedia.org/66451 (10Chris McMahon) 3NEW p:3Unprio s:3normal a:3None Reading the documentation and a cursory google search suggests that Net:HTTP:Persistent was useful for Ruby 1.8.x, but that the persistent funct... [20:55:32] (03PS1) 10Hashar: mw-core-get: restore cwd after cd [integration/jenkins] - 10https://gerrit.wikimedia.org/r/138720 [20:56:09] (03CR) 10Hashar: "Should fix up https://integration.wikimedia.org/ci/job/parsoidsvc-php-parsertests/1900/console" [integration/jenkins] - 10https://gerrit.wikimedia.org/r/138720 (owner: 10Hashar) [20:56:45] (03CR) 10Hashar: [C: 032] mw-core-get: restore cwd after cd [integration/jenkins] - 10https://gerrit.wikimedia.org/r/138720 (owner: 10Hashar) [20:56:48] (03Merged) 10jenkins-bot: mw-core-get: restore cwd after cd [integration/jenkins] - 10https://gerrit.wikimedia.org/r/138720 (owner: 10Hashar) [21:00:28] chrismcmahon: i believe that i have VE browser tests executing correctly in the vagrant environment [21:01:12] congratulations marxarelli ! [21:01:27] chrismcmahon: however, many of the tests are failing. can you take a look to see if they're failing "correctly" [21:01:38] hashar: thanks! [21:01:44] w00t [21:02:36] e.g. bullets.feature passes, anon.feature /almost/ passes [21:03:18] marxarelli: I think I got most of the way through installing vagrant locally the other day... [21:03:58] * chrismcmahon checks if I ever actually got 1.5.4 to install correctly... [21:04:17] chrismcmahon: mediawiki/vagrant should work with 1.6 now [21:04:37] marxarelli: awesome [21:04:53] chrismcmahon: with one extra installation step (should be in the readme) [21:05:56] marxarelli: OK, I'm downloading 1.6.3 now [21:06:36] chrismcmahon: and you might want to install vagrant-vbguest to avoid issues with VirtualBox Guest Additions not being up to date [21:06:59] chrismcmahon: vagrant plugin install vagrant-vbguest [21:07:11] (maybe we should add that suggestion to the readme) [21:07:16] (yes) [21:07:23] :) [21:07:53] marxarelli: and the mw.o page too http://www.mediawiki.org/wiki/Vagrant [21:08:18] rgr that [21:10:42] $ vagrant --version [21:10:42] Vagrant 1.6.3 [21:10:42] Administrator [21:10:59] $ vagrant plugin install vagrant-vbguest [21:11:00] Installing the 'vagrant-vbguest' plugin. This can take a few minutes... [21:11:00] Installed the plugin 'vagrant-vbguest (0.10.0)' [21:12:06] guessing I probably don't want to do 'git submodule update --init --recursive' from within the fix-mw-extension-browser-tests branch? [21:12:57] vagrant up is going... [21:13:39] * marxarelli puts down his half sandwich [21:13:51] "no, no more. we still have a long way to go" [21:14:08] marxarelli: YES! [21:14:21] best. reference. this. week. [21:14:29] haha [21:14:45] 5 more minutes... [21:14:46] it's only because i've started calling my dog Rock Biter [21:14:50] haha [21:15:02] (he's teething) [21:15:35] also, congrats on getting them going [21:15:52] hoping I won't have to do too much OSX hacking for this... [21:20:04] thanks! i'm just glad to be hacking again [21:23:04] i should clarify. i'm just glad to be hacking on something other than a Drupal website [21:23:27] this might bite me: [21:23:30] Could not find the X.Org or XFree86 Window System, skipping. [21:23:30] An error occurred during installation of VirtualBox Guest Additions 4.3.12. Some functionality may not work as intended. [21:23:30] In most cases it is OK that the "Window System drivers" installation failed. [21:24:12] chrismcmahon: shouldn't be a problem [21:24:20] ok [21:25:37] If I smoked, I'd go have a cigarette while this installs... [21:26:42] i remember those day... [21:26:53] *days* (there were many) [21:27:30] Project browsertests-en.wikipedia.beta.wmflabs.org-linux-chrome build #900: SUCCESS in 18 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-linux-chrome/900/ [21:29:45] Project MultimediaViewer-en.wikipedia.beta.wmflabs.org-linux-chrome build #54: SUCCESS in 2 min 14 sec: https://wmf.ci.cloudbees.com/job/MultimediaViewer-en.wikipedia.beta.wmflabs.org-linux-chrome/54/ [21:29:45] l10n-bot: Localisation updates from https://translatewiki.net. [21:29:53] still watching but been stuck on thsi step for a while: ==> default: notice: /Stage[main]/Redis/Package[redis-server]/ensure: ensure changed 'purged' to 'present' [21:30:04] aaaand, unstuck.... [21:30:37] the ruby build takes a bit as well [21:32:50] Project MultimediaViewer-mediawiki.org-linux-firefox build #112: SUCCESS in 3 min 4 sec: https://wmf.ci.cloudbees.com/job/MultimediaViewer-mediawiki.org-linux-firefox/112/ [21:32:50] l10n-bot: Localisation updates from https://translatewiki.net. [21:33:13] Project WikiLove-en.wikipedia.beta.wmflabs.org-linux-firefox build #223: SUCCESS in 2 min 11 sec: https://wmf.ci.cloudbees.com/job/WikiLove-en.wikipedia.beta.wmflabs.org-linux-firefox/223/ [21:33:22] Project ZeroRatedMobileAccess-en.m.wikipedia.org-linux-phantomjs build #227: STILL FAILING in 31 sec: https://wmf.ci.cloudbees.com/job/ZeroRatedMobileAccess-en.m.wikipedia.org-linux-phantomjs/227/ [21:38:30] ooh y'know marxarelli my biggest issue with VE tests right now is not actually the tests, but that my user gets logged out often. if we could repro this on vagrant and point wireshark or something at a failure, that would be cool: https://bugzilla.wikimedia.org/show_bug.cgi?id=65709 [21:38:58] marxarelli: it's a bug almost certainly happening in prod but fiendishly difficult to repro [21:39:17] has anyone been able to repro it locally? [21:39:47] marxarelli: yes, Rummana captured a repro manually, and I've seen it but not documented it. it happens much more often with the automation [21:39:57] got it [21:40:45] marxarelli: James is aware of vague reports of users being logged out in the wild, but nobody has any details [21:40:54] ah nice, Rumana did repo it? that's good. [21:40:55] been happening for several weeks now [21:41:12] greg-g: yes, it's in the bug comments [21:42:06] a lot of the failures i'm seeing are on account of watir wait timeouts. i'm wondering if the vm is performing well enough [21:42:11] Project Flow-en.wikipedia.beta.wmflabs.org-linux-firefox build #481: SUCCESS in 8 min 57 sec: https://wmf.ci.cloudbees.com/job/Flow-en.wikipedia.beta.wmflabs.org-linux-firefox/481/ [21:42:11] * legoktm: Relay some API methods to the actual submodule [21:42:12] * ebernhardson: (bug 61939) Topic-titles not displaying in some topics (disappearing?) [21:42:12] * legoktm: Split out POST-specific logic from ApiFlowBase & add a new one for GET [21:42:13] * legoktm: Add ApiFlowViewHeader [21:42:13] * legoktm: Add ApiFlowViewTopicSummary [21:42:14] * legoktm: Display a proper error when an invalid workflow is provided [21:42:14] * legoktm: Add ApiFlowViewPost [21:42:15] * legoktm: Add ApiFlowViewTopic [21:42:16] * legoktm: Add ApiFlowViewTopicList [21:42:16] * legoktm: Deprecate existing read API [21:42:16] * l10n-bot: Localisation updates from https://translatewiki.net. [21:42:21] Mobile has a similar issue, because they had some custom token/session handline. they removed it to use session handling in core, then the bug started showing up in VE but stopped showing up in MF. [21:42:30] s/has/had/ [21:42:34] i had to bump my vm memory up to 1.5G to execute some of them [21:43:21] vagrant up finished just now [21:43:31] Project UploadWizard-api-commons.wikimedia.beta.wmflabs.org build #591: SUCCESS in 1 min 20 sec: https://wmf.ci.cloudbees.com/job/UploadWizard-api-commons.wikimedia.beta.wmflabs.org/591/ [21:43:32] l10n-bot: Localisation updates from https://translatewiki.net. [21:46:15] Project MultimediaViewer-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_9 build #54: SUCCESS in 2 min 44 sec: https://wmf.ci.cloudbees.com/job/MultimediaViewer-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_9/54/ [21:46:16] * tgr.huwiki: Toggle metadata panel on up/down keypress [21:46:16] * l10n-bot: Localisation updates from https://translatewiki.net. [21:47:00] Nemo_bis: can you confirm lack of CSS http://deployment.wikimedia.beta.wmflabs.org/wiki/Special:RecentChanges ? [21:47:36] Project UploadWizard-api-commons.wikimedia.org build #490: SUCCESS in 1 min 19 sec: https://wmf.ci.cloudbees.com/job/UploadWizard-api-commons.wikimedia.org/490/ [21:47:36] l10n-bot: Localisation updates from https://translatewiki.net. [21:53:01] Project browsertests-test2.wikipedia.org-linux-chrome build #1133: STILL FAILING in 19 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-linux-chrome/1133/ [21:55:55] marxarelli: so I am looking at a shell on the vagrant image from VirtualBox. I do "list-roles" at the shell prompt and response is "command not found" [21:56:54] chrismcmahon: did you build and install the mediawiki-vagrant plugin? [21:57:50] since vagrant 1.6, plugins must be installed. they can't be included from within the Vagrantfile [22:00:12] marxarelli: I did git clone ssh://cmcmahon@gerrit.wikimedia.org:29418/mediawiki/vagrant then git review -d 138662 then vagrant plugin install vagrant-vbguest then vagrant up from there [22:00:15] chrismcmahon: the readme should contain instructions on how to install it [22:00:44] yeah, there's an extra step for 1.6 [22:00:54] well, steps technically [22:01:11] gem build mediawiki-vagrant.gemspec [22:01:21] vagrant plugin install mediawiki-vagrant-0.0.1.gem [22:04:07] we could simplify the plugin installation (both of them) with a rake task [22:04:47] Project MobileFrontend-en.m.wikipedia.org-linux-firefox build #526: STILL FAILING in 11 min: https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.org-linux-firefox/526/ [22:04:47] * jrobson: Alpha: Avoid multiple title parameters when rewriting url [22:04:48] * jrobson: Documentation: Add summary blocks to files in api directory [22:04:48] * jrobson: Hygiene: Kill dead variable [22:04:57] * jrobson: QA: Fix failing builds [22:04:57] * jrobson: Update file summary for phpdoc [22:04:57] * florian.schmidt.welzow: Respect Upload Settings on Special:Uploads [22:04:57] * jrobson: QA: Updating mobile VisualEditor browser test - alpha->beta [22:04:57] * kaldari: Migrate float and clear styles from parsoid styles to mobile [22:04:57] * kaldari: Fixing styling of full-size (non-thumbnail) images in mobile [22:05:49] don't look now, but bits on beta cluster isn't loading :) [22:05:53] got vagrant list-roles now [22:05:57] matma and trevor are fixing [22:07:52] Project browsertests-test2.wikipedia.org-linux-firefox build #1110: STILL FAILING in 20 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-linux-firefox/1110/ [22:12:55] Project UploadWizard-commons.wikimedia.beta.wmflabs.org-linux-firefox build #840: SUCCESS in 8 min 6 sec: https://wmf.ci.cloudbees.com/job/UploadWizard-commons.wikimedia.beta.wmflabs.org-linux-firefox/840/ [22:12:55] l10n-bot: Localisation updates from https://translatewiki.net. [22:20:07] ==> default: notice: /Stage[main]/Browsertests/Mediawiki::User[Selenium_user]/Exec[mediawiki user Selenium_user]/returns: executed successfully [22:20:18] neato marxarelli ^^ [22:21:40] yeah, i thought it would be helpful to set up defaults for all the env variables that are required [22:23:32] chrismcmahon: i noticed we're using the headless gem. has anyone experimented with headless firefox and video capture [22:25:01] marxarelli: we have headless FF and screenshot working (at least in some places) I don't think we've tried screencasts yet, because we have those available from SauceLabs [22:27:08] chrismcmahon: right. i was just thinking of it as a possible alternative to having to use x-forwarding and xquartz on a mac [22:28:23] i.e. record a screencast of the headless browser and only show it upon failure. of course, i'm making the assumption that nobody cares what passing tests look like [22:30:17] ok, http://127.0.0.1:8080/wiki/Main_Page?veaction=edit works [22:31:40] Project browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_10 build #705: STILL FAILING in 23 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_10/705/ [22:32:58] Project UploadWizard-api-commons.wikimedia.beta.wmflabs.org build #592: SUCCESS in 1 min 15 sec: https://wmf.ci.cloudbees.com/job/UploadWizard-api-commons.wikimedia.beta.wmflabs.org/592/ [22:34:12] marxarelli: next move? I have VE available at localhost now [22:35:39] vagrant ssh -- -Y [22:35:51] cd /vagrant/mediawiki/extensions/VisualEditor/modules/ve-mw/tes [22:35:51] t/browser [22:36:06] bundle exec cucumber features/headings.feature [22:36:20] that feature should pass [22:36:37] Project browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_8 build #740: STILL FAILING in 23 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_8/740/ [22:37:18] OK, running [22:40:59] marxarelli: might be an allocation problem? [22:41:02] Given I go to the "Bullets VisualEditor Test" page with content "Bullets VisualEditor Test" # features/step_definitions/shared_steps.rb:10 [22:41:02] Unable to pick a platform for the provided browser. [22:41:02] nil was passed to the PageObject constructor instead of a valid browser object. (RuntimeError) [22:41:20] tells me FF didn't start correctly [22:41:23] or at all [22:41:40] do you have xquartz installed in os x? [22:42:14] i would try starting firefox from that same ssh session [22:43:41] and see what it spits out [22:44:31] also, you'll likely need to logout/login of osx after installing xquartz [22:44:45] blek. these dependencies are annoying [22:47:58] ok. I don't think I have xquartz [22:48:13] trying one more time just to see what it does [22:51:01] I did a ton of work in X back around 2004, I am really rusty [22:54:09] installing xquartz... [22:57:03] brb xquartz :-) [23:06:04] marxarelli: this is really great! [23:06:10] 6 scenarios (6 passed) [23:06:10] 48 steps (48 passed) [23:06:20] nice! [23:06:39] and yeah, there are a few VE that won't pass right now on a bare wiki but I can fix that quickly. like probably tomorrow [23:07:13] marxarelli: all the MobileFrontend tests and /mediawiki/core tests *should* pass on a bare wiki though [23:07:51] fantastic [23:07:53] marxarelli: thanks, that was a lot of moving parts to orchestrate [23:09:42] no sweat. i enjoy these problems [23:10:07] rock. [23:22:37] marxarelli: so if I update the /tests/browser repo then I would want to do "vagrant git-update" to get those changes to my local vm, yes? [23:23:41] i'm not sure how git-update works [23:24:15] you could ostensibly just do a git fetch/pull from the host os [23:24:34] in the vagrant/mediawiki/extensions/VisualEditor directory [23:24:47] marxarelli: me neither :-) but Ori's original docs indicate that it should. http://www.mediawiki.org/wiki/Vagrant#How_do_I....3F [23:24:57] oh, ok [23:25:42] but yeah, that seems sort of magical, git pull from the VM seems less magical [23:28:53] marxarelli: one question: I see that the env vars for e.g. MEDIAWIKI_URL are set properly. where does that happen? (I think it would be convenient to add one BROWSER=firefox) [23:30:00] they're declared in puppet/modules/browsertests/manifests/init.pp [23:32:08] isn't firefox already the default browser used by mediawiki_selenium? [23:33:41] in either case, we have definitely add that [23:34:06] marxarelli: yes, but I had an issue with edit contention on target wiki pages so I use $BROWSER to send the test to one page or another page [23:35:33] I could do y'know "unless $BROWSER firefox", but it's nice to have it specified and not just rely on the default [23:38:27] chrismcmahon:Hi Chris! [23:38:37] are you busy right now? [23:38:57] chrismcmahon: cool. i'll add it [23:39:06] I am right now beginning my work on another issue changing should to expect [23:39:07] hi Jagori I am around for a few more minutes [23:39:16] Okay .. [23:39:32] Jagori: that's great, thank you! [23:39:35] I was reading somewhere is ther any spec/spec_helper.rb [23:39:50] couldntlocate it [23:40:39] am not sure if I actually need to change there anything or not ..changes made to this file will stop RSpec from adding should to all objects [23:40:45] am not sure if we want to do this [23:41:12] although as of now my main focus is to change should to expect [23:41:19] in step defn files only [23:42:13] Jagori: I do not think we have any spec_helper locally, but we do use the spec_helper in the page_object gem https://github.com/cheezy/page-object/tree/master/spec [23:42:26] Jagori: that's a good question for the QA mail list [23:42:47] but maybe later on if we want to strictly apply expect syntax we might need to apply a change to spec_helper.rb [23:43:05] okay [23:43:07] :) [23:43:18] Jagori: good point, I am not sure exactly how we interact with the upstream spec_helper [23:43:44] okay so as of now its a page object you are saying [23:44:06] should I mail my doubt on the mailing list [23:44:28] probably I would get more clarity on the usage [23:45:03] also there's a tool called Transpec [23:45:19] which converts specs to latest rSPec syntax [23:45:20] Jagori: looking a little closer I don't think the page_object thing will affect us.e [23:46:48] okay yes.. are we using RSpec 2 [23:46:48] I guess we are not using 3 right? [23:46:48] if am not mistaken [23:46:58] the Transpec tool is good for conversion [23:47:07] and there is no need to add anything to Gemfile too [23:47:24] I came to know of this tool from relishapp [23:47:37] let me analyse a bit more :) [23:47:39] then [23:49:45] Jagori: we want to move to RSpec 3. marxarelli you're aware of this should vs expect thing in RSpec? https://github.com/rspec/rspec-expectations/blob/master/Should.md [23:50:09] (we have a whole lot of should and no expect at all right now) [23:50:46] chrismcmahon: yes [23:51:44] let me introduce you :-) Jagori is a volunteer contributor, marxarelli is our new Automation Engineer [23:52:04] Hi :) Marxarelli [23:52:07] nice to meet you [23:52:08] :) [23:52:10] Jagori: nice to meet you [23:53:06] I was wondering if we have to make any changes finally to spec_helper.rb [23:53:53] also there is a tool Transpec which might help us to convert to RSpec3 syntax [23:53:53] https://github.com/yujinakayama/transpec [23:53:56] Jagori: I think the answer is "no". We haven't defined any custom matchers or otherwise changes out-of-the-box RSpec [23:54:07] changed [23:54:18] Hmm okay [23:54:46] so then I should rather change the syntaxjust as of now from should to expect [23:55:10] in hindsight, we probably should have [23:55:15] we are probably using 2.14 [23:55:54] Jagori: do me a favor and send a message to the QA mail list so Zeljko can reply also [23:56:34] Okay thanks [23:56:34] :) [23:56:54] sure I would do that [23:56:56] as well [23:57:05] Jagori: i second that. there are a number of changes in rspec that we'll have to review [23:57:31] marxarelli:Yes [23:57:45] i'm not aware enough yet to say how in-depth our review needs to be :) [23:57:47] Also I have a session with Zeljko tomorrow too [23:58:33] :) [23:59:11] marxarelli:but yes since expect is the latest syntax we should rather start using it [23:59:23] Jagori: yes, definitely