[00:00:38] I know we have really basic should and should_not in place in all of the repos, but I'm not sure the best approach to change that [00:09:05] chrismcmahon: you're right. sorry for the snap "definitely". let's discuss it on the ML [00:11:54] chrismcmahon: Hi Chris! I guess will post the discussion on QA mailing list or maybe would discuss once with Zeljko tomorrow too further [00:12:02] my network is down [00:12:12] marxarelli:thanks so much [00:12:18] :) [00:48:52] Project UploadWizard-api-commons.wikimedia.beta.wmflabs.org build #593: SUCCESS in 1 min 27 sec: https://wmf.ci.cloudbees.com/job/UploadWizard-api-commons.wikimedia.beta.wmflabs.org/593/ [00:55:45] Project UploadWizard-api-commons.wikimedia.org build #491: SUCCESS in 1 min 21 sec: https://wmf.ci.cloudbees.com/job/UploadWizard-api-commons.wikimedia.org/491/ [02:50:37] (03CR) 10Krinkle: [C: 04-1] "See comment on I33ead93b1fb8. Open to other ideas, but for now would like to block this." [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/138612 (owner: 10Jackmcbarn) [03:01:08] (03CR) 10Krinkle: "Many of these are not check jobs but test-pipeline jobs (npm, jsduck, qunit). Can you remove those and/or amend message?" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/136993 (https://bugzilla.wikimedia.org/63936) (owner: 10Hashar) [03:02:56] 3Wikimedia / 3Continuous integration: Drop some Jenkins jobs history - 10https://bugzilla.wikimedia.org/63936#c3 (10Krinkle) I'm curious why mwcore and puppet specifically. Maybe do it from the default settings in jjb-config for all jobs? [03:08:55] Project MultimediaViewer-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_10 build #54: SUCCESS in 2 min 26 sec: https://wmf.ci.cloudbees.com/job/MultimediaViewer-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_10/54/ [03:08:55] * tgr.huwiki: Show Commons link to logged out users [03:08:56] * tgr.huwiki: Toggle metadata panel on up/down keypress [03:08:56] * l10n-bot: Localisation updates from https://translatewiki.net. [03:08:57] * mtraceur: Add "zoom" but really just view-file [03:13:57] (03CR) 10Krinkle: Refactor doc publishing from labs (032 comments) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/134840 (owner: 10Hashar) [03:18:44] (03CR) 10Krinkle: Refactor doc publishing from labs (031 comment) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/134840 (owner: 10Hashar) [03:25:31] (03PS9) 10Krinkle: Refactor doc publishing from labs [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/134840 (owner: 10Hashar) [03:26:17] (03CR) 10Krinkle: Refactor doc publishing from labs (031 comment) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/134840 (owner: 10Hashar) [03:27:20] (03PS10) 10Krinkle: Refactor doc publishing from labs [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/134840 (owner: 10Hashar) [03:32:29] Project browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_9 build #774: SUCCESS in 23 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_9/774/ [03:34:27] Project browsertests-test2.wikipedia.org-windows-internet_explorer_10 build #695: STILL FAILING in 23 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-windows-internet_explorer_10/695/ [03:41:48] Project Flow-test2.wikipedia.org-linux-firefox build #298: STILL FAILING in 7 min 16 sec: https://wmf.ci.cloudbees.com/job/Flow-test2.wikipedia.org-linux-firefox/298/ [03:41:48] * l10n-bot: Localisation updates from https://translatewiki.net. [03:41:49] * ebernhardson: Only merge external content once [03:49:12] Project Flow-en.wikipedia.beta.wmflabs.org-linux-chrome build #482: SUCCESS in 7 min 22 sec: https://wmf.ci.cloudbees.com/job/Flow-en.wikipedia.beta.wmflabs.org-linux-chrome/482/ [03:49:13] * l10n-bot: Localisation updates from https://translatewiki.net. [03:49:13] * ebernhardson: Only merge external content once [03:59:46] Project UploadWizard-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_9 build #817: STILL FAILING in 10 min: https://wmf.ci.cloudbees.com/job/UploadWizard-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_9/817/ [03:59:47] l10n-bot: Localisation updates from https://translatewiki.net. [04:09:41] Project Flow-test2.wikipedia.org-linux-chrome build #332: STILL FAILING in 7 min 7 sec: https://wmf.ci.cloudbees.com/job/Flow-test2.wikipedia.org-linux-chrome/332/ [04:09:42] * l10n-bot: Localisation updates from https://translatewiki.net. [04:09:42] * ebernhardson: Only merge external content once [04:16:26] Project browsertests-en.wikipedia.beta.wmflabs.org-linux-firefox build #885: SUCCESS in 16 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-linux-firefox/885/ [04:18:30] Project UploadWizard-commons.wikimedia.beta.wmflabs.org-linux-chrome build #882: SUCCESS in 8 min 42 sec: https://wmf.ci.cloudbees.com/job/UploadWizard-commons.wikimedia.beta.wmflabs.org-linux-chrome/882/ [04:18:31] l10n-bot: Localisation updates from https://translatewiki.net. [04:46:33] Yippee, build fixed! [04:46:34] Project VisualEditor-en.wikipedia.beta.wmflabs.org-linux-firefox build #50: FIXED in 30 min: https://wmf.ci.cloudbees.com/job/VisualEditor-en.wikipedia.beta.wmflabs.org-linux-firefox/50/ [04:46:35] * moriel: Disable/Enable alignment select widget with checkbox [04:46:35] * l10n-bot: Localisation updates from https://translatewiki.net. [04:46:35] * roan.kattouw: Update VE core submodule to master (ba8872e) [04:46:36] * roan.kattouw: Update VE core submodule to master (e1b0e33) [04:58:13] Project MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome build #504: SUCCESS in 39 min: https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/504/ [04:58:14] * jrobson: Ignore tests directory when running `make phpdocs` [04:58:14] * jrobson: Hygiene: Kill dead variable [05:23:37] Project MultimediaViewer-en.wikipedia.beta.wmflabs.org-linux-firefox build #283: SUCCESS in 1 min 48 sec: https://wmf.ci.cloudbees.com/job/MultimediaViewer-en.wikipedia.beta.wmflabs.org-linux-firefox/283/ [05:23:37] * tgr.huwiki: Show Commons link to logged out users [05:23:38] * tgr.huwiki: Toggle metadata panel on up/down keypress [05:23:38] * l10n-bot: Localisation updates from https://translatewiki.net. [05:23:39] * mtraceur: Add "zoom" but really just view-file [05:49:10] Project UploadWizard-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_10 build #704: STILL FAILING in 10 min: https://wmf.ci.cloudbees.com/job/UploadWizard-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_10/704/ [06:05:34] Project browsertests-en.wikipedia.beta.wmflabs.org-linux-chrome build #901: SUCCESS in 16 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-linux-chrome/901/ [06:07:31] Project MultimediaViewer-en.wikipedia.beta.wmflabs.org-linux-chrome build #55: SUCCESS in 1 min 57 sec: https://wmf.ci.cloudbees.com/job/MultimediaViewer-en.wikipedia.beta.wmflabs.org-linux-chrome/55/ [06:07:31] * tgr.huwiki: Show Commons link to logged out users [06:07:32] * tgr.huwiki: Toggle metadata panel on up/down keypress [06:07:32] * mtraceur: Add "zoom" but really just view-file [06:07:58] 30 min late... no, huh, I see CSS http://deployment.wikimedia.beta.wmflabs.org/wiki/Special:RecentChanges [06:09:00] Project MultimediaViewer-mediawiki.org-linux-firefox build #113: SUCCESS in 2 min 35 sec: https://wmf.ci.cloudbees.com/job/MultimediaViewer-mediawiki.org-linux-firefox/113/ [06:09:01] * tgr.huwiki: Show Commons link to logged out users [06:09:01] * tgr.huwiki: Toggle metadata panel on up/down keypress [06:09:02] * mtraceur: Add "zoom" but really just view-file [06:09:21] Project WikiLove-en.wikipedia.beta.wmflabs.org-linux-firefox build #224: SUCCESS in 1 min 48 sec: https://wmf.ci.cloudbees.com/job/WikiLove-en.wikipedia.beta.wmflabs.org-linux-firefox/224/ [06:09:31] Project ZeroRatedMobileAccess-en.m.wikipedia.org-linux-phantomjs build #228: STILL FAILING in 28 sec: https://wmf.ci.cloudbees.com/job/ZeroRatedMobileAccess-en.m.wikipedia.org-linux-phantomjs/228/ [06:17:10] Project Flow-en.wikipedia.beta.wmflabs.org-linux-firefox build #482: SUCCESS in 7 min 49 sec: https://wmf.ci.cloudbees.com/job/Flow-en.wikipedia.beta.wmflabs.org-linux-firefox/482/ [06:17:11] ebernhardson: Only merge external content once [06:19:39] Project MultimediaViewer-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_9 build #55: SUCCESS in 2 min 28 sec: https://wmf.ci.cloudbees.com/job/MultimediaViewer-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_9/55/ [06:19:40] * tgr.huwiki: Show Commons link to logged out users [06:19:40] * mtraceur: Add "zoom" but really just view-file [06:27:18] Project browsertests-test2.wikipedia.org-linux-chrome build #1134: STILL FAILING in 17 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-linux-chrome/1134/ [06:37:24] Project browsertests-test2.wikipedia.org-linux-firefox build #1111: STILL FAILING in 17 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-linux-firefox/1111/ [06:38:01] Project MobileFrontend-en.m.wikipedia.org-linux-firefox build #527: STILL FAILING in 10 min: https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.org-linux-firefox/527/ [06:38:02] jrobson: Ignore tests directory when running `make phpdocs` [06:45:19] Project UploadWizard-commons.wikimedia.beta.wmflabs.org-linux-firefox build #841: SUCCESS in 7 min 54 sec: https://wmf.ci.cloudbees.com/job/UploadWizard-commons.wikimedia.beta.wmflabs.org-linux-firefox/841/ [07:01:56] Yippee, build fixed! [07:01:56] Project browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_10 build #706: FIXED in 23 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_10/706/ [07:03:10] Project UploadWizard-api-commons.wikimedia.beta.wmflabs.org build #594: SUCCESS in 1 min 14 sec: https://wmf.ci.cloudbees.com/job/UploadWizard-api-commons.wikimedia.beta.wmflabs.org/594/ [07:04:25] Project UploadWizard-api-commons.wikimedia.org build #492: SUCCESS in 1 min 14 sec: https://wmf.ci.cloudbees.com/job/UploadWizard-api-commons.wikimedia.org/492/ [07:09:53] Project browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_8 build #741: STILL FAILING in 24 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_8/741/ [08:03:07] good morning [09:40:59] hashar: suggestions on how to test https://gerrit.wikimedia.org/r/#/c/138555/ ? [09:41:08] Nemo_bis: write code? [09:41:31] holy hell [09:52:34] Nemo_bis: honestly I never bothered investigating the difference between Xml::check() and Html::check() [09:52:37] Nemo_bis: I replied there [09:52:43] that is some tech debt hehe [09:53:09] Nemo_bis: and yeah, should probably made in smaller patchsets [09:53:20] with deprecation notices but that might slow down the code [09:54:03] thanks for input [09:58:26] 3Wikimedia / 3Continuous integration: Import some content on beta.wmflabs.org wikis - 10https://bugzilla.wikimedia.org/66402#c3 (10Andre Klapper) p:5Unprio>3Low s:5normal>3enhanc "Import some content" sounds valid but blocked by beta cluster not powerful enough (comment 1). Nemo: What is the criteri... [10:04:27] 3Wikimedia / 3Continuous integration: Import some content on beta.wmflabs.org wikis - 10https://bugzilla.wikimedia.org/66402#c4 (10Nemo) (In reply to Andre Klapper from comment #3) > Nemo: What is the criteria for "ar de en eo fa hi ja ko ru sq uk zh"? Just the list of existing and empty wikis. > Could >... [12:48:49] Project UploadWizard-api-commons.wikimedia.beta.wmflabs.org build #595: SUCCESS in 1 min 25 sec: https://wmf.ci.cloudbees.com/job/UploadWizard-api-commons.wikimedia.beta.wmflabs.org/595/ [12:55:45] Project UploadWizard-api-commons.wikimedia.org build #493: SUCCESS in 1 min 21 sec: https://wmf.ci.cloudbees.com/job/UploadWizard-api-commons.wikimedia.org/493/ [15:19:24] Krinkle: https://wiki.jenkins-ci.org/display/JENKINS/Docker+Plugin || his plugin allows slaves to be dynamically provisioned using Docker. [15:19:48] seems we can get our own image on some machines, setup docker daemon on them [15:20:03] then add each of the docker daemon in Jenkins and the plugin supposedly spawn vm on the fly [15:20:15] I give it a try in labs, the boot up is super fast [15:32:07] docker *is* the new hotness ;) [15:42:03] hashar: greg-g could you include Dan Duvall in the docker discussion? He's been doing some awesome improvements to Vagrant in the week or so since we hired him, he'd probably be good with docker [15:42:30] yeah I should point him to the RFC I am writing up with ops regarding jenkins isolation [15:43:47] gotta rewrite some parts though [15:44:08] greg-g: during thecheckin yesterday i talked about documenting how to push a new infrastructure in production [15:44:14] i.e. the workflow from idea down to having it in prod [15:44:26] the context was the content translation server [15:44:37] I can't remember where to send the email / whom to ask [15:50:28] I am out of here, will figure it out tomorrow :] [16:04:20] oops, had to do kid handoff, will email hashar [17:33:01] (03PS1) 10Krinkle: Remove old "-npmtest" macro and job templates [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/138850 [17:42:10] (03CR) 10Krinkle: [C: 032] "No change in job output, this macro and the templates were unused." [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/138850 (owner: 10Krinkle) [17:43:26] (03Merged) 10jenkins-bot: Remove old "-npmtest" macro and job templates [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/138850 (owner: 10Krinkle) [17:43:28] 3Wikimedia / 3Continuous integration: Jenkins: Extension jobs are not reset properly (files no longer present in mediawiki-core@master still persist) - 10https://bugzilla.wikimedia.org/66429 (10Jon) 5PATC>3RESO/FIX [17:48:29] marxarelli: James_F this patch should make all the VE browser tests pass on Vagrant (and everywhere else) (except the verify_production_wikis test of course) https://gerrit.wikimedia.org/r/#/c/138837/ [17:50:18] chrismcmahon: awesome. i'll give it a spin to confirm against my recent vagrant changes [17:52:57] marxarelli: we talked about setting the env var BROWSER=firefox; the tests should work without that but they would be more elegant (ha) with [17:53:39] chrismcmahon: i've modified the browsertests puppet class to include BROWSER [17:53:49] schweet [17:53:53] chrismcmahon: what was the reason for that though? [17:53:58] i didn't quite understand [17:54:51] marxarelli: in shared_steps.rb I have: [17:54:54] Given(/^I go to the browser specific edit page page$/) do [17:54:54] page_title = "Edit page for " + ENV['BROWSER'] [17:55:32] marxarelli: because we run builds per-browser-per-target and that avoids edit contention for the same target page when using different browsers [17:55:51] i see [17:56:24] marxarelli: which is actually OK if BROWSER is not set, it will just default to firefox and the target page with title "Edit page for" (which is goofy but not wrong) [17:56:25] it that because tests run in parallel (do they?) or because they leave cruft behind when they break, or none of the above? [17:57:03] marxarelli: because parallel. if a Chrome build and a FF build run at the same time editing the same page they cause unexpected edit conflict messages [17:57:18] chrismcmahon: i see. that makes sense [17:57:51] couldn't we just generate some unique hash at the beginning of each test to ensure isolation? [17:58:04] marxarelli: also with this change, the tests stop leaving cruft. the page contents are reset each time the page runs (which is another potential source of unexpected results when multiple builds target the same page) [17:58:27] (03PS1) 10Krinkle: Clean up and re-order [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/138861 [17:59:22] marxarelli: we do that for some tests, we have a @random_string value that can be re-used per suite. The problem with that is that no wiki page is ever truly deleted, so teardown doesn't really work [18:00:08] chrismcmahon: is the concern that we're leaving too much cruft behind? [18:00:28] (03CR) 10Krinkle: [C: 032] "layoutdiff test is clean." [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/138861 (owner: 10Krinkle) [18:00:29] marxarelli: basically yes [18:00:32] (just trying to understand the test environment a bit better) [18:00:32] (03Merged) 10jenkins-bot: Clean up and re-order [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/138861 (owner: 10Krinkle) [18:00:43] got it [18:00:58] (03PS1) 10Ori.livneh: operations-apache-config: update directory sed pattern [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/138863 [18:01:22] marxarelli: we have e.g. a test to create a page that leaves behind page like http://en.wikipedia.beta.wmflabs.org/wiki/0.9753751036924678 [18:04:00] for local testing in vagrant, do you think it might be worthwhile to try lower level ways of isolating the tests (database snapshot/rollback or something similar)? [18:05:16] (03CR) 10Dzahn: [C: 031] operations-apache-config: update directory sed pattern [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/138863 (owner: 10Ori.livneh) [18:07:12] (03CR) 10Krinkle: "Will compile and deploy shortly." [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/138863 (owner: 10Ori.livneh) [18:08:56] Project MultimediaViewer-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_10 build #55: SUCCESS in 2 min 29 sec: https://wmf.ci.cloudbees.com/job/MultimediaViewer-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_10/55/ [18:12:07] (03PS1) 10Krinkle: Clean up phpcs [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/138869 [18:12:50] (03PS1) 10Krinkle: Remove unused npmtest configuration [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/138871 [18:13:08] marxarelli: I think a db snapshot/ rollback thing would be awesome. it's not really practical in beta labs, but we're talking about creating new test envs Real Soon Now where that might be possible (attn: greg-g) [18:13:10] (03CR) 10Krinkle: [C: 032] "Clean layoutdiff test." [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/138869 (owner: 10Krinkle) [18:14:02] (03Merged) 10jenkins-bot: Clean up phpcs [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/138869 (owner: 10Krinkle) [18:14:27] marxarelli: I am getting back to https://gerrit.wikimedia.org/r/#/c/133507 and I don't think your inline comments got saved. (inline comments are a hassle in gerrit, I always forget how to get them saved properly) [18:15:05] chrismcmahon: oh, grr [18:15:22] chrismcmahon: i'm seeing them for patchset 10 [18:15:24] marxarelli: but I did update the README, that was a good idea [18:15:29] aha, looking [18:15:35] i noticed that they get buried pretty quickly [18:16:08] chrismcmahon: oh, nice [18:17:22] (03CR) 10Krinkle: [C: 032] "Empty layoutdiff." [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/138871 (owner: 10Krinkle) [18:17:27] (03Merged) 10jenkins-bot: Remove unused npmtest configuration [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/138871 (owner: 10Krinkle) [18:17:49] (03PS1) 10Krinkle: Clean up whitespace between code and comments [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/138873 [18:18:05] (03CR) 10Krinkle: [C: 032] Clean up whitespace between code and comments [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/138873 (owner: 10Krinkle) [18:18:09] (03Merged) 10jenkins-bot: Clean up whitespace between code and comments [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/138873 (owner: 10Krinkle) [18:19:21] (03PS2) 10Krinkle: operations-apache-config: Add /usr/local/apache/conf/ to filter pattern [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/138863 (owner: 10Ori.livneh) [18:21:48] (03CR) 10Krinkle: [C: 032] "Recompiled operations-apache-config-lint and pushed to Jenkins." [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/138863 (owner: 10Ori.livneh) [18:23:02] (03Merged) 10jenkins-bot: operations-apache-config: Add /usr/local/apache/conf/ to filter pattern [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/138863 (owner: 10Ori.livneh) [18:29:02] manybubbles: hello [18:29:22] hashar: hi! just fixed it, actually [18:29:26] it was caused by a core change [18:29:32] o really? [18:29:43] yeah [18:29:54] have we restored back compatibility? [18:29:57] core change caused a cite test failure [18:30:03] just updated the cite tests [18:30:11] marxarelli: updateded and commenteded: https://gerrit.wikimedia.org/r/#/c/133507/ [18:30:41] manybubbles: good to know. The Cite tests are only run when a patch is sent, so we are very lucky to have detected the issue via the CirrusSearch tests [18:31:04] manybubbles: I want to eventually run the tests for ALL extensions whenever a change is proposed to ANY of those extensions [18:31:11] hashar: it was more annoying than anything - just some spacing changes [18:31:17] hashar: yeah, that [18:31:20] that'll be fun [18:31:31] i.e. a change proposed to core would also run the Cite / CirrusSearch etc tests [18:31:36] yeah that is going to be fun [18:31:48] I am building up an utility to make it possible [18:32:02] happy to see you fixed it [18:34:06] hashar: I sent an email in response to your irc question, hope it was the right answer [18:34:49] Project browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_9 build #775: SUCCESS in 26 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_9/775/ [18:36:56] greg-g: yeah more or less : [18:36:58] °) [18:38:06] Project browsertests-test2.wikipedia.org-windows-internet_explorer_10 build #696: STILL FAILING in 26 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-windows-internet_explorer_10/696/ [18:38:10] greg-g: the idea was to formally document the process to build a new piece of infra. Ie design -> ops review -> procurement -> deployment etc [18:39:30] I approve of this idea :) [18:39:44] let me know when I should help out with it [18:39:57] I can be a shepard for the doc [18:43:33] greg-g: I guess I will delegate the task to kartik :D [18:43:44] i.e. ask him to write down what ever he had to do to push cxserver [18:43:54] from there we can amend and put it somewhere [18:44:01] best way to write documentation is to do it [18:44:03] yep [18:45:39] Project Flow-test2.wikipedia.org-linux-firefox build #299: STILL FAILING in 7 min 29 sec: https://wmf.ci.cloudbees.com/job/Flow-test2.wikipedia.org-linux-firefox/299/ [18:53:12] Project Flow-en.wikipedia.beta.wmflabs.org-linux-chrome build #483: SUCCESS in 7 min 31 sec: https://wmf.ci.cloudbees.com/job/Flow-en.wikipedia.beta.wmflabs.org-linux-chrome/483/ [19:04:57] Project UploadWizard-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_9 build #818: STILL FAILING in 11 min: https://wmf.ci.cloudbees.com/job/UploadWizard-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_9/818/ [19:08:03] Project VisualEditor-test2.wikipedia.org-linux-firefox build #573: FAILURE in 33 min: https://wmf.ci.cloudbees.com/job/VisualEditor-test2.wikipedia.org-linux-firefox/573/ [19:08:04] * esanders: Fix typo in class name [19:08:04] * esanders: Don't select contents of textarea in extension inspector [19:08:05] * cmcmahon: [BrowserTest] Remove obsolete test [19:08:05] * krinklemail: ve.dm.Converter.test: Use teardown to restore mw.config instead of ad-hoc [19:08:06] * roan.kattouw: Update VE core submodule to master (fc52878) [19:15:53] Project Flow-test2.wikipedia.org-linux-chrome build #333: STILL FAILING in 7 min 48 sec: https://wmf.ci.cloudbees.com/job/Flow-test2.wikipedia.org-linux-chrome/333/ [19:22:03] Project browsertests-en.wikipedia.beta.wmflabs.org-linux-firefox build #886: SUCCESS in 17 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-linux-firefox/886/ [19:25:53] Project UploadWizard-commons.wikimedia.beta.wmflabs.org-linux-chrome build #883: FAILURE in 9 min 58 sec: https://wmf.ci.cloudbees.com/job/UploadWizard-commons.wikimedia.beta.wmflabs.org-linux-chrome/883/ [19:49:44] Project VisualEditor-en.wikipedia.beta.wmflabs.org-linux-firefox build #51: FAILURE in 27 min: https://wmf.ci.cloudbees.com/job/VisualEditor-en.wikipedia.beta.wmflabs.org-linux-firefox/51/ [19:49:45] * esanders: Fix typo in class name [19:49:45] * esanders: Don't select contents of textarea in extension inspector [19:49:46] * cmcmahon: [BrowserTest] Remove obsolete test [19:49:46] * krinklemail: ve.dm.Converter.test: Use teardown to restore mw.config instead of ad-hoc [19:49:47] * roan.kattouw: Update VE core submodule to master (fc52878) [20:06:54] Project MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome build #505: FAILURE in 40 min: https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/505/ [20:06:54] maxsem.wiki: mobileview: return page_props [20:16:51] James_F: trying to figure out something: in VE when I click Insert/Template/ and type 'foo' and I see a list of existing templates, where does that list come from? How does VE know what templates already exist? [20:24:18] chrismcmahon: i'm having trouble getting ve to work in my vagrant env [20:25:05] chrismcmahon: clicking on edit nor navigating to the veaction=edit url work [20:25:17] marxarelli: I just did git pull in my VM and things look OK. let me check [20:25:34] chrismcmahon: any ideas of where to start looking? it was working ok yesterday [20:26:14] (03PS2) 10Jackmcbarn: Add Scribunto as a dependency for FlaggedRevs [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/138612 [20:26:36] chrismcmahon: i wanted to verify your fixes but none of my tests get past the Background clauses as a result of this [20:27:29] (03CR) 10jenkins-bot: [V: 04-1] Add Scribunto as a dependency for FlaggedRevs [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/138612 (owner: 10Jackmcbarn) [20:27:37] marxarelli: now mine is mess up too, after doing git pull [20:28:25] Project MultimediaViewer-en.wikipedia.beta.wmflabs.org-linux-firefox build #284: SUCCESS in 2 min 4 sec: https://wmf.ci.cloudbees.com/job/MultimediaViewer-en.wikipedia.beta.wmflabs.org-linux-firefox/284/ [20:28:57] (03CR) 10Jackmcbarn: "recheck" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/138612 (owner: 10Jackmcbarn) [20:40:56] marxarelli: for grins I am bringing up a new vagrant from scratch [20:41:44] either the role got un-enabled, or git pull did not dtrt [21:07:41] marxarelli: on a clean Vagrant VM VE browsertests work fine. mine broke on existing VM after doing "git pull". I wonder if VE has some sort of magical git arrangements [21:08:52] chrismcmahon: ah. it does have a submodule at lib/ve [21:09:57] that's probably it. I vaguely remember some drama when we were first deploying VE automatically to beta labs [21:10:53] Project UploadWizard-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_10 build #705: STILL FAILING in 11 min: https://wmf.ci.cloudbees.com/job/UploadWizard-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_10/705/ [21:17:13] Project MultimediaViewer-en.wikipedia.beta.wmflabs.org-linux-chrome build #56: SUCCESS in 2 min 14 sec: https://wmf.ci.cloudbees.com/job/MultimediaViewer-en.wikipedia.beta.wmflabs.org-linux-chrome/56/ [21:17:13] l10n-bot: Localisation updates from https://translatewiki.net. [21:22:55] Project browsertests-en.wikipedia.beta.wmflabs.org-linux-chrome build #902: SUCCESS in 18 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-linux-chrome/902/ [21:22:55] Project MultimediaViewer-mediawiki.org-linux-firefox build #114: SUCCESS in 2 min 51 sec: https://wmf.ci.cloudbees.com/job/MultimediaViewer-mediawiki.org-linux-firefox/114/ [21:22:55] l10n-bot: Localisation updates from https://translatewiki.net. [21:22:55] Project ZeroRatedMobileAccess-en.m.wikipedia.org-linux-phantomjs build #229: STILL FAILING in 30 sec: https://wmf.ci.cloudbees.com/job/ZeroRatedMobileAccess-en.m.wikipedia.org-linux-phantomjs/229/ [21:22:55] Project WikiLove-en.wikipedia.beta.wmflabs.org-linux-firefox build #225: SUCCESS in 1 min 58 sec: https://wmf.ci.cloudbees.com/job/WikiLove-en.wikipedia.beta.wmflabs.org-linux-firefox/225/ [21:23:27] chrismcmahon: hey there! in maybe 10 minutes we'll be talking about https://www.mediawiki.org/wiki/Requests_for_comment/Debugging_at_production_server in #wikimedia-office and I would love for you to participate [21:23:36] greg-g: ^ you as well [21:24:29] yeppers [21:24:48] sweet, thanks [21:24:49] sumanah: am already lurking [21:28:37] Project Flow-en.wikipedia.beta.wmflabs.org-linux-firefox build #483: SUCCESS in 8 min 18 sec: https://wmf.ci.cloudbees.com/job/Flow-en.wikipedia.beta.wmflabs.org-linux-firefox/483/ [21:28:37] l10n-bot: Localisation updates from https://translatewiki.net. [21:28:46] Great [21:28:54] * greg-g goes to get some water, brb [21:29:22] Project UploadWizard-api-commons.wikimedia.beta.wmflabs.org build #596: SUCCESS in 1 min 19 sec: https://wmf.ci.cloudbees.com/job/UploadWizard-api-commons.wikimedia.beta.wmflabs.org/596/ [21:35:48] marxarelli: welcome to gerrit: https://www.mediawiki.org/wiki/Gerrit/resolve_conflict [21:36:02] chrismcmahon: :) [21:36:56] i just went ahead and rebased. luckily that's what the docs said to do :) [21:38:13] though i remember reading somewhere that rebasing borks gerrit's ability to compare patch sets, so hopefully it won't be a problem [21:38:56] marxarelli: I have no idea how you did that :-) I have always had to resolve the conflicts before rebasing [21:39:17] i ran into a conflict when rebasing [21:39:23] luckily it was an easy one [21:39:46] just some eof garbage [21:40:05] yeah, the conflict is usually trivial unfortunately [21:40:54] Project MultimediaViewer-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_9 build #56: SUCCESS in 2 min 46 sec: https://wmf.ci.cloudbees.com/job/MultimediaViewer-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_9/56/ [21:40:54] * l10n-bot: Localisation updates from https://translatewiki.net. [21:40:54] * tgr.huwiki: Use Repo.isCommons() for deciding whether an image is from Commons [21:40:54] Project UploadWizard-api-commons.wikimedia.org build #494: SUCCESS in 1 min 17 sec: https://wmf.ci.cloudbees.com/job/UploadWizard-api-commons.wikimedia.org/494/ [21:41:00] Project browsertests-test2.wikipedia.org-linux-chrome build #1135: STILL FAILING in 20 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-linux-chrome/1135/ [21:42:00] chrismcmahon: the new vagrant setup creates some directories under the tests/browser directory that can safely be ignored [21:42:28] chrismcmahon: should we added them to the .gitignore for VE? (and all other repos that have browser tests) [21:45:09] chrismcmahon: specifically .gem .bundle and .ruby-version [21:45:30] marxarelli: yeah, I think those should not be in the repo [21:45:36] actually, it might make sense to track .ruby-version [21:46:01] nm, vagrant/pupppet would just overwrite it [21:46:48] chrismcmahon: great. should i add to the .gitignore in the root project directory, or would it make more sense to create a test/browser/.gitignore? [21:47:34] marxarelli: I hadn't thought that far ahead. I would lean toward a test/browser/.gitignore [21:52:24] Project browsertests-test2.wikipedia.org-linux-firefox build #1112: STILL FAILING in 19 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-linux-firefox/1112/ [21:52:45] Project MobileFrontend-en.m.wikipedia.org-linux-firefox build #528: STILL FAILING in 11 min: https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.org-linux-firefox/528/ [21:52:45] * maxsem.wiki: mobileview: return page_props [21:52:46] * l10n-bot: Localisation updates from https://translatewiki.net. [22:00:34] Project UploadWizard-commons.wikimedia.beta.wmflabs.org-linux-firefox build #842: SUCCESS in 8 min 8 sec: https://wmf.ci.cloudbees.com/job/UploadWizard-commons.wikimedia.beta.wmflabs.org-linux-firefox/842/ [22:02:18] marxarelli: it's generally good to let people hack any part of the repo in any way they want without affecting browsertests, so test/browser/.gitignore makes sense to me [22:04:38] chrismcmahon: great. i've pushed a patch [22:14:12] (03CR) 10Krinkle: [C: 031] "Will need someone with Jenkins access to recompile the relevant configuration files locally and push them to Jenkins." [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/138612 (owner: 10Jackmcbarn) [22:16:18] Project browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_10 build #707: SUCCESS in 23 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_10/707/ [22:22:35] chrismcmahon: https://gerrit.wikimedia.org/r/#/c/138837/ i'm getting two additional failures [22:23:06] marxarelli: besides transclusion what else? [22:23:10] cucumber features/cursor.feature:8 # Scenario: show hover icons [22:23:10] cucumber features/references.feature:15 # Scenario: Reusing an existing reference [22:23:38] i'll retry them just to make sure [22:23:43] marxarelli: eh, I forgot cursor was in there, that never worked (but I should re-visit it) [22:23:59] looking at references now [22:24:13] we're so close to green! [22:24:15] Yippee, build fixed! [22:24:16] Project browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_8 build #742: FIXED in 23 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_8/742/ [22:25:39] marxarelli: references has a problem, either a bug or the VE code changed recently, looking more [22:26:40] marxarelli: I think I see the problem, will take a few minutes [22:28:31] marxarelli: in the builds we do iirc bundle exec cucumber features/ --tags @firefox --tags @en.wikipedia.beta.wmflabs.org [22:32:24] marxarelli: we're good, references has the same issue as transclusion, namely the failing step relies on existing references that do not exist in a bare wiki. I'll have to populate some for both of those, but I'm not sure how right off the bat. [22:33:39] chrismcmahon: awesome [22:34:23] chrismcmahon: maybe we should create a default cucumber profile with the --tags options [22:34:50] marxarelli: yeah, or a tag @vagrant or some such [22:35:01] for the tests [22:35:02] like a 'default' that specifies the tags you mentioned, and an 'all' that executes everything [22:35:55] chrismcmahon: i was also thinking that a vagrant command for easier execution of browser tests might be useful. there's one for unit tests already [22:36:10] sure, makes sense [22:36:33] * chrismcmahon is still figuring out what's exactly up with the references test [22:42:33] marxarelli: I take it back, there is some sort of bug here I think, I am guessing a piece of software missing in order to interpret references correctly inside VE and in the normal view... [22:42:57] marxarelli: compare http://en.wikipedia.beta.wmflabs.org/wiki/Reference_VisualEditor_Test to http://127.0.0.1/w/index.php?title=Reference_VisualEditor_Test [22:43:06] marxarelli: I'ma file a bug for that one/ [22:52:24] chrismcmahon: sounds good. i'm going to pretend i know what's going on :) [23:01:01] marxarelli: boils down to https://bugzilla.wikimedia.org/show_bug.cgi?id=66504 [23:01:07] Project MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox build #617: STILL FAILING in 44 min: https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox/617/ [23:01:07] * jrobson: Hide enabling of site notices behind flag [23:01:08] * jrobson: Alpha: Avoid multiple title parameters when rewriting url [23:01:08] * maxsem.wiki: Hygiene: remove old b/c code that was there since October [23:01:09] * jrobson: MobileOptions: Log authentication status for users getting token errors [23:01:09] * jrobson: Hack around yet another template problem. [23:01:10] * jrobson: Update docs for skin and Api Files [23:01:10] * florian.schmidt.welzow: Hygiene: Update/Create doc for php in diff and modules [23:01:11] * kaldari: Make sure images are properly aligned in Mobile VisualEditor [23:01:11] * jrobson: Documentation: Add summary blocks to files in api directory [23:01:12] * jrobson: Ignore tests directory when running `make phpdocs` [23:01:12] * jrobson: Slight tweak to quotebox template [23:01:13] * jrobson: Make `make message` work again. [23:01:13] * jrobson: Hygiene: Kill dead variable [23:01:14] * maxsem.wiki: Throw a couple more Android UAs at tests [23:01:14] * jrobson: QA: Fix failing builds [23:01:15] * jrobson: Update file summary for phpdoc [23:01:15] * florian.schmidt.welzow: Respect Upload Settings on Special:Uploads [23:01:58] marxarelli: and I messed up the screen shots, but Roan replied to https://bugzilla.wikimedia.org/show_bug.cgi?id=66502 [23:04:10] automated tests ftw [23:29:11] 3Wikimedia / 3Continuous integration: Make RSS feeds public - 10https://bugzilla.wikimedia.org/66443#c2 (10Jon) Okay, I tried to use the JSON api. It's probably a better move on long term. https://github.com/wikimedia/bingle/pull/40 Shame the RSS feed doesn't work though... [23:34:57] (03PS1) 10Ori.livneh: operations-apache-config: make path truncation more generic [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/139035 [23:35:00] (03CR) 10jenkins-bot: [V: 04-1] operations-apache-config: make path truncation more generic [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/139035 (owner: 10Ori.livneh) [23:35:09] (03PS2) 10Ori.livneh: operations-apache-config: make path truncation more generic [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/139035 [23:35:39] (03CR) 10Chad: [C: 032] Add Scribunto as a dependency for FlaggedRevs [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/138612 (owner: 10Jackmcbarn) [23:37:17] (03Merged) 10jenkins-bot: Add Scribunto as a dependency for FlaggedRevs [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/138612 (owner: 10Jackmcbarn) [23:38:39] (03PS3) 10Krinkle: operations-apache-config: make path truncation more generic [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/139035 (owner: 10Ori.livneh) [23:40:03] chrismcmahon: the references feature is still failing for me, even after restarting parsoid [23:40:30] marxarelli: with the Cite extension installed? [23:41:02] chrismcmahon: gah. nope [23:41:40] chrismcmahon: should the visualeditor vagrant role include cite? [23:41:41] marxarelli: https://www.mediawiki.org/wiki/Help:Extension:Cite is what I found [23:42:27] marxarelli: yes. also it seems several others: https://bugzilla.wikimedia.org/show_bug.cgi?id=66504 "Lua" in this case might mean "Scribuntu". but Cite is a good place to start [23:43:09] marxarelli: I know basically nothing about installing extensions unfortunately [23:44:23] (03CR) 10Ori.livneh: [C: 031] operations-apache-config: make path truncation more generic [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/139035 (owner: 10Ori.livneh) [23:45:27] chrismcmahon: i'll start with Cite, and see how it goes :) [23:46:36] marxarelli: yeah, templates are strange, and pretty unique to mediawiki in this form, I am not an expert at all there [23:46:43] references are simpler [23:46:52] (03CR) 10Krinkle: [C: 032] "Deployed." [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/139035 (owner: 10Ori.livneh) [23:48:03] (03Merged) 10jenkins-bot: operations-apache-config: make path truncation more generic [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/139035 (owner: 10Ori.livneh) [23:49:32] chrismcmahon: references passes! [23:49:44] marxarelli: you rawk [23:53:52] marxarelli: just a side note, issues like a problem between one extension and another extension are exactly what these tests are designed to catch [23:59:37] James_F: re: https://bugzilla.wikimedia.org/show_bug.cgi?id=66504 is the requirement the Lua extension or Scribuntu?