[08:10:19] hashar: I am in the hangout [08:11:14] zeljkof: coming [08:14:02] zeljkof: https://review.openstack.org/#/c/100020/ [08:14:05] zeljkof: JJB patch [08:14:31] 1 line change https://review.openstack.org/#/c/100020/1/jenkins_jobs/builder.py [12:38:23] 3Wikimedia / 3Continuous integration: JJB: document "current build parameters" to trigger-build builder - 10https://bugzilla.wikimedia.org/45910#c5 (10Andre Klapper) mtraceur: Are you still working on this? Or should the assignee be reset? [12:53:47] hello zeljkof [12:54:45] vikas: hi [12:57:06] zeljkof: Is there any permission required to create a new job in https://integration.wikimedia.org/ci/ ? [12:58:04] vikas: yes [12:58:20] can you log in there with your gerrit credentials? [13:01:11] zeljkof: yup logged in there, but cannot create a job :(, I am trying out creation of multiple language wikimedia on fly. Hashar had created a wiki(in job itself) and run browser tests on it. This is something I don't think I can do it in cloudbees [13:01:15] vikas: make sure to mention my nick when replying, this window is in the background :) [13:01:33] zeljkof: ok :) [13:01:43] vikas: you should ping hashar, he knows what needs to be done so you could create jobs [13:01:55] he should be online later today [13:02:03] zeljkof: great ! [13:42:47] vikas: hashar just sent e-mail that he is not feeling good [13:42:59] I hope he will feel better tomorrow [13:43:17] zeljkof: ok thank you for the message :) I will ask him tomorrow [13:44:04] zeljkof: had some problem with ruby style(http://etherpad.wikimedia.org/p/vikas-ruby-style), I would be happy if you can recommend something which will look good? [13:44:45] vikas: what do you mean by stlye? [13:44:52] this is what we use [13:45:04] https://www.mediawiki.org/wiki/Manual:Coding_conventions/Selenium [13:45:25] https://github.com/styleguide/ruby [13:46:47] zeljkof: looking into the links [14:03:47] zeljkof: did you change the password for Selenium_user? [14:03:57] chrismcmahon: no [14:04:12] as far as I can remember [14:04:22] not today, for sure [14:08:47] zeljkof: my mistake, I had a typo [14:09:35] chrismcmahon: :) [14:09:51] chrismcmahon: hashar is not feeling good today and I have been dealing with yearly review all day [14:10:05] so no progress has been made on jjb/jenkins :( [14:13:15] zeljkof: it seems beta labs is throwing 503 errors from the Varnish cache right now [14:14:06] zeljkof: https://integration.wikimedia.org/ci/view/BrowserTests/job/browsertests-VisualEditor-en.wikipedia.beta.wmflabs.org-linux-firefox-sauce/9/console [14:14:52] zeljkof: hmm, maybe that was actually integration host with 503 [15:38:16] (03PS1) 10Zfilipin: Deleted two local Flow jobs, created two Flow jobs that run on Sauce Labs [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/139851 [15:57:28] (03PS1) 10Zfilipin: Deleted local MobileFrontend jobs, refactored MobileFrontend Sauce Labs jobs [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/139853 [15:57:31] (03PS1) 10Zfilipin: Refactored Flow, MobileFrontend and VisualEditor Sauce Labs jobs. Deleted local VisualEditor jobs. [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/139854 [15:58:54] (03CR) 10Cmcmahon: [C: 032] Deleted local MobileFrontend jobs, refactored MobileFrontend Sauce Labs jobs [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/139853 (owner: 10Zfilipin) [15:59:05] (03CR) 10Cmcmahon: [C: 032] Refactored Flow, MobileFrontend and VisualEditor Sauce Labs jobs. Deleted local VisualEditor jobs. [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/139854 (owner: 10Zfilipin) [15:59:38] 3Wikimedia / 3Continuous integration: mwext-Math-testextensions-master should build texvc - 10https://bugzilla.wikimedia.org/49884#c6 (10Bryan Davis) Does the https://integration.wikimedia.org/ci/job/beta-recompile-math-texvc-eqiad/ jenkins job do the things this bug was opened to track or is there still add... [15:59:44] (03CR) 10Cmcmahon: [C: 032] Remove unneeded mediawiki_user variable [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/138346 (owner: 10Zfilipin) [15:59:47] (03CR) 10jenkins-bot: [V: 04-1] Remove unneeded mediawiki_user variable [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/138346 (owner: 10Zfilipin) [16:00:11] (03CR) 10Cmcmahon: [C: 032] Deleted two local Flow jobs, created two Flow jobs that run on Sauce Labs [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/139851 (owner: 10Zfilipin) [16:00:37] (03Merged) 10jenkins-bot: Deleted two local Flow jobs, created two Flow jobs that run on Sauce Labs [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/139851 (owner: 10Zfilipin) [16:00:40] (03Merged) 10jenkins-bot: Deleted local MobileFrontend jobs, refactored MobileFrontend Sauce Labs jobs [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/139853 (owner: 10Zfilipin) [16:00:43] (03Merged) 10jenkins-bot: Refactored Flow, MobileFrontend and VisualEditor Sauce Labs jobs. Deleted local VisualEditor jobs. [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/139854 (owner: 10Zfilipin) [16:28:30] Hello manybubbles [16:28:35] hi! [16:29:00] manybubbles: I have updated the patch https://gerrit.wikimedia.org/r/#/c/135616/, can you please take a look at it :) [16:29:57] I'll add it to my reading list:) [16:30:08] I'm about 10 tabs backlogged right now, unfortunately [16:30:14] but I'll bump you to the top [16:30:22] manybubbles: great ! thank you :) [16:36:38] congratulations to Amir for bug #66666 https://bugzilla.wikimedia.org/show_bug.cgi?id=66666 [16:59:53] hah [17:11:50] manybubbles: left you some comments in https://gerrit.wikimedia.org/r/#/c/138377/2/modules/ve-mw/test/browser/screenshot.rb and https://gerrit.wikimedia.org/r/#/c/137451/ , you can read it when you are free :) I am putting it now so that I don't forget to tell you :) [19:05:57] marxarelli: you're being summoned in #mediawiki-core [19:06:19] WHO HAS AWAKENED ME [19:06:23] ok :) [19:06:43] :) [20:27:18] hi fhocutt! [20:27:30] hi sumanah! [20:27:41] ok, so I will just copy and paste your question here ;-) [20:27:49] sumanah_wikimedia_mentor, I'm looking at the tests for mwclient [20:27:49] this is a test but not a unit test, yeah? https://github.com/mwclient/mwclient/blob/master/tests/basic_edit_test.py [20:27:49] it covers a lot of stuff [20:27:49] but this is a unit test: https://github.com/mwclient/mwclient/blob/master/tests/client-test.py [20:27:54] so I'm evaluating the tests available for mwclient, all here: https://github.com/mwclient/mwclient/tree/master/tests [20:28:52] * sumanah looks at both [20:29:30] client-test.py looks like a unit test to me on first glance. Now looking at the edit test [20:29:31] client-test.py is definitely not *complete*, it just tests if you can set up a site [20:29:59] this is a test but not a "unit test" [20:30:38] 3Wikimedia / 3Continuous integration: Figure out how to test for database backwards incompatibilities - 10https://bugzilla.wikimedia.org/66684 (10Greg Grossmeier) p:5Unprio>3Normal [20:30:39] 3Wikimedia / 3Continuous integration: Figure out how to test for database backwards incompatibilities - 10https://bugzilla.wikimedia.org/66684 (10Greg Grossmeier) 3NEW p:3Unprio s:3enhanc a:3None Sometimes database changes are made to core (not likely) or deployed extensions (much more likely) that a... [20:31:04] ok [20:31:14] fhocutt: so my opinion is: you are right. https://github.com/mwclient/mwclient/blob/master/tests/basic_edit_test.py is a test, but it is not a "unit test" [20:32:07] 3Wikimedia / 3Continuous integration: Figure out how to test for database backwards incompatibilities - 10https://bugzilla.wikimedia.org/66684#c1 (10Greg Grossmeier) Strawman #1: * We run a set of integration tests "right" before a run of update.php * We run the same set "right" after. * Some how compare the... [20:32:09] we use the word "unit" because each success or failure can sort of be run independently and you can easily make dashboards re what succeeds and what fails, what percentage of the code paths are covered, and so on [20:32:40] right. [20:32:48] it's good to have automated tests, and it's even better to have *a bunch of individual independent* automated tests, so you can say "aha, THAT is the one thing that failed" and zero in on it [20:33:55] and - as you see in the client-test.py "setup" lines - with real unit tests, you can decouple the thing you're testing from the setup steps, e.g., initializing a connection, creating a new random or time-dependent bit of input to try [20:39:11] fhocutt: am happy to delve further if you want [20:39:28] so for this one, there are tests but there aren't really unit tests [20:41:47] fhocutt: I would say that there seems to be one unit test [20:41:58] ok. [20:43:18] another not-test-related question: https://github.com/mwclient/mwclient/blob/master/mwclient/client.py#L119 [20:43:39] there is a function defined inside of an if statement inside another function [20:44:17] I find this quite confusing at a first read. Is this actually a Done Thing or is it kinda hacky? [20:47:37] sometimes we do define a function within another function [20:48:05] ...more namespace shenanigans, or do you just sometimes really only need it in the one place? [20:48:08] it's strange but we do it sometimes, especially if there's no way we'll want to do that thing outside the (parent) function [20:48:58] I'm also questioning defining it *in* the conditional [20:49:45] right. That, I feel like I am not clear enough to judge. [20:49:53] but I think I have seen it before [20:50:00] ok, ty [21:45:36] sumanah, what would you call the other tests? [21:46:30] fhocutt: this is a point of jargon contention, but I would say that the basic_edit_test.py is possibly an "integration" test [21:47:22] so if I call it that, it will be understandable but may annoy some people? [21:47:35] I think so, yes [21:47:41] cool. Thanks. [22:52:08] @chrismcmahon:Hi Chris! Yesterday I coudnot see the Visual editor toolbar for the test page that gets created on the fly..Its visible today..Is there any particular setting which needs for the toolbarto be visible on beta.wmflabs [22:52:28] I know there is an option in preferences for visual editor toolbar [22:53:02] Is this something which I need to take care of,? [22:55:27] Also I spoke to Zeljko for the spec_helper.rb file for the should syntax to be changed to expect one and he said that with cucumber version 3 on.. should is automatically disabled [22:55:59] so as of now hes asked me to focus on manually changing the syntax only which I have begun [22:56:06] * sumanah is curious what chrismcmahon will say [22:57:11] Jagori: beta labs seems to have been broken over the weekend. I know I filed this bug this morning: https://bugzilla.wikimedia.org/show_bug.cgi?id=66669 but it looks like beta had other problems also [22:57:25] I see.. [22:57:38] thanks so much [22:58:39] Ya I too saw the same error yesterday [22:58:41] while testing [22:58:48] thanks for clarifying..