[07:27:17] <vikas>	 hello zeljkof 
[07:27:46] <zeljkof>	 vikas: hi, sorry, I have to go, will be back in 30 minutes
[07:27:52] <vikas>	 ok zeljkof :) 
[09:53:32] <Nemo_bis>	 hi Niharika 
[10:30:00] <Tobi_WMDE>	 zeljkof__: will be a few minutes late
[10:30:03] <Tobi_WMDE>	 ~5
[10:30:11] <zeljkof__>	 Tobi_WMDE: no problem, I am in the hangout
[12:05:20] <grrrit-wm2>	 (03PS1) 10Zfilipin: WIP Moved the first Wikidata job from WMDE Jenkins [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/147093 
[12:52:38] <grrrit-wm2>	 (03PS1) 10Zfilipin: mediawiki/core Jenkins job should not send e-mail notifications to ULS team [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/147098 
[12:54:20] <grrrit-wm2>	 (03PS2) 10Zfilipin: mediawiki/core Jenkins job should not send e-mail notifications to ULS team [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/147098 
[12:56:07] <grrrit-wm2>	 (03CR) 10Amire80: [C: 032] mediawiki/core Jenkins job should not send e-mail notifications to ULS team [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/147098 (owner: 10Zfilipin)
[12:56:33] <grrrit-wm2>	 (03Merged) 10jenkins-bot: mediawiki/core Jenkins job should not send e-mail notifications to ULS team [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/147098 (owner: 10Zfilipin)
[13:20:07] <vikas>	 zeljkof: can you look into https://gerrit.wikimedia.org/r/#/c/142990/
[13:21:13] <zeljkof>	 vikas: sure, looking now
[13:21:31] <vikas>	 zeljkof:  great ! 
[13:29:05] <vikas>	 zeljkof: you might get 1 failure 
[13:29:11] <vikas>	 not sure how to solve it :( 
[13:29:47] <zeljkof>	 vikas: what is the problem?
[13:30:18] <vikas>	 zeljkof: how do you click at a image ?
[13:30:28] <zeljkof>	 image.click
[13:30:37] <zeljkof>	 :)
[13:30:47] <vikas>	 wow ! let me try it 
[13:33:15] <zeljkof>	 vikas: I got 21 scenarios (4 failed, 17 passed)
[13:33:44] <zeljkof>	 all failures were "timed out after 5 seconds..."
[13:33:58] <zeljkof>	 let my try hardcoding url to a small page on beta
[13:35:06] <vikas>	 I remember solving everything. I am running everything again 
[13:45:56] <vikas>	 zeljkof: I got 2 failures 
[13:46:16] <zeljkof>	 vikas: it is even worse now :) 21 scenarios (7 failed, 14 passed)
[13:46:42] <vikas>	 weird 
[13:47:50] <vikas>	 zeljkof: why is that happening ? 
[13:48:00] <zeljkof>	 vikas: mostly timeouts 
[13:48:08] <zeljkof>	 welcome to driving the browser :)
[13:50:05] <vikas>	 haha ! but the result should be independent of who is driving it right ? 
[13:50:52] <zeljkof>	 vikas: yes, but my internet connection might be faster or slower than yours
[13:51:08] <zeljkof>	 so timeouts might be more or less likely to happen
[13:58:19] <zeljkof>	 vikas: what ever I try, 5-7 tests fail
[13:58:26] <zeljkof>	 let me try reproducing that in jenkins
[13:58:58] <vikas>	 ok ! 
[14:00:21] <zeljkof>	 testing 
[14:00:22] <zeljkof>	 https://integration.wikimedia.org/ci/job/browsertests-VisualEditor-language-screenshot-linux-firefox-sauce/LANGUAGE_SCREENSHOT_CODE=he,label=contintLabsSlave/50/console
[14:02:46] <vikas>	 zeljkof: it ran only 2 scenarios ?
[14:05:28] <zeljkof>	 vikas: hm
[14:05:31] <zeljkof>	 let me check
[14:07:12] <zeljkof>	 vikas: really
[14:07:13] <zeljkof>	 strange
[14:07:21] <zeljkof>	 the file contains only two scenarios
[14:07:21] <zeljkof>	 https://integration.wikimedia.org/ci/job/browsertests-VisualEditor-language-screenshot-linux-firefox-sauce/LANGUAGE_SCREENSHOT_CODE=he,label=contintLabsSlave/ws/modules/ve-mw/tests/browser/features/language_screenshot.feature/*view*/
[14:07:31] <zeljkof>	 parent folder: https://integration.wikimedia.org/ci/job/browsertests-VisualEditor-language-screenshot-linux-firefox-sauce/LANGUAGE_SCREENSHOT_CODE=he,label=contintLabsSlave/ws/modules/ve-mw/tests/browser/features/
[14:08:26] <zeljkof>	 but
[14:08:27] <zeljkof>	 https://integration.wikimedia.org/ci/job/browsertests-VisualEditor-language-screenshot-linux-firefox-sauce/LANGUAGE_SCREENSHOT_CODE=he,label=contintLabsSlave/50/console
[14:09:37] <vikas>	 strange I can see it fetch 
[14:09:43] <vikas>	 the patch 
[14:10:10] <zeljkof>	 says
[14:10:10] <zeljkof>	 00:00:03.189 + git fetch https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor refs/changes/90/142990/24
[14:10:10] <zeljkof>	 and also 00:00:04.174 HEAD is now at 2739047... [BrowserTest] Added lots of new scenarios for language screenshot
[14:10:38] <vikas>	 wait a second it is changing it's branch again to master ??
[14:10:44] <vikas>	 13:59:53 + MEDIAWIKI_GIT_BRANCH=master
[14:10:44] <vikas>	 13:59:53 + git checkout -f origin/master
[14:10:47] <zeljkof>	 vikas: just noticed that
[14:11:02] <zeljkof>	 let me try adding the line that fetches master just before running the script
[14:11:23] <zeljkof>	 done
[14:11:47] <zeljkof>	 vikas: https://integration.wikimedia.org/ci/job/browsertests-VisualEditor-language-screenshot-linux-firefox-sauce/LANGUAGE_SCREENSHOT_CODE=he,label=contintLabsSlave/51/console
[14:12:32] <vikas>	 ok :) 
[14:16:21] <vikas>	 zeljkof: looks like when I click that image it takes me to that image url :(  
[14:16:37] <zeljkof>	 vikas: and what should happen?
[14:17:46] <vikas>	 it should have highlighted it in VisualEditor and we should have got something like this => https://www.mediawiki.org/wiki/File:VisualEditor_-_Media_editing_3.png
[14:18:11] <zeljkof>	 vikas: ok, we can pair on that tomorrow
[14:18:18] <zeljkof>	 not sure what is wrong there
[14:18:31] <zeljkof>	 now more tests are running
[14:19:39] <vikas>	 ok :) 
[14:24:00] <grrrit-wm2>	 (03CR) 10Zfilipin: Minor style cleanup. Updated documentation with new features. (031 comment) [ruby/api] - 10https://gerrit.wikimedia.org/r/146794 (owner: 10Zfilipin)
[14:25:46] <grrrit-wm2>	 (03CR) 10Zfilipin: "Why this commit was not merged after +2? Zuul[1] says "mediawiki-ruby-api-ruby1.9.3lint queued"." [ruby/api] - 10https://gerrit.wikimedia.org/r/146794 (owner: 10Zfilipin)
[14:26:22] <chrismcm_>	 zeljkof: I know zuul had a problem late yesterday, it might be broken
[14:26:43] <zeljkof>	 chrismcm_: will update the commit, maybe it will rerun
[14:27:41] <zeljkof>	 vikas: one timeout so far https://integration.wikimedia.org/ci/job/browsertests-VisualEditor-language-screenshot-linux-firefox-sauce/LANGUAGE_SCREENSHOT_CODE=he,label=contintLabsSlave/51/console
[14:32:26] <vikas>	 zeljkof: yup that was expected 
[14:33:14] <vikas>	 zeljkof: done ! only 1 failing(which was expected) yay ! 
[14:33:45] <zeljkof>	 so the failing one is the one with the image?
[14:33:52] <vikas>	 yes ! 
[14:34:24] <zeljkof>	 In that case, +2 :)
[14:34:31] <zeljkof>	 and let's fix the details later
[14:35:28] <vikas>	 wait
[14:35:52] <zeljkof>	 waiting...
[14:36:13] <vikas>	 zeljkof: Someone needs to run all of VisualEditor browser tests, to check if others are not broken 
[14:36:17] <vikas>	 It should not be 
[14:36:34] <zeljkof>	 vikas: we will worry about that later :)
[14:36:42] <vikas>	 zeljkof: ok :)  
[14:37:34] <grrrit-wm2>	 (03PS2) 10Zfilipin: VisualEditor renamed "test" folder to "tests"[1] [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/146758 
[14:38:11] <zeljkof>	 vikas, chrismcmahonbrb, James_F|Away: could you please +1/+2 this one? https://gerrit.wikimedia.org/r/#/c/146758/
[14:43:20] <vikas>	 looking into it 
[14:43:54] <grrrit-wm2>	 (03CR) 10Vikassy: [C: 031] VisualEditor renamed "test" folder to "tests"[1] [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/146758 (owner: 10Zfilipin)
[14:47:58] <grrrit-wm2>	 (03PS2) 10Zfilipin: Minor cleanup, preparing for 0.1.4 release [ruby/api] - 10https://gerrit.wikimedia.org/r/146794 
[14:48:34] <grrrit-wm2>	 (03CR) 10Zfilipin: Minor cleanup, preparing for 0.1.4 release (032 comments) [ruby/api] - 10https://gerrit.wikimedia.org/r/146794 (owner: 10Zfilipin)
[14:51:04] <grrrit-wm2>	 (03CR) 10Cmcmahon: [C: 032] VisualEditor renamed "test" folder to "tests"[1] [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/146758 (owner: 10Zfilipin)
[14:51:12] <chrismcmahon>	 zeljkof: done
[14:51:19] <zeljkof>	 chrismcmahon: thanks
[14:51:40] <grrrit-wm2>	 (03Merged) 10jenkins-bot: VisualEditor renamed "test" folder to "tests"[1] [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/146758 (owner: 10Zfilipin)
[14:57:46] <Tobi_WMDE>	 zeljkof: can you forward me the license for rubymine? it seems it expired while I was on vacation.. -_-
[15:00:42] <zeljkof>	 Tobi_WMDE: :)
[15:00:47] <zeljkof>	 will do right now
[15:01:07] <Tobi_WMDE>	 zeljkof: thx!!
[15:01:28] <Tobi_WMDE>	 have the 30 day evaluation ohase now.. so it's not so urgent.. ;)
[15:04:04] <zeljkof>	 Tobi_WMDE: sent!
[15:04:13] <Tobi_WMDE>	 thx
[16:05:43] <grrrit-wm>	 (03PS4) 10Zfilipin: WIP Minor cleanup, preparing for 0.1.4 release [ruby/api] - 10https://gerrit.wikimedia.org/r/146794 
[16:23:49] <grrrit-wm>	 (03CR) 10Dduvall: [C: 031] "Looks great." [ruby/api] - 10https://gerrit.wikimedia.org/r/146794 (owner: 10Zfilipin)
[16:50:01] <vikas>	 chrismcmahon: should I change "I go to the (.+) page" to "I go to the \"(.*?)\" page" [Will it be confusing] ? 
[16:52:35] <chrismcmahon>	 vikas: I'm not sure. what happens if you do something like "I go to the (.+) page for screen shots"
[16:53:38] <vikas>	 chrismcmahon: yup ! I was thinking about that. Will submit the the patch soon :) 
[16:55:36] <chrismcmahon>	 vikas: I just hope that is enough difference for Cucumber.  can you submit that in the next few minutes?
[16:56:13] <vikas>	 yup ! doing that  
[17:10:15] <vikas>	 chrismcmahon: Testing this => https://gerrit.wikimedia.org/r/#/c/147148/ Might take some time 
[17:15:04] <chrismcmahon>	 run edit_utf8_logged_in.feature  should show
[17:21:55] <vikas>	 chrismcmahon: It is failing, but it is checking in features/step_definitions/shared_steps.rb:2 
[17:28:24] <chrismcmahon>	 vikas: I am just about to look at your patch
[17:30:54] <vikas>	 chrismcmahon: ok :) 
[17:32:16] <chrismcmahon>	 vikas: I merged it, thanks for the quick update!
[17:32:55] <vikas>	 chrismcmahon: thank you for merging 
[17:33:37] <vikas>	 chrismcmahon
[17:33:52] <vikas>	 oops looks like WIP is present in commit :( 
[17:34:39] <chrismcmahon>	 whoops 
[17:35:10] <chrismcmahon>	 I think I fixed it
[17:36:52] <vikas>	 I I can still see it here => https://gerrit.wikimedia.org/r/#/c/147148 and https://github.com/wikimedia/mediawiki-extensions-VisualEditor/commit/f58d98fcb9108121d1ebd285f9200321d352ab12
[17:47:37] <chrismcmahon>	 hi ryasmeen can I ask you to look at a VE issue I just found?  On http://en.wikipedia.beta.wmflabs.org/wiki/0.9753751036924678?veaction=edit on OSX/Chrome hit CTRL-K twice, deletes the link and inserts a row of snowman icons
[17:47:58] <chrismcmahon>	 ryasmeen: probably some other issues around that also
[17:53:26] <ryasmeen>	 chrismcmahon: I cannot reproduce it
[17:53:45] <ryasmeen>	 But there are few issues with snowmen appearing in bugzilla
[17:56:14] <chrismcmahon>	 ryasmeen: OK, seems to be on test2 also, I'll file a bug for it
[17:56:29] <ryasmeen>	 ok chrismcmahon
[20:14:37] <wikibugs>	 3Wikimedia / 3Quality Assurance: core mediawiki.util test failing in Flow qunit Jenkins jobs - 10https://bugzilla.wikimedia.org/68188 (10Jon) 3NEW p:3Unprio s:3normal a:3None It's not clear why. Can anyone shed light on why this happen?: https://integration.wikimedia.org/ci/job/mwext-Flow-qunit/318/c...
[20:44:43] <grrrit-wm>	 (03CR) 10Manybubbles: [C: 031] WIP Minor cleanup, preparing for 0.1.4 release [ruby/api] - 10https://gerrit.wikimedia.org/r/146794 (owner: 10Zfilipin)
[21:46:05] <grrrit-wm>	 (03PS1) 10Dduvall: Runtime dependency on mediawiki_api [selenium] - 10https://gerrit.wikimedia.org/r/147319 
[21:53:01] <greg-g>	 marxarelli: what's your mw.org username?
[21:53:40] <marxarelli>	 greg-g: Dzduvall
[21:53:52] <greg-g>	 ah, that z came out of no where!
[21:54:22] <marxarelli>	 that's my unique-username smackdown z
[21:54:41] <greg-g>	 :)
[21:55:01] <marxarelli>	 also, it stands for my middle name
[21:55:07] <marxarelli>	 so... that's convenient!
[21:59:23] <greg-g>	 sensible
[22:00:51] <grrrit-wm>	 (03PS2) 10Dduvall: Runtime dependency on mediawiki_api [selenium] - 10https://gerrit.wikimedia.org/r/147319 
[22:04:21] <grrrit-wm>	 (03PS3) 10Dduvall: Runtime dependency on mediawiki_api [selenium] - 10https://gerrit.wikimedia.org/r/147319 
[22:11:09] <grrrit-wm>	 (03CR) 10Cmcmahon: [C: 032] Runtime dependency on mediawiki_api [selenium] - 10https://gerrit.wikimedia.org/r/147319 (owner: 10Dduvall)
[22:11:11] <grrrit-wm>	 (03Merged) 10jenkins-bot: Runtime dependency on mediawiki_api [selenium] - 10https://gerrit.wikimedia.org/r/147319 (owner: 10Dduvall)