[00:00:16] bd808: greg-g: What's up? [00:06:08] Krinkle: beta db auto locked because of lag time caused by a migration that was merged today -- http://en.wikipedia.beta.wmflabs.org/w/index.php?maxlag=-1 [00:06:26] Krinkle: And Ori has got the wikis switched over to run on hhvm [00:06:49] I don't think anything "bad" is up other than slave rep lag [00:06:55] k [00:24:31] (03CR) 10Ori.livneh: [C: 032] Fix-up for I2cddc62d421: Fix unbalanced parens in regex [operations/apache-config] (betacluster) - 10https://gerrit.wikimedia.org/r/148250 (owner: 10Ori.livneh) [00:24:34] (03Merged) 10jenkins-bot: Fix-up for I2cddc62d421: Fix unbalanced parens in regex [operations/apache-config] (betacluster) - 10https://gerrit.wikimedia.org/r/148250 (owner: 10Ori.livneh) [00:58:50] 3Wikimedia / 3Continuous integration: Jenkins: Job runner slaves in labs no longer updated by puppet - 10https://bugzilla.wikimedia.org/68254#c7 (10Antoine "hashar" Musso) (In reply to Chase from comment #5) > what is the _latest_ time stamp for these logs. My guess is they are > orphaned and can be removed... [01:04:20] 3Wikimedia / 3Continuous integration: Jenkins: Job runner slaves in labs no longer updated by puppet - 10https://bugzilla.wikimedia.org/68254#c8 (10Antoine "hashar" Musso) 5NEW>3RESO/FIX The logs are smaller now :-) Thank you! [01:08:51] 3Wikimedia / 3Continuous integration: Jenkins: browserstests puppet manifest fails on "File[/var/lib/elasticsearch]:ensure" - 10https://bugzilla.wikimedia.org/68260#c5 (10Antoine "hashar" Musso) 5NEW>3RESO/FIX That works for me on integration-slave1004-trusty . I guess the slaves had an obsolete puppet m... [01:24:35] (03CR) 10Hashar: [C: 032] "Congratulations!" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/148244 (https://bugzilla.wikimedia.org/67734) (owner: 10Jdlrobson) [01:25:28] (03Merged) 10jenkins-bot: Make Flow QUnit tests voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/148244 (https://bugzilla.wikimedia.org/67734) (owner: 10Jdlrobson) [01:26:20] 3Wikimedia / 3Continuous integration: Setup QUnit tests on Jenkins for Flow - 10https://bugzilla.wikimedia.org/67734#c20 (10Antoine "hashar" Musso) 5PATC>3RESO/FIX And it is now voting! [01:36:38] 3Wikimedia / 3Continuous integration: Please have Jenkins do some basic checks of the phabtricator/ repos - 10https://bugzilla.wikimedia.org/68263#c1 (10Antoine "hashar" Musso) We could get php linting job for a start. Not sure how helpful it would be. Is there any tests suite to run on the repositories? [07:29:17] (03PS3) 10Hashar: add jzerebecki to trusted users in zuul [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/148238 (owner: 10Dzahn) [07:29:45] (03CR) 10Hashar: [C: 032] "Jan: you will have tests triggered now :-)" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/148238 (owner: 10Dzahn) [07:29:50] (03Merged) 10jenkins-bot: add jzerebecki to trusted users in zuul [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/148238 (owner: 10Dzahn) [07:58:35] Jagori: I will be in the hangout in a minute or two [07:58:42] no issues [08:02:48] Jagori: I am in the hangout [08:03:02] okay [08:06:16] hashar: I get "Domain not configured" for http://en.wikipedia.beta.wmflabs.org/ [08:06:28] hashar: ignore, works now [08:22:37] Jagori: can you hear me? I can not hear you [08:23:45] zeljkof: i can hear you [08:23:45] zeljkof:can you hear me,should i logout [08:23:45] and login again [08:24:08] zeljkof:i could hear your voice [08:24:08] but dont know what happened all of a sudden:) [08:24:30] Jagori: yes, let's try rejoining the hangout [08:24:32] zeljkof:am joining hangout once more [08:29:21] 3Wikimedia / 3Continuous integration: Drop some Jenkins jobs history - 10https://bugzilla.wikimedia.org/63936#c6 (10Antoine "hashar" Musso) 5PATC>3RESO/FIX That is good enough as is. The most offending jobs are now cleaned up automatically by Jenkins. [08:43:45] Jagori: http://git-scm.com/book/en/Git-Branching-Rebasing [08:58:01] Jagori: https://integration.wikimedia.org/ci/view/BrowserTests/job/browsertests-VisualEditor-en.wikipedia.beta.wmflabs.org-linux-chrome-sauce/lastCompletedBuild/testReport/(root)/VisualEditor%20Bullets,%20Numbering/check_strings_for_bullets_and_numbering__outline_example_____Numbering_______/ [09:05:57] zeljkof:I just forgot to mention my last session I got the date wrong in my pairing session email [09:06:04] Jagori: no problem :) [09:06:08] :) [09:06:10] okay [09:06:12] thanks [09:35:39] hello zeljkof hashar [09:35:48] hi vikasyaligar [09:36:11] is something wrong with english bets labs ? [09:36:41] vikasyaligar: I have noticed a few strange errors today [09:36:56] not sure if hashar is making some changes there now [09:38:37] oh ok :) [09:41:37] zeljkof: I am not changing any job :-] [10:21:21] 3Wikimedia / 3Continuous integration: Jenkins: Jobs for SwiftCloudFiles extension - 10https://bugzilla.wikimedia.org/46262 (10Antoine "hashar" Musso) 5PATC>3NEW [10:27:30] hashar: around? [10:40:16] kart_: around? [10:40:27] I have a bash question for the two of you [10:57:24] (03PS1) 10Legoktm: Add zuul config for a bunch of extensions I maintain [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/148352 [10:59:06] (03CR) 10Legoktm: "These already have entries in jenkins-job-builder-config AFAIS." [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/148352 (owner: 10Legoktm) [11:11:48] When I go to => http://en.wikipedia.beta.wmflabs.org/wiki/Language_Screenshot?vehidebetadialog=true&veaction=edit ; I am getting => Error loading data from server: readonly: The wiki is currently in read-only mode. Would you like to retry? [11:11:55] Is it only me ? [11:20:36] vikasyaligar: jagori told me earlier today she got the same error [11:20:43] and I was able to reproduce it now [11:22:04] * zeljkof is out to lunch [11:53:30] (03PS1) 10Legoktm: Add jobs for analytics/quarry/web [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/148361 [11:54:42] (03CR) 10jenkins-bot: [V: 04-1] Add jobs for analytics/quarry/web [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/148361 (owner: 10Legoktm) [11:56:15] (03PS1) 10Legoktm: Add zuul config for analytics/quarry/web [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/148362 [11:57:19] (03PS2) 10Legoktm: Add jobs for analytics/quarry/web [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/148361 [12:02:00] hey zeljkof, is there any reason why we are running the jobs in english beta labs and not on http://test2.wikipedia.org/ ? [12:02:30] not sure [12:02:42] we could do either, or both [12:03:16] i wonder what is the difference between both ? [12:08:19] vikasyaligar: in a meeting with Amir, sorry [12:28:15] vikasyaligar: I have reported a bug that beta is not working https://bugzilla.wikimedia.org/show_bug.cgi?id=68373 cc aharoni [12:29:04] thank you zeljkof :) [12:35:23] aharoni: LanguageScreenshotBot [12:42:48] zeljkof: There is another problem; like here => https://github.com/wikimedia/mediawiki-extensions-VisualEditor/commit/7b7d8c02a48777f5d34611e9bc1cb00346148cff [12:43:40] I had used css initially, but I think they changed the class name in VE. Is there any other better way ? [12:44:00] It is the save button which one can see on the top right corner [13:02:30] vikasyaligar: you can update the way you find the element [13:02:39] that is why we have page objects [13:02:45] so it is easy to update elements :) [13:07:03] zeljkof: ok :) [13:08:13] vikasyaligar: do you have time to make a few changes to the upload script? [13:08:35] zeljkof: yup I do, let me know [13:08:57] aharoni and I have talked about LanguageScreenshotBot [13:09:10] did you see comments here? https://commons.wikimedia.org/wiki/Commons:Bots/Requests/LanguageScreenshotBot [13:09:27] zeljkof: yup I did :) [13:09:49] did you see this? https://commons.wikimedia.org/wiki/Commons:Bots#Bot_speed [13:10:57] ah ! I read it now thank you for that :) [13:11:36] do you know how to change the script so it uploads only every 5 seconds? [13:11:49] I can add sleep 5 ? [13:12:02] vikasyaligar: yes :) [13:12:06] that is the simplest thing [13:12:21] just add sleep 5 after this line https://github.com/wikimedia/mediawiki-extensions-VisualEditor/blob/master/modules/ve-mw/tests/browser/upload.rb#L47 [13:12:54] zeljkof: yup doing that [13:12:54] you should also refactor #upload_image, so it does not have to log in every time it uploads the image [13:13:01] do you know how to do that? [13:17:10] zeljkof: yup I just checked out the api and there is a attribute logged_in which tells whether we are logged in or not :) [13:17:38] vikasyaligar: hm, not sure that that would work, but you can try :) [13:18:03] what I had in mind was moving these lines to #upload_images [13:18:03] https://github.com/wikimedia/mediawiki-extensions-VisualEditor/blob/master/modules/ve-mw/tests/browser/upload.rb#L44-L46 [13:18:17] and then passing "client" as an argument to #upload_image [13:18:39] so, calling #upload_image would look like [13:18:47] upload_image file_path, client [13:19:05] yup we can do that :) seems simpler [13:19:11] that would make sure you log in only once, but you can reuse the same session [13:19:14] great [13:19:29] when you do that, there will be another problem to solve [13:19:36] let me know when you are done with these changes [13:32:21] hashar: do you have some time to take a look at this? https://bugzilla.wikimedia.org/show_bug.cgi?id=68373 [13:32:29] beta seems really flaky today [13:32:37] :'( [13:33:05] ahh [13:33:40] zeljkof: yeah some patch landed in core yesterday that caused a massive database update [13:33:48] it has been running for 14+ hours now [13:34:04] hashar: ok, so it will get better with time? :) [13:34:27] evenutally [13:34:58] zeljkof: here it is => https://gerrit.wikimedia.org/r/#/c/148368 [13:34:58] will clear bits cache [13:35:05] hashar: ok, good to know [13:35:14] we have a lot of failed tests [13:36:34] vikasyaligar: replied, you should make two commits, they are not really related [13:37:23] zeljkof: ok will do that now :) [13:37:28] zeljkof: and bits is broken hehe [13:39:15] hashar: bits is a server on beta/labs? [13:47:54] zeljkof: here it is => https://gerrit.wikimedia.org/r/#/c/148373 and https://gerrit.wikimedia.org/r/#/c/148368/ [13:49:29] vikasyaligar: did you test if uploading works after the change? [13:51:27] I tested it by adding a puts in the output and it seems like it is working :) [13:51:44] zeljkof: I am not able to check commons as I am not able to login to it :( [13:52:07] vikasyaligar: ok, let's wait then until we can check [13:52:08] zeljkof: yeah bits serves common assets such as JS / CSS [13:52:14] rebooting it [13:52:22] vikasyaligar: now another problem [13:52:35] jobs for all languages run in parallel [13:52:54] how would you make sure then that a file can be uploaded only once every 5 seconds? [13:53:09] now we have 3 jobs, but in the future we might have way more [13:53:57] zeljkof: yup I was thinking about it. This problem sounds complex [13:54:08] vikasyaligar: there is a simple solution [13:54:09] :) [13:54:15] really ?? [13:54:22] I am looking for the simplest thing that would work [13:54:40] the problem is that we have to limit the number of uploads to less than one every 5 seconds [13:54:49] but the jobs run in parallel [13:55:01] so, how to do that? do you have any ideas? [13:55:06] and I am looking for simple ones [13:55:22] zeljkof: let me think for some time .... [13:55:48] vikasyaligar: I have an answer, but I would like to see you get there yourself :) [13:56:36] zeljkof: is the answer related to jenkins job ? [13:56:54] vikasyaligar: yes [13:57:20] I remember master slave; so if we can run the upload script from master [Not sure how to do it] [13:58:21] vikasyaligar: the solution I have is solved by one line change :) [13:58:27] does not get simpler than that [13:58:43] making it run on master, not sure if that is doable, maybe [13:59:00] other ideas? do not try to have good ideas, any ideas are good [13:59:16] any idea is good (probably better english) [14:02:31] zeljkof: nope ! cannot think of anything else :( [14:02:49] vikasyaligar: we could make the jobs run serially, right? :) [14:02:59] there is no need for them to run in parallel, is it? [14:03:16] it was the default, so we left it like that [14:03:35] do you know how to make the change? [14:03:44] won't it be slow later ? [14:04:32] zeljkof: nope ! how do you do it in 1 line ? [14:05:19] vikasyaligar: this is how matrix projects are defined [14:05:20] http://ci.openstack.org/jenkins-job-builder/project_matrix.html [14:05:39] and this is language screenshot job template [14:05:39] https://github.com/wikimedia/integration-jenkins-job-builder-config/blob/cloudbees/job_template.yaml#L11 [14:05:45] ah ! now I can do it :) [14:05:54] let me know if you get stuck :) [14:06:23] gerrit patch is on it's way for it :) [14:15:34] (03PS1) 10Vikassy: Language screenshot jobs run in serial now [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/148378 [14:16:13] zeljkof: is that it ^^ [14:16:24] vikasyaligar: I think it is :) [14:16:26] let me test it [14:16:50] vikasyaligar: but wait, you did not make a topic branch cccc :) [14:18:18] zeljkof: changing it through gerrit [14:18:31] vikasyaligar: that could break your local repo [14:18:40] but it might not [14:18:52] updating the local repo with review -d [14:19:15] vikasyaligar: but you already have this commit in cloudbees branch, that could be the problem [14:19:29] well, you can fix the problem later, if it happens [14:21:46] hmm ! not sure whether it will be a problem or not, because change-id will be same, so gerrit might know that the branch is same as earlier [Not sure, i am guessing ...] [14:23:05] vikasyaligar: if we change the commit in gerrit, it might conflict with your local one [14:23:08] but it looks good [14:23:08] https://integration.wikimedia.org/ci/view/BrowserTests/job/browsertests-VisualEditor-language-screenshot-linux-firefox-sauce/69/console [14:23:18] so if I just merge it, then it should be fine [14:23:24] only he is running :) [14:24:11] yup it is ! but I will miss the parallel one :) [14:25:29] (03PS2) 10Zfilipin: Language screenshot jobs run in serial now [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/148378 (owner: 10Vikassy) [14:31:59] (03CR) 10Zfilipin: [C: 032] Language screenshot jobs run in serial now [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/148378 (owner: 10Vikassy) [14:32:04] vikasyaligar: ^ :) [14:32:06] merged [14:32:31] aharoni: uploading rate problem solved with two one line commits :) [14:32:39] cool [14:32:45] https://gerrit.wikimedia.org/r/#/c/148378/ and https://gerrit.wikimedia.org/r/#/c/148368 [14:33:14] (03Merged) 10jenkins-bot: Language screenshot jobs run in serial now [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/148378 (owner: 10Vikassy) [14:33:40] aharoni: and bonus refactoring https://gerrit.wikimedia.org/r/#/c/148373/ [14:33:44] well done vikasyaligar :) [14:33:47] zeljkof: awesome :) [14:33:51] vikasyaligar++ [14:33:58] vikasyaligar: you should update bot page [14:34:13] to say you have solved the speed problem, point them to the commits [14:34:17] vikasyaligar: yes - explain the project, link to the project pages, and explain the upload rates. [14:34:23] and ask for a normal upload rate [14:34:23] answer people's questions. [14:34:34] that's part of mentoring and "community bonding" :) [14:34:40] aharoni: zeljkof yup writing that now :) [14:34:41] happens in every GSoC project ;) [14:34:55] aharoni: did I say the problem will be solved with two one-liners :) [14:35:05] zeljkof: yes you did :) [14:35:41] we could go fancy, but this is simple and robust and solves the problem, let's leave fancy solutions for fancy problems :) [14:53:30] (03PS1) 10Zfilipin: Added alumni section to readme file [selenium] - 10https://gerrit.wikimedia.org/r/148388 [15:01:21] mini: ready? [15:01:35] yes [15:02:17] i havaalready joined [15:11:50] mini: http://www.developsense.com/resources/Oracles.pdf [15:16:56] aharoni: replied => https://commons.wikimedia.org/wiki/Commons:Bots/Requests/LanguageScreenshotBot [15:37:54] mini: https://www.mediawiki.org/wiki/VisualEditor [16:00:46] zeljkof: around? [16:00:56] thanks for the links zeljko :) [16:01:01] chrismcmahon: in the hangout [16:05:24] The database has been automatically locked while the slave database servers catch up to the master http://en.wikipedia.beta.wmflabs.org/wiki/Special:Preferences [16:21:10] Nemo_bis: yeah a huge database upgrade is proceeding [16:21:14] https://bugzilla.wikimedia.org/show_bug.cgi?id=68349 [16:22:09] ok [16:24:23] Nemo_bis: pinged qa list about it [16:24:33] the Jenkins job is https://integration.wikimedia.org/ci/job/beta-update-databases-eqiad/label=deployment-bastion-eqiad,wikidb=simplewiki/2742/console [16:24:45] it takes a while and I have no idea how many entries it is going to proceed :-( [16:24:48] so no ETA [16:51:41] bd808: just occurred to me, is there any risk that this db update killing beta labs right now will do a similar thing in production? [16:52:37] It will if it's not applied carefully. We don't run update.php in prod though so I imagine that springle will do the update in a sane way. [16:53:17] bd808: OK, gotcha. thanks! [16:53:45] The things that is causing the slow down is this patch form Aaron -- https://gerrit.wikimedia.org/r/#/c/117373/ [16:54:39] You could touch base with him to see if he has worked out a plan with Sean to update production. [16:55:24] bd808: aaaand, James Forrester already noted the impact on beta labs, awesome [16:56:16] Man I really can't spell. [19:06:01] chrismcmahon: h [19:06:09] hi aharoni [19:06:15] hi [19:06:30] if the labs are broken, maybe the test jobs should be disabled? [19:06:33] I am getting fail mail [19:06:55] aharoni: I killed a lot of jobs. I may not have gotten yours in time. [19:08:45] aharoni: beta should be back to normal within the hour, sorry [19:12:44] chrismcmalunch: thanks [19:23:22] are we going to delete/massively shrink simplewiki? [20:12:37] greg-g: dunno. I didn't know simplewiki was that big, but I guess it's nice to have a big wiki to find out stuff like this. [20:52:13] I heard rumours there was an environment variable I could set to lengthen the timeouts? [20:52:22] Jon doesn't want me to lengthen them for everyone in env.rb [21:24:29] werdna: you mean for browser tests? take a look at https://github.com/cheezy/page-object/issues/79 [21:25:22] chrismcmahon: seen it, but that requires modifying env.rb [21:25:35] I worked around it by making env.rb look for environment variables. [21:35:29] I'm trying to find a reference for Watir selectors [21:40:06] werdna: http://rubydoc.info/gems/watir-webdriver/frames ? [21:40:36] chrismcmahon: I found that, but I can't find anything that tells me the things I can use to select elements [21:40:52] I found this: http://rubydoc.info/gems/watir-webdriver/Watir/ElementLocator [21:42:41] werdna: also https://github.com/watir/watirspec [22:08:30] chrismcmahon: I'm confused, I thought WMF browsertests used the Cheezy page object https://github.com/cheezy/page-object/wiki/Elements , is that different from Watir/ElementLocator ? [22:09:13] spagewmf: anything page-object doesn't recognize it passes down to watir-webdriver, it should all work. [23:31:54] (03PS1) 10EBernhardson: Add Echo dependency to Flow phpunit [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/148543 [23:36:58] (03CR) 10Werdna: [C: 032] Add Echo dependency to Flow phpunit [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/148543 (owner: 10EBernhardson) [23:37:25] (03Merged) 10jenkins-bot: Add Echo dependency to Flow phpunit [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/148543 (owner: 10EBernhardson) [23:52:27] chrismcmahon: not sure I understand what the watirspec is [23:56:43] werdna: test suite for the watir api. (watir api is generated automatically from the HTTP5 spec, ruby-selenium api generated from the Selenium W3C spec; Jari Bakken is a very bright guy.) [23:58:56] man, that is pretty neat [23:59:00] I love it when code writes itself [23:59:07] still figuring out how to read it :p [23:59:48] werdna: http://lanyrd.com/profile/jarib/slides/