[07:45:56] (03CR) 10Zfilipin: "Is there a reason to remove Gemfile.lock from the repo? I thought the file should be committed with Gemfile." [ruby/api] - 10https://gerrit.wikimedia.org/r/150371 (owner: 10Dduvall) [07:46:05] (03CR) 10Zfilipin: [C: 04-1] Better handling of API error responses [ruby/api] - 10https://gerrit.wikimedia.org/r/150371 (owner: 10Dduvall) [09:43:31] hashar: when my first wave of bugs is fixed, I'll need to understand what to do with some other problems I had, and I'd use some help in determining what's a configuration error and what isn't [09:44:37] Things like Fatal error: Class 'EtherEditorApiTestCase' not found in /srv/vagrant/mediawiki/extensions/EtherEditor/tests/phpunit/api/GetEtherPadTextTest.php on line 17 [09:45:35] and the commented stuff on http://p.defau.lt/?u6k2gc6oI27_Hu20fsiz1Q [09:46:16] buuug fill it :-] [09:46:25] Nemo_bis: ether editor is broken IIRC [09:46:34] it was some kind of experiment, I guess you can forget it [11:00:41] James_F|Away: Because it only ran lint tests which aren't enough confidence to verify it fully. One could override that in zuul-config to V+2 even without tests. But in general I think people use it this way to be reminded to check it out locally and test it by whatever means the maintiners feel it shoudl be tested. [11:00:57] Which at this point is probably just smoke testing and then V+2/CR+2 [11:02:59] (03PS8) 10Zfilipin: WIP Running Ruby linter for all repos that have Ruby code [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/150177 (https://bugzilla.wikimedia.org/63469) [11:03:02] (03PS6) 10Zfilipin: WIP Running Ruby linter for all repos that have Ruby code [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/150189 (https://bugzilla.wikimedia.org/63469) [11:18:56] hashar, Krinkle: how come we have both VisualEditor/VisualEditor and mediawiki/extensions/VisualEditor? [11:20:16] zeljkof: VisualEditor is a standalone HTML5 editing platform. The mediawiki extension is a relatively small layer that implements fetching from Parsoid and saving to MediaWiki. [11:20:46] Krinkle: thanks [11:20:46] There are also serverless implementations and plans for e.g. WordPress bridge. [11:20:56] yw [11:21:54] zeljkof: serverless https://doc.wikimedia.org/VisualEditor/master/lib/ve/demos/ve/desktop.html [11:22:24] (well, mostly for debugging so we can develop without mediawiki) [11:22:37] Krinkle: I have found ruby linter running for ve/ve [11:22:51] but there are probably no ruby files in that repo, checking now [11:24:00] zeljkof: There is one [11:24:06] zeljkof: jsduck extension [11:24:23] When we split the repos I considered removing the linter but decided to keep it [11:24:40] note that we optimise that job in zuul-config by only being added to the jenkins stack for changes that touch one or more .rb files. [11:24:58] Krinkle: that is what I was checking, if the job was running by mistake [11:25:10] if that was on purpose, then no problem there [12:19:51] (03PS1) 10Zfilipin: Minor readme update [selenium] - 10https://gerrit.wikimedia.org/r/150532 [12:40:01] (03PS2) 10Zfilipin: Minor readme update [selenium] - 10https://gerrit.wikimedia.org/r/150532 [12:47:57] (03PS7) 10Zfilipin: WIP Running Ruby linter for all repos that have Ruby code [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/150189 (https://bugzilla.wikimedia.org/63469) [12:48:00] (03PS9) 10Zfilipin: WIP Running Ruby linter for all repos that have Ruby code [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/150177 (https://bugzilla.wikimedia.org/63469) [12:50:49] (03PS10) 10Zfilipin: Running Ruby linter for all repos that have Ruby code [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/150177 (https://bugzilla.wikimedia.org/63469) [12:54:15] (03PS8) 10Zfilipin: Running Ruby linter for all repos that have Ruby code [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/150189 (https://bugzilla.wikimedia.org/63469) [12:55:12] hashar: I think these two commits are now ready [12:55:17] https://gerrit.wikimedia.org/r/#/c/150177/ [12:55:21] https://gerrit.wikimedia.org/r/#/c/150189/ [12:59:13] hello zeljkof [12:59:20] hi vikasyaligar [12:59:58] zeljkof: images are uploaded to commons in beta lab :) [13:00:16] http://commons.wikimedia.beta.wmflabs.org/wiki/Special:ListFiles/LanguageScreenshotBot [13:00:16] vikasyaligar: :) [13:00:42] zeljkof: have you deployed the jobs in jenkins? [13:00:43] all problems solved? [13:00:55] hashar: no, I was not sure if I did the right thing [13:01:00] specially for mediawiki/core [13:01:16] vikasyaligar: all problems solved? [13:01:17] reviewing :-] [13:01:25] hashar: great thanks [13:01:40] hashar: I have another commit that I need help with, when you are ready with this one [13:02:05] zeljkof: looks like so ! I will decrease the zoom level of certain images, so that we do not have scrollbar :) [13:02:08] vikasyaligar: and the job is green :) https://integration.wikimedia.org/ci/view/BrowserTests/job/browsertests-VisualEditor-language-screenshot-linux-firefox-sauce/ [13:02:15] yup it is :) [13:02:40] vikasyaligar: I am building it right now, to see if the last run was just luck :) [13:03:05] zeljkof: haha ok ! Till then I will be done with correcting the zoom :) [13:03:22] 3Wikimedia / 3Quality Assurance: Ruby linter should run after patch set submission to every repo that has Ruby code - 10https://bugzilla.wikimedia.org/63469#c5 (10Ċ½eljko Filipin) Basic ruby syntax check should now be running for all repos that have Ruby code. The next step is to run a linter. Dan has sugge... [13:08:06] (03CR) 10Hashar: [C: 04-1] "There is an issue with mediawiki/extensions/ContentTranslation part see inline diff." (032 comments) [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/150177 (https://bugzilla.wikimedia.org/63469) (owner: 10Zfilipin) [13:09:07] (03CR) 10Hashar: [C: 032] "Jenkins jobs are fine :-]" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/150189 (https://bugzilla.wikimedia.org/63469) (owner: 10Zfilipin) [13:09:32] zeljkof: the change for Jenkins jobs is fine, I +2ed it assuming you deployed the jobs already (if not should do!) [13:09:42] zuul config has a tiny mistake :-] [13:10:01] hashar: will deploy the jobs then right now [13:10:24] (03Merged) 10jenkins-bot: Running Ruby linter for all repos that have Ruby code [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/150189 (https://bugzilla.wikimedia.org/63469) (owner: 10Zfilipin) [13:12:23] hashar: yes, I was not sure about content translation too [13:12:27] will fix [13:14:05] (03PS11) 10Zfilipin: Running Ruby linter for all repos that have Ruby code [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/150177 (https://bugzilla.wikimedia.org/63469) [13:14:36] hashar: https://gerrit.wikimedia.org/r/#/c/150177/10..11/layout.yaml,unified [13:16:55] zeljkof: also suggest using a template https://gerrit.wikimedia.org/r/#/c/150177/ :D [13:18:00] (03Abandoned) 10Hashar: Adding DonationInterface test runner [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/71727 (owner: 10MarkTraceur) [13:19:24] hashar: what do you mean? [13:19:38] Maybe create a new template under 'project-templates'. Something like: [13:19:38] - name: extension-rubylint [13:19:38] check: [13:19:38] - 'mwext-{name}-ruby1.9.3lint' [13:19:38] test: [13:19:39] - 'mwext-{name}-ruby1.9.3lint' [13:19:39] gate-and-submit: [13:19:40] - 'mwext-{name}-ruby1.9.3lint' [13:19:40] Then apply it on the repositories having the 'extension-unittests' template. That will save up a bunch of repetition and easily add more ruby related jobs such as rubocop (ruby style linter). [13:20:22] hashar: can that be a separate commit? :) [13:20:25] (03PS2) 10Hashar: Add mwalker's new email address [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/150275 (owner: 10Mwalker) [13:20:29] (03PS3) 10Hashar: Add mwalker's new email address [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/150275 (owner: 10Mwalker) [13:21:06] (03CR) 10Hashar: [C: 032] "I have adjusted the commit message -:-)" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/150275 (owner: 10Mwalker) [13:21:18] (03Merged) 10jenkins-bot: Add mwalker's new email address [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/150275 (owner: 10Mwalker) [13:21:40] hashar: something is wrong with jjb/config repo [13:21:40] http://etherpad.wikimedia.org/p/jenkins-job-builder [13:21:49] do you get the same? [13:22:40] oh [13:22:55] reinstall Iguess [13:23:23] hashar: it works for you? the problem is in my local jjb? [13:23:33] local [13:23:34] :D [13:23:36] pip uninstall jenkins-job-builder [13:23:43] maybe a few times to make sure everything is removed [13:23:56] then move to your copy of integration/jenkins-job-builder git pull it [13:24:05] and pip install . [13:24:10] or pip install -e . [13:24:26] (-e being used if you want to be able to edit python code and have it reflect to your laptop wide installation) [13:25:20] hashar: I do not plan to touch any pythons :) [13:25:33] just pip install so :-D [13:25:42] and you can then drop the repo hehe [13:25:44] hashar: do I need to sudo? [13:25:47] brb coffee [13:25:53] depends on where it is going to install stuff [13:26:03] hashar: trying [13:26:11] (without sudo) [13:26:14] at worth [13:26:17] pip install --user [13:26:23] would install it somewhere under your homedir [13:26:37] with entry point probably in ~/bin [13:26:39] not sure [13:26:43] or sudo hehe [13:26:46] will try with sudo :) [13:26:50] without did not work [13:26:59] coffeeeeeeee [13:28:43] (03PS12) 10Zfilipin: Running Ruby linter for all repos that have Ruby code [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/150177 (https://bugzilla.wikimedia.org/63469) [13:32:30] zeljkof: tests are failing ! due to wikimedia errors in beta labs :( [Even I get those error pages of wikimedia sometimes when I run it in my local machines] [13:32:58] vikasyaligar: oh [13:33:33] back [13:35:29] (03PS8) 10Hashar: (WIP) Experiment zuul cloner (replace multigit.sh) (WIP) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/141819 [13:36:03] (03PS29) 10Hashar: (WIP) Experiment zuul-cloner with extensions [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/141846 [13:38:06] (03CR) 10Hashar: "rebased / fixed conflict" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/141819 (owner: 10Hashar) [13:38:49] hashar: should I rewrite this one? https://gerrit.wikimedia.org/r/#/c/150177/ [13:39:04] or can it get merged as is, and then I could refactor it [13:39:36] ? [13:40:01] Hi guys. Can someone please help me with this error I keep getting this error when I try to use git pull origin master: "fatal not a git repository". Its my first time setting up Git and I am using the mediawiki guide: http://www.mediawiki.org/wiki/Gerrit/Tutorial#Update_master [13:41:32] mazza: could you please copy/paste the entire text from your command line here? http://etherpad.wikimedia.org/p/mazza [13:43:13] hashar: when I deploy ruby jobs with [13:43:14] jenkins-jobs --conf etc/jenkins_jobs.ini update config/ mwext-*-ruby1.9.3lint [13:43:21] the existing ones got changed [13:43:26] https://integration.wikimedia.org/ci/job/mwext-CirrusSearch-ruby1.9.3lint/jobConfigHistory/showDiffFiles?timestamp1=2014-07-09_13-01-02×tamp2=2014-07-30_13-36-38 [13:43:29] zeljkof: Done :) [13:44:03] mazza: keep pasting below the text there, I have more quesitons [13:44:14] what do you get when you type this: ls [13:44:46] core [13:45:35] mazza: right [13:45:42] so, the error message said it all [13:45:50] you are in the wrong folder :) [13:45:57] wikimedia is not where the code is [13:46:04] the code is in wikimedia/core :) [13:46:12] haha [13:46:15] try "git pull" there :) [13:46:22] beta labs are down I think :( see this => https://integration.wikimedia.org/ci/job/browsertests-VisualEditor-language-screenshot-linux-firefox-sauce/LANGUAGE_SCREENSHOT_CODE=de,label=contintLabsSlave/85/console [13:49:16] zeljkof: when I try in that correct path which sort of works. it then says: are you sure you want to continue: yes/no [13:49:36] I typed yes and I got Permission denied (publickey) [13:49:42] mazza: output to etherpad or it did not happen :) [13:49:50] lol ok got it [13:50:14] mazza: a lot of things could go wrong, seeing the output helps [13:50:41] pasted [13:50:47] what does this output [13:50:54] git remote -v [13:52:16] origin //mazzax5@gerrit.wikimedia.org:29418/mediawiki/core (fetch) [13:52:18] origin mazzax5@gerrit.wikimedia.org:29418/mediawiki/core (push) [13:52:28] pasted in the etherpad [13:53:22] mazza: yes, please posting everything bigger than one line to the pad [13:53:31] well, did you enter the correct password? [13:53:35] (03PS9) 10Hashar: Use Zuul cloner to test mediawiki/core + vendor [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/141819 [13:53:36] try again [13:54:48] zeljkof: is it not appearing in the etherpad? :( [13:56:47] zeljkof: regarding https://gerrit.wikimedia.org/r/#/c/150177/ yes make it use a template (such as extension-rubylint [13:56:49] mazza: yes it is, I wanted to say that pasting more that one line to the pad is a godo thing [13:57:08] hashar: ok, working on it [13:58:00] (03CR) 10Manybubbles: [C: 032] Minor readme update [selenium] - 10https://gerrit.wikimedia.org/r/150532 (owner: 10Zfilipin) [13:58:02] (03Merged) 10jenkins-bot: Minor readme update [selenium] - 10https://gerrit.wikimedia.org/r/150532 (owner: 10Zfilipin) [14:00:26] Zeljkof: Ok, whats the next step? [14:00:59] mazza: did "git pull" work? [14:02:11] Permission denied (publickey). fatal: Could not read from remote repository. [14:02:51] mazza: uh oh [14:02:55] zeljkof: thats the new error I am getting now using git pull [14:03:09] zeljkof: that doesnt sound good :) [14:03:19] mazza: not sure what could be wrong [14:03:35] and I am in the middle of something else [14:03:45] zeljkof: didnt really ask me for any passwords or anything like that [14:03:56] zeljkof: I know [14:03:58] please send mail to qa mailing list, with all the steps you did [14:04:11] cool will do zeljkof. [14:04:53] (03PS10) 10Hashar: Use Zuul cloner to test mediawiki/core + vendor [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/141819 [14:05:39] (03CR) 10Hashar: "cleaned up the patch a bit. It runs concurrently on all production slaves now :-]" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/141819 (owner: 10Hashar) [14:05:39] zeljkof: thanks for your time and I will speak to you soon. take care all [14:05:58] mazza: sorry I was not of any help :( [14:06:29] zeljkof: dont worry mate, we cant all be superman ;) [14:06:41] mazza: :) [14:12:48] hashar: hello ! beta labs are down :( [14:14:33] (03PS13) 10Zfilipin: Running Ruby linter for all repos that have Ruby code [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/150177 (https://bugzilla.wikimedia.org/63469) [14:15:23] hashar: something like this? https://gerrit.wikimedia.org/r/#/c/150177/12..13/layout.yaml,unified [14:15:28] (03CR) 10jenkins-bot: [V: 04-1] Running Ruby linter for all repos that have Ruby code [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/150177 (https://bugzilla.wikimedia.org/63469) (owner: 10Zfilipin) [14:16:11] vikasyaligar: bah :-( [14:17:02] vikasyaligar: I have restarted HHVM on beta cluster. Might have fixed it [14:17:18] zeljkof: ok ! let me check. Thank you :) [14:17:21] ooop [14:17:29] hashar: ok ! let me check. Thank you :) [14:17:43] zeljkof: if you add the ruby lint to "extension-unittests" , that would add the job on all extension repositories [14:17:51] zeljkof: and most of them do not have the job in Jenkins job builder :] [14:22:25] hashar: ok, that was a mistake then :) [14:22:41] did you see lines 922-931? [14:22:47] something like that? [14:23:22] (03CR) 10Hashar: [C: 04-1] "almost :]" (035 comments) [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/150177 (https://bugzilla.wikimedia.org/63469) (owner: 10Zfilipin) [14:23:33] zeljkof: -1 https://gerrit.wikimedia.org/r/#/c/150177/13/layout.yaml,unified :D [14:23:42] zeljkof: yeah the template is fine [14:23:55] zeljkof: you will also have to apply it on the repos [14:24:00] i.e. at line 1682 [14:25:05] hashar: I see now [14:25:11] ok, let me try again [14:30:20] :-] [14:44:20] (03PS14) 10Zfilipin: Running Ruby linter for all repos that have Ruby code [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/150177 (https://bugzilla.wikimedia.org/63469) [14:44:28] (03CR) 10jenkins-bot: [V: 04-1] Running Ruby linter for all repos that have Ruby code [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/150177 (https://bugzilla.wikimedia.org/63469) (owner: 10Zfilipin) [14:44:50] hashar: I think I am getting somewhere, but obviously messed up something ^ [14:47:23] 3Wikimedia / 3Continuous integration: Add Jenkins jobs for OnlineStatus extension repo - 10https://bugzilla.wikimedia.org/68816 (10Florian) [14:47:24] 3Wikimedia / 3Continuous integration: Add Jenkins jobs for WhitelistPage extension repo - 10https://bugzilla.wikimedia.org/68858 (10Florian) 3NEW p:3Unprio s:3normal a:3None Can you add a phpcs jenkins job for extension WhitelistPages, please? https://gerrit.wikimedia.org/r/#/admin/projects/mediawik... [14:47:38] 3Wikimedia / 3Continuous integration: Add Jenkins jobs for WhitelistPage extension repo - 10https://bugzilla.wikimedia.org/68858 (10Florian) [14:47:38] 3Wikimedia / 3Continuous integration: Add Jenkins jobs for OnlineStatus extension repo - 10https://bugzilla.wikimedia.org/68816 (10Florian) [14:48:16] (03CR) 10Zfilipin: Running Ruby linter for all repos that have Ruby code (034 comments) [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/150177 (https://bugzilla.wikimedia.org/63469) (owner: 10Zfilipin) [14:56:53] (03PS15) 10Zfilipin: Running Ruby linter for all repos that have Ruby code [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/150177 (https://bugzilla.wikimedia.org/63469) [14:57:00] (03CR) 10jenkins-bot: [V: 04-1] Running Ruby linter for all repos that have Ruby code [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/150177 (https://bugzilla.wikimedia.org/63469) (owner: 10Zfilipin) [15:00:14] (03PS16) 10Zfilipin: Running Ruby linter for all repos that have Ruby code [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/150177 (https://bugzilla.wikimedia.org/63469) [15:00:23] (03CR) 10jenkins-bot: [V: 04-1] Running Ruby linter for all repos that have Ruby code [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/150177 (https://bugzilla.wikimedia.org/63469) (owner: 10Zfilipin) [15:02:46] (03PS17) 10Zfilipin: Running Ruby linter for all repos that have Ruby code [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/150177 (https://bugzilla.wikimedia.org/63469) [15:02:56] (03CR) 10jenkins-bot: [V: 04-1] Running Ruby linter for all repos that have Ruby code [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/150177 (https://bugzilla.wikimedia.org/63469) (owner: 10Zfilipin) [15:05:44] (03PS18) 10Zfilipin: Running Ruby linter for all repos that have Ruby code [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/150177 (https://bugzilla.wikimedia.org/63469) [15:08:03] hashar: huh, finally, all whitespace problems solved, looks like this is now ready for review :) ^ [15:11:20] \O/ [15:11:29] lets see whether I can nitpick about it [15:11:43] hashar: :) [15:13:45] zeljkof: you are missing jobs for ContentTranslation [15:14:07] zeljkof: ah no forget me [15:14:09] it already has the jobs [15:14:12] so that is fine [15:14:18] looking at zuul diff [15:14:58] zeljkof: deplooooyyyinnng [15:15:09] (03CR) 10Hashar: [C: 032] "excellent ! :-]" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/150177 (https://bugzilla.wikimedia.org/63469) (owner: 10Zfilipin) [15:15:17] (03Merged) 10jenkins-bot: Running Ruby linter for all repos that have Ruby code [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/150177 (https://bugzilla.wikimedia.org/63469) (owner: 10Zfilipin) [15:16:16] deployed! [15:17:06] 3Wikimedia / 3Continuous integration: Add Jenkins jobs for OnlineStatus extension repo - 10https://bugzilla.wikimedia.org/68816#c2 (10Andre Klapper) Florian: Is this about OggHandler or OnlineStatus? [15:18:36] 3Wikimedia / 3Continuous integration: Add Jenkins jobs for OnlineStatus extension repo - 10https://bugzilla.wikimedia.org/68816#c3 (10Florian) Andre: I thought it's clear after Siebrand changed the summmary :) It's about OnlineStatus, not OggHandler (i don't changed the summary in "clone this bug" :/) [15:20:56] hashar: thanks :) [15:23:53] hashar: I had a question about this one https://gerrit.wikimedia.org/r/#/c/150174/ [15:25:10] is that the way to delete old qa jobs? [15:25:20] or did we do it wrong? [15:29:04] zeljkof: sounds good to me [15:29:14] you will probably want to manually delete the jobs in Jenkins [15:29:17] though you can keep them around [15:29:35] hashar: is there a reason to keep them? [15:29:56] none [15:30:29] hashar: I would prefer to delete them then [15:30:36] +1 :-] [15:31:38] bd808: I got the mediawiki/core mediawiki/core/vendor Jenkins job working :] [15:31:48] gotta shoot a mail / RFC tonight [15:31:57] sweet! [15:32:11] hashar: so the jobs to delete are: qa-browsertests-run, qa-browsertests-build, qa-browsertests-yamllint, qa-browsertests-postmerge, qa-browsertests-ruby1.9.3lint [15:32:15] hashar: right? [15:32:52] you can look at the Jenkins job that does the diff [15:33:02] https://integration.wikimedia.org/ci/job/integration-jjb-config-diff/614/console [15:33:13] 00:02:01.185 Only in output-parent: qa-browsertests-build [15:33:13] 00:02:01.185 Only in output-parent: qa-browsertests-postmerge [15:33:13] 00:02:01.185 Only in output-parent: qa-browsertests-ruby1.9.3lint [15:33:13] 00:02:01.185 Only in output-parent: qa-browsertests-run [15:33:13] 00:02:01.185 Only in output-parent: qa-browsertests-yamllint [15:42:50] (03PS1) 10Zfilipin: WIP Ignore all rubocop warnings [ruby/api] - 10https://gerrit.wikimedia.org/r/150565 [15:43:08] (03PS2) 10Zfilipin: WikidataBrowserTests now has tests in tests/browser [selenium] - 10https://gerrit.wikimedia.org/r/150170 [15:46:18] (03PS2) 10Zfilipin: WIP Ignore all rubocop warnings [ruby/api] - 10https://gerrit.wikimedia.org/r/150565 [15:50:55] hashar: thanks, I knew that, but then I forgot about it :( [15:52:10] :-P [15:52:51] (03PS3) 10Zfilipin: WIP Ignore all rubocop warnings [ruby/api] - 10https://gerrit.wikimedia.org/r/150565 [16:15:19] greg-g: stupid hangout [16:32:26] Are these tests written in a specific (programming?) language? Or is it like a pseudo-code? [16:32:26] https://github.com/wikimedia/mediawiki-core/blob/master/tests/browser/features/preferences.feature [16:35:15] helderwiki: syntax is Cucumber, see http://cukes.info/ and https://github.com/cheezy/page-object [16:35:44] here we go :-) Thanks! [16:36:40] helderwiki: Cucumber "Scenarios" are interpreted in Ruby code. The general approach is called "Acceptance Test Driven Development" and there are a number of ways to implement ATDD, of which Cucumber is on that is very nice and well-supported [16:37:03] s/on/one/ [16:37:22] nice! [16:38:09] helderwiki: we've been using it for over 2 years now, it's been effective [16:39:31] I didn't look much in this part of the code in the past, but it always made me curious.. [16:41:09] Where can I see typical results for these tests? E.g. a failed test and an accepted test [16:41:14] chrismcmahon: ^ [16:41:20] helderwiki: if you'd like to learn more, my colleague Zeljko Filipin has an open invitation to pair-program using the framework: http://www.mediawiki.org/wiki/Pair_programming_for_fun_and_profit [16:41:33] helderwiki: https://integration.wikimedia.org/ci/view/BrowserTests/ [16:42:06] helderwiki: next builds kick off in about 100 minutes [16:42:07] heh that "Pair programming for fun and profit" page is one of tabs open in my browser right now :-) [16:42:25] helderwiki: Zeljko is a very good teacher [16:43:38] are there any specific pre-requisites for the pair-program? (maybe I should read the page before asking :-) [16:44:59] helderwiki: no, newbies are welcome. You might join #wikimedia-qa or look over the QA mail list https://lists.wikimedia.org/mailman/listinfo/qa [16:45:55] done yesterday night, so I think I'll keep reading a little more for now [16:45:59] thanks [16:46:52] helderwiki: Zelkjo lives in Croatia, so he tends to not be around during the day in California time much [16:47:11] what time (UTC) would be the best? [16:48:24] helderwiki: normal working hours UTC. I think CET is only one hour off UTC? [17:12:39] (03CR) 10Dduvall: "Sorry, I should have mentioned that in the commit message." [ruby/api] - 10https://gerrit.wikimedia.org/r/150371 (owner: 10Dduvall) [17:25:26] Hi James [17:26:22] I have a question regarding bug 68539 [17:27:06] i can reproduce it in test2 with the release ver.1.24wmf15 (148011a) [17:28:55] but not in beta [17:32:47] (03CR) 10Manybubbles: [C: 032] WikidataBrowserTests now has tests in tests/browser [selenium] - 10https://gerrit.wikimedia.org/r/150170 (owner: 10Zfilipin) [17:32:49] (03Merged) 10jenkins-bot: WikidataBrowserTests now has tests in tests/browser [selenium] - 10https://gerrit.wikimedia.org/r/150170 (owner: 10Zfilipin) [17:55:31] bd808: off the top of your head, do you know if y'all were using HHVM in beta labs on July 16? [17:57:02] chrismcmahon: I don't think so. I think we turned it on around 7/21 [17:57:51] bd808: thanks, Mobile folk reported some funky behavior that date that I don't remember in particular [18:30:02] greg-g: ping when ready [18:30:59] chrismcmahon: ready [18:39:08] 3Wikimedia / 3Continuous integration: Add Jenkins jobs for JSBreadCrumbs extension repo - 10https://bugzilla.wikimedia.org/68871 (10Florian) [18:39:08] 3Wikimedia / 3Continuous integration: Add Jenkins jobs for OnlineStatus extension repo - 10https://bugzilla.wikimedia.org/68816 (10Florian) [18:39:10] 3Wikimedia / 3Continuous integration: Add Jenkins jobs for JSBreadCrumbs extension repo - 10https://bugzilla.wikimedia.org/68871 (10Florian) 3NEW p:3Unprio s:3normal a:3None Can you add a phpcs jenkins job for extension JSBreadCrumbs, please? https://gerrit.wikimedia.org/r/#/admin/projects/mediawiki... [18:39:21] 3Wikimedia / 3Continuous integration: Add Jenkins jobs for OnlineStatus extension repo - 10https://bugzilla.wikimedia.org/68816 (10Florian) [19:28:23] 3Wikimedia / 3Continuous integration: Add Jenkins jobs for AutomaticBoardWelcome extension repo - 10https://bugzilla.wikimedia.org/68873 (10Florian) 3NEW p:3Unprio s:3normal a:3None Can you add a phpcs jenkins job for extension AutomaticBoardWelcome, please? https://gerrit.wikimedia.org/r/#/admin/pr... [20:02:09] marxarelli: pingaling [20:02:12] oh there you are [21:44:14] Anyone know if there is a way to make browser tests use a proxy? [21:45:11] Setting HTTP_PROXY uses the proxy to talk to localhost:7055 (watir?), which is just a bunch of json [21:47:36] csteipp: you want to configure the browser that selenium is driving to use a proxy? [21:47:51] marxarelli: Yep [21:49:31] csteipp: http://docs.seleniumhq.org/docs/04_webdriver_advanced.jsp see "Using a proxy", see if that helps. [21:51:09] ah, thanks chrismcmahon. should csteipp put that in a Before hook? [21:51:45] chrismcmahon: I was just going to ask where to put that :) [21:52:36] marxarelli csteipp: probably? I've never done it in anger before. [21:54:41] csteipp: a before hook seems like the right place. let me know if you want to pair on it [21:54:56] marxarelli: Yeah, I might need that