[00:17:11] (03PS5) 10Dduvall: Feature-extension dependency system [selenium] - 10https://gerrit.wikimedia.org/r/151802 [01:35:50] after hundreds of failures, https://integration.wikimedia.org/ci/view/BrowserTests/job/browsertests-Flow-en.wikipedia.beta.wmflabs.org-windows_8-internet_explorer-sauce/ passes [06:53:45] hello [08:01:00] (03PS5) 10Hashar: Add missing extensions and fix order of list [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/152140 (owner: 10Addshore) [08:06:19] (03CR) 10Hashar: [C: 032] "All jobs deployed. Now we need to add them to Zuul with the extension-unittest template, send dummy change for each of the new extension " [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/152140 (owner: 10Addshore) [08:07:38] (03Merged) 10jenkins-bot: Add missing extensions and fix order of list [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/152140 (owner: 10Addshore) [08:34:02] (03CR) 10Cmcmahon: "This turns out to be a bad idea. test2wiki is one of very few wikis with VisualEditor as the default wiki editor, so the tests for pure c" [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/151044 (owner: 10Zfilipin) [08:44:23] zeljkof: when you have time, can you review this => https://gerrit.wikimedia.org/r/#/c/150833/ [08:44:50] vikasyaligar: in 10 minutes [08:45:04] zeljkof: ok ! thank you :) [08:55:00] vikasyaligar: +2d :) [08:55:04] looks good to me! [08:55:30] thank you :) [08:55:41] zeljkof: this one also => https://gerrit.wikimedia.org/r/#/c/150803/ [08:55:59] vikasyaligar: looking [08:56:22] vikasyaligar: didn't we already merge that one? :) [08:57:16] zeljkof: nope we were just testing if we get green on the test2 :) [08:58:14] (03CR) 10Zfilipin: [C: 04-1] Language screenshot job should run on test2.wikipedia.org (031 comment) [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/150803 (owner: 10Vikassy) [08:58:30] vikasyaligar: minor tweak and it is ready to go :) [08:59:17] hi zeljkof if you get a moment, could you take a look at the Math test for Chrome? it seems to be typing the wrong password and I do not see the problem https://integration.wikimedia.org/ci/job/browsertests-Math-en.wikipedia.beta.wmflabs.org-linux-chrome-sauce/15/testReport/junit/(root)/Math/Display_simple_math/ [08:59:23] zeljkof: ok ! will do it now :) [08:59:52] chrismcmahon: sure, looking [09:01:55] (03CR) 10Zfilipin: "Should we abandon this commit and delete the job?" [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/151044 (owner: 10Zfilipin) [09:03:47] (03CR) 10Cmcmahon: "I think we should. I forgot about the VE situation on test2, and that it would cause the Core tests not to work properly." [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/151044 (owner: 10Zfilipin) [09:05:46] (03PS6) 10Vikassy: Language screenshot job should run on test2.wikipedia.org [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/150803 [09:06:46] chrismcmahon: I am not sure why logging in does not work for math job, the password is correct [09:07:35] chrismcmahon: wow, and the same test if failing for the last 6 runs [09:07:36] strange [09:08:19] chrismcmahon: will try reproducing locally [09:11:05] zeljkof: chrismcmahon Did you know that people can see password of Selenium_user from this url => https://saucelabs.com/jobs/72d7f29593da407e9e62c53d19cb51e2 ? [09:11:23] vikasyaligar: yes :( [09:11:35] there is actually no way to hide it [09:11:40] at least none that we found [09:11:55] we might have to contact sauce support [09:12:06] chrismcmahon: should I do that? [09:13:33] hmm ! I came to know about it just now :) [09:17:16] zeljkof: done with the change, which you had commented => https://gerrit.wikimedia.org/r/#/c/150803 [09:18:30] (03CR) 10Zfilipin: [C: 032] Language screenshot job should run on test2.wikipedia.org [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/150803 (owner: 10Vikassy) [09:18:38] vikasyaligar: +2d :) [09:18:56] thank you :) [09:19:56] (03Merged) 10jenkins-bot: Language screenshot job should run on test2.wikipedia.org [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/150803 (owner: 10Vikassy) [09:24:48] (03Abandoned) 10Zfilipin: Running mediawiki/core job at test2 [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/151044 (owner: 10Zfilipin) [09:26:03] (03CR) 10Addshore: "I better get started then ;p" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/152140 (owner: 10Addshore) [09:27:00] hashar: shall I split the commits up a bit to zuul config? how many per commit would be nice? [09:27:14] addshore: na just push one big commit :-] [09:27:20] haha :P okay! [09:27:27] will merge / deploy [09:27:31] then we can trigger fake changes [09:27:39] did we decide we cared about the order? ;p [09:27:42] I try to commit the fake changes using the same Change-Id [09:27:54] to make it easier to look them up [09:27:58] then fill bug for any job failling [09:28:02] sounds like a plan! [09:28:05] and make them non voting in zuul [09:28:17] you can even have the Zuul change to have the same change-id as the jjb change [09:29:49] did you decide if you cared about alphabetical order hashar or the order is somehting we can clean up later? [09:30:26] alphabetical :-) [09:30:30] I know it is long and tedious [09:30:36] :P [09:30:56] thers 433 friggin extensions needed to be added ;p [09:31:07] ahhh [09:31:18] start adding Zuul triggers for the jenkins jobs added yesterday [09:31:21] that is less tedious :] [09:31:37] mind sharing the list of all the 433 extensions? [09:33:16] https://etherpad.wikimedia.org/p/addshore [09:33:45] http://pastebin.com/hRRAwePm [09:33:46] xD [09:34:23] so that is only three: meh, using and pastebin [09:34:25] sounds easy [09:34:40] addshore: so hmm [09:34:41] hha, [09:35:05] 1731 new lines too the zuul config :P [09:35:26] do we have jobs for all of them ? [09:35:35] i.e. are they listed in the long array of extensions in JJB [09:35:37] they are all added to the jenkins config builder yes [09:35:42] greaat [09:35:51] then s/extension-checks/extension-unittests [09:35:55] the checks just run lint command [09:36:00] they don't run mw core phpunit tests [09:36:08] which has a bunch of structure checkers for extensions [09:36:15] huh? :P I dont follow :) [09:36:16] they are beneficial to be run even when the extension has no test [09:36:27] extension-checks? [09:36:37] ex: making sure autoloader is fine, compile less files, resource loader modules properly registered [09:36:42] ahh okay [09:36:47] yeah the zuul template [09:37:06] there are still some extension-checks [09:37:13] got to slowly migrate them to extension-unittests [09:37:18] but [09:37:31] well, that can be the next task :P [09:37:35] the issue is that adding those triggers will most certainly cause Jenkins to vote Verified -2 on a whole bunch of repositories [09:37:37] annoying devs [09:38:28] so, how about add them ALL as non voting for now, and then slowly turn the voting on? [09:39:00] not too bad :] [09:39:10] sounds like a plan then? ;p [09:39:26] *approved* [09:39:27] hehe [09:39:38] :P [09:39:42] that is clever than my way of breaking everything then making non voting hehe [09:39:44] THOUGH [09:39:52] having verified -2 let me easily spot the one that fail [09:39:54] and then fill bug [09:40:12] meh, I can go through them, its only 433 extensions right ;p [09:40:19] :-D [09:40:33] also to add to the mess [09:40:40] some extensions depends on other extensions [09:40:51] and each dependency has to be added manually in some yaml cruft below :-( [09:42:13] right, so my plan will be to add these currently not in alphabetical order, also add the checks as false (not in alphabetical order) within some large comment blocks? And as we go through each one and see if it is passing move it into the correct place and make it voting? [09:42:28] sounds good [09:42:44] Right! [09:42:48] and scary! :-] [09:43:04] need to make both jslint and lint non voting right? [09:43:48] lint runs php -l [09:43:52] so yeah should be non voting [09:43:57] jslint is a different beast [09:44:12] it runs a PHP script that ensure the .json files pass PHP json_decode() [09:44:13] AND [09:44:16] * hashar rolls the drum [09:44:20] run jshint [09:44:27] which is f*** up on almost all repos [09:44:30] :D [09:44:36] I should split them [09:44:42] so make both jobs for every extension non voting for now? ;p [09:44:58] lint voting (it is php -l [09:45:01] jslint non voting [09:46:48] wait, but phplint will also fail in many places right now? [09:47:11] wernt we making everything non voting and slowly enabling them when we know they are passing [09:49:45] or just non voting jslint? :P [09:52:45] (03CR) 10Zfilipin: "I am confused. How come this is not merged into master, but I can see it in master?" [ruby/api] - 10https://gerrit.wikimedia.org/r/148083 (owner: 10Zfilipin) [09:58:20] hashar: when you have a minute, could you please take a look at ^ [09:58:34] zeljkof: force pushed ? :D [09:58:52] let me check [09:58:54] hashar: what does that mean? somebody did not use git review? [09:59:05] but git push? [09:59:30] zeljkof: that patch is in the gerrit branch 'json' [09:59:33] which got merged in master [09:59:40] and your change is against master [09:59:49] I guess if you press [Rebase Change] [09:59:55] it will end up being a noop change [10:00:00] and thus should probably be abandonned [10:00:17] hashar: The change could not be rebased due to a path conflict during merge. [10:00:23] thanks, abandoning [10:00:38] (03Abandoned) 10Zfilipin: Use "let" keyword to define local variables [ruby/api] - 10https://gerrit.wikimedia.org/r/148083 (owner: 10Zfilipin) [10:01:01] Downloading refs/changes/83/148083/1 from gerrit [10:01:01] Switched to branch "review/zfilipin/let" [10:01:09] git checkout master [10:01:11] git branch --merged [10:01:15] * master [10:01:15] review/zfilipin/let [10:01:17] it is in :-] [10:01:35] hashar: I still do not understand what happened [10:01:45] but anyway, it got merged [10:03:43] (03PS1) 10Addshore: WIP Add zuul trigger for all extension repos in gerrit [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/152236 [10:03:56] (03CR) 10jenkins-bot: [V: 04-1] WIP Add zuul trigger for all extension repos in gerrit [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/152236 (owner: 10Addshore) [10:04:07] 3Wikimedia / 3Quality Assurance: Implement tests for exporting pages to PDF files using Chrome - 10https://bugzilla.wikimedia.org/57921#c7 (10Željko Filipin) 5NEW>3RESO/WON I have no plans on implementing this in the near future. If somebody wants to work on this, please move it to a pdf extension. [10:05:10] (03PS2) 10Addshore: WIP Add zuul trigger for all extension repos in gerrit [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/152236 [10:05:27] (03CR) 10jenkins-bot: [V: 04-1] WIP Add zuul trigger for all extension repos in gerrit [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/152236 (owner: 10Addshore) [10:06:04] (03PS3) 10Addshore: WIP Add zuul trigger for all extension repos in gerrit [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/152236 [10:06:43] (03CR) 10jenkins-bot: [V: 04-1] WIP Add zuul trigger for all extension repos in gerrit [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/152236 (owner: 10Addshore) [10:08:17] hashar: any idea about this apparent APX failure? https://integration.wikimedia.org/ci/job/integration-zuul-config-tox-py27/81/console [10:08:35] oh.. is_in_gerrit [10:08:35] 10:06:10 assert zuul_project in GERRIT_REPOS [10:09:12] (03PS1) 10Addshore: Remove APX extension (not in gerrit) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/152238 [10:09:43] (03PS4) 10Addshore: WIP Add zuul trigger for all extension repos in gerrit [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/152236 [10:12:45] well hashar its passes, but we want to disable phplint for all the extensions I added to zuul config for ext-checks triggers too right? [10:14:41] zeljkof: well the commit got pushed somehow to the branch 'json' [10:14:53] zeljkof: and that branch got merged in master. Hence the commit show up in master :] [10:15:09] addshore: ssert zuul_project in GERRIT_REPOS [10:15:22] addshore: the job list all projects on gerrit using gerrit ls-projects [10:15:31] I fixed that one hashar :) [10:15:35] hashar: makes sense, but I am not sure how that would happen [10:15:36] addshore: if you add triggers for a project which is not / no more in Gerrit you have a problem [10:16:01] addshore: the phplint job should be voting imho [10:16:13] addshore: if there is some parse error in a php file we can fix it up :] [10:16:25] right then, thats patch is /ready/ then [10:16:38] (03PS5) 10Addshore: Add zuul trigger for all extension repos in gerrit [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/152236 [10:20:58] This is all sort of stemming from discussion at a talk yesterday > http://etherpad.wikimedia.org/p/wm2014-3rdparty [10:22:25] (03PS3) 10Zfilipin: WIP The first PdfHandler Selenium tests [selenium] - 10https://gerrit.wikimedia.org/r/144984 [10:23:57] (03PS4) 10Zfilipin: The first PdfHandler Selenium tests [selenium] - 10https://gerrit.wikimedia.org/r/144984 [10:24:51] addshore: I am out for lunch [10:24:55] kk =] [10:25:00] be back in 1 hour and a half [10:37:30] (03PS1) 10Zfilipin: The first PdfHandler job [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/152246 [10:43:21] (03PS2) 10Zfilipin: The first PdfHandler job [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/152246 [10:51:35] (03PS5) 10Zfilipin: The first PdfHandler Selenium tests [selenium] - 10https://gerrit.wikimedia.org/r/144984 [10:52:12] (03PS3) 10Zfilipin: The first PdfHandler job [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/152246 [10:55:10] (03PS4) 10Zfilipin: The first PdfHandler job [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/152246 [11:14:21] (03CR) 10Zfilipin: "Dan, is there a reason this still has -2 from you? mediawiki_api gem is released now." [selenium] - 10https://gerrit.wikimedia.org/r/151802 (owner: 10Dduvall) [11:14:56] (03PS5) 10Zfilipin: WIP Enable browser tests for the GettingStarted extension [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/150172 (https://bugzilla.wikimedia.org/52246) (owner: 10Phuedx) [11:17:36] (03CR) 10Zfilipin: [C: 04-1] WIP Enable browser tests for the GettingStarted extension (032 comments) [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/150172 (https://bugzilla.wikimedia.org/52246) (owner: 10Phuedx) [11:21:14] (03PS3) 10Zfilipin: Add job for PageTriage tests [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/149327 (https://bugzilla.wikimedia.org/67134) (owner: 10Cmcmahon) [11:23:23] (03CR) 10Zfilipin: [C: 032] Add job for PageTriage tests [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/149327 (https://bugzilla.wikimedia.org/67134) (owner: 10Cmcmahon) [11:23:51] (03Merged) 10jenkins-bot: Add job for PageTriage tests [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/149327 (https://bugzilla.wikimedia.org/67134) (owner: 10Cmcmahon) [11:23:52] 3Wikimedia / 3Quality Assurance: create build for PageTriage browser test - 10https://bugzilla.wikimedia.org/67134 (10Željko Filipin) 5PATC>3RESO/FIX [11:24:45] (03PS2) 10Zfilipin: Updated MEDIAWIKI_API_UPLOAD_URL for language screenshot job [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/147415 (owner: 10Vikassy) [11:27:20] (03CR) 10Zfilipin: [C: 04-1] Updated MEDIAWIKI_API_UPLOAD_URL for language screenshot job (031 comment) [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/147415 (owner: 10Vikassy) [11:30:30] (03PS3) 10Zfilipin: Minor improvements to API-client configuration [selenium] - 10https://gerrit.wikimedia.org/r/147527 (owner: 10Dduvall) [11:32:17] (03CR) 10Zfilipin: [C: 032] Minor improvements to API-client configuration [selenium] - 10https://gerrit.wikimedia.org/r/147527 (owner: 10Dduvall) [11:32:19] (03Merged) 10jenkins-bot: Minor improvements to API-client configuration [selenium] - 10https://gerrit.wikimedia.org/r/147527 (owner: 10Dduvall) [11:42:43] I'm trying to follow the guide on https://www.mediawiki.org/wiki/Quality_Assurance/Browser_testing/Setup_instructions running physikerwelt@drmf:~$ sudo labs-vagrant enable-role browsertests [11:42:43] 'browsertests' is not a valid role. [11:43:00] leads to the error message above [11:52:08] 3Wikimedia / 3Continuous integration: Add Jenkins jobs for WhitelistPages extension repo - 10https://bugzilla.wikimedia.org/68858 (10Addshore) [11:56:37] oh hi hashar ;p [12:01:45] addshore: yeah back [12:01:53] merge merge merge merge merge :P [12:10:28] can't can't can't :D [12:10:36] why why ? :( [12:10:37] addshore: I am fixing up Zuul source code :D [12:10:44] pah! [12:10:51] relying on evil trickiness to ship a bunch of dependencies I need huhu [12:11:13] but if you merge merge then I can poke all 400+ repos and see if they pass ;p [12:11:34] sure hold a few minutes :-D [12:11:38] :P [12:14:17] F¨***** Y**** Precise!!!!!!!!!! [12:14:19] it is outdated [12:14:20] bah [12:18:02] *clones the 400 repos [12:18:44] addshore: they should almost all be in mediawiki/extensions.git already [12:19:03] meh, I dont really use that thing :P [12:19:07] syncing it [12:19:18] maybe I should just check it out :P [12:22:28] AH [12:22:30] I got zuul upgraded [12:22:31] evil [12:28:52] zeljkof: do you use any mergetool to solve merge conflicts ? [12:29:16] hashar: any new features? ;p [12:29:17] vikasyaligar: no [12:29:32] vikasyaligar: I use vim :) [12:29:32] addshore: na just some preliminary work [12:29:45] addshore: will eventually bump Zuul version next week [12:29:54] zeljkof: wow ! ok :) [12:42:37] zeljkof: Is there a replacement for the vagrant browsertests role? I tried to set up according to the guide but I can not get a firefox connection even though I ran sudo apt-get install firefox [12:43:02] physikerwelt: I am not sure :( [12:43:21] the last time I have used vagrant the role was still there [12:43:46] physikerwelt: could you please create a bug in bugzilla about that? [12:43:53] so it does not get forgotten [12:44:05] and please add me to cc, I will ping all the right people [12:44:48] (03PS1) 10Zfilipin: Fixed the location of tests and how to contribute [selenium] - 10https://gerrit.wikimedia.org/r/152274 [12:45:57] zeljkof: I have more the impression me being stupid... I don't understand how firefox is supposed to work on a system that has no graphical interface [12:46:12] physikerwelt: it can work headless [12:46:24] I have to go now, will be back in an hour or two, we can continue then [12:46:27] sorry about that [12:46:47] k cu [12:47:49] (03PS1) 10Zfilipin: Fixed how to contribute [ruby/api] - 10https://gerrit.wikimedia.org/r/152277 [12:48:00] addshore: sorry I am done for good now [12:48:55] (03CR) 10Physikerwelt: [C: 04-1] Fixed the location of tests and how to contribute (032 comments) [selenium] - 10https://gerrit.wikimedia.org/r/152274 (owner: 10Zfilipin) [12:52:06] and beta code update is broken [12:52:11] https://integration.wikimedia.org/ci/job/beta-code-update-eqiad/ [12:54:43] yay! [12:55:32] (03CR) 10Physikerwelt: [C: 031] Fixed how to contribute [ruby/api] - 10https://gerrit.wikimedia.org/r/152277 (owner: 10Zfilipin) [12:57:03] beta cluster code update fixed :-D [12:57:08] addshore: so where are the patches ? :-] [12:57:37] (03PS3) 10Hashar: Move MediaWiki HHVM job to Trusty instance(s) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/152179 [12:58:21] (03CR) 10Hashar: [C: 032] "Refreshed the remaining jobs" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/152179 (owner: 10Hashar) [12:59:10] (03Merged) 10jenkins-bot: Move MediaWiki HHVM job to Trusty instance(s) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/152179 (owner: 10Hashar) [13:00:35] hashar: https://gerrit.wikimedia.org/r/#/c/152238/ and https://gerrit.wikimedia.org/r/#/c/152236/ ? :P [13:01:57] (03PS2) 10Hashar: Remove APX extension (not in gerrit) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/152238 (owner: 10Addshore) [13:02:11] (03CR) 10Hashar: [C: 032] "I am removing APX Jenkins jobs manually." [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/152238 (owner: 10Addshore) [13:03:16] APX is gone [13:03:55] =] [13:04:15] andddd [13:04:17] that broke zuul [13:04:18] yeah [13:04:18] urgh I think I am mkaing this wifi grind to a halt [13:04:44] removing apx from jjbc broke zuul? :P [13:05:28] (03Merged) 10jenkins-bot: Remove APX extension (not in gerrit) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/152238 (owner: 10Addshore) [13:08:20] not just the ultimate zuul patch that will break everything? ;p [13:08:38] addshore: oh my god :-] [13:10:42] addshore: extension-checks -> extension-unittest [13:10:50] on all of them? :P [13:10:55] but then you will need a bunch of ignore rules for mwext--testextensions-master [13:10:57] yeah [13:11:06] that runs the mw/core testsuite extensions [13:11:07] thats okay, can be done [13:11:08] :) [13:11:18] which runs UnitTestsList hook or something like that [13:11:18] gimme a few mins :p [13:11:22] + a bunch of tests which are in core [13:11:27] I guess just replace [13:11:36] then copy paste the voting: false list and replace :] [13:11:51] yup :P [13:11:55] addshore: can you link the raw list of extensions ? [13:12:02] I have a script to generate changes and submit them :] [13:12:06] https://www.irccloud.com/pastebin/ZQrRX2Z8 [13:12:30] thats everything I am adding to zuul now (that are all already in jjbc) [13:12:41] and thats everything in gerrit, except sub extensions with a / [13:16:59] addshore: how to setup git-review on all extensions [13:17:02] :: find * -name .git |xargs -n1 -P8 -I{} bash -c 'cd `dirname {}`; git-review -s' [13:17:03] crazy [13:17:24] (03PS6) 10Addshore: Add zuul trigger for all extension repos in gerrit [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/152236 [13:18:20] heh, still getting all the extensions on the wifi right now :/ [13:18:35] was going to find Reedy and grab them all off his laptop but dont know where he has gone :p [13:18:35] will do [13:18:37] dont worry [13:19:02] https://integration.wikimedia.org/ci/job/integration-zuul-layoutdiff/1530/console has the whole list [13:19:04] 8MB + [13:20:01] step two [13:20:05] ensuring we have nice repos [13:20:06] find * -name .git |xargs -n1 -P8 -I{} bash -c 'cd `dirname {}`; git fetch gerrit && git reset --hard gerrit/master' [13:20:21] (03CR) 10Hashar: [C: 032] "Lets unleash the beast!" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/152236 (owner: 10Addshore) [13:20:53] haha [13:20:58] nearly finished getting all those exts! [13:20:59] (03Merged) 10jenkins-bot: Add zuul trigger for all extension repos in gerrit [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/152236 (owner: 10Addshore) [13:21:06] mwhahahahahaa *fingers crossed* [13:21:44] so we just need a minor commit to each extension now? :P [13:21:45] addshore: will do a massive amount of commit [13:21:48] and kill Gerrit :-D [13:21:53] yeah got a script to do that :] [13:21:56] is zuul updated? :) [13:21:57] haha [13:21:59] not yet [13:22:07] what change does your script actually make? xD [13:22:22] send a commit message with first like: Jenkins validation (DO NOT SUBMIT) [13:22:27] and third line having some given Change-Id [13:22:42] hmm, but empty commit? [13:23:35] commits cant be empty? you must touch something? [13:25:30] addshore: yeah some jobs only trigger when some specific files are touched [13:25:39] i.e. ruby lint jobs are only triggered when a .rb file is created [13:25:53] lets create 432 dummy commit [13:25:54] urgh, true! [13:25:58] and... 432 dummy changes [13:26:07] maybe I should make you an author :-] [13:26:08] 432 changes each making a php js and rb file? ;p [13:26:13] yeah [13:26:22] https://integration.wikimedia.org/zuul/ is going to be pretty filled [13:26:29] hehe, oh well ;p [13:29:45] addshore: your list has some errors apparently [13:29:47] -bash: cd: DataValuesCommon: No such file or directory [13:29:47] -bash: cd: ImageMetrics: No such file or directory [13:29:47] -bash: cd: MultimediaPlayer: No such file or directory [13:29:47] -bash: cd: NewsBox: No such file or directory [13:29:47] -bash: cd: PhpTagsSMW: No such file or directory [13:29:47] -bash: cd: Screenplay: No such file or directory [13:29:48] -bash: cd: ShortUrlApi: No such file or directory [13:29:48] -bash: cd: StaffEdits: No such file or directory [13:29:48] -bash: cd: TwitterLogin: No such file or directory [13:30:11] heh, they are there, I just cloned them [13:30:20] indeed they are in Gerrit [13:30:23] but not in my local clone [13:30:23] hmm [13:30:25] :P [13:31:03] hashar: this is the sample change right? [13:31:03] https://gerrit.wikimedia.org/r/#/c/143591/ [13:31:10] just add one of everything? [13:31:20] addshore: yeah I am doing so right now [13:31:28] Ill do it on those you listed above if you want [13:32:32] addshore: I am trying to understand why I don't have them [13:33:28] hehe [13:38:40] *waits for the onslaught* [13:41:31] hi hashar... could you comment whether we can exclude directories from phplint? [13:41:47] Nikerabbit: can't remember how we execute it [13:42:00] I think it just looks for files .php .phtml .inc and execute php -l on them [13:45:09] addshore: yeah I am going to skip the extensions reported above [13:45:40] addshore: when crafting dummy commits use Change-Id: I0cbfadb4363df19f3a3ff6819280e5ccbedc50b9 [13:45:53] okay :) I'll add them to a list of things to check later on [13:46:15] hashar: so in short "no" [13:46:30] Nikerabbit, no but there probably could be with a bit of work [13:46:35] Nikerabbit: no, look at the phplint command and figure out whether it is possible [13:46:44] I don't think it is [13:47:22] suck that we need to modify upstream files... [13:47:57] perhaps I should just put it via composer [13:51:50] addshore: patches ready [13:52:10] (03PS1) 10Addshore: Remove triggers for empty repos to be removed [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/152295 [13:52:52] (03PS1) 10Addshore: Remove jobs for empty repos to be removed [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/152296 [13:53:55] lets unleash the best [13:53:56] addshore: cat DAEXT|gxargs -n1 -I{} --interactive bash -c 'cd {} && git-review -R' [13:54:00] lovely :P [13:54:01] crazy :-) [13:54:08] where in bugzilla should requests to have gerrit repos deleted go? [13:54:09] then just have to press Y [13:54:19] Wikimedia > git/gerrit I guess [13:54:39] so [13:54:45] using the same Change-Id we can now https://gerrit.wikimedia.org/r/#/q/I0cbfadb4363df19f3a3ff6819280e5ccbedc50b9,n,z [13:54:48] and see all the changes [13:56:17] Nikerabbit: it is probably doable to adjust phplint to ignore some files [13:56:30] Nikerabbit: or even have it ignore files listed in some file at the root of the repository [13:56:39] Nikerabbit: but someone (i.e. not me) will have to figure out the implementation details [13:57:49] Nikerabbit: the script is in integration/jenkins-job-builder-config.git in the file macro.yaml . Look up for phplint [13:57:54] /srv/deployment/integration/slave-scripts/bin/git-changed-in-head php php5 inc phtml module install \ [13:57:54] | xargs -n1 -t php -l [13:58:24] I don't think xargs has support to discard strings passed to it [13:58:49] addshore: jenkins is soooo fast [13:58:53] xD [13:59:03] when there are no / not many tests to run [13:59:20] and Gerrit server barely blink an eye [13:59:28] ytterbium http://ganglia.wikimedia.org/latest/?c=Miscellaneous%20eqiad&h=ytterbium.wikimedia.org&m=cpu_report&r=hour&s=descending&hc=4&mc=2 [14:00:06] hows the progress of getting to be able to run composer to get deps for unit tests etc.? [14:00:16] addshore: the tedious thing will be to parse the results to figure out which jobs pass / do not pass [14:00:24] hehe [14:00:28] addshore: though I can provide you with the Zuul raw logs that have the build results [14:00:43] ah for composer there is no progress [14:00:44] but [14:00:53] I have a nice change that is able to fetch multiple repositories together [14:01:06] ensuring they all use the same branch as the proposed patch [14:01:11] and execute whatever command [14:03:49] wonder if composer has the ability to ignore packagist as a repo, and instead point to a totally different package repo [14:04:04] that way wmf could set one up within their control, heh [14:05:18] so what format is the zuul logs in? [14:05:49] fgrep 'complete, result' /var/log/zuul/zuul.log|cut -d\ -f11,16|cut -d\: -f2- [14:05:54]