[00:29:39] 3Wikimedia / 3Continuous integration: Add Jenkins jobs for AutomaticBoardWelcome extension repo - 10https://bugzilla.wikimedia.org/68873#c1 (10Florian) That looks great: https://gerrit.wikimedia.org/r/#/c/152320/ I think this bug report can be closed now? [08:13:51] (03CR) 10Zfilipin: [C: 032] Releasing minor version 0.3.0 [selenium] - 10https://gerrit.wikimedia.org/r/152829 (owner: 10Dduvall) [08:13:54] (03Merged) 10jenkins-bot: Releasing minor version 0.3.0 [selenium] - 10https://gerrit.wikimedia.org/r/152829 (owner: 10Dduvall) [10:20:38] 3Wikimedia / 3Continuous integration: Add Jenkins jobs for AutomaticBoardWelcome extension repo - 10https://bugzilla.wikimedia.org/68873#c2 (10Andre Klapper) (In reply to Florian from comment #1) > That looks great: > https://gerrit.wikimedia.org/r/#/c/152320/ Yes, but not merged yet. > I think this bug re... [10:22:54] 3Wikimedia / 3Continuous integration: Add Jenkins jobs for AutomaticBoardWelcome extension repo - 10https://bugzilla.wikimedia.org/68873#c3 (10Addshore) phplint and unit tests are running now. Not phpcs, this should stay open. [10:53:24] (03PS1) 10Addshore: Make unittests voting for WantedPagesFromNS extension [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/152879 [11:16:23] hello [11:16:36] addshore: and I am back around [11:16:39] hi hashar greetings from London [11:16:42] after a long night at hacker group [11:16:46] ahh [11:16:54] chrismcmahon: train train folks! :-] [11:17:14] hashar: my presentation is tomorrow. there is a picture of you in it :-) [11:17:22] that is cute! [11:17:35] do you need a review? [11:17:57] hashar: thanks, I ran over it with greg-g yesterday, he seemed to like it [11:23:23] chrismcmahon: mind sharing it with me ? :-] [11:24:33] hashar: really basic points: http://prezi.com/1epw63qmgcho/finding-and-fixing-software-bugs-for-the-wikipedias/ [11:25:11] thx! [11:25:46] chrismcmahon: the transitions between "slides" are lovely [11:25:50] hashar: prezi is fun if you've never seen it before [11:26:04] I have seen something like that using SVG / CSS3 animations [11:28:03] chrismcmahon: you probably want to add mukunda and yourself to the team :-D [11:28:25] lovely pres, I guess that will give a good overview to the attendees [11:28:51] hashar: I didn't want to include anyone whose work I did not address directly in the presentation, so Mukunda gets left out. :-) [11:30:56] oh hi hashar ! [11:31:27] chrismcmahon: make sense [11:31:41] addshore: I have 900 Gerrit emails from yesterday mad change :-] [11:31:46] :D [11:31:46] next year ! [11:31:53] hashar: got a few more patches up for you [11:32:04] slowly poking at the extensions :P [11:32:11] awesome [11:32:26] lets see what is pending on integration/* repos ( https://gerrit.wikimedia.org/r/#/q/is:open+project:%255Eintegration.*,n,z ) [11:33:51] (03PS2) 10Hashar: Remove triggers for repos that are empty [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/152762 (owner: 10Addshore) [11:34:05] :> [11:34:16] addshore: that is a lot of empty repositories [11:34:20] yup [11:34:30] I sent Reedy a list of them to see what we wants to do with them [11:34:32] might file a bug too [11:34:37] yeah [11:34:47] maybe dig in the wiki page that list extensions to be created [11:35:00] really we need a system to manage all of these extensions :/ [11:35:15] we could use puppet to manage the Gerrit repos [11:35:28] and puppet to create the jenkins jobs / zuul triggers that goes with it [11:35:45] would be quite cool [11:36:12] some of the extensions there might have been created fairly recently [11:36:48] hashar: would also be cool to configure the tests / voting / non voting / entrypoint files etc in a file in each repo [11:37:10] jenkins cant run tests on 27 extensions as the entry files are different to that that jenkins extepcs [11:37:12] *expects [11:38:32] merging some changes [11:38:50] (03CR) 10Hashar: [C: 032] "Nice cleanup." [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/152762 (owner: 10Addshore) [11:39:37] (03PS2) 10Hashar: Remove jobs for empty repos to be removed [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/152296 (owner: 10Addshore) [11:42:52] [= [11:43:03] (03Merged) 10jenkins-bot: Remove triggers for repos that are empty [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/152762 (owner: 10Addshore) [11:48:08] (03CR) 10Hashar: "Jobs deleted manually." [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/152296 (owner: 10Addshore) [11:48:45] hashar: mwext-{Extension}-phpcs-HEAD can be added to any extensions right? and everything should just work? [11:48:51] (03CR) 10Hashar: [C: 032] Remove jobs for empty repos to be removed [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/152296 (owner: 10Addshore) [11:53:59] (03Merged) 10jenkins-bot: Remove jobs for empty repos to be removed [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/152296 (owner: 10Addshore) [11:55:05] addshore: phpcs is generated for all repositories [11:55:14] addshore: but I think it is not triggered in Zuul by default [11:55:22] that runs PHP CodeSniffer and most repos do not adhere to it [11:55:26] + it is non voting [11:55:29] lovely, will add it for a few things that have bugs for them! [11:55:42] ah yeah there is a few extensions that requested it [11:55:51] Will do them now :) [11:55:53] probably want to have it non voting, but I think that is the default anyway [11:57:30] (03PS2) 10Hashar: Remove jobs for repos that are empty [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/152767 (owner: 10Addshore) [11:58:06] (03CR) 10Hashar: "Rebased, fixed a trivial conflict." [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/152767 (owner: 10Addshore) [11:58:23] yup phpcs is non voting by default [11:58:42] good [11:58:52] ah daughter awake brb [11:59:52] bah [12:02:00] (03PS1) 10Addshore: Add extension-phpcs template [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/152899 [12:06:39] (03PS1) 10Addshore: Use extension-phpcs template [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/152900 [12:10:29] (03CR) 10Hashar: [C: 032] "Jobs are being deleted." [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/152767 (owner: 10Addshore) [12:10:52] addshore: interestingly deleting jenkins jobs cause Zuul to stop triggering jobs :/ [12:11:12] (03PS1) 10Addshore: Add phpcs for 4 Extensions [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/152901 (https://bugzilla.wikimedia.org/68816) [12:11:19] >.> thats annoying :P [12:13:06] (03Merged) 10jenkins-bot: Remove jobs for repos that are empty [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/152767 (owner: 10Addshore) [12:32:53] 3Wikimedia / 3Continuous integration: [upstream] Jenkins ArtifactDeployer plugin v0.31 breaks lazy load causing slow start - 10https://bugzilla.wikimedia.org/69197#c1 (10Antoine "hashar" Musso) Somehow the ArtifactDeployer plugin got upgraded on Aug 7th 20:57 UTC despite it being broken. Manually downgradin... [12:34:24] hashar, Re ^^ you should version control them ;p [12:34:41] addshore: yeah should be done via puppet [12:34:49] but then I will lost ability to apply change / have to wait ops [12:35:07] or literally have a repo with all the plugins in ;p [12:42:54] (03PS2) 10Hashar: Make SimpleSurvey + NSFileRepo ext tests voting! [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/152811 (owner: 10Addshore) [12:43:15] (03CR) 10Hashar: [C: 032] "rebased" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/152811 (owner: 10Addshore) [12:43:23] (03Merged) 10jenkins-bot: Make SimpleSurvey + NSFileRepo ext tests voting! [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/152811 (owner: 10Addshore) [12:49:24] (03PS2) 10Hashar: Make unittests voting for WantedPagesFromNS extension [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/152879 (owner: 10Addshore) [12:50:28] (03CR) 10Hashar: [C: 032] "Change https://gerrit.wikimedia.org/r/#/c/152876/ on master branch got merged." [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/152879 (owner: 10Addshore) [12:50:37] (03Merged) 10jenkins-bot: Make unittests voting for WantedPagesFromNS extension [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/152879 (owner: 10Addshore) [12:52:16] (03PS2) 10Hashar: Add extension-phpcs template [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/152899 (owner: 10Addshore) [12:52:21] =] [12:52:48] (03CR) 10Hashar: [C: 032] "noop. Thanks." [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/152899 (owner: 10Addshore) [12:52:56] (03Merged) 10jenkins-bot: Add extension-phpcs template [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/152899 (owner: 10Addshore) [12:53:37] (03PS2) 10Hashar: Use extension-phpcs template [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/152900 (owner: 10Addshore) [12:57:57] (03CR) 10Hashar: [C: 032] "Good! The differences shown are related to how Zuul order jobs internally, beside that, the change is a noop :-)" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/152900 (owner: 10Addshore) [12:58:04] (03PS2) 10Hashar: Add phpcs for 4 Extensions [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/152901 (https://bugzilla.wikimedia.org/68816) (owner: 10Addshore) [12:58:07] (03Merged) 10jenkins-bot: Use extension-phpcs template [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/152900 (owner: 10Addshore) [12:58:56] (03PS3) 10Hashar: Add phpcs for 4 Extensions (non voting) [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/152901 (https://bugzilla.wikimedia.org/68816) (owner: 10Addshore) [12:59:22] (03CR) 10Hashar: [C: 032] "All good! Amended commit message to mention the jobs are non voting." [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/152901 (https://bugzilla.wikimedia.org/68816) (owner: 10Addshore) [12:59:32] (03Merged) 10jenkins-bot: Add phpcs for 4 Extensions (non voting) [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/152901 (https://bugzilla.wikimedia.org/68816) (owner: 10Addshore) [13:01:42] 3Wikimedia / 3Continuous integration: Add Jenkins jobs for OnlineStatus extension repo - 10https://bugzilla.wikimedia.org/68816#c6 (10Antoine "hashar" Musso) 5PATC>3RESO/FIX a:3Addshore Implemented by Addshore and deployed. The job will be run but will not vote -1 on failure, we will have to later on... [13:01:42] 3Wikimedia / 3Continuous integration: Add Jenkins jobs for JSBreadCrumbs extension repo - 10https://bugzilla.wikimedia.org/68871#c3 (10Antoine "hashar" Musso) 5PATC>3RESO/FIX a:3Addshore Implemented by Addshore and deployed. The job will be run but will not vote -1 on failure, we will have to later on... [13:01:42] 3Wikimedia / 3Continuous integration: Add Jenkins jobs for WhitelistPages extension repo - 10https://bugzilla.wikimedia.org/68858#c3 (10Antoine "hashar" Musso) 5PATC>3RESO/FIX a:3Addshore Implemented by Addshore and deployed. The job will be run but will not vote -1 on failure, we will have to later o... [13:01:43] 3Wikimedia / 3Continuous integration: Add Jenkins jobs for AutomaticBoardWelcome extension repo - 10https://bugzilla.wikimedia.org/68873#c6 (10Antoine "hashar" Musso) 5PATC>3RESO/FIX a:3Addshore Implemented by Addshore and deployed. The job will be run but will not vote -1 on failure, we will have to... [13:04:24] hashar: around? [13:04:52] * zeljkof needs help with https://bugzilla.wikimedia.org/show_bug.cgi?id=68801 [13:05:29] addshore: all changes deployed :-] [13:05:32] :D [13:05:39] wonder what else I can change :P [13:05:45] zeljkof: ah yeah [13:09:00] (03PS1) 10Hashar: Merge cloudbees branch into master [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/152905 [13:09:03] bah [13:09:24] (03PS2) 10Hashar: Merge cloudbees branch into master [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/152905 (https://bugzilla.wikimedia.org/68801) [13:09:28] zeljkof: ^^^ [13:11:23] 3Wikimedia / 3Quality Assurance: Merge master and cloudbees branch of integration/jenkins-job-builder-config repository - 10https://bugzilla.wikimedia.org/68801#c4 (10Antoine "hashar" Musso) Here what I did: git remote update git checkout master git reset --hard gerrit/master git merge --no-ff gerrit/cl... [13:11:30] explanation on bug report :] [13:19:44] hashar: thanks :) [13:26:07] hashar: but wait [13:26:25] I do not see commits from cloudbees branch in master branch [13:27:17] hashar: take a look [13:27:21] https://github.com/wikimedia/integration-jenkins-job-builder-config/commits/cloudbees [13:27:26] https://github.com/wikimedia/integration-jenkins-job-builder-config/commits/master [13:27:54] for example, there were two commits in cloudbees branch on August 7 [13:28:09] but they are not in master branch now [13:28:40] how would they be ? [13:28:54] the merge hasn't happened yet, it is pending review : https://gerrit.wikimedia.org/r/152905 [13:28:55] :D [13:29:00] hashar: I see :) [13:29:13] I thought you have already made the change [13:29:32] so [13:29:35] hoping to work on the afternoon [13:29:38] with kid and wife at home [13:29:41] proven to be a bad idea [13:29:46] hashar: :) [13:29:51] wife sleep [13:29:55] there is no rush [13:30:02] daughter keep having nice trick [13:30:06] it is great we got it moving [13:30:16] zeljkof: the merge change above should be fine. git review it and look at the git log produced [13:30:31] you will see the commits from cloudbees branch landing in master nicely [13:30:43] hashar: I will test xml output too [13:33:00] ok off for some food / milk / park etc [13:33:09] I guess I will work tonight and probably tomorrow [13:34:51] addshore: I am off for the rest of the afternoon. if you send patches, I will have a look at them tonight [13:34:57] okay :) [13:37:58] (03CR) 10Zfilipin: "Not sure what is going on here:" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/152905 (https://bugzilla.wikimedia.org/68801) (owner: 10Hashar) [13:42:26] hashar: welcome back :) [13:44:10] 3Wikimedia / 3Quality Assurance: rubocop should run after patch set submission to every repo that has Ruby code - 10https://bugzilla.wikimedia.org/69245 (10Željko Filipin) 5NEW>3ASSI a:3Željko Filipin [13:47:24] zeljkof: wife woke up :] [13:49:03] hashar: I will also probably need help with this https://bugzilla.wikimedia.org/show_bug.cgi?id=69245 [13:54:57] 3Wikimedia / 3Quality Assurance: rubocop should run after patch set submission to every repo that has Ruby code - 10https://bugzilla.wikimedia.org/69245#c1 (10Antoine "hashar" Musso) We need a way to install rubocop. We can probably have it run on labs instance and use gem to install it on job run. We found... [13:55:46] zeljkof: shah I was replying on it :-D [13:56:07] zeljkof: we could reuse the lame gem hack to avoid reinstalling from gem again and again [13:56:07] or [13:56:14] more elegant: have rubocop packaged for Debian [13:57:01] hashar: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=745423 [13:57:47] hashar: strange bug tracker, I am not sure what it says about rubocop for debian [13:58:25] zeljkof: debian uses a mail based bug tracker [13:58:34] hashar: nice :P [13:58:38] that bugs says that someone intend to package it [13:58:40] (ITP) [13:58:50] and he is french :] [13:59:00] maybe there is some repository somewhere that propose a package [13:59:42] you can email 745423@bugs.debian.org to query about it [13:59:56] you can even download the mailbox : https://bugs.debian.org/cgi-bin/bugreport.cgi?msg=5;mbox=yes;bug=745423 :D [15:03:20] (03PS1) 10Zfilipin: WIP Added builder that runs rubocop, Ruby linter [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/152918 (https://bugzilla.wikimedia.org/69245) [15:04:44] hashar: is this the way to go? ^ [15:05:36] to go ? [15:05:36] no [15:05:45] you need to close your laptop then walk! :_D [15:06:15] zeljkof: that would probably work [15:06:28] hashar: :) [15:06:50] hashar: I am adding it to the template in zuul-config [15:07:11] hashar: and then "just" to figure out how to install rubocop [15:07:15] zeljkof: well there is no rubocop yet! [15:07:32] contact ops maybe to find out how easy/hard it is going to package [15:07:37] rt.wikimedia.org is your friend :] [15:11:05] hashar: will do [15:11:44] hashar: I have never used rt [15:11:53] do I login with my gerrit credentials? [15:12:09] well, no [15:14:09] ah [15:14:40] (03PS2) 10Zfilipin: WIP Added job template and builder that runs rubocop, Ruby linter [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/152918 (https://bugzilla.wikimedia.org/69245) [15:38:31] (03PS1) 10Zfilipin: WIP Run rubocop, Ruby linter, for all repositories that have Ruby code [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/152926 (https://bugzilla.wikimedia.org/69245) [15:38:44] (03PS2) 10Zfilipin: WIP Run rubocop, Ruby linter, for all repositories that have Ruby code [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/152926 (https://bugzilla.wikimedia.org/69245) [15:39:30] (03PS3) 10Zfilipin: WIP Run rubocop, Ruby linter, for all repositories that have Ruby code [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/152926 (https://bugzilla.wikimedia.org/69245) [15:39:57] (03PS3) 10Zfilipin: WIP Added job template and builder that runs rubocop, Ruby linter [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/152918 (https://bugzilla.wikimedia.org/69245) [15:40:37] hashar: ^ [15:41:03] sending mail to ops, I think there is nothing else left to do on my side, right? [15:41:09] tip for next time: you can reuse the same Change-Id: on all changes :] [15:41:16] zeljkof: yeah might be fine [15:41:23] zeljkof: CC me on the request amusso@wikimedia.org [15:41:29] we can poke ops next week about it [15:41:32] hashar: will do [15:41:55] (03PS4) 10Zfilipin: WIP Added job template and builder that runs rubocop, Ruby linter [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/152918 (https://bugzilla.wikimedia.org/69245) [15:42:00] that will take a few days though [15:42:01] (03PS4) 10Zfilipin: WIP Run rubocop, Ruby linter, for all repositories that have Ruby code [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/152926 (https://bugzilla.wikimedia.org/69245) [15:45:28] hashar: there is no rush [15:45:35] how to I make the job non voting for now? [15:47:33] hashar: sent a short mail, added you, chrismcmahon and Dan to cc [15:56:33] and I guess I am moving out [17:38:13] (03PS1) 10Addshore: Remove triggers for 'normal' [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/152937 [17:38:58] (03PS1) 10Addshore: Remove 'normal' from list of extensions [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/152938 [19:55:02] (03PS1) 10Hashar: Trigger pywikibot-core-tox-nose [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/152961 [19:56:22] (03CR) 10Hashar: [C: 04-2] "Pending https://gerrit.wikimedia.org/r/#/c/152959/" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/152961 (owner: 10Hashar) [20:05:58] (03CR) 10John Vandenberg: "This should also be dependent on I712a196bfefd8ec0aa2398d87a983b82f1ed4a8f , otherwise the http/weblib tests will run. the http tests are" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/152961 (owner: 10Hashar) [20:47:36] (03CR) 10John Vandenberg: "ok, it looks like the weblib webcitation test is passing, but they still could fail, which would be annoying for gerrit patch uploaders." [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/152961 (owner: 10Hashar) [20:49:45] (03PS1) 10Addshore: Make 4 more extensions jobs voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/152972 [23:49:23] 3Wikimedia / 3Continuous integration: Userrights API broken - 10https://bugzilla.wikimedia.org/69305#c6 (10Jon) 5RESO/INV>3REOP Okay so that was a red herring. It seems to be a bug with the mediawiki ruby api. on(APIPage).client.query('userrights', token_type: false, token: @token, add: "bot", user: @u... [23:49:38] 3Wikimedia / 3Continuous integration: Userrights API broken - 10https://bugzilla.wikimedia.org/69305#c7 (10Jon) adding Dan.. not sure what right component is for https://git.wikimedia.org/blob/mediawiki%2Fruby%2Fapi/8632e89c7a2b632ea6739989700358157c60031b/lib%2Fmediawiki_api%2Fclient.rb