[07:27:51] (03PS2) 10Zfilipin: Chrome 28 is the last version that works properly on Sauce Labs [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/153408 (https://bugzilla.wikimedia.org/69399) [07:45:51] good morning [08:13:08] (03CR) 10Zfilipin: [C: 032] Chrome 28 is the last version that works properly on Sauce Labs [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/153408 (https://bugzilla.wikimedia.org/69399) (owner: 10Zfilipin) [08:13:41] (03Merged) 10jenkins-bot: Chrome 28 is the last version that works properly on Sauce Labs [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/153408 (https://bugzilla.wikimedia.org/69399) (owner: 10Zfilipin) [10:05:08] 3Wikimedia / 3Continuous integration: Add jenkins jobs for mediawiki/skins/CologneBlue , Nostalgia, Modern, Example, MonoBook, Vector - 10https://bugzilla.wikimedia.org/66926#c18 (10Bartosz Dziewoński) 5PATC>3NEW Thanks guys. Can/Should this be closed now? It seems that all skin repos that have somethin... [11:23:24] 3Wikimedia / 3Continuous integration: Add jenkins jobs for mediawiki/skins/CologneBlue, Nostalgia, Modern, Example, MonoBook, Vector - 10https://bugzilla.wikimedia.org/66926#c19 (10Antoine "hashar" Musso) The skins must now have a bunch of MediaWiki core tests run on them, just like extensions. Ie the tests... [13:36:21] hello zeljkof [13:36:31] vikasyaligar: hi [13:36:59] (03PS8) 10Phuedx: WIP Enable browser tests for the GettingStarted extension [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/150172 (https://bugzilla.wikimedia.org/52246) [13:37:11] (03CR) 10Phuedx: WIP Enable browser tests for the GettingStarted extension (032 comments) [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/150172 (https://bugzilla.wikimedia.org/52246) (owner: 10Phuedx) [13:37:29] zeljkof: any idea why this(https://gerrit.wikimedia.org/r/#/c/151419/) did not get merged ? [13:38:23] vikasyaligar: qunit test failed, but I am not sure why [13:38:34] vikasyaligar: at the bottom of this page [13:38:34] https://gerrit.wikimedia.org/r/#/c/151419/ [13:38:39] https://integration.wikimedia.org/ci/job/mwext-VisualEditor-qunit/11037/console : FAILURE in 1m 28s [13:38:41] click the link [13:38:56] 00:01:28.407 Aborted due to warnings. [13:39:08] will try merging now [13:39:23] zeljkof: yup ! saw it ! Ok :) [13:41:29] vikasyaligar: it passed now [13:41:32] :) [13:42:09] not sure if I have to do something to get it merged, let's wait a minute to see if it gets merged automatically [13:42:15] zeljkof: yay ! [13:51:14] anybody knows what needs to happen so this commit gets merged? https://gerrit.wikimedia.org/r/#/c/151419/ [13:51:25] jenkins jobs are passing, it has two +2s [13:51:33] but still the status is "ready to submit" [13:56:53] 3Wikimedia / 3Quality Assurance: create API level tests to monitor services on beta/test2wiki and also on production (tracking) - 10https://bugzilla.wikimedia.org/58353#c11 (10Željko Filipin) Yes, looks like I was thinking of bug 58555. Anyway, this tracking bug does not track any other bugs, so I vote to r... [14:00:34] :( [14:01:01] greg-g, twentyafterfour: if you can halp... pls... :) [14:01:15] (see my question ^^) [14:01:26] good morning chrismcmahon :) [14:02:34] hi zeljkof [14:03:09] chrismcmahon: any help on getting this merged is appreciated :) https://gerrit.wikimedia.org/r/#/c/151419/ [14:03:10] zeljkof: was there a question for me? [14:03:36] chrismcmahon: not for you in particular, but vikasyaligar and me are not sure why the above commit refuses to merge [14:03:43] can you +2 it? [14:03:47] I already did [14:05:34] hashar is not around I guess [14:05:39] 3Wikimedia / 3Quality Assurance: Use dotenv ruby gem for configuration management - 10https://bugzilla.wikimedia.org/69405#c2 (10Željko Filipin) If we commit the .env file, we can get rid of some ugly hacks that we have at the moment. For example, the entire url_module.rb in mediawiki/selenium[1] and MobileF... [14:06:06] chrismcmahon: speaking of devil... :) [14:06:17] zeljkof: zuul says it's starting gate-and-submit now, maybe it worked when I +2'd it [14:06:38] chrismcmahon: great [14:06:43] not sure what went wrong [14:06:56] hashar: do you know why this did not get merged? https://gerrit.wikimedia.org/r/#/c/151419/ [14:08:16] zeljkof: looking [14:08:22] hashar: thanks [14:08:29] zeljkof: it is merged [14:08:37] zeljkof: It got merged ! yay! [14:08:38] it got merged now, that chris has +2d it [14:08:41] jenkins-bot 16:06 [14:08:41] Change has been successfully merged into the git repository. [14:08:50] but it refused to get merged after I +2d it [14:09:05] PS9 was rejected because the qunit job had a failure [14:09:10] there was a qunit job failing yesterday, so jenkins refused to merge it [14:09:11] right [14:09:12] Gate pipeline build failed. [14:09:13] https://integration.wikimedia.org/ci/job/mwext-VisualEditor-qunit/11033/console : FAILURE in 1m 32s [14:09:15] but today the job passed [14:09:29] and the commit still did not want to get merged [14:10:01] maybe an issue within core? [14:10:04] or a transientfailure [14:10:22] the VE team might now :-] [14:10:55] hashar: the question is, why did the commit fail to merge, once qunit job was passing? [14:11:08] at which patchset? [14:11:34] PS9 failed the build [14:11:34] 10 and 11 [14:11:42] but 10 and 11 passed, right? [14:11:44] all others are 'recheck' which are just running the tests and will not submit [14:11:52] hashar: I see [14:12:00] but what was I supposed to do? [14:12:00] you need a CR+2 to have the change enter the gate [14:12:08] hashar: I did that [14:12:12] revote +2, potentially by removing your +2 vote :] [14:12:19] I see [14:12:22] that is what I did not do [14:12:28] I just did +2 again [14:12:33] and it did not do anything [14:12:33] or Gerrit does not register a +2 :-] [14:12:49] so I should change +2 to anything else, and then back to +2? [14:12:52] will try to remember [14:12:56] we can probably make it so recheck push the change to gate-and-submit if the change already has +2 [14:13:06] will need to look at Zuul configuration a bit [14:13:07] hashar: that was what I was expecting [14:13:15] it is doable for sure :] [14:13:17] but this happens rarely [14:13:21] so there is no rush [14:13:22] openstack does it [14:17:38] 3Wikimedia / 3Quality Assurance: Cucumber step should fail if pending RSpec expectation no longer fails - 10https://bugzilla.wikimedia.org/56243#c10 (10Željko Filipin) I think just my Ruby-fu is failing me. See comments 6 and 7. RSpec::Pending already does what I want, but looks like I am calling Cucumber::P... [14:22:01] hashar, chrismcmahon: since both of you are here, I have a general question [14:22:53] is translating visual editor strings from english to croatian (so we can run language screenshot script for croatian too) something that I can do on wmf time, or should I do it on my own time? [14:23:26] I get slightly confused sometimes on which things are considered harmful [14:24:47] vikas_dinner: did you see how much time the screenshots job runs now? :) https://integration.wikimedia.org/ci/view/BrowserTests/job/browsertests-VisualEditor-language-screenshot-linux-firefox-sauce/buildTimeTrend [14:30:48] (03PS8) 10Zfilipin: The first PdfHandler job [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/152246 [14:31:00] zeljkof: I would let the community handle the translation via translatewiki.net [14:31:14] zeljkof: my answer is not conclusive, but I would think that you could translate on WMF time in support of a software project you're working on. I certainly have no objection to it. [14:31:23] zeljkof: your time is probably best spent on getting us moaaar browser tests hehe :] [14:31:49] hashar: in order to run browser tests in croatian, I have to translate ve to croatian :) [14:31:58] zeljkof: but what hashar said, it would probably be best to do the translation working with the Language team [14:32:16] a good thing would be to highlight the browser screenshot project on the croatian wiki, gives detailed instructions about how to do the translations (I guess Translatewiki.net) and scale the translation to the community :] [14:32:23] because it makes no sense to take screenshots of croatian interface that is half in english [14:32:37] oh at least you know it is half good hehe [14:32:56] hashar: or just do it on my own time :) [14:34:12] :-D [14:34:36] zeljkof: hashar makes a good point: it would be worth knowing how to escalate a translation project within the language-translating community. I don't know how to do that, but Amir or Siebrand or someone would. [14:34:54] dont forget nikerabbit [14:35:07] chrismcmahon, hashar: sure, but I do not care about translations in general, just about this one :) [14:35:12] I think translatewiki maintains some top 10 translators per language [14:35:18] would be nice to reach to them [14:35:19] so I do not really want to get involved in all that jazz [14:35:24] you would get everything translated in a breeze [14:36:01] (03CR) 10Zfilipin: "Anybody knows how to get [1] in wmf/1.24wmf16 (or wmf/1.24wmf17...)? That is causing the jenkins job to fail." [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/152246 (owner: 10Zfilipin) [14:37:25] and I guess it would be nice to have the project fully translated in all languages to provide screenshots for the communities [14:37:39] so yeah large scale translation involving the community would be best [14:37:42] that would be time well spent [14:37:59] hashar: but I have no interest in organising it :) [14:38:19] I guess I will just do the translations after work [14:41:40] zeljkof: well vikas might be able to bootstrap the process :] [14:43:22] pff [14:43:36] for sale: 3y old kid [14:48:04] chrismcmahon: what do you mean by "escalate a translation project"? [14:50:30] Nemo_bis: If I want to say "It is really important that we translate these VisualEditor messages into Croatian as soon as possible", who would I say that to in the translation community? I don't know the answer to that question. [14:51:22] So by "escalate" you meant "prioritise"? [14:51:42] You can visit special:supportedlanguages, on the wikis where Tim didn't disable itù [14:53:04] zeljkof: ^^ [14:53:32] chrismcmahon: yeah, I have no plans to try to organise that :) [14:53:46] I will just do the translations that I care about myself after work [14:54:01] but thanks [15:04:29] zeljkof: yup ! it is still running. this patch => https://gerrit.wikimedia.org/r/#/c/153594/ should decrease it :) [15:05:20] vikas: the patch is ready? should I merge it? [15:05:32] it looks good to me [15:05:41] zeljkof: yup ! you can merge it now :) [15:06:55] vikas: +2d [15:07:03] zeljkof: thank you :) [15:10:32] zeljkof: still need my halp? [15:15:14] zeljkof: did you start the job again ? [15:21:30] (03PS4) 10Vikassy: WIP: Added language exception tag to language screenshot job [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/153569 [15:21:44] (03PS4) 10Vikassy: WIP: Updated MEDIAWIKI_API_UPLOAD_URL for language screenshot job to production commons(http://commons.wikimedia.org) [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/147415 [15:23:06] zeljkof: can I abort the current execution, as I want to see=> how much time it takes now ? [15:23:16] *execution of job [15:23:26] vikas: leave it for now [15:23:36] I do not understand what you want to do [15:24:45] zeljkof: ok :) Just wanted to see how much time it takes after this(https://gerrit.wikimedia.org/r/#/c/153594/) is merged [15:25:06] vikas: you can start a new job now [15:25:15] and it will run after this one is finished [15:25:18] and you will know tomorrow :) [15:25:21] is that ok? [15:28:32] zeljkof: by new job => you meant build the current job again ? [15:28:39] yes [15:28:46] ok ! doing it now [15:34:07] zeljkof: hey, did you figure out the merge thing? [15:34:39] greg-g: yes, thanks [15:34:45] good deal [15:34:57] nothing that another +2 did not fix :) [15:35:07] but it was confusing [15:35:38] weird [15:39:57] hey greg-g [15:40:01] g'morning [15:40:24] sorry i have missed the checkin yesterday [15:41:46] no worries, it happens, we'll catch up in 20 minutes :) [15:41:52] you missed a slightly loopy Greg :) [15:47:04] ah 1/1 [15:47:09] was about to miss that one as well hehe [16:24:28] 3Wikimedia / 3Continuous integration: enable tab voting on DNS repo - 10https://bugzilla.wikimedia.org/69478 (10Daniel Zahn) 3NEW p:3Unprio s:3normal a:3None Dear hashar, recently you enabled tab voting in jenkins on the operations/puppet repo after we removed the last litereal tab chars. Could yo... [17:50:41] 3Wikimedia / 3Quality Assurance: Use dotenv ruby gem for configuration management - 10https://bugzilla.wikimedia.org/69405#c3 (10Dan Duvall) We can get rid of those hacks (and we should!) regardless of our use of an `.env` file. As I understand it, this is more about simplifying setup outside of something l... [17:57:11] 3Wikimedia / 3Quality Assurance: Cucumber step should fail if pending RSpec expectation no longer fails - 10https://bugzilla.wikimedia.org/56243#c11 (10Dan Duvall) I'm not sure that cucumber even uses `rspec-core`. It might just use the matchers. Either way, I think implementing our own helper is more inline... [19:00:03] chrismcmahon: if a test needs to access the browser string, should I use @browser or $browser or browser_name ? ENV["BROWSER"] fails if you're defaulting to Firefox [19:00:31] spagewmf: one sec, I have an example... [19:02:34] spagewmf, chrismcmahon: @browser.name gives you a symbol (e.g. :chrome) [19:02:47] spagewmf: first 'Given' clause here https://github.com/wikimedia/mediawiki-extensions-VisualEditor/blob/master/modules/ve-mw/tests/browser/features/step_definitions/shared_steps.rb e.g. http://en.wikipedia.beta.wmflabs.org/wiki/Edit_page_for_firefox [19:04:13] spagewmf: marxarelli is right, I didn't read closely [19:04:41] a symbol might be what you want. depends on what you're trying to do [19:05:34] chrismcmahon , marxarelli : we're creating a session user name with `return ENV["MEDIAWIKI_USER"] + "_" + ENV["BROWSER"]`. So a leading ':' would cause problems [19:06:48] spagewmf: symbols play nicely with string interpolation (as does anything that implements #to_s) [19:07:13] spagewmf: so you can do "#{ENV["MEDIAWIKI_USER"]}_#{@browser.name}" [19:07:30] spagewmf: marxarelli "ENV['BROWSER'] = firefox unless ENV['BROWSER']" would set that if it is empty [19:07:35] i.e. :chrome.to_s == "chrome" [19:07:56] chrismcmahon: yeah, but i would avoid mutating global state [19:08:19] anything in ENV is global and shouldn't be changed in steps [19:08:36] seems reasonable in this case, but I'm easy [19:08:37] marxarelli: thanks. Who are you? :) [19:08:48] spagewmf: Batman [19:08:59] spagewmf: Dan Duvall :) [19:09:24] jeez spagewmf marxarelli is our new(ish) Automation Engineer, he knows way more about Ruby than I do [19:11:13] though i'm still learning a lot about selenium/watir/page-object [19:11:39] "WMF marxarelli" comes up empty, Dan Duvall has no user page on https://wikimediafoundation.org/w/index.php?title=Staff_and_contractors&showall=1 ... talk about low profile [19:12:28] spagewmf: i'm on there! [19:12:47] spagewmf: oh, Daniel Duvall [19:13:20] OK, teach a man to fish time: how can I try this myself? In irb, `require 'mediawiki-selenium'` fails, so I can't even get started fiddling around with calls. And require pry-byebug foo is a pain [19:14:16] marxarelli: I mean Daniel Duvall isn't a link, unlike everyone else in Release Engineering bar Rummana [19:14:54] ryasmeen and marxarelli : https://office.wikimedia.org/wiki/Getting_Started_With_User_Info_and_Talk_Pages [19:19:45] spagewmf: looks like some of the global cucumber hooks in mediawiki_selenium make it unfriendly to irb (or inclusion outside the context of cucumber). i'd recommend pry for now [19:20:56] I should have typed `require 'mediawiki_selenium'` but yeah still fails NoMethodError: undefined method `World' for main:Object [19:21:04] exactly [19:22:06] usually the best way to load up a irb session for projects managed by bundler (Gemfile) is irb -rbundler/setup [19:22:14] then irb> Bundler.require [19:57:42] 3Wikimedia / 3Continuous integration: Echo browser tests Jenkins job - 10https://bugzilla.wikimedia.org/69130#c1 (10Jon) How can I make this happen? :) Code was merged... [20:13:27] 3Wikimedia / 3Quality Assurance: Create Jenkins job for Echo browser tests - 10https://bugzilla.wikimedia.org/69130#c2 (10Chris McMahon) I'll do this with Zeljko this week [21:22:32] jgonera: https://gerrit.wikimedia.org/r/#/c/152993/ [21:23:35] James_F: got a minute for a Cite UI question? right now, regardless of what you're citing (Website, Book, etc.) the inputs are generic textareas, with no unique ids, names, classes, etc. Do you know if Cite inspector will continue like that? or will those textareas be designated more specifically later on? [21:24:51] jgonera: https://gerrit.wikimedia.org/r/#/c/151802/ [23:51:04] (03PS4) 10Addshore: Enable phplint job for labs-toollabs [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/153581 (https://bugzilla.wikimedia.org/63687) [23:51:22] (03CR) 10Addshore: "Switched this change to just phplint for now" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/153581 (https://bugzilla.wikimedia.org/63687) (owner: 10Addshore) [23:53:58] (03PS3) 10Addshore: make mw-core-phpcs-lenient-HEAD voting on master! [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/153575 (https://bugzilla.wikimedia.org/46500)