[02:31:58] 3Wikimedia / 3Quality Assurance: Run phantomjs across set of Wikimedia wiki pages to ensure sane JavaScript - 10https://bugzilla.wikimedia.org/69519 (10MZMcBride) 3NEW p:3Unprio s:3normal a:3None From bug 69445 comment 13: --- However it would be great to have automated tests running after changes i... [02:35:56] 3Wikimedia / 3Quality Assurance: Run PhantomJS across set of Wikimedia wiki pages to ensure sane JavaScript - 10https://bugzilla.wikimedia.org/69519#c1 (10MZMcBride) The idea here is to use a tool such as PhantomJS (a headless WebKit browser) to hit a bunch of pre-defined URLs and report JavaScript errors.... [02:38:11] 3Wikimedia / 3Quality Assurance: Run PhantomJS across set of Wikimedia wiki pages to ensure sane JavaScript - 10https://bugzilla.wikimedia.org/69519#c2 (10Kunal Mehta (Legoktm)) checks for any JS errors being thrown on the main page (as an anonymous user)... [02:43:41] 3Wikimedia / 3Quality Assurance: Run PhantomJS across set of Wikimedia wiki pages to ensure sane JavaScript - 10https://bugzilla.wikimedia.org/69519#c3 (10Helder) (In reply to MZMcBride from comment #0) > ... > testing als > ERROR: ReferenceError: Can't find variable: ta > TRACE: > -> > https://als.wikipedi... [03:58:26] 3Wikimedia / 3Quality Assurance: Run PhantomJS across set of Wikimedia wiki pages to ensure sane JavaScript - 10https://bugzilla.wikimedia.org/69519#c4 (10Eran Roz) here is my version used for error checking: https://github.com/eranroz/wiki-js-error-log/blob/master/testwiki.js [11:12:03] (03PS5) 10Zfilipin: WIP Moved the first Wikidata job from WMDE Jenkins [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/147093 [11:19:34] hello zeljkof [11:19:58] vikasyaligar: hi [11:30:10] vikasyaligar: coming to the hangout in a minute [11:30:17] zeljkof: ok ! :) [11:36:00] zeljkof: https://integration.wikimedia.org/ci/view/BrowserTests/job/browsertests-VisualEditor-language-screenshot-linux-firefox-sauce/LANGUAGE_SCREENSHOT_CODE=ast,label=contintLabsSlave%20&&%20UbuntuPrecise/90/consoleFull [12:04:50] (03CR) 10Hashar: [C: 032] "deploying" [integration/jenkins] - 10https://gerrit.wikimedia.org/r/151876 (owner: 10Hashar) [12:04:53] (03Merged) 10jenkins-bot: mwconf: let us override magic extension loader [integration/jenkins] - 10https://gerrit.wikimedia.org/r/151876 (owner: 10Hashar) [12:07:30] more tofu's in kn => https://integration.wikimedia.org/ci/view/BrowserTests/job/browsertests-VisualEditor-language-screenshot-linux-firefox-sauce/LANGUAGE_SCREENSHOT_CODE=kn,label=contintLabsSlave%20&&%20UbuntuPrecise/ws/log/VisualEditor_Insert_Menu-kn.png [12:07:42] zeljkof: ^ [12:09:16] zeljkof: [12:09:16] Anybody knows how to get [1] in wmf/1.24wmf16 (or wmf/1.24wmf17...)? That is causing the jenkins job to fail. [12:09:16] 1: https://gerrit.wikimedia.org/r/#/c/143175/ [12:09:21] just have to cherry pick the change to the branch [12:09:27] can be done from Gerrit directly [12:09:41] vikasyaligar: https://play.google.com/store/apps/details?id=net.translatewiki.app&hl=en [12:10:04] hashar: thanks [12:10:30] (03CR) 10Hashar: "Zeljkof: use the Gerrit cherry-pick button to propose the patch on both wmf branches. Will need someone to review / approve / deploy the " [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/152246 (owner: 10Zfilipin) [12:10:45] zeljkof: I am not sure how to deploy such proposals though. You will want to poke Reedy [12:17:26] 3Wikimedia / 3Quality Assurance: Run PhantomJS across set of Wikimedia wiki pages to ensure sane JavaScript - 10https://bugzilla.wikimedia.org/69519#c5 (10Antoine "hashar" Musso) Seems we have two versions :-]  If you guys could unify the effort and have the resulting code hosted in Gerrit, I would be more t... [12:17:52] (03PS5) 10Zfilipin: WIP: Updated MEDIAWIKI_API_UPLOAD_URL for language screenshot job to production Commons [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/147415 (owner: 10Vikassy) [12:20:19] zeljkof: aharoni: one more problem: http://commons.wikimedia.beta.wmflabs.org/wiki/File:VisualEditor_Toolbar_SpecialCharacters-en.png [12:20:22] hashar: we do not need to deploy the commit to test2, we just need the commit in the branch [12:20:38] zeljkof: yeah still have to be deployed [12:20:47] whenever a change is merged in a wmf branch, we need to deploy it [12:20:54] though for this change, I guess we just need to pull [12:21:06] hashar: ok, but I do not care when it will be deployed [12:21:16] though that extension might have a production hack and I dont know how to do it [12:30:34] (03PS1) 10Vikassy: Language screenshot job should run on english beta labs [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/154042 [12:31:46] (03CR) 10Hashar: [C: 04-1] "You need to define the ruby lint job in Jenkins job builder configuration (master branch). It is done in mediawiki-extensions.yaml using " [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/152795 (https://bugzilla.wikimedia.org/52246) (owner: 10Zfilipin) [12:32:35] (03CR) 10Zfilipin: [C: 032] Language screenshot job should run on english beta labs [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/154042 (owner: 10Vikassy) [12:33:04] (03Merged) 10jenkins-bot: Language screenshot job should run on english beta labs [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/154042 (owner: 10Vikassy) [12:39:15] aharoni: https://gerrit.wikimedia.org/r/#/c/154042/ [12:39:46] aharoni: https://gerrit.wikimedia.org/r/#/c/147415/ [12:39:57] (03PS6) 10Zfilipin: Updated MEDIAWIKI_API_UPLOAD_URL for language screenshot job to production Commons [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/147415 (owner: 10Vikassy) [12:40:02] (03PS7) 10Zfilipin: Updated MEDIAWIKI_API_UPLOAD_URL for language screenshot job to production Commons [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/147415 (owner: 10Vikassy) [12:42:12] (03CR) 10Zfilipin: Updated MEDIAWIKI_API_UPLOAD_URL for language screenshot job to production Commons (031 comment) [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/147415 (owner: 10Vikassy) [12:42:24] (03CR) 10Zfilipin: [C: 031] Updated MEDIAWIKI_API_UPLOAD_URL for language screenshot job to production Commons [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/147415 (owner: 10Vikassy) [12:42:42] (03CR) 10Amire80: [C: 032] "\o/" [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/147415 (owner: 10Vikassy) [12:43:08] (03Merged) 10jenkins-bot: Updated MEDIAWIKI_API_UPLOAD_URL for language screenshot job to production Commons [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/147415 (owner: 10Vikassy) [12:43:48] (03CR) 10Hashar: [C: 04-1] Enable phplint job for labs-toollabs (031 comment) [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/153581 (https://bugzilla.wikimedia.org/63687) (owner: 10Addshore) [12:44:26] (03PS5) 10Hashar: Enable phplint job for labs-toollabs [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/153581 (https://bugzilla.wikimedia.org/63687) (owner: 10Addshore) [12:45:23] (03CR) 10Hashar: [C: 032] "PS5: added phplint to gate-and-submit." [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/153581 (https://bugzilla.wikimedia.org/63687) (owner: 10Addshore) [12:45:31] (03Merged) 10jenkins-bot: Enable phplint job for labs-toollabs [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/153581 (https://bugzilla.wikimedia.org/63687) (owner: 10Addshore) [12:53:25] (03PS1) 10Zfilipin: Removed languages that fonts are missing [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/154049 [12:57:19] (03PS2) 10Amire80: Removed languages for which fonts are missing [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/154049 (https://bugzilla.wikimedia.org/69535) (owner: 10Zfilipin) [12:58:04] (03CR) 10Amire80: [C: 032] Removed languages for which fonts are missing [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/154049 (https://bugzilla.wikimedia.org/69535) (owner: 10Zfilipin) [12:58:47] (03Merged) 10jenkins-bot: Removed languages for which fonts are missing [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/154049 (https://bugzilla.wikimedia.org/69535) (owner: 10Zfilipin) [13:18:56] 3Wikimedia / 3Quality Assurance: Fonts for Japanese and Chinese must be installed for VisualEditor localized screenshots - 10https://bugzilla.wikimedia.org/69535#c1 (10Antoine "hashar" Musso) Moving to Wikimedia -> Quality. Will have to figure out the font packages to install. Maybe we could reuse the one... [13:19:03] (03PS1) 10Zfilipin: WIP Running language screenshot job using local Firefox [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/154052 [13:55:55] (03Draft1) 10Addshore: Update to php codesniffer 1.4.8 [integration/phpcs] - 10https://gerrit.wikimedia.org/r/154053 [14:41:56] (03PS1) 10Jeroen De Dauw: Do not +2 on verified based just on linting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/154058 [15:11:15] (03CR) 10Addshore: "Im fairly sure this will still +2 after linting." [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/154058 (owner: 10Jeroen De Dauw) [15:29:23] (03CR) 10Hashar: [C: 031] "The check-only pipeline votes verified +1 / -1 . Since repositories usually requires Verified +2 for a change to be submitted by Gerrit, " [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/154058 (owner: 10Jeroen De Dauw) [15:36:13] (03PS1) 10Cmcmahon: create browser test builds for Echo extension [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/154070 [17:53:57] greg-g: besides looking at "actual hours" try surfing for "ideal days" [17:55:52] 3Wikimedia / 3Continuous integration: enable tab voting on DNS repo - 10https://bugzilla.wikimedia.org/69478 (10Sam Reed (reedy)) s:5normal>3enhanc [17:56:08] 3Wikimedia / 3Quality Assurance: Run PhantomJS across set of Wikimedia wiki pages to ensure sane JavaScript - 10https://bugzilla.wikimedia.org/69519 (10Sam Reed (reedy)) s:5normal>3enhanc [18:03:11] chrismcmahon: cool [18:20:29] (03CR) 10Hoo man: [C: 04-1] "This would force us to submit per hand... can't we stick with the current workflow unless we can switch back to WMF's jenkins?" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/154058 (owner: 10Jeroen De Dauw) [18:36:51] chrismcmahon: re metrics and CAST, this is it, I assume? http://cast2014.sched.org/event/d8962c7d110711f3825fd21ecb332e94 [18:37:09] now we just have to wait for them to get their videos on youtube [18:44:45] greg-g: toward the bottom of Michael Larsen's live blog also: http://www.mkltesthead.com/ [18:53:52] chrismcmahon: there are a few tests in mobilefrontend that require multiple languages for a given page to exist [18:54:08] chrismcmahon: would this require multiple wikis to be setup? [18:54:52] chrismcmahon: i'm a bit confused on how language links work... [19:02:06] marxarelli: not sure, which test is it? [19:03:06] http://git.wikimedia.org/blob/mediawiki%2Fextensions%2FMobileFrontend.git/2fe647c6f3934dc44c8617853c85774e124db840/tests%2Fbrowser%2Ffeatures%2Feditor_wikitext_saving.feature#L20 [19:10:04] marxarelli: man, those need refactoring, I'm reading... [19:10:16] they should really be using the API [19:10:46] chrismcmahon: sure, but how do i create pages in other languages via the api? [19:11:00] marxarelli: I'm not sure :-) [19:11:30] marxarelli: I think I knew this once, but it's been a while since I've worked with language pages, checking... [19:12:17] chrismcmahon: no problem. i've been trying to read more on it but it's hard to know where to start :) [19:15:13] marxarelli: actually, we're good, check out line 65 here: http://git.wikimedia.org/blob/mediawiki%2Fextensions%2FMobileFrontend.git/2fe647c6f3934dc44c8617853c85774e124db840/tests%2Fbrowser%2Ffeatures%2Fstep_definitions%2Fcreate_page_api_steps.rb [19:15:45] chrismcmahon: that doesn't work in the mw-vagrant environment though [19:15:51] chrismcmahon: and i'm trying to figure out why [19:16:15] marxarelli: oic. yeah, there is some trick to get that link to show up [19:17:33] marxarelli: because that link actually points to a different node on the cluster, eswiki as opposed to enwiki. [19:22:29] marxarelli: this might be the clue: http://www.mediawiki.org/wiki/Manual:Guide_to_setting_up_interwiki_linking#Language_links [19:23:43] chrismcmahon: hmm... ok. i guess there are two problems then: 1) how to best provision a second language wiki in vagrant; and 2) how to best abstract access to a second wiki in tests [19:24:00] marxarelli: suggests that if an entry exists in Names.php, then such a link would show up even if no other wiki exists? [19:25:07] marxarelli: this is something that Reedy or hashar might know: put "es" in Names.php and I bet you'd get the right behavior, but I'm not certain of that. [19:25:53] chrismcmahon: awesome. i'll try it out. thanks! [19:38:04] chrismcmahon: i think the interwiki extension needs to be enabled and there needs to be a record in the interwiki table for 'es' for that test to work [19:38:16] chrismcmahon: i'll try it and let you know [19:39:53] marxarelli: that stands to reason [19:46:06] chrismcmahon: i forgot, did you create/auth a saucelabs account for me? [19:47:20] marxarelli: I can. If you create an account I can link it to the main account. the concept of "users" on an "account" at Sauce is a little strange. [19:48:59] chrismcmahon: cool. i just create an account: dduvall [19:55:07] marxarelli: I'm not finding you, did you use your WMF email? [19:55:56] marxarelli: I just sent an invite to be a "sub-account" to dduvall@wmf [20:06:36] chrismcmahon: perfect, thanks [22:05:49] greg-g: are you on e2@lists.wikimedia.org ? apropos of our process and unit test discussion earlier today, they're doing cool stuff and making headway [22:07:41] chrismcmahon: no, not on it [23:12:29] chrismcmahon: hey Chris, where can i find the Selenium_user password for beta labs? [23:12:57] trying to verify some failures that are only occurring in sauce labs... [23:18:26] marxarelli: https://integration.wikimedia.org/ci/configure [23:18:53] marxarelli: I'll PM you passwords if you can't get into Jenkins [23:19:34] chrismcmahon: got in. thanks! [23:20:03] (03CR) 10Addshore: [C: 031] "Clicking submit isnt that big a deal." [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/154058 (owner: 10Jeroen De Dauw)