[01:51:56] 3Wikimedia / 3Continuous integration: Regression test failure: "The builder for vector returned a non-Skin object" - 10https://bugzilla.wikimedia.org/69639 (10Matthew Flaschen) [08:51:01] (03PS4) 10Hashar: create browser test builds for Echo extension [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/154070 (https://bugzilla.wikimedia.org/69130) (owner: 10Cmcmahon) [12:07:38] (03PS5) 10Addshore: Add tests for existing custom sniffs [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/154276 [12:08:29] (03PS4) 10Addshore: Refactor ValidGlobalNameSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/153314 [12:08:50] (03PS8) 10Addshore: Create phpcs standard for MW core compatability [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/153399 [12:09:00] (03PS2) 10Addshore: Refactor CodeSniffer Standard checks [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/154296 [12:09:02] (03CR) 10jenkins-bot: [V: 04-1] Refactor CodeSniffer Standard checks [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/154296 (owner: 10Addshore) [12:09:21] (03PS3) 10Addshore: Refactor CodeSniffer Standard tests [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/154296 [12:09:23] (03CR) 10jenkins-bot: [V: 04-1] Refactor CodeSniffer Standard tests [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/154296 (owner: 10Addshore) [12:11:29] (03PS4) 10Addshore: Refactor CodeSniffer Standard tests [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/154296 [12:12:51] (03CR) 10jenkins-bot: [V: 04-1] Refactor CodeSniffer Standard tests [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/154296 (owner: 10Addshore) [12:18:09] (03PS5) 10Addshore: Refactor CodeSniffer Standard tests [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/154296 [12:33:27] 3Wikimedia / 3Continuous integration: CodeSniffer Generic.Formatting.SpaceAfterCast.NoSpace is incorrect - 10https://bugzilla.wikimedia.org/48450 (10Addshore) 5NEW>3RESO/FIX [12:36:18] (03PS1) 10Addshore: Remove dead stuff from MW/ruleset.xml [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/154402 [12:38:02] (03PS1) 10Addshore: Add description to MW/ruleset.xml [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/154403 [13:34:27] (03PS1) 10Addshore: Also catch use of bad classes in function typehints [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/154405 [13:55:00] (03PS1) 10Addshore: AbstractTest makes sure total msg count is correct [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/154406 [13:55:05] (03CR) 10jenkins-bot: [V: 04-1] AbstractTest makes sure total msg count is correct [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/154406 (owner: 10Addshore) [13:58:24] (03PS2) 10Addshore: AbstractTest makes sure total msg count is correct [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/154406 [14:39:26] (03PS1) 10Addshore: Also catch use of globals through $GLOBALS [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/154410 [14:48:28] (03PS1) 10Addshore: Also catch use of global functions [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/154411 [14:54:19] (03PS1) 10Addshore: Add GenericPass test for MediaWikiBreaks standard [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/154412 [18:57:07] (03CR) 10Hashar: [C: 032] "Seems fine, reuse some code from Cake using MIT. Pass on Wikimedia Jenkins thanks to an acceptable hack. Merging in to unlock the other " (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/154276 (owner: 10Addshore) [18:57:14] (03Merged) 10jenkins-bot: Add tests for existing custom sniffs [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/154276 (owner: 10Addshore) [19:07:36] (03CR) 10Hashar: [C: 032] "Some code there was odd indeed :-D" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/153314 (owner: 10Addshore) [19:07:42] (03Merged) 10jenkins-bot: Refactor ValidGlobalNameSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/153314 (owner: 10Addshore) [19:08:34] (03PS9) 10Hashar: Create phpcs standard for MW core compatibility [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/153399 (owner: 10Addshore) [19:38:13] (03CR) 10Hashar: [C: 04-1] "All those tests are a great idea." (0311 comments) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/153399 (owner: 10Addshore) [19:54:46] (03PS2) 10Hashar: Add description to MW/ruleset.xml [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/154403 (owner: 10Addshore) [19:55:27] (03CR) 10Hashar: [C: 032] "simple enough, cherry picked on master and merging." [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/154403 (owner: 10Addshore) [19:55:29] (03Merged) 10jenkins-bot: Add description to MW/ruleset.xml [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/154403 (owner: 10Addshore) [19:56:34] (03PS2) 10Hashar: Remove dead stuff from MW/ruleset.xml [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/154402 (owner: 10Addshore) [19:56:52] (03CR) 10Hashar: "manually rebased." [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/154402 (owner: 10Addshore) [19:59:49] (03CR) 10Hashar: [C: 04-1] "I think I / Timo kept the rules there so we can easily compare with the Squiz rulesets whenever they release a new version. Makes the dif" (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/154402 (owner: 10Addshore) [20:06:16] (03CR) 10Hashar: Refactor CodeSniffer Standard tests (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/154296 (owner: 10Addshore)