[01:38:37] (03CR) 10Krinkle: "Note that this only purges sqlite files in the same build directory. We'll still have N jobs * N concurrency build directories left over i" [integration/jenkins] - 10https://gerrit.wikimedia.org/r/167948 (https://bugzilla.wikimedia.org/71128) (owner: 10Hashar) [01:49:33] (03PS5) 10Krinkle: tools: Update dev packages [integration/jenkins] - 10https://gerrit.wikimedia.org/r/166900 [01:56:42] (03PS6) 10Krinkle: tools: Update dev packages [integration/jenkins] - 10https://gerrit.wikimedia.org/r/166900 [01:58:31] (03PS7) 10Krinkle: tools: Update dev packages [integration/jenkins] - 10https://gerrit.wikimedia.org/r/166900 [01:59:47] (03CR) 10Krinkle: [C: 032] tools: Update dev packages [integration/jenkins] - 10https://gerrit.wikimedia.org/r/166900 (owner: 10Krinkle) [01:59:52] (03Merged) 10jenkins-bot: tools: Update dev packages [integration/jenkins] - 10https://gerrit.wikimedia.org/r/166900 (owner: 10Krinkle) [03:17:33] Project browsertests-Echo-test2.wikipedia.org-linux-chrome-sauce build #120: FAILURE in 11 min: https://integration.wikimedia.org/ci/job/browsertests-Echo-test2.wikipedia.org-linux-chrome-sauce/120/ [03:35:37] Yippee, build fixed! [03:35:38] Project browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-windows_7-internet_explorer-11-sauce build #31: FIXED in 33 min: https://integration.wikimedia.org/ci/job/browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-windows_7-internet_explorer-11-sauce/31/ [03:43:52] Yippee, build fixed! [03:43:53] Project browsertests-CirrusSearch-en.wikipedia.beta.wmflabs.org-linux-firefox-sauce build #224: FIXED in 1 min 11 sec: https://integration.wikimedia.org/ci/job/browsertests-CirrusSearch-en.wikipedia.beta.wmflabs.org-linux-firefox-sauce/224/ [04:15:29] Project browsertests-Echo-en.wikipedia.beta.wmflabs.org-linux-firefox-sauce build #138: FAILURE in 10 min: https://integration.wikimedia.org/ci/job/browsertests-Echo-en.wikipedia.beta.wmflabs.org-linux-firefox-sauce/138/ [04:39:46] Project browsertests-Echo-en.wikipedia.beta.wmflabs.org-linux-chrome-sauce build #123: FAILURE in 8 min 32 sec: https://integration.wikimedia.org/ci/job/browsertests-Echo-en.wikipedia.beta.wmflabs.org-linux-chrome-sauce/123/ [05:13:37] Yippee, build fixed! [05:13:38] Project browsertests-MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome-sauce build #284: FIXED in 46 min: https://integration.wikimedia.org/ci/job/browsertests-MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome-sauce/284/ [06:23:44] Project browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-windows_8-internet_explorer-sauce build #240: FAILURE in 33 min: https://integration.wikimedia.org/ci/job/browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-windows_8-internet_explorer-sauce/240/ [06:41:06] Yippee, build fixed! [06:41:07] Project browsertests-Flow-test2.wikipedia.org-linux-chrome-sauce build #229: FIXED in 35 min: https://integration.wikimedia.org/ci/job/browsertests-Flow-test2.wikipedia.org-linux-chrome-sauce/229/ [06:52:00] PROBLEM - BetaLabs: Puppet failure events on labmon1001 is CRITICAL: CRITICAL: deployment-prep.deployment-analytics01.puppetagent.failed_events.value (30.00%) [07:00:03] Yippee, build fixed! [07:00:04] Project browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-linux-chrome-sauce build #242: FIXED in 25 min: https://integration.wikimedia.org/ci/job/browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-linux-chrome-sauce/242/ [07:09:57] PROBLEM - BetaLabs: Puppet failure events on labmon1001 is CRITICAL: CRITICAL: deployment-prep.deployment-analytics01.puppetagent.failed_events.value (80.00%) [07:17:48] RECOVERY - BetaLabs: Puppet failure events on labmon1001 is OK: OK: All targets OK [07:19:57] Yippee, build fixed! [07:19:57] Project browsertests-UniversalLanguageSelector-commons.wikimedia.beta.wmflabs.org-linux-firefox-sauce build #237: FIXED in 21 min: https://integration.wikimedia.org/ci/job/browsertests-UniversalLanguageSelector-commons.wikimedia.beta.wmflabs.org-linux-firefox-sauce/237/ [11:03:42] (03PS1) 10Zfilipin: WIP Run RuboCop and Ruby syntax check for mediawiki-vagrant [integration/config] - 10https://gerrit.wikimedia.org/r/168270 (https://bugzilla.wikimedia.org/69245) [11:15:03] (03PS2) 10Zfilipin: WIP Run RuboCop and Ruby syntax check for mediawiki-vagrant [integration/config] - 10https://gerrit.wikimedia.org/r/168270 (https://bugzilla.wikimedia.org/69245) [11:23:33] (03PS3) 10Zfilipin: Run RuboCop and Ruby syntax check for mediawiki-vagrant [integration/config] - 10https://gerrit.wikimedia.org/r/168270 (https://bugzilla.wikimedia.org/69245) [11:27:26] * zeljkof is out of lunch [11:44:20] * zeljkof is back [11:54:17] it seems zuul stoped running any jenkins jobs [12:06:21] (03PS4) 10Krinkle: Enable RuboCop and Ruby syntax check for mediawiki-vagrant [integration/config] - 10https://gerrit.wikimedia.org/r/168270 (https://bugzilla.wikimedia.org/69245) (owner: 10Zfilipin) [12:12:02] PROBLEM - jenkins_service_running on gallium is CRITICAL: PROCS CRITICAL: 2 processes with regex args ^/usr/bin/java .*-jar /usr/share/jenkins/jenkins.war [12:46:32] RECOVERY - jenkins_service_running on gallium is OK: PROCS OK: 1 process with regex args ^/usr/bin/java .*-jar /usr/share/jenkins/jenkins.war [13:04:21] (03CR) 10Zfilipin: [C: 031] Switch ruby jobs to ruby 2.0 [integration/config] - 10https://gerrit.wikimedia.org/r/166555 (owner: 10Hashar) [13:06:56] 3Wikimedia / 3Quality Assurance: rubocop should run after patch set submission to every repo that has Ruby code - 10https://bugzilla.wikimedia.org/69245 (10Željko Filipin) a:3Željko Filipin [13:07:25] 3Wikimedia / 3Quality Assurance: Review if existing Ruby code follows Ruby Styleguide - 10https://bugzilla.wikimedia.org/63307 (10Željko Filipin) a:3Željko Filipin [13:14:07] (03PS1) 10Zfilipin: Fixed Style/BracesAroundHashParameters RuboCop offense [ruby/api] - 10https://gerrit.wikimedia.org/r/168277 (https://bugzilla.wikimedia.org/63307) [13:14:39] (03CR) 10Zfilipin: "check experimental" [ruby/api] - 10https://gerrit.wikimedia.org/r/168277 (https://bugzilla.wikimedia.org/63307) (owner: 10Zfilipin) [13:19:27] (03PS2) 10Zfilipin: Fixed RuboCop offense Style/BracesAroundHashParameters [ruby/api] - 10https://gerrit.wikimedia.org/r/168277 (https://bugzilla.wikimedia.org/63307) [13:19:37] (03PS1) 10Zfilipin: Fixed RuboCop offense Style/Alias [ruby/api] - 10https://gerrit.wikimedia.org/r/168279 (https://bugzilla.wikimedia.org/63307) [13:21:33] (03PS1) 10Zfilipin: Fixed RuboCop offense Style/DotPosition [ruby/api] - 10https://gerrit.wikimedia.org/r/168281 (https://bugzilla.wikimedia.org/63307) [13:24:09] (03PS5) 10Krinkle: Enable RuboCop and Ruby syntax check jobs for mediawiki-vagrant [integration/config] - 10https://gerrit.wikimedia.org/r/168270 (https://bugzilla.wikimedia.org/69245) (owner: 10Zfilipin) [13:36:49] (03PS1) 10Zfilipin: Fixed RuboCop offense Style/LeadingCommentSpace [ruby/api] - 10https://gerrit.wikimedia.org/r/168283 (https://bugzilla.wikimedia.org/63307) [13:36:54] (03PS1) 10Zfilipin: Fixed RuboCop offense Style/PercentLiteralDelimiters [ruby/api] - 10https://gerrit.wikimedia.org/r/168284 (https://bugzilla.wikimedia.org/63307) [13:36:57] (03PS1) 10Zfilipin: Fixed RuboCop offense Style/SignalException [ruby/api] - 10https://gerrit.wikimedia.org/r/168285 (https://bugzilla.wikimedia.org/63307) [13:37:02] (03PS1) 10Zfilipin: Fixed RuboCop offense Style/SpaceInsideParens [ruby/api] - 10https://gerrit.wikimedia.org/r/168286 (https://bugzilla.wikimedia.org/63307) [13:37:06] (03PS1) 10Zfilipin: Fixed RuboCop offense Style/SpecialGlobalVars [ruby/api] - 10https://gerrit.wikimedia.org/r/168287 (https://bugzilla.wikimedia.org/63307) [13:37:11] (03PS1) 10Zfilipin: Fixed RuboCop offense Style/StringLiterals [ruby/api] - 10https://gerrit.wikimedia.org/r/168288 (https://bugzilla.wikimedia.org/63307) [13:37:18] (03PS1) 10Zfilipin: Fixed RuboCop offense Style/UnneededPercentQ [ruby/api] - 10https://gerrit.wikimedia.org/r/168289 (https://bugzilla.wikimedia.org/63307) [13:37:22] (03CR) 10jenkins-bot: [V: 04-1] Fixed RuboCop offense Style/SpecialGlobalVars [ruby/api] - 10https://gerrit.wikimedia.org/r/168287 (https://bugzilla.wikimedia.org/63307) (owner: 10Zfilipin) [13:37:24] (03PS1) 10Zfilipin: Fixed RuboCop offense Style/WordArray [ruby/api] - 10https://gerrit.wikimedia.org/r/168290 (https://bugzilla.wikimedia.org/63307) [13:38:14] (03CR) 10Zfilipin: "check experimental" [ruby/api] - 10https://gerrit.wikimedia.org/r/168290 (https://bugzilla.wikimedia.org/63307) (owner: 10Zfilipin) [13:38:44] (03CR) 10Zfilipin: "check experimental" [ruby/api] - 10https://gerrit.wikimedia.org/r/168289 (https://bugzilla.wikimedia.org/63307) (owner: 10Zfilipin) [13:39:06] (03CR) 10Zfilipin: "check experimental" [ruby/api] - 10https://gerrit.wikimedia.org/r/168288 (https://bugzilla.wikimedia.org/63307) (owner: 10Zfilipin) [13:39:18] (03CR) 10Zfilipin: "check experimental" [ruby/api] - 10https://gerrit.wikimedia.org/r/168287 (https://bugzilla.wikimedia.org/63307) (owner: 10Zfilipin) [13:39:44] (03CR) 10Zfilipin: "recheck" [ruby/api] - 10https://gerrit.wikimedia.org/r/168287 (https://bugzilla.wikimedia.org/63307) (owner: 10Zfilipin) [13:39:52] (03CR) 10Zfilipin: "check experimental" [ruby/api] - 10https://gerrit.wikimedia.org/r/168286 (https://bugzilla.wikimedia.org/63307) (owner: 10Zfilipin) [13:40:20] (03CR) 10Zfilipin: "check experimental" [ruby/api] - 10https://gerrit.wikimedia.org/r/168285 (https://bugzilla.wikimedia.org/63307) (owner: 10Zfilipin) [13:40:38] (03CR) 10Zfilipin: "check experimental" [ruby/api] - 10https://gerrit.wikimedia.org/r/168284 (https://bugzilla.wikimedia.org/63307) (owner: 10Zfilipin) [13:40:52] (03CR) 10Zfilipin: "check experimental" [ruby/api] - 10https://gerrit.wikimedia.org/r/168283 (https://bugzilla.wikimedia.org/63307) (owner: 10Zfilipin) [13:41:01] (03CR) 10Zfilipin: "check experimental" [ruby/api] - 10https://gerrit.wikimedia.org/r/168281 (https://bugzilla.wikimedia.org/63307) (owner: 10Zfilipin) [13:41:10] (03CR) 10Zfilipin: "check experimental" [ruby/api] - 10https://gerrit.wikimedia.org/r/168279 (https://bugzilla.wikimedia.org/63307) (owner: 10Zfilipin) [13:55:35] (03PS1) 10Zfilipin: Fixed RuboCop offense Lint/UselessAssignment [ruby/api] - 10https://gerrit.wikimedia.org/r/168292 (https://bugzilla.wikimedia.org/63307) [13:55:56] (03CR) 10Zfilipin: "check experimental" [ruby/api] - 10https://gerrit.wikimedia.org/r/168292 (https://bugzilla.wikimedia.org/63307) (owner: 10Zfilipin) [13:58:03] (03CR) 10Zfilipin: "If I remove Lint/UselessAssignment from .rubocop_todo.yml, I get this from rubocop:" [ruby/api] - 10https://gerrit.wikimedia.org/r/168292 (https://bugzilla.wikimedia.org/63307) (owner: 10Zfilipin) [13:58:48] (03CR) 10Zfilipin: "Trying again to format terminal output:" [ruby/api] - 10https://gerrit.wikimedia.org/r/168292 (https://bugzilla.wikimedia.org/63307) (owner: 10Zfilipin) [14:00:28] (03CR) 10Zfilipin: "If I remove spec/client_spec.rb:182 line:" [ruby/api] - 10https://gerrit.wikimedia.org/r/168292 (https://bugzilla.wikimedia.org/63307) (owner: 10Zfilipin) [14:01:23] (03CR) 10Zfilipin: "But then rspec fails:" [ruby/api] - 10https://gerrit.wikimedia.org/r/168292 (https://bugzilla.wikimedia.org/63307) (owner: 10Zfilipin) [15:58:58] (03PS1) 10Zfilipin: Fixed RuboCop offense Style/ClassAndModuleChildren [ruby/api] - 10https://gerrit.wikimedia.org/r/168309 (https://bugzilla.wikimedia.org/63307) [15:59:04] (03PS1) 10Zfilipin: WIP Fixed RuboCop offense Metrics/LineLength [ruby/api] - 10https://gerrit.wikimedia.org/r/168310 (https://bugzilla.wikimedia.org/63307) [16:00:21] (03CR) 10Zfilipin: "check experimental" [ruby/api] - 10https://gerrit.wikimedia.org/r/168310 (https://bugzilla.wikimedia.org/63307) (owner: 10Zfilipin) [16:00:32] (03CR) 10Zfilipin: "check experimental" [ruby/api] - 10https://gerrit.wikimedia.org/r/168309 (https://bugzilla.wikimedia.org/63307) (owner: 10Zfilipin) [16:11:51] zeljkof: still no sound... trying something else.... give me 5 more minutes :( [16:12:06] greg-g: ok [16:12:13] I can call you on the phone from the hangout [16:12:27] or we can try skype [16:19:21] zeljkof: let's skip today's call, unfortunately [16:19:26] greg-g: ok [16:19:38] better luck next week :) [16:21:33] yeah, no idea what happened to that laptop, it lost it's sound outputs (only "Dummy Output" listed in sound settings) [16:27:06] (03PS2) 10Zfilipin: Fixed RuboCop offense Metrics/LineLength [ruby/api] - 10https://gerrit.wikimedia.org/r/168310 (https://bugzilla.wikimedia.org/63307) [16:30:09] 3Wikimedia / 3Quality Assurance: Pending fails upon not finding an element (a failure case that should pass) - 10https://bugzilla.wikimedia.org/72379#c2 (10Dan Duvall) Also, please run cucumber with the --backtrace option and provide the backtrace. That will help in tracking down the strange TODO exception. [16:32:52] (03PS1) 10Zfilipin: Fixed RuboCop offense Lint/UnusedBlockArgument [selenium] - 10https://gerrit.wikimedia.org/r/168314 (https://bugzilla.wikimedia.org/63307) [16:35:35] (03PS1) 10Zfilipin: Fixed RuboCop offense Lint/UnusedMethodArgument [selenium] - 10https://gerrit.wikimedia.org/r/168316 (https://bugzilla.wikimedia.org/63307) [16:37:17] should I be filing CI bugs in BZ or phabricator? [16:37:50] legoktm: I think phab does not have CI project (or whatever that is called) yet [16:38:40] (03PS1) 10Zfilipin: Fixed RuboCop offense Lint/UselessAccessModifier [selenium] - 10https://gerrit.wikimedia.org/r/168318 (https://bugzilla.wikimedia.org/63307) [16:38:54] hmm, I could have sworn it did. [16:40:10] legoktm: bugzilla for now [16:40:39] it has a #releng project (really #Release-Engineering, but short names are great), but that's the closest [16:41:16] (03PS1) 10Zfilipin: Fixed RuboCop offense Style/AndOr [selenium] - 10https://gerrit.wikimedia.org/r/168320 (https://bugzilla.wikimedia.org/63307) [16:43:23] 3Wikimedia / 3Quality Assurance: ZeroPortal browsertests fails early due to auth issue with zero.wikimedia.org - 10https://bugzilla.wikimedia.org/72326#c4 (10dr0ptp4kt) Aha, okay, I think I understand the magic a little better. @yurik, is there a way to open the specific API endpoint to which @hashar refers... [16:43:25] 3Wikimedia / 3Continuous integration: mediawiki-gate job blocking on different branches - 10https://bugzilla.wikimedia.org/72432 (10Kunal Mehta (Legoktm)) 3NEW p:3Unprio s:3normal a:3None A patch to WikimediaEvents's master branch was blocked by two core patches being merged in the REL1_24 branch. Th... [17:06:53] 3Wikimedia / 3Quality Assurance: Pending fails upon not finding an element (a failure case that should pass) - 10https://bugzilla.wikimedia.org/72379#c3 (10Chris McMahon) FWIW: in my Scenario I have a step Background: Given I am logged in And This is my step and I have put this in my steps f... [17:12:28] Project beta-scap-eqiad build #26780: FAILURE in 1 min 2 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/26780/ [17:15:08] Yippee, build fixed! [17:15:08] Project beta-scap-eqiad build #26781: FIXED in 1 min 7 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/26781/ [17:27:49] (03PS2) 10Dduvall: Fixed RuboCop offense Lint/UselessAssignment [ruby/api] - 10https://gerrit.wikimedia.org/r/168292 (https://bugzilla.wikimedia.org/63307) (owner: 10Zfilipin) [17:31:06] (03CR) 10Dduvall: [C: 032] Fixed RuboCop offense Style/BracesAroundHashParameters [ruby/api] - 10https://gerrit.wikimedia.org/r/168277 (https://bugzilla.wikimedia.org/63307) (owner: 10Zfilipin) [17:31:21] (03Merged) 10jenkins-bot: Fixed RuboCop offense Style/BracesAroundHashParameters [ruby/api] - 10https://gerrit.wikimedia.org/r/168277 (https://bugzilla.wikimedia.org/63307) (owner: 10Zfilipin) [17:32:02] (03PS2) 10Dduvall: Fixed RuboCop offense Style/Alias [ruby/api] - 10https://gerrit.wikimedia.org/r/168279 (https://bugzilla.wikimedia.org/63307) (owner: 10Zfilipin) [17:35:25] 3Wikimedia / 3Quality Assurance: pdfhandler build is misconfigured - 10https://bugzilla.wikimedia.org/72435 (10Chris McMahon) 3NEW p:3Unprio s:3normal a:3None no results in the build as of 21 October https://integration.wikimedia.org/ci/view/BrowserTests/view/-All/job/browsertests-PdfHandler-test2.w... [17:36:24] 3Wikimedia / 3Quality Assurance: pdfhandler and MMV builds are misconfigured - 10https://bugzilla.wikimedia.org/72435#c1 (10Chris McMahon) also see https://integration.wikimedia.org/ci/view/BrowserTests/view/-All/job/browsertests-MultimediaViewer-mediawiki.org-linux-firefox-sauce/ [17:38:23] 3Wikimedia / 3Quality Assurance: pdfhandler and MMV builds are misconfigured - 10https://bugzilla.wikimedia.org/72435#c2 (10Chris McMahon) p:5Unprio>3High s:5normal>3major core also: https://integration.wikimedia.org/ci/view/BrowserTests/view/-All/job/browsertests-Core-en.wikipedia.beta.wmflabs.org-l... [17:59:50] Yippee, build fixed! [17:59:50] Project browsertests-Echo-en.wikipedia.beta.wmflabs.org-linux-firefox-sauce build #140: FIXED in 10 min: https://integration.wikimedia.org/ci/job/browsertests-Echo-en.wikipedia.beta.wmflabs.org-linux-firefox-sauce/140/ [18:20:43] Yippee, build fixed! [18:20:43] Project browsertests-Echo-test2.wikipedia.org-linux-chrome-sauce build #121: FIXED in 13 min: https://integration.wikimedia.org/ci/job/browsertests-Echo-test2.wikipedia.org-linux-chrome-sauce/121/ [18:23:14] Project browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-windows_7-internet_explorer-11-sauce build #32: FAILURE in 21 min: https://integration.wikimedia.org/ci/job/browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-windows_7-internet_explorer-11-sauce/32/ [18:59:22] (03CR) 10EBernhardson: "bump?" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/163898 (owner: 10EBernhardson) [19:50:08] Yippee, build fixed! [19:50:09] Project browsertests-CirrusSearch-test2.wikipedia.org-linux-firefox-sauce build #219: FIXED in 1 min 35 sec: https://integration.wikimedia.org/ci/job/browsertests-CirrusSearch-test2.wikipedia.org-linux-firefox-sauce/219/ [19:50:56] Yippee, build fixed! [19:50:57] Project browsertests-Echo-en.wikipedia.beta.wmflabs.org-linux-chrome-sauce build #124: FIXED in 8 min 16 sec: https://integration.wikimedia.org/ci/job/browsertests-Echo-en.wikipedia.beta.wmflabs.org-linux-chrome-sauce/124/ [20:24:38] Yippee, build fixed! [20:24:38] Project browsertests-VisualEditor-en.wikipedia.beta.wmflabs.org-linux-firefox-sauce build #354: FIXED in 1 hr 1 min: https://integration.wikimedia.org/ci/job/browsertests-VisualEditor-en.wikipedia.beta.wmflabs.org-linux-firefox-sauce/354/ [20:25:53] Yippee, build fixed! [20:25:53] Project browsertests-PdfHandler-test2.wikipedia.org-linux-firefox-sauce build #157: FIXED in 1 min 16 sec: https://integration.wikimedia.org/ci/job/browsertests-PdfHandler-test2.wikipedia.org-linux-firefox-sauce/157/ [20:49:48] marxarelli: I was going to point out that nifty thing the Flow team did with specifying elements within other elements, e.g. https://gerrit.wikimedia.org/r/#/c/168197/2/tests/browser/features/support/pages/flow_page.rb [20:58:02] marxarelli: also, if you want to do more guerilla merging, I have four more patches in the queue [21:20:04] chrismcmahon: cool, i'll take a look [21:20:47] chrismcmahon: i'm going through all the rubocop-related commits that zeljko pushed but that shouldn't take too long [21:24:54] wtf is up with beta-code-update [21:24:55] https://integration.wikimedia.org/ci/view/Beta/job/beta-code-update-eqiad/ [21:24:59] 2 hours since last success? [21:25:07] marxarelli: they did it for the edit/thank stuff above, and for the topic-watch stuff also https://gerrit.wikimedia.org/r/#/c/168420/1/tests/browser/features/support/pages/flow_page.rb, places where the same controls exist many places on the page. pretty neat. [21:25:14] urgh [21:27:38] Asked in -operations too, we'll see what happen [21:34:41] Yippee, build fixed! [21:34:41] Project browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-windows_8-internet_explorer-sauce build #241: FIXED in 35 min: https://integration.wikimedia.org/ci/job/browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-windows_8-internet_explorer-sauce/241/ [21:36:00] !log Jenkins: disconnected / reconnected slave node deployment-bastion.eqiad [21:36:06] !log Jenkins: disconnected / reconnected slave node deployment-bastion.eqiad [21:36:11] Logged the message, Master [21:41:42] (03CR) 10Dduvall: [C: 04-1] "I don't necessarily agree with this rule across the board[1]—and there's no discussion around it in the bbatsov guide, only that `alias_me" [ruby/api] - 10https://gerrit.wikimedia.org/r/168279 (https://bugzilla.wikimedia.org/63307) (owner: 10Zfilipin) [21:46:15] (03PS3) 10Dduvall: Use alias_method when aliasing macro-defined attributes [ruby/api] - 10https://gerrit.wikimedia.org/r/168279 (https://bugzilla.wikimedia.org/63307) (owner: 10Zfilipin) [22:05:52] marxarelli: I didn't know that about nested elements, thanks for the pointer [22:06:23] chrismcmahon: no problem. i wasn't sure myself which is why i jumped into a debugger [22:07:52] marxarelli: I do still think that the object passed in that context should be more descriptive than just "page" (as opposed to when we actually do "on(FooPage) do |page|") [22:08:07] chrismcmahon: i kind of wish there was an alternative way to declare nested elements. something like: `div(:bar, parent: :foo) { |foo| foo.div(css: ...) } [22:08:30] where you _could_ dictate that the block argument was the parent element [22:09:30] marxarelli: file an issue? https://github.com/cheezy/page-object/issues Jeff is a reasonable guy... [22:10:02] chrismcmahon: not a bad idea. maybe even a pull request :) [22:26:34] I am going to restart Jenkins so canceling a bunch of browsertests builds [22:27:00] hashar: fine by me [22:27:12] should we bother retriggering them manually ? [22:27:58] hashar: don't bother, I leave for the airport in 15 minutes or so [22:28:10] they'll run overnight as usual [22:28:16] chrismcmahon: I guess :) [22:28:20] chrismcmahon: have a good flight! [22:28:24] chrismcmahon: safe travels :) [22:28:42] I like SF, but I like leaving SF also :-) [22:35:17] (03CR) 10Jforrester: [C: 032] WikidataBrowserTests jobs are now hosted at Wikimedia Jenkins [selenium] - 10https://gerrit.wikimedia.org/r/167807 (owner: 10Zfilipin) [22:35:48] marxarelli: what to do to reverse the -1 on https://gerrit.wikimedia.org/r/#/c/168197/ ? [22:36:44] chrismcmahon: oh, sorry, i should have been more clear [22:37:04] chrismcmahon: i would just abandon the changes to flow_page.rb. everything else looks good [22:37:27] i.e. git checkout HEAD^ -- tests/browser/features/support/pages/flow_page.rb [22:38:17] marxarelli: quoting myself above, I do still think that the object passed in that context should be more descriptive than just "page" (as opposed to when we actually do "on(FooPage) do |page|") [22:38:45] chrismcmahon: i'm not sure what could be more descriptive though [22:38:52] i mean, it is a page object instance [22:38:58] so, page seems reasonable to me [22:39:35] marxarelli: yes, but it's intent is to be a parent for "first_post_meta_actions" per the css of the span being described [22:39:41] i would say maybe flow_page, but it's already in the context of FlowPage so that's kind of a given [22:40:27] chrismcmahon: the :edit_post link is the parent element, not `page` [22:40:31] (03Merged) 10jenkins-bot: WikidataBrowserTests jobs are now hosted at Wikimedia Jenkins [selenium] - 10https://gerrit.wikimedia.org/r/167807 (owner: 10Zfilipin) [22:40:44] wait, sorry, that's wrong [22:40:46] :) [22:40:57] * marxarelli really thinks the api on this matter is confusing [22:41:03] well, it's kind of right [22:41:25] the post_meta_actions element is the parent [22:42:13] when you give page objects a block like that, you're supplying the implementation for finding the element from the root of the page [22:42:20] right, and "|first_post_meta_actions|" is the description I supplied for that parent. I like that better than "|page|" [22:42:27] which is why the argument to the block is the page-object instance [22:43:06] !log Jenkins resumed activity. Beta cluster code is being updated [22:43:08] Logged the message, Master [22:43:13] but the first_post_meta_actions object wouldn't be the parent when the block is invoked [22:43:17] crashing to bed, see you tomorrow [22:43:33] hmm [22:44:09] you can't control what page-object passes as the argument by simply changing its name. it's always going to be the root page-object instance [22:45:22] marxarelli: understood, but naming that other than "|page|" demonstrates the intent behind using that element as the parent for the nested stuff. dunno, I'll think it over, I want to beat the crush to BART right about now. [22:45:39] in other words, page object is responsible for invoking the block and we have no control over it [22:45:55] naming is super important, i agree [22:46:02] but the name should represent what the object is [22:46:25] hokay, I'll move those back to |page|, but it'll probably be tomorrow [22:46:39] and since we can't affect what the object will be, we might as well keep the name true to what it is