[03:34:59] Yippee, build fixed! [03:35:00] Project browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-windows_7-internet_explorer-11-sauce build #33: FIXED in 32 min: https://integration.wikimedia.org/ci/job/browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-windows_7-internet_explorer-11-sauce/33/ [04:14:39] Project browsertests-Echo-en.wikipedia.beta.wmflabs.org-linux-firefox-sauce build #142: FAILURE in 9 min 30 sec: https://integration.wikimedia.org/ci/job/browsertests-Echo-en.wikipedia.beta.wmflabs.org-linux-firefox-sauce/142/ [04:26:26] Project browsertests-UploadWizard-commons.wikimedia.beta.wmflabs.org-linux-firefox-sauce build #260: FAILURE in 7 min 41 sec: https://integration.wikimedia.org/ci/job/browsertests-UploadWizard-commons.wikimedia.beta.wmflabs.org-linux-firefox-sauce/260/ [04:37:39] Project browsertests-Echo-en.wikipedia.beta.wmflabs.org-linux-chrome-sauce build #125: FAILURE in 8 min 19 sec: https://integration.wikimedia.org/ci/job/browsertests-Echo-en.wikipedia.beta.wmflabs.org-linux-chrome-sauce/125/ [05:14:28] Project browsertests-MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome-sauce build #286: FAILURE in 48 min: https://integration.wikimedia.org/ci/job/browsertests-MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome-sauce/286/ [07:02:32] Project browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-windows_7-internet_explorer-9-sauce build #87: FAILURE in 43 min: https://integration.wikimedia.org/ci/job/browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-windows_7-internet_explorer-9-sauce/87/ [07:27:23] Project browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-linux-chrome-sauce build #244: FAILURE in 24 min: https://integration.wikimedia.org/ci/job/browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-linux-chrome-sauce/244/ [07:27:30] Project browsertests-VisualEditor-test2.wikipedia.org-windows_8-internet_explorer-sauce build #85: STILL FAILING in 1 hr 16 min: https://integration.wikimedia.org/ci/job/browsertests-VisualEditor-test2.wikipedia.org-windows_8-internet_explorer-sauce/85/ [07:48:20] Project browsertests-VisualEditor-test2.wikipedia.org-linux-firefox-sauce build #262: STILL FAILING in 1 hr 10 min: https://integration.wikimedia.org/ci/job/browsertests-VisualEditor-test2.wikipedia.org-linux-firefox-sauce/262/ [07:59:44] Project browsertests-VisualEditor-en.wikipedia.beta.wmflabs.org-os_x_10.9-safari-sauce build #96: STILL FAILING in 57 min: https://integration.wikimedia.org/ci/job/browsertests-VisualEditor-en.wikipedia.beta.wmflabs.org-os_x_10.9-safari-sauce/96/ [08:18:50] good morning [08:25:49] (03PS8) 10Hashar: Switch ruby jobs to ruby 2.0 [integration/config] - 10https://gerrit.wikimedia.org/r/166555 [08:35:38] (03PS9) 10Hashar: Switch ruby jobs to ruby 2.0 [integration/config] - 10https://gerrit.wikimedia.org/r/166555 [08:46:30] (03CR) 10Hashar: [C: 032] "Had to move the UploadWizard api tests back to Precise. I have tested all jobs beside the browsertests jobs one but I am not worried abo" [integration/config] - 10https://gerrit.wikimedia.org/r/166555 (owner: 10Hashar) [08:50:43] (03Merged) 10jenkins-bot: Switch ruby jobs to ruby 2.0 [integration/config] - 10https://gerrit.wikimedia.org/r/166555 (owner: 10Hashar) [09:22:18] (03PS1) 10Hashar: Refactor mw sqlite related env variables [integration/jenkins] - 10https://gerrit.wikimedia.org/r/168558 (https://bugzilla.wikimedia.org/71128) [09:23:26] (03CR) 10Hashar: [C: 032] Refactor mw sqlite related env variables [integration/jenkins] - 10https://gerrit.wikimedia.org/r/168558 (https://bugzilla.wikimedia.org/71128) (owner: 10Hashar) [09:23:30] (03Merged) 10jenkins-bot: Refactor mw sqlite related env variables [integration/jenkins] - 10https://gerrit.wikimedia.org/r/168558 (https://bugzilla.wikimedia.org/71128) (owner: 10Hashar) [09:30:47] (03PS1) 10Hashar: mw-teardown.sh: to be run after mw jobs [integration/jenkins] - 10https://gerrit.wikimedia.org/r/168562 (https://bugzilla.wikimedia.org/71128) [09:31:23] (03CR) 10Hashar: [C: 032] mw-teardown.sh: to be run after mw jobs [integration/jenkins] - 10https://gerrit.wikimedia.org/r/168562 (https://bugzilla.wikimedia.org/71128) (owner: 10Hashar) [09:31:25] (03Merged) 10jenkins-bot: mw-teardown.sh: to be run after mw jobs [integration/jenkins] - 10https://gerrit.wikimedia.org/r/168562 (https://bugzilla.wikimedia.org/71128) (owner: 10Hashar) [09:54:53] (03PS1) 10Hashar: Mediawiki teardown publisher [integration/config] - 10https://gerrit.wikimedia.org/r/168566 (https://bugzilla.wikimedia.org/71128) [09:56:05] (03CR) 10Hashar: [C: 032] "All jobs having mw-install-sqlite now have mw-teardown as well. Tested it on a few jobs and that seems to work properly." [integration/config] - 10https://gerrit.wikimedia.org/r/168566 (https://bugzilla.wikimedia.org/71128) (owner: 10Hashar) [10:04:42] (03Merged) 10jenkins-bot: Mediawiki teardown publisher [integration/config] - 10https://gerrit.wikimedia.org/r/168566 (https://bugzilla.wikimedia.org/71128) (owner: 10Hashar) [10:26:24] 3Wikimedia / 3Continuous integration: Jenkins: lanthanum/gallium tmpfs are filling up with stale tmp files - 10https://bugzilla.wikimedia.org/71128#c16 (10Antoine "hashar" Musso (WMF)) 5PATC>3ASSI The patch above cause jobs to delete the sqlite file on completion. That should keep tmpfs usage at a minim... [10:44:48] food needed , heading lunch [11:04:45] (03PS2) 10Zfilipin: Enable RuboCop jobs for all repositories where it was experimental [integration/config] - 10https://gerrit.wikimedia.org/r/168061 (https://bugzilla.wikimedia.org/69245) [12:52:53] 3Wikimedia / 3Continuous integration: Zuul cloner: fails on extension jobs against a wmf branch - 10https://bugzilla.wikimedia.org/71133#c9 (10Antoine "hashar" Musso (WMF)) This is fixed on our installation. Pending upstream patch to be merged in. [13:36:15] !log apt-get upgrade on Trusty Jenkins slaves [13:36:19] Logged the message, Master [13:36:46] !log That bumps hhvm on contint from 3.3.0-20140925+wmf2 to 3.3.0-20140925+wmf3 [13:36:48] Logged the message, Master [13:42:39] 3Wikimedia / 3Continuous integration: [OPS] hhvm 3.3.0-20140925+wmf3 has some annoying build dependency - 10https://bugzilla.wikimedia.org/71413#c2 (10Antoine "hashar" Musso (WMF)) p:5Unprio>3Low 3.3.0-20140925+wmf3 still has the issue. The puppet manifest has been enhanced and no more blindly attempt t... [13:45:53] 3Wikimedia / 3Continuous integration: Jenkins: lanthanum/gallium tmpfs are filling up with stale tmp files - 10https://bugzilla.wikimedia.org/71128#c17 (10Antoine "hashar" Musso (WMF)) 5ASSI>3RESO/FIX Lets just assume this is fixed for now. Additionally I have manually cleared the tmpfs partitions on bo... [13:46:45] * hashar kills bugs [13:46:52] 3Wikimedia / 3Continuous integration: [upstream] Jenkins: jobs created via JJB are not properly registered in Zuul Gearman server - 10https://bugzilla.wikimedia.org/63758#c6 (10Antoine "hashar" Musso (WMF)) 5ASSI>3RESO/FIX The plugin has been released and is applied on our Jenkins. Jobs created via JJB... [13:51:39] 3Wikimedia / 3Continuous integration: Zuul cloner: fails on extension jobs against a wmf branch - 10https://bugzilla.wikimedia.org/71133#c10 (10Antoine "hashar" Musso (WMF)) The patch I proposed to upstream https://review.openstack.org/#/c/123437/ was blocked because the tests under python2.6 were broken. T... [13:53:38] 3Wikimedia / 3Continuous integration: Augment jsonlint test with a test for duplicate keys - 10https://bugzilla.wikimedia.org/71284#c10 (10Antoine "hashar" Musso (WMF)) p:5Normal>3Lowest Setting lowest priority until someone is willing to take this and figure out a solution. [13:56:38] 3Wikimedia / 3Continuous integration: mediawiki-gate job blocking on different branches - 10https://bugzilla.wikimedia.org/72432#c1 (10Antoine "hashar" Musso (WMF)) Zuul is not smart enough to detect branch dependencies. The changes shares the same queue if they share at least one job (in our case 'mediawik... [13:58:24] 3Wikimedia / 3Continuous integration: Jenkins: Figure out long term solution for /tmp management - 10https://bugzilla.wikimedia.org/72011 (10Antoine "hashar" Musso (WMF)) s:5major>3enhanc [13:59:23] 3Wikimedia / 3Continuous integration: ci/jenkins: remove dependency on git.wikimedia.org - 10https://bugzilla.wikimedia.org/72001 (10Antoine "hashar" Musso (WMF)) p:5Unprio>3Normal s:5normal>3enhanc [14:19:08] 3Wikimedia Labs / 3deployment-prep (beta): broken Upload file link in en-beta navigation - 10https://bugzilla.wikimedia.org/57117#c1 (10Antoine "hashar" Musso (WMF)) p:5Unprio>3Lowest s:5normal>3enhanc On the production wiki that is a link to: https://en.wikipedia.org/w/index.php?title=Wikipedia:Fil... [14:19:09] 3Wikimedia Labs / 3deployment-prep (beta): sync articles from production wikis (css/gadgets) - 10https://bugzilla.wikimedia.org/49779 (10Antoine "hashar" Musso (WMF)) [14:20:24] 3Wikimedia Labs / 3deployment-prep (beta): Make deployment prep have continuous replication lag - 10https://bugzilla.wikimedia.org/57583#c2 (10Antoine "hashar" Musso (WMF)) p:5Unprio>3Lowest Marking to lowest priority since nobody is sponsoring this for now. [14:21:38] 3Wikimedia Labs / 3deployment-prep (beta): Lock wait timeout error on beta enwiki - 10https://bugzilla.wikimedia.org/59751#c2 (10Antoine "hashar" Musso (WMF)) 5NEW>3RESO/FIX Seems it was some transient issue back in January. [14:22:52] 3Wikimedia Labs / 3deployment-prep (beta): Configure all deployment-prep instances to use local salt and puppet master by default - 10https://bugzilla.wikimedia.org/62795#c4 (10Antoine "hashar" Musso (WMF)) p:5Unprio>3High We still need to have to set the configuration manually. Pointing to the local p... [14:25:54] 3Wikimedia Labs / 3deployment-prep (beta): `sql` does not work on deployment-prep - 10https://bugzilla.wikimedia.org/63803#c6 (10Antoine "hashar" Musso (WMF)) 5NEW>3RESO/FIX That has been fixed somehow :-) [14:27:09] 3Wikimedia Labs / 3deployment-prep (beta): false "wiki is read-only mode" message in beta labs - 10https://bugzilla.wikimedia.org/65228#c7 (10Antoine "hashar" Musso (WMF)) 5NEW>3RESO/FIX It seems the main issue was the database lag that would cause MediaWiki to switch readonly. The threshold has been ra... [14:28:11] 3Wikimedia Labs / 3deployment-prep (beta): beta labs no longer listens for HTTPS - 10https://bugzilla.wikimedia.org/68387 (10Antoine "hashar" Musso (WMF)) [14:28:11] 3Wikimedia Labs / 3deployment-prep (beta): Reenable $wgMWOAuthSecureTokenTransfer=true; - 10https://bugzilla.wikimedia.org/65421#c1 (10Antoine "hashar" Musso (WMF)) p:5Unprio>3Low s:5normal>3enhanc Blocked by Bug 68387 - beta labs no longer listens for HTTPS [14:30:43] 3Wikimedia Labs / 3deployment-prep (beta): Submitting Special:ChangePassword gives Internal error - 10https://bugzilla.wikimedia.org/63396#c4 (10Antoine "hashar" Musso (WMF)) *** Bug 66401 has been marked as a duplicate of this bug. *** [14:30:43] 3Wikimedia Labs / 3deployment-prep (beta): Beta cluster centralauth accounts points to no more existing wikis - 10https://bugzilla.wikimedia.org/66401#c3 (10Antoine "hashar" Musso (WMF)) 5NEW>3RESO/DUP That is a duplicate of Bug 63396 - Submitting Special:ChangePassword gives Internal error. The bug eve... [14:31:08] 3Wikimedia Labs / 3deployment-prep (beta): Beta cluster centralauth accounts points to no more existing wikis - 10https://bugzilla.wikimedia.org/63396#c5 (10Antoine "hashar" Musso (WMF)) Reusing topic of duplicate bug 66401 [14:32:14] Project browsertests-Wikidata-SmokeTests-linux-firefox-sauce build #27: FAILURE in 15 min: https://integration.wikimedia.org/ci/job/browsertests-Wikidata-SmokeTests-linux-firefox-sauce/27/ [14:33:54] 3Wikimedia Labs / 3deployment-prep (beta): Requested 115.108.187.192.proxies.dnsbl.sorbs.net., not found in proxies.dnsbl.sorbs.net.. - 10https://bugzilla.wikimedia.org/71894#c5 (10Antoine "hashar" Musso (WMF)) 5NEW>3RESO/WOR The message is logged from includes/User.php: if ( $ipList ) { wfDebugLog(... [14:35:09] 3Wikimedia Labs / 3deployment-prep (beta): ferm policy on deployment-bastion prevents scap rsync from mw hosts - 10https://bugzilla.wikimedia.org/70858#c1 (10Antoine "hashar" Musso (WMF)) 5NEW>3RESO/FIX That was solved since scap works now :) [14:37:38] 3Wikimedia Labs / 3deployment-prep (beta): Yell loudly of failed puppet runs on Beta Cluster instances - 10https://bugzilla.wikimedia.org/67333#c7 (10Antoine "hashar" Musso (WMF)) We now have notifications on irc channel #wikimedia-qa and a few people receives an hourly mail until all instances pass puppet.... [14:38:54] 3Wikimedia Labs / 3deployment-prep (beta): Yell loudly of failed puppet runs on Beta Cluster instances - 10https://bugzilla.wikimedia.org/67333#c8 (10Antoine "hashar" Musso (WMF)) Blocks Bug 51497 - Setup monitoring for Beta cluster [14:38:54] 3Wikimedia Labs / 3deployment-prep (beta): Setup monitoring for Beta cluster - 10https://bugzilla.wikimedia.org/51497 (10Antoine "hashar" Musso (WMF)) [14:39:54] 3Wikimedia Labs / 3deployment-prep (beta): sync-site-resources should sync all Labs wikis - 10https://bugzilla.wikimedia.org/49791 (10Antoine "hashar" Musso (WMF)) p:5Normal>3Lowest [14:40:08] 3Wikimedia Labs / 3deployment-prep (beta): sync articles from production wikis (css/gadgets) - 10https://bugzilla.wikimedia.org/49779 (10Antoine "hashar" Musso (WMF)) p:5Normal>3Lowest [14:40:23] 3Wikimedia Labs / 3deployment-prep (beta): automatically import some content from production (tracking) - 10https://bugzilla.wikimedia.org/52382 (10Antoine "hashar" Musso (WMF)) p:5Normal>3Lowest [14:45:39] 3Wikimedia Labs / 3deployment-prep (beta): easily reload all apaches - 10https://bugzilla.wikimedia.org/36422#c20 (10Antoine "hashar" Musso (WMF)) 5NEW>3RESO/FIX Seems it is fixed now :) Thank you Bryan. [14:46:08] 3Wikimedia Labs / 3deployment-prep (beta): sync Sandbox gadget from production to en.wikipedia.beta.wmflabs.org - 10https://bugzilla.wikimedia.org/47205 (10Antoine "hashar" Musso (WMF)) p:5Normal>3Lowest [14:46:53] 3Wikimedia Labs / 3deployment-prep (beta): GettingStarted extension broken at beta.wmflabs.org - 10https://bugzilla.wikimedia.org/51362 (10Antoine "hashar" Musso (WMF)) p:5Unprio>3Low [14:48:53] 3Wikimedia Labs / 3deployment-prep (beta): monitor that application servers are responding - 10https://bugzilla.wikimedia.org/52867#c6 (10Antoine "hashar" Musso (WMF)) s:5critic>3enhanc Resetting severity. If it was really critical it would have been fixed long ago. Yuvi Panda is working on integrating... [14:50:55] 3Wikimedia Labs / 3deployment-prep (beta): wrong links on file pages on beta labs for instant commons images - 10https://bugzilla.wikimedia.org/57122#c1 (10Antoine "hashar" Musso (WMF)) 5NEW>3RESO/WON The analysis is correct, the image description comes from production commons and thus reuse whatever tem... [14:52:23] 3Wikimedia Labs / 3deployment-prep (beta): Detect image loading from production, pull those images into beta cluster - 10https://bugzilla.wikimedia.org/61784#c3 (10Antoine "hashar" Musso (WMF)) 5NEW>3RESO/WOR We do have instant commons and the foreignApi backend file system of doom. So in theory all imag... [14:54:08] 3Wikimedia Labs / 3deployment-prep (beta): Caching makes it impossible to test JS changes when logged out - 10https://bugzilla.wikimedia.org/63034#c5 (10Antoine "hashar" Musso (WMF)) Sam, any clue how we invalidate the JS/CSS cache on the bits cache when doing production deployment? I am assuming it expire... [14:58:09] 3Wikimedia Labs / 3deployment-prep (beta): Beta Cluster stopped receiving code updates (beta-update-databases-eqiad hung) - 10https://bugzilla.wikimedia.org/70597#c9 (10Antoine "hashar" Musso (WMF)) That happened again on Oct 23 2014. Looking at Jenkins thread dumps, the deployment-bastion execute thread ar... [14:58:39] 3Wikimedia Labs / 3deployment-prep (beta): Install and configure pool counter - 10https://bugzilla.wikimedia.org/70940 (10Antoine "hashar" Musso (WMF)) p:5Unprio>3Low [14:59:08] 3Wikimedia Labs / 3deployment-prep (beta): monitor unsigned salt keys - 10https://bugzilla.wikimedia.org/70862 (10Antoine "hashar" Musso (WMF)) p:5Unprio>3Low s:5normal>3enhanc [15:00:28] 3Wikimedia Labs / 3deployment-prep (beta): monitor unsigned salt keys - 10https://bugzilla.wikimedia.org/70862#c5 (10Ariel T. Glenn) no autoacceptance in the works? That would take care of the problem. [15:08:23] (03CR) 10Ricordisamoa: "Note that the latest stable version appears to be 4.3.4 now." [integration/phpunit] - 10https://gerrit.wikimedia.org/r/151252 (owner: 10EBernhardson) [15:25:53] 3Wikimedia Labs / 3deployment-prep (beta): Beta cluster centralauth accounts points to no longer existing wikis - 10https://bugzilla.wikimedia.org/63396 (10Alex Monk) [15:29:52] 3Wikimedia / 3Quality Assurance: ZeroPortal browsertests fails early due to auth issue with zero.wikimedia.org - 10https://bugzilla.wikimedia.org/72326#c5 (10Antoine "hashar" Musso (WMF)) > @hashar, by the way, is there a way to ensure these CI tests run over > https:// at all times? The mw-api-siteinfo.py... [15:34:09] gotta leave end of the day [16:25:38] 3Wikimedia Labs / 3deployment-prep (beta): Beta cluster centralauth accounts points to no longer existing wikis - 10https://bugzilla.wikimedia.org/63396#c6 (10Alex Monk) There's some slightly weird cases around the code I posted. Some quotes from IRC so they aren't missed. on deployment-prep, if I... [16:26:09] 3Wikimedia Labs / 3deployment-prep (beta): Beta cluster centralauth accounts points to no longer existing wikis - 10https://bugzilla.wikimedia.org/63396#c7 (10Alex Monk) (Additionally, centralauth.localnames/localusers seems to have a ton of references to wikis that AFAIK have never been in deployment-prep?) [16:34:38] 3Wikimedia Labs / 3deployment-prep (beta): Configure all deployment-prep instances to use local salt and puppet master by default - 10https://bugzilla.wikimedia.org/62795#c5 (10Bryan Davis) Both salt and puppet 3Wikimedia Labs / 3deployment-prep (beta): Caching makes it impossible to test JS changes when logged out - 10https://bugzilla.wikimedia.org/63034#c6 (10Krinkle) So far this bug has failed to give any clear definition of what kind of resources this is about. Are we talking about static resources served dire... [17:31:24] 3Wikimedia Labs / 3deployment-prep (beta): Caching makes it impossible to test JS changes when logged out - 10https://bugzilla.wikimedia.org/63034#c7 (10Krinkle) So yeah, what resources are we talking about, in what way are they not being invalidated, and how is it different from production? [17:33:37] greg-g: It seems Jenkins failing are becoming more frequent (almost like contractions, yikes). I think maybe Antoine and I should be relieved from other duties for a serious (short term) assignment to get things back on track before they get worse. Mostly to figure out what makes things disconnect between gearman/gerrit/zuul/jenkins (and once we know, to fix it, even if that means patching zuul upstream [17:33:38] , because upstream clearly isn't helping enough), and the other bug where zuul get stuck indefinitely due to a pipeline error somewhere. Both of which are currentyl mitigated by restarting Zuul or jenkins respecitively. [17:34:52] Right now I'm spending almost 2-3 hours a week just fighting random fires as they come up each time not knowing what it is and eventually filing bug reports that don't get fixed and restarting the system losing all queues. [17:51:50] Krinkle: you don't have to convince me too hard on that. Let me know if you want me to talk to James [17:52:13] greg-g: More worried about Antoine's duties than my own. [17:52:42] Or maybe we're both imagining we're not supposed to work on that we just need to tell you we're going to do it :) [17:52:45] yeah, I'll chat with him and we'll figure it out, but generally, I'm happy to have him devoted to that [17:52:54] OK [17:52:55] JDFI :) [17:53:03] er JFDI [17:57:18] greg-g: Krinkle fwiw, we've been noticing: https://bugzilla.wikimedia.org/show_bug.cgi?id=70049 [18:03:55] (03CR) 10Dduvall: [C: 04-1] "The style guide allows for either format of multi-line method chaining as long as it's consistent within a project. Until we make a decisi" [ruby/api] - 10https://gerrit.wikimedia.org/r/168281 (https://bugzilla.wikimedia.org/63307) (owner: 10Zfilipin) [18:18:08] Project beta-scap-eqiad build #26910: FAILURE in 9 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/26910/ [18:22:39] (03CR) 10Krinkle: "Hm.. isn't there a way to provide the publisher from the same macro? Or does 'publisher' always overwrite? Would be nice to not have to du" [integration/config] - 10https://gerrit.wikimedia.org/r/168566 (https://bugzilla.wikimedia.org/71128) (owner: 10Hashar) [18:23:53] Yippee, build fixed! [18:23:54] Project beta-scap-eqiad build #26911: FIXED in 1 min 14 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/26911/ [18:29:14] Request: GET http://meta.wikimedia.beta.wmflabs.org/wiki/Special:SpecialPages, from 127.0.0.1 via deployment-cache-text02 deployment-cache-text02 ([127.0.0.1]:3128), Varnish XID 281962437 [18:29:14] Forwarded for: 76.103.130.60, 127.0.0.1 [18:29:14] Error: 503, Service Unavailable at Fri, 24 Oct 2014 18:28:47 GMT [18:29:19] something's broken? [18:37:05] Project browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-windows_7-internet_explorer-11-sauce build #34: FAILURE in 35 min: https://integration.wikimedia.org/ci/job/browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-windows_7-internet_explorer-11-sauce/34/ [18:55:13] hi marxarelli do you have a couple minutes for a code review question? it's https://gerrit.wikimedia.org/r/#/c/168420/ in the steps file, I wonder if it is clear what the begin/rescue clauses are doing there [18:59:05] chrismcmahon: hmm... big improvement over what it was but i'm iffy about using rescue there [18:59:40] marxarelli: that's the convention I know. basically I want to set the state of the page-watch button regardless of what the initial state is [19:00:32] chrismcmahon: i would use a conditional instead though i'm not sure what the "cleanest" conditional would be in this case [19:00:36] marxarelli: (side note: I want to use this test as a gentle poster child for how not to abuse the framework) [19:01:39] marxarelli: I'd far prefer rescue over a conditional, because it will never be ambiguous [19:01:40] chrismcmahon: as a user looking at the ui, how do you determine if you're already watching the flow board? [19:02:44] marxarelli: the star in the upper-right corner of the page is either clear or colored (green I think). except that it is broken in beta labs now [19:02:54] * chrismcmahon files a second bug for Flow [19:03:06] chrismcmahon: i think if we can find the right conditional, it will be clearer with a conditional (just one, not the monstrosity that it was :) [19:04:52] marxarelli: let's think this through. it'd have to be "if page is watched/then do nothing/else click watch-page" and the converse. (reverse? whatever) [19:04:55] so, could you just define an element called board_status_watched and do the following? "unless page.board_status_watched.present?" [19:05:05] right [19:06:48] I see your point, I just like imperatives over conditionals in UI tests whenever possible. I'll do that "unless" thing though. [19:07:35] yeah, try it out. i just tend to avoid rescue-ing for implementation whenever i can [19:10:08] chrismcmahon: if the logic for checking the board status is too complex to be readable i would consider using an instance method of FlowPage. e.g. on(FlowPage) { |page| page.board_unwatch_element.click if page.board_watched? } [19:10:31] and implement #board_watched? in whatever way is least brittle [19:11:00] marxarelli: I don't think it's complex, I just don't like conditionals in UI tests. probably a character flaw on my part. [19:11:21] chrismcmahon: yeah, i hear ya [19:11:30] I like your "unless" suggestion the best, I think I'll do that [19:12:01] chrismcmahon: but remember that rescues introduce additional code paths too [19:12:12] true [19:12:46] i think it's safe to say "avoid conditionals when possible" [19:12:58] yep [19:15:47] anyway, let me emphasize how nice it is that we're in a position to debate such fine points of style. :-) [19:16:20] Project browsertests-UniversalLanguageSelector-sandbox.translatewiki.net-linux-firefox-sauce build #217: FAILURE in 7.7 sec: https://integration.wikimedia.org/ci/job/browsertests-UniversalLanguageSelector-sandbox.translatewiki.net-linux-firefox-sauce/217/ [19:44:23] 3Wikimedia Labs / 3deployment-prep (beta): no log in deployment-bastion:/data/project/logs from "503 server unavailable" on beta labs - 10https://bugzilla.wikimedia.org/72275#c2 (10spage) p:5Normal>3High (In reply to Antoine "hashar" Musso (WMF) from comment #1) > udp2log / python demux script crash fr... [19:51:07] 3Wikimedia Labs / 3deployment-prep (beta): SpecialCite's i18n is still being loaded which is breaking CiteThisPage in BetaLabs - 10https://bugzilla.wikimedia.org/71112 (10Greg Grossmeier) 5PATC>3NEW p:5Unprio>3Normal [19:51:08] 3Wikimedia Labs / 3deployment-prep (beta): SpecialCite's i18n is still being loaded which is breaking CiteThisPage in BetaLabs - 10https://bugzilla.wikimedia.org/71112 (10Greg Grossmeier) 5NEW>3PATC [19:51:54] 3Wikimedia Labs / 3deployment-prep (beta): SpecialCite's i18n is still being loaded which is breaking CiteThisPage in BetaLabs - 10https://bugzilla.wikimedia.org/71112 (10Greg Grossmeier) a:3James Forrester [19:52:08] 3Wikimedia Labs / 3deployment-prep (beta): SpecialCite's i18n is still being loaded which is breaking CiteThisPage in BetaLabs - 10https://bugzilla.wikimedia.org/71112#c4 (10Greg Grossmeier) Planned for Tuesday Oct 28th (this coming Tuesday) [19:52:52] 3Wikimedia Labs / 3deployment-prep (beta): no log in deployment-bastion:/data/project/logs from "503 server unavailable" on beta labs - 10https://bugzilla.wikimedia.org/72275#c3 (10Antoine "hashar" Musso (WMF)) I haven't took time to properly investigate the issue. But recently we had a new udp2log-mw insta... [19:55:34] Yippee, build fixed! [19:55:34] Project browsertests-UploadWizard-commons.wikimedia.beta.wmflabs.org-linux-firefox-sauce build #261: FIXED in 8 min 4 sec: https://integration.wikimedia.org/ci/job/browsertests-UploadWizard-commons.wikimedia.beta.wmflabs.org-linux-firefox-sauce/261/ [20:11:53] 3Wikimedia Labs / 3deployment-prep (beta): no log in deployment-bastion:/data/project/logs from "503 server unavailable" on beta labs - 10https://bugzilla.wikimedia.org/72275#c4 (10spage) (In reply to spage from comment #2) > We also have an instance udplog.eqiad.wmflabs There's also a deployment-fluoride... [20:32:36] (03CR) 10Hashar: [C: 04-1] "So this change is on hold till we agree on a set of conventions to enforce on all repositories :-D" [integration/config] - 10https://gerrit.wikimedia.org/r/168061 (https://bugzilla.wikimedia.org/69245) (owner: 10Zfilipin) [20:32:45] Project beta-scap-eqiad build #26925: FAILURE in 5 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/26925/ [20:47:27] my bet it is a DNS issue [20:47:58] 00:00:04.997 CalledProcessError: Command '/usr/local/bin/mwscript mergeMessageFileList.php --wiki="eowiki" --list-file="/srv/mediawiki-staging/wmf-config/extension-list" --output="/tmp/tmp.xBirjj6h56" ' returned non-zero exit status 1 [20:48:02] there is no error output :/ [20:49:07] Reedy: ^ help? [20:49:58] what if you run it manually? [20:52:51] haven't try [20:53:08] need to look at the upstream job that refresh the repositories [20:53:25] https://integration.wikimedia.org/ci/job/beta-mediawiki-config-update-eqiad/1277/console [20:54:07] * d05ddec - (gerrit/master) Adding WikiGrok to extensions list for testing on Beta Labs (30 minutes ago) [20:54:10] that would be that one [20:54:18] I bet it is not registered in mediawiki/extensions.git :D [20:54:56] hashar: Reedy see https://bugzilla.wikimedia.org/show_bug.cgi?id=72465 [20:55:03] comment there [20:56:18] I commented on the change as well https://gerrit.wikimedia.org/r/#/c/168688/ [20:56:24] refreshing the extensions rightnow [20:56:25] * greg-g nods [20:57:37] beta labs does not seem to be updating to latest Flow master, is this what you're working on? [20:57:51] spagewmf: yeah broken as per above [20:58:12] I am trying to commit the change that will fix it :D [21:01:14] https://gerrit.wikimedia.org/r/168694 [21:02:16] spagewmf: extension management is hard, yo [21:05:33] solved apparently https://integration.wikimedia.org/ci/job/beta-scap-eqiad/26929/console [21:05:38] Yippee, build fixed! [21:05:39] Project beta-scap-eqiad build #26929: FIXED in 1 min 22 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/26929/ [21:05:43] \O/ [21:06:14] :) :) [21:06:19] thanks hashar [21:06:28] and Reedy :) [21:06:35] spagewmf: ^ [21:09:18] that being fixed, I am off! [21:09:24] have a safe week-end [21:22:45] soooo.... [21:22:51] is anyone else getting the error I still am? [21:23:01] http://meta.wikimedia.beta.wmflabs.org/wiki/Special:SpecialPages [22:45:40] Yippee, build fixed! [22:45:41] Project browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-windows_7-internet_explorer-9-sauce build #88: FIXED in 42 min: https://integration.wikimedia.org/ci/job/browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-windows_7-internet_explorer-9-sauce/88/ [23:16:34] Yippee, build fixed! [23:16:35] Project browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-linux-chrome-sauce build #245: FIXED in 28 min: https://integration.wikimedia.org/ci/job/browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-linux-chrome-sauce/245/ [23:37:32] Project browsertests-UniversalLanguageSelector-commons.wikimedia.beta.wmflabs.org-linux-firefox-sauce build #239: FAILURE in 23 min: https://integration.wikimedia.org/ci/job/browsertests-UniversalLanguageSelector-commons.wikimedia.beta.wmflabs.org-linux-firefox-sauce/239/ [23:43:54] 3Wikimedia / 3Continuous integration: Jenkins mobile QUnit always -1ing patches in MobileFrontend - 10https://bugzilla.wikimedia.org/72505 (10Jon) 3NEW p:3Unprio s:3normal a:3None We can't merge in MobileDrontend For example: https://gerrit.wikimedia.org/r/168663 https://gerrit.wikimedia.org/r/16871...