[00:21:58] 3Wikimedia Labs / 3deployment-prep (beta): Beta Cluster stopped receiving code updates (beta-update-databases-eqiad hung) - 10https://bugzilla.wikimedia.org/70597#c10 (10Bryan Davis) a:5Bryan Davis>3None Un-licking this cookie. I took a shot at it but the problem seems to be deeper in the stack. [01:03:41] 3Wikimedia Labs / 3deployment-prep (beta): Beta Cluster stopped receiving code updates (beta-update-databases-eqiad hung) - 10https://bugzilla.wikimedia.org/70597#c11 (10Antoine "hashar" Musso (WMF)) I forgot to update this bug after my debugging session on Oct 24th here is the rough brain dump: The Gearman... [03:39:05] Yippee, build fixed! [03:39:05] Project browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-windows_7-internet_explorer-11-sauce build #46: FIXED in 37 min: https://integration.wikimedia.org/ci/job/browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-windows_7-internet_explorer-11-sauce/46/ [04:37:39] Project browsertests-Echo-en.wikipedia.beta.wmflabs.org-linux-firefox-sauce build #156: FAILURE in 10 min: https://integration.wikimedia.org/ci/job/browsertests-Echo-en.wikipedia.beta.wmflabs.org-linux-firefox-sauce/156/ [05:03:56] Project browsertests-CirrusSearch-test2.wikipedia.org-linux-firefox-sauce build #234: FAILURE in 1 min 26 sec: https://integration.wikimedia.org/ci/job/browsertests-CirrusSearch-test2.wikipedia.org-linux-firefox-sauce/234/ [06:01:15] YuviPanda: how to add notification from Gerrit on IRC for repository? [06:01:41] YuviPanda: repo here is mediawiki/services/cxserver/deploy to #mediawiki-i18n [06:18:57] 3Wikimedia / 3Continuous integration: Augment jsonlint test with a test for duplicate keys - 10https://bugzilla.wikimedia.org/71284#c13 (10Yuri Astrakhan) Seems like it does. Didn't think it required such an elaborate python code though! And thanks!!! :) [06:42:57] PROBLEM - CI: Puppet failure events on labmon1001 is CRITICAL: CRITICAL: integration.integration-puppetmaster.puppetagent.failed_events.value (33.33%) [07:06:49] RECOVERY - CI: Puppet failure events on labmon1001 is OK: OK: All targets OK [08:01:38] Yippee, build fixed! [08:01:39] Project browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-linux-chrome-sauce build #258: FIXED in 26 min: https://integration.wikimedia.org/ci/job/browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-linux-chrome-sauce/258/ [12:00:27] 3Wikimedia / 3Quality Assurance: Quality Assurance/Browser testing/Setup instructions is out of date - 10https://bugzilla.wikimedia.org/72732 (10Andre Klapper) p:5Unprio>3Normal [13:58:10] (03PS1) 10Hashar: Only test Jenkins jobs existence on gate-and-submit [integration/config] - 10https://gerrit.wikimedia.org/r/170320 [13:59:15] (03CR) 10Hashar: "I am not self merging this, I would like people to have a look at it :-D" [integration/config] - 10https://gerrit.wikimedia.org/r/170320 (owner: 10Hashar) [14:01:38] (03CR) 10jenkins-bot: [V: 04-1] Only test Jenkins jobs existence on gate-and-submit [integration/config] - 10https://gerrit.wikimedia.org/r/170320 (owner: 10Hashar) [14:04:41] (03PS1) 10Hashar: Only trigger JJB config diff when changed [integration/config] - 10https://gerrit.wikimedia.org/r/170323 [14:08:00] (03CR) 10jenkins-bot: [V: 04-1] Only trigger JJB config diff when changed [integration/config] - 10https://gerrit.wikimedia.org/r/170323 (owner: 10Hashar) [14:17:16] (03CR) 10Hashar: "And the job fails because:" [integration/config] - 10https://gerrit.wikimedia.org/r/170320 (owner: 10Hashar) [14:19:03] (03PS2) 10Hashar: Only trigger JJB config diff when changed [integration/config] - 10https://gerrit.wikimedia.org/r/170323 [14:34:55] manybubbles: I am in the hangout [15:22:35] (03CR) 10EBernhardson: "bump? how do i get these things reviewed?" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/163898 (owner: 10EBernhardson) [15:23:31] who are the "owners" of codesniffer, who do a ask for reviews from? [15:26:38] after a month of no reviews, can i just self merge? [15:45:52] (03CR) 10Cscott: "Going to do that now." [integration/config] - 10https://gerrit.wikimedia.org/r/170031 (owner: 10Cscott) [15:47:08] ebernhardson: did you look at the git log to see who reviewed previous patches? [15:48:47] ebernhardson: I know hashar is active on today, although he's not on irc, maybe poke him via email. [15:49:59] ebernhardson: chadh also +2ed a previous patch to codesniffer, i added him as a reviewer for you. [15:58:24] Project browsertests-Wikidata-WikidataTests-linux-firefox-sauce build #25: STILL FAILING in 1 hr 36 min: https://integration.wikimedia.org/ci/job/browsertests-Wikidata-WikidataTests-linux-firefox-sauce/25/ [16:05:26] (03CR) 10Cscott: "recheck" [integration/config] - 10https://gerrit.wikimedia.org/r/170031 (owner: 10Cscott) [16:13:39] cscott: thanks! [16:38:37] (03CR) 10Cscott: "Hm, jenkins doesn't seem to be picking up the recheck." [integration/config] - 10https://gerrit.wikimedia.org/r/170031 (owner: 10Cscott) [16:39:00] (03PS2) 10Cscott: Add jenkins/zuul jobs for OCG ZIM backend. [integration/config] - 10https://gerrit.wikimedia.org/r/170031 [17:05:49] (03CR) 10Cscott: "Ok, it looks like deploying the two new jobs in this patch to jenkins might have triggered https://www.mediawiki.org/wiki/Continuous_integ" [integration/config] - 10https://gerrit.wikimedia.org/r/170031 (owner: 10Cscott) [17:10:05] Looks like some Android build jobs are stuck in Zuul's check-voter for 40+ min. Can anyone here help the jobs along? [17:13:07] !log bouncing zuul in jenkins as per https://www.mediawiki.org/wiki/Continuous_integration/Zuul#Known_issues [17:13:09] Logged the message, Master [17:20:23] thanks godog [17:21:10] yw, got a chance to see it while it was stuck, the failure mode is curious [17:31:47] (03CR) 10Cscott: [C: 032] "Deploying to zuul now." [integration/config] - 10https://gerrit.wikimedia.org/r/170031 (owner: 10Cscott) [17:33:34] bearND: zuul was stuck for a while, should be going now (thanks to godog) [17:35:10] (03Merged) 10jenkins-bot: Add jenkins/zuul jobs for OCG ZIM backend. [integration/config] - 10https://gerrit.wikimedia.org/r/170031 (owner: 10Cscott) [17:37:51] cscott: thank you. I see the queue is empty now. What's the best way to retrigger the two jobs associated with https://gerrit.wikimedia.org/r/170321 and https://gerrit.wikimedia.org/r/#/c/170332/? [17:38:05] and thanks to godog [17:38:24] bearND: make a comment on the patch with just the text "recheck" [17:38:52] bearND: but it looks to me like jenkins already ran successfully there [17:39:02] np bearND cscott [17:40:01] cscott: ah, good. I pushed a new commit (just different commit message), and was hoping that this would trigger it but it took so long that i thought it wouldn't [17:42:31] bearND: https://gerrit.wikimedia.org/r/170332 isn't being merged because it has an outdated (and unmerged) dependency [17:43:01] bearND: you need to rebase it. [17:43:23] bearND: looks like you figured that out already. [17:45:00] cscott: yeah. One question remains: I had +2'd it earlier. Usually that means it gets merged automatically. Should I hit the submit button in this case? [17:45:50] bearND: i was just looking at that. [17:46:55] bearND: looks like i just needed another +2 [17:47:04] s/i just/it just/ [17:47:20] cscott: cool. Thanks! [18:39:59] Project browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-windows_7-internet_explorer-11-sauce build #47: FAILURE in 37 min: https://integration.wikimedia.org/ci/job/browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-windows_7-internet_explorer-11-sauce/47/ [19:35:29] 3Wikimedia / 3Continuous integration: mediawiki-core-doxygen-publish job needs mediawiki/vendor - 10https://bugzilla.wikimedia.org/72826 (10Bryan Davis) 3NEW p:3Unprio s:3normal a:3None Building remotely on gallium (hasContintPackages hasPhpUnit hasSlaveScripts hasPhpcs hasAndroidSdk productionSlaves... [19:37:22] Yippee, build fixed! [19:37:23] Project browsertests-Echo-en.wikipedia.beta.wmflabs.org-linux-firefox-sauce build #157: FIXED in 11 min: https://integration.wikimedia.org/ci/job/browsertests-Echo-en.wikipedia.beta.wmflabs.org-linux-firefox-sauce/157/ [19:46:42] (03PS1) 10BryanDavis: Clone mediawiki/vendor for mediawiki-core-doxygen-publish [integration/config] - 10https://gerrit.wikimedia.org/r/170386 (https://bugzilla.wikimedia.org/72826) [19:52:57] Project beta-scap-eqiad build #27887: FAILURE in 0.29 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/27887/ [19:55:14] Yippee, build fixed! [19:55:15] Project beta-scap-eqiad build #27888: FIXED in 1 min 11 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/27888/ [20:02:10] (03CR) 10Hashar: "That is worth a try :-) You can deploy the job and see what happens before merging this change. See details inline." (031 comment) [integration/config] - 10https://gerrit.wikimedia.org/r/170386 (https://bugzilla.wikimedia.org/72826) (owner: 10BryanDavis) [20:21:01] Project browsertests-Echo-en.wikipedia.beta.wmflabs.org-linux-chrome-sauce build #140: FAILURE in 8 min 5 sec: https://integration.wikimedia.org/ci/job/browsertests-Echo-en.wikipedia.beta.wmflabs.org-linux-chrome-sauce/140/ [20:22:09] Yippee, build fixed! [20:22:10] Project browsertests-CirrusSearch-test2.wikipedia.org-linux-firefox-sauce build #235: FIXED in 1 min 37 sec: https://integration.wikimedia.org/ci/job/browsertests-CirrusSearch-test2.wikipedia.org-linux-firefox-sauce/235/ [20:33:32] (03PS2) 10BryanDavis: Clone mediawiki/vendor for mediawiki-core-doxygen-publish [integration/config] - 10https://gerrit.wikimedia.org/r/170386 (https://bugzilla.wikimedia.org/72826) [20:34:25] (03CR) 10BryanDavis: [C: 032] "Deployed and verified with https://integration.wikimedia.org/ci/job/mediawiki-core-doxygen-publish/7644/" [integration/config] - 10https://gerrit.wikimedia.org/r/170386 (https://bugzilla.wikimedia.org/72826) (owner: 10BryanDavis) [20:37:46] (03Merged) 10jenkins-bot: Clone mediawiki/vendor for mediawiki-core-doxygen-publish [integration/config] - 10https://gerrit.wikimedia.org/r/170386 (https://bugzilla.wikimedia.org/72826) (owner: 10BryanDavis) [20:39:43] 3Wikimedia / 3Continuous integration: mediawiki-core-doxygen-publish job needs mediawiki/vendor - 10https://bugzilla.wikimedia.org/72826 (10Bryan Davis) 5PATC>3RESO/FIX p:5Unprio>3High a:3Bryan Davis [20:44:17] (03CR) 10Hashar: "bd808 hurrah!" [integration/config] - 10https://gerrit.wikimedia.org/r/170386 (https://bugzilla.wikimedia.org/72826) (owner: 10BryanDavis) [20:47:14] 3Wikimedia / 3Continuous integration: Jenkins: migrate mediawiki-core-doxygen-publish to zuul cloner - 10https://bugzilla.wikimedia.org/72837 (10Antoine "hashar" Musso (WMF)) 3NEW p:3Unprio s:3enhanc a:3None mediawiki-core-doxygen-publish invokes maintenance/mwdocgen.php which thus depends on mediawi... [21:16:36] (03PS1) 10Dduvall: Removed Environment#bind [selenium] - 10https://gerrit.wikimedia.org/r/170439 [21:16:38] (03PS1) 10Dduvall: Custom page factory for "on-demand" browser [selenium] - 10https://gerrit.wikimedia.org/r/170440 [21:26:38] marxarelli: that is a lot of patches to review :D [21:27:06] hashar: yeah, i know. what's more is that only the last patch is stable enough to use :) [21:27:19] ho it is fine [21:27:24] I like small commits [21:27:29] easier to review and get merged [21:29:00] hashar: and i think the review process can be more liberal seeing as they're on an experimental remote branch [21:29:21] on that note, looks like i screwed up and forgot the remote branch for git-review again... :/ [21:30:00] marxarelli: you should probably upgrade your git-review [21:30:11] or confirm your local branch is tracking a remote one [21:31:34] hashar: blurg. how do i fix it? [21:31:42] the pushed commits that is [21:32:02] if you pushed them to the master branch, you have to abandon them :D [21:32:12] crap. ok [21:32:20] * marxarelli is making a mess [21:32:50] (03Abandoned) 10Dduvall: Removed Environment#bind [selenium] - 10https://gerrit.wikimedia.org/r/170439 (owner: 10Dduvall) [21:32:58] (03Abandoned) 10Dduvall: Custom page factory for "on-demand" browser [selenium] - 10https://gerrit.wikimedia.org/r/170440 (owner: 10Dduvall) [21:33:39] you can find the remote branch using: git branch -vv|egrep '^\*' [21:33:46] i'm guessing i should `rebase -i` and change the change-ids? [21:34:28] you don't need to alter the change-ids [21:34:53] Gerrit uses the triplet (project, branch, change-id) to detect the related change number to attach a patchset to [21:35:06] so if you send the same change-id against a different branch, that creates a different change number [21:35:16] which is handy when you cherry pick patches between branches [21:35:26] (for example to backport a hot fix to a release branch) [21:35:41] got it. that makes sense [21:36:16] i will leave a trail of my incompetence :) [21:36:43] (03PS1) 10Dduvall: Removed Environment#bind [selenium] (env-abstraction-layer) - 10https://gerrit.wikimedia.org/r/170444 [21:36:45] (03PS1) 10Dduvall: Custom page factory for "on-demand" browser [selenium] (env-abstraction-layer) - 10https://gerrit.wikimedia.org/r/170445 [21:37:06] s/incompetence/freshman/ :D [21:37:52] :P [21:38:03] anddd [21:38:06] git-review does not work indeed [21:38:21] git push gerrit HEAD:refs/publish/master/env-abstraction-layer [21:38:21] :/ [21:40:39] AHHHHH [21:41:51] marxarelli: so git-review is not smart enough to look at the tracked branch but it has per repo configuration file to set the branch to use [21:42:02] in /.gitreview [21:42:06] defaultbranch=master [21:42:07] hashar: i saw that [21:42:20] so just replace it with your branch name and you will be fine :] [21:42:25] seems problematic as it will be merged with the commits [21:42:26] that will cause a trivial merge conflict later on [21:42:40] but that is easily solved :] [21:42:51] you can get it removed in the merge commit [21:43:01] true true [21:43:04] "I do it all the time" ™ [21:43:32] git-review is still guilty of not looking at the remote branch though :d [21:44:11] i almost feel like just learning the push commands. that way, i'm force to be a little more careful [21:44:40] I probably lost all my bookmarks pointing to nice git tutorials [21:45:06] ah [21:45:07] http://www.git-scm.com/book/en/v2 [21:45:10] highly recommended. [21:45:11] hashar: i'm comfortable enough with git. i think it's more about learning how gerrit organizes things [21:45:17] yeah, i love that book [21:45:19] specially chapter 3 about branching http://www.git-scm.com/book/en/v2/Git-Branching-Branches-in-a-Nutshell [21:45:51] I have attended a training given by Scott Chacon (then git evangelist at Github) [21:46:18] he basically presented git as a tree and you are the guys cutting the branches/leaves or repositioning them [21:46:27] that made everything straightforward [21:46:52] that analogy is especially good for explaining rebase i think [21:47:59] yup [21:48:39] (03PS1) 10Lewis Cawte: Tests for Bouquet skin. [integration/config] - 10https://gerrit.wikimedia.org/r/170447 [21:51:00] ah http://assets.en.oreilly.com/1/event/27/Git%20101%20Presentation.pdf [21:51:02] marxarelli: ^^^ [21:51:07] skip to about the middle of the document [21:51:13] that one is worth browsing [21:51:52] hashar: oh, neat. thankls [21:53:46] marxarelli: we should hangout together one day so I can show you the git tricks I have :D [21:54:16] hashar: sounds good :) [21:55:29] https://github.com/hashar/alix/blob/master/bashrc#L29-L44 [21:55:33] and my nice PS1 : PS1='\[\e]0;\u@'$(get_PS1_hostname)': \w\a\]\[\033['$(user_at_host_color)'\]\u@'$(get_PS1_hostname)'\[\033[00m\]:\[\033[01;36m\]\w\[\033[00m\]\[\033[00;32m\]$(parse_repo_branch)\[\033[00m\]\$ ' [21:55:37] slightly too long [21:56:22] I can't remember found the trick, the idea is to add in the prompt the local branch and its state (ex: it has 3 commits ahead of remote branch ) [21:59:55] I am off! good weekend [22:00:08] hashar: you too! [22:01:54] (03CR) 10Hashar: "That will create the jobs. You also need to have them triggered by Zuul via zuul/layout.yaml" [integration/config] - 10https://gerrit.wikimedia.org/r/170447 (owner: 10Lewis Cawte) [22:11:52] (03PS2) 10Lewis Cawte: Tests for Bouquet skin. [integration/config] - 10https://gerrit.wikimedia.org/r/170447 [22:12:00] (03CR) 10jenkins-bot: [V: 04-1] Tests for Bouquet skin. [integration/config] - 10https://gerrit.wikimedia.org/r/170447 (owner: 10Lewis Cawte) [22:14:23] ... uhh? [22:19:08] (03CR) 10Lewis Cawte: "Is it normal for the test to fail or are there other things I still have to do?" [integration/config] - 10https://gerrit.wikimedia.org/r/170447 (owner: 10Lewis Cawte) [22:38:07] Project browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-windows_7-internet_explorer-9-sauce build #102: FAILURE in 40 min: https://integration.wikimedia.org/ci/job/browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-windows_7-internet_explorer-9-sauce/102/ [22:49:09] Project browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-linux-chrome-sauce build #259: FAILURE in 10 min: https://integration.wikimedia.org/ci/job/browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-linux-chrome-sauce/259/ [22:57:58] 3Wikimedia / 3Continuous integration: Configure Rubocop and make it voting for the OOjs UI repo - 10https://bugzilla.wikimedia.org/72841 (10James Forrester) 3NEW p:3Unprio s:3normal a:3None We now have ruby in the OOjs UI repo, so we should enable Rubocop and make sure we're already passing it.