[02:39:46] (03PS1) 10Legoktm: Add labs-tools-extdist-tox-tests job [integration/config] - 10https://gerrit.wikimedia.org/r/172192 [02:42:58] (03CR) 10Legoktm: "This test requires an internet connection, so it has to be run on the labs slaves (iirc what hashar said on IRC), my reading of the python" [integration/config] - 10https://gerrit.wikimedia.org/r/172192 (owner: 10Legoktm) [08:26:11] 3Wikimedia Labs / 3deployment-prep (beta): File upload area resorts to 0777 permissions to for uploaded conent - 10https://bugzilla.wikimedia.org/73206#c2 (10Antoine "hashar" Musso (WMF)) We had system users created in LDAP already, bug 66575 for cxserver and bug 63329 for parsoid. Maybe we need to create i... [08:30:10] 3Wikimedia / 3Continuous integration: mediawiki-core-qunit test is flakey - 10https://bugzilla.wikimedia.org/73189#c2 (10Antoine "hashar" Musso (WMF)) 5NEW>3RESO/DUP The qunit test has been around for a long time, but there is a bug in MediaWiki which cause the suite to fail, most probably due to a race... [08:51:17] (03CR) 10Hashar: Add jobs for PyBal (031 comment) [integration/config] - 10https://gerrit.wikimedia.org/r/172180 (owner: 10Ori.livneh) [08:51:35] (03PS2) 10Hashar: Add jobs for PyBal [integration/config] - 10https://gerrit.wikimedia.org/r/172180 (owner: 10Ori.livneh) [08:56:36] (03CR) 10Hashar: [C: 032] "Thank you! Jobs deployed:" [integration/config] - 10https://gerrit.wikimedia.org/r/172180 (owner: 10Ori.livneh) [09:00:07] (03Merged) 10jenkins-bot: Add jobs for PyBal [integration/config] - 10https://gerrit.wikimedia.org/r/172180 (owner: 10Ori.livneh) [09:09:34] (03PS1) 10Hashar: Make debian-glue jobs runnable in parallel [integration/config] - 10https://gerrit.wikimedia.org/r/172209 [09:11:22] PROBLEM - BetaLabs: Low disk space on /var on labmon1001 is CRITICAL: CRITICAL: deployment-prep.deployment-mediawiki01.diskspace._var.byte_avail.value (33.33%) [09:13:16] (03CR) 10Hashar: [C: 032] "Jobs refreshed:" [integration/config] - 10https://gerrit.wikimedia.org/r/172209 (owner: 10Hashar) [09:16:46] (03Merged) 10jenkins-bot: Make debian-glue jobs runnable in parallel [integration/config] - 10https://gerrit.wikimedia.org/r/172209 (owner: 10Hashar) [09:22:52] zeljkof: whenever you have time, can you review this=> https://gerrit.wikimedia.org/r/#/c/171531/ [09:23:06] Project browsertests-UniversalLanguageSelector-commons.wikimedia.beta.wmflabs.org-linux-firefox-sauce build #272: FAILURE in 11 sec: https://integration.wikimedia.org/ci/job/browsertests-UniversalLanguageSelector-commons.wikimedia.beta.wmflabs.org-linux-firefox-sauce/272/ [09:23:12] hi vikasyaligar [09:23:26] zeljkof: Hello ! :) [09:24:12] vikasyaligar: sure, will take a look later today, probably in 30-60 minutes [09:24:16] just to finish something first [09:24:28] zeljkof: great ! thank you :) [09:25:59] PROBLEM - BetaLabs: Low disk space on / on labmon1001 is CRITICAL: CRITICAL: deployment-prep.deployment-mediawiki02.diskspace.root.byte_avail.value (22.22%) [09:33:37] RECOVERY - BetaLabs: Low disk space on / on labmon1001 is OK: OK: All targets OK [09:40:20] (03CR) 10Hashar: [C: 032 V: 032] "thanks" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/172000 (owner: 10Tim Landscheidt) [09:41:56] (03CR) 10Hashar: [C: 032 V: 032] "thanks" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/172001 (owner: 10Tim Landscheidt) [09:52:02] (03CR) 10Hashar: [C: 04-1] Add labs-tools-extdist-tox-tests job (031 comment) [integration/config] - 10https://gerrit.wikimedia.org/r/172192 (owner: 10Legoktm) [09:53:08] (03PS2) 10Hashar: Add labs-tools-extdist-tox-tests job [integration/config] - 10https://gerrit.wikimedia.org/r/172192 (owner: 10Legoktm) [09:53:24] (03CR) 10Hashar: "suffixed zuul triggers with '-trusty' to reflect the JJB change" [integration/config] - 10https://gerrit.wikimedia.org/r/172192 (owner: 10Legoktm) [09:53:29] (03PS3) 10Hashar: Add labs-tools-extdist-tox-tests job [integration/config] - 10https://gerrit.wikimedia.org/r/172192 (owner: 10Legoktm) [09:57:51] (03CR) 10Hashar: [C: 032] "Jobs deployed:" [integration/config] - 10https://gerrit.wikimedia.org/r/172192 (owner: 10Legoktm) [10:01:15] (03Merged) 10jenkins-bot: Add labs-tools-extdist-tox-tests job [integration/config] - 10https://gerrit.wikimedia.org/r/172192 (owner: 10Legoktm) [10:02:19] (03CR) 10Hashar: "Zuul reloaded :)" [integration/config] - 10https://gerrit.wikimedia.org/r/172192 (owner: 10Legoktm) [10:13:10] 3Wikimedia / 3Continuous integration: Jenkins: Don't trigger rubocop for changes that only modify php or js files - 10https://bugzilla.wikimedia.org/73077#c1 (10Antoine "hashar" Musso (WMF)) Seems we should only trigger it when .rubocop.* or .rb files are changed. In Zuul something like: jobs: - name: '^.... [10:19:10] 3Wikimedia / 3Continuous integration: Jenkins: QUnit job always -1ing patches in MobileFrontend - 10https://bugzilla.wikimedia.org/72505#c3 (10Antoine "hashar" Musso (WMF)) 5RESO/INV>3RESO/FIX Has been fixed by https://gerrit.wikimedia.org/r/#/c/168747/ "Remove deprecated call of SkinTemplate::outputPage... [10:21:23] (03CR) 10Zfilipin: "RuboCop configuration files are now in MediaWiki-Vagrant repository:" [integration/config] - 10https://gerrit.wikimedia.org/r/168270 (https://bugzilla.wikimedia.org/69245) (owner: 10Zfilipin) [10:23:32] (03CR) 10Zfilipin: [C: 04-1] "RuboCop is complaining:" [selenium] (env-abstraction-layer) - 10https://gerrit.wikimedia.org/r/172009 (owner: 10Dduvall) [10:29:42] (03CR) 10Zfilipin: [C: 04-1] "RuboCop is complaining:" [selenium] (env-abstraction-layer) - 10https://gerrit.wikimedia.org/r/172007 (owner: 10Dduvall) [10:30:42] (03CR) 10Zfilipin: [C: 04-1] "RuboCop is complaining:" [selenium] (env-abstraction-layer) - 10https://gerrit.wikimedia.org/r/171985 (owner: 10Dduvall) [10:51:44] vikasyaligar: the commit looks good to me [10:51:57] but you made rubocop unhappy :) [10:52:13] Let me check ... [10:52:27] vikasyaligar: let me know if you need help with rubocop [10:53:19] zeljkof: hmm; It is a bit confusing. Shouldn't jenkins-bot give -1 in that case ? [10:54:08] vikasyaligar: no, it is not voting for now [10:54:20] we have just introduced rubocop, last week I think [10:54:42] so we made it non voting for a few weeks, until we are sure it does not introduce problems [10:56:22] wow ! rubocop is awesome ! :) [10:59:15] vikasyaligar: yes it is :) [10:59:30] please notice --auto-fix option (or something like that) [11:00:33] wow ! let me read the documentation of rubocop [11:02:35] zeljkof: yay ! Auto correct worked :) [11:04:19] vikasyaligar: let me know when you push the change to gerrit [11:04:34] ok, I see it there [11:10:30] zeljkof: I think I shoudl make a seperate commit => https://integration.wikimedia.org/ci/job/mwext-VisualEditor-bundle-rubocop/213/console [11:10:33] *should [11:11:06] zeljkof: the rubocop complains about the files which I have not changed. [11:21:02] i and rubocop auto-correct have no clue on how to correct "Assignment Branch Condition size for crop_image is too high" offence :( [11:33:16] vikasyaligar: sorry, had to step away for a few minutes [11:33:33] ok, so rubocop complains about the files you did not change then, sorry, did not notice taht [11:33:35] that [11:43:25] Project browsertests-VisualEditor-language-screenshot-linux-firefox-sauce » nl,contintLabsSlave && UbuntuTrusty build #1: ABORTED in 21 sec: https://integration.wikimedia.org/ci/job/browsertests-VisualEditor-language-screenshot-linux-firefox-sauce/LANGUAGE_SCREENSHOT_CODE=nl,label=contintLabsSlave%20&&%20UbuntuTrusty/1/ [11:49:33] vikasyaligar: ok, looks like rubocop problems are not because of your change [11:51:29] running job on sauce, looks like local firefox has problems [11:51:30] https://integration.wikimedia.org/ci/job/browsertests-VisualEditor-language-screenshot-linux-firefox-sauce/LANGUAGE_SCREENSHOT_CODE=nl,label=contintLabsSlave%20&&%20UbuntuTrusty/2/console [11:52:55] 3Wikimedia / 3Continuous integration: mediawiki-gate job blocking on different branches - 10https://bugzilla.wikimedia.org/72432#c3 (10Antoine "hashar" Musso (WMF)) See also https://www.mediawiki.org/wiki/Requests_for_comment/Extensions_continuous_integration [12:00:52] zeljkof: OK [12:03:09] vikasyaligar: will merge your commit as soon as the job finishes [12:06:24] Project browsertests-VisualEditor-language-screenshot-linux-firefox-sauce » nl,contintLabsSlave && UbuntuTrusty build #2: FAILURE in 21 min: https://integration.wikimedia.org/ci/job/browsertests-VisualEditor-language-screenshot-linux-firefox-sauce/LANGUAGE_SCREENSHOT_CODE=nl,label=contintLabsSlave%20&&%20UbuntuTrusty/2/ [12:07:31] zeljkof: was my changes pulled; before cucumber was ran in the ^^ job [12:07:48] vikasyaligar: no, the above is before your change [12:07:59] I will apply the change now and rerun [12:08:12] zeljkof: Ok; great ! :) [12:09:14] vikasyaligar: https://integration.wikimedia.org/ci/job/browsertests-VisualEditor-language-screenshot-linux-firefox-sauce/LANGUAGE_SCREENSHOT_CODE=nl,label=contintLabsSlave%20&&%20UbuntuTrusty/3/console [12:10:23] zeljkof: Also I wanted to know about the rubocop running for all the files; Is it an expected behaviour ?;Shouldn't we change it to files which were modified ? [12:10:38] vikasyaligar: go ahead :) [12:11:05] vikasyaligar: https://bugzilla.wikimedia.org/show_bug.cgi?id=73077 [12:11:09] related bug ^ [12:13:16] zeljkof: Yay ! Will it be a problem if I work on it. Because hashar is already assigned ? [12:13:34] vikasyaligar: I am pretty sure hashar would not mind at all :) [12:13:49] but leave a comment on the bug [12:13:58] so there is no duplication of effort [12:14:25] zeljkof: sure [12:18:38] * zeljkof is out of lunch [12:28:16] Will be back soon [12:37:12] Yippee, build fixed! [12:37:13] Project browsertests-VisualEditor-language-screenshot-linux-firefox-sauce » nl,contintLabsSlave && UbuntuTrusty build #3: FIXED in 28 min: https://integration.wikimedia.org/ci/job/browsertests-VisualEditor-language-screenshot-linux-firefox-sauce/LANGUAGE_SCREENSHOT_CODE=nl,label=contintLabsSlave%20&&%20UbuntuTrusty/3/ [12:54:52] I am back; [12:55:00] Yay ! everything is green :) [13:04:46] vikasyaligar: ok, your changes fixed the build [13:04:50] https://integration.wikimedia.org/ci/job/browsertests-VisualEditor-language-screenshot-linux-firefox-sauce/LANGUAGE_SCREENSHOT_CODE=nl,label=contintLabsSlave%20&&%20UbuntuTrusty/3/console [13:05:10] zeljkof: yup ! :) [13:05:27] vikasyaligar: merging [13:05:54] feel free to play with rubocop [13:06:06] and let me know if you have any question [13:06:10] questions [13:06:20] I do plan to write about rubocop workflow soon [13:07:11] zeljkof: great ! I have 1 question => [13:08:09] I think current behaviour of rubocop is good, i.e. it checks for all the files(ruby) rather than the files which we have changed. [13:08:23] vikasyaligar: agreed [13:08:37] because when rubocop upgrades, sometimes it has new checks [13:09:08] I think there should be a bug to solve all such offences? [13:09:44] Like ones here => https://integration.wikimedia.org/ci/job/mwext-VisualEditor-bundle-rubocop/213/console [13:11:36] Once were are done with that(getting rubocop green for all repo) bug then I think we can use robocop for voting?; What do you think zeljkof? [13:12:09] vikasyaligar: no [13:12:18] we can use rubocop voting now :) [13:12:40] because rubocop --auto-gen-config created configuration file that ignores current problems [13:12:49] meaning rubocop would not fail the build now [13:12:54] and we have already done that [13:13:16] now the only thing left is to clean up the generated config file problem by problem [13:13:29] for all repos with ruby code [13:13:43] vikasyaligar: for example https://gerrit.wikimedia.org/r/#/c/169363/ [13:16:25] 3Wikimedia / 3Quality Assurance: Fix the language screenshot test for new VE architecture - 10https://bugzilla.wikimedia.org/73033 (10Željko Filipin) 5PATC>3RESO/FIX [13:20:28] zeljkof: sounds great; then we should run bundle exec rubocop --config .rubocop.yml; so that all those offences are ignored ? [13:20:39] no [13:20:56] vikasyaligar: .rubocom.yml inherits from .rubocop_todo.xml [13:20:58] yml [13:21:04] so everything is already done [13:24:02] wow; that is awesome; but I am still confused on why I got that error on my patch ?; It should have ignored it. right ? [13:24:10] zeljkof: ^ [13:27:24] vikasyaligar: hm [13:27:31] I think we upgraded rubocop recently [13:27:45] and did not notice that it started complaining about something [13:27:57] your patch was probably the first one where we have noticed it [13:28:08] the problem of rubocop job being non-voting :) [13:28:25] if it was voting, then we would notice the change immediatelly [13:33:21] zeljkof: yup; now I understood it. I updated my .rubocop_todo.yml by rubocop --auto-gen-config and ran rubocop to get 0 offenses :) [13:33:37] vikasyaligar: yes, that is the way to get green fast :) [13:33:47] then, fix problems from todo file one by one [13:33:58] feel free to do it for VE, I will +2 everything :) [13:34:13] create a topic branch and one problem by commit [13:36:51] zeljkof: yup; Will do that :) [13:36:55] (03PS6) 10Hashar: Tests for Bouquet skin. [integration/config] - 10https://gerrit.wikimedia.org/r/170447 (owner: 10Lewis Cawte) [13:37:53] vikasyaligar: most of the stuff can be done with --auto-correct [13:38:00] even stuff that does not do that is easy [13:38:11] and the hard stuff just leave until the end :) [13:41:06] (03CR) 10Hashar: [C: 032] "Should be good :)" [integration/config] - 10https://gerrit.wikimedia.org/r/170447 (owner: 10Lewis Cawte) [13:44:25] (03Merged) 10jenkins-bot: Tests for Bouquet skin. [integration/config] - 10https://gerrit.wikimedia.org/r/170447 (owner: 10Lewis Cawte) [13:45:35] (03CR) 10Hashar: "Deployed. You will need a .jshintrc in your repository though ( see https://www.mediawiki.org/wiki/Manual:Coding_conventions/JavaScript " [integration/config] - 10https://gerrit.wikimedia.org/r/170447 (owner: 10Lewis Cawte) [13:54:14] wow; 610 offenses corrected [13:54:52] let me commit it and send it for review ... [14:01:04] (03PS2) 10Hashar: Remove `parsoidsvc-*-parsertests-run-harder` jobs. [integration/config] - 10https://gerrit.wikimedia.org/r/171314 (owner: 10Cscott) [14:06:14] (03CR) 10Hashar: [C: 032] "That is a good move. Thanks!" [integration/config] - 10https://gerrit.wikimedia.org/r/171314 (owner: 10Cscott) [14:08:20] (03PS2) 10Hashar: Run `jslint` on parsoid deploy repo. [integration/config] - 10https://gerrit.wikimedia.org/r/171764 (owner: 10Cscott) [14:09:21] (03Merged) 10jenkins-bot: Remove `parsoidsvc-*-parsertests-run-harder` jobs. [integration/config] - 10https://gerrit.wikimedia.org/r/171314 (owner: 10Cscott) [14:09:49] (03CR) 10Hashar: [C: 032] "The repo has a .jshintignore which would skip the jshint. Nice :)" [integration/config] - 10https://gerrit.wikimedia.org/r/171764 (owner: 10Cscott) [14:13:21] (03Merged) 10jenkins-bot: Run `jslint` on parsoid deploy repo. [integration/config] - 10https://gerrit.wikimedia.org/r/171764 (owner: 10Cscott) [14:15:01] zeljkof: would you be able to do another pairing session with me Tuesday morning? [14:15:13] lubaochuan: sure, I have just sent you the e-mail :) [14:15:35] great minds think alike :) [14:15:42] lubaochuan: will create the event in the calendar right now and invite you [14:15:44] lubaochuan: :) [14:16:05] Yes. That's exactly what I have in mind. [14:16:50] (03CR) 10Hashar: "The run-harder jobs have been dropped with https://gerrit.wikimedia.org/r/#/c/171314/ in favor of using 'npm test'. So I guess this change" [integration/config] - 10https://gerrit.wikimedia.org/r/171309 (owner: 10Subramanya Sastry) [14:16:53] lubaochuan: ok, made the event recurring weekly [14:17:00] the same day and time [14:17:08] we can cancel it any time we get bored :) [14:17:14] (03PS2) 10Hashar: Add jobs for ext/PhpTagsWidgets [integration/config] - 10https://gerrit.wikimedia.org/r/171809 (owner: 10Pastakhov) [14:17:21] Sounds great. [14:17:33] lubaochuan: did you see my comments in gerrit? [14:17:39] do you know how to move forward [14:17:55] it is important to not get stuck, and to know where to ask for help [14:18:13] but wait, tomorrow is a holiday in the US, [14:18:18] you can still pair? [14:19:25] I just saw you comments. Tomorrow is a work day for me. [14:19:37] lubaochuan: ok, see you tomorrow [14:19:47] if you have questions about the commit, I will be around for a few more hours [14:19:54] (03CR) 10Hashar: [C: 032] "Jobs deployed:" [integration/config] - 10https://gerrit.wikimedia.org/r/171809 (owner: 10Pastakhov) [14:19:59] and mail to qa list is also a good way to get help, if I am not around [14:20:11] Got it. [14:20:32] or asking here, people here will also mostly know what to do if you get stuck :) [14:21:45] Great! Thanks. I will amend my first commit. [14:23:25] (03Merged) 10jenkins-bot: Add jobs for ext/PhpTagsWidgets [integration/config] - 10https://gerrit.wikimedia.org/r/171809 (owner: 10Pastakhov) [14:24:36] zeljkof: do you mind if I invite my students to join the pairing session to at least observe? [14:28:20] lubaochuan: no problem [14:29:15] send me their mail addresses so I could add them to the event [14:34:09] Just sent you their emails. [14:34:18] lubaochuan: we could also make it a public event and post the video to youtube [14:34:31] I saw people doing that, but not sure how to do it :) [14:34:50] That's what I think. It is hangout on air. I've done it before. [14:34:51] we could keep it simple this time, and record the next time, probably [14:35:15] That sounds good. [14:37:26] I send you a link to the hangout on air, just in case. I am not sure how to record a normal hangout session either. [14:39:19] Lets play by ear. I am sure it will be fine either ways. [14:41:04] lubaochuan: see you tomorrow [14:41:34] see you and thanks much for your help! [14:47:39] lubaochuan: no problem [14:47:46] hope you will find it useful [14:48:08] we have plenty of work to do, and plenty of interesting projects and areas to explore [14:49:04] It has been tremendously useful already. I would love to explore the terrain my self and hopefully get more students involved. [15:29:49] (03PS6) 10Hashar: Enable RuboCop and Ruby syntax check jobs for mediawiki-vagrant [integration/config] - 10https://gerrit.wikimedia.org/r/168270 (https://bugzilla.wikimedia.org/69245) (owner: 10Zfilipin) [15:54:50] hi zeljkof vikasyaligar thanks for merging https://gerrit.wikimedia.org/r/#/c/171531/ [15:55:48] chrismcmahon: the job using local firefox is still failing, but not related to VE code, but firefox [15:55:55] will work on that this week [15:56:19] zeljkof: OK. I want to do some other things in the VE repo today as well [15:57:10] (03CR) 10Hashar: [C: 04-1] "Rubocop apparently does not pass on mediawiki/vagrant but this job have mediawiki-vagrant-bundle-rubocop set voting :/" [integration/config] - 10https://gerrit.wikimedia.org/r/168270 (https://bugzilla.wikimedia.org/69245) (owner: 10Zfilipin) [16:16:23] zeljkof: vikasyaligar can https://gerrit.wikimedia.org/r/#/c/172245/ be merged today? I don't want to have to rebase over that change. [16:16:54] hello chrismcmahon; wait I will get it done now [16:17:02] chrismcmahon: it can, if vikasyaligar replies to my comments :) [16:20:12] I noticed that we're going to accept rubocop's preference for single-quotes over double-quotes [16:20:25] (03PS1) 10Hashar: Update Mark A Hershberger email address [integration/config] - 10https://gerrit.wikimedia.org/r/172265 [16:22:54] (03CR) 10jenkins-bot: [V: 04-1] Update Mark A Hershberger email address [integration/config] - 10https://gerrit.wikimedia.org/r/172265 (owner: 10Hashar) [16:23:07] (03CR) 10Hashar: [C: 032] Update Mark A Hershberger email address [integration/config] - 10https://gerrit.wikimedia.org/r/172265 (owner: 10Hashar) [16:26:11] chrismcmahon: that is optional, and per repo [16:26:24] (03Merged) 10jenkins-bot: Update Mark A Hershberger email address [integration/config] - 10https://gerrit.wikimedia.org/r/172265 (owner: 10Hashar) [16:26:29] but I would go with rubocop defaults where ever possible [16:26:49] single/double quotes can be switched automatically by rubocop [16:27:13] zeljkof: chrismcmahon I think https://gerrit.wikimedia.org/r/#/c/172245/ is ready now :) [16:27:22] vikasyaligar, chrismcmahon: please ping me if you need reply, irc window is in the background [16:27:27] vikasyaligar: looking [16:27:51] vikasyaligar: noooo :'( [16:27:57] :( [16:28:00] you like big commits, like chrismcmahon :) [16:28:49] (03CR) 10Hashar: "Deployed" [integration/config] - 10https://gerrit.wikimedia.org/r/172265 (owner: 10Hashar) [16:29:18] zeljkof: all of that came directly from auto-correct option of rubocop :) [16:29:23] vikasyaligar: I have left the comment, I think rubocop should be fixed like this [16:29:23] https://gerrit.wikimedia.org/r/#/q/status:abandoned+project:mediawiki/extensions/Flow+branch:master+topic:bug/63307,n,z [16:29:29] with a series of small commits [16:29:45] vikasyaligar: yes, but it is really hard to review [16:30:05] if you remove offenses one by one, then rubocop will fix just one thing [16:30:14] take a look at the above commit [16:30:18] commits [16:30:37] they were abandoned because chrismcmahon submitted the same thing in a separate branch [16:30:41] but the idea is there [16:32:53] zeljkof: yup; hmm; then it might take some time; I think I will do it tomorrow, as I have some class work now. Hope it is fine ? [16:33:18] vikasyaligar: there is no rush :) [16:33:31] the workflow is fast, creating a small commit is just a minute [16:33:43] and it is waaaay easier to review [16:33:49] than a bunch of unrelated changes [16:45:36] zeljkof: yup I agree; Is there any way I can auto correct specific Style like EmptyLines ? [16:46:10] vikasyaligar: just delete one offense from the todo file [16:46:17] and rubocop will fix just that one [16:46:29] zeljkof: ah ha ! that should do :) [16:47:16] (03CR) 10Lewis Cawte: "Done - I3975e9d6878c362995948ab3622a37a22a1b4d5e" [integration/config] - 10https://gerrit.wikimedia.org/r/170447 (owner: 10Lewis Cawte) [17:01:39] (03Abandoned) 10Cscott: Remove "-run-harder" suffix from parsoid parser tests job name [integration/config] - 10https://gerrit.wikimedia.org/r/171309 (owner: 10Subramanya Sastry) [17:14:00] (03PS1) 10Lewis Cawte: Trigger tests for EditAccount [integration/config] - 10https://gerrit.wikimedia.org/r/172276 [17:27:35] Yippee, build fixed! [17:27:36] Project browsertests-Math-en.wikipedia.beta.wmflabs.org-linux-chrome-sauce build #214: FIXED in 1 min 39 sec: https://integration.wikimedia.org/ci/job/browsertests-Math-en.wikipedia.beta.wmflabs.org-linux-chrome-sauce/214/ [17:44:58] if anyone sees Dan Duvall in the office, could you mention I have a question for him? [17:54:26] (03PS1) 10QChris: Add jobs for analytics/aggregator [integration/config] - 10https://gerrit.wikimedia.org/r/172288 [18:01:14] Yippee, build fixed! [18:01:15] Project browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-windows_7-internet_explorer-9-sauce build #122: FIXED in 46 min: https://integration.wikimedia.org/ci/job/browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-windows_7-internet_explorer-9-sauce/122/ [18:36:35] (03PS2) 10QChris: Add jobs for analytics/aggregator [integration/config] - 10https://gerrit.wikimedia.org/r/172288 [19:01:37] Yippee, build fixed! [19:01:38] Project browsertests-Flow-en.wikipedia.beta.wmflabs.org-linux-firefox-monobook-sauce build #121: FIXED in 1 hr 8 min: https://integration.wikimedia.org/ci/job/browsertests-Flow-en.wikipedia.beta.wmflabs.org-linux-firefox-monobook-sauce/121/ [19:11:25] welcome lubaochuan [19:12:29] Thanks. [19:18:43] I am amending a change. The "git review --download 171508" command gave me the following error: https://gist.github.com/anonymous/5ef08cb835cedc19377d [19:19:47] I am following instructions at https://www.mediawiki.org/wiki/Gerrit/Getting_started [19:22:14] Does anyone know what issue might be? [19:22:14] lubaochuan: looking... [19:26:54] lubaochuan: have you set your ssh keys in gerrit? [19:27:51] lubaochuan: hmm, you've made some amendments to this patch before it seems [19:29:00] I think I set the key. I can do "ssh lubaochuan@gerrit.wikimedia.org -p 29418" successfully. [19:29:04] lubaochuan: is this link helpful? http://www.mediawiki.org/wiki/Gerrit/git-review#.22Cannot_query_patchset_information.22 [19:31:33] I committed two changes, which should have been one. I have abandoned the second change. Now I want to modify my first change. [19:32:07] greg-g: do you know if Dan Duvall is around today? I have a question for him... [19:33:09] Can I revert to the first change in my local repo and commit --amend with the change ID of my first change? [19:37:28] lubaochuan: if I understand correctly, I think you might want to do "git reset --hard". that will take your local repo back to the latest version you committed [19:37:36] chrismcmahon: yep, I don't see him right now, but yeah, he's in the office [19:38:29] greg-g: let him know I'm looking for him? I think one of his improvement projects has gone astray in the MobileFrontend repo [19:39:17] will do [19:40:55] Ok. I want to amend the second to last version I committed. [19:42:45] lubaochuan: ha. OK, I haven't done that in a really long time. :-) let me look around. in the meantime, perhaps ask on #wikimedia-tech (low traffic) or #wikimedia-dev (high traffic) [19:43:09] I will try "git reset --hard ". [19:43:46] lubaochuan: ultimately you'll need the git docs I think. this might be useful: http://git-scm.com/docs/git-reset [19:44:01] Thanks. [19:44:54] The "git review --download " should work though. [19:49:10] lubaochuan: "git review --download " when done from the master branch will set your repo to the current state of that topic branch "bug/63307". fwiw, I do this often, I'll just check out latest master branch and then do "git review -d " [19:51:34] Sorry, I meant "git review -d 171508" should work if I am on the topic branch. [19:59:40] 3Wikimedia / 3Continuous integration: make jobs that depend on wikidata jenkins slaves run on the normal labs slaves instead - 10https://bugzilla.wikimedia.org/71419#c9 (10Antoine "hashar" Musso (WMF)) > Infact, there are a few more slaves than when I last looked so should be fine ;p And the wikidata instan... [20:30:09] (03CR) 10Hashar: [C: 04-1] "That will let us create the jobs in Jenkins. Now Zuul needs its own configuration in zuul/layout.yaml something like:" [integration/config] - 10https://gerrit.wikimedia.org/r/172276 (owner: 10Lewis Cawte) [20:39:44] (03CR) 10Dduvall: "Since rubocop is currently non-voting, I think I'm going to address the detected issues (and ignore some) in a separate commit." [selenium] (env-abstraction-layer) - 10https://gerrit.wikimedia.org/r/171985 (owner: 10Dduvall) [20:47:59] chrismcmahon: sorry, forgot to startup irc this morning :) [20:48:10] hi marxarelli [20:48:32] chrismcmahon: that error looks like the result of a bad URL somewhere [20:48:39] marxarelli: [20:48:43] (03CR) 10Hashar: [C: 032] "The *-flake8-bin are not configured in the Zuul configuration, I guess you don't want them triggered until the change https://gerrit.wikim" [integration/config] - 10https://gerrit.wikimedia.org/r/172288 (owner: 10QChris) [20:48:46] marxarelli: yeah, agreed [20:49:03] I haven't gone too far into it, let me look at what MF is trying to do there [20:49:18] chrismcmahon: do you have a link to the full job? maybe we can repro it [20:51:03] marxarelli: yeah, I had to "bundle update": ruby gems for MF and the error happens after doing that [20:51:58] (03CR) 10jenkins-bot: [V: 04-1] Add jobs for analytics/aggregator [integration/config] - 10https://gerrit.wikimedia.org/r/172288 (owner: 10QChris) [20:52:20] chrismcmahon: oh, even when running it locallyl? [20:53:10] marxarelli: hrm, false alarm? no repro right now [20:55:56] chrismcmahon: heading to lunch but let me know if you want help debugging [20:56:10] (03CR) 10Hashar: [C: 032] "Jobs deployed now:" [integration/config] - 10https://gerrit.wikimedia.org/r/172288 (owner: 10QChris) [20:58:49] marxarelli: dunno. googling that error suggests I hit a bug in URI this morning but it's not happening now. [20:59:31] (03Merged) 10jenkins-bot: Add jobs for analytics/aggregator [integration/config] - 10https://gerrit.wikimedia.org/r/172288 (owner: 10QChris) [21:03:42] marxarelli|lunch: nothing to debug any more. I no longer see the error [21:13:52] (03PS1) 10QChris: Add flake8 for analytics/aggregator's bin directory [integration/config] - 10https://gerrit.wikimedia.org/r/172399 [21:14:16] (03CR) 10QChris: [C: 04-1] "This should ounly get merged once analytics/aggregator's" [integration/config] - 10https://gerrit.wikimedia.org/r/172399 (owner: 10QChris) [21:17:16] (03CR) 10QChris: "> The *-flake8-bin are not configured in the Zuul configuration, I guess" [integration/config] - 10https://gerrit.wikimedia.org/r/172288 (owner: 10QChris) [21:24:33] chrismcmahon: did we use browserstack before? [21:24:54] .com, that is :) [21:26:00] greg-g: nope [21:26:16] greg-g: not to my knowledge. crossbrowsertesting.com yes. [21:26:33] greg-g: but good point, maybe mention on wikitech-l [21:27:46] chrismcmahon: asking because someone else asked me if we did given: http://www.computerworld.com/article/2845319/browserstack-hacked-attacker-sends-email-to-customers-alleging-shoddy-security.html [21:27:49] greg-g: fwiw, I read about the browserstack issues (which were scary) but SauceLabs has always been much more secure. they don't re-use VMs at all, each one is created and destroyed for a single use [21:27:57] and if you go to browserstack.com, it says Wikipedia uses it :) [21:28:02] * greg-g nods [21:28:10] really. hm [21:28:15] lemme search email [21:28:23] kk [21:31:20] greg-g: Timo from 2012 [21:32:34] * greg-g nods [21:33:17] greg-g: we seem to have a current account but it is not widely used [21:34:12] * greg-g nods [22:04:32] greg-g: might get some spammy shinken notifications for the next hour... [22:06:14] wee? :) [22:12:39] greg-g: I sent mail to wikitech-l about browserstack, cc'd Sarah and Rachel [22:18:19] chrismcmahon: cool, ty [22:18:29] Project browsertests-CirrusSearch-test2.wikipedia.org-linux-firefox-sauce build #254: FAILURE in 3 min 50 sec: https://integration.wikimedia.org/ci/job/browsertests-CirrusSearch-test2.wikipedia.org-linux-firefox-sauce/254/ [22:24:05] Project browsertests-VisualEditor-en.wikipedia.beta.wmflabs.org-linux-firefox-sauce build #399: FAILURE in 1 hr 20 min: https://integration.wikimedia.org/ci/job/browsertests-VisualEditor-en.wikipedia.beta.wmflabs.org-linux-firefox-sauce/399/ [22:39:16] chrismcmahon: greg-g: Browserstack has claimed Wikipedia using it way before we asked/subscribed for an account. [22:39:32] I approached Rachel/ErikM with browserstack little over a year ago and we got an account with discount. [22:40:00] based on my experience with the jQuery Foundation using browserstack. [22:44:46] Krinkle: actually, it was back in 2012 or earlier you did that. [22:44:57] hah [22:45:04] we should have them remove us from that list then :) [22:45:30] I think Eloquence proposed that but instead we got a discount, as we did want an account. [22:45:52] I still like browserstack a lot, though if on principle basis we're abondoning it, fine by me. [22:46:13] "abondoning" implies we used it [22:46:21] We did, for a long time. [22:46:33] do we use it now? [22:46:38] Afaik various features engineering people use it quite often. myself included. [22:46:46] ah, ok, good to know [22:47:19] It's feature set, speed, browser coverage and easy of use are not triumphed by crossbrowsertesting or suacelabs. In my experience those both have horrible interfaces and are slow. [22:48:13] I know they've caught up with browsersets feature set technically, but I still never use it. It's just no where nearly as user friendly. I can pop up browserstack in under a minute from within chrome and have a tunnel to my lcoalhost and be testing in any browser I want. [22:49:06] Afaik the vm re-using thing is not entirely true. Browserstack has a cold standby pool of fresh vms and they don't reuse them. That only applies to the Apple machines, not to the windows boxes. [22:49:29] e.g. spawn ahead of time to save time, use once, and tear down. [22:50:17] the APple machines are hardware bound due to licensing. I expect it'll be the same on saucelabs (they might have better reset scripts maybe, or they pay extra for licensing and maybe manage to virtualise mac os inside mac os) [23:03:27] Krinkle: not sure from context if you've seen this: http://techcrunch.com/2014/11/10/hacker-emails-testing-service-browserstacks-customers-says-company-lied-about-security/ [23:03:39] Yeah, I got the e-mails last night too [23:04:01] About 5 of them (jquery, wikimedia, and two accounts for scipts I manage at both)