[00:14:38] 3Wikimedia / 3Continuous integration: Publish cdb documentation on doc.wikimedia.org - 10https://bugzilla.wikimedia.org/73530 (10Krinkle) [00:14:39] 3Wikimedia / 3Continuous integration: Jenkins: Set up lint and phpunit jobs for cdb repo - 10https://bugzilla.wikimedia.org/73541 (10Krinkle) p:5Unprio>3Normal s:5normal>3major [00:14:53] 3Wikimedia / 3Continuous integration: Publish cdb documentation to doc.wikimedia.org - 10https://bugzilla.wikimedia.org/73530 (10Krinkle) [00:16:06] 3Wikimedia / 3Continuous integration: Jenkins: Slaves running Ubuntu Trusty should have hhvm installed - 10https://bugzilla.wikimedia.org/73356 (10Krinkle) [00:17:35] 3Wikimedia / 3Continuous integration: Jenkins: Implement mediawiki-phpunit-hhvm job for mediawiki-core repo (and voting) - 10https://bugzilla.wikimedia.org/73521 (10Krinkle) [00:17:50] 3Wikimedia / 3Continuous integration: Jenkins: Create phpcs and phpunit jobs for GoogleAPIClient repo - 10https://bugzilla.wikimedia.org/73044 (10Krinkle) [00:29:53] 3Wikimedia / 3Continuous integration: Restrict 'integration' Gerrit group - 10https://bugzilla.wikimedia.org/73303 (10Krinkle) 5NEW>3RESO/FIX a:3Chad H. [01:18:35] 3Wikimedia / 3Continuous integration: Jenkins: Slaves running Ubuntu Trusty should have hhvm installed - 10https://bugzilla.wikimedia.org/73356#c2 (10Krinkle) (In reply to Antoine "hashar" Musso (WMF) from comment #1) > Timo, I have unpooled integration-slave1009 since it is missing hhvm and > left a note po... [01:45:05] 3Wikimedia / 3Continuous integration: Jenkins: Generate doc in test pipeline and publish temporarily for review - 10https://bugzilla.wikimedia.org/70945 (10Krinkle) p:5Normal>3Low [01:45:05] 3Wikimedia / 3Continuous integration: Jenkins: JSDuck should run on Ruby 1.9 instead of Ruby 1.8 - 10https://bugzilla.wikimedia.org/60138 (10Krinkle) [01:45:08] 3Wikimedia / 3Continuous integration: Jenkins: Add a lint job for JSON - 10https://bugzilla.wikimedia.org/58279#c27 (10Krinkle) (In reply to Bawolff (Brian Wolff) from comment #26) > (In reply to Bawolff (Brian Wolff) from comment #25) > > Re-opening. I just managed to submit a patch ( > > https://gerrit.wik... [01:50:28] (03PS1) 10Krinkle: jsduck: Remove redundant hack that searched jsduck.log for "Warning" [integration/config] - 10https://gerrit.wikimedia.org/r/174619 (https://bugzilla.wikimedia.org/55668) [02:06:14] Project browsertests-GettingStarted-en.wikipedia.beta.wmflabs.org-linux-firefox-sauce build #169: FAILURE in 9.9 sec: https://integration.wikimedia.org/ci/job/browsertests-GettingStarted-en.wikipedia.beta.wmflabs.org-linux-firefox-sauce/169/ [02:10:00] Yippee, build fixed! [02:10:00] Project browsertests-Flow-test2.wikipedia.org-linux-chrome-sauce build #284: FIXED in 1 hr 1 min: https://integration.wikimedia.org/ci/job/browsertests-Flow-test2.wikipedia.org-linux-chrome-sauce/284/ [02:27:09] PROBLEM - CI: Low disk space on /var on labmon1001 is CRITICAL: CRITICAL: integration.integration-puppetmaster.diskspace._var.byte_avail.value (12.50%) [03:16:54] Project browsertests-UniversalLanguageSelector-commons.wikimedia.beta.wmflabs.org-linux-firefox-sauce build #291: FAILURE in 28 min: https://integration.wikimedia.org/ci/job/browsertests-UniversalLanguageSelector-commons.wikimedia.beta.wmflabs.org-linux-firefox-sauce/291/ [03:18:23] 3Wikimedia / 3Continuous integration: Jenkins: Create test for mediawiki-config repo to ensure Parsoid settings for are valid - 10https://bugzilla.wikimedia.org/68532#c1 (10Krinkle) Not sure creating another script and abstraction layer would be the best way to support this minor case. Perhaps implement as... [03:33:56] Yippee, build fixed! [03:33:57] Project browsertests-Echo-test2.wikipedia.org-linux-chrome-sauce build #176: FIXED in 16 min: https://integration.wikimedia.org/ci/job/browsertests-Echo-test2.wikipedia.org-linux-chrome-sauce/176/ [04:36:27] RECOVERY - CI: Low disk space on /var on labmon1001 is OK: OK: All targets OK [04:41:15] Project browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-os_x_10.9-safari-sauce build #295: FAILURE in 52 min: https://integration.wikimedia.org/ci/job/browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-os_x_10.9-safari-sauce/295/ [04:50:21] Yippee, build fixed! [04:50:22] Project browsertests-Flow-en.wikipedia.beta.wmflabs.org-linux-firefox-sauce build #366: FIXED in 1 hr 1 min: https://integration.wikimedia.org/ci/job/browsertests-Flow-en.wikipedia.beta.wmflabs.org-linux-firefox-sauce/366/ [05:36:26] Yippee, build fixed! [05:36:26] Project browsertests-Flow-en.wikipedia.beta.wmflabs.org-linux-chrome-monobook-sauce build #126: FIXED in 53 min: https://integration.wikimedia.org/ci/job/browsertests-Flow-en.wikipedia.beta.wmflabs.org-linux-chrome-monobook-sauce/126/ [06:58:38] Project browsertests-VisualEditor-en.wikipedia.beta.wmflabs.org-linux-firefox-sauce build #419: FAILURE in 1 hr 8 min: https://integration.wikimedia.org/ci/job/browsertests-VisualEditor-en.wikipedia.beta.wmflabs.org-linux-firefox-sauce/419/ [07:01:30] Project browsertests-Flow-en.wikipedia.beta.wmflabs.org-linux-chrome-sauce build #335: FAILURE in 1 hr 23 min: https://integration.wikimedia.org/ci/job/browsertests-Flow-en.wikipedia.beta.wmflabs.org-linux-chrome-sauce/335/ [07:40:23] 3Wikimedia / 3Continuous integration: [OPS] Jenkins: puppet master fills /var on labs with yaml reports - 10https://bugzilla.wikimedia.org/73472#c14 (10Yuvi Panda) Can someone with projectadmin on integration project edit https://wikitech.wikimedia.org/wiki/Hiera:Integration to add the line: "puppetmaster::... [09:19:33] Project browsertests-Flow-en.wikipedia.beta.wmflabs.org-windows_8-internet_explorer-sauce build #286: FAILURE in 43 min: https://integration.wikimedia.org/ci/job/browsertests-Flow-en.wikipedia.beta.wmflabs.org-windows_8-internet_explorer-sauce/286/ [09:41:53] (03PS1) 10Zfilipin: Created job for VisualEditor screenshots that runs using Sauce Labs [integration/config] - 10https://gerrit.wikimedia.org/r/174660 [09:45:59] (03PS2) 10Zfilipin: Created job for VisualEditor screenshots that runs using Sauce Labs [integration/config] - 10https://gerrit.wikimedia.org/r/174660 [10:00:17] Project browsertests-VisualEditor-language-screenshot-linux-firefox » ar,contintLabsSlave && UbuntuTrusty build #1: FAILURE in 12 min: https://integration.wikimedia.org/ci/job/browsertests-VisualEditor-language-screenshot-linux-firefox/LANGUAGE_SCREENSHOT_CODE=ar,label=contintLabsSlave%20&&%20UbuntuTrusty/1/ [10:02:21] Project browsertests-VisualEditor-language-screenshot-windows_8.1-firefox » ar,contintLabsSlave && UbuntuTrusty build #1: FAILURE in 15 min: https://integration.wikimedia.org/ci/job/browsertests-VisualEditor-language-screenshot-windows_8.1-firefox/LANGUAGE_SCREENSHOT_CODE=ar,label=contintLabsSlave%20&&%20UbuntuTrusty/1/ [10:19:39] Project browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-linux-firefox-sauce build #298: FAILURE in 41 min: https://integration.wikimedia.org/ci/job/browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-linux-firefox-sauce/298/ [11:05:38] zeljkof: sorry for the short notice, but I cannot make it to our meeting today.. sorry. [11:05:57] np [11:10:10] Yippee, build fixed! [11:10:10] Project browsertests-GettingStarted-en.wikipedia.beta.wmflabs.org-linux-firefox-sauce build #170: FIXED in 1 min 22 sec: https://integration.wikimedia.org/ci/job/browsertests-GettingStarted-en.wikipedia.beta.wmflabs.org-linux-firefox-sauce/170/ [13:20:53] !log rebased puppet master [13:20:57] Logged the message, Master [13:20:58] !log rebased puppet master on integration project [13:21:00] Logged the message, Master [13:21:43] !log for integration, set puppet master report retention to 360 minutes ( https://wikitech.wikimedia.org/wiki/Hiera:Integration , see https://bugzilla.wikimedia.org/show_bug.cgi?id=73472#c14 ) [13:21:45] Logged the message, Master [13:25:19] PROBLEM - CI: Low disk space on /var on labmon1001 is CRITICAL: CRITICAL: integration.integration-puppetmaster.diskspace._var.byte_avail.value (11.11%) [13:27:24] 3Wikimedia / 3Continuous integration: [OPS] Jenkins: puppet master fills /var on labs with yaml reports - 10https://bugzilla.wikimedia.org/73472#c15 (10Antoine "hashar" Musso (WMF)) (In reply to Yuvi Panda from comment #14) > Can someone with projectadmin on integration project edit > https://wikitech.wikime... [13:28:53] hashar: bah, typo on my end. it's 'keep_reports_minutes' (s after report) [13:30:20] yuvipanda: trying :] [13:34:29] RECOVERY - CI: Low disk space on /var on labmon1001 is OK: OK: All targets OK [13:35:53] 3Wikimedia / 3Quality Assurance: Investigate how often browser tests fail because of Jenkins performance problems (tracking) - 10https://bugzilla.wikimedia.org/60338 (10Željko Filipin) a:5Željko Filipin>3None [13:37:55] 3Wikimedia / 3Continuous integration: [OPS] Jenkins: puppet master fills /var on labs with yaml reports - 10https://bugzilla.wikimedia.org/73472#c16 (10Antoine "hashar" Musso (WMF)) 5PATC>3RESO/FIX a:3Yuvi Panda hashar: bah, typo on my end. it's 'keep_reports_minutes' (s after report)... [13:37:56] yuvipanda: awesome. Both delpoyment-prep and integration puppet master are fixed now :] [13:38:09] hashar: :D cool! [13:38:15] hashar: did you put it in Hiera:deployment-prep too? [13:38:20] yeah [13:38:22] worked like a charm [13:39:06] looking at the http://shinken.wmflabs.org/problems [13:39:09] 3Wikimedia / 3Quality Assurance: rubocop should run after patch set submission to every repo that has Ruby code - 10https://bugzilla.wikimedia.org/69245#c69 (10Željko Filipin) 5PATC>3RESO/FIX Rubocop is now running. Still not voting. Searching for new repositories with ruby code is reported as a separate... [13:39:20] Greg told me yesterday I should fill up bugs for each :] [13:39:40] 3Wikimedia / 3Quality Assurance: Review if existing Ruby code follows Ruby Styleguide - 10https://bugzilla.wikimedia.org/63307#c73 (10Željko Filipin) 5PATC>3RESO/FIX The review is mostly done. "All" that is left is fixing the problems. [13:39:56] yuvipanda: any clue where to fill bugs for shin ken? [13:40:09] the hostname columns is too small :( [13:40:48] hashar: oh, for shinken itself [13:40:53] hashar: hmm, phabricator, operations project? [13:41:00] hashar: you can click an entry to find them. [13:41:13] hashar: for the bugs about the instance, deployment-prep under wikimedia labs project on labs [13:54:54] 3Wikimedia Labs / 3deployment-prep (beta): Puppet failures on deployment-bastion - 10https://bugzilla.wikimedia.org/73520#c1 (10Antoine "hashar" Musso (WMF)) 5NEW>3ASSI a:3Ori Livneh Seems to be caused by https://gerrit.wikimedia.org/r/#/c/173353/ keyholder: add /etc/keyholder.d and `keyholder arm` sub... [14:32:56] (03PS1) 10Filippo Giunchedi: merge job timing stats together [integration/zuul] - 10https://gerrit.wikimedia.org/r/174691 [14:56:28] (03PS1) 10Jdlrobson: Add mwext-MobileFrontend-npm job [integration/config] - 10https://gerrit.wikimedia.org/r/174696 [14:56:42] ^ hashar i hope that's right? :) [14:57:05] hashar: is there need to kick jenkins? https://integration.wikimedia.org/ci/ [14:57:23] hashar: https://integration.wikimedia.org/ci/job/beta-update-databases-eqiad/5600/console seems to hand [14:57:26] *hang [15:00:49] Tobi_WMDE_SW_NA: yeah it is in deadlock :( [15:01:54] Project browsertests-Wikidata-WikidataTests-linux-firefox-sauce build #47: ABORTED in 39 min: https://integration.wikimedia.org/ci/job/browsertests-Wikidata-WikidataTests-linux-firefox-sauce/47/ [15:02:05] Tobi_WMDE_SW_NA: and I have aborted https://integration.wikimedia.org/ci/job/browsertests-Wikidata-WikidataTests-linux-firefox-sauce/ [15:02:19] hashar: what? [15:02:21] nooo [15:02:23] :) [15:03:14] hashar: are you going to retrigger the deployment jobs then? [15:03:43] Tobi_WMDE_SW_NA: no. Unless needed :] [15:04:05] the next change merged would catch up the backlog [15:04:15] hashar: would need it for wikidata, to be able to test the new version on wikidata.beta [15:04:58] iirc the mediawiki code is run every 10 minutes [15:05:16] iirc the mediawiki code *update* is run every 10 minutes [15:05:18] ok. if that includes the wikidata extension that's fine [15:05:21] mediawiki-config is on post merge so [15:05:23] though [15:05:56] 3Wikimedia / 3Continuous integration: Jenkins won't run, stating "NOT_REGISTERED" for each test - 10https://bugzilla.wikimedia.org/73658 (10Gilles Dubuc) 3NEW p:3Unprio s:3normal a:3None https://gerrit.wikimedia.org/r/#/c/174698/ [15:12:26] hashar: did we do that? :) [15:20:52] Yippee, build fixed! [15:20:53] Project beta-update-databases-eqiad build #5602: FIXED in 52 sec: https://integration.wikimedia.org/ci/job/beta-update-databases-eqiad/5602/ [15:21:10] 3Wikimedia Labs / 3deployment-prep (beta): Beta not picking up merged change - 10https://bugzilla.wikimedia.org/73659 (10Gilles Dubuc) 3NEW p:3Unprio s:3normal a:3None This changeset was merged more than 2 hours ago: https://gerrit.wikimedia.org/r/#/c/172953/3 Beta is still serving the old version o... [15:24:30] (03CR) 10Hashar: "That is a good basis. I would like to have it worked on with upstream on their Gerrit install ( review.openstack.org ) and further enhanc" [integration/zuul] - 10https://gerrit.wikimedia.org/r/174691 (owner: 10Filippo Giunchedi) [15:24:59] jdlrobson: I have restarted Jenkins / Zuul :( [15:25:20] !log 15:01 Restarted Jenkins AND Zuul. Beta cluster jobs are still deadlocked. [15:25:22] Logged the message, Master [15:26:23] 3Wikimedia / 3Continuous integration: Jenkins won't run, stating "NOT_REGISTERED" for each test - 10https://bugzilla.wikimedia.org/73658#c1 (10Antoine "hashar" Musso (WMF)) p:5Unprio>3Immedi a:3Antoine "hashar" Musso (WMF) I restarted Zuul and Jenkins a few minutes before that bug got filled. Investiga... [15:28:26] hashar: hasharokay [15:29:26] hashar: did you deploy the new zuul change? [15:29:27] 3Wikimedia / 3Continuous integration: Jenkins won't run, stating "NOT_REGISTERED" for each test - 10https://bugzilla.wikimedia.org/73658#c2 (10Antoine "hashar" Musso (WMF)) What happened is that I shutdown Jenkins and Zuul. Restarted Zuul which came up with non jobs registered at all (since Jenkins was down,... [15:29:28] 3Wikimedia / 3Continuous integration: Jenkins won't run, stating "NOT_REGISTERED" for each test - 10https://bugzilla.wikimedia.org/73658 (10Antoine "hashar" Musso (WMF)) 5NEW>3RESO/FIX [15:29:47] jdlrobson: i restarted them due to a deadlock :D [15:30:16] will follow up in -mobile [15:36:16] (03CR) 10Hashar: "I have deployed the job using JJB:" [integration/config] - 10https://gerrit.wikimedia.org/r/174696 (owner: 10Jdlrobson) [15:43:06] (03CR) 10Hashar: "Seem Timo reply on https://gerrit.wikimedia.org/r/#/c/174697/ :)" [integration/config] - 10https://gerrit.wikimedia.org/r/174696 (owner: 10Jdlrobson) [15:43:38] (03CR) 10Krinkle: [C: 04-1] "Remote unittests-template so that the old jslint job no longer runs in test/gate pipeline." [integration/config] - 10https://gerrit.wikimedia.org/r/174696 (owner: 10Jdlrobson) [15:58:12] hashar: Who is SYSTEM? [15:58:17] https://integration.wikimedia.org/ci/job/mwext-VisualEditor-qunit/jobConfigHistory/ [15:58:23] Krinkle: Jenkins itself [15:58:35] Krinkle: seems on configuration save some plugins can hack in and change the config [15:58:36] I've never seen that untl now [15:58:47] hashar: k [15:58:58] hashar: btw, do you know why the diffs keep being dirty for job config changes? [15:59:02] It's such a mess [15:59:18] e.g. elements using or <> and new lines and whitespace [15:59:23] Krinkle: JJB generate a raw XML file which is copy pasted as is by Jenkins [15:59:30] apparently Jenkins renormalize the config after it [15:59:33] or maybe some jenkins plugin do [15:59:39] that is the SYSTEM thingy [15:59:54] maybe it happens on Jenkins restart [16:00:08] looking at the diff for that job above : https://integration.wikimedia.org/ci/job/mwext-VisualEditor-qunit/jobConfigHistory/showDiffFiles?timestamp1=2014-11-19_03-29-03×tamp2=2014-11-20_13-08-40 [16:00:14] - [16:00:20] + [16:00:24] the old line is what JJB wrote [16:00:32] the next one is what ever Jenkins managed to write back in config [16:00:35] so yeah, dirty diff [16:01:30] (03CR) 10Hashar: "The job has been tested and iterated against the master branch of the repo. The last one is passing: https://integration.wikimedia.org/ci" [integration/config] - 10https://gerrit.wikimedia.org/r/174696 (owner: 10Jdlrobson) [16:05:04] hashar: I mean, even when using normal edits on the Jenkins interface itself twice in a row, all kinds of random shit changes in teh diff. [16:05:13] It's like it's not deterministic [16:05:45] Krinkle: an edit via the web interface would trigger the renormalization of the xml file indeed [16:05:57] nature's call [16:06:08] hashar: Can you explain the purpose of mediawiki-gate? I read https://bugzilla.wikimedia.org/show_bug.cgi?id=58772 but still don't get it. Looks like a hack that shouldn't be. [16:06:41] hasharNature: yeah, but when the same app (web interface), triggers two edits in a row, surely it's alreayd been normalised? [16:06:49] something keeps normalising it back, even without using jjb in between [16:07:20] Krinkle: yeah I am not sure how it works in Jenkins. Maybe plugin can renormalize the configuration when it is loaded. [16:07:27] I haven't bothered investigating [16:07:39] https://bugzilla.wikimedia.org/show_bug.cgi?id=58772 and mediawiki-gate job is to group jobs related to mediawiki together [16:08:52] 3Wikimedia / 3Continuous integration: common gating job for mediawiki core and extensions - 10https://bugzilla.wikimedia.org/58772#c5 (10Antoine "hashar" Musso (WMF)) I wrote a RFC explaining part of the future system at: https://www.mediawiki.org/wiki/Requests_for_comment/Extensions_continuous_integration... [16:09:01] Krinkle: the new jobs would be based on the RFC I wrote a few weeks ago https://www.mediawiki.org/wiki/Requests_for_comment/Extensions_continuous_integration [16:09:11] basically run tests against core + vendor + a bunch of extensions [16:09:25] brb need food & drink [16:10:39] hasharNature: Yes. What do you mean by "group jobs". [16:10:56] How is this different from a regular job that fetches relevant dependencies and core and runs tests. [16:11:48] It's an empty job, and not a placeholder, but intended to be empty. So curious what it's purpose is. I guess it's supposed to force Zuul to do someting it doesn't otherwise do with regards to streamlining which jobs run when, but would be useful if you could elaborate exactlt what you're making it do. [16:14:30] Krinkle: so that is to make changes against core and extensions to share the same queue in gate-and-submit [16:14:56] the gate-and-submit in Zuul is a DependentPipeline, it means that if two changes share a common job, they are put in the same queue [16:15:24] so a change A to core and a change B to MobileFrontend will end up in the gate-and-submit queue "meidawiki": A -> B [16:15:42] Zuul will test core with change A applied [16:16:04] And test Mobilefrontend with: Core + Change A and MobileFrontend + Change B [16:16:27] this way if Change A ends up conflicting with Change B somehow, the mobilefrontend tests will fail [16:16:45] the concept is explained at http://ci.openstack.org/zuul/gating.html#cross-projects-dependencies [16:17:02] (03PS2) 10Jhernandez: Add mwext-MobileFrontend-npm job [integration/config] - 10https://gerrit.wikimedia.org/r/174696 (owner: 10Jdlrobson) [16:17:06] and Zuul cloner is meant to easily reproduce on slaves the state of the repositories determined by zuul [16:20:35] (03CR) 10jenkins-bot: [V: 04-1] Add mwext-MobileFrontend-npm job [integration/config] - 10https://gerrit.wikimedia.org/r/174696 (owner: 10Jdlrobson) [16:22:53] (03CR) 10Hashar: "Removing the -jslint job is slightly more complicated than just removing the extensions-unittests template. That templates includes a few" (031 comment) [integration/config] - 10https://gerrit.wikimedia.org/r/174696 (owner: 10Jdlrobson) [16:35:18] (03PS3) 10Jhernandez: Add mwext-MobileFrontend-npm job [integration/config] - 10https://gerrit.wikimedia.org/r/174696 (owner: 10Jdlrobson) [16:36:25] 3Wikimedia / 3Continuous integration: Beta Cluster stopped receiving code updates (beta-update-databases-eqiad hung) - 10https://bugzilla.wikimedia.org/70597#c19 (10Antoine "hashar" Musso (WMF)) *** Bug 73659 has been marked as a duplicate of this bug. *** [16:36:25] 3Wikimedia Labs / 3deployment-prep (beta): Beta not picking up merged change - 10https://bugzilla.wikimedia.org/73659#c1 (10Antoine "hashar" Musso (WMF)) 5NEW>3RESO/DUP The beta cluster Jenkins slave (deployment-bastion) ends up having all its executing slots locked by the Gearman plugin. The only way t... [16:36:45] (03CR) 10Jhernandez: "I'm leaving it at this. Use either patchset 1 (bare with duplicated jshint checking) or 3 (new template without jslint), or improve them a" [integration/config] - 10https://gerrit.wikimedia.org/r/174696 (owner: 10Jdlrobson) [16:40:03] hashar: So you agree we should subst the unittests template in https://gerrit.wikimedia.org/r/#/c/174696/2 and them in there directly (except for jslint in tests/gate) [16:41:18] (03CR) 10Hashar: [C: 032] "Seems to achieve something: https://integration.wikimedia.org/ci/job/browsertests-VisualEditor-language-screenshot-windows_8.1-firefox/2/" [integration/config] - 10https://gerrit.wikimedia.org/r/174660 (owner: 10Zfilipin) [16:41:48] Krinkle: I would move jslint to its own template [16:41:59] so we can still edit all repos easily by editing unittests [16:42:04] or just expand everything as you propose [16:42:11] I can't really make a choice between both options [16:42:30] it is probably easier to expand the template as you suggested [16:42:30] hashar: That's a big unrelated change [16:42:48] yeah that is why I proposed to merge their change and have another change that do the split [16:42:53] but it is probably not worth it [16:43:05] so yeah expand [16:43:05] I've added a dozen npm jobs so far [16:43:13] always expanded. having two jsint jobs is not an option. [16:43:22] anyother option is fine by me. [16:43:28] yeah I take your point [16:43:36] so lets expand :] [16:43:37] I agree we should refactor the templates. [16:43:51] I'd love for a extensions-modern template that does npm, composer and qunit. [16:44:23] or, since not all projects have both, probably don't need a template [16:44:36] eg. some repos have npm, others composer, some both, and some have qunit. [16:44:41] They kind of already are a template. [16:44:56] I'd like to run phpcs and phplint inside composer test [16:44:58] (03Merged) 10jenkins-bot: Created job for VisualEditor screenshots that runs using Sauce Labs [integration/config] - 10https://gerrit.wikimedia.org/r/174660 (owner: 10Zfilipin) [16:45:48] hashar: What would you think of that? composer scripts.test: "php -l .. && phpunit && phpcs .. " [16:47:14] yeah I thought about that overnight [16:47:18] well differently [16:47:32] in npm, you have grunt plugins added by the developers that provides some tests capabiilities [16:47:52] in php / composer world, we could craft php bricks that would provide the php linting [16:48:13] so one could require: wikimedia/phplint phpunit/phpunit whatever/phpcs [16:48:26] and have their "test" run script executes whatever commands are provided [16:53:28] hashar: I'm currently using parallel-lint in a few non-wikimedia repos for php [16:53:49] https://github.com/Krinkle/intuition/blob/master/tests/run [16:54:00] I've also creeped it into github projects for wikimedia such as php-cssjanus and nagf [16:54:07] https://github.com/wikimedia/nagf/blob/master/.travis.yml [16:54:17] https://github.com/cssjanus/php-cssjanus/blob/master/composer.json#L19 [16:54:54] the last one being the most integrated [16:55:14] phpunit is the best, no arguments [16:55:25] I'm trying to simplify the others too, but still a fair amount of cruft [17:27:58] (03CR) 10Filippo Giunchedi: "+1, sounds like a better idea. abandoning this for now." [integration/zuul] - 10https://gerrit.wikimedia.org/r/174691 (owner: 10Filippo Giunchedi) [17:28:06] (03Abandoned) 10Filippo Giunchedi: merge job timing stats together [integration/zuul] - 10https://gerrit.wikimedia.org/r/174691 (owner: 10Filippo Giunchedi) [17:29:39] (03PS1) 10Krinkle: [WIP] Experimental mediawiki-core-qunit-labsSlave [integration/config] - 10https://gerrit.wikimedia.org/r/174731 [17:30:25] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Experimental mediawiki-core-qunit-labsSlave [integration/config] - 10https://gerrit.wikimedia.org/r/174731 (owner: 10Krinkle) [17:54:53] (03PS2) 10Krinkle: [WIP] Experimental mediawiki-core-qunit-labsSlave [integration/config] - 10https://gerrit.wikimedia.org/r/174731 [17:57:11] (03PS4) 10Krinkle: Add mwext-MobileFrontend-npm job [integration/config] - 10https://gerrit.wikimedia.org/r/174696 (https://bugzilla.wikimedia.org/72598) (owner: 10Jdlrobson) [17:57:23] (03PS5) 10Krinkle: Add mwext-MobileFrontend-npm job [integration/config] - 10https://gerrit.wikimedia.org/r/174696 (https://bugzilla.wikimedia.org/72598) (owner: 10Jdlrobson) [18:01:09] (03CR) 10Krinkle: "It should still run jslint in the 'check' pipeline. As we currently do for various projects and extensions (mediawiki-core, mwext-VisualEd" [integration/config] - 10https://gerrit.wikimedia.org/r/174696 (https://bugzilla.wikimedia.org/72598) (owner: 10Jdlrobson) [18:01:13] (03CR) 10Krinkle: [C: 04-1] Add mwext-MobileFrontend-npm job [integration/config] - 10https://gerrit.wikimedia.org/r/174696 (https://bugzilla.wikimedia.org/72598) (owner: 10Jdlrobson) [18:15:52] (03CR) 10Krinkle: [C: 04-1] "The provided use case was solved in a different manner and was arguably a real bug we caught this way. Maybe instead skip dead symlinks in" [integration/jenkins] - 10https://gerrit.wikimedia.org/r/174047 (owner: 10Cscott) [18:37:58] Yippee, build fixed! [18:37:58] Project browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-windows_7-internet_explorer-11-sauce build #87: FIXED in 35 min: https://integration.wikimedia.org/ci/job/browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-windows_7-internet_explorer-11-sauce/87/ [19:14:38] Yippee, build fixed! [19:14:38] Project browsertests-VisualEditor-en.wikipedia.beta.wmflabs.org-linux-firefox-sauce build #420: FIXED in 1 hr 16 min: https://integration.wikimedia.org/ci/job/browsertests-VisualEditor-en.wikipedia.beta.wmflabs.org-linux-firefox-sauce/420/ [19:19:10] (03CR) 10Cscott: "It was solved by writing a custom jenkins task which skips json-lint entirely. I thought we both agreed that that was not a desirable lon" [integration/jenkins] - 10https://gerrit.wikimedia.org/r/174047 (owner: 10Cscott) [19:42:41] Yippee, build fixed! [19:42:41] Project browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-windows_8.1-internet_explorer-11-sauce build #141: FIXED in 36 min: https://integration.wikimedia.org/ci/job/browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-windows_8.1-internet_explorer-11-sauce/141/ [19:54:02] (03CR) 10Jdlrobson: "krinkle please can you update this?" [integration/config] - 10https://gerrit.wikimedia.org/r/174696 (https://bugzilla.wikimedia.org/72598) (owner: 10Jdlrobson) [19:55:19] (03PS6) 10Jdlrobson: Add mwext-MobileFrontend-npm job [integration/config] - 10https://gerrit.wikimedia.org/r/174696 [20:06:29] (03PS7) 10Jdlrobson: Add mwext-MobileFrontend-npm job [integration/config] - 10https://gerrit.wikimedia.org/r/174696 [20:09:03] (03PS8) 10Krinkle: Add mwext-MobileFrontend-npm job [integration/config] - 10https://gerrit.wikimedia.org/r/174696 (owner: 10Jdlrobson) [20:12:31] (03CR) 10jenkins-bot: [V: 04-1] Add mwext-MobileFrontend-npm job [integration/config] - 10https://gerrit.wikimedia.org/r/174696 (owner: 10Jdlrobson) [20:17:01] (03PS9) 10Krinkle: Add mwext-MobileFrontend-npm job [integration/config] - 10https://gerrit.wikimedia.org/r/174696 (owner: 10Jdlrobson) [20:20:31] (03CR) 10jenkins-bot: [V: 04-1] Add mwext-MobileFrontend-npm job [integration/config] - 10https://gerrit.wikimedia.org/r/174696 (owner: 10Jdlrobson) [20:21:23] Yippee, build fixed! [20:21:24] Project browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-os_x_10.9-safari-sauce build #296: FIXED in 1 hr 7 min: https://integration.wikimedia.org/ci/job/browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-os_x_10.9-safari-sauce/296/ [20:25:17] Project beta-scap-eqiad build #30543: FAILURE in 1 min 16 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/30543/ [20:26:32] (03PS10) 10Krinkle: Add mwext-MobileFrontend-npm job [integration/config] - 10https://gerrit.wikimedia.org/r/174696 (owner: 10Jdlrobson) [20:31:33] (03CR) 10Krinkle: [C: 031] "lint (for php) and textextension (for phpunit) were removed. I've added those back. And also the mediawiki-gate job which the extension-un" [integration/config] - 10https://gerrit.wikimedia.org/r/174696 (owner: 10Jdlrobson) [20:35:03] Yippee, build fixed! [20:35:04] Project beta-scap-eqiad build #30544: FIXED in 1 min 8 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/30544/ [20:39:27] (03PS1) 10Anomie: Add testing for mediawiki/extensions/ApiFeatureUsage [integration/config] - 10https://gerrit.wikimedia.org/r/174797 [21:09:09] 3Wikimedia / 3Continuous integration: Jenkins: Assert no PHP errors (notices, warnings) were raised or exceptions were thrown - 10https://bugzilla.wikimedia.org/48002 (10Krinkle) 5NEW>3ASSI [21:09:10] 3Wikimedia / 3Continuous integration: Jenkins: Assert no PHP errors (notices, warnings) were raised or exceptions were thrown - 10https://bugzilla.wikimedia.org/48002#c11 (10Krinkle) Since I added a MediaWiki log group for php errors (notices and warnings) we no longer need to get them via the apache2 log or... [21:09:12] 3Wikimedia / 3Continuous integration: Jenkins: Assert no PHP errors (notices, warnings) were raised or exceptions were thrown - 10https://bugzilla.wikimedia.org/48002 (10Krinkle) p:5Low>3Normal a:3Krinkle [21:14:34] (03CR) 10Hashar: "It is missing:" [integration/config] - 10https://gerrit.wikimedia.org/r/174696 (owner: 10Jdlrobson) [21:15:40] (03PS11) 10Hashar: Add mwext-MobileFrontend-npm job [integration/config] - 10https://gerrit.wikimedia.org/r/174696 (owner: 10Jdlrobson) [21:21:08] (03CR) 10Hashar: [C: 032] "Job updated. Will deploy the Zuul configuration once the change is merged." [integration/config] - 10https://gerrit.wikimedia.org/r/174696 (owner: 10Jdlrobson) [21:22:36] (03PS1) 10Krinkle: mediawiki: Configure 'error' and 'exception' log groups [integration/jenkins] - 10https://gerrit.wikimedia.org/r/174810 (https://bugzilla.wikimedia.org/48002) [21:24:31] (03Merged) 10jenkins-bot: Add mwext-MobileFrontend-npm job [integration/config] - 10https://gerrit.wikimedia.org/r/174696 (owner: 10Jdlrobson) [21:46:24] (03CR) 10Hashar: [C: 031] "Note that will move the exception and error logs OUT of the main debug log file. It is fine to me but might be an unexpected side effect " [integration/jenkins] - 10https://gerrit.wikimedia.org/r/174810 (https://bugzilla.wikimedia.org/48002) (owner: 10Krinkle) [21:48:04] greg-g: did you get emails from shinken just now? [21:48:25] yuvipanda: yes [21:48:33] deployment-restbase02/Puppet failure is CRITICAL [21:48:43] wheeee [21:48:49] looks like I've fixed email [21:48:57] now it'll email you once an... hour. I think. until it gets fixed. [22:00:55] greg-g: you might get some spam from shinken again, apologies. just testing email notifications, which have been flaky of late [22:01:12] so do not panic [22:01:17] chrismcmahon: ^ [22:01:19] yuvipanda: I just got 20. I [22:01:28] I'm not panicking :-) [22:01:34] yeah, do not :) [22:01:41] it'll also send you some more in a bit when it 'recovers' [22:01:44] these I'm just triggering [22:01:49] email delivery was fairly unreliable [22:01:53] but seems ok now [22:16:33] chrismcmahon: greg-g ok, testing subsided. any new emails point to real issues [22:16:46] :) [22:16:49] chrismcmahon: greg-g thanks for putting up with the spam! I'll try to figure ways around it for the next time [22:18:14] * yuvipanda waves off for the night [22:23:00] Yippee, build fixed! [22:23:00] Project browsertests-Flow-en.wikipedia.beta.wmflabs.org-linux-chrome-sauce build #336: FIXED in 1 hr 0 min: https://integration.wikimedia.org/ci/job/browsertests-Flow-en.wikipedia.beta.wmflabs.org-linux-chrome-sauce/336/ [23:46:56] Project beta-scap-eqiad build #30560: FAILURE in 22 min: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/30560/ [23:55:33] Yippee, build fixed! [23:55:34] Project beta-scap-eqiad build #30562: FIXED in 1 min 38 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/30562/