[00:02:01] 3Continuous-Integration: Android app build: Gradle checkstyle + app build - https://phabricator.wikimedia.org/T88494#1013292 (10bearND) 3NEW [00:03:00] 3Continuous-Integration: Jenkins jobs involving npm-test often failing due to symlink 'esprima/bin/esparse.js' conflict - https://phabricator.wikimedia.org/T88395#1013303 (10Krinkle) 5Open>3Resolved [00:08:28] (03CR) 10Krinkle: "That's not the reality. See T88015." [integration/config] - 10https://gerrit.wikimedia.org/r/188052 (owner: 10Hashar) [00:10:42] 3MediaWiki-extensions-ZeroPortal, MediaWiki-extensions-ZeroBanner, Continuous-Integration: Jenkins must not load ZeroPortal before ZeroBanner - https://phabricator.wikimedia.org/T88015#1013335 (10Krinkle) @hashar Yeah, but that's not the reality right now. At the moment https://gerrit.wikimedia.org/r/188115 has... [00:10:50] 3MediaWiki-extensions-ZeroPortal, MediaWiki-extensions-ZeroBanner, Continuous-Integration: Jenkins must not load ZeroPortal before ZeroBanner - https://phabricator.wikimedia.org/T88015#1013336 (10Krinkle) 5Open>3Resolved [01:31:44] PROBLEM - Free space - all mounts on deployment-bastion is CRITICAL: CRITICAL: deployment-prep.deployment-bastion.diskspace._var.byte_percentfree.value (<22.22%) [01:56:05] (03CR) 10Jhobs: [C: 031] Step definitions refactored for the EAL [selenium] - 10https://gerrit.wikimedia.org/r/188102 (owner: 10Dduvall) [02:14:41] Project beta-scap-eqiad build #40164: FAILURE in 43 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/40164/ [02:34:57] Yippee, build fixed! [02:34:57] Project beta-scap-eqiad build #40166: FIXED in 59 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/40166/ [03:28:10] Project browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-os_x_10.9-safari-sauce build #447: FAILURE in 18 min: https://integration.wikimedia.org/ci/job/browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-os_x_10.9-safari-sauce/447/ [03:29:50] Project browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-windows_8.1-internet_explorer-11-sauce build #293: FAILURE in 22 min: https://integration.wikimedia.org/ci/job/browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-windows_8.1-internet_explorer-11-sauce/293/ [03:41:10] Yippee, build fixed! [03:41:10] Project browsertests-CirrusSearch-en.wikipedia.beta.wmflabs.org-linux-firefox-sauce build #430: FIXED in 1 min 5 sec: https://integration.wikimedia.org/ci/job/browsertests-CirrusSearch-en.wikipedia.beta.wmflabs.org-linux-firefox-sauce/430/ [05:00:09] Yippee, build fixed! [05:00:09] Project browsertests-MobileFrontend-test2.m.wikipedia.org-linux-firefox-sauce build #449: FIXED in 35 min: https://integration.wikimedia.org/ci/job/browsertests-MobileFrontend-test2.m.wikipedia.org-linux-firefox-sauce/449/ [05:30:38] 3Quality-Assurance: audit/update headers in files - https://phabricator.wikimedia.org/T69141#1013667 (10Mattflaschen) This is still present. Preferably, files should be subject to terms given in the same repository as the file. E.g. the PageTriage extension has headers [like this](https://git.wikimedia.org/blo... [06:35:34] PROBLEM - Host deployment-mediawiki01 is DOWN: CRITICAL - Host Unreachable (10.68.17.96) [06:36:43] RECOVERY - Free space - all mounts on deployment-bastion is OK: OK: All targets OK [06:37:04] PROBLEM - Host deployment-mediawiki04 is DOWN: CRITICAL - Host Unreachable (10.68.16.127) [06:41:18] 3MediaWiki-extensions-CLDR, MediaWiki-extensions-UniversalLanguageSelector, Continuous-Integration, MediaWiki-extensions-Babel: Add i18n team extensions to mediawiki-phpunit-(zend|hhvm) - https://phabricator.wikimedia.org/T86930#1013763 (10hashar) p:5Triage>3Normal [06:47:30] Project UploadWizard-api-commons.wikimedia.beta.wmflabs.org build #1414: FAILURE in 1 min 30 sec: https://integration.wikimedia.org/ci/job/UploadWizard-api-commons.wikimedia.beta.wmflabs.org/1414/ [06:47:41] (03PS1) 10Hashar: Add Translate to the shared mw job [integration/config] - 10https://gerrit.wikimedia.org/r/188518 (https://phabricator.wikimedia.org/T86930) [06:48:42] 3MediaWiki-extensions-CLDR, MediaWiki-extensions-UniversalLanguageSelector, Continuous-Integration, MediaWiki-extensions-Babel: Add i18n team extensions to mediawiki-phpunit-(zend|hhvm) - https://phabricator.wikimedia.org/T86930#1013769 (10hashar) Translate pass as well (dummy change https://gerrit.wikimedia.org... [06:48:59] 3MediaWiki-extensions-CLDR, MediaWiki-extensions-UniversalLanguageSelector, Continuous-Integration, MediaWiki-extensions-Babel: Add i18n team extensions to mediawiki-phpunit-(zend|hhvm) - https://phabricator.wikimedia.org/T86930#1013770 (10hashar) [06:49:52] (03CR) 10Hashar: [C: 032] Add Translate to the shared mw job [integration/config] - 10https://gerrit.wikimedia.org/r/188518 (https://phabricator.wikimedia.org/T86930) (owner: 10Hashar) [06:56:09] Project beta-scap-eqiad build #40191: FAILURE in 22 min: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/40191/ [06:57:55] (03Merged) 10jenkins-bot: Add Translate to the shared mw job [integration/config] - 10https://gerrit.wikimedia.org/r/188518 (https://phabricator.wikimedia.org/T86930) (owner: 10Hashar) [07:15:38] RECOVERY - Host deployment-mediawiki01 is UP: PING OK - Packet loss = 0%, RTA = 1.01 ms [07:16:00] 3MediaWiki-extensions-Translate, MediaWiki-extensions-UniversalLanguageSelector, MediaWiki-extensions-CLDR, Continuous-Integration, MediaWiki-extensions-Babel: Add i18n team extensions to mediawiki-phpunit-(zend|hhvm) - https://phabricator.wikimedia.org/T86930#1013795 (10hashar) Translate has been added. [07:16:07] 3MW-RFCs, ArchCom, Continuous-Integration: RFC: Extensions continuous integration - https://phabricator.wikimedia.org/T1350#1013798 (10hashar) [07:16:09] 3MediaWiki-extensions-Translate, MediaWiki-extensions-UniversalLanguageSelector, MediaWiki-extensions-CLDR, Continuous-Integration, MediaWiki-extensions-Babel: Add i18n team extensions to mediawiki-phpunit-(zend|hhvm) - https://phabricator.wikimedia.org/T86930#1013797 (10hashar) 5Open>3Resolved [07:19:43] 3Phabricator: Search on phabricator is utterly broken and unusable - https://phabricator.wikimedia.org/T88514#1013813 (10Joe) 3NEW [07:56:50] (03PS4) 10Adrian Lang: Add npm job to wikibase [integration/config] - 10https://gerrit.wikimedia.org/r/184592 [07:56:52] (03PS1) 10Adrian Lang: Drop jslint job from Wikibase [integration/config] - 10https://gerrit.wikimedia.org/r/188522 [07:59:16] (03CR) 10Adrian Lang: "Dropped jslint in a follow-up." [integration/config] - 10https://gerrit.wikimedia.org/r/184592 (owner: 10Adrian Lang) [08:13:45] 3Code-Review, Engineering-Community: How to prioritize code review of patches submitted by volunteers - https://phabricator.wikimedia.org/T78768#1013878 (10Qgil) [08:15:50] 3MediaWiki-extensions-Translate, MediaWiki-extensions-UniversalLanguageSelector, MediaWiki-extensions-CLDR, Continuous-Integration, MediaWiki-extensions-Babel: Add i18n team extensions to mediawiki-phpunit-(zend|hhvm) - https://phabricator.wikimedia.org/T86930#1013881 (10Nemo_bis) [08:25:24] 3Code-Review, Engineering-Community: How to prioritize code review of patches submitted by volunteers - https://phabricator.wikimedia.org/T78768#1013886 (10Qgil) What about organizing a Gerrit Cleanup Day? * A full day of code review. * Focusing on oldest changesets first ** waiting for a first review ** +1 wai... [08:38:17] RECOVERY - Puppet failure on deployment-test is OK: OK: Less than 1.00% above the threshold [0.0] [08:40:34] (03PS1) 10Hashar: Create qunit job for the Thanks extension [integration/config] - 10https://gerrit.wikimedia.org/r/188527 (https://phabricator.wikimedia.org/T86866) [08:49:43] (03CR) 10Hashar: "I am not sure whether we need a qunit-mobile job as well. A build against master branch pass https://integration.wikimedia.org/ci/job/mwex" [integration/config] - 10https://gerrit.wikimedia.org/r/188527 (https://phabricator.wikimedia.org/T86866) (owner: 10Hashar) [08:50:34] 3Thanks, Continuous-Integration: Thanks needs Jenkins qunit job - https://phabricator.wikimedia.org/T86866#1013898 (10hashar) I am not sure whether we need a qunit-mobile job as well. A build against master branch pass https://integration.wikimedia.org/ci/job/mwext-Thanks-qunit/1/console Note: this job only tr... [08:53:26] 3MediaWiki-extensions-ZeroPortal, MediaWiki-extensions-ZeroBanner, Continuous-Integration: Jenkins must not load ZeroPortal before ZeroBanner - https://phabricator.wikimedia.org/T88015#1013922 (10hashar) > I noticed change rCICF49e703cb8592: Ensure extensions are loaded in a consistent order 49e703cb859 was brok... [08:54:25] 3Thanks, Continuous-Integration: Thanks needs Jenkins qunit job - https://phabricator.wikimedia.org/T86866#1013932 (10hashar) [08:55:10] 3Continuous-Integration: Merge extensions PHPUnit and QUnit jobs - https://phabricator.wikimedia.org/T88207#1013934 (10hashar) [08:56:25] 3Continuous-Integration: Merge extensions PHPUnit and QUnit jobs - https://phabricator.wikimedia.org/T88207#1006104 (10hashar) That would help making sure extensions do not break each other QUnit tests. For example a mobile extension change breaking Thanks as a side effect ( T86687 ). [09:00:18] 3Wikidata, Continuous-Integration, MediaWiki-extensions-WikibaseRepository: jenkins job to generate wikibase.git coverage - https://phabricator.wikimedia.org/T88434#1013952 (10hashar) p:5Triage>3Volunteer? Lacking spare cycles to work on it. One will have to figure out how it can be done. [09:19:33] 3Code-Review, Engineering-Community: How to prioritize code review of patches submitted by volunteers - https://phabricator.wikimedia.org/T78768#1013963 (10jayvdb) +1 To prioritise changesets by volunteers, I suggest that we build a list (in advance) of patches ordered by people with the least number of patches... [09:27:23] 3Code-Review, Engineering-Community: How to prioritize code review of patches submitted by volunteers - https://phabricator.wikimedia.org/T78768#1013975 (10scfc) I don't think increasing the review work would have a positive impact on volunteers ("you only need to wait one quarter for a review!"). If WMF wants... [09:35:24] 3Code-Review, Engineering-Community: How to prioritize code review of patches submitted by volunteers - https://phabricator.wikimedia.org/T78768#1013989 (10Reedy) >>! In T78768#1013975, @scfc wrote: > I don't think increasing the review work would have a positive impact on volunteers ("you only need to wait one... [09:55:34] 3Code-Review, Engineering-Community: How to prioritize code review of patches submitted by volunteers - https://phabricator.wikimedia.org/T78768#1014013 (10scfc) Something unreviewable can get a -1 immediately (or WMF could just use their discretion to not pay people trying to game the system). Looking at the W... [10:27:54] !logbeta-scap-eqiad job is broken because mwdeploy can no more ssh from deployment-bastion to deployment-mediawiki01 [10:29:21] stupid qa-morebots [10:30:41] hashar: hi [10:30:44] hashar: that's probably me [10:30:51] !log piok [10:30:53] Logged the message, Master [10:30:54] hashar: I deleted and re-created deployment-mediawiki01 [10:30:57] !logbeta-scap-eqiad job is broken because mwdeploy can no more ssh from deployment-bastion to deployment-mediawiki01 [10:30:59] and am going to do so for deployment-mediawiki02 [10:31:07] YuviPanda: found that :-D [10:31:08] where are the keys set? [10:31:13] the ssh host key has been changed [10:31:17] and I have no idea how to set it [10:31:21] haha :) [10:31:35] also need to have the instance to point to beta cluster salt/puppet masters :-D [10:31:40] hashar: it does [10:34:49] I don't understand how the host keys are validated [10:35:05] /home/mwdeploy/.ssh/ does not have any known_hosts file [10:38:36] global? [10:39:09] 3Code-Review, Engineering-Community: How to prioritize code review of patches submitted by volunteers - https://phabricator.wikimedia.org/T78768#1014053 (10jayvdb) >>! In T78768#1013975, @scfc wrote: > I don't think increasing the review work would have a positive impact on volunteers ("you only need to wait one... [10:43:21] 3Beta-Cluster: beta-scap-eqiad job is broken: can not ssh to deployment-mediawiki01.eqiad.wmflabs - https://phabricator.wikimedia.org/T88529#1014069 (10hashar) 3NEW [10:43:45] !log beta-scap-eqiad job is broken because mwdeploy can no more ssh from deployment-bastion to deployment-mediawiki01 . Filled as {{bug|T88529}} [10:43:48] Logged the message, Master [10:45:12] pid 20235] open("/etc/ssh/ssh_known_hosts", O_RDONLY) = -1 ENOENT (No such file or directory) [10:45:13] [pid 20235] open("/etc/ssh/ssh_known_hosts2", O_RDONLY) = -1 ENOENT (No such file or directory) [10:45:16] Reedy: if only ^^^ :( [10:49:18] * hashar gives up [10:49:58] hashar: it's not a hostkey issue [10:50:06] hashar: it's mwdeploy user's key not being verified [10:50:08] which is strange [10:50:11] hashar: I'm looking into it [10:51:08] YuviPanda: good luck :-] [10:55:39] I have no idea how this ever worked before [11:10:36] Yippee, build fixed! [11:10:36] Project beta-scap-eqiad build #40219: FIXED in 1 min 15 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/40219/ [11:24:41] PROBLEM - App Server bits response on deployment-mediawiki02 is CRITICAL: Connection refused [11:24:48] 3Beta-Cluster: beta-scap-eqiad job is broken: can not ssh to deployment-mediawiki01.eqiad.wmflabs - https://phabricator.wikimedia.org/T88529#1014100 (10yuvipanda) 5Open>3Resolved a:3yuvipanda I had just forgotten to apply the beta specific scap role (which I haven't managed to kill yet). Applying it fixed... [11:25:09] PROBLEM - App Server Main HTTP Response on deployment-mediawiki02 is CRITICAL: Connection refused [11:29:41] RECOVERY - App Server bits response on deployment-mediawiki02 is OK: HTTP OK: HTTP/1.1 200 OK - 3895 bytes in 0.003 second response time [11:30:11] RECOVERY - App Server Main HTTP Response on deployment-mediawiki02 is OK: HTTP OK: HTTP/1.1 200 OK - 49081 bytes in 0.562 second response time [11:30:45] hmm [11:30:48] this makes little sense [11:33:02] PROBLEM - Puppet failure on deployment-mediawiki02 is CRITICAL: CRITICAL: 33.33% of data above the critical threshold [0.0] [11:35:11] Project beta-scap-eqiad build #40222: FAILURE in 1 min 10 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/40222/ [11:45:54] 3Code-Review, Engineering-Community: Organize a Gerrit Cleanup Day - https://phabricator.wikimedia.org/T88531#1014128 (10Qgil) 3NEW a:3Qgil [11:46:55] 3Code-Review, Engineering-Community: Organize a Gerrit Cleanup Day - https://phabricator.wikimedia.org/T88531#1014128 (10Qgil) [12:08:00] PROBLEM - English Wikipedia Main page on beta-cluster is CRITICAL: HTTP CRITICAL: HTTP/1.1 404 Not Found - string 'Wikipedia' not found on 'http://en.wikipedia.beta.wmflabs.org:80/wiki/Main_Page?debug=true' - 793 bytes in 0.002 second response time [12:12:59] RECOVERY - English Wikipedia Main page on beta-cluster is OK: HTTP OK: HTTP/1.1 200 OK - 49269 bytes in 0.555 second response time [12:16:36] PROBLEM - English Wikipedia Mobile Main page on beta-cluster is CRITICAL: HTTP CRITICAL: HTTP/1.1 404 Not Found - string 'Wikipedia' not found on 'http://en.m.wikipedia.beta.wmflabs.org:80/wiki/Main_Page?debug=true' - 799 bytes in 0.012 second response time [12:21:34] RECOVERY - English Wikipedia Mobile Main page on beta-cluster is OK: HTTP OK: HTTP/1.1 200 OK - 29531 bytes in 0.532 second response time [12:23:58] PROBLEM - English Wikipedia Main page on beta-cluster is CRITICAL: HTTP CRITICAL: HTTP/1.1 404 Not Found - string 'Wikipedia' not found on 'http://en.wikipedia.beta.wmflabs.org:80/wiki/Main_Page?debug=true' - 793 bytes in 0.004 second response time [12:29:01] RECOVERY - English Wikipedia Main page on beta-cluster is OK: HTTP OK: HTTP/1.1 200 OK - 49269 bytes in 0.531 second response time [12:35:43] 3Phabricator: Default search should be limited to open tasks. - https://phabricator.wikimedia.org/T88533#1014179 (10daniel) 3NEW [12:44:51] Yippee, build fixed! [12:44:52] Project beta-scap-eqiad build #40226: FIXED in 54 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/40226/ [12:46:32] Yippee, build fixed! [12:46:32] Project UploadWizard-api-commons.wikimedia.beta.wmflabs.org build #1415: FIXED in 32 sec: https://integration.wikimedia.org/ci/job/UploadWizard-api-commons.wikimedia.beta.wmflabs.org/1415/ [13:11:43] 3Phabricator: Default search should be limited to open tasks. - https://phabricator.wikimedia.org/T88533#1014275 (10Qgil) See T76273#794511 [13:22:12] RECOVERY - Puppet failure on deployment-mediawiki02 is OK: OK: Less than 1.00% above the threshold [0.0] [13:42:51] Reedy: greg-g do you know if deployment-mediawiki03 is still being used? [13:46:46] 3Beta-Cluster, operations: Minimize differences between beta and production (Tracking) - https://phabricator.wikimedia.org/T87220#1014331 (10yuvipanda) [13:46:47] 3Beta-Cluster: Remove beta specific mediawiki roles - https://phabricator.wikimedia.org/T87210#1014329 (10yuvipanda) 5Open>3Resolved Re-imaged mediawiki01 and 02, and everything seems peachy! :D [13:55:27] Project beta-scap-eqiad build #40233: FAILURE in 1 min 8 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/40233/ [14:06:28] PROBLEM - Puppet failure on deployment-jobrunner01 is CRITICAL: CRITICAL: 77.78% of data above the critical threshold [0.0] [14:15:00] Yippee, build fixed! [14:15:01] Project beta-scap-eqiad build #40235: FIXED in 1 min 2 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/40235/ [14:21:27] RECOVERY - Puppet failure on deployment-jobrunner01 is OK: OK: Less than 1.00% above the threshold [0.0] [14:27:26] PROBLEM - Puppet failure on deployment-jobrunner01 is CRITICAL: CRITICAL: 44.44% of data above the critical threshold [0.0] [14:37:27] RECOVERY - Puppet failure on deployment-jobrunner01 is OK: OK: Less than 1.00% above the threshold [0.0] [14:40:53] 3MediaWiki-extensions-Translate, Continuous-Integration: mediawiki-extensions-hhvm: MessageGroupStatesUpdaterJobTest::testHooks is intermittent failing - https://phabricator.wikimedia.org/T88554#1014558 (10Se4598) 3NEW [14:43:19] 3Phabricator: Enabling Herald - https://phabricator.wikimedia.org/T630#1014570 (10Qgil) I didn't think that we would be without Herald still in February... What about a next step enabling Herald for a #Herald-Users group? wmf-nda and individually approved guests? [14:54:41] Project beta-scap-eqiad build #40239: FAILURE in 44 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/40239/ [14:56:56] 3Beta-Cluster: Migrate beta cluster jobrunner to HAT - https://phabricator.wikimedia.org/T87214#1014609 (10yuvipanda) I've migrated this to a trusty instance, and things *seem* to work. Someone with more MW knowledge should confirm. [14:57:04] Reedy: ^ can you check? [15:11:23] 3Beta-Cluster: Migrate beta cluster jobrunner to HAT - https://phabricator.wikimedia.org/T87214#1014711 (10yuvipanda) 5Open>3Resolved a:3yuvipanda Confirmed with @hoo's help that this works! \o/ [15:11:25] 3Beta-Cluster, operations: Minimize differences between beta and production (Tracking) - https://phabricator.wikimedia.org/T87220#1014715 (10yuvipanda) [15:15:08] Yippee, build fixed! [15:15:08] Project beta-scap-eqiad build #40241: FIXED in 1 min 11 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/40241/ [15:21:48] 3Wikidata, Continuous-Integration: Enable PHP_CodeSniffer for Wikibase - https://phabricator.wikimedia.org/T86538#1014783 (10Lydia_Pintscher) p:5Triage>3Normal [15:27:27] 3MediaWiki-extensions-Translate, Continuous-Integration: mediawiki-extensions-hhvm: MessageGroupStatesUpdaterJobTest::testHooks is intermittent failing - https://phabricator.wikimedia.org/T88554#1014838 (10Nikerabbit) p:5Triage>3High [15:34:54] 3Phabricator: Enabling Herald - https://phabricator.wikimedia.org/T630#1014897 (10Negative24) I would like to help test Herald. I've taken a look at some of its code before. Was T493 resolved with a Phabricator release? The latest update (T86772) doesn't mention it and I don't have any contacts to ask about it. [15:52:26] 3Thanks, Continuous-Integration: Thanks needs Jenkins qunit job - https://phabricator.wikimedia.org/T86866#1014991 (10Jdlrobson) @hashar - I'd suggest running the Thanks qunit test on MobileFrontend rather than the MobileFrontend tests on Thanks. Thanks rarely changes these days so errors tend to happen from els... [15:54:23] YuviPanda: I haven't heard from the person doing the security/fuzzing testing in a while, but theoretically maybe :) [15:54:32] twentyafterfour: greg-g FYI, todays deploy is on hold [15:54:42] Reedy: yeah, just saw that.... [15:55:03] Did ori file a ticket to have someone investigate? [15:55:49] dont' see one [15:55:59] I can do that real quick [15:56:53] Looks like brad is talking about it in -core now [15:57:00] oh wait, yeah he did https://phabricator.wikimedia.org/T88528 [15:57:08] * greg-g looks over there [16:41:16] 3Thanks, Continuous-Integration: Thanks needs Jenkins qunit job - https://phabricator.wikimedia.org/T86866#1015131 (10hashar) @jdlrobson definitely. That will be done whenever we find the time to merge the phpunit and qunit steps in the shared jobs mediawiki-extensions-hhvm and mediawiki-extensions-zend ( T8820... [16:43:42] 3Continuous-Integration: Merge extensions PHPUnit and QUnit jobs - https://phabricator.wikimedia.org/T88207#1015133 (10hashar) The Qunit step is hitting an Apache / Zend PHP 5.3 service. I am not sure whether it is going to work on the Trusty instances used for the mediawiki-extensions-hhvm job. From a discussi... [16:44:59] (03CR) 10Jeroen De Dauw: [C: 031] Add npm job to wikibase [integration/config] - 10https://gerrit.wikimedia.org/r/184592 (owner: 10Adrian Lang) [16:44:59] 3Continuous-Integration: Merge extensions PHPUnit and QUnit jobs - https://phabricator.wikimedia.org/T88207#1015134 (10hashar) Timo, if you have any good ideas to merge the PHPUnit and Qunit jobs, I would really love them. [16:45:13] (03CR) 10Jeroen De Dauw: [C: 031] Drop jslint job from Wikibase [integration/config] - 10https://gerrit.wikimedia.org/r/188522 (owner: 10Adrian Lang) [16:49:41] 3MediaWiki-extensions-ContentTranslation, Continuous-Integration, ContentTranslation-Deployments: Enable Debian CI tests on all Apertium packages - https://phabricator.wikimedia.org/T87607#1015148 (10hashar) To build Debian package via Jenkins, I am relying on the [[ http://jenkins-debian-glue.org | jenkins-debi... [16:54:55] 3MediaWiki-extensions-Translate, Continuous-Integration: mediawiki-extensions-hhvm: MessageGroupStatesUpdaterJobTest::testHooks is intermittent failing - https://phabricator.wikimedia.org/T88554#1015152 (10Se4598) now (up to build 2230) four ones: 2217, 2224, 2227 and 2230, where the two latter also has a mw-err... [16:58:07] 3MediaWiki-extensions-Translate, Continuous-Integration: mediawiki-extensions-hhvm: MessageGroupStatesUpdaterJobTest::testHooks is intermittent failing - https://phabricator.wikimedia.org/T88554#1015157 (10hashar) I have added Translate to the shared job on Feb 4th 7am UTC: https://gerrit.wikimedia.org/r/#/c/188... [16:58:31] 3MediaWiki-extensions-CLDR, MediaWiki-extensions-UniversalLanguageSelector, MediaWiki-extensions-Translate, Continuous-Integration, MediaWiki-extensions-Babel: Add i18n team extensions to mediawiki-phpunit-(zend|hhvm) - https://phabricator.wikimedia.org/T86930#979673 (10hashar) Seems to cause {T88554} [17:12:09] 3Phabricator, Wikimedia-Git-or-Gerrit: Task/Job 7092771 (PhabricatorRepositoryCommitHeraldWorker) has over 1600 failures (Importing revision) - https://phabricator.wikimedia.org/T87549#1015185 (10Se4598) new one for documentation: [[https://phabricator.wikimedia.org/daemon/task/7250335/|Task 7250335]] with 233 f... [17:14:00] 3Echo, MediaWiki-General-or-Unknown, Release-Engineering: Get JQuery error "a is undefined" running browser tests locally for Firefox - https://phabricator.wikimedia.org/T87446#1015188 (10Cmcmahon) 5Resolved>3Open p:5Unbreak!>3High [17:15:48] 3Echo, MediaWiki-General-or-Unknown, Release-Engineering: Get JQuery error "a is undefined" running browser tests locally for Firefox - https://phabricator.wikimedia.org/T87446#991347 (10Cmcmahon) I re-opened this, but I removed the VisualEditor project tag, because the problem is known to also affect Flow and M... [17:25:06] greg-g: just FYI, I'm going to ask SoS for help with this "a is undefined" bug because working around it would affect every repo and cause occasional random login failures in the tests everywhere. [17:25:12] ^^ [17:28:02] 3Release-Engineering, MediaWiki-General-or-Unknown, Echo: Get JQuery error "a is undefined" running browser tests locally for Firefox - https://phabricator.wikimedia.org/T87446#1015255 (10Cmcmahon) Here is a copy of the generic failure that is shared among all the repos: a is undefined (Selenium::WebDriver::E... [17:28:26] chrismcmahon: /me nods [17:29:51] also it really blows on Vagrant [17:36:09] 3Scrum-of-Scrums, Release-Engineering, MediaWiki-General-or-Unknown, Echo: Get JQuery error "a is undefined" running browser tests locally for Firefox - https://phabricator.wikimedia.org/T87446#1015271 (10Cmcmahon) [17:39:16] Reedy: PM ping [17:39:22] cooking time *wave* [17:50:52] A bunch of folks are in #mediawiki-core trying to work on https://phabricator.wikimedia.org/T88528 (wmf15 perf regression). Help is welcome [17:53:15] bd808: git bisect on the cluster! [/jk] [17:53:52] valhallasw`cloud: not as crazy as you might think but hard to do in practice [17:56:21] *nod*. wfProfile stuff is no longer logged? I don't see anything in the dashboards [17:58:41] 3Code-Review, Engineering-Community: How to prioritize code review of patches submitted by volunteers - https://phabricator.wikimedia.org/T78768#1015372 (10ggellerman) +1 tom prioritizing work not just by 'oldest' first [18:03:02] oh, I see the profiling method was actually changed between wmf14 and 15 [18:06:47] Yippee, build fixed! [18:06:47] Project browsertests-PageTriage-en.wikipedia.beta.wmflabs.org-linux-chrome-sauce build #392: FIXED in 45 sec: https://integration.wikimedia.org/ci/job/browsertests-PageTriage-en.wikipedia.beta.wmflabs.org-linux-chrome-sauce/392/ [18:10:10] (03CR) 10Krinkle: "T88395 / T76304" [integration/config] - 10https://gerrit.wikimedia.org/r/188288 (owner: 10Krinkle) [18:10:43] (03Abandoned) 10Krinkle: [WIP] Make -npm throttled to one per node [integration/config] - 10https://gerrit.wikimedia.org/r/188288 (owner: 10Krinkle) [18:16:19] bd808: I don't want to distract from the conversation in core, but seeing that the performance problem may be JQuery related, it would be ironic if this were also a symptom: https://phabricator.wikimedia.org/T87446 I reported Jan 23 [18:17:36] chrismcmahon: interesting. any theory how that might effect wmf15 and not wmf14? [18:18:18] bd808: none whatsoever, except that JQuery is puking all over and didn't used to. [18:18:26] *nod* [18:18:40] bd808: I have zero case for that being the culprit, but the timing is interesting [18:30:51] chrismcmahon: So the a-is-undefined is specific to Firefox and webdriver? I don't think jQuery would cause this, but using Special:BlankPage and a reduced browser test with less abstraction layers to reproduce the error would help me debug it if you want me to. [18:32:16] Krinkle: We see a-is-undefined when firing an explicit onfocus event on the "Log in" button. Behavior started Jan 23. I can repro in a Vagrant instance with MobileFrontend (and probably other repos also) [18:33:00] chrismcmahon: Hm.. that's around Firefox release date [18:33:08] Could be a regression in the protocol that Firefox ships. Have you tried downgrading to FF 34 or lower? [18:33:15] (FF35 released around then) [18:33:30] Does it apply to saucelabs firefox? [18:33:41] Krinkle: only seen locally [18:34:37] hmm, yeah, vagrant has ff35 [18:35:30] Krinkle: but googling for "a is undefined" seems to show that there is some clear error in the JQuery code [18:35:50] chrismcmahon: I googled, too, but seeing no such results [18:35:57] Yippee, build fixed! [18:35:58] Project browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-os_x_10.9-safari-sauce build #448: FIXED in 25 min: https://integration.wikimedia.org/ci/job/browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-os_x_10.9-safari-sauce/448/ [18:36:00] https://www.google.co.uk/search?q=firefox+webdriver+a+undefined [18:36:33] https://code.google.com/p/selenium/issues/detail?id=8387 [18:36:34] https://code.google.com/p/selenium/issues/detail?id=8390 [18:36:36] could be related [18:37:06] " [18:37:34] Krinkle: this one http://forum.jquery.com/topic/a-is-undefined [18:37:37] "a" is just a variable name. Googling "a is undefined" does indeed yield a few jQuery related issues (from 2013), but those are all user errors and not related (just some random thing using a vairable name 'a') [18:38:29] That's from 2011 even. jQuery has only been rewritten a dozen times since then ;-) [18:39:23] Past month: https://www.google.co.uk/search?q=%22a+is+undefined%22&tbs=qdr:m [18:39:41] Yippee, build fixed! [18:39:41] Project browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-windows_8.1-internet_explorer-11-sauce build #294: FIXED in 32 min: https://integration.wikimedia.org/ci/job/browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-windows_8.1-internet_explorer-11-sauce/294/ [18:40:30] https://www.google.co.uk/search?q=%22Selenium%3A%3AWebDriver%3A%3AError%3A%3AJavascriptError%22+undefined+firefox [18:41:35] chrismcmahon: Can you get the stack trace of the error? It's propagated from javascript, so it should have a name (TypeError, SyntaxError, ReferenceError, etc.) and stacktrace. [18:41:56] from js that is, not ruby. [18:42:21] Krinkle: I'll see what I can do. In a meeting now, will probably be later this afternoon [18:42:52] Krinkle: btw, FF35 came out Jan 26 and this error started 3 days earlier Jan 23 [18:44:10] It came out January 13 [18:44:16] 35.0.1 was January 26 [18:44:30] 35.0.1. was the 1st google result for firefox 35 [18:44:32] https://www.mozilla.org/en-US/firefox/35.0/releasenotes/ [18:45:46] Took me a while to notice, but since the selenium issue was filed Jan 15 (and didn't mention Beta), figured there must've been an earlier release, and there was :) [18:56:30] 3Scrum-of-Scrums, Release-Engineering, MediaWiki-General-or-Unknown, Echo: Get JQuery error "a is undefined" running browser tests locally for Firefox - https://phabricator.wikimedia.org/T87446#1015517 (10Cmcmahon) Errors in the console when this happens: {F37201} [18:57:00] Krinkle: are those errors helpful? that's in the browser when the error occurs [18:57:04] ^^ [18:59:17] wingswednesday: gerrit rights request when you get a chance; not urgent -- https://www.mediawiki.org/w/index.php?title=Gerrit/Project_ownership&diff=1394988&oldid=1392799 [18:59:19] 3Phabricator.org, Phabricator: "Resolved" should be the first (default) option in "Change Status" action - https://phabricator.wikimedia.org/T548#1015536 (10Qgil) [19:22:13] Yippee, build fixed! [19:22:14] Project browsertests-PageTriage-en.wikipedia.beta.wmflabs.org-linux-firefox-sauce build #388: FIXED in 1 min 1 sec: https://integration.wikimedia.org/ci/job/browsertests-PageTriage-en.wikipedia.beta.wmflabs.org-linux-firefox-sauce/388/ [19:40:22] PROBLEM - Puppet failure on deployment-pdf01 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [20:10:18] 3Thanks, Continuous-Integration: Thanks needs Jenkins qunit job - https://phabricator.wikimedia.org/T86866#1015783 (10Mattflaschen) >>! In T86866#1014991, @Jdlrobson wrote: > @hashar - I'd suggest running the Thanks qunit test on MobileFrontend rather than the MobileFrontend tests on Thanks. I agree. Thanks's... [20:16:40] 3Phabricator: Task creation by email is unclear - https://phabricator.wikimedia.org/T865#1015791 (10Qgil) [20:19:23] 3Phabricator: Task creation by email is unclear - https://phabricator.wikimedia.org/T865#1015796 (10ori) IMO, we should simply drop the feature. Having a single, canonical workflow that can be concisely expressed seems vastly more desirable. See . [20:20:12] 3Code-Review: GitHub->Phabricator bridge for new contributors - https://phabricator.wikimedia.org/T173#1015797 (10Qgil) [20:20:15] 3Code-Review: Arcanist installer for Windows - https://phabricator.wikimedia.org/T172#1015801 (10Qgil) [20:20:16] 3Code-Review: Running `arc diff` twice on the same commit creates another redundant diff within the same differential - https://phabricator.wikimedia.org/T137#1015802 (10Qgil) [20:20:17] 3Code-Review: Editing files and contributing changes via web - https://phabricator.wikimedia.org/T409#1015799 (10Qgil) [20:20:19] 3Code-Review: Arcanist isn't packaged in Fedora, Debian, or Ubuntu - https://phabricator.wikimedia.org/T133#1015800 (10Qgil) [20:20:20] 3Code-Review: Landing a patch with arc currently will sometimes strip author information - https://phabricator.wikimedia.org/T612#1015804 (10Qgil) [20:20:21] 3Code-Review: Allow viewing diffs of single commits within a Differential - https://phabricator.wikimedia.org/T125#1015803 (10Qgil) [20:22:44] 3WMF-Design, Phabricator: Migration of the Design team to Phabricator - https://phabricator.wikimedia.org/T832#1015811 (10Qgil) [20:24:51] 3Scrum-of-Scrums, Release-Engineering, MediaWiki-General-or-Unknown, Echo: Get JQuery error "a is undefined" running browser tests locally for Firefox - https://phabricator.wikimedia.org/T87446#1015829 (10Mattflaschen) Note, the errors in that screenshot are all from inside the Firefox browser itself (and/or ext... [20:25:57] 3Phabricator: Add IRC name and MediaWiki Username as alternate auto-complete lookups - https://phabricator.wikimedia.org/T877#1015833 (10Qgil) [20:27:04] 3MediaWiki-Core-Team, Librarization, Deployment-Systems: Have a check for reported security issues in dependencies - https://phabricator.wikimedia.org/T74193#1015834 (10Krenair) [20:36:31] 3Scrum-of-Scrums, Release-Engineering, MediaWiki-General-or-Unknown, Echo: Get JQuery error "a is undefined" running browser tests locally for Firefox - https://phabricator.wikimedia.org/T87446#1015857 (10Mattflaschen) Also, the main errors in that screenshot appears to be two file not found errors in a WebDrive... [20:37:03] 3RESTBase, Continuous-Integration: Publish RESTBase documentation on doc.wikimedia.org - https://phabricator.wikimedia.org/T87702#1015859 (10Jdouglas) a:3Jdouglas [20:37:32] 3RESTBase, Continuous-Integration: Publish RESTBase documentation on doc.wikimedia.org - https://phabricator.wikimedia.org/T87702#996961 (10Jdouglas) [20:53:49] 3RESTBase, Continuous-Integration: Publish RESTBase documentation on doc.wikimedia.org - https://phabricator.wikimedia.org/T87702#1015902 (10Qgil) [20:56:53] 3Phabricator: Task creation by email is unclear - https://phabricator.wikimedia.org/T865#1015905 (10Qgil) As far as I know, task creation via email is part of a feature required by Operations, in relation to Procurement. Besides, I don't think we can drop the feature via configuration. Honestly, I don't see an... [21:13:27] hi marxarelli what's your opinion of removing the "onfocus" event from shared code at https://github.com/wikimedia/mediawiki-selenium/blob/master/lib/mediawiki_selenium/support/pages/login_page.rb ? It's causing the Firefox to throw a fatal javascript error for the last couple weeks. [21:14:05] chrismcmahon: sec. 1:1 [21:14:08] I put it in there because we would from time to time get a mis-click and a flaky failed login [21:14:12] marxarelli: sure, thanks [21:14:43] Project beta-scap-eqiad build #40274: FAILURE in 42 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/40274/ [21:22:52] 3RESTBase, Continuous-Integration: Publish RESTBase documentation on doc.wikimedia.org - https://phabricator.wikimedia.org/T87702#1015946 (10Jdouglas) @hashar Awesome, that looks like what we need. Where do we put the job definition? Something like `/.jenkins.yml`? [21:31:33] 3Phabricator: Task creation by email is unclear - https://phabricator.wikimedia.org/T865#1015976 (10ori) >>! In T865#1015905, @Qgil wrote: > As far as I know, task creation via email is part of a feature required by Operations, in relation to Procurement. > > Besides, I don't think we can drop the feature via c... [21:35:08] (03PS1) 10Cmcmahon: Remove explicit onfocus [selenium] - 10https://gerrit.wikimedia.org/r/188670 [21:36:24] (03PS2) 10Bartosz Dziewoński: Remove explicit onfocus [selenium] - 10https://gerrit.wikimedia.org/r/188670 (owner: 10Cmcmahon) [21:39:16] (03CR) 10Dduvall: [C: 031] "Depending on the severity of the bug, we might need to backport this to a v0.4 branch for use with current test suites." [selenium] - 10https://gerrit.wikimedia.org/r/188670 (owner: 10Cmcmahon) [21:40:47] Yippee, build fixed! [21:40:47] Project beta-scap-eqiad build #40276: FIXED in 5 min 52 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/40276/ [21:41:30] chrismcmahon: have you tested that fix? [21:41:40] marxarelli: yes [21:42:44] marxarelli: you mean removing 'onfocus'? yes, I am certain that removing it stops the 'a is undefined' error. and I'm chatting in #selenium now where Adam Goucher suggested that FF doesn't support native events any longer [21:43:14] I'd like to hear it from David Burns or someone else at Moz, but they don't seem to be around. [21:44:40] marxarelli I can check in my bogus test case if you want to see it. [21:44:43] chrismcmahon: great. i'll go ahead and +2 it, created a 0.4 branch, and [21:44:50] cherry pick it [21:44:53] chrismcmahon: no, that's fine [21:45:04] awesome I think it's the right thing to do. [21:45:06] just making sure before i do a release [21:46:57] I guess it's kind of a kluge. The "Log in" button used to load weirdly, hopefully it's healthier today than it was when we wrote this code :-) [21:47:57] (03CR) 10Dduvall: [C: 032] Remove explicit onfocus [selenium] - 10https://gerrit.wikimedia.org/r/188670 (owner: 10Cmcmahon) [21:48:16] (03Merged) 10jenkins-bot: Remove explicit onfocus [selenium] - 10https://gerrit.wikimedia.org/r/188670 (owner: 10Cmcmahon) [21:51:42] do we have any conventions for cherry picks, btw? [21:52:11] like references to the other gerrit change, etc. [21:52:39] marxarelli: none that I know of [21:58:42] (03PS1) 10Dduvall: Remove explicit onfocus [selenium] (0.4) - 10https://gerrit.wikimedia.org/r/188675 [21:59:00] (03CR) 10jenkins-bot: [V: 04-1] Remove explicit onfocus [selenium] (0.4) - 10https://gerrit.wikimedia.org/r/188675 (owner: 10Dduvall) [22:00:25] greg-g: Do you have a feel for when/if wmf15 will get deployed (and, for that matter, wmf16 will get cut)? [22:00:50] James_F: see -operations, short answer: tomorrow [22:00:50] greg-g: Oh, no matter, seen your comments in -operations. [22:00:52] :) [22:00:53] Thanks. [22:00:59] Sorry for the duplication. [22:01:14] it's actually triplication for me [22:01:21] (mediawiki-core as well) [22:01:55] Also, /cc ryasmeen|Away FYI. [22:02:09] I'll let her know in 10 minutes during our 1:1 :) [22:02:14] * James_F grins. [22:03:56] chrismcmahon: looks like the backported fix won't pass the rspec job (which probably needs to be modified to check for rspec-core before attempting to run) [22:04:21] i need to go eat something, but i can take a look when i get back [22:04:34] greg-g: Speaking of 1:1, I should probably start having that with you and not robla :) [22:05:06] wingswednesday: yeah, thought of that last night as I was falling asleep, forgot to do anything about it yet :) [22:11:10] wingswednesday: when is your's with rob? [22:13:35] Thursdays at 1:30 these days [22:22:38] 3Beta-Cluster: /var/log full on deployment-elasticsearch* hosts - https://phabricator.wikimedia.org/T88280#1016111 (10greg) Is it worth reimaging these hosts with the new bigger var? [22:41:08] 3Beta-Cluster, VisualEditor: Searching for images in VisualEditor with Firefox is painfully slow in Beta Cluster - https://phabricator.wikimedia.org/T87676#1016176 (10Cmcmahon) I am pretty sure that on or around 16 January VE stopped handling this situation gracefully. [23:04:35] 3Code-Review, Engineering-Community: Organize a Gerrit Cleanup Day - https://phabricator.wikimedia.org/T88531#1016290 (10brion) +1 [23:07:30] 3Code-Review, Engineering-Community: Organize a Gerrit Cleanup Day - https://phabricator.wikimedia.org/T88531#1016301 (10Reedy) Some basic rules should be devised here. Such as, if a patch is -1 for X time, with no response, or work from the author (or any interested parties), it should be abandoned, with a mes... [23:33:31] 3Legalpad, WMF-Legal, Phabricator: remove legalpad.wm.org - https://phabricator.wikimedia.org/T87688#1016366 (10Dzahn) @chase can i merge? [23:34:22] (03PS1) 10MaxSem: Bump PHPUnit to 4.4.4 [integration/phpunit] - 10https://gerrit.wikimedia.org/r/188694 [23:36:08] (03PS2) 10MaxSem: Bump PHPUnit to 4.4.4 [integration/phpunit] - 10https://gerrit.wikimedia.org/r/188694 [23:37:58] (03PS1) 10Dduvall: Restrict mediawiki-selenium's rspec job to master branch [integration/config] - 10https://gerrit.wikimedia.org/r/188698 [23:39:10] (03CR) 10Dduvall: "I'm not completely sure if I did this right." [integration/config] - 10https://gerrit.wikimedia.org/r/188698 (owner: 10Dduvall) [23:39:39] Krinkle: ^ if you have a moment [23:39:53] (03CR) 10jenkins-bot: [V: 04-1] Bump PHPUnit to 4.4.4 [integration/phpunit] - 10https://gerrit.wikimedia.org/r/188694 (owner: 10MaxSem) [23:42:35] 3Legalpad, WMF-Legal, Phabricator: remove legalpad.wm.org - https://phabricator.wikimedia.org/T87688#1016394 (10chasemp) >>! In T87688#1016366, @Dzahn wrote: > @chasemp can i merge? I'm wondering if we make this box the phab failover, but cleaning out legalpad configuration is of no concern either way I suppose... [23:50:43] 3Code-Review, Engineering-Community: Organize a Gerrit Cleanup Day - https://phabricator.wikimedia.org/T88531#1016423 (10jayvdb) >>! In T88531#1016301, @Reedy wrote: > Some basic rules should be devised here. > > Such as, if a patch is -1 for X time, with no response, or work from the author (or any interested... [23:50:47] marxarelli: So you want the job to not run on branches other than master, righr? [23:50:53] (03CR) 10Krinkle: [C: 031] Restrict mediawiki-selenium's rspec job to master branch [integration/config] - 10https://gerrit.wikimedia.org/r/188698 (owner: 10Dduvall) [23:51:40] Krinkle: right [23:54:18] 3Code-Review, Engineering-Community: Organize a Gerrit Cleanup Day - https://phabricator.wikimedia.org/T88531#1016436 (10Dzahn) What jayvdb said, often volunteers uploading something, it doesn't get attention, then quite some time later an employee says he would like a little bit to be changed and -1's it, and t... [23:55:26] marxarelli: Do you have two irc nicks (one like dduvall) or always this one? [23:55:43] Krinkle: nope, always this one [23:56:10] marxarelli: Want to deploy it [23:56:11] ? [23:56:19] Krinkle: that would be great, yeah [23:56:24] marxarelli: First time? [23:56:35] i might have done it once before [23:56:41] but i forget how :) [23:57:05] marxarelli: https://www.mediawiki.org/wiki/Continuous_integration/Zuul#Deploy_configuration [23:57:10] marxarelli: Merge first with CR+2 [23:57:12] Krinkle: i can probably just follow some docs if you want to point me in the right direction [23:57:13] nice