[00:05:38] (03PS2) 10Dduvall: Render tags and links to SauceLabs sessions [integration/raita] - 10https://gerrit.wikimedia.org/r/215221 [00:05:40] (03PS2) 10Dduvall: Highlight step arguments [integration/raita] - 10https://gerrit.wikimedia.org/r/215237 [00:09:47] PROBLEM - Puppet staleness on integration-slave-jessie-1001 is CRITICAL 100.00% of data above the critical threshold [43200.0] [00:24:13] 6Release-Engineering, 10Gather, 6Mobile-Web, 10MobileFrontend, 3Mobile-Web-Sprint-48-Voyage-of-the-Damned: [EPIC] Encourage developers to increase code coverage - https://phabricator.wikimedia.org/T100294#1327743 (10Tgr) >>! In T100294#1322186, @hashar wrote: > At first we would need a place to push temp... [00:32:13] 6Release-Engineering, 10Gather, 6Mobile-Web, 10MobileFrontend, 3Mobile-Web-Sprint-48-Voyage-of-the-Damned: [EPIC] Encourage developers to increase code coverage - https://phabricator.wikimedia.org/T100294#1327755 (10Legoktm) [00:32:14] 10Continuous-Integration-Infrastructure, 5Patch-For-Review: Generate code coverage reports for extensions - https://phabricator.wikimedia.org/T71685#1327756 (10Legoktm) [00:34:56] Yippee, build fixed! [00:34:56] Project browsertests-Gather-en.m.wikipedia.beta.wmflabs.org-linux-chrome-sauce build #138: FIXED in 8 min 42 sec: https://integration.wikimedia.org/ci/job/browsertests-Gather-en.m.wikipedia.beta.wmflabs.org-linux-chrome-sauce/138/ [00:37:22] PROBLEM - Puppet failure on deployment-stream is CRITICAL 60.00% of data above the critical threshold [0.0] [01:04:25] (03CR) 10Krinkle: "(Resolved meanwhile)" [integration/jenkins] - 10https://gerrit.wikimedia.org/r/167948 (https://bugzilla.wikimedia.org/71128) (owner: 10Hashar) [01:11:10] (03Abandoned) 10Krinkle: Add Paladox to the whitelist [integration/config] - 10https://gerrit.wikimedia.org/r/215064 (owner: 10Aude) [01:42:25] RECOVERY - Puppet failure on deployment-stream is OK Less than 1.00% above the threshold [0.0] [02:01:20] 10Beta-Cluster, 10MediaWiki-ResourceLoader, 3Mobile-Web-Sprint-48-Voyage-of-the-Damned: ResourceLoader urls with certain version serving different content on beta cluster - https://phabricator.wikimedia.org/T100542#1327967 (10Krinkle) > Note grepping for toast.showOnPageReload you'll find it is present in ht... [02:07:14] PROBLEM - Puppet staleness on deployment-elastic07 is CRITICAL 100.00% of data above the critical threshold [43200.0] [06:49:41] RECOVERY - Free space - all mounts on deployment-videoscaler01 is OK All targets OK [06:50:47] PROBLEM - Free space - all mounts on deployment-bastion is CRITICAL deployment-prep.deployment-bastion.diskspace._var.byte_percentfree (<10.00%) [07:18:38] Project browsertests-Flow-en.wikipedia.beta.wmflabs.org-linux-firefox-monobook-sauce build #461: FAILURE in 53 min: https://integration.wikimedia.org/ci/job/browsertests-Flow-en.wikipedia.beta.wmflabs.org-linux-firefox-monobook-sauce/461/ [07:49:24] (03PS3) 10Polybuildr: Add sniff to check for spacey use of parentheses [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/193766 (owner: 10Legoktm) [07:49:41] (03CR) 10jenkins-bot: [V: 04-1] Add sniff to check for spacey use of parentheses [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/193766 (owner: 10Legoktm) [07:51:59] (03CR) 10Polybuildr: "Updated the commit message to reflect that all parentheses will be checked. This triggered a jenkins job and there are some tests that are" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/193766 (owner: 10Legoktm) [08:15:38] 10Deployment-Systems, 6operations: Unhashable type: dict error when running salt --batch-size - https://phabricator.wikimedia.org/T99776#1328353 (10ArielGlenn) This fix is deployed on virt1000 and on the production salt master as of last week. Please watch over the next few days; if I have no more reports of... [08:24:22] 10Browser-Tests, 10MediaWiki-extensions-MultimediaViewer, 6Multimedia: Fix failed MultimediaViewer browsertests Jenkins jobs - https://phabricator.wikimedia.org/T94157#1328361 (10Gilles) [08:48:00] addshore: Hello. :) [08:48:07] How much time do you have today? :P [08:48:28] 25 mins ;p [08:48:45] You have the same conference call? :P [08:48:50] yup :P [08:48:59] Okay. Well, awesome news. The tests are passing. :D [08:49:07] https://gerrit.wikimedia.org/r/#/c/214792/ [08:50:09] awesome [08:50:31] is that will the CS checks against itself? [08:50:49] sorry? [08:51:00] CS is checking against itself, yes. [08:51:16] =] [08:51:26] Review, please. :P [08:51:39] Project browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-os_x_10.9-safari-sauce build #618: SUCCESS in 41 min: https://integration.wikimedia.org/ci/job/browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-os_x_10.9-safari-sauce/618/ [08:57:41] reviewing [08:58:17] (03CR) 10Addshore: [C: 04-1] "1 comment, otherwise looks good to go" (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/214792 (https://phabricator.wikimedia.org/T92754) (owner: 10Polybuildr) [08:59:31] (03CR) 10Polybuildr: "There are actually a lot of lines in several files where the spacey convention is not being followed. I was planning to fix this in legokt" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/214792 (https://phabricator.wikimedia.org/T92754) (owner: 10Polybuildr) [09:00:13] (03CR) 10Addshore: [C: 032] Make mediawiki/tools/codesniffer pass phpcs [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/214792 (https://phabricator.wikimedia.org/T92754) (owner: 10Polybuildr) [09:00:29] (03Merged) 10jenkins-bot: Make mediawiki/tools/codesniffer pass phpcs [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/214792 (https://phabricator.wikimedia.org/T92754) (owner: 10Polybuildr) [09:01:21] (03CR) 10Addshore: [C: 04-1] "needs manual rebase" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/196880 (owner: 10Polybuildr) [09:01:24] (03PS4) 10Addshore: Add sniff to check for spacey use of parentheses [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/193766 (owner: 10Legoktm) [09:01:39] (03CR) 10jenkins-bot: [V: 04-1] Add sniff to check for spacey use of parentheses [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/193766 (owner: 10Legoktm) [09:06:59] addshore: Are you fixing legoktm's patch or should I continue working on it? [09:07:11] you can work on it :) I was just rebasing :) [09:07:22] alright :) [09:07:27] tata for now! [09:31:28] 10Continuous-Integration-Infrastructure, 5Patch-For-Review: Generate code coverage reports for extensions - https://phabricator.wikimedia.org/T71685#1328430 (10phuedx) @Legoktm: Can we get MobileFrontend and Gather added to the list of extensions that you're generating reports for? [09:46:51] (03PS5) 10Polybuildr: Add sniff to check for spacey use of parentheses [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/193766 (owner: 10Legoktm) [09:49:00] addshore: rebased and passing now :) [09:49:31] in a call, give me 5 mins ;p [09:54:07] sure :P [10:07:06] (03CR) 10Addshore: [C: 032] Add sniff to check for spacey use of parentheses [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/193766 (owner: 10Legoktm) [10:07:20] (03Merged) 10jenkins-bot: Add sniff to check for spacey use of parentheses [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/193766 (owner: 10Legoktm) [10:07:24] polybuildr: ^^ [10:07:27] :D [10:07:34] Making a lot of progress today. :P [10:09:27] ping me if you need anything else ;p [10:09:40] yes, two more coming up. [10:16:46] addshore: Okay, so while splitting a patch into two, I seem to have removed one of legoktm's original changes to the generic_pass file [10:16:59] I'm currently working on a patch that makes tests fail for respective, specific reasons [10:17:07] XYZ_fail should only fail for XYZ [10:17:10] and not for some other test [10:18:23] and I ended up doing that while working on his patch [10:18:25] so I stashed them [10:18:30] and accidentally stashed this one too [10:18:44] addshore: too I just bundle it with the others in the next patch? [10:18:50] s/too/do [10:24:52] depends what the next patch is :P [10:25:05] normally there is very little point in 'bundelling' unrelated changes to gether [10:25:18] the smaller the change, the easier it is to understand, the faster it is the review etc [10:26:01] addshore: it is one `(bool)` added to the generic_pass file [10:26:13] it was supposed to go along with spacey parens patch [10:26:14] yeh, do it in a seprate patch ;p [10:26:34] okay, what do I write in the commit message? :P [10:27:18] okay, I'll just mention the change to generic_pass [10:27:52] yeh, put whatever you think explains it :P [10:34:22] (03PS1) 10Polybuildr: Modify generic pass test with a case of not-spacey parentheses [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/215310 [10:36:15] (03PS1) 10Polybuildr: Make failing tests fail only for specific respective reasons [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/215311 [10:37:41] addshore: ^ [10:37:56] the rebase for changing global variables detection procedure I'll do after lunch [10:38:19] (03CR) 10Addshore: [C: 032] Modify generic pass test with a case of not-spacey parentheses [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/215310 (owner: 10Polybuildr) [10:38:35] (03Merged) 10jenkins-bot: Modify generic pass test with a case of not-spacey parentheses [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/215310 (owner: 10Polybuildr) [10:39:36] (03CR) 10Addshore: [C: 032] Make failing tests fail only for specific respective reasons [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/215311 (owner: 10Polybuildr) [10:59:42] (03PS2) 10Addshore: Make failing tests fail only for specific respective reasons [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/215311 (owner: 10Polybuildr) [11:18:20] 10Deployment-Systems: Come up with an abstract deployment model that roughly addresses the needs of existing projects - https://phabricator.wikimedia.org/T97068#1328531 (10mmodell) Here's my attempt at diagramming the process as a sequence diagram. {F172979} see P709 for the source code [11:20:46] PROBLEM - Free space - all mounts on deployment-bastion is CRITICAL deployment-prep.deployment-bastion.diskspace._var.byte_percentfree (<20.00%) [11:23:42] 10Beta-Cluster, 7Blocked-on-RelEng, 10ContentTranslation-Deployments, 10MediaWiki-extensions-ContentTranslation, and 3 others: Setup new wikis in Beta Cluster for Content Translation - https://phabricator.wikimedia.org/T90683#1328533 (10KartikMistry) @mmodell, can you explain parameters of, ``` mwscript e... [11:24:18] 10Deployment-Systems: Future Deployment Tooling Modules - https://phabricator.wikimedia.org/T101024#1328534 (10mmodell) Maybe helpful in defining these modules: {F172979} [11:28:13] (03PS7) 10Polybuildr: Change procedure for finding global variables in ValidGlobalNameSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/196880 [11:29:15] (03CR) 10Polybuildr: "This needs to be tested once with a reasonable amount of code before being merged." [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/196880 (owner: 10Polybuildr) [11:56:48] (03CR) 10Polybuildr: "Ran against core with this output: https://phabricator.wikimedia.org/P710 (only relevant portions copied over)." [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/196880 (owner: 10Polybuildr) [11:56:54] addshore: ^ [11:57:54] just about to go into another call ;p [11:59:49] okay :) [12:02:51] (03PS1) 10Polybuildr: Change certain errors to warnings [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/215316 [12:08:22] (03CR) 1020after4: [C: 032] Lint JSON files [tools/scap] - 10https://gerrit.wikimedia.org/r/214288 (https://phabricator.wikimedia.org/T100600) (owner: 10Legoktm) [12:08:41] (03Merged) 10jenkins-bot: Lint JSON files [tools/scap] - 10https://gerrit.wikimedia.org/r/214288 (https://phabricator.wikimedia.org/T100600) (owner: 10Legoktm) [12:20:43] PROBLEM - Free space - all mounts on deployment-videoscaler01 is CRITICAL deployment-prep.deployment-videoscaler01.diskspace._var.byte_percentfree (<40.00%) [12:25:01] (03CR) 10Polybuildr: "recheck" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/201010 (https://phabricator.wikimedia.org/T94141) (owner: 10Hharchani) [12:25:20] (03CR) 10jenkins-bot: [V: 04-1] Update ExtraCharacters Sniff to allow valid shebang [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/201010 (https://phabricator.wikimedia.org/T94141) (owner: 10Hharchani) [12:26:14] 10Beta-Cluster, 7Epic: Meeting: Automatic deployment of backend services on beta cluster - https://phabricator.wikimedia.org/T100099#1305393 (10mobrovac) [12:32:06] (03CR) 10Polybuildr: "The failing test should be named "valid_shebang_before_phpopen_tag_pass". Also, there are some coding style errors that need to be fixed. " [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/201010 (https://phabricator.wikimedia.org/T94141) (owner: 10Hharchani) [12:32:13] (03CR) 10Polybuildr: [C: 04-1] Update ExtraCharacters Sniff to allow valid shebang [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/201010 (https://phabricator.wikimedia.org/T94141) (owner: 10Hharchani) [12:32:53] addshore: Two for you to review when free: https://gerrit.wikimedia.org/r/196880 and https://gerrit.wikimedia.org/r/215316 [12:51:18] addshore: oh, and https://gerrit.wikimedia.org/r/#/c/215311/ [13:02:31] PROBLEM - Puppet failure on deployment-memc03 is CRITICAL 30.00% of data above the critical threshold [0.0] [13:04:27] PROBLEM - Puppet failure on deployment-memc02 is CRITICAL 50.00% of data above the critical threshold [0.0] [13:05:37] PROBLEM - Puppet failure on deployment-logstash1 is CRITICAL 20.00% of data above the critical threshold [0.0] [13:07:05] hashar: I didn't understand yesterday how codesniffer would help with those errors. [13:07:59] which errors are you talking about? :-} [13:08:57] hashar: the log errors [13:09:06] You told me you'd spent the day triaging log errors [13:09:10] and then asked about codesniffer's progress [13:09:20] I couldn't figure out the relation then. [13:09:28] PROBLEM - Puppet failure on deployment-cxserver03 is CRITICAL 44.44% of data above the critical threshold [0.0] [13:09:58] PROBLEM - Puppet failure on deployment-db2 is CRITICAL 60.00% of data above the critical threshold [0.0] [13:10:06] PROBLEM - Puppet failure on deployment-fluorine is CRITICAL 66.67% of data above the critical threshold [0.0] [13:10:35] PROBLEM - Puppet failure on deployment-fluoride is CRITICAL 20.00% of data above the critical threshold [0.0] [13:10:57] PROBLEM - Puppet failure on deployment-sentry2 is CRITICAL 50.00% of data above the critical threshold [0.0] [13:11:01] PROBLEM - Puppet failure on deployment-mediawiki03 is CRITICAL 60.00% of data above the critical threshold [0.0] [13:11:01] PROBLEM - Puppet failure on deployment-memc04 is CRITICAL 40.00% of data above the critical threshold [0.0] [13:11:15] puppet failures are from me [13:11:31] polybuildr: ah the log error were the wikimedia backend server logs [13:11:34] so yeah, unrelated [13:11:37] PROBLEM - Puppet failure on deployment-test is CRITICAL 30.00% of data above the critical threshold [0.0] [13:11:41] PROBLEM - Puppet failure on deployment-sca01 is CRITICAL 30.00% of data above the critical threshold [0.0] [13:12:02] hashar: Okay. I've been wondering about the relation since then. :P [13:12:09] PROBLEM - Puppet failure on deployment-upload is CRITICAL 55.56% of data above the critical threshold [0.0] [13:12:47] hashar: Also, what do you think about also making codesniffer a non-voting task on tests run for core? [13:13:19] PROBLEM - Puppet failure on deployment-elastic08 is CRITICAL 30.00% of data above the critical threshold [0.0] [13:14:08] PROBLEM - Puppet failure on deployment-apertium01 is CRITICAL 33.33% of data above the critical threshold [0.0] [13:14:17] PROBLEM - Puppet failure on deployment-db1 is CRITICAL 20.00% of data above the critical threshold [0.0] [13:14:41] PROBLEM - Puppet failure on deployment-zookeeper01 is CRITICAL 20.00% of data above the critical threshold [0.0] [13:15:12] PROBLEM - Puppet failure on deployment-elastic06 is CRITICAL 66.67% of data above the critical threshold [0.0] [13:15:18] PROBLEM - Puppet failure on deployment-sca02 is CRITICAL 44.44% of data above the critical threshold [0.0] [13:15:20] PROBLEM - Puppet failure on deployment-elastic05 is CRITICAL 30.00% of data above the critical threshold [0.0] [13:15:36] PROBLEM - Puppet failure on deployment-redis01 is CRITICAL 60.00% of data above the critical threshold [0.0] [13:16:06] PROBLEM - Puppet failure on deployment-mediawiki02 is CRITICAL 22.22% of data above the critical threshold [0.0] [13:16:32] !log restarted deployment-salt [13:16:34] Logged the message, Master [13:17:02] PROBLEM - Puppet failure on deployment-mathoid is CRITICAL 60.00% of data above the critical threshold [0.0] [13:17:07] PROBLEM - Puppet failure on deployment-zotero01 is CRITICAL 55.56% of data above the critical threshold [0.0] [13:17:14] polybuildr|away: we have the job mediawiki-core-phpcs-HEAD already [13:17:21] though it only run on file being changed by the patch [13:17:37] PROBLEM - Puppet failure on deployment-jobrunner01 is CRITICAL 50.00% of data above the critical threshold [0.0] [13:18:05] PROBLEM - Puppet failure on deployment-mediawiki01 is CRITICAL 44.44% of data above the critical threshold [0.0] [13:18:23] PROBLEM - Puppet failure on deployment-stream is CRITICAL 40.00% of data above the critical threshold [0.0] [13:19:23] PROBLEM - Puppet failure on deployment-videoscaler01 is CRITICAL 66.67% of data above the critical threshold [0.0] [13:21:27] PROBLEM - Puppet failure on deployment-bastion is CRITICAL 55.56% of data above the critical threshold [0.0] [13:21:43] PROBLEM - Puppet failure on deployment-pdf02 is CRITICAL 90.00% of data above the critical threshold [0.0] [13:23:00] hashar: That job runs on what version of codesniffer? dev-master? or the older 0.10? [13:23:41] addshore: free now for those reviews? [13:25:09] It runs a snapshot we have in integration/phpcs.git :( [13:25:10] with code sniffer from srv/deployment/integration/mediawiki-tools-codesniffer/MediaWiki [13:25:11] we should migrate that to use npm I guess [13:25:11] when does the srv/deployment version get updated? [13:25:11] RECOVERY - Puppet failure on deployment-fluorine is OK Less than 1.00% above the threshold [0.0] [13:25:15] hashar: or is that the same as the integration/phpcs snapshot? [13:25:40] RECOVERY - Puppet failure on deployment-logstash1 is OK Less than 1.00% above the threshold [0.0] [13:25:54] it is updated via puppet by doing a git pull every 20 minutes iirc [13:26:37] hashar: I see, that's fine then. [13:27:31] (03PS2) 10Hashar: Jobs for WikidataPageBanner [integration/config] - 10https://gerrit.wikimedia.org/r/214583 (https://phabricator.wikimedia.org/T100495) [13:27:34] RECOVERY - Puppet failure on deployment-memc03 is OK Less than 1.00% above the threshold [0.0] [13:28:44] (03CR) 10Hashar: [C: 032] Jobs for WikidataPageBanner [integration/config] - 10https://gerrit.wikimedia.org/r/214583 (https://phabricator.wikimedia.org/T100495) (owner: 10Hashar) [13:29:03] hashar: Also, now that more rules have been added to codesniffer, several files in core need updates. Should that be done in one big commit, in your opinion? [13:29:26] RECOVERY - Puppet failure on deployment-memc02 is OK Less than 1.00% above the threshold [0.0] [13:29:30] RECOVERY - Puppet failure on deployment-cxserver03 is OK Less than 1.00% above the threshold [0.0] [13:30:00] RECOVERY - Puppet failure on deployment-db2 is OK Less than 1.00% above the threshold [0.0] [13:30:12] RECOVERY - Puppet failure on deployment-elastic06 is OK Less than 1.00% above the threshold [0.0] [13:31:00] RECOVERY - Puppet failure on deployment-mediawiki03 is OK Less than 1.00% above the threshold [0.0] [13:33:22] RECOVERY - Puppet failure on deployment-elastic08 is OK Less than 1.00% above the threshold [0.0] [13:34:12] (03Merged) 10jenkins-bot: Jobs for WikidataPageBanner [integration/config] - 10https://gerrit.wikimedia.org/r/214583 (https://phabricator.wikimedia.org/T100495) (owner: 10Hashar) [13:34:39] RECOVERY - Puppet failure on deployment-zookeeper01 is OK Less than 1.00% above the threshold [0.0] [13:35:38] RECOVERY - Puppet failure on deployment-redis01 is OK Less than 1.00% above the threshold [0.0] [13:35:38] RECOVERY - Puppet failure on deployment-fluoride is OK Less than 1.00% above the threshold [0.0] [13:36:38] RECOVERY - Puppet failure on deployment-sca01 is OK Less than 1.00% above the threshold [0.0] [13:36:38] RECOVERY - Puppet failure on deployment-test is OK Less than 1.00% above the threshold [0.0] [13:37:04] RECOVERY - Puppet failure on deployment-mathoid is OK Less than 1.00% above the threshold [0.0] [13:37:06] RECOVERY - Puppet failure on deployment-upload is OK Less than 1.00% above the threshold [0.0] [13:37:38] RECOVERY - Puppet failure on deployment-jobrunner01 is OK Less than 1.00% above the threshold [0.0] [13:38:06] RECOVERY - Puppet failure on deployment-mediawiki01 is OK Less than 1.00% above the threshold [0.0] [13:39:10] RECOVERY - Puppet failure on deployment-apertium01 is OK Less than 1.00% above the threshold [0.0] [13:39:24] RECOVERY - Puppet failure on deployment-videoscaler01 is OK Less than 1.00% above the threshold [0.0] [13:40:18] RECOVERY - Puppet failure on deployment-sca02 is OK Less than 1.00% above the threshold [0.0] [13:40:56] RECOVERY - Puppet failure on deployment-sentry2 is OK Less than 1.00% above the threshold [0.0] [13:41:00] RECOVERY - Puppet failure on deployment-memc04 is OK Less than 1.00% above the threshold [0.0] [13:41:09] RECOVERY - Puppet failure on deployment-mediawiki02 is OK Less than 1.00% above the threshold [0.0] [13:41:31] RECOVERY - Puppet failure on deployment-bastion is OK Less than 1.00% above the threshold [0.0] [13:41:39] RECOVERY - Puppet failure on deployment-pdf02 is OK Less than 1.00% above the threshold [0.0] [13:41:39] 10Beta-Cluster, 7Blocked-on-RelEng, 10ContentTranslation-Deployments, 10MediaWiki-extensions-ContentTranslation, and 3 others: Setup new wikis in Beta Cluster for Content Translation - https://phabricator.wikimedia.org/T90683#1328912 (10demon) `--help` explains them: ``` Arguments: : Language... [13:42:05] RECOVERY - Puppet failure on deployment-zotero01 is OK Less than 1.00% above the threshold [0.0] [13:43:25] RECOVERY - Puppet failure on deployment-stream is OK Less than 1.00% above the threshold [0.0] [13:44:16] RECOVERY - Puppet failure on deployment-db1 is OK Less than 1.00% above the threshold [0.0] [13:45:20] RECOVERY - Puppet failure on deployment-elastic05 is OK Less than 1.00% above the threshold [0.0] [14:15:29] addshore: there? [14:15:34] yes [14:15:38] just got out of a meeting [14:16:29] addshore: you are an extremely busy person :P [14:16:39] mhhm, just started work yesterday [14:16:43] = lots of meetings [14:17:04] You were on vacation? [14:17:58] nope :P [14:18:16] What did you mean by started work yesterday? [14:18:30] I mean, I got a job and started yesterday ;p [14:18:40] At WMF? [14:18:55] WMDE [14:19:38] I see. Nice. :D [14:19:47] How come there's no welcoming mail on wikitech-l? :P [14:20:58] addshore: These were the ones that need review: https://gerrit.wikimedia.org/r/196880, https://gerrit.wikimedia.org/r/215316 and https://gerrit.wikimedia.org/r/#/c/215311/ [14:21:53] one of them you +2ed, but it needed a rebase before the merge. [14:23:28] polybuildr: for https://gerrit.wikimedia.org/r/#/c/196880/ were the errors in the pastebin showing up before you changed the way it looked for globals? [14:25:02] addshore: No, not all of them. Because the earlier version was searching for the `global` keyword, and some of them were never used outside of global scope. [14:25:20] That was essentially the reason I thought the change was necessary. [14:25:22] (03CR) 10Addshore: [C: 032] Change certain errors to warnings [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/215316 (owner: 10Polybuildr) [14:26:07] (03PS2) 10Addshore: Change certain errors to warnings [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/215316 (owner: 10Polybuildr) [14:26:41] 10Beta-Cluster, 10Continuous-Integration-Infrastructure, 10pywikibot-core: Run pywikibot test suite regularly on beta cluster as part of MediaWiki/Wikimedia CI - https://phabricator.wikimedia.org/T100903#1323218 (10hashar) @jayvb have you implemented a family for the beta cluster? We will need the exact com... [14:26:49] 10Beta-Cluster, 10Continuous-Integration-Infrastructure: Reenable ssh MAC/KEX hardening on beta cluster and integration labs project - https://phabricator.wikimedia.org/T100518#1329526 (10hashar) p:5Triage>3Normal Blocked on T100517 [14:26:53] polybuildr: Ill have a look at that one a bit later or tommorw :) [14:26:55] 10Continuous-Integration-Infrastructure, 7Jenkins, 7Upstream: Jenkins jar should ship with a more recent jsch java lib version to support hardened algorithm - https://phabricator.wikimedia.org/T100517#1314566 (10hashar) [14:26:56] other 2 are merged [14:28:02] addshore: https://gerrit.wikimedia.org/r/#/c/215316/ made sense, I hope? [14:28:15] twentyafterfour: thanks :D [14:28:15] polybuildr: you aare awesome :D [14:28:19] polybuildr: yeh [14:28:22] and yeah, sure. that one was a big "subject to review". :P [14:28:26] legoktm: why? :P [14:28:29] legoktm: want to check https://gerrit.wikimedia.org/r/#/c/196880/ [14:28:51] dont think I'll have the time today :O I'm writing Java :/ [14:29:08] * polybuildr feels a little sorry for addshore [14:29:12] xD [14:29:59] 10Continuous-Integration-Infrastructure: Upgrade PHPUnit to 4.0+ - https://phabricator.wikimedia.org/T99982#1329560 (10hashar) [14:30:01] 10Continuous-Integration-Infrastructure, 5MW-1.26-release, 5Patch-For-Review, 5WMF-deploy-2015-06-09_(1.26wmf9): Fetch dependencies using composer instead of cloning mediawiki/vendor for non-wmf branches - https://phabricator.wikimedia.org/T90303#1329561 (10hashar) [14:31:06] 10Continuous-Integration-Infrastructure: Upgrade PHPUnit to 4.0+ - https://phabricator.wikimedia.org/T99982#1303101 (10hashar) The Jenkins job currently uses a stalled version of PHPUnit 3.7.x provided via a git repository. We will never update it. Instead the jobs will be using composer to bring in PHPUnit: T90303 [14:33:21] legoktm: Reviewing that one now? [14:34:17] Yippee, build fixed! [14:34:18] Project browsertests-Echo-en.wikipedia.beta.wmflabs.org-linux-firefox-sauce build #521: FIXED in 8 min 17 sec: https://integration.wikimedia.org/ci/job/browsertests-Echo-en.wikipedia.beta.wmflabs.org-linux-firefox-sauce/521/ [14:36:19] legoktm: https://gerrit.wikimedia.org/r/#/c/196880/ checks for variables in global scope instead of just looking for `global` keywords. It's catching some new cases, up to you to decide if we want to catch them. [14:37:43] Yippee, build fixed! [14:37:43] Project browsertests-MobileFrontend-SmokeTests-linux-chrome-sauce build #138: FIXED in 9 min 42 sec: https://integration.wikimedia.org/ci/job/browsertests-MobileFrontend-SmokeTests-linux-chrome-sauce/138/ [14:40:17] 10Continuous-Integration-Infrastructure: Fix "PHP Warning: Module 'apc' already loaded" on zend slaves - https://phabricator.wikimedia.org/T99413#1329597 (10hashar) ``` integration-slave-precise-1013:/etc/php5$ grep -R "extension=.*apc" . ./conf.d/apc.ini:extension="apc.so" ./conf.d/disable-html_errors.ini:exte... [14:40:58] 10Continuous-Integration-Infrastructure: Fix "PHP Warning: Module 'apc' already loaded" on zend slaves - https://phabricator.wikimedia.org/T99413#1329602 (10JanZerebecki) Need to remove the line from disable-html_errors.ini: integration-slave-precise-1013:~$ grep -r apc /etc/php5/ /etc/php5/conf.d/apc.ini:; pup... [14:42:05] 6Release-Engineering, 6operations: Try out hack (3None Don't want to lick this cookie too hard, haven't had time to play with it. We'll have to change some settings in HHVM (forgot which one) and scap & co will... [14:42:19] 10Continuous-Integration-Infrastructure, 7Jenkins, 7Upstream: Jenkins does not shutdown due to a deadlock in the IRC plugin - https://phabricator.wikimedia.org/T98976#1329611 (10hashar) Upstream issue in Jenkins plugin. We need to report a bug. [14:42:36] 10Continuous-Integration-Infrastructure, 7Jenkins, 7Upstream: Jenkins does not shutdown due to a deadlock in the IRC plugin - https://phabricator.wikimedia.org/T98976#1329616 (10hashar) p:5Triage>3Normal [14:42:44] bd808: your thoughts on 10Continuous-Integration-Infrastructure: Fix "PHP Warning: Module 'apc' already loaded" on zend slaves - https://phabricator.wikimedia.org/T99413#1329623 (10hashar) cat /etc/php5/conf.d/disable-html_errors.ini ``` ; This file is managed by puppet ; puppet:///modules/contint/php-disable-html_errors.ini extensio... [14:44:56] polybuildr: eh, we really don't want to be catching those tbh... [14:45:08] legoktm: because they're generally in standalone scripts? [14:45:58] 6Release-Engineering, 10Wikipedia-Android-App, 10Wikipedia-iOS-App: Create end-to-end automated test for Wikipedia native app(s) - https://phabricator.wikimedia.org/T90177#1329628 (10hashar) [14:45:59] 10Beta-Cluster, 10Continuous-Integration-Infrastructure, 10pywikibot-core: Run pywikibot test suite regularly on beta cluster as part of MediaWiki/Wikimedia CI - https://phabricator.wikimedia.org/T100903#1329630 (10jayvdb) @hashar , this task is only waiting on the blocker task T69931 , which is a Beta-Clus... [14:46:23] 6Release-Engineering, 10Wikipedia-Android-App, 10Wikipedia-iOS-App: Create end-to-end automated test for Wikipedia native app(s) - https://phabricator.wikimedia.org/T90177#1053692 (10hashar) Removed #Continuous-Integration-Infrastructure for now since not much work is needed on the infra right now. The tas... [14:46:35] legoktm: also, after https://gerrit.wikimedia.org/r/#/c/201010/ is done, might be a good time for the next release. [14:47:02] polybuildr: well, ZhConversion isn't globals for one [14:47:05] it gets required in [14:47:12] 10Continuous-Integration-Infrastructure, 5Patch-For-Review: Unattended upgrade seems to only run daily instead of hourly - https://phabricator.wikimedia.org/T98885#1329636 (10hashar) a:3hashar Will look at it eventually. In short unattended upgrade is not meant to run hourly :-( [14:47:22] 10Continuous-Integration-Infrastructure, 6Editing-Department, 10VisualEditor, 7Regression: Submodule not being updated in Jenkins jobs - https://phabricator.wikimedia.org/T101105#1329638 (10Krinkle) 3NEW [14:47:25] 10Continuous-Integration-Infrastructure: Unattended upgrade seems to only run daily instead of hourly - https://phabricator.wikimedia.org/T98885#1329645 (10hashar) [14:47:33] and stuff like https://github.com/wikimedia/mediawiki-extensions-Flow/blob/master/includes/Notifications/Notifications.php would get flagged [14:47:38] even though it's not in global scope [14:48:18] legoktm: hmm, true. [14:48:26] alright, I'll abandon then? [14:49:26] 10Continuous-Integration-Infrastructure, 7Zuul: Bump python-gear package to 0.5.6 - https://phabricator.wikimedia.org/T98294#1264016 (10hashar) That is for the zuul server on gallium (Precise). Need to bump the package in Debian alioth git repo and push it to apt.wikimedia.org [14:51:27] legoktm: ^ ? [14:51:38] polybuildr: yeah, sorry :/ [14:51:47] legoktm: why in the world are you apologising? :P [14:52:16] 10Continuous-Integration-Infrastructure, 6Release-Engineering: Run qunit tests in IE8 (and possibly other Grade A browsers) - https://phabricator.wikimedia.org/T96432#1329657 (10hashar) p:5Triage>3Low [14:52:24] because you spent time working on it and I didn't realize what the patch was actually doing until now [14:52:28] (03Abandoned) 10Polybuildr: Change procedure for finding global variables in ValidGlobalNameSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/196880 (owner: 10Polybuildr) [14:52:39] legoktm: ah, okay. :) [14:52:50] anyway, that's a lot of stuff done in codesniffer :D [14:53:20] 10Continuous-Integration-Infrastructure: Run QUnit tests via SauceLabs - https://phabricator.wikimedia.org/T96919#1329662 (10hashar) p:5Triage>3Normal [14:55:19] legoktm: Look at (2) in https://phabricator.wikimedia.org/T92754#1325091, though, something should be decided about that. [14:55:37] Generic convention to shorten long URLs. [14:55:45] uhh [14:55:58] don't? :P [14:56:04] I don't trust url shorteners [14:56:15] well, github URLs were shortened using git.io [14:56:29] which, since it's provided by github, should be safe enough. [14:56:34] the issue is with line lengths. [14:56:37] hopefully [14:56:39] hmm [14:56:43] what other urls need breaking? [14:56:45] Even warnings get the test to fail. [14:57:10] One was a URL I put in, Manual:CC/PHP#alternative_syntax (much longer, of course :P) [14:57:30] I removed the URL fragment from there and put in which section I was referring to in a comment below that [14:57:40] 10Continuous-Integration-Infrastructure, 7Zuul: mwext-Wikidata-testextension-zend not queuing properly - https://phabricator.wikimedia.org/T96034#1329676 (10hashar) The mwext-*-testextension jobs are throttled by a plugin so there is only one instance of them per node. That is to prevent the slaves disk space... [14:57:48] but while github was handled using git.io and the CC/PHP was handled by removing the fragment [14:57:56] if we want this to run against core and vote.. [14:58:03] we're going to have to figure out a way to account for URLs. [14:58:16] 10Continuous-Integration-Infrastructure, 7Zuul: mwext-Wikidata-testextension-zend not queuing properly - https://phabricator.wikimedia.org/T96034#1329678 (10hashar) p:5Triage>3Normal [14:58:38] legoktm: or // @codingStandardsIgnoreStart :P [14:58:40] I think we'll just have to break lines [14:58:42] or that [14:58:49] break lines in a URL? [14:59:40] legoktm: anyway, got to leave now. [14:59:42] o/ [14:59:46] 10Continuous-Integration-Infrastructure, 7Zuul: mwext-Wikidata-testextension-zend not queuing properly - https://phabricator.wikimedia.org/T96034#1206804 (10hashar) jjb/mediawiki-extensions.yaml:182: - throttle-one-per-node That is the Jenkins extension. [15:00:26] o/ [15:00:29] thanks for all your work :) [15:02:17] legoktm: my pleasure. :) also, tell me if there's anything else that needs to be done before the next release. I'd love to see one come out. :D [15:04:07] 10Browser-Tests, 10Continuous-Integration-Infrastructure: Accommodate flaky tests flapping - https://phabricator.wikimedia.org/T94212#1329736 (10hashar) p:5Normal>3Low [15:04:49] 10Continuous-Integration-Infrastructure: reduce copies of mediawiki/core in workspaces - https://phabricator.wikimedia.org/T93703#1329738 (10Krinkle) [15:04:50] 10Continuous-Integration-Infrastructure, 7Zuul: mwext-Wikidata-testextension-zend not queuing properly - https://phabricator.wikimedia.org/T96034#1329737 (10Krinkle) [15:05:00] 10Continuous-Integration-Infrastructure, 7Zuul: mwext-*-testextension-zend limited to one per node - https://phabricator.wikimedia.org/T96034#1329739 (10Krinkle) [15:06:22] so [15:06:28] https://phabricator.wikimedia.org/T101105 Submodule not being updated in Jenkins jobs [15:06:40] Krinkle: looking at the submodule issue [15:06:43] 10Continuous-Integration-Infrastructure, 7Zuul: mwext-*-testextension-zend limited to one per node - https://phabricator.wikimedia.org/T96034#1206804 (10Krinkle) This is intentionally configured this way via `throttle-on-per-node` to avoid multiple workspace on one slave for the same extension (both of which w... [15:10:00] 10Continuous-Integration-Infrastructure: Upgrade Jenkins git related plugins - https://phabricator.wikimedia.org/T100655#1329763 (10hashar) Causes T101105 due to JJB [15:13:54] 10Continuous-Integration-Infrastructure, 6Editing-Department, 10VisualEditor, 7Regression: Submodule not being updated in Jenkins jobs - https://phabricator.wikimedia.org/T101105#1329775 (10hashar) a:3hashar The JJB version on integration/jenkins-job-builder is at the commit just before //[[ https://revi... [15:16:48] !log updated integration/jenkins-job-builder to e3199d9 [15:16:51] Logged the message, Master [15:22:35] 10Continuous-Integration-Infrastructure, 6Editing-Department, 10VisualEditor, 7Regression: Submodule not being updated in Jenkins jobs - https://phabricator.wikimedia.org/T101105#1329789 (10hashar) I have updated integration/jenkins-job-builder to e3199d9 [15:23:20] 10Continuous-Integration-Infrastructure: Consolidate jobs to test entry points - https://phabricator.wikimedia.org/T91996#1329791 (10Krinkle) [15:25:41] 10Browser-Tests, 10VisualEditor: Update VisualEditor repository to mediawiki_selenium Ruby gem 1.1 - https://phabricator.wikimedia.org/T99661#1329796 (10dduvall) p:5High>3Normal [15:25:46] 10Browser-Tests, 10VisualEditor: Update VisualEditor repository to mediawiki_selenium Ruby gem 1.1 - https://phabricator.wikimedia.org/T99661#1295902 (10dduvall) p:5Normal>3High [15:26:16] 10Browser-Tests, 10VisualEditor: Update VisualEditor repository to mediawiki_selenium Ruby gem 1.1 - https://phabricator.wikimedia.org/T99661#1295902 (10dduvall) @ryasmeen, let's schedule a pairing session to work on this. [15:27:16] 10Browser-Tests, 10VisualEditor: Delete or fix failed VisualEditor browsertests Jenkins job - https://phabricator.wikimedia.org/T94162#1329805 (10dduvall) @ryasmeen, let's schedule a pairing session to work on this. [15:27:46] 10Browser-Tests, 10VisualEditor: Delete or fix failed VisualEditor browsertests Jenkins job - https://phabricator.wikimedia.org/T94162#1329808 (10dduvall) p:5Normal>3Triage [15:28:41] hashar: Ah interesting. JJB supports the old input, but only for the old output. So regenerating xml with newer JJB won't fix it, we need to actually change our YAML. [15:28:48] yeah [15:28:51] 10Browser-Tests, 10VisualEditor: Delete or fix failed VisualEditor browsertests Jenkins job - https://phabricator.wikimedia.org/T94162#1329812 (10zeljkofilipin) p:5Triage>3Normal [15:28:52] I have been misslead [15:28:58] I have updated our JJB fork [15:29:02] working on updating our config files [15:29:10] Cool [15:30:33] (03PS1) 10Hashar: Update Git plugin configuration [integration/config] - 10https://gerrit.wikimedia.org/r/215335 (https://phabricator.wikimedia.org/T101105) [15:30:48] I still have a bunch of warnings in JJB :( [15:30:57] WARNING:jenkins_jobs.modules.scm:git:'disable-submodules' is deprecated and will be ignored in favour of 'submodule' [15:30:57] WARNING:jenkins_jobs.modules.scm:git:'recursive-submodules' is deprecated and will be ignored in favour of 'submodule' [15:32:14] 10Browser-Tests, 10Continuous-Integration-Infrastructure, 6Release-Engineering, 7Tracking: Fix or delete browsertests* Jenkins jobs that are failing for more than a week (tracking) - https://phabricator.wikimedia.org/T94150#1329826 (10dduvall) [15:33:08] 10Browser-Tests, 10Continuous-Integration-Infrastructure, 6Release-Engineering, 7Epic, 7Tracking: Fix or delete browsertests* Jenkins jobs that are failing for more than a week (tracking) - https://phabricator.wikimedia.org/T94150#1156290 (10dduvall) [15:34:30] 6Release-Engineering: Organize browsertests/Selenium training - https://phabricator.wikimedia.org/T100170#1329829 (10zeljkofilipin) This is done for #wikimedia-hackathon-2015. Ready for #wikimania-hackathon-2015. [15:35:22] 10Beta-Cluster, 10Continuous-Integration-Infrastructure, 10Staging, 6Labs: Change local puppetmaster names for RE labs projects - https://phabricator.wikimedia.org/T101110#1329841 (10Andrew) 3NEW a:3thcipriani [15:36:06] hashar: Hm.. before checkout clean? [15:36:08] I thought it was after [15:36:59] 10Browser-Tests, 10MediaWiki-extensions-GuidedTour: Add Cucumber browser tests for GuidedTour - https://phabricator.wikimedia.org/T92154#1329861 (10zeljkofilipin) @mattflaschen do you need help with this ticket? We can pair on creating the first test. Is this something you plan to work on, or can this be closed? [15:37:29] ah the warning is non sense [15:37:32] and fixed later with https://review.openstack.org/#/c/158543/ [15:37:33] \O/ [15:37:41] Krinkle: yeah i am not sure [15:37:45] Krinkle: from https://integration.wikimedia.org/ci/job/mwext-VisualEditor-npm/8631/console [15:37:59] Krinkle: seems clean is done after indeed [15:38:16] 10Beta-Cluster, 10Continuous-Integration-Infrastructure, 10Staging, 6Labs: Change local puppetmaster names for RE labs projects - https://phabricator.wikimedia.org/T101110#1329862 (10thcipriani) p:5Triage>3High [15:39:54] (03PS2) 10Hashar: Update Git plugin configuration [integration/config] - 10https://gerrit.wikimedia.org/r/215335 (https://phabricator.wikimedia.org/T101105) [15:41:52] hashar: Hnm.. I don't know. I'm confused now. If you clean before doing the checkout , there can be extra untracked files during the build because switching from one checkout to another, leaves files behind that are part of commit 1 but not part of commit 2. [15:42:07] It would run clean based on the previous commit, not the current one. [15:42:28] e.g. commitA.1 adds foo.txt, commitA.2 doesn't add foo.txt, foo.txt will be left behind. [15:42:56] But let's stick to what we did before for now. [15:42:57] :D [15:43:49] ther eis a checkout -f [15:43:55] potentially that discard local changes [15:43:56] not sure [15:44:10] 6Release-Engineering, 6operations: Try out hack ( 6Release-Engineering, 6operations: Try out hack ( bd808: good catch :) [15:47:18] heh. hhvm migration is a bit like SUL finalization. The big flashy part is done but there is a long tail of things to do still that is dragging on and not high priority [15:47:45] because priorities [15:47:59] because lacks focus... [15:48:26] why do a few things really well and completely when we can fail about at dozens of projects instead :) [15:48:35] *flail [15:48:37] 10Browser-Tests: Given I am logged in step not generic enough - https://phabricator.wikimedia.org/T91671#1329897 (10dduvall) There are a couple ways we can tackle this. One possible solution is just to remove the wait on the logout element. Arguably, `Given` implementation shouldn't be asserting anything and yo... [15:48:55] 10Browser-Tests, 6Mobile-Web, 10MobileFrontend: Upgrade MobileFrontend browser tests to use mediawiki_selenium 1.x - https://phabricator.wikimedia.org/T99658#1329899 (10phuedx) [15:49:00] 10Browser-Tests: Given I am logged in step not generic enough - https://phabricator.wikimedia.org/T91671#1329902 (10dduvall) p:5Normal>3Triage [15:49:45] 10Beta-Cluster, 10Continuous-Integration-Infrastructure, 10Staging, 6Labs: Change local puppetmaster names for RE labs projects - https://phabricator.wikimedia.org/T101110#1329841 (10mmodell) this task is binary. [15:51:52] 10Browser-Tests, 7Documentation: mediawiki_selenium should document SauceLabs usage - https://phabricator.wikimedia.org/T98331#1329914 (10zeljkofilipin) p:5Triage>3Normal [15:52:23] 10Browser-Tests, 10MediaWiki-extensions-ZeroBanner, 6Zero, 7Tracking: [Blocking] Chromium/Firefox do not provide ability to set custom headers via Selenium and PhantomJS does not clear session (LocalStorage/Cookies/Cache) properly - https://phabricator.wikimedia.org/T96451#1329916 (10zeljkofilipin) p:5Tri... [15:52:41] 10Browser-Tests: Given I am logged in step not generic enough - https://phabricator.wikimedia.org/T91671#1329917 (10zeljkofilipin) p:5Triage>3Normal [15:53:04] 10Browser-Tests: Net::ReadTimeout shouldn't mark a test as failed - https://phabricator.wikimedia.org/T98968#1329924 (10zeljkofilipin) p:5Triage>3Normal [15:53:19] 10Browser-Tests, 10CirrusSearch: Support alternative API endpoints - https://phabricator.wikimedia.org/T99663#1329925 (10zeljkofilipin) p:5Triage>3Normal [15:54:15] 10Browser-Tests, 10MediaWiki-extensions-DonationInterface: Write browser tests for DonationInterface - https://phabricator.wikimedia.org/T99955#1329938 (10zeljkofilipin) p:5Triage>3Normal [15:55:32] 10Browser-Tests: mediawiki_selenium 1.2 breaks mw/core browser test when reporting to raita - https://phabricator.wikimedia.org/T100904#1329953 (10zeljkofilipin) p:5Triage>3Unbreak! [15:57:57] Looks like getting the image scalers on hhvm is still a far off goal :( -- https://phabricator.wikimedia.org/T84842#1328917 [15:58:27] 10Browser-Tests, 6Release-Engineering, 6Mobile-Web: Introduce @skip tag in mediawiki selenium - https://phabricator.wikimedia.org/T101062#1329973 (10zeljkofilipin) [15:58:41] 10Browser-Tests, 6Release-Engineering, 6Mobile-Web: Introduce @skip tag in mediawiki selenium - https://phabricator.wikimedia.org/T101062#1329976 (10zeljkofilipin) p:5Triage>3Normal [16:06:02] ostriches: Following the official policy of "poke ^d on irc" -- I'd like to make sure that Niharika Kohli (Niharika29) and Frances Holcutt (Fhocutt) are in the wmf ldap group and have +2 rights in gerrit [16:07:18] {{done}} [16:07:28] thx! [16:07:30] yw [16:07:37] I love processes that work! [16:08:25] * bd808 turns new hire developers loose to +2 all the things [16:15:40] 10Browser-Tests, 10VisualEditor: Update VisualEditor repository to mediawiki_selenium Ruby gem 1.1 - https://phabricator.wikimedia.org/T99661#1330106 (10Ryasmeen) @dduvall: sure. [16:19:28] 10Beta-Cluster, 10Continuous-Integration-Infrastructure, 10Staging, 6Labs: Change local puppetmaster names for RE labs projects - https://phabricator.wikimedia.org/T101110#1330124 (10scfc) https://wikitech.wikimedia.org/wiki/Help:Self-hosted_puppetmaster#Puppetmaster_Setup explicitly says: > […] When you... [16:36:56] 10Deployment-Systems, 6Release-Engineering, 7Epic, 3releng-201415-Q4: EPIC: The future of MediaWiki deployment: Tooling - https://phabricator.wikimedia.org/T94620#1330226 (10mmodell) [16:37:00] * hashar points the new folks to error logs [16:43:15] 10Continuous-Integration-Infrastructure, 6Release-Engineering: automatically build and commit mediawiki/vendor (composer) - https://phabricator.wikimedia.org/T101123#1330244 (10JanZerebecki) 3NEW [16:43:56] 10Beta-Cluster, 6Labs: Make sure labs ENC knows about cert changes - https://phabricator.wikimedia.org/T101124#1330255 (10Andrew) 3NEW a:3Andrew [16:44:39] legoktm: the question I asked earlier, anything else to be done before a possible new release of codesniffer? [16:48:10] I need to wake up first [16:52:19] thcipriani: not understanding from the ticket, what's the state of https://phabricator.wikimedia.org/T97775? [16:52:21] you are waiting on ops? [16:53:30] chasemp: yeah, patch works in staging, could use some more eyes/review from ops [16:54:10] on this patch specifically: https://gerrit.wikimedia.org/r/#/c/209045/ [16:54:22] 10Beta-Cluster, 10Continuous-Integration-Infrastructure, 10Staging, 6Labs: Change local puppetmaster names for RE labs projects - https://phabricator.wikimedia.org/T101110#1330304 (10Andrew) Yes, it works. From puppet: # else assume short hostname and append domain. default => "${... [16:55:38] does this straight wikidev the repo then? [16:55:43] 10Continuous-Integration-Infrastructure: Upgrade PHPUnit to 4.0+ - https://phabricator.wikimedia.org/T99982#1330318 (10Legoktm) Which repository is this for? If it's a MediaWiki extension it's blocked on T90303, but if it is something standalone, we can convert it to a composer test entry point with its own phpu... [16:55:43] from what I see [16:56:23] 10Continuous-Integration-Infrastructure, 6Release-Engineering: automatically build and commit mediawiki/vendor (composer) - https://phabricator.wikimedia.org/T101123#1330327 (10Legoktm) [16:56:50] chasemp: yes it does by default. Can be overridden in the pillar per repo [16:57:04] legoktm: alright. :P [16:57:27] I guess it's the solution we need not the solution we want [16:57:28] 10Beta-Cluster, 6Labs: Make sure labs ENC knows about cert changes - https://phabricator.wikimedia.org/T101124#1330344 (10Andrew) Bitrotted patch: https://gerrit.wikimedia.org/r/#/c/202790/ [16:57:38] is this something you want to babysit today? [16:58:30] 10Continuous-Integration-Infrastructure: Upgrade PHPUnit to 4.0+ - https://phabricator.wikimedia.org/T99982#1330352 (10Ejegg) I was asking in regards to the DonationInterface extension. For now, I found a handy @requires annotation that lets me run the newfangled tests locally without failing on older versions... [16:59:09] seems likely to require some love for ongoing deployment work [16:59:58] chasemp: can babysit, likely will need some fine-tuning [17:00:16] 10Browser-Tests, 10Gather, 6Mobile-Web, 10MobileFrontend, 3Mobile-Web-Sprint-48-Voyage-of-the-Damned: Audit existing browser tests - https://phabricator.wikimedia.org/T101071#1327764 (10dduvall) [17:01:18] !log updated JJB fork to e3199d9..c7231fe [17:01:24] Logged the message, Master [17:01:27] not that I don't trust your judgement thcipriani :) but greg-g is this repo permissioning fixup something you are ok with getting merged today [17:01:36] knowing it will probably require a bit of your teams time to sheppard [17:02:12] 10Continuous-Integration-Infrastructure, 6Editing-Department, 10VisualEditor, 5Patch-For-Review, 7Regression: Submodule not being updated in Jenkins jobs - https://phabricator.wikimedia.org/T101105#1330393 (10hashar) Further updated JJB from e3199d9 to c7231fe Now gotta merge in https://gerrit.wikimedia... [17:02:25] Krinkle: bulk of the work is done [17:02:29] I have updated our JJB fork [17:02:30] this is where I could fling things at greg-g if we were in an office [17:02:36] only lack I feel on remoteness [17:02:44] Krinkle: I am out of time to send the announce and refresh the jobs though :-( [17:02:44] context? [17:02:45] I can't throw paper balls to gain attention [17:03:10] greg-g: teh trebuchet stuff seems to badly permission things, patch has been sitting / in the works for awhile [17:03:16] hashar: announcement? [17:03:16] greg-g: https://phabricator.wikimedia.org/T97775 [17:03:18] 10Browser-Tests, 10Gather, 6Mobile-Web, 10MobileFrontend, 3Mobile-Web-Sprint-48-Voyage-of-the-Damned: Audit existing browser tests - https://phabricator.wikimedia.org/T101071#1330399 (10dduvall) p:5Triage>3High [17:03:22] I"m ready to +2 merge and thcipriani is on it [17:03:26] Krinkle: that folks need to upgrade JJB [17:03:35] but considering you hold the bag ultimately just making sure it's a good time [17:03:38] hashar: are the jobs updated and working? [17:03:48] and you aren't in some meeting showing off how smooth deplyment works [17:03:50] what do I need to approve? [17:03:54] I dont care much for the 4 people using jjb, what about the live jobs [17:03:58] Krinkle: what I said, need to refresh them from https://gerrit.wikimedia.org/r/#/c/215335/ [17:03:58] you don't really I'm just asking / heads upping [17:03:59] ah, doit [17:04:06] * greg-g trusts thcipriani [17:04:07] _should be_ a no-op considering everything in /srv/deployment is group wikidev anyway [17:04:10] ok off we go [17:04:12] Krinkle: using the new JJB version I have pushed [17:04:14] thcipriani: understand [17:04:18] ("famous last words") [17:04:26] (03CR) 10Hashar: "recheck" [integration/config] - 10https://gerrit.wikimedia.org/r/215335 (https://phabricator.wikimedia.org/T101105) (owner: 10Hashar) [17:04:26] trust and verify [17:04:27] oh boy [17:04:28] that's my motto [17:04:32] * greg-g nods [17:04:45] you and Reagan :) [17:04:50] we've now all successfully shifted burden to thcipriani [17:04:56] well dude had good hair at least [17:05:07] (03CR) 10Hashar: "Our JJB fork got updated to c7231fe . Will let us deploy this change and verify it is working all properly." [integration/config] - 10https://gerrit.wikimedia.org/r/215335 (https://phabricator.wikimedia.org/T101105) (owner: 10Hashar) [17:05:12] Krinkle: you can give it a try with the VE jobs [17:05:16] OK [17:05:20] Will do later, Thx [17:07:28] 10Browser-Tests: mediawiki_selenium 1.2 breaks mw/core browser test when reporting to raita - https://phabricator.wikimedia.org/T100904#1330426 (10dduvall) a:3dduvall [17:08:04] thcipriani: thanks for humoring me I'm paranoid I guess [17:08:31] chasemp: just because you're paranoid doesn't mean they're not out to get you :) [17:08:37] 10Beta-Cluster, 6operations, 5Patch-For-Review, 7Puppet: Trebuchet on deployment-bastion: wrong group owner - https://phabricator.wikimedia.org/T97775#1330437 (10chasemp) 5Open>3Resolved a:3chasemp merged [17:09:14] schrodinger's paranoia [17:09:32] indeed. [17:10:45] 10Deployment-Systems, 6Release-Engineering, 10ReleaseTaggerBot, 7Epic: EPIC: Code Deploy Dashboard - https://phabricator.wikimedia.org/T280#1330441 (10mmodell) I would like to build a phabricator application that summarizes this information in a nice and easily parsable way, in a single canonical location.... [17:12:55] https://integration.wikimedia.org/ci/job/mediawiki-phpunit-hhvm-composer/11/console <-- YAY [17:13:52] ahah [17:15:07] legoktm: well done :-} [17:15:09] off for dinner [17:15:15] :) [17:16:21] polybuildr: so we want to get https://gerrit.wikimedia.org/r/#/c/201010/ in the release right? [17:16:26] 10Deployment-Systems, 10ReleaseTaggerBot: Create a phabricator application that simply summarizes which branches are currently deployed, in an easily understandable format. - https://phabricator.wikimedia.org/T101128#1330500 (10mmodell) 3NEW a:3mmodell [17:17:29] legoktm: yep [17:17:32] (03PS2) 10Legoktm: Update ExtraCharacters Sniff to allow valid shebang [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/201010 (https://phabricator.wikimedia.org/T94141) (owner: 10Hharchani) [17:17:51] (03CR) 10jenkins-bot: [V: 04-1] Update ExtraCharacters Sniff to allow valid shebang [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/201010 (https://phabricator.wikimedia.org/T94141) (owner: 10Hharchani) [17:17:55] (03CR) 10Legoktm: [C: 04-1] "PS2 was just a rebase" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/201010 (https://phabricator.wikimedia.org/T94141) (owner: 10Hharchani) [17:18:14] 10Deployment-Systems, 10ReleaseTaggerBot: Create a phabricator application that simply summarizes which branches are currently deployed, in an easily understandable format. - https://phabricator.wikimedia.org/T101128#1330515 (10mmodell) [17:18:27] legoktm: I have a fixed version of that patch ready locally. [17:18:32] polybuildr: oh. [17:18:35] polybuildr: push it then? :P [17:18:41] sure [17:19:21] legoktm: checking once. [17:20:11] (03PS3) 10Polybuildr: Update ExtraCharacters Sniff to allow valid shebang [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/201010 (https://phabricator.wikimedia.org/T94141) (owner: 10Hharchani) [17:20:46] legoktm: check now :) [17:22:49] (03CR) 10Legoktm: [C: 04-1] "Minor stuff" (033 comments) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/201010 (https://phabricator.wikimedia.org/T94141) (owner: 10Hharchani) [17:23:34] polybuildr: ^ [17:23:38] legoktm: on it [17:26:03] legoktm: replied to two of the comments. [17:27:19] polybuildr: where? [17:27:25] inline [17:27:28] oh, wait. [17:27:49] ouch. :P [17:28:09] (03CR) 10Polybuildr: "Reponses to minor stuff." (032 comments) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/201010 (https://phabricator.wikimedia.org/T94141) (owner: 10Hharchani) [17:28:20] legoktm: I didn't realise that inline comments only get saved as drafts. :'( [17:29:24] legoktm: new patch ready, though, with those things fixed. [17:31:13] (03PS4) 10Polybuildr: Update ExtraCharacters Sniff to allow valid shebang [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/201010 (https://phabricator.wikimedia.org/T94141) (owner: 10Hharchani) [17:31:46] (03PS5) 10Polybuildr: Update ExtraCharacters Sniff to allow shebang [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/201010 (https://phabricator.wikimedia.org/T94141) (owner: 10Hharchani) [17:32:10] legoktm: removed the "valid" because I'm not sure what exactly validity would mean [17:39:05] I guess it meant not invalid? :P aka same as pass [17:39:49] (03CR) 10Legoktm: [C: 032] Update ExtraCharacters Sniff to allow shebang [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/201010 (https://phabricator.wikimedia.org/T94141) (owner: 10Hharchani) [17:40:45] legoktm: so that's done. [17:42:49] legoktm: Hmm. ForrestBot working? It last ran at 23:00 yesterday, and since then a few new core patches have been merged. [17:42:53] (03Merged) 10jenkins-bot: Update ExtraCharacters Sniff to allow shebang [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/201010 (https://phabricator.wikimedia.org/T94141) (owner: 10Hharchani) [17:43:51] INFO:forrestbot:Adding PHID {'PHID-PROJ-un4fuqoaltjvpqucxw3l', 'PHID-PROJ-3hfwwinurvs6s3adzxls'} to T97444. [17:43:51] Traceback (most recent call last): [17:43:51] File "/data/project/forrestbot/forrestbot/forrestbot.py", line 166, in [17:43:51] old_projs = set(task_info['projectPHIDs']) [17:43:51] TypeError: 'NoneType' object is not subscriptable [17:44:16] James_F: it's trying to post to a security bug lol [17:44:25] legoktm: Aha. [17:44:35] * James_F opens a new ForrestBox fix task, then. [17:44:38] I'll fix that in a bit and then it'll catch up to the backlog [17:46:34] * James_F nods. [17:46:59] legoktm: so, anything else to be done? :P [17:47:11] (I must be so annoying. :P ) [17:47:16] polybuildr: I'm generating a changelog [17:47:23] okay :D [17:49:40] James_F: you have a script that generates the oojs-ui changelogs right? [17:50:56] legoktm: "Script". [17:51:25] legoktm: https://git.wikimedia.org/blob/oojs%2Fui.git/HEAD/README.md has the line. [17:51:30] legoktm: `git log --format='* %s (%aN)' --no-merges --reverse v$(node -e 'console.log(require("./package.json").version);')...HEAD | grep -v "Localisation updates from" | sort ` [17:52:22] thanks [17:59:02] legoktm: But I normally prod at the output. [17:59:24] legoktm: Also, libraries aren't the priority. :-) [18:19:11] (03PS1) 10Legoktm: Improve README, add HISTORY with changelog for 0.2.0 release [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/215376 [18:19:19] polybuildr: ^ review please [18:19:30] legoktm: on it [18:21:17] legoktm: Eww. .md means the file is viewable inside Phabricator etc. [18:21:48] James_F: I can't markdown. [18:22:08] legoktm: It's exactly the same as wikitext for everything in your README except links. :-) [18:22:13] heh [18:22:34] James_F: want to amend then please? [18:22:37] Sure. [18:22:43] Also, should we add the version number to composer.json? [18:23:12] (03CR) 10Polybuildr: [C: 04-1] "Minor edit" (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/215376 (owner: 10Legoktm) [18:23:29] James_F: no, composer determines versions based on git tags, it's weird [18:23:35] Oh, needs to be updated to markdown? [18:23:49] polybuildr: git log says you wrote it :P [18:23:55] legoktm: Eww. [18:24:19] legoktm: How did that happen? :o [18:25:59] https://gerrit.wikimedia.org/r/#/c/193766/ you reset the author [18:26:18] I'll fix it after James_F converts the readme to markdown [18:26:43] legoktm: alright :) [18:27:31] legoktm: But how did I reset the author anyway?... git review -d , edits, git rebase, git review [18:27:39] idk [18:27:47] :P [18:27:57] legoktm: weird. :P [18:28:12] James_F is fixing the README now? [18:28:37] Yeah. [18:28:43] I can fix the History too. [18:29:56] James_F: Great. :D [18:31:48] James_F: fixed and ran it manually: https://phabricator.wikimedia.org/p/Forrestbot/feed/ [18:32:42] legoktm: Yay. Thanks. [18:32:45] (03PS2) 10Jforrester: Improve README, add HISTORY with changelog for 0.2.0 release [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/215376 (owner: 10Legoktm) [18:33:27] legoktm: (I tweaked the README a bit too.) [18:33:33] (03CR) 10Jforrester: Improve README, add HISTORY with changelog for 0.2.0 release (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/215376 (owner: 10Legoktm) [18:34:25] thanks :D [18:34:32] polybuildr: +1? [18:34:38] legoktm: on it :P [18:37:01] (03CR) 10Polybuildr: "Minor indentation issue" (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/215376 (owner: 10Legoktm) [18:37:23] legoktm: James_F: Should I fix that ^ ? [18:41:26] fixing [18:43:57] (03PS3) 10Legoktm: Improve README, add HISTORY with changelog for 0.2.0 release [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/215376 [18:44:20] (03CR) 10Legoktm: Improve README, add HISTORY with changelog for 0.2.0 release (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/215376 (owner: 10Legoktm) [18:45:09] (03CR) 10Polybuildr: [C: 031] Improve README, add HISTORY with changelog for 0.2.0 release [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/215376 (owner: 10Legoktm) [18:47:52] (03CR) 10Legoktm: [C: 032] "\o/" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/215376 (owner: 10Legoktm) [18:49:29] (03Merged) 10jenkins-bot: Improve README, add HISTORY with changelog for 0.2.0 release [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/215376 (owner: 10Legoktm) [18:49:50] legoktm: +2? :O [18:51:40] polybuildr: https://github.com/wikimedia/mediawiki-tools-codesniffer/tags tag pushed :) [18:54:24] polybuildr: I'm writing an email to wikitech now :) [18:54:54] legoktm: :D [18:55:44] legoktm: also... something is wrong [18:55:47] ? [18:55:53] I added 0.2.0 as a dependency for my new extension [18:55:55] and did a composer update [18:56:15] https://dpaste.de/O698 [18:56:40] polybuildr: do you have a explicit version set for php_codesniffer in it? [18:57:06] legoktm: right. Removing and rechecking. [18:57:18] legoktm: works. :D sorry, and thanks :) [18:59:30] https://gerrit.wikimedia.org/r/214303 first patch to use 0.2.0 :P [19:08:54] 10Browser-Tests: mediawiki_selenium 1.2 breaks mw/core browser test when reporting to raita - https://phabricator.wikimedia.org/T100904#1331123 (10dduvall) Cucumber's JSON formatter appears to omit results for each of the scenario outline examples. https://github.com/cucumber/gherkin/issues/165 I'll see if I c... [19:38:03] 10Browser-Tests: mediawiki_selenium 1.2 breaks mw/core browser test when reporting to raita - https://phabricator.wikimedia.org/T100904#1331275 (10dduvall) It looks like we can work around this bug by forcing the `--expand` option in `Raita::Logger` which will include each outline example in the output as a sepa... [19:56:24] 10Continuous-Integration-Infrastructure, 10Deployment-Systems: Evaluate the value of 'Visual Diff' tools for CI / Deployment smoke testing - https://phabricator.wikimedia.org/T101154#1331365 (10mmodell) 3NEW [19:59:33] manybubbles: would this change to cucumber output in ci be a problem? https://phabricator.wikimedia.org/T100904 [20:00:23] (03CR) 10Dduvall: [C: 032] Render tags and links to SauceLabs sessions [integration/raita] - 10https://gerrit.wikimedia.org/r/215221 (owner: 10Dduvall) [20:00:33] (03CR) 10Dduvall: [C: 032] Highlight step arguments [integration/raita] - 10https://gerrit.wikimedia.org/r/215237 (owner: 10Dduvall) [20:00:38] (03Merged) 10jenkins-bot: Render tags and links to SauceLabs sessions [integration/raita] - 10https://gerrit.wikimedia.org/r/215221 (owner: 10Dduvall) [20:00:43] me? [20:00:45] (03Merged) 10jenkins-bot: Highlight step arguments [integration/raita] - 10https://gerrit.wikimedia.org/r/215237 (owner: 10Dduvall) [20:01:33] manybubbles: i think? nik? :) [20:01:57] yeah - thats me. [20:02:16] I certainly don't mind the change [20:02:23] the change would result in quite a bit more verboseness for tests using scenario outlines. i saw that there are lots of them in CirrusSearch tests [20:02:47] hurray! [20:03:50] I don't mind it [20:04:15] fantastic. the alternative workaround would have been treacherous :) [20:08:00] (03PS1) 10Dduvall: Force expanded formatter output for scenario outlines [selenium] - 10https://gerrit.wikimedia.org/r/215501 (https://phabricator.wikimedia.org/T100904) [20:11:39] (03PS1) 10Dduvall: Releasing patch version 1.2.1 [selenium] - 10https://gerrit.wikimedia.org/r/215503 [20:12:25] 10Beta-Cluster, 10Continuous-Integration-Infrastructure, 10Staging, 6Labs: Change local puppetmaster names for RE labs projects - https://phabricator.wikimedia.org/T101110#1331464 (10thcipriani) Staging, Deployment-prep, and Integration projects are all updated. No-op in all cases. $ RUBYLIB=/var/lib... [20:12:48] 10Beta-Cluster, 10Continuous-Integration-Infrastructure, 10Staging, 6Labs: Change local puppetmaster names for RE labs projects - https://phabricator.wikimedia.org/T101110#1331465 (10thcipriani) 5Open>3Resolved [20:15:19] Gerrit comments break when a phabricator link is put in them. [20:15:24] Is there an open task for that somewhere? [20:15:30] hashar: ^ ? [20:15:37] for example, https://gerrit.wikimedia.org/r/#/c/215502/ [20:15:43] If there isn't one, I'll open one now. [20:17:31] 10Deployment-Systems, 6Release-Engineering, 5Patch-For-Review: scap should lint JSON files - https://phabricator.wikimedia.org/T100600#1331521 (10Legoktm) Should I leave this open until scap is deployed? Or will someone else take care of that...? [20:37:59] !log manually rebased operations/puppet on integration-puppetmaster to fix empty commit from cherry-pick [20:38:05] Logged the message, Master [20:40:57] !log cherry-picked https://gerrit.wikimedia.org/r/#/c/208024/ on integration-puppetmaster [20:41:01] Logged the message, Master [20:49:15] !log Updated scap to 62d5cb2 (Lint JSON files) [20:49:20] legoktm: ^ [20:49:20] Logged the message, Master [20:49:30] bd808: thanks :D [20:49:52] bd808: should we do a test sync to make sure nothing is b0rked? [20:50:33] https://integration.wikimedia.org/ci/view/Beta/job/beta-scap-eqiad/55531/console [20:51:02] 10Continuous-Integration-Infrastructure, 10Deployment-Systems: Evaluate the value of 'Visual Diff' tools for CI / Deployment smoke testing - https://phabricator.wikimedia.org/T101154#1331671 (10greg) See also (duplicate of?) {T64633} [20:51:21] bd808: oh, did you update it in beta or prod? [20:51:26] beta [20:51:44] looks like it was safe [20:51:48] woot [20:51:57] at least for a full scap [20:52:11] Do you want to do it for prod? [20:52:20] yes please :) [20:54:09] !log deleted unused deployment-rsync01 instance [20:54:15] Logged the message, Master [20:58:16] !log redis-cli srem "deploy:scap/scap:minions" i-000002f4.eqiad.wmflabs [20:58:21] Logged the message, Master [20:59:15] 10Continuous-Integration-Infrastructure, 6Editing-Department, 10VisualEditor, 5Patch-For-Review, 7Regression: Submodule not being updated in Jenkins jobs - https://phabricator.wikimedia.org/T101105#1331722 (10hashar) Finished too late, had some meetings in the evening. So will process updating jobs caref... [21:00:10] legoktm: Looks like twentyafterfour already deployed it in prod [21:00:16] heh [21:00:21] alright then :D [21:00:46] {"sync-time": "20150602-121000", "tag": "scap/scap-sync-20150602-121000", "user": "Mukunda Modell", "time": "20150602-121000"} [21:01:05] bd808: you would be happy to know people do fix issues reported in #wikimedia-log-errors :-})))))) [21:01:18] :) good! [21:01:20] I have been triaging a bunch of bug on monday and had pleasant replies [21:01:39] and the dashboards are quite nice [21:02:05] * twentyafterfour thought it was forbidden to merge and not deploy [21:02:10] Now that logstash is stable again I should probably do a brown bag talk about how to use it [21:02:48] twentyafterfour: that confusing rule is only for ops/puppet and mediawiki-config [21:03:27] but the beta scap doesn't auto-update so when you push out a change to scap you should do it there first and then in prod most of the time [21:03:43] ok [21:04:04] so many dumb differences from repo to repo to remember [21:04:34] I almost nerd sniped myself into forking trebuchet over the weekend [21:04:42] but then I came to my senses [21:05:09] (03CR) 1020after4: [C: 032] Force expanded formatter output for scenario outlines [selenium] - 10https://gerrit.wikimedia.org/r/215501 (https://phabricator.wikimedia.org/T100904) (owner: 10Dduvall) [21:05:32] (03Merged) 10jenkins-bot: Force expanded formatter output for scenario outlines [selenium] - 10https://gerrit.wikimedia.org/r/215501 (https://phabricator.wikimedia.org/T100904) (owner: 10Dduvall) [21:05:35] bd808: D: [21:05:49] I did come up with an idea for changing scap to use a git repo instead of rsync [21:05:59] I think it would be pretty easy to implement [21:06:10] orly? [21:06:29] what would be the advantage? [21:06:35] precomputed hashes [21:06:40] I actually think the rsync method works pretty well [21:06:47] so no slow ass rsync fetch [21:07:04] (03CR) 1020after4: [C: 032] Releasing patch version 1.2.1 [selenium] - 10https://gerrit.wikimedia.org/r/215503 (owner: 10Dduvall) [21:07:18] rsync has to stat every file on both sides to figure out what deltas to request [21:07:25] which is slow [21:07:28] really slow [21:07:33] doesn't git have to do similar? [21:07:52] git status is really slow when there are a lot of submodules [21:08:04] (03Merged) 10jenkins-bot: Releasing patch version 1.2.1 [selenium] - 10https://gerrit.wikimedia.org/r/215503 (owner: 10Dduvall) [21:08:22] because there are a bunch of repos. with one repo it would be pretty fast [21:08:24] Yippee, build fixed! [21:08:25] Project browsertests-Flow-en.wikipedia.beta.wmflabs.org-linux-chrome-sauce build #657: FIXED in 42 min: https://integration.wikimedia.org/ci/job/browsertests-Flow-en.wikipedia.beta.wmflabs.org-linux-chrome-sauce/657/ [21:08:39] the repo on tin would be the squash of everything [21:08:50] bd808: but mediawiki has a lot of repos, so how would scap avoid the bunch-of-repos problem? [21:09:03] ah so like my subtree merge experiment? [21:09:12] sort of [21:09:38] I really like the idea of having the release branches merge the extensions in instead of using submodules [21:09:46] +34 [21:09:47] my idea was just to make a local repo on tin, use rsync to update it from the staging dir, git add, git commit [21:10:01] talked about it with jzerebecki during the hackathon [21:10:14] that is what they are doing for wikidata [21:10:32] they have a build script that flatten all their extensions + whatever dependencies they need [21:10:44] twentyafterfour: the only part of that I'm not sure about is how easy cherry-picks would be [21:10:45] and we deploy it has it was a single extension (it is one submodule) [21:10:57] that == subtrees [21:10:59] the subtree merge is essentially the same thing, except it carries over the commit messages from the sub-repos [21:11:39] the scripts I am using support cherry picking on the sub-trees [21:11:47] many (most?) of the swat changes are cherry picks from master to the release branches [21:12:10] bd808: I like the pull request model that releeph uses [21:12:11] so as long as people can be easily show how to keep doing that, +1 [21:13:09] twentyafterfour: will you use yet another repo for that ? [21:13:26] like mediawiki/wmfdeploy.git ? or would it be in the wmf branches [21:13:42] hashar: for the merged tree? it would be like wmfdeploy.git probably [21:13:53] yeah I would prefer that [21:14:04] twentyafterfour: git does not have to stat any files to transfer changes (git fetch), only for git checkout or other commands that need to update the whole working copy. both together still save over rsync the stats on the sending side . [21:14:10] it could just live in a branch of mediawiki/core though, the drawback is that would add bloat to /core [21:14:11] else mediawiki/core.git would become too big [21:14:18] sold [21:14:19] :-} [21:14:27] potentially we could use the beta cluster to try it out [21:15:12] hashar: one advantage is that CI / beta would have a single target to check out instead of having to recursively update submodules [21:15:18] we can create a wiki using an alternate php dir ( something like: subtreewiki php-subtree ) [21:15:34] the problem I ran into is sub-sub-modules like extensions/visualeditor/lib/ve [21:15:36] and have that wmfdeploy.git repo pulled in /srv/.blabla../php-subtree/ [21:16:06] 10Deployment-Systems, 6Release-Engineering, 5Patch-For-Review: scap should lint JSON files - https://phabricator.wikimedia.org/T100600#1331795 (10bd808) 5Open>3Resolved Deployed to beta cluster and prod [21:17:20] ah submodules in submodules grrr [21:17:49] you will need some recursion :-/ [21:19:42] for such extensions, I guess you will need an intermediate branch [21:20:00] that would have the extension code + its submodules as subtrees [21:21:58] anyway time for bed. And yeah I love the idea twentyafterfour :-} [21:21:59] mediawiki/core --> extensions/VisualEditor --> lib/ve [21:22:11] :D [21:22:15] yup gotta recurse into that :/ [21:22:46] or we could have extensions/VisualEditor to have VisualEditor has a dependency in npm [21:23:08] and use npm to incorporate it in our stage. crazy [21:25:01] Why does visual editor need to have have the lib separate from the extension anyway? [21:25:19] twentyafterfour: lib/ve is a standalone html? editor, and extensions/VisualEditor is the MediaWiki integration part [21:27:20] yeah, VE core and VE-MW are separate [21:28:19] well one way to deal with it would be to incorporate VE core into the extension as a subrepo then incorporate the extension as a subrepo of mediawiki core [21:33:11] thcipriani: have you got a plan for dealing with the changes that andrewbogott is going to make to role::puppet::self for the beta cluster? [21:34:11] twentyafterfour, is this causing issues for you right now? [21:34:25] the immediate change is delt with: the change to role::puppet::self, the ultimate change to using a new dns schema is trickier [21:35:48] 10Continuous-Integration-Infrastructure: Jenkins: Set up perceptual diffs (visual regression testing) - https://phabricator.wikimedia.org/T64633#1331902 (10mmodell) [21:35:49] 10Continuous-Integration-Infrastructure, 10Deployment-Systems: Evaluate the value of 'Visual Diff' tools for CI / Deployment smoke testing - https://phabricator.wikimedia.org/T101154#1331901 (10mmodell) [21:36:07] *nod* wikitech is still reporting puppetmaster=deployment-salt.eqiad.wmflabs for all the instances but I'm guessing you changed it with hiera instead of updating all the instances individually [21:36:32] 1. Have to update salt master for all the minions, 2. have to re-generate puppet keys for the master, then rerun puppet agent on each instance and resign keys [21:36:42] Krenair: the visual editor submodule? not causing major issues, it's just something that needs to be solved if we want to move forward with subtrees [21:36:48] bd808: yeah, ldap still reports that, but hiera overrides ldap in this case [21:37:12] it's not immediately a problem, the whole idea is somewhat speculative [21:37:13] the other thing is the puppet ENC will have to be updated to use the new domain names so that we even get info from ldap [21:37:24] patch pending for that [21:37:34] fun [21:37:54] if you need hands to run things when the big day comes just let me know [21:38:32] bd808: thanks, it'll probably just be a mad dash for an hour or so of puppet failures, but not too bad. [21:38:59] twentyafterfour, please could you write this down in a task or email to editing-team@ or something? [21:41:39] Krenair: ok, I hadn't wanted to bother anyone about it yet since it's rather speculative, but I would welcome feedback on the idea. The task is https://phabricator.wikimedia.org/T98834 [21:50:41] 10Deployment-Systems, 6Release-Engineering: Use subrepos instead of git submodules for deployed MediaWiki extensions - https://phabricator.wikimedia.org/T98834#1331975 (10mmodell) Following up from a conversation we had in `#wikimedia-releng` on irc (CC'ing interested-parties): One thing that I would have to... [21:53:08] Krenair: CC'd you, the entire "Editing Department," as well as some other potentially interested parties :) [21:53:38] thanks [21:55:41] twentyafterfour: did you send it to editing-team@wikimedia.org? I don't see it yet [21:55:53] 10Deployment-Systems, 6Release-Engineering: Use subrepos instead of git submodules for deployed MediaWiki extensions - https://phabricator.wikimedia.org/T98834#1331985 (10mmodell) My experience so far is that `git subrepo pull --all` is quite slow. I don't think it's any slower than make-wmf-branch but it's n... [21:55:54] not sure about ccing entire projects for such things, but ok [21:56:15] oh [21:56:16] in phab [21:56:17] lol [21:56:23] yeah in phab [22:28:52] 10Deployment-Systems, 6Release-Engineering: Use subrepos instead of git submodules for deployed MediaWiki extensions - https://phabricator.wikimedia.org/T98834#1332099 (10Jdforrester-WMF) >>! In T98834#1331975, @mmodell wrote: > Following up from a conversation we had in `#wikimedia-releng` on irc (CC'ing int... [22:40:09] 10Browser-Tests, 10Continuous-Integration-Infrastructure, 6Release-Engineering, 7Epic, and 2 others: Fix or delete browsertests* Jenkins jobs that are failing for more than a week (tracking) - https://phabricator.wikimedia.org/T94150#1332163 (10dduvall) 5stalled>3Open a:3dduvall [23:06:12] Project browsertests-Gather-en.m.wikipedia.beta.wmflabs.org-linux-chrome-sauce build #139: FAILURE in 9 min 12 sec: https://integration.wikimedia.org/ci/job/browsertests-Gather-en.m.wikipedia.beta.wmflabs.org-linux-chrome-sauce/139/ [23:14:56] 6Release-Engineering, 6operations: Try out hack (>! In T91590#1329608, @demon wrote: > (Should we be linting with hhvm anyway? Hmm....) Once tin is upgraded to trusty `php` will point to `hhvm` and we'd be linting with... [23:31:20] PROBLEM - Puppet failure on deployment-pdf01 is CRITICAL 100.00% of data above the critical threshold [0.0] [23:31:24] PROBLEM - Puppet staleness on deployment-urldownloader is CRITICAL 100.00% of data above the critical threshold [43200.0] [23:31:44] PROBLEM - Puppet failure on deployment-cache-text02 is CRITICAL 100.00% of data above the critical threshold [0.0] [23:53:54] Yippee, build fixed! [23:53:55] Project browsertests-Gather-en.m.wikipedia.beta.wmflabs.org-linux-chrome-sauce build #140: FIXED in 8 min 58 sec: https://integration.wikimedia.org/ci/job/browsertests-Gather-en.m.wikipedia.beta.wmflabs.org-linux-chrome-sauce/140/