[00:09:20] Krinkle: so, I've been thinking of having 'npm'/'php-composer-test' run for all extensions, but only do anything if a package.json/composer.json is configured properly with a "test" command. It would making adding new checks much easier since devs are no longer dependent upon CI updates. Thoughts? [00:11:51] (03PS3) 10Dduvall: Builder for running MW-Selenium integration tests [integration/config] - 10https://gerrit.wikimedia.org/r/219513 (https://phabricator.wikimedia.org/T103039) [00:16:17] legoktm: Hm.. does Zuul have a way to run a job for a wildcard of projects [00:16:18] ? [00:16:25] Or would it not simplify Zuul management [00:16:27] nope [00:16:52] it wouldn't really, but we could blanket add npm for all MW extensions like we do with php-composer-validate [00:16:56] I think getting entry points standardised is essentially that effort already [00:17:45] So extension get jenkins-bot comments with both npm and composer entries always? [00:17:55] yeah [00:18:04] I'd rather merge them in that case [00:18:11] in prep for isolation [00:18:27] perhaps a 'test' job that runs composer install/test and npm install/test [00:18:28] oh, one job that does "npm install && npm test && composer update && composer test"? [00:18:42] both conditionally on there being package.json or composer.json in the repo [00:18:53] not based on the contents I think [00:19:24] idk about package.json, but for composer we have to account for extensions that were made "installable" and won't have a "test" command set [00:19:34] example? [00:20:06] !log running `jenkins-jobs update` to create 'mediawiki-selenium-integration' with I7affe14e878d5c1fc4bcb4dfc7f2d1494cd795b7 [00:20:08] Logged the message, Master [00:20:23] https://github.com/wikimedia/mediawiki-extensions-Translate/blob/master/composer.json [00:26:01] brb in 15-20 [00:27:08] (03PS4) 10Dduvall: Builder for running MW-Selenium integration tests [integration/config] - 10https://gerrit.wikimedia.org/r/219513 (https://phabricator.wikimedia.org/T103039) [00:32:54] !log running `jenkins-jobs update` to create 'mwext-MobileFrontend-mw-selenium' with I7affe14e878d5c1fc4bcb4dfc7f2d1494cd795b7 [00:32:56] Logged the message, Master [00:33:25] (03PS5) 10Dduvall: Builder for running MW-Selenium integration tests [integration/config] - 10https://gerrit.wikimedia.org/r/219513 (https://phabricator.wikimedia.org/T103039) [00:38:38] !log reloading zuul to deploy https://gerrit.wikimedia.org/r/#/c/219513/ [00:38:40] Logged the message, Master [00:39:33] (03CR) 10Dduvall: "check experimental" [selenium] - 10https://gerrit.wikimedia.org/r/220348 (https://phabricator.wikimedia.org/T103039) (owner: 10Dduvall) [00:42:40] (03PS1) 10Krinkle: Highlight current menu item [integration/docroot] - 10https://gerrit.wikimedia.org/r/220360 [00:42:42] (03PS1) 10Krinkle: Use standard header and footer [integration/docroot] - 10https://gerrit.wikimedia.org/r/220361 [00:42:50] (03CR) 10Krinkle: [C: 032] Highlight current menu item [integration/docroot] - 10https://gerrit.wikimedia.org/r/220360 (owner: 10Krinkle) [00:42:57] (03CR) 10Krinkle: [C: 032] Use standard header and footer [integration/docroot] - 10https://gerrit.wikimedia.org/r/220361 (owner: 10Krinkle) [00:43:01] (03CR) 10jenkins-bot: [V: 04-1] Use standard header and footer [integration/docroot] - 10https://gerrit.wikimedia.org/r/220361 (owner: 10Krinkle) [00:43:18] (03PS2) 10Krinkle: Highlight current menu item [integration/docroot] - 10https://gerrit.wikimedia.org/r/220360 [00:43:42] (03CR) 10Krinkle: [C: 032] Highlight current menu item [integration/docroot] - 10https://gerrit.wikimedia.org/r/220360 (owner: 10Krinkle) [00:43:52] Krinkle: so..god idea? [00:43:53] (03Merged) 10jenkins-bot: Highlight current menu item [integration/docroot] - 10https://gerrit.wikimedia.org/r/220360 (owner: 10Krinkle) [00:43:56] good* [00:44:29] legoktm: What's the reason for Translate not to have any composer test [00:44:32] surely they need lint and phpcs? [00:44:43] if they're not migrated yet, just don't enable it for that repo yet [00:45:06] but for all extensions that have no such file yet or have a "proper" file, we can enable the new job [00:45:16] but beware of queue pollution. [00:45:22] Let's keep a few prefixes where possible. [00:45:28] e.g. 'test' and 'mw-test' at least. [00:46:00] and hopefully removing all npm/composer/jshint/phpcs/phpunit soon [00:46:17] Feel free to experiment on oojs-ui as example if you like [00:46:29] (03PS2) 10Krinkle: Use standard header and footer [integration/docroot] - 10https://gerrit.wikimedia.org/r/220361 [00:46:35] ok, sounds good :) [00:46:36] (03CR) 10Krinkle: [C: 032] Use standard header and footer [integration/docroot] - 10https://gerrit.wikimedia.org/r/220361 (owner: 10Krinkle) [00:46:45] legoktm: Thanks! [00:46:47] (03Merged) 10jenkins-bot: Use standard header and footer [integration/docroot] - 10https://gerrit.wikimedia.org/r/220361 (owner: 10Krinkle) [00:50:31] Project browsertests-Gather-en.m.wikipedia.beta.wmflabs.org-linux-chrome-sauce build #169: FAILURE in 9 min 49 sec: https://integration.wikimedia.org/ci/job/browsertests-Gather-en.m.wikipedia.beta.wmflabs.org-linux-chrome-sauce/169/ [00:50:47] Project browsertests-MobileFrontend-SmokeTests-linux-chrome-sauce build #165: FAILURE in 9 min 55 sec: https://integration.wikimedia.org/ci/job/browsertests-MobileFrontend-SmokeTests-linux-chrome-sauce/165/ [01:20:43] (03PS1) 10Krinkle: Remove stray   [integration/docroot] - 10https://gerrit.wikimedia.org/r/220363 [01:20:56] (03CR) 10Krinkle: [C: 032] "Thanks Held3r." [integration/docroot] - 10https://gerrit.wikimedia.org/r/220363 (owner: 10Krinkle) [01:21:07] (03Merged) 10jenkins-bot: Remove stray   [integration/docroot] - 10https://gerrit.wikimedia.org/r/220363 (owner: 10Krinkle) [01:23:25] 10Continuous-Integration-Infrastructure, 6Labs, 10Tool-Labs: Recover homedir of "ci" tool - https://phabricator.wikimedia.org/T103205#1394990 (10jayvdb) Is this part of {T100903}? *wishful thinking* [01:25:11] 10Continuous-Integration-Infrastructure, 6Labs, 10Tool-Labs: Recover homedir of "ci" tool - https://phabricator.wikimedia.org/T103205#1394992 (10Legoktm) >>! In T103205#1394990, @jayvdb wrote: > Is this part of {T100903}? *wishful thinking* No, it's a bot that updates (or used to...) https://www.mediawiki.o... [01:29:18] (03PS1) 10Legoktm: global-set-env: Create "composer" alias for convenience [integration/jenkins] - 10https://gerrit.wikimedia.org/r/220364 [01:34:33] (03CR) 10Dduvall: "check experimental" [selenium] - 10https://gerrit.wikimedia.org/r/220348 (https://phabricator.wikimedia.org/T103039) (owner: 10Dduvall) [01:35:30] 10Browser-Tests, 6Collaboration-Team, 10Echo: 503 on Echo tests - https://phabricator.wikimedia.org/T103437#1395005 (10Mattflaschen) I belatedly remembered that I saw CentralAuth token errors on Beta when logging in or creating an account (I forget which) around this time, so that might be it. [01:48:23] (03PS1) 10Dduvall: Add mw-set-env-mw-selenium.sh for mw-selenium builder [integration/jenkins] - 10https://gerrit.wikimedia.org/r/220368 (https://phabricator.wikimedia.org/T103039) [01:58:57] (03CR) 10Dduvall: [C: 032] Add mw-set-env-mw-selenium.sh for mw-selenium builder [integration/jenkins] - 10https://gerrit.wikimedia.org/r/220368 (https://phabricator.wikimedia.org/T103039) (owner: 10Dduvall) [01:59:29] (03Merged) 10jenkins-bot: Add mw-set-env-mw-selenium.sh for mw-selenium builder [integration/jenkins] - 10https://gerrit.wikimedia.org/r/220368 (https://phabricator.wikimedia.org/T103039) (owner: 10Dduvall) [02:07:42] (03PS1) 10Dduvall: Fix permissions of mw-set-env-mw-selenium.sh [integration/jenkins] - 10https://gerrit.wikimedia.org/r/220373 [02:08:30] (03CR) 10Dduvall: [C: 032] Fix permissions of mw-set-env-mw-selenium.sh [integration/jenkins] - 10https://gerrit.wikimedia.org/r/220373 (owner: 10Dduvall) [02:09:01] (03Merged) 10jenkins-bot: Fix permissions of mw-set-env-mw-selenium.sh [integration/jenkins] - 10https://gerrit.wikimedia.org/r/220373 (owner: 10Dduvall) [02:28:48] 10Browser-Tests, 10Wikidata, 7Pywikibot-Wikidata, 7Pywikibot-tests: Testing Pywikibot-Wikidata changes on non-production wikis - https://phabricator.wikimedia.org/T85358#1395037 (10jayvdb) >>! In T85358#1392985, @zeljkofilipin wrote: > Is this still a problem? If not, can it be resolved? The steps to repr... [03:01:01] (03PS2) 10Dduvall: Integration tests to be run by CI [selenium] - 10https://gerrit.wikimedia.org/r/220348 (https://phabricator.wikimedia.org/T103039) [04:02:37] (03PS1) 10Legoktm: [WIP] Add job to run pywikibot tests against beta cluster [integration/config] - 10https://gerrit.wikimedia.org/r/220384 (https://phabricator.wikimedia.org/T100903) [04:33:17] 10Beta-Cluster, 10Continuous-Integration-Infrastructure, 10pywikibot-core, 5Patch-For-Review: Run pywikibot test suite regularly on beta cluster as part of MediaWiki/Wikimedia CI - https://phabricator.wikimedia.org/T100903#1395264 (10Legoktm) https://integration.wikimedia.org/ci/view/Default/job/pywikibot-... [05:28:08] (03PS1) 10Legoktm: Use upstream codesniffer 2.3.3 [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/220399 [05:33:06] (03PS2) 10Legoktm: global-set-env: Create "composer" alias for convenience [integration/jenkins] - 10https://gerrit.wikimedia.org/r/220364 [05:38:27] 10Continuous-Integration-Infrastructure: php-composer-validate job should not be triggered if a composer.json file is removed from the repository - https://phabricator.wikimedia.org/T89263#1395323 (10Legoktm) >>! In T89263#1209368, @hashar wrote: > Maybe php-composer-validate could skip if composer.json but that... [05:38:35] (03PS1) 10Legoktm: Don't fail composer validate if a composer.json is removed [integration/config] - 10https://gerrit.wikimedia.org/r/220405 (https://phabricator.wikimedia.org/T89263) [05:38:50] 10Continuous-Integration-Infrastructure, 5Patch-For-Review: php-composer-validate job should not be triggered if a composer.json file is removed from the repository - https://phabricator.wikimedia.org/T89263#1395328 (10Legoktm) a:3Legoktm [06:37:54] Yippee, build fixed! [06:37:54] Project browsertests-Gather-en.m.wikipedia.beta.wmflabs.org-linux-chrome-sauce build #170: FIXED in 9 min 44 sec: https://integration.wikimedia.org/ci/job/browsertests-Gather-en.m.wikipedia.beta.wmflabs.org-linux-chrome-sauce/170/ [07:23:36] 10Deployment-Systems, 6Release-Engineering, 10RESTBase, 6Services, 6operations: Get ops feedback regarding the use of SSH for deployment system control channel. - https://phabricator.wikimedia.org/T102687#1395514 (10MoritzMuehlenhoff) >>! In T102687#1381061, @fgiunchedi wrote: > I can see ssh working, in... [07:27:25] 10Deployment-Systems, 6Release-Engineering, 10RESTBase, 6Services, 6operations: Get ops feedback regarding the use of SSH for deployment system control channel. - https://phabricator.wikimedia.org/T102687#1395521 (10Joe) I strongly oppose to using mcollective, FWIW. I tried it in the past and it's way w... [07:41:35] Yippee, build fixed! [07:41:36] Project browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-windows_8-internet_explorer-10-sauce build #78: FIXED in 32 min: https://integration.wikimedia.org/ci/job/browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-windows_8-internet_explorer-10-sauce/78/ [07:57:00] !log disabling NFS on deployment-parsoidcache02 [07:57:03] Logged the message, Master [07:58:11] !log Bah puppet reenable NFS on deployment-parsoidcache02 for some reason [07:58:14] Logged the message, Master [08:01:02] 10Beta-Cluster, 7Varnish: deployment-parsoidcache02 fails puppet: Role::Cache::Statsd/Varnish::Logging::Statsd[default]/Base::Service_unit[varnishstatsd-default]/Service[varnishstatsd-default]: Could not evaluate: Could not find init script or upstart conf file... - https://phabricator.wikimedia.org/T103660#1395617 [08:22:34] haha :P [08:22:43] hashar: puppet's not letting you do what you want? [08:24:29] polybuildr: yeah something new got introduced which is not passing on beta cluster :/ [08:24:48] okay :/ [08:38:59] 10Deployment-Systems, 6Release-Engineering, 10RESTBase, 6Services, 6operations: Get ops feedback regarding the use of SSH for deployment system control channel. - https://phabricator.wikimedia.org/T102687#1395679 (10mobrovac) >>! In T102687#1395514, @MoritzMuehlenhoff wrote: > How many services are we ta... [09:10:02] Project browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-os_x_10.9-safari-sauce build #640: FAILURE in 1 hr 0 min: https://integration.wikimedia.org/ci/job/browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-os_x_10.9-safari-sauce/640/ [09:18:11] !log getting rid of java 6 on CI machines ( https://phabricator.wikimedia.org/T103491 ) [09:18:14] Logged the message, Master [09:18:36] 10Continuous-Integration-Infrastructure, 6operations, 5Patch-For-Review: Remove Java 6 from CI Jenkins slaves - https://phabricator.wikimedia.org/T103491#1395712 (10hashar) [09:42:15] 10Continuous-Integration-Infrastructure, 6operations, 5Patch-For-Review: Remove Java 6 from CI Jenkins slaves - https://phabricator.wikimedia.org/T103491#1395761 (10hashar) Purged the packages from gallium and lanthanum. Same for labs machines with: salt '*' cmd.run 'apt-get remove --yes --purge openjdk... [09:43:07] 10Continuous-Integration-Infrastructure, 6operations, 5Patch-For-Review: Remove Java 6 from CI Jenkins slaves - https://phabricator.wikimedia.org/T103491#1395765 (10hashar) [09:51:40] 10Continuous-Integration-Infrastructure, 6operations, 5Patch-For-Review: Remove Java 6 from CI Jenkins slaves - https://phabricator.wikimedia.org/T103491#1395787 (10hashar) Java alternatives on labs instances no more shows java6: ``` salt '*' cmd.run 'ls -l /etc/alternatives/j*|grep java-6' i-0000063a.eqiad.... [09:51:47] 10Continuous-Integration-Infrastructure, 6operations, 5Patch-For-Review: Remove Java 6 from CI Jenkins slaves - https://phabricator.wikimedia.org/T103491#1395788 (10hashar) [09:52:11] 10Continuous-Integration-Infrastructure, 6operations, 5Patch-For-Review: Remove Java 6 from CI Jenkins slaves - https://phabricator.wikimedia.org/T103491#1395789 (10hashar) 5Open>3Resolved a:3hashar Java 6 is gone. Thank you @MoritzMuehlenhoff ! [09:52:30] !log Java 6 removed from gallium / lanthanum and CI labs slaves. [09:52:33] Logged the message, Master [10:04:53] hashar: something with jenkins? [10:08:59] kart_: what ? [10:09:17] hashar: https://integration.wikimedia.org/ci/job/npm/10865/console [10:09:31] state the problem please, I am busy on other things :-D [10:09:55] It is backport to wmf10, and I think new job was added after wmf10 [10:10:01] What to do in this case? :) [10:12:42] hashar: ignore it? [10:13:23] so [10:13:40] mediawiki/extensions/ContentTranslation change https://gerrit.wikimedia.org/r/#/c/220436/ fails on wmf10 branch [10:13:45] because npm job fails [10:13:58] yes [10:14:00] and yeah there is no package.son yet [10:14:06] so you can force merge that one :-] [10:14:11] okay! [10:14:14] Thanks. [10:14:23] you might want to backport package.json to the REL branches as well [10:14:28] since they will end up having the same issue [10:14:50] hashar: it is in wmf11, so that's okay. [10:16:14] hashar: I need to verified +2, right? [10:16:19] yeah [10:16:22] and remove Jenkins vote [10:16:34] cause the verified -X by Jenkins would prevent the change from being merged by Gerrit [10:16:44] did it :D [10:18:52] Still failing? [10:18:54] :/ [10:20:23] ooo. Publish and Submit. [10:21:17] kart_: yeah but your patch is already merged [10:21:24] feel free to backport package.son to the wmf10 branch :} [10:24:28] hashar: thanks! [10:24:36] any branching expert awake? [10:24:53] I cherry-picked two patches to wmf10/wmf11 [10:25:16] and now updating submodule doesn't show any difference to submit. [10:25:27] Using: https://wikitech.wikimedia.org/wiki/How_to_deploy_code#Updating_the_submodule [10:27:40] kart_: need to cherry pick the patches in the extension wmf branches [10:27:44] get them merged [10:27:58] then in mediawiki/core wmf branches update the extension for each branch [10:28:07] then commit the submodule update for each branch and send for review [10:28:12] (yeah painful process) [10:28:35] hashar: yeah done it for months :) [10:28:54] but somehow it doesn't show any difference/diff [10:29:18] look like when I merged patches, it updated https://gerrit.wikimedia.org/r/#/admin/projects/mediawiki/extensions/ContentTranslation,branches [10:29:21] too [10:30:16] hashar: any other ideas? [10:30:40] 10Continuous-Integration-Infrastructure, 10Wikibase-Quality-Constraints, 10Wikidata, 3Wikidata-Sprint-2015-06-16: MW_INSTALL_PATH incorrect for WikibaseQualityConstraints jenkins jobs - https://phabricator.wikimedia.org/T103626#1395923 (10JanZerebecki) [10:32:26] (03CR) 10Hashar: "In bash alias takes precedent over PATH. Would prevent us from overriding the composer installation if needed." [integration/jenkins] - 10https://gerrit.wikimedia.org/r/220364 (owner: 10Legoktm) [10:35:58] hashar: should merged into wmf10/wmf11 caused problem? [10:37:04] I cherry picked, merged them, tried to update submodule - found no diff in extensions/ContentTranslation, so can't submit patch :/ [10:52:52] 10Continuous-Integration-Infrastructure, 10Wikibase-Quality-Constraints, 10Wikidata, 3Wikidata-Sprint-2015-06-16: MW_INSTALL_PATH incorrect for WikibaseQualityConstraints jenkins jobs - https://phabricator.wikimedia.org/T103626#1396001 (10Tobi_WMDE_SW) [11:12:38] 6Release-Engineering, 10Gather, 10MobileFrontend, 7Epic, and 3 others: [EPIC] Encourage developers to increase code coverage - https://phabricator.wikimedia.org/T100294#1396039 (10phuedx) > It seems a cheap way to do this would be to use the existing grunt qunit:cov command and then reject patches that pus... [11:26:05] 5Continuous-Integration-Isolation: Create a Jessie image with diskimage-builder suitable for nodepool - https://phabricator.wikimedia.org/T102878#1396066 (10hashar) p:5High>3Normal [11:27:18] 5Continuous-Integration-Isolation, 6Labs: Nodepool can't SSH to spawn instances due to wmflabs provided instances due ssh algorithms - https://phabricator.wikimedia.org/T102459#1396075 (10hashar) [11:44:28] 5Continuous-Integration-Isolation: nodepool users should have OpenStack env variables set on login - https://phabricator.wikimedia.org/T103673#1396143 (10hashar) 3NEW [11:54:33] 5Continuous-Integration-Isolation: nodepool users should have OpenStack env variables set on login - https://phabricator.wikimedia.org/T103673#1396182 (10hashar) We can probably use the puppet wmflibs function `shell_exports`: Invocation: shell_exports({ apache_run_user => 'apache', apache_pid_file =>... [12:42:56] greg-g: twentyafterfour Please see my mail when you wake up. [12:43:07] thcipriani|afk: are you SWATing today? [12:44:07] kart_: was planning to after some morning things. [12:45:51] thcipriani|afk: cool. I need some clarification, so lets talk when you're free. 30 minutes prior to SWAT is fine. [12:47:32] kart_: kk will be around about 30 min pre swat. I'll ping you then. [12:50:12] Thanks! [13:03:50] 10Continuous-Integration-Infrastructure, 10Wikibase-Quality-Constraints, 10Wikidata, 3Wikidata-Sprint-2015-06-16: MW_INSTALL_PATH incorrect for WikibaseQualityConstraints jenkins jobs - https://phabricator.wikimedia.org/T103626#1396333 (10JanZerebecki) https://gerrit.wikimedia.org/r/#/c/220339/ [13:06:33] 10Continuous-Integration-Infrastructure, 10Wikibase-Quality-Constraints, 10Wikidata, 3Wikidata-Sprint-2015-06-16: MW_INSTALL_PATH incorrect for WikibaseQualityConstraints jenkins jobs - https://phabricator.wikimedia.org/T103626#1396334 (10hoo) >>! In T103626#1396333, @JanZerebecki wrote: > https://gerrit.w... [13:14:45] 5Continuous-Integration-Isolation, 6operations: Figure out fine sudo rules for the nodepool service - https://phabricator.wikimedia.org/T102281#1396342 (10hashar) So on `labnodepool1001.eqiad.wmnet` I run: sudo -u nodepool nodepool image-build ci-jessie-wikimedia The first sudo error is: ``` ++ id -u ++... [13:28:44] 5Continuous-Integration-Isolation, 6operations: Figure out fine sudo rules for the nodepool service / diskimage-builder - https://phabricator.wikimedia.org/T102281#1396353 (10hashar) [13:32:46] 5Continuous-Integration-Isolation, 6operations: Figure out fine sudo rules for the nodepool service / diskimage-builder - https://phabricator.wikimedia.org/T102281#1396365 (10hashar) So diskimage-builder is a python utility that apply shell based templates. Some commands are run on the machine outside of the... [14:17:28] kart_: what's up? [14:17:36] thcipriani: hello [14:17:50] Let me describe [14:18:09] thcipriani: I wanted to have two patches cherry-pick in wmf10/wmf11 [14:18:25] so, I did cherry-pick and merged them. [14:18:44] While doing submodule udpate, found that submodule is already updated. [14:19:22] thcipriani: https://git.wikimedia.org/blobdiff/mediawiki%2Fcore/d458936e64d4ae9f770844ed1f0534e9231887a2/extensions%2FContentTranslation [14:19:34] and https://git.wikimedia.org/commitdiff/mediawiki%2Fcore/f47c800374727fdf789502b9ab1b4e094990c429 [14:19:50] So, have we started doing that automatically? [14:20:03] I can't see diff in extensions/ContentTranslation too. [14:20:28] Can you try doing updating submodule for ContentTranslation in wmf10/wmf11? We need that for today's SWAT. [14:20:35] That's the story :) [14:20:46] Already sent note to greg-g and twentyafterfour [14:20:48] that's very strange. [14:21:09] was the auto submodule bump correct in this case? [14:21:19] Yes. They're correct. [14:21:33] What I'm worried is auto bump [14:21:48] yeah, me too. [14:22:08] I saw in the scrollback you did a force merge for wmf10 [14:22:49] I'm not sure what difference that would make, but it's the only outlier to the usual process. [14:25:22] thcipriani: I did normal merge to wmf11 and it did same. [14:25:35] so, force merge isn't culprit here. [14:26:21] thcipriani: So, how can I get CX updated in wmf10/wmf11 today? :D [14:27:04] kart_: well if the submodule bump is on the branches, which it looks like it is, I can just fetch, update and push it out [14:27:41] any need for a full scap in the changes to the submodule? [14:29:39] thcipriani: changes are small, so fine with files. [14:30:12] thcipriani: I've added that in SWAT, so it is recorded too :) [14:30:26] ok, I'll just push that change out first with SWAT. [14:30:34] that is worrisome though [14:30:37] thcipriani: thanks! [14:31:01] thcipriani: yes. see what git log says there and scap. [14:31:12] cool. [14:31:16] thcipriani: if needed, I will mail to engg- [14:31:36] (There is no Release Engg list, right?) [14:33:23] there is, but I think it's internal, besides you hit pretty much everyone on it already :P [14:33:55] :) [14:38:07] Yippee, build fixed! [14:38:07] Project browsertests-MobileFrontend-SmokeTests-linux-chrome-sauce build #166: FIXED in 10 min: https://integration.wikimedia.org/ci/job/browsertests-MobileFrontend-SmokeTests-linux-chrome-sauce/166/ [15:02:40] 10Continuous-Integration-Infrastructure, 6Labs, 10Tool-Labs: Recover homedir of "ci" tool - https://phabricator.wikimedia.org/T103205#1396506 (10coren) 5Open>3Resolved Salvaged files are available in ~tools.ci/restore.tgz [15:13:13] !log removed /var/lib/puppet/state/agent_catalog_run.lock on integration-dev [15:13:16] Logged the message, Master [15:18:43] Project browsertests-CentralNotice-en.wikipedia.beta.wmflabs.org-os_x_10.9-chrome-sauce build #97: FAILURE in 43 sec: https://integration.wikimedia.org/ci/job/browsertests-CentralNotice-en.wikipedia.beta.wmflabs.org-os_x_10.9-chrome-sauce/97/ [15:35:11] !log integration-dev recovered! puppet hasn't run for ages but caught up with changes [15:35:13] Logged the message, Master [15:36:48] kart_: thcipriani: personally I think that the submodule bump _should_ be automatic. Why would you want to commit to a branch and not update the submodule pointer? Anyway I have no idea what triggers the automatic behavior, this has happened once before. [15:37:20] Holy mother of god. [15:37:26] How did that get turned on again? [15:37:48] ostriches: beats me [15:38:07] I suspect it's related to the .gitmodules file? [15:38:17] Yes [15:38:33] uno momento [15:38:43] I think make-wmf-branch has two different ways of calling git submodule add [15:38:54] https://phabricator.wikimedia.org/diffusion/MW/browse/wmf%252F1.26wmf11/.gitmodules [15:38:56] but anyway why is it a bad thing again? [15:39:02] Do. Not. Put. The. Branch. Identifier. [15:39:14] ostriches: you wrote the code ;) [15:39:24] I thought I unbroke this ages ago tho [15:39:26] or didn't you? [15:41:44] ostriches: https://phabricator.wikimedia.org/diffusion/MREL/browse/master/make-wmf-branch/MakeWmfBranch.php;dacb6c775588c9d6ed0ee3866d09417f34939414$204 [15:42:02] that '-b' argument is what does it [15:42:53] so I still don't understand why it's a bad thing though [15:43:16] (03PS2) 10Hashar: Update e-mail address for myself [integration/config] - 10https://gerrit.wikimedia.org/r/220345 (owner: 10Odder) [15:43:18] Because it's unexpected and the behavior is incredibly opaque. [15:43:27] I don't disagree it's the right design decision long term. [15:45:20] (03PS3) 10Hashar: Update e-mail address for myself [integration/config] - 10https://gerrit.wikimedia.org/r/220345 (owner: 10Odder) [15:45:38] (03CR) 10Hashar: [C: 032] "Had to update the other occurence of the email" [integration/config] - 10https://gerrit.wikimedia.org/r/220345 (owner: 10Odder) [15:48:05] twentyafterfour: problem is anyone can do accidental bump [15:48:13] and it can stay without deployed. [15:48:24] That's my understanding. Correct me. [15:48:31] That ^ [15:48:47] kart_: accidental? if you commit to a branch then you should always bump the submodule [15:48:52] otherwise just commit to master [15:48:55] (03Merged) 10jenkins-bot: Update e-mail address for myself [integration/config] - 10https://gerrit.wikimedia.org/r/220345 (owner: 10Odder) [15:49:01] Unless you aren't planning to deploy yet. [15:49:09] Plenty of times to go ahead and merge to a branch. [15:49:20] Anyway, like I said: if it was the explicit, documented process, that's fine. [15:49:23] It's not a bad thought. [15:49:31] ok. Lets document it? [15:49:41] But it's counter-intuitive to how we /currently/ do things and we get to repeat this conversation :) [15:49:59] I was scared because of no-documented-thing-happended. [15:50:09] not8 [15:50:12] not* [15:50:16] bad keyboard. [15:57:10] it's also not documented in make-wmf-branch and seems that something has recently changed the behavior [15:58:17] (03CR) 10Hashar: "That would do but shouldn't we fail when composer.json disappear? Once it has been introduced I am not sure there is a good reason to get" [integration/config] - 10https://gerrit.wikimedia.org/r/220405 (https://phabricator.wikimedia.org/T89263) (owner: 10Legoktm) [16:18:13] 10Beta-Cluster, 6Labs: Disable NFS home directories on deployment-prep - https://phabricator.wikimedia.org/T102169#1396856 (10yuvipanda) 5Open>3Resolved This is just the homedirs, and they are gone. [16:24:19] Quick RL deprecation question: if I want to deprecate a RL module, should I just (1) stop adding it to html (2) declare it but give it no resources (3) wait 'till the cache clears (4) then remove it completely? [16:39:45] (03CR) 10Hashar: "I think the dirs: parameter can be dropped, all extensions should have Gemfile at the root of their repo. Pretty sure Zeljko worked on tha" (031 comment) [integration/config] - 10https://gerrit.wikimedia.org/r/219513 (https://phabricator.wikimedia.org/T103039) (owner: 10Dduvall) [16:42:57] hashar|GIGN: i could use your help with the slave script part of that ^ [16:43:27] marxarelli: yeah that is all of a mess [16:43:32] gotta leave right now though sorry :-(( [16:43:48] hashar|GIGN: no problem [16:44:00] the slave scripts are deployed on labs instance via puppet git::clone() [16:44:03] that should work usually [16:44:20] but yeah reusing the bundle macro and passing it env needs the initialization: variable [16:44:22] not ideal [16:44:24] though [16:44:31] time to leave! [16:44:39] hashar|GIGN: yeah, i created a slave script already but it defines MEDIAWIKI_URL incorrectly [16:45:30] (03CR) 10Dduvall: Builder for running MW-Selenium integration tests (031 comment) [integration/config] - 10https://gerrit.wikimedia.org/r/219513 (https://phabricator.wikimedia.org/T103039) (owner: 10Dduvall) [17:10:51] 6Release-Engineering, 6Team-Practices: Organize "testing: where does it hurt?" workshop for the second week of July - https://phabricator.wikimedia.org/T102713#1397084 (10dduvall) >>! In T102713#1393586, @ggellerman wrote: > @dduvall QRs are nearing....should we schedule this week of June 29 (next week) or is... [17:11:54] (03PS1) 1020after4: Add a delete-stale-branch script. [tools/release] - 10https://gerrit.wikimedia.org/r/220500 [17:16:30] (03CR) 10Ori.livneh: [C: 032] Add a delete-stale-branch script. [tools/release] - 10https://gerrit.wikimedia.org/r/220500 (owner: 1020after4) [17:19:52] (03PS2) 1020after4: add deploy-promote script [tools/release] - 10https://gerrit.wikimedia.org/r/220292 [17:47:44] 6Release-Engineering, 10MediaWiki-Debug-Logger, 6Reading-Infrastructure-Team, 10Wikimedia-Logstash, 7HHVM: Log php fatals with full backtraces again (fatal.log on fluorine) - https://phabricator.wikimedia.org/T89169#1397230 (10Legoktm) Today I saw a stacktrace in fatal.log, (T103716#1397193), but looking... [18:06:45] 6Release-Engineering, 6Project-Creators, 6Team-Practices: Create a generic "Release" tag in Phabricator - https://phabricator.wikimedia.org/T99143#1397285 (10ggellerman) [18:07:37] 6Release-Engineering, 6Project-Creators, 6Team-Practices: Create a generic "Release" tag in Phabricator - https://phabricator.wikimedia.org/T99143#1286223 (10ggellerman) +RelEng Given the proposed use of the term "Release" adding RelEng so that they can wait in. [18:51:52] 6Release-Engineering, 6Project-Creators, 6Team-Practices: Create a generic "Release" tag in Phabricator - https://phabricator.wikimedia.org/T99143#1397463 (10mmodell) No objections from me. [18:55:05] 10Continuous-Integration-Infrastructure, 6Labs, 10Tool-Labs: Recover homedir of "ci" tool - https://phabricator.wikimedia.org/T103205#1397469 (10Legoktm) Thanks! [18:57:01] (03PS1) 10Dduvall: Set correct MW URLs for MW-Selenium [integration/jenkins] - 10https://gerrit.wikimedia.org/r/220547 [19:04:17] 10Beta-Cluster, 6Labs: Disable NFS home directories on deployment-prep - https://phabricator.wikimedia.org/T102169#1397489 (10hashar) 5Resolved>3Open Not yet. ``` hashar@deployment-salt:~$ sudo salt '*' cmd.run 'mount|grep /home' deployment-fluorine.deployment-prep.eqiad.wmflabs: deployment-sca02.deploymen... [19:05:59] !log fixing DNS / puppet and salt on i-000008d5.eqiad.wmflabs i-000002de.eqiad.wmflabs i-00000958.eqiad.wmflabs [19:06:02] salt for the win [19:06:04] Logged the message, Master [19:06:23] !log beta: salt 'i-00*' cmd.run "echo 'domain integration.eqiad.wmflabs\nsearch integration.eqiad.wmflabs eqiad.wmflabs\nnameserver 208.80.154.20\noptions timeout:5' > /etc/resolv.conf" [19:06:27] Logged the message, Master [19:08:36] 6Release-Engineering, 6Project-Creators, 6Team-Practices: Create a generic "Release" tag in Phabricator - https://phabricator.wikimedia.org/T99143#1397505 (10Aklapper) 5Open>3Resolved a:3Aklapper Thanks. Requested project #Release has been created: https://phabricator.wikimedia.org/project/profile/133... [19:10:22] 10Beta-Cluster: deployment-parsoid01-test fails puppet: Could not find class role::parsoid - https://phabricator.wikimedia.org/T103731#1397520 (10hashar) 3NEW [19:10:48] 10Beta-Cluster: deployment-parsoid01-test fails puppet: Could not find class role::parsoid - https://phabricator.wikimedia.org/T103731#1397527 (10hashar) @yuvipanda apparently you created that instance in February https://wikitech.wikimedia.org/w/index.php?title=Nova_Resource:Deployment-parsoid01-test.deployment... [19:20:52] (03CR) 10Legoktm: "See my comment at T89263#1395323." [integration/config] - 10https://gerrit.wikimedia.org/r/220405 (https://phabricator.wikimedia.org/T89263) (owner: 10Legoktm) [19:24:09] !log rebooting deployment-zookeeper to get rid of the /home NFS https://phabricator.wikimedia.org/T102169 [19:24:15] Logged the message, Master [19:24:40] 10Beta-Cluster: deployment-parsoid01-test fails puppet: Could not find class role::parsoid - https://phabricator.wikimedia.org/T103731#1397552 (10hashar) [19:24:43] 10Beta-Cluster, 6Labs: Disable NFS home directories on deployment-prep - https://phabricator.wikimedia.org/T102169#1397551 (10hashar) [19:28:35] 10Beta-Cluster: deployment-parsoid01-test fails puppet: Could not find class role::parsoid - https://phabricator.wikimedia.org/T103731#1397554 (10yuvipanda) nope - that was for testing https://gerrit.wikimedia.org/r/#/c/193082/ and since nobody seems to have the time for that it could be deleted. [19:28:42] !log fixing DNS puppet etc on deployment-cache-upload02 [19:28:47] Logged the message, Master [19:31:20] !log rebooting deployment-cache-upload02 [19:31:26] Logged the message, Master [19:31:37] 10Beta-Cluster, 6Labs: Disable NFS home directories on deployment-prep - https://phabricator.wikimedia.org/T102169#1397564 (10hashar) I have fixed DNS on the i-** instances. * deployment-cache-upload02 fixed up (dns/puppet/certs etc) * deployment-zookeeper01 no more has the /home NFS dir after a reboot * de... [19:46:37] 10Continuous-Integration-Infrastructure, 5Patch-For-Review: Create CI slaves using Debian Jessie (tracking) - https://phabricator.wikimedia.org/T94836#1397618 (10hashar) [19:46:40] 10Continuous-Integration-Infrastructure, 6operations, 7Blocked-on-Operations, 5Patch-For-Review: Build Debian package ruby-jsduck for Jessie - https://phabricator.wikimedia.org/T95008#1397616 (10hashar) 5Resolved>3Open Not yet :-( ``` integration-slave-jessie-1001# apt-get install ruby-jsduck Reading... [19:47:59] (03CR) 10Dduvall: "I could use some feedback on the correct values for `MEDIAWIKI_URL` and `MEDIAWIKI_API_URL`." (031 comment) [integration/jenkins] - 10https://gerrit.wikimedia.org/r/220547 (owner: 10Dduvall) [19:53:13] (03CR) 10Hashar: "https://integration.wikimedia.org/ci/job/mediawiki-core-qunit/ might have clues. See inline diff for some potentially useful details :-]" (031 comment) [integration/jenkins] - 10https://gerrit.wikimedia.org/r/220547 (owner: 10Dduvall) [19:53:20] marxarelli: https://gerrit.wikimedia.org/r/#/c/220547/1/bin/mw-set-env-mw-selenium.sh,unified :D [19:53:28] I am crashing to bed now [19:57:01] thanks, hashar. nighty night [19:57:59] (03PS2) 10Dduvall: Set correct MW URLs for MW-Selenium [integration/jenkins] - 10https://gerrit.wikimedia.org/r/220547 [19:59:46] hashar: out of curiosity, what timezone are you in? [20:00:18] (03CR) 10Dduvall: "Thanks, hashar. It appears that the Apache config for the qunit environment (which I'm building off of) is setup for short URLs at `/$BUIL" [integration/jenkins] - 10https://gerrit.wikimedia.org/r/220547 (owner: 10Dduvall) [20:01:28] polybuildr: it depends [20:01:41] polybuildr: more seriously I am in Europe UTC+2 currently [20:01:51] so it is 10pm / 22:00 right now [20:01:57] hashar: okay :P [20:05:15] polybuildr: usually work 9:30 - 6pm or so [20:05:24] then randomly connect between 9pm to 11pm [20:05:35] hashar: I see. okay :) [20:05:39] depends on mood, stuff I want to finish before heading bed etc [20:06:06] but dont worry. I also have 2 hours lunch some time or have a quick nap [20:06:33] haha :P okay. [20:06:48] that being said [20:06:51] sleep() !!! [20:06:58] keep up the good work on CodeSniffer :-] [20:07:25] (03CR) 10Krinkle: "Afaik the localhosts do not have short urls. They have their script path at /build_tag (not build_tag/w). There is no short url configured" [integration/jenkins] - 10https://gerrit.wikimedia.org/r/220547 (owner: 10Dduvall) [20:07:29] hashar: I'm taking a break from that. Got my GSoC project to finish. :P [20:20:15] 10Deployment-Systems, 7Wikimedia-log-errors: Cant unserialize( ) - https://phabricator.wikimedia.org/T103744#1397772 (10hashar) 3NEW [20:22:46] 6Release-Engineering, 6Project-Creators, 6Team-Practices: Create a generic "Release" tag in Phabricator - https://phabricator.wikimedia.org/T99143#1397784 (10Aklapper) [20:30:18] 6Release-Engineering, 10MediaWiki-File-management, 10MediaWiki-Tarball-Backports, 6Multimedia, and 6 others: InstantCommons broken by switch to HTTPS - https://phabricator.wikimedia.org/T102566#1397806 (10Nemo_bis) 1.6.12 was in 2009, not that long ago. ;) [20:32:33] 6Release-Engineering, 6Project-Creators, 6Team-Practices: Create a generic "Release" tag in Phabricator - https://phabricator.wikimedia.org/T99143#1397812 (10greg) Heh, yeah, no objections from me, either thankfully :) [21:07:03] 10Beta-Cluster, 7Varnish: deployment-parsoidcache02 fails puppet: Role::Cache::Statsd/Varnish::Logging::Statsd[default]/Base::Service_unit[varnishstatsd-default]/Service[varnishstatsd-default]: Could not evaluate: Could not find init script or upstart conf file... - https://phabricator.wikimedia.org/T103660#1397903 [21:14:06] 6Release-Engineering, 10MediaWiki-File-management, 10MediaWiki-Tarball-Backports, 6Multimedia, and 6 others: InstantCommons broken by switch to HTTPS - https://phabricator.wikimedia.org/T102566#1397936 (10demon) That's 6 years ago, yeah pretty long. Also, it never supported InstantCommons, so who cares ab... [21:15:22] (03PS1) 10Dduvall: Initialize browser when using `PageFactory#on` first [selenium] - 10https://gerrit.wikimedia.org/r/220625 (https://phabricator.wikimedia.org/T103746) [21:29:58] (03CR) 10Dduvall: "> The environment value set here seems rather odd ("scriptpath/wiki"). Why would the selenium tests need that? It seems like all it needs " [integration/jenkins] - 10https://gerrit.wikimedia.org/r/220547 (owner: 10Dduvall) [21:32:19] (03CR) 10Krinkle: "The rewrite part of that config applies to directories mounted by browser tests with a canonical name and contain /w/ within and rewritten" [integration/jenkins] - 10https://gerrit.wikimedia.org/r/220547 (owner: 10Dduvall) [21:34:37] Krinkle: right, but wouldn't localhost:x/tag/wiki/Foo be written as localhost:x/tag/w/index.php? [21:36:26] marxarelli: which doesnt' exist [21:36:43] in other words, the right config might be wiki_url=http://localhost:x/tag/wiki and api_url=http://localhost:x/tag/w/api.php [21:36:47] tag is the script directory not tag/w [21:36:50] oh :) [21:37:19] right, ok. i get it now [21:37:22] url=server/tag/index.php api=server/tag/api.php [21:37:37] thanks to php-pathinfo, it shoudl work fine to do slash titles on that [21:37:40] e.g. index.php/Foo [21:37:43] Is supported [21:37:45] oh sweet, ok [21:37:54] that's the part i wasn't getting [21:37:59] if that is not enabled, we can enable it. [21:38:06] well, there were other parts ... :) [21:38:21] But again, the selenium tests shouldn't use {prefix}/title but {script}?title=title [21:38:23] eventually [21:38:34] yeah, i agree there [21:38:38] or take MW_ARTICLE_PATH [21:39:07] mw has a configurable wgArticlePath which defaults to '/w/index.php?title=$1' and can be set to 'index.php/$1' or '/wiki/$1' [21:39:15] now that we have a proper url qualifier in mw-selenium, that wouldn't be hard to implement [21:40:33] but requring users to export three env variables is annoying. especially since all info can be derived from the api. Its more conventional to either only take the api-url (and fetch action=siteinfo for any shorturl config that is available), or only take only script-path and use query parameters (which works on all installs, regardless of short url) [21:40:35] Krinkle: got it. i can probably add that to the mw-selenium builder [21:41:38] that would be ideal. i.e. MEDIAWIKI_URL being the only configuration you need [21:41:51] especially since we have a user factory for account fixtures in mw-selenium now [21:42:15] or API_URL rather [21:42:50] i tried to reduce the amount of env variable setting w/ mw-selenium 1.x but i'm not sure i did it in the best way [22:25:16] 10Beta-Cluster, 6Labs: Completely remove Beta Cluster dependency on NFS - https://phabricator.wikimedia.org/T102953#1398133 (10greg) [22:25:41] 10Beta-Cluster: Setup a Swift cluster to match production - https://phabricator.wikimedia.org/T64835#1398136 (10greg) [22:25:44] 10Beta-Cluster, 6Labs: Completely remove Beta Cluster dependency on NFS - https://phabricator.wikimedia.org/T102953#1378487 (10greg) [22:26:08] 10Beta-Cluster, 10MediaWiki-File-management, 6Multimedia: Thumbnail generation should happen via the same setup in the beta cluster and in production (tracking) - https://phabricator.wikimedia.org/T84950#1398138 (10greg) [22:26:11] 10Beta-Cluster, 6Labs: Completely remove Beta Cluster dependency on NFS - https://phabricator.wikimedia.org/T102953#1378487 (10greg) [22:26:45] 10Beta-Cluster, 6Labs: Disable NFS home directories on deployment-prep - https://phabricator.wikimedia.org/T102169#1398147 (10greg) [22:26:47] 10Beta-Cluster, 6Labs: Completely remove Beta Cluster dependency on NFS - https://phabricator.wikimedia.org/T102953#1378487 (10greg) [22:45:44] 10Deployment-Systems, 6operations, 7HHVM, 5Patch-For-Review, 15User-Bd808-Test: Scap should restart HHVM - https://phabricator.wikimedia.org/T103008#1398221 (10bd808) @ori did some additional operational testing up to and including using `--restart` across the entire WMF prod cluster. The restart functio... [22:51:36] 6Release-Engineering, 6Team-Practices: Organize "testing: where does it hurt?" workshop for the end of July - https://phabricator.wikimedia.org/T102713#1398242 (10ggellerman) [23:05:00] (03CR) 10Jdlrobson: "No longer needed?" [integration/config] - 10https://gerrit.wikimedia.org/r/191046 (https://phabricator.wikimedia.org/T74794) (owner: 10Hashar) [23:17:48] (03PS3) 10Dduvall: Set correct MW URLs for MW-Selenium [integration/jenkins] - 10https://gerrit.wikimedia.org/r/220547 (https://phabricator.wikimedia.org/T103039) [23:32:56] (03CR) 10Dduvall: [C: 032] "Tested this build https://integration.wikimedia.org/ci/job/mediawiki-selenium-integration/6/" [integration/jenkins] - 10https://gerrit.wikimedia.org/r/220547 (https://phabricator.wikimedia.org/T103039) (owner: 10Dduvall) [23:33:27] (03Merged) 10jenkins-bot: Set correct MW URLs for MW-Selenium [integration/jenkins] - 10https://gerrit.wikimedia.org/r/220547 (https://phabricator.wikimedia.org/T103039) (owner: 10Dduvall) [23:34:09] (03PS6) 10Dduvall: Builder for running MW-Selenium integration tests [integration/config] - 10https://gerrit.wikimedia.org/r/219513 (https://phabricator.wikimedia.org/T103039) [23:42:23] 10Browser-Tests: Use the API URL as a single entry point and infer the rest by querying siteinfo - https://phabricator.wikimedia.org/T103763#1398496 (10dduvall) 3NEW [23:47:00] marxarelli: Just curious but, why could we merge these two? [23:47:20] e.g. there's very little about qunit-localhost specific to qunit. In fact, nothing, other than the subdirectory name (localhost/qunit) [23:47:47] and that apache server supports serving as many different concurrent builds as we want. They don't clobber one another [23:47:57] which vhost does it use? [23:48:12] I assume a differnet one since it's in a different /mnt directory [23:48:32] Hm.. /mnt instead of /srv/ [23:48:41] Krinkle: it was using the qunit vhost actually [23:49:08] but i changed it after i noticed there was another vhost for browser tests on a different port [23:49:09] that means it will break on hosts without extra storage. It's only a symlink in /srv/. seems lightweight [23:49:29] it's still just a symlink [23:49:39] but yeah, this could all be simplified i think [23:49:43] to use the same vhost, etc. [23:49:50] Yeah, hence it's on /srv and points to wherever (/mnt if that's what Jenkins uses) [23:50:01] marxarelli: OK. So this is re-using the existing vhost or browser tests? [23:50:10] which uses /mnt/localhost-browsertests I guess? [23:50:27] right. i'm not sure that was being used at all until now [23:50:41] i just happened to see it when scanning through the puppet config [23:50:47] O [23:50:48] OK [23:50:52] so i decided to recommission it for this project [23:50:59] I'll rename localhost/qunit to something generic and then you can take it from there [23:51:08] yeah, makes sense [23:51:12] that sounds good [23:51:56] Krinkle: there's also a /srv/localhost/mediawiki [23:52:08] i'm not sure if that's setup differently or not, but it seems to use the same vhost [23:52:12] vhost config i mean [23:53:01] which seems quite generic already :) [23:53:25] marxarelli: I know that at least localhost/qunit is widely used, works on precise/trusty, and is puppetised for labs and prod slaves. [23:53:27] i didn't see which builders in jjb used it though [23:53:39] The other two have not been used much and I'm unsure to what degree they are puppetised and documented. [23:54:50] Krinkle: looks to be defined in role::ci::slave::labs [23:55:16] but yeah, if you think renaming the qunit vhost is a better idea, that works for me [23:58:12] 10Continuous-Integration-Infrastructure: Generalise localhost/qunit infrastructure - https://phabricator.wikimedia.org/T103766#1398564 (10Krinkle) 3NEW a:3Krinkle [23:58:28] (03PS1) 10Krinkle: Rename mw-set-env-qunit to mw-set-env-localhost [integration/jenkins] - 10https://gerrit.wikimedia.org/r/220655 (https://phabricator.wikimedia.org/T103766)