[00:57:12] greg-g, I've started trying to make site-requests better organised [00:57:31] earlier I renamed it to mediawiki-config but now I'm not sure, because it actually includes maintenance scripts and things [00:58:22] it's more like "tasks requiring deployers", but for generic things like operations/mediawiki-config or maintenance scripts... [00:59:51] aude, Shanmugamp7, Nemo_bis, revi, Glaisher ^ [01:01:05] It's not for updating actual MW code like backporting commits [01:01:24] maybe maintenance scripts should be split out of it [01:35:30] 6Release-Engineering, 10Gather, 10MobileFrontend, 10Reading Web Planning, and 2 others: [EPIC] Encourage developers to increase code coverage - https://phabricator.wikimedia.org/T100294#1530285 (10Jdlrobson) [01:35:45] 6Release-Engineering, 10Gather, 10MobileFrontend, 10Reading Web Planning, and 2 others: [EPIC] Encourage developers to increase code coverage - https://phabricator.wikimedia.org/T100294#1309866 (10Jdlrobson) [01:35:58] 6Release-Engineering, 10Gather, 10MobileFrontend, 10Reading Web Planning, and 2 others: [EPIC] Encourage developers to increase code coverage - https://phabricator.wikimedia.org/T100294#1309866 (10Jdlrobson) [01:57:49] 10Beta-Cluster, 6Collaboration-Team-Backlog, 7Blocked-on-Operations, 5Patch-For-Review: Decide what to do with ee_prototypewiki in beta - https://phabricator.wikimedia.org/T107397#1530342 (10Dzahn) Daniel Zahn: there is still an entire wiki here, doesn't that need more shutdown steps first if it is to be k... [03:37:47] 10Beta-Cluster, 6Collaboration-Team-Backlog, 7Blocked-on-Operations, 5Patch-For-Review: Decide what to do with ee_prototypewiki in beta - https://phabricator.wikimedia.org/T107397#1530466 (10Krenair) 5Open>3Resolved ```mysql> DELETE FROM localnames WHERE ln_wiki='ee_prototypewiki'; Query OK, 2998 rows... [03:38:33] 10Beta-Cluster, 6Collaboration-Team-Backlog, 7Blocked-on-Operations, 5Patch-For-Review: Decide what to do with ee_prototypewiki in beta - https://phabricator.wikimedia.org/T107397#1530468 (10Krenair) Like the production wikis in deleted.dblist, the database for this site remains intact but of course is ina... [04:20:35] deployer_request? [04:24:37] revi, the maintenance script stuff can be done by people in the restricted group [04:25:12] then split it with maintenance_script_request and keep the site_request as is seems best for me [04:25:46] I haven't been around for few months so not sure [04:34:39] revi, if we split that we can probably just keep this called mediawiki-config [04:35:16] hmm, let me clarify ; you changed project name to mediawiki-config and want to split maint-script-req from mediawiki-config? [04:35:39] yes [04:35:59] maybe I shouldn't have renamed it :/ [04:37:13] well, then I think it makes sense [04:37:26] since maint-script-req is not mediawiki-config [04:37:42] is not in scope of* [05:04:19] 6Release-Engineering, 10Continuous-Integration-Config, 3Mobile-App-Sprint-63-Android-Europium, 5Patch-For-Review, 3Wikipedia-Android-App: Create jenkins slave instance dedicated to Android runs - https://phabricator.wikimedia.org/T107336#1530545 (10Niedzielski) @thcipriani / @greg any guidance on my last... [06:23:17] 6Release-Engineering, 6Commons, 10MediaWiki-File-management, 10MediaWiki-Tarball-Backports, and 7 others: InstantCommons broken by switch to HTTPS - https://phabricator.wikimedia.org/T102566#1530704 (10Tau) I saved [[ https://raw.githubusercontent.com/wikimedia/mediawiki/f3d821de4e1f79b4c4b73e44b38d1c19830... [09:41:57] Project browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-os_x_10.9-safari-sauce build #689: FAILURE in 1 hr 31 min: https://integration.wikimedia.org/ci/job/browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-os_x_10.9-safari-sauce/689/ [10:05:16] Krenair: what, you renamed the project *before* figuring out what to do with maintenance scripts? I suggest reverting [10:05:50] (Also, the proper channel for site requests discussions is #wikimedia-tech.) [12:21:10] Krenair: I think I actually liked site requests more [12:21:52] wikimedia-mediawiki has a nice ring to it though :P [12:23:44] Nemo_bis, yeah, I've reverted it [12:37:55] ok, thanks [12:54:40] Project browsertests-GettingStarted-en.wikipedia.beta.wmflabs.org-linux-firefox-sauce build #562: FAILURE in 39 sec: https://integration.wikimedia.org/ci/job/browsertests-GettingStarted-en.wikipedia.beta.wmflabs.org-linux-firefox-sauce/562/ [13:45:20] (03CR) 10Phuedx: "Anything stopping this from being merged now?" [integration/config] - 10https://gerrit.wikimedia.org/r/229612 (https://phabricator.wikimedia.org/T107582) (owner: 10Robmoen) [13:55:26] 6Release-Engineering, 10MediaWiki-Tarball-Backports, 7Security-Extensions: Backport security fixes to stable + LTS extension branches - https://phabricator.wikimedia.org/T108734#1531582 (10Aklapper) [14:05:49] (03CR) 10Paladox: "Hi yes this should be using the npm test and move jshint and jsonlint to the check:" [integration/config] - 10https://gerrit.wikimedia.org/r/229612 (https://phabricator.wikimedia.org/T107582) (owner: 10Robmoen) [14:07:48] (03CR) 10Paladox: "It should look like" [integration/config] - 10https://gerrit.wikimedia.org/r/229612 (https://phabricator.wikimedia.org/T107582) (owner: 10Robmoen) [14:42:34] Krenair: maint scripts could be, sure? [14:43:41] Krenair: nvm me, just finished reading backscroll :) [15:06:54] 6Release-Engineering, 6Team-Practices, 7Testing Initiative 2015: Talk to Greg and Arthur about Onboarding's role in establishing good testing practices/habits - https://phabricator.wikimedia.org/T108121#1531786 (10ALantz) @Awjrichards Thanks for the mention. Please let me know where I can help. [15:13:01] Project beta-code-update-eqiad build #67931: FAILURE in 39 ms: https://integration.wikimedia.org/ci/job/beta-code-update-eqiad/67931/ [15:17:58] ^ looks like part of labvirt1001 reboot [15:18:27] yep, that’s me. beta nodes were pretty close to the top of the list, they should be back up shortly [15:18:42] and I think CI nodes are up already [15:18:54] Project browsertests-CentralNotice-en.wikipedia.beta.wmflabs.org-os_x_10.9-chrome-sauce build #146: FAILURE in 53 sec: https://integration.wikimedia.org/ci/job/browsertests-CentralNotice-en.wikipedia.beta.wmflabs.org-os_x_10.9-chrome-sauce/146/ [15:20:01] Project beta-update-databases-eqiad build #2147: FAILURE in 21 ms: https://integration.wikimedia.org/ci/job/beta-update-databases-eqiad/2147/ [15:24:35] Yippee, build fixed! [15:24:35] Project beta-code-update-eqiad build #67932: FIXED in 1 min 34 sec: https://integration.wikimedia.org/ci/job/beta-code-update-eqiad/67932/ [15:41:29] (03CR) 10Cscott: "Ah. Is there anyone else who likes to keep an eye on Jenkins stuff? (I'm guessing not, since no one else has piped in on this review for" [integration/config] - 10https://gerrit.wikimedia.org/r/229558 (owner: 10Cscott) [15:42:45] (03CR) 10Greg Grossmeier: "I just added Tyler and Dan to the review." [integration/config] - 10https://gerrit.wikimedia.org/r/229558 (owner: 10Cscott) [15:43:19] (03CR) 10Greg Grossmeier: "Also, Gerrit has "groups". I just added the "integration" group as well." [integration/config] - 10https://gerrit.wikimedia.org/r/229558 (owner: 10Cscott) [16:15:57] 10Deployment-Systems: make-release should use mediawiki/vendor instead of running composer - https://phabricator.wikimedia.org/T108634#1531927 (10mmodell) p:5Triage>3Normal [16:17:32] 6Release-Engineering: Create KPIs for #releng-201516-Q2 - https://phabricator.wikimedia.org/T107905#1531929 (10greg) [16:20:53] Yippee, build fixed! [16:20:53] Project beta-update-databases-eqiad build #2148: FIXED in 50 sec: https://integration.wikimedia.org/ci/job/beta-update-databases-eqiad/2148/ [16:21:26] yippee [16:23:06] 10Deployment-Systems, 5Patch-For-Review, 7Security-Other: By default, have /usr/local/bin/sql use a read-only account when connecting to mysql - https://phabricator.wikimedia.org/T105046#1531960 (10thcipriani) p:5Triage>3Normal [16:24:28] 10Deployment-Systems, 6Release-Engineering, 10RESTBase, 6Services, 3releng-201516-q1: Create or improve the RESTBase deploy method (tracking) - https://phabricator.wikimedia.org/T102667#1531970 (10mmodell) [16:24:32] 10Deployment-Systems, 6Release-Engineering, 10RESTBase, 6Services, 6operations: Get ops feedback regarding the use of SSH for deployment system control channel. - https://phabricator.wikimedia.org/T102687#1531968 (10mmodell) 5Open>3Resolved a:3mmodell [16:25:48] 10Deployment-Systems, 6operations: Unhashable type: dict error when running salt --batch-size - https://phabricator.wikimedia.org/T99776#1531974 (10thcipriani) 5Open>3Resolved Haven't heard any reports of this error—if that's incorrect, please re-open. [16:40:36] (03PS1) 10Kaldari: Adding WikidataPageBanner [tools/release] - 10https://gerrit.wikimedia.org/r/231046 [16:43:09] (03PS7) 10Robmoen: Add QuickSurveys ext [integration/config] - 10https://gerrit.wikimedia.org/r/229612 (https://phabricator.wikimedia.org/T107582) [16:50:12] !log Fixed puppet merge conflict [16:50:15] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL, Master [16:54:42] (03PS2) 10Dduvall: Run mwext-mw-selenium on Gather experimental pipeline [integration/config] - 10https://gerrit.wikimedia.org/r/229043 [17:01:42] greg-g: kaldari ran out of time for deployment today [17:02:16] jdlrobson: for the record, you have another hour before the next thing (train at 11am) [17:15:13] greg-g: i lost a kaldari though [17:15:17] i think he had to go somewhere :( [17:15:32] still here [17:15:39] cleaning things up now [17:19:07] jdlrobson: I have to roll-back the submodule addition on master [17:19:27] kaldari: can we still do this then given we have 40 mins left? :) [17:19:36] or do you have places to be? [17:19:43] no, I have places to be sadly [17:20:11] have to go to scrum of scrums in 10 minutes and then Engineering managers meeting :( [17:26:01] greg-g: actually I think I need your advice here. I merged the submodule addition for wmf17, but wasn't able to deploy it. I assume that I need to now remove the submodule from that branch, correct? Removing a submodule seems to be a bit more complicated than adding a submodule (judging by the extremely confusing discussion at [17:26:01] http://stackoverflow.com/questions/1260748/how-do-i-remove-a-git-submodule). Do you have a recommended way of handling it? [17:30:29] heh, fun :) [17:30:34] twentyafterfour: ^^ advice needed :) [17:30:51] ... [17:30:57] kaldari: did you add it to wmf18 as well? or just wmf17? [17:30:58] The important bit is removing it from .gitmodules. [17:31:03] Local clones need cleanup after. [17:31:12] But removing from .gitmodules prevents it from being re-added. [17:31:15] greg-g: just wmf17 [17:31:21] kk [17:31:43] Oh yeah, and `git rm` the path you added. [17:32:01] `git rm` the path, update .gitmodules, commit to gerrit. [17:32:22] (in one commit, otherwise you're in a screwy state of uncommitted directories and shiz) [17:33:11] Have I mentioned that git submodules are an atrociously designed concept and were never meant for more than like 1 or 2 submodules per repo? [17:33:15] [17:37:18] (03CR) 10Paladox: [C: 031] "Thanks +1 now." [integration/config] - 10https://gerrit.wikimedia.org/r/229612 (https://phabricator.wikimedia.org/T107582) (owner: 10Robmoen) [17:40:14] anything I can do? I think ostriches covered it pretty well [17:42:16] also the top answer on that stackoverflow question is pretty much the right thing to do [17:42:29] except the renaming seems unnecessary [17:49:45] ostriches: thanks! [17:53:41] ostriches: Does this look right: https://gerrit.wikimedia.org/r/#/c/231063/ [17:57:34] yerp [18:47:16] (03PS3) 10Legoktm: Make Flow depend on GuidedTour and add it to the shared extension job [integration/config] - 10https://gerrit.wikimedia.org/r/230942 (owner: 10Catrope) [18:49:02] legoktm: glow depends on guidedtour? [18:49:05] er, flow [18:50:11] greg-g: https://gerrit.wikimedia.org/r/#/c/230924/, I'm not sure if it's going to be a hard dependency or not [18:50:55] interesting [18:58:03] !log Applied https://gerrit.wikimedia.org/r/#/c/231049/ via cherry-pick [18:58:08] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL, Master [19:02:20] (03CR) 10Legoktm: [C: 032] "Deployed" [integration/config] - 10https://gerrit.wikimedia.org/r/230942 (owner: 10Catrope) [19:04:23] (03Merged) 10jenkins-bot: Make Flow depend on GuidedTour and add it to the shared extension job [integration/config] - 10https://gerrit.wikimedia.org/r/230942 (owner: 10Catrope) [19:39:22] 6Release-Engineering, 6Team-Practices, 5Testing Initiative 2015: Follow up workshop & brown bag ideas from Testing: Where does it hurt? - https://phabricator.wikimedia.org/T108122#1532434 (10Awjrichards) p:5Triage>3Normal [19:40:39] 6Release-Engineering, 6Team-Practices, 5Testing Initiative 2015: Talk to Greg and Arthur about Onboarding's role in establishing good testing practices/habits - https://phabricator.wikimedia.org/T108121#1532448 (10Awjrichards) p:5Triage>3Normal [20:02:36] 6Release-Engineering, 10Gitblit-Deprecate: Update mediawiki.org templates to link to Diffusion, not gitblit - https://phabricator.wikimedia.org/T108864#1532501 (10Spage) 3NEW [20:42:01] (03CR) 10Jdlrobson: [C: 031] Run mwext-mw-selenium on Gather experimental pipeline [integration/config] - 10https://gerrit.wikimedia.org/r/229043 (owner: 10Dduvall) [20:42:09] (03CR) 10Jdlrobson: "merge if you can! Thanks Dan :D" [integration/config] - 10https://gerrit.wikimedia.org/r/229043 (owner: 10Dduvall) [20:44:42] (03CR) 10Dduvall: [C: 032] Run mwext-mw-selenium on Gather experimental pipeline [integration/config] - 10https://gerrit.wikimedia.org/r/229043 (owner: 10Dduvall) [20:46:06] !log restarted restbase on deployment-restbase01 (dead) [20:46:11] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL, Master [20:51:21] (03PS3) 10Dduvall: Run mwext-mw-selenium on Gather experimental pipeline [integration/config] - 10https://gerrit.wikimedia.org/r/229043 [20:53:24] (03CR) 10Dduvall: [C: 032] Run mwext-mw-selenium on Gather experimental pipeline [integration/config] - 10https://gerrit.wikimedia.org/r/229043 (owner: 10Dduvall) [20:55:06] (03Merged) 10jenkins-bot: Run mwext-mw-selenium on Gather experimental pipeline [integration/config] - 10https://gerrit.wikimedia.org/r/229043 (owner: 10Dduvall) [21:01:15] !log Reloading Zuul to deploy I11bcac5b35a8f36cf3eb43caf7b792de6105a501 and I4bec54d445cb41cba3d6f5d9bd74ffe823b2c7ad [21:01:21] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL, Master [21:05:26] 6Release-Engineering, 5Testing Initiative 2015: Create QA Health scoreboard - https://phabricator.wikimedia.org/T108768#1532684 (10ggellerman) [21:07:06] 6Release-Engineering, 5Testing Initiative 2015: Create QA Health scoreboard - https://phabricator.wikimedia.org/T108768#1532689 (10dduvall) [21:10:10] 6Release-Engineering, 10Continuous-Integration-Config, 3Mobile-App-Sprint-63-Android-Europium, 5Patch-For-Review, 3Wikipedia-Android-App: Create jenkins slave instance dedicated to Android runs - https://phabricator.wikimedia.org/T107336#1532694 (10thcipriani) >>! In T107336#1519054, @Niedzielski wrote:... [21:11:01] 10Browser-Tests, 5Testing Initiative 2015: Run Selenium tests in parallel - https://phabricator.wikimedia.org/T57867#1532698 (10dduvall) [21:13:34] 10Browser-Tests, 5Testing Initiative 2015: Run Selenium tests in parallel - https://phabricator.wikimedia.org/T57867#1532702 (10dduvall) This was discussed in our Testing: Where does it hurt? discussion. https://etherpad.wikimedia.org/p/testing-where-does-it-hurt [21:15:08] 10Browser-Tests, 10MediaWiki-Vagrant, 5Patch-For-Review, 5Testing Initiative 2015: Vagrant command for running browser tests - https://phabricator.wikimedia.org/T96283#1532704 (10dduvall) [21:18:36] 10Browser-Tests: Add documentation for release process of MW-Selenium - https://phabricator.wikimedia.org/T108873#1532722 (10dduvall) 3NEW [21:18:49] 10Browser-Tests, 5Testing Initiative 2015: Add documentation for release process of MW-Selenium - https://phabricator.wikimedia.org/T108873#1532731 (10dduvall) [21:21:43] 10Browser-Tests, 5Testing Initiative 2015: Experiment with browser testing in other languages - https://phabricator.wikimedia.org/T108874#1532746 (10dduvall) [21:22:38] 10Continuous-Integration-Infrastructure, 5Testing Initiative 2015: Jenkins: Set up perceptual diffs (visual regression testing) - https://phabricator.wikimedia.org/T64633#1532748 (10dduvall) [21:23:46] 10Browser-Tests, 5Testing Initiative 2015: Experiment with browser testing in other software languages - https://phabricator.wikimedia.org/T108874#1532749 (10Jdforrester-WMF) [21:24:03] 10Browser-Tests, 5Testing Initiative 2015: Experiment with browser testing in other software languages - https://phabricator.wikimedia.org/T108874#1532739 (10Jdforrester-WMF) Tweaked the title as we already do awesome testing in other //human// languages. [21:30:43] 10Browser-Tests, 5Patch-For-Review, 5Testing Initiative 2015: [Spike] Decouple MW-Selenium from Cucumber - https://phabricator.wikimedia.org/T108273#1532791 (10dduvall) [21:31:33] 10Browser-Tests, 5Patch-For-Review, 5Testing Initiative 2015: [Spike] Decouple MW-Selenium from Cucumber - https://phabricator.wikimedia.org/T108273#1516828 (10dduvall) Added this task to Testing Initiative 2015. It isn't quite "using another language" for browser testing, but it does constitute a different... [22:06:06] greg-g: I have a patch to turn off authz for beta cluster's kibana interface. Seems like you should +1 it before I cherry-pick -- https://gerrit.wikimedia.org/r/#/c/231179/ [22:14:58] {{done}} [22:15:16] * greg-g just caught up on the office location thread. good times [22:16:14] !log Cherry-picked https://gerrit.wikimedia.org/r/#/c/231179/ (Disable authentication for Kibana) [22:16:20] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL, Master [22:17:59] greg-g: Let's move the office to a boat 12 nautical miles off the Bay shore! [22:18:56] If you are going to move, move to PDX. Much shorter flight time for me to visit [22:19:15] James_F: I hear there are some VC duders who are trying that, no? [22:19:19] also I might be able to convince my wife to move there someday [22:20:12] lol. this error message is brain hurtingly bad: "Fatal error: Redis::publish requires at least 2 parameters 2 given in /srv/mediawiki/php-master/includes/clientpool/RedisConnectionPool.php on line 483" [22:20:27] so 2 is not "at least 2"? [22:20:43] nice [22:20:49] maybe the 2 is a literal `2`? [22:21:33] "you only gave me a 2. i'll be needing another. kthxbye" [22:21:58] * bd808 digs in hhvm source tree [22:23:04] the second 2, yeah [22:23:11] that'd make sense, but is horrible [22:23:28] greg-g: I assume they (ho, ho) sank beneath the waves of reason. [22:24:16] hopefully [22:24:27] figuratively, yeah, figuratively [22:25:32] so .. "Redis::$fname requires at least $flen parameters $argc given" [22:25:48] those are both numeric counts of args then in the message [22:25:58] huh. [22:26:27] https://github.com/facebook/hhvm/blob/a84eda43a3cd7f28ff5dce26f13b316e6d9c4e7b/hphp/system/php/redis/Redis.php#L1556 [22:30:08] also TIL that some crazy hhvm contributor uses the `and` logical operator in production code [22:32:05] bd808: seems pretty messed up. `$func` is a reference to `self::$map['publish']`, and it tests `$func['defaults']` [22:32:22] which isn't defined anywhere [22:32:53] line 1550 seems to be the key there [22:33:16] eg the block that throws the error shoudl never ever be run [22:33:56] oh, that's true [22:34:02] because you've given it 2 arguments [22:34:27] it's all buried in __call magic... [22:35:04] somehow $args is a thing wit count() === 2 but no [1] I guess [22:35:39] and trigger_error() means no stacktrace :/ [22:36:00] which is something I really should figure out how to fix and/or file upstream [22:37:46] heh. the line in our code that it is called from is __call() magic too [22:37:54] * bd808 moved on with his life [22:39:28] invoked with `call_user_func_array` i hope :P [22:40:33] maybe with some unserialized ambiguous array value from a mysql column [22:40:41] meeeeeemories [22:58:04] Project browsertests-Gather-en.m.wikipedia.beta.wmflabs.org-linux-chrome-sauce build #228: FAILURE in 1 min 3 sec: https://integration.wikimedia.org/ci/job/browsertests-Gather-en.m.wikipedia.beta.wmflabs.org-linux-chrome-sauce/228/ [23:00:46] Project browsertests-CentralNotice-en.wikipedia.beta.wmflabs.org-windows_7-firefox-sauce build #141: FAILURE in 1 min 45 sec: https://integration.wikimedia.org/ci/job/browsertests-CentralNotice-en.wikipedia.beta.wmflabs.org-windows_7-firefox-sauce/141/ [23:58:38] (03CR) 10Jdlrobson: [C: 031] "Can someone merge?" [integration/config] - 10https://gerrit.wikimedia.org/r/229612 (https://phabricator.wikimedia.org/T107582) (owner: 10Robmoen)