[02:25:48] <grrrit-wm>	 (03CR) 10Legoktm: [C: 032] Whitelist kumariankita002 at gmail.com [integration/config] - 10https://gerrit.wikimedia.org/r/231902 (https://phabricator.wikimedia.org/T109057) (owner: 10Amire80)
[02:27:22] <grrrit-wm>	 (03Merged) 10jenkins-bot: Whitelist kumariankita002 at gmail.com [integration/config] - 10https://gerrit.wikimedia.org/r/231902 (https://phabricator.wikimedia.org/T109057) (owner: 10Amire80)
[02:28:06] <legoktm>	 !log deploying https://gerrit.wikimedia.org/r/231902
[05:36:19] <wmf-insecte>	 Yippee, build fixed!
[05:36:20] <wmf-insecte>	 Project browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-windows_7-internet_explorer-11-sauce build #513: FIXED in 34 min: https://integration.wikimedia.org/ci/job/browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-windows_7-internet_explorer-11-sauce/513/
[06:27:38] <wmf-insecte>	 Project browsertests-Core-en.wikipedia.beta.wmflabs.org-linux-firefox-sauce build #714: FAILURE in 8 min 37 sec: https://integration.wikimedia.org/ci/job/browsertests-Core-en.wikipedia.beta.wmflabs.org-linux-firefox-sauce/714/
[09:44:11] <wmf-insecte>	 Project browsertests-Echo-en.wikipedia.beta.wmflabs.org-linux-chrome-sauce build #582: FAILURE in 7 min 10 sec: https://integration.wikimedia.org/ci/job/browsertests-Echo-en.wikipedia.beta.wmflabs.org-linux-chrome-sauce/582/
[10:55:42] <grrrit-wm>	 (03CR) 10Zfilipin: [C: 032] Expose client cookies [ruby/api] - 10https://gerrit.wikimedia.org/r/226949 (owner: 10Dduvall)
[10:56:02] <grrrit-wm>	 (03Merged) 10jenkins-bot: Expose client cookies [ruby/api] - 10https://gerrit.wikimedia.org/r/226949 (owner: 10Dduvall)
[11:18:26] <wikibugs>	 6Release-Engineering, 10Staging, 10Reading Web Planning, 7Epic: [EPIC] Create a development staging environment and branch. - https://phabricator.wikimedia.org/T104324#1544491 (10Jhernandez)
[14:58:51] <grrrit-wm>	 (03PS7) 10Thcipriani: Add service deploy via scap [tools/scap] - 10https://gerrit.wikimedia.org/r/224374 
[15:34:44] <wikibugs>	 10Continuous-Integration-Infrastructure, 10Wikidata, 7Composer: create mirror for our composer dependencies - https://phabricator.wikimedia.org/T106548#1545685 (10JanZerebecki)
[15:37:28] <Krenair>	 FlorianSW, ostriches: was https://gerrit.wikimedia.org/r/#/c/232051/ just something you guys missed?
[15:37:34] <Krenair>	 or will that commit break everything?
[15:38:55] <FlorianSW>	 Krenair: I suspect I missed that
[15:39:12] <Krenair>	 I can't actually remember where extension-list is sued
[15:39:14] <Krenair>	 used*
[15:42:34] <FlorianSW>	 Krenair: https://github.com/wikimedia/mediawiki/blob/0ea03a7f56070956838ab360a5dccc2a506fc4ff/includes/DefaultSettings.php#L6520-L6525 ??? I don't see any other usages (while I'm not seeing, that this list is added to that array https://github.com/wikimedia/operations-mediawiki-config/search?utf8=%E2%9C%93&q=extension-list&type=Code )
[15:42:38] <ostriches>	 Yeah, just overlooked
[16:03:57] <wikibugs>	 6Release-Engineering, 15User-greg: Admin: fill out Summer Managers Offsite - Roadmap 2015-2016 spreadsheet - https://phabricator.wikimedia.org/T108984#1545877 (10greg)
[17:13:37] <ostriches>	 legoktm: You missed out
[17:13:40] <ostriches>	 <3
[17:13:43] <legoktm>	 :(
[17:15:50] <ostriches>	 I got some xfinity-branded TS swag I'll give you, heh.
[17:15:56] <ostriches>	 A button! A keychain!
[17:18:36] <greg-g>	 TS?
[17:21:25] <ostriches>	 #taylorswift
[17:21:48] <greg-g>	 hah
[17:22:11] <legoktm>	 thanks :)
[17:25:40] <wikibugs>	 6Release-Engineering, 10MediaWiki-extensions-Gadgets, 7I18n, 5Patch-For-Review: Don't deploy new namespaces without having translations - https://phabricator.wikimedia.org/T109234#1546526 (10greg) Just catching up on this: should this task have been titled "fix missing namespace translations" instead?  If...
[17:27:12] <Reedy>	 greg-g: yes
[17:27:22] <Reedy>	 well, even, no
[17:27:23] <greg-g>	 Reedy: :)
[17:27:25] <Reedy>	 it's a null task
[17:27:31] <Reedy>	 "it doesn't fucking matter"
[17:27:44] <greg-g>	 hah, I was wondering why Krenair was like 'no' and then a bunch of patches were mered :)
[17:27:47] <greg-g>	 +g
[17:27:56] <Reedy>	 everything falls back to english anyway
[17:28:44] <Krenair>	 "Bad Things" didn't happen
[17:32:33] <greg-g>	 that's what I thought/assumed but wasn't sure
[17:32:38] <greg-g>	 thanks
[17:33:31] <wikibugs>	 6Release-Engineering, 10MediaWiki-extensions-Gadgets, 7I18n, 5Patch-For-Review: Don't deploy new namespaces without having translations - https://phabricator.wikimedia.org/T109234#1546565 (10greg) Consensus on IRC (in #wikimedia-releng) with Reedy and Krenair is that Bad Things(TM) didn't happen. :) I'll s...
[17:36:48] <legoktm>	 greg-g: when deploying things with new namespaces, we should make sure translators have had time to translate them before they start being used, which is exactly what happened in this case
[17:37:02] <legoktm>	 also someone needs to fix Special:Magic
[17:37:52] <greg-g>	 TIL we have a Special:Magic
[17:38:12] <greg-g>	 also, that it redirects to Special:AdvancedTranslate and then tells me it doesn't exist
[17:38:42] <Reedy>	 It's disabled on twn due to a big bug
[17:45:51] <wmf-insecte>	 Project beta-scap-eqiad build #66099: FAILURE in 21 min: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/66099/
[17:48:42] <wmf-insecte>	 Yippee, build fixed!
[17:48:42] <wmf-insecte>	 Project beta-scap-eqiad build #66100: FIXED in 1 min 37 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/66100/
[18:18:28] <wikibugs>	 10Browser-Tests, 10VisualEditor: add true internationalized content support to auto-screenshots - https://phabricator.wikimedia.org/T105466#1546732 (10Jdforrester-WMF) a:3Vikassy
[18:28:19] <Nikerabbit>	 it's *too much* magic ;)
[18:40:12] <wikibugs>	 6Release-Engineering, 15User-greg: Admin: Do homework for SPDPP - Due Monday the 17th - https://phabricator.wikimedia.org/T108997#1546791 (10greg) 5Open>3Resolved Read and done :)
[18:43:07] <legoktm>	 a bunch of trusty slaves are running out of disk space
[18:45:38] <legoktm>	 !log freeing up disk space on 1017
[19:03:22] <legoktm>	 bot is missing?
[19:08:48] <Krenair>	 did the morebots in here run from tools?
[19:09:32] <Krenair>	 I don't have access to that project
[19:09:37] <Krenair>	 but you do, legoktm !
[19:10:05] <legoktm>	 :<
[19:10:31] <Krenair>	 :)
[19:11:27] <legoktm>	 I logged in and have no idea what to do
[19:12:07] <Krenair>	 https://wikitech.wikimedia.org/wiki/Morebots#README
[19:14:30] <legoktm>	 tools.morebots@tools-bastion-01:~$ qmod -rj qa-morebot
[19:14:30] <legoktm>	 Pushed rescheduling of job 674700 on host tools-exec-1217.eqiad.wmflabs
[19:14:47] <legoktm>	 qa-morebots: hello!
[19:14:47] <qa-morebots>	 I am a logbot running on tools-exec-1211.
[19:14:47] <qa-morebots>	 Messages are logged to https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL.
[19:14:47] <qa-morebots>	 To log a message, type !log <msg>.
[19:15:01] <legoktm>	 !log restarted qa-morebots
[19:15:04] <qa-morebots>	 Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL, Master
[19:15:07] <legoktm>	 !log [11:45:39] <legoktm> !log freeing up disk space on 1017
[19:15:10] <qa-morebots>	 Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL, Master
[19:16:18] <Krenair>	 I take it the readme helped? :P
[19:16:34] <legoktm>	 no, I just stared at qstat for a while
[19:16:59] * legoktm updates readme
[19:19:27] <legoktm>	 !log freeing up disk space on 1012
[19:19:30] <qa-morebots>	 Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL, Master
[19:27:39] <wikibugs>	 6Release-Engineering, 10Continuous-Integration-Config, 3Mobile-App-Sprint-64-Android-Gadolinium, 5Patch-For-Review, 3Wikipedia-Android-App: Create jenkins slave instance dedicated to Android runs - https://phabricator.wikimedia.org/T107336#1547001 (10Dbrant)
[19:30:34] <grrrit-wm>	 (03CR) 10Legoktm: "[0] is a link to our gerrit instance? What is the upstream patch? I'm also wary of using something that hasn't been accepted upstream..." [integration/jenkins-job-builder] - 10https://gerrit.wikimedia.org/r/231722 (https://phabricator.wikimedia.org/T107336) (owner: 10Niedzielski)
[19:34:12] <grrrit-wm>	 (03CR) 10Niedzielski: "@Legoktm, thanks! I've corrected the [0] reference. Do I need to drive this patch upstream? This issue is blocking a good portion of our C" [integration/jenkins-job-builder] - 10https://gerrit.wikimedia.org/r/231722 (https://phabricator.wikimedia.org/T107336) (owner: 10Niedzielski)
[19:49:15] <wmf-insecte>	 Project beta-scap-eqiad build #66109: FAILURE in 21 min: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/66109/
[19:49:56] <James_F>	 Oh dear.
[19:52:18] <wmf-insecte>	 Yippee, build fixed!
[19:52:18] <wmf-insecte>	 Project beta-scap-eqiad build #66110: FIXED in 1 min 42 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/66110/
[19:55:33] <greg-g>	 James_F: s'ok ;)
[19:55:47] * greg-g assumed it was re scap fail, maybe not
[19:55:50] <James_F>	 greg-g: Hmm.
[19:56:37] <greg-g>	 legoktm: thanks for doing the diskspace grooming :)
[19:56:45] <grrrit-wm>	 (03PS9) 10Paladox: Update HitCounters tests [integration/config] - 10https://gerrit.wikimedia.org/r/227438 
[20:24:48] <legoktm>	 np
[20:42:56] <grrrit-wm>	 (03PS2) 10Dduvall: Decouple session annotation from Cucumber [selenium] - 10https://gerrit.wikimedia.org/r/230234 (https://phabricator.wikimedia.org/T108273) 
[20:42:58] <grrrit-wm>	 (03PS3) 10Dduvall: Decouple `Environment#test_name` [selenium] - 10https://gerrit.wikimedia.org/r/230139 (https://phabricator.wikimedia.org/T108273) 
[20:43:00] <grrrit-wm>	 (03PS3) 10Dduvall: Decouple check for MediaWiki extension dependencies [selenium] - 10https://gerrit.wikimedia.org/r/230140 (https://phabricator.wikimedia.org/T108273) 
[20:43:02] <grrrit-wm>	 (03PS3) 10Dduvall: Decouple screenshot-ing and artifacts from Cucumber hooks [selenium] - 10https://gerrit.wikimedia.org/r/230230 (https://phabricator.wikimedia.org/T108273) 
[20:44:05] <grrrit-wm>	 (03PS4) 10Dduvall: Basic RSpec support [selenium] - 10https://gerrit.wikimedia.org/r/230261 (https://phabricator.wikimedia.org/T108273) 
[20:54:08] <marxarelli>	 jdlrobson: let me know if you want help debugging your `@integration` tests?
[20:54:14] <marxarelli>	 s/?//
[21:01:20] <jdlrobson>	 marxarelli: sure
[21:01:48] <jdlrobson>	 marxarelli: it's weird. can't replicate locally :/
[21:02:11] <marxarelli>	 jdlrobson: does the video recording give a clue?
[21:02:38] <jdlrobson>	 marxarelli: where is the video?
[21:03:08] <marxarelli>	 jdlrobson: should be under "build artifacts" on the build's main page
[21:03:20] <marxarelli>	 not the console log that gerrit links to
[21:03:31] <jdlrobson>	 got it thanks :)
[21:03:35] <marxarelli>	 https://integration.wikimedia.org/ci/job/mwext-mw-selenium/371/
[21:03:37] <marxarelli>	 np
[21:03:56] <jdlrobson>	 marxarelli: ooohh
[21:03:58] <jdlrobson>	 i think i know
[21:06:07] <jdlrobson>	 marxarelli: mm maybe i dont
[21:07:07] <jdlrobson>	 seems to be cookie related
[21:07:46] <jdlrobson>	 marxarelli: opting into beta not working it seems
[21:09:29] <marxarelli>	 strange
[21:09:31] <jdlrobson>	 marxarelli: does `page.goto` do same as visit(MainPage)
[21:09:45] <marxarelli>	 yes
[21:10:20] <marxarelli>	 `visit(MainPage)` is equivalent to `on(MainPage) { |page| page.goto }`
[21:10:27] <jdlrobson>	 ooh think i got it
[21:10:32] <jdlrobson>	 page.browser instead of browser.
[21:10:43] <marxarelli>	 hmm
[21:10:50] <marxarelli>	 they should reference the same browser object
[21:18:22] <marxarelli>	 jdlrobson: do you think the MW installation might be missing an extension or configuration necessary for the beta flag to work?
[21:19:02] <jdlrobson>	 shouldn't need anything.. :-/
[21:20:17] <marxarelli>	 grep-ing the debug www log i see cookies for both `mf_useformat` and `optin`
[21:20:22] <marxarelli>	 https://integration.wikimedia.org/ci/job/mwext-mw-selenium/371/artifact/log/mw-debug-www.log
[21:26:11] <jdlrobson>	 marxarelli: it doesn't seem to be opting into beta though..
[21:26:15] <jdlrobson>	 i don't know why :/
[21:26:24] <jdlrobson>	 the ui should change when beta has been opted into
[21:26:35] <marxarelli>	 and that is part of core?
[21:28:47] <wikibugs>	 6Release-Engineering, 6Commons, 10MediaWiki-File-management, 10MediaWiki-Tarball-Backports, and 7 others: InstantCommons broken by switch to HTTPS - https://phabricator.wikimedia.org/T102566#1547410 (10BBlack) So, I see new releases a week ago for 1.2[345] containing the InstantCommons fix.  Also, it's bee...
[21:30:37] <wikibugs>	 6Release-Engineering: Tag last two weeks of tasks with core vs new - https://phabricator.wikimedia.org/T109375#1547416 (10greg) 3NEW
[21:37:02] <greg-g>	 which "beta"?
[21:37:06] <greg-g>	 Beta Features aren't part of core
[21:38:04] <marxarelli>	 mobilefrontend looks like
[21:38:11] <marxarelli>	 includes/MobileContext.php
[21:47:32] <marxarelli>	 jdlrobson: fwict, gather switches on context.isBetaGroupMember(), which is turn queries mw.config.get('MFMode')
[21:47:46] <marxarelli>	 and the latter seems to be set in includes/skins/SkinMinerva.php
[21:48:12] <marxarelli>	 so maybe it's an issue with the skin?
[21:48:33] * marxarelli is fishing in new waters
[21:48:49] <jdlrobson>	 marxarelli: but i can't replicate locally..
[21:49:02] <jdlrobson>	 actually
[21:49:14] <jdlrobson>	 so i'm guessing this will fail on MobileFrontend too.. if we had browser tests which ran on beta
[21:49:39] <grrrit-wm>	 (03CR) 10Legoktm: "I think that's a good idea regardless :-)" [integration/jenkins-job-builder] - 10https://gerrit.wikimedia.org/r/231722 (https://phabricator.wikimedia.org/T107336) (owner: 10Niedzielski)
[21:50:04] <jdlrobson>	 ahhh
[21:50:05] <marxarelli>	 should, yeah
[21:50:06] <jdlrobson>	 marxarelli: $wgMFEnableBeta = false;
[21:50:18] <jdlrobson>	 so we need to switch it to $wgMFEnableBeta = true on experimental builds - how can i do that?
[21:50:53] <marxarelli>	 jdlrobson: where do you see that?
[21:51:17] <jdlrobson>	  cat includes/config/Site.php
[21:51:58] <jdlrobson>	 so basically i need to enable that local seting
[21:51:58] <marxarelli>	 ah, ok
[21:52:41] <marxarelli>	 jdlrobson: we can do that in prepare-localhost builder as long as it doesn't mess with qunit tests
[21:52:50] <marxarelli>	 legoktm: ^ any idea if it would?
[21:53:04] <legoktm>	 umm
[21:53:12] <marxarelli>	 (enable $wgMFEnableBeta)
[21:53:36] <marxarelli>	 if you think it might, i can probably factor it in elsewhere
[21:53:47] <legoktm>	 we try to avoid hardcoding extension stuff in CI config I think
[21:54:08] <marxarelli>	 i was also wondering if we should come up with a convention for amending LocalSettings.php from test repos
[21:54:14] <legoktm>	 https://github.com/wikimedia/mediawiki-extensions-GlobalBlocking/blob/e9bec050dbc45fe72edfd10266525e1041c7933c/GlobalBlocking.php#L86
[21:54:32] <marxarelli>	 e.g. include a LocalSettings.php in tests/browser that gets appended, or something
[21:54:52] <legoktm>	 there's a bug for that...somewhere!
[21:55:35] <legoktm>	 https://phabricator.wikimedia.org/T89096
[21:56:17] <marxarelli>	 https://phabricator.wikimedia.org/T72250 maybe?
[21:56:25] <marxarelli>	 ah
[21:56:59] <marxarelli>	 hmmm
[21:57:09] <marxarelli>	 the $wgWikimediaJenkinsCI flag seems to coupled to me
[21:57:15] <marxarelli>	 *too*
[21:58:02] <legoktm>	 it's not ideal, but it works :P
[22:15:55] <grrrit-wm>	 (03CR) 10Thcipriani: "FWIW, I updated the upstream patch, made the last-requested review changes, and poked in their gerrit a bit: https://review.openstack.org/" [integration/jenkins-job-builder] - 10https://gerrit.wikimedia.org/r/231722 (https://phabricator.wikimedia.org/T107336) (owner: 10Niedzielski)
[22:18:42] <legoktm>	 !log running schema change for [[gerrit:202344]] on beta
[22:18:45] <qa-morebots>	 Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL, Master
[22:18:51] <legoktm>	 mysql> ALTER TABLE globaluser ADD COLUMN gu_cas_token integer unsigned NOT NULL default 1; 
[22:18:51] <legoktm>	 Query OK, 14249 rows affected (0.52 sec)
[22:18:51] <legoktm>	 Records: 14249  Duplicates: 0  Warnings: 0
[22:19:58] <jdlrobson>	 marxarelli: so any thoughts. sorry my attention has been divided :)
[22:20:17] <jdlrobson>	 do we need to think more about this or is this something we can do now?
[22:22:31] <marxarelli>	 jdlrobson: there are a couple of options i think
[22:22:38] <marxarelli>	 but i don't know which is the best :)
[22:22:42] <jdlrobson>	 and https://phabricator.wikimedia.org/T72250 is the bug?
[22:23:46] <marxarelli>	 and https://phabricator.wikimedia.org/T89096
[22:23:56] <marxarelli>	 it's not a bug per say
[22:24:10] <wikibugs>	 10Continuous-Integration-Infrastructure, 10MediaWiki-extensions-SpamBlacklist: Figure out a system to override default settings when in test context - https://phabricator.wikimedia.org/T89096#1547681 (10Jdlrobson)
[22:24:11] <wikibugs>	 10Continuous-Integration-Infrastructure, 10Wikidata: Allow tests to specify what extensions and or what order things are loaded in - https://phabricator.wikimedia.org/T72250#1547682 (10Jdlrobson)
[22:24:33] <marxarelli>	 just a call for a convention to supply configuration that's specific to CI/testing
[22:24:49] <marxarelli>	 i think the comments re unit testing and qunit testing are pretty spot on
[22:25:21] <marxarelli>	 but browser tests are inherently "outside" of the application so much that mocking and overriding global set per test is not always an option
[22:25:28] <marxarelli>	 global *state*
[22:26:57] <marxarelli>	 jdlrobson: we can either push for a general implementation (for qunit, phpunit, and browser tests) in  https://phabricator.wikimedia.org/T89096
[22:27:34] <marxarelli>	 or 2) make a gather specific job that wraps mwext-mw-selenium
[22:28:04] <marxarelli>	 or 3) modify mwext-mw-selenium to append LocalSettings.php with a `tests/browser/LocalSettings.php` file if one exists
[22:30:31] <marxarelli>	 option #3 is effectively #1 without the red tape (read: unilateral, not collaborative) as it would only apply to mwext-mw-selenium job
[22:36:34] <jdlrobson>	 marxarelli: MobileFrontend already has a need for config variables
[22:36:53] <jdlrobson>	 3 sounds like a good option in the interest of iterating and failing fast
[22:37:28] <jdlrobson>	 I feel like this could educate 1
[22:37:48] <marxarelli>	 jdlrobson: i think it should be paired with an explicit assertion in the MF/Gather tests
[22:38:03] <jdlrobson>	 marxarelli: what do you mean?
[22:38:56] <marxarelli>	 jdlrobson: so, if we're ensuring that $wgMFEnableBeta is set to true in LocalSettings.php, that manifests as mw.config.get('MFMode') == 'beta' on the frontend, right?
[22:39:23] <marxarelli>	 so maybe you should include an assertion for that early on in the tests that require beta to be enabled
[22:54:43] <jdlrobson>	 marxarelli: should i open a new bug specific to this use case then?
[22:55:26] <marxarelli>	 probably just comment in https://phabricator.wikimedia.org/T89096
[22:55:48] <marxarelli>	 jdlrobson: what were the other test cases for MF that require changes to LocalSettings?
[22:59:33] <wikibugs>	 10Continuous-Integration-Infrastructure, 10MediaWiki-extensions-SpamBlacklist: Figure out a system to override default settings when in test context - https://phabricator.wikimedia.org/T89096#1547718 (10Jdlrobson) Right now we need this for MobileFrontend and Gather's JJB job for running browser tests per comm...
[23:07:50] <wikibugs>	 10Continuous-Integration-Infrastructure, 10MediaWiki-extensions-SpamBlacklist: Figure out a system to override default settings when in test context - https://phabricator.wikimedia.org/T89096#1547730 (10dduvall) I agree with @Krinkle's comments regarding the proposed system in the context of unit testing: it d...
[23:31:23] <marxarelli>	 jdlrobson: thought of another possible option
[23:31:54] <jdlrobson>	 oh yeh?
[23:33:05] <marxarelli>	 we could support some additional configuration in `environments.yml` that gets append to LocalSettings.php when `AfterConfiguration` fires
[23:33:22] <marxarelli>	 i.e. put the implementation in mw-selenium, not in jjb
[23:33:45] <marxarelli>	 that way, it's a little closer to your test code
[23:35:36] <marxarelli>	 (`AfterConfiguration` is a Cucumber hook that runs before the entire suite gets executed)
[23:35:40] <jdlrobson>	 that also works :)
[23:35:49] <jdlrobson>	 i likey
[23:35:53] <marxarelli>	 cool. i think it's marginally cleaner
[23:44:00] <grrrit-wm>	 (03PS1) 10Dduvall: Close PHP tag when appending LocalSettings.php [integration/config] - 10https://gerrit.wikimedia.org/r/232224 (https://phabricator.wikimedia.org/T89096)