[00:06:04] (03CR) 10John Vandenberg: [C: 04-1] [WIP] Add job to run pywikibot tests against beta cluster (031 comment) [integration/config] - 10https://gerrit.wikimedia.org/r/220384 (https://phabricator.wikimedia.org/T100903) (owner: 10Legoktm) [00:21:56] (03CR) 10John Vandenberg: [WIP] Add job to run pywikibot tests against beta cluster (031 comment) [integration/config] - 10https://gerrit.wikimedia.org/r/220384 (https://phabricator.wikimedia.org/T100903) (owner: 10Legoktm) [00:23:40] 10Beta-Cluster, 10ContentTranslation-Deployments, 10MediaWiki-extensions-ContentTranslation, 7Pywikibot-tests: paraminfo for contenttranslationlist is broken on beta wikis - https://phabricator.wikimedia.org/T109659#1555714 (10jayvdb) (edit conflict..) [00:41:38] 10Beta-Cluster, 10ContentTranslation-Deployments, 10MediaWiki-extensions-ContentTranslation, 7Pywikibot-tests: paraminfo for contenttranslationlist is broken on beta wikis - https://phabricator.wikimedia.org/T109659#1555763 (10Anomie) Looks to have been caused by https://gerrit.wikimedia.org/r/#/c/232000/. [00:43:50] (03CR) 10John Vandenberg: [WIP] Add job to run pywikibot tests against beta cluster (031 comment) [integration/config] - 10https://gerrit.wikimedia.org/r/220384 (https://phabricator.wikimedia.org/T100903) (owner: 10Legoktm) [00:46:37] (03PS4) 10Legoktm: [WIP] Add job to run pywikibot tests against beta cluster [integration/config] - 10https://gerrit.wikimedia.org/r/220384 (https://phabricator.wikimedia.org/T100903) [00:52:21] (03PS5) 10Legoktm: [WIP] Add job to run pywikibot tests against beta cluster [integration/config] - 10https://gerrit.wikimedia.org/r/220384 (https://phabricator.wikimedia.org/T100903) [00:55:02] 10Beta-Cluster, 6operations, 7HHVM: hhvm apache fills /var/log/apache2 with access logs - https://phabricator.wikimedia.org/T75262#1555799 (10Dzahn) Why "externally blocked" ? [00:55:32] (03CR) 10John Vandenberg: [C: 031] [WIP] Add job to run pywikibot tests against beta cluster [integration/config] - 10https://gerrit.wikimedia.org/r/220384 (https://phabricator.wikimedia.org/T100903) (owner: 10Legoktm) [00:57:11] 10Continuous-Integration-Config, 10MediaWiki-extensions-ContentTranslation: ContentTranslation is not running PHPUnit structure tests - https://phabricator.wikimedia.org/T109670#1555809 (10Legoktm) 3NEW [00:58:36] 10Beta-Cluster, 10ContentTranslation-Deployments, 10MediaWiki-extensions-ContentTranslation, 5Patch-For-Review, 7Pywikibot-tests: paraminfo for contenttranslationlist is broken on beta wikis - https://phabricator.wikimedia.org/T109659#1555821 (10Legoktm) 5Open>3Resolved a:3Legoktm I reverted the pr... [01:20:33] 6Release-Engineering: foreachwikiexceptdblist to run scripts on all but a blacklist of wikis - https://phabricator.wikimedia.org/T101213#1555862 (10Dzahn) [01:28:01] (03PS6) 10Legoktm: Add job to run pywikibot tests against beta cluster [integration/config] - 10https://gerrit.wikimedia.org/r/220384 (https://phabricator.wikimedia.org/T100903) [01:30:28] (03CR) 10Legoktm: [C: 032] Add job to run pywikibot tests against beta cluster [integration/config] - 10https://gerrit.wikimedia.org/r/220384 (https://phabricator.wikimedia.org/T100903) (owner: 10Legoktm) [01:32:25] (03Merged) 10jenkins-bot: Add job to run pywikibot tests against beta cluster [integration/config] - 10https://gerrit.wikimedia.org/r/220384 (https://phabricator.wikimedia.org/T100903) (owner: 10Legoktm) [01:34:47] 10Beta-Cluster, 10Continuous-Integration-Infrastructure, 10pywikibot-core, 5Patch-For-Review: Run pywikibot test suite regularly on beta cluster as part of MediaWiki/Wikimedia CI - https://phabricator.wikimedia.org/T100903#1555911 (10Legoktm) I configured the job to run "@midnight" which jenkins interprete... [01:41:48] 10Beta-Cluster, 10Continuous-Integration-Infrastructure, 10MediaWiki-API, 7Pywikibot-tests: prevent modules with broken paraminfo being deployed to production wikis - https://phabricator.wikimedia.org/T108322#1555926 (10jayvdb) {T100903} is moving ahead to catch these types of problems. [02:45:34] 6Release-Engineering: foreachwikiexceptdblist to run scripts on all but a blacklist of wikis - https://phabricator.wikimedia.org/T101213#1556023 (10Krenair) Should probably fix that code to work with these dblists first though: ```all-labs.dblist gettingstarted-with-category-suggestions.dblist visualeditor-defau... [02:54:30] 6Release-Engineering: foreachwikiexceptdblist to run scripts on all but a blacklist of wikis - https://phabricator.wikimedia.org/T101213#1556026 (10Krenair) https://gerrit.wikimedia.org/r/232672 for that [03:47:50] 6Release-Engineering, 5Patch-For-Review: foreachwikiexceptdblist to run scripts on all but a blacklist of wikis - https://phabricator.wikimedia.org/T101213#1556075 (10Krenair) a:3Krenair [04:01:31] 10Deployment-Systems, 6Release-Engineering, 6Services, 6operations: Streamline our service development and deployment process - https://phabricator.wikimedia.org/T93428#1556078 (10mmodell) @gwicke: Where is the error rate for services logged? I'd like to try my hand at building a monitoring task that watch... [04:04:13] 10Deployment-Systems, 6Release-Engineering, 7Epic: Merge to deployed branches instead of cutting a new deployment branch every week. - https://phabricator.wikimedia.org/T89945#1556080 (10mmodell) [04:13:51] 10Deployment-Systems, 6Release-Engineering, 6Services, 6operations: Streamline our service development and deployment process - https://phabricator.wikimedia.org/T93428#1556086 (10GWicke) @mmodell, the set of metrics and logs to look at depends on the service. For RESTBase, we could for example look at the... [04:25:12] 10Browser-Tests, 10Continuous-Integration-Infrastructure, 6Release-Engineering, 7Epic, 7Tracking: [EPIC] trigger browser tests from Gerrit (tracking) - https://phabricator.wikimedia.org/T55697#1556109 (10Mattflaschen) [04:27:21] 10Continuous-Integration-Infrastructure, 10MediaWiki-extensions-SpamBlacklist, 5Patch-For-Review: Figure out a system to override default settings when in test context - https://phabricator.wikimedia.org/T89096#1556112 (10Mattflaschen) >>! In T89096#1553749, @dduvall wrote: >>>! In T89096#1552164, @Legoktm w... [04:39:12] 10Browser-Tests, 10Continuous-Integration-Infrastructure, 6Release-Engineering, 7Epic, 7Tracking: [EPIC] trigger browser tests from Gerrit (tracking) - https://phabricator.wikimedia.org/T55697#1556124 (10Jdlrobson) [04:39:13] 10Continuous-Integration-Infrastructure: browsertests: triggers for MobileFrontend - https://phabricator.wikimedia.org/T59560#1556122 (10Jdlrobson) 5declined>3Resolved Reflecting the true state. [05:36:54] Yippee, build fixed! [05:36:54] Project browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-windows_7-internet_explorer-11-sauce build #516: FIXED in 34 min: https://integration.wikimedia.org/ci/job/browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-windows_7-internet_explorer-11-sauce/516/ [05:56:06] 10Deployment-Systems, 6Release-Engineering, 6Services, 6operations: Streamline our service development and deployment process - https://phabricator.wikimedia.org/T93428#1556189 (10mmodell) >>! In T93428#1556086, @GWicke wrote: > @mmodell, the set of metrics and logs to look at depends on the service. For R... [06:15:27] 10Deployment-Systems, 10Scap3: Scap3 should support post-deploy checks - https://phabricator.wikimedia.org/T109515#1556205 (10mmodell) For simple checks we can use this: >01:04 <_joe_> https://gerrit.wikimedia.org/r/#/c/231790/5/modules/service/templates/deployment_script.sh.erb at line 110 we do that exactly... [07:10:32] 10Continuous-Integration-Config, 10MediaWiki-extensions-ContentTranslation, 5ContentTranslation-Release6, 3LE-CX6-Sprint 2: ContentTranslation is not running PHPUnit structure tests - https://phabricator.wikimedia.org/T109670#1556301 (10Arrbee) [07:22:12] 6Release-Engineering, 10MediaWiki-extensions-Gadgets, 7I18n, 5WMF-deploy-2015-08-25_(1.26wmf20): Don't deploy new namespaces without having translations - https://phabricator.wikimedia.org/T109234#1556320 (10Ricordisamoa) [07:23:35] 10Deployment-Systems, 6Release-Engineering, 6Services, 6operations: Streamline our service development and deployment process - https://phabricator.wikimedia.org/T93428#1556326 (10Joe) @mmodell you could be interested in the check_graphite nagios script we use - it has threshold alerts and alerts based on... [07:24:01] 10Continuous-Integration-Config, 10MediaWiki-extensions-ContentTranslation, 5ContentTranslation-Release6, 3LE-CX6-Sprint 2: ContentTranslation is not running PHPUnit structure tests - https://phabricator.wikimedia.org/T109670#1556327 (10santhosh) a:3KartikMistry [07:35:28] 10Beta-Cluster, 10ContentTranslation-Deployments, 10MediaWiki-extensions-ContentTranslation, 7Pywikibot-tests, 5WMF-deploy-2015-08-25_(1.26wmf20): paraminfo for contenttranslationlist is broken on beta wikis - https://phabricator.wikimedia.org/T109659#1556328 (10Ricordisamoa) [08:23:29] 10Continuous-Integration-Config, 10MediaWiki-extensions-ContentTranslation, 5ContentTranslation-Release6, 3LE-CX6-Sprint 2: ContentTranslation is not running PHPUnit structure tests - https://phabricator.wikimedia.org/T109670#1556403 (10Arrbee) p:5Unbreak!>3High [08:23:43] 10Continuous-Integration-Config, 10MediaWiki-extensions-ContentTranslation, 5ContentTranslation-Release6, 3LE-CX6-Sprint 2: ContentTranslation is not running PHPUnit structure tests - https://phabricator.wikimedia.org/T109670#1555809 (10Arrbee) p:5High>3Unbreak! [08:47:25] legoktm: https://phabricator.wikimedia.org/T109670 - more info to fix? ie example? [09:21:43] Project browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-os_x_10.9-safari-sauce build #697: FAILURE in 1 hr 11 min: https://integration.wikimedia.org/ci/job/browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-os_x_10.9-safari-sauce/697/ [09:42:24] 6Release-Engineering, 6Commons, 10MediaWiki-File-management, 10MediaWiki-Tarball-Backports, and 7 others: InstantCommons broken by switch to HTTPS - https://phabricator.wikimedia.org/T102566#1556550 (10Nemo_bis) > Are there environments where curl is not available? (Shared hosting?) Yes. (According to use... [10:25:50] 10Deployment-Systems, 10Scap3: Scap3 should support post-deploy checks - https://phabricator.wikimedia.org/T109515#1556599 (10mobrovac) Great stuff @mmodell! >>! In T109515#1556205, @mmodell wrote: > I haven't worked out how to define the thresholds yet but the code for reading values from graphite is probabl... [10:36:13] (03PS11) 10JanZerebecki: Update HitCounters tests [integration/config] - 10https://gerrit.wikimedia.org/r/227438 (owner: 10Paladox) [10:36:22] (03CR) 10JanZerebecki: [C: 032] Update HitCounters tests [integration/config] - 10https://gerrit.wikimedia.org/r/227438 (owner: 10Paladox) [10:44:21] 10Continuous-Integration-Config, 10Wikidata, 5Patch-For-Review, 3Wikidata-Sprint-2015-08-18: [Task] change phpunit CI job for Wikidata.org to use composer - https://phabricator.wikimedia.org/T107834#1556667 (10JanZerebecki) [10:44:49] (03Merged) 10jenkins-bot: Update HitCounters tests [integration/config] - 10https://gerrit.wikimedia.org/r/227438 (owner: 10Paladox) [10:45:18] 10Continuous-Integration-Config, 10Wikidata, 5Patch-For-Review, 3Wikidata-Sprint-2015-08-18: [Task] change phpunit CI job for Wikidata.org to use composer - https://phabricator.wikimedia.org/T107834#1505355 (10JanZerebecki) WikimediaBadges works, but Wikidata.org needs a dependency on Wikibase and the job... [10:45:53] 10Continuous-Integration-Infrastructure, 5MW-1.26-release, 5Patch-For-Review: Fetch dependencies using composer instead of cloning mediawiki/vendor for non-wmf branches - https://phabricator.wikimedia.org/T90303#1556671 (10JanZerebecki) [10:45:55] 10Continuous-Integration-Config, 10Wikidata, 5Patch-For-Review, 3Wikidata-Sprint-2015-08-18: [Task] change phpunit CI job for Wikidata.org to use composer - https://phabricator.wikimedia.org/T107834#1556670 (10JanZerebecki) [10:46:44] (03PS4) 10JanZerebecki: Remove WikiGrok as dependency from mediawiki-core phpunit [integration/config] - 10https://gerrit.wikimedia.org/r/231579 (owner: 10Florianschmidtwelzow) [10:46:58] (03CR) 10JanZerebecki: [C: 032] Remove WikiGrok as dependency from mediawiki-core phpunit [integration/config] - 10https://gerrit.wikimedia.org/r/231579 (owner: 10Florianschmidtwelzow) [10:48:57] (03Merged) 10jenkins-bot: Remove WikiGrok as dependency from mediawiki-core phpunit [integration/config] - 10https://gerrit.wikimedia.org/r/231579 (owner: 10Florianschmidtwelzow) [12:41:50] 10Continuous-Integration-Infrastructure: MediaWiki phpunit job failing with "Can't connect to local MySQL server" - https://phabricator.wikimedia.org/T109704#1556908 (10Krinkle) 3NEW [12:46:13] 10Continuous-Integration-Infrastructure: MediaWiki phpunit job failing with "Can't connect to local MySQL server" - https://phabricator.wikimedia.org/T109704#1556930 (10Krenair) Some people in #RelEng know what's causing this, related to T109497 ? [12:47:11] (03CR) 10Krinkle: [C: 04-1] Append LocalSettings.php for mw-selenium jobs (031 comment) [integration/jenkins] - 10https://gerrit.wikimedia.org/r/232399 (https://phabricator.wikimedia.org/T89096) (owner: 10Dduvall) [12:47:17] Project browsertests-PdfHandler-test2.wikipedia.org-linux-firefox-sauce build #612: FAILURE in 1 min 16 sec: https://integration.wikimedia.org/ci/job/browsertests-PdfHandler-test2.wikipedia.org-linux-firefox-sauce/612/ [12:48:00] 10Continuous-Integration-Infrastructure, 6Discovery, 7Elasticsearch: elasticsearch 1.6.0 fails to start after reboot - https://phabricator.wikimedia.org/T109497#1556933 (10Krinkle) [12:48:10] (03CR) 10Krinkle: [C: 031] Support additional LocalSettings.php for mw-selenium jobs [integration/config] - 10https://gerrit.wikimedia.org/r/232224 (https://phabricator.wikimedia.org/T89096) (owner: 10Dduvall) [13:26:44] 10Deployment-Systems, 10Scap3: Scap3 should support post-deploy checks - https://phabricator.wikimedia.org/T109515#1556991 (10mmodell) >>! In T109515#1556599, @mobrovac wrote: > What could be useful is to gather some metrics/logs before the actual deploy (say, in a one-min window or the likes), do the deploy,... [13:32:34] 10Deployment-Systems, 10Scap3: Scap3 should support post-deploy checks - https://phabricator.wikimedia.org/T109515#1556997 (10mobrovac) >>! In T109515#1556991, @mmodell wrote: > we could even continuously monitor several metrics during a deploy and give immediate feedback if any of them appear to be headed in... [13:34:32] 10Deployment-Systems, 6Release-Engineering, 6Services, 6operations: Streamline our service development and deployment process - https://phabricator.wikimedia.org/T93428#1557006 (10mmodell) @joe: thanks, that seems a lot more powerful than the ideas I had come up with so far. So we can call the nagios chec... [13:38:11] 10Deployment-Systems, 10Scap3: Scap3 should support post-deploy checks - https://phabricator.wikimedia.org/T109515#1557024 (10mmodell) >>! In T109515#1556997, @mobrovac wrote: > Yes, +1e3 to that. We'll need to devise a heuristic for the //heading in the wrong direction// part. > > Note that the same could b... [13:43:28] 10Continuous-Integration-Infrastructure, 10MediaWiki-extensions-SpamBlacklist, 5Patch-For-Review: Figure out a system to override default settings when in test context - https://phabricator.wikimedia.org/T89096#1557026 (10Florian) Not everyone uses (or want to use) vagrant, so there should be a solution for... [14:06:43] hallo [14:07:03] https://phabricator.wikimedia.org/T109670 is "Unbreak Now" and it's probably very easy to fix, but I'll need a hint how [14:07:21] !log reloading zuul for 838af5a..0c601ae [14:08:23] legoktm, Reedy , Krinkle , zeljkof ^ [14:08:47] hi aharoni [14:08:51] Did they previously work? [14:08:52] * zeljkof is looking [14:09:14] I'd look in zuul/layout and see what your extension is doing different than most other extensions [14:10:14] Krinkle: that's what I'm doing, but I'm trying to understand what does "PHPUnit structure" refer to [14:10:36] mediawiki-core/tests/phpunit/structure [14:10:44] Eg. ResourcesTest [14:10:52] and other meta reflection tests [14:20:01] (03PS1) 10Amire80: Remove Narayam and WebFonts [integration/config] - 10https://gerrit.wikimedia.org/r/232726 [14:22:00] Krinkle: Sorry, I still don't think that I understand. Is "PHPunit structure" a thing that needs to be enabled in particular, or will enabling the usual phpunit tests do it? [14:23:54] aharoni: looking at it? [14:24:27] For example, we don't have, php-composer-validate [14:25:46] kart_: this sounds like the right thing, but I prefer not to guess without understanding [14:27:16] Obvious. [14:27:40] I would ask moreinfo in bug now. UBN is because UBN isn't good description. [14:27:54] (I had to think twice what is UBN ;)) [14:28:43] it's a good description for the priority, but not a good hint for fixing [14:28:53] zeljkof, do you have a clearer pointer? [14:29:02] php-composer-validate validates composer.json, not related to mediawiki structure tests [14:29:32] 10Continuous-Integration-Config, 10MediaWiki-extensions-ContentTranslation, 5ContentTranslation-Release6, 3LE-CX6-Sprint 2: ContentTranslation is not running PHPUnit structure tests - https://phabricator.wikimedia.org/T109670#1557108 (10KartikMistry) It looks zuul/layout.yaml is missing some entries for 'P... [14:29:58] Krinkle: yeah. [14:30:03] So I just guessed. [14:30:13] kart_: Can you re-read that comment and re-reserialise? It's not making sense. [14:31:22] It's not missing an entry for 'PHPUnit structure tests', that doesn't exist. No extension anywhere has that. [14:31:51] I assume it looks *like*. Not sure what the second sentence means. [14:32:40] Updated. [14:32:46] I'm still not sure. [14:35:20] 10Continuous-Integration-Infrastructure, 10MediaWiki-extensions-SpamBlacklist, 5Patch-For-Review: Figure out a system to override default settings when in test context - https://phabricator.wikimedia.org/T89096#1557117 (10Jdlrobson) >>! In T89096#1557026, @Florian wrote: > Not everyone uses (or want to use)... [14:39:34] there are two problems: phab works, but look strange, and all pictures at wikipedia are not shown [14:39:39] *looks [14:40:15] Try to look at a photo gives this message: https://upload.wikimedia.org/wikipedia/commons/0/01/Catwatch-recentchanges-de.png [14:40:39] kart_, Krinkle - that's a yet-another guess, but maybe adding extension-gate is the right thing? [14:41:31] Luke081515: I think you're seeing a problem that not every body is getting. Following that url shows me a picture of German wikipedia recent changes. [14:41:33] What message? [14:42:49] error: connection failed, no correct OCSP certificate [14:42:54] sec_error_ocsp_invalid_signing_cert [14:43:03] can you go to -operations Luke081515? [14:43:27] ok [14:48:42] 10Deployment-Systems, 6Release-Engineering, 6Services, 6operations: Streamline our service development and deployment process - https://phabricator.wikimedia.org/T93428#1557148 (10GWicke) > What kind of configuration parameters would be useful? The very first thing would be a way to configure which metri... [14:49:54] aharoni: sorry, I was away for a few minutes, catching up [14:56:49] aharoni: I am not familiar with phpunit structure tests [14:57:09] is there a separate job that runs them? or are they a part of normal unit test run? [14:57:22] aharoni: I'm looking at it now. [14:57:38] did the job ever work for CX? can you point me to an extension where it runs? [15:24:02] (03PS2) 10Zfilipin: Test SauceLabs job status annotation [selenium] - 10https://gerrit.wikimedia.org/r/229417 (https://phabricator.wikimedia.org/T105589) (owner: 10Dduvall) [15:25:18] (03CR) 10jenkins-bot: [V: 04-1] Test SauceLabs job status annotation [selenium] - 10https://gerrit.wikimedia.org/r/229417 (https://phabricator.wikimedia.org/T105589) (owner: 10Dduvall) [15:29:07] (03CR) 10Zfilipin: [C: 04-1] "I have rebased the commit, but now the integration job fails." [selenium] - 10https://gerrit.wikimedia.org/r/229417 (https://phabricator.wikimedia.org/T105589) (owner: 10Dduvall) [15:56:48] (03CR) 10Dduvall: Append LocalSettings.php for mw-selenium jobs (031 comment) [integration/jenkins] - 10https://gerrit.wikimedia.org/r/232399 (https://phabricator.wikimedia.org/T89096) (owner: 10Dduvall) [16:03:11] (03PS3) 10Dduvall: Append LocalSettings.php for mw-selenium jobs [integration/jenkins] - 10https://gerrit.wikimedia.org/r/232399 (https://phabricator.wikimedia.org/T89096) [16:10:14] aharoni: there's a mwext-testextension-(zend|hhvm) job that runs PHPUnit tests, including the structure tests which check things like every class in your autoloader mapping exists, or, all API modules exist, etc. And if your extension has other phpunit tests, it'll run those too. [16:11:04] kart_: ^ [16:11:06] legoktm: thanks [16:13:47] legoktm: thanks [16:15:59] aharoni: I'm submitting fix. Can you take it fwd from it? It looks I have to go off early :/ [16:18:49] greg-g: What's the mailing list that everyone who has deployment access is supposed to be on? Ops? [16:22:48] csteipp: ops yeah [16:23:27] TIL -- are we sure as I don't know if anyone adds ppl to that list as they get added to the admin group [16:23:31] but just a thought [16:23:37] (03PS3) 10Dduvall: Test SauceLabs job status annotation [selenium] - 10https://gerrit.wikimedia.org/r/229417 (https://phabricator.wikimedia.org/T105589) [16:31:56] chasemp, csteipp, greg-g: My understanding is that everyone with deployment access is supposed to be able to subscribe to that list [16:32:03] But not necessarily everyone is currently [16:32:42] I do know for a fact that not everyone with deployment access is supposed to be able to subscribe to engineering :) [16:33:25] really? is engineering-l WMF staff only? [16:33:27] 10Deployment-Systems, 5Patch-For-Review, 7Security-Other: By default, have /usr/local/bin/sql use a read-only account when connecting to mysql - https://phabricator.wikimedia.org/T105046#1557591 (10Krenair) 5Open>3Resolved [16:33:38] yes [16:33:55] bd808: WMF, and a few others... a bunch of wmde are on there [16:33:57] bd808, yes, really. [16:34:12] Or were, iirc [16:34:25] #toomanymailinglists [16:34:32] Engineering [16:34:32] Development and Operations engineers (WMF only) [16:34:32] WMF Engineering staff and contractors (only!) list. [16:34:38] It's very *very* clear. [16:35:44] thats sort of odd since we have roots even who don't match that description [16:35:51] Indeed. [16:36:13] And a non-WMF non-root who has mailman archive access anyway. [16:36:29] chain of command! [16:36:34] or something [16:37:05] Some people on that list look like ex-contractors actually. Should probably add that to the list of offboarding things [16:37:19] * Krenair grumbles [16:37:38] organizing the work of anarchists is hard [16:38:13] taht deserves stashbotting [16:38:19] bd808: :) [16:38:47] Just !bash it and *poof* [16:39:08] !bash bd808: organizing the work of anarchists is hard [16:39:12] ...poof? [16:39:33] https://tools.wmflabs.org/bash/quip/AU9L-nNa1oXzWjit5RvW [16:40:37] where is the code for that maybe I could get it to respond with a link :) [16:40:44] 10Browser-Tests, 6Release-Engineering, 5Testing Initiative 2015: Improve browser testing page with templates : Emphasize testing documentation on mediawiki.org - https://phabricator.wikimedia.org/T108110#1557620 (10dduvall) a:5dduvall>3None [16:41:03] 6Release-Engineering, 5Testing Initiative 2015: Include links to unit testing (Emphasize testing documentation on mediawiki.org) - https://phabricator.wikimedia.org/T108105#1557624 (10dduvall) a:5dduvall>3None [16:42:26] chasemp: sadly the irc bot built into logstash is input only. [16:44:10] It uses this -- https://github.com/wikimedia/operations-puppet/blob/production/files/logstash/filter-stashbot.conf -- and -- https://github.com/wikimedia/operations-puppet/blob/production/manifests/role/logstash.pp#L217-L304 [16:56:55] 10Deployment-Systems, 6Release-Engineering, 6Services, 6operations: Streamline our service development and deployment process - https://phabricator.wikimedia.org/T93428#1557763 (10GWicke) Timely [blog post on lessons learned from post-mortems](http://danluu.com/postmortem-lessons/): > Configuration bugs,... [17:01:31] 10Deployment-Systems, 6Release-Engineering, 6Services, 6operations: Streamline our service development and deployment process - https://phabricator.wikimedia.org/T93428#1557776 (10Joe) >>! In T93428#1557148, @GWicke wrote: >> What kind of configuration parameters would be useful? > > The very first thing... [17:10:14] 10Deployment-Systems, 6Release-Engineering, 6Services, 6operations: Streamline our service development and deployment process - https://phabricator.wikimedia.org/T93428#1557821 (10ssastry) >>! In T93428#1557763, @GWicke wrote: > Timely [blog post on lessons learned from post-mortems](http://danluu.com/post... [17:28:05] 10Browser-Tests, 10VisualEditor, 5Patch-For-Review: Update VisualEditor repository to mediawiki_selenium Ruby gem 1.x - https://phabricator.wikimedia.org/T99661#1557917 (10dduvall) [17:29:38] 10Browser-Tests, 10VisualEditor: Delete or fix failed VisualEditor browsertests Jenkins job - https://phabricator.wikimedia.org/T94162#1557943 (10dduvall) [17:29:39] 10Browser-Tests, 10VisualEditor, 5Patch-For-Review: Update VisualEditor repository to mediawiki_selenium Ruby gem 1.x - https://phabricator.wikimedia.org/T99661#1557944 (10dduvall) [17:33:56] 6Release-Engineering, 7Tracking: Update repositories that use mediawiki_selenium Ruby gem 1.x (tracking) - https://phabricator.wikimedia.org/T94083#1557957 (10dduvall) [17:33:57] 10Browser-Tests, 10VisualEditor: Delete or fix failed VisualEditor browsertests Jenkins job - https://phabricator.wikimedia.org/T94162#1557956 (10dduvall) [17:33:59] 10Browser-Tests, 10VisualEditor, 5Patch-For-Review: Update VisualEditor repository to mediawiki_selenium Ruby gem 1.x - https://phabricator.wikimedia.org/T99661#1557954 (10dduvall) 5Open>3Resolved The test suite has been fully upgraded to use MW-Selenium 1.5 and the daily browser-test Jenkins job runs su... [18:01:50] (03PS4) 10Dduvall: Support additional LocalSettings.php for mw-selenium jobs [integration/config] - 10https://gerrit.wikimedia.org/r/232224 (https://phabricator.wikimedia.org/T89096) [18:09:55] legoktm: does https://gerrit.wikimedia.org/r/#/c/232749/ make sense? [18:10:31] https://phabricator.wikimedia.org/T109670 is a blocker for other things that we'd love to do ASAP [18:12:56] um, no [18:12:59] I'll just fix it [18:13:12] our docs about this are out of date which sucks [18:15:53] (03PS2) 10Legoktm: Add PHPUnit tests for ContentTranslation [integration/config] - 10https://gerrit.wikimedia.org/r/232749 (https://phabricator.wikimedia.org/T109670) (owner: 10KartikMistry) [18:15:55] (03CR) 10jenkins-bot: [V: 04-1] Add PHPUnit tests for ContentTranslation [integration/config] - 10https://gerrit.wikimedia.org/r/232749 (https://phabricator.wikimedia.org/T109670) (owner: 10KartikMistry) [18:16:05] (03PS3) 10Legoktm: Add PHPUnit tests for ContentTranslation [integration/config] - 10https://gerrit.wikimedia.org/r/232749 (https://phabricator.wikimedia.org/T109670) (owner: 10KartikMistry) [18:16:54] 10Browser-Tests, 10VisualEditor, 5Patch-For-Review, 5WMF-deploy-2015-08-25_(1.26wmf20): Update VisualEditor repository to mediawiki_selenium Ruby gem 1.x - https://phabricator.wikimedia.org/T99661#1558069 (10Jdforrester-WMF) [18:18:42] legoktm: thanks [18:20:43] (03CR) 10Legoktm: [C: 032] Add PHPUnit tests for ContentTranslation [integration/config] - 10https://gerrit.wikimedia.org/r/232749 (https://phabricator.wikimedia.org/T109670) (owner: 10KartikMistry) [18:23:02] 10Continuous-Integration-Infrastructure, 7Zuul: zuul status page has double underline in Firefox due to abbr styles - https://phabricator.wikimedia.org/T109747#1558086 (10Legoktm) 3NEW [18:23:15] 10Continuous-Integration-Infrastructure, 7Zuul: zuul status page has double underline in Firefox due to abbr styles - https://phabricator.wikimedia.org/T109747#1558093 (10Legoktm) p:5Triage>3Lowest [18:26:58] (03Merged) 10jenkins-bot: Add PHPUnit tests for ContentTranslation [integration/config] - 10https://gerrit.wikimedia.org/r/232749 (https://phabricator.wikimedia.org/T109670) (owner: 10KartikMistry) [18:27:56] !log deploying https://gerrit.wikimedia.org/r/232749 [18:28:52] aharoni, kart_: [18:28:53] 18:28:33 1) ResourcesTest::testMissingDependencies [18:28:53] 18:28:33 The module 'wikibase.api.RepoApi' required by 'ext.cx.wikibase.link' must exist [18:28:53] 18:28:33 Failed asserting that an array contains 'wikibase.api.RepoApi'. [18:28:54] 10Deployment-Systems, 6Release-Engineering, 7Epic: Merge to deployed branches instead of cutting a new deployment branch every week. - https://phabricator.wikimedia.org/T89945#1558101 (10Jdforrester-WMF) This means that we will lose the feature of ~~Forrest~~ReleaseTaggerBot telling us to which versions patc... [18:30:14] is Wikibase a dependency of ContentTranslation? I don't see it on https://www.mediawiki.org/wiki/Extension:ContentTranslation#Extension_dependencies ... [18:33:11] 10Continuous-Integration-Config, 10MediaWiki-extensions-ContentTranslation, 5ContentTranslation-Release6, 3LE-CX6-Sprint 2, 5Patch-For-Review: ContentTranslation is not running PHPUnit structure tests - https://phabricator.wikimedia.org/T109670#1558104 (10Legoktm) Tests enabled. Currently failing (https:... [19:19:21] Anyone know how to run foreachwikiindb for group1 wikis? [19:19:53] apparently Krenair may have tried to do that recently :) [19:20:47] group1.dblist uses a dblist expression right? [19:20:59] So you can't do that right now without using one of my open puppet repo patches [19:21:16] but you can make your own dblist locally [19:22:03] and then point foreachwikiindblist to that [19:22:24] by locally I mean, in your home directory or wherever, instead of needing to go via the ones in mediawiki-config.git [19:22:57] marxarelli: any idea what might have triggered this? https://phabricator.wikimedia.org/T109593 [19:25:35] Krenair: Cool. Yep. sort + comm ftw. Thanks! [19:27:10] tin:/home/krenair/group1.py should do the trick [19:41:46] legoktm: thanks for getting that patch about ContentTranslation merged. [19:41:47] now https://gerrit.wikimedia.org/r/#/c/232677/ fails [19:41:55] probably because of a missing dependency [19:42:18] https://integration.wikimedia.org/ci/job/mwext-testextension-zend/6817/console [19:42:30] ContentTranslation uses a Wikibase library [19:44:40] it now says in config/jjb/mediawiki-extensions.yaml dependencies: 'UniversalLanguageSelector,EventLogging' [19:44:47] I wonder how to add Wikibase there [19:46:11] thcipriani, greg-g ^ any idea? [19:46:22] I'd really love this issue not to block our development :) [19:53:05] Nikerabbit ^ FWIW [19:56:02] (03PS1) 10Amire80: Add Wikibase as a dependency for ContentTranslation [integration/config] - 10https://gerrit.wikimedia.org/r/232830 [19:57:22] https://gerrit.wikimedia.org/r/#/c/232830/ is a very naive attempt to fix it, and I'd be super-happy if it was reviewed ASAP, otherwise our team's work tomorrow will be blocked * greg-g thcipriani legoktm [19:58:50] (I'm slightly surprised that I cannot Wikibase as a dependency of any other extension... really, only ContentTranslation is dependent on it?) [19:59:06] [ cannot ^see^ Wikibase ] [20:00:20] so modern [20:00:59] :) [20:01:07] we also use Echo [20:01:19] and we might even use Gather in the near future [20:01:22] (or maybe not) [20:01:36] wow librarization [20:15:51] marxarelli: zeljkof-meeting ^ [20:17:03] legoktm: do you know if https://gerrit.wikimedia.org/r/#/c/232830/ is correct? [20:17:12] sorry to ping [20:22:43] 10Beta-Cluster, 6Release-Engineering, 10Wikimedia-Logstash, 5Patch-For-Review, 15User-Bd808-Test: Make logstash in beta public - https://phabricator.wikimedia.org/T76784#1558485 (10bd808) 5Open>3Resolved [20:24:19] It's not [20:24:28] Also Wikibase is extra special [20:24:43] wee [20:26:04] (03PS1) 10Legoktm: Add Wikidata as a dependency for ContentTranslation [integration/config] - 10https://gerrit.wikimedia.org/r/232837 (https://phabricator.wikimedia.org/T109670) [20:26:16] (03CR) 10Legoktm: [C: 032] Add Wikidata as a dependency for ContentTranslation [integration/config] - 10https://gerrit.wikimedia.org/r/232837 (https://phabricator.wikimedia.org/T109670) (owner: 10Legoktm) [20:27:36] (03CR) 10jenkins-bot: [V: 04-1] Add Wikidata as a dependency for ContentTranslation [integration/config] - 10https://gerrit.wikimedia.org/r/232837 (https://phabricator.wikimedia.org/T109670) (owner: 10Legoktm) [20:27:50] lolno [20:28:05] 20:26:09 ./zuul/ext_dependencies.py:9:80: E501 line too long (84 > 79 characters) [20:28:28] (03PS2) 10Legoktm: Add Wikidata as a dependency for ContentTranslation [integration/config] - 10https://gerrit.wikimedia.org/r/232837 (https://phabricator.wikimedia.org/T109670) [20:28:39] (03CR) 10Legoktm: [C: 032] Add Wikidata as a dependency for ContentTranslation [integration/config] - 10https://gerrit.wikimedia.org/r/232837 (https://phabricator.wikimedia.org/T109670) (owner: 10Legoktm) [20:30:14] (03Merged) 10jenkins-bot: Add Wikidata as a dependency for ContentTranslation [integration/config] - 10https://gerrit.wikimedia.org/r/232837 (https://phabricator.wikimedia.org/T109670) (owner: 10Legoktm) [20:30:37] !log deploying https://gerrit.wikimedia.org/r/232837 [20:31:38] https://integration.wikimedia.org/ci/job/mwext-testextension-zend/6833/console [20:33:36] aharoni: can you abandon your change so no one gets confused? thanks [20:34:08] (03Abandoned) 10Amire80: Add Wikibase as a dependency for ContentTranslation [integration/config] - 10https://gerrit.wikimedia.org/r/232830 (owner: 10Amire80) [20:37:03] OK, it also needs GuidedTours. [20:37:28] Meanwhile my internet has died.... [20:39:21] aharoni: and it also depends upon Echo? [20:40:19] legoktm: yes [20:40:42] (03PS1) 10Legoktm: ContentTranslation depends upon Echo & GuidedTour too [integration/config] - 10https://gerrit.wikimedia.org/r/232839 [20:40:59] (03CR) 10Legoktm: [C: 032] ContentTranslation depends upon Echo & GuidedTour too [integration/config] - 10https://gerrit.wikimedia.org/r/232839 (owner: 10Legoktm) [20:42:37] (03Merged) 10jenkins-bot: ContentTranslation depends upon Echo & GuidedTour too [integration/config] - 10https://gerrit.wikimedia.org/r/232839 (owner: 10Legoktm) [20:42:59] !log deploying https://gerrit.wikimedia.org/r/232839 [20:43:11] ugh, morebots is gone too [20:43:56] https://integration.wikimedia.org/ci/job/mwext-testextension-zend/6834/console [20:44:13] legoktm: https://tools.wmflabs.org/sal/releng works, though :) [20:45:01] heh [20:45:50] legoktm: is it all deployed? [20:46:25] waiting on the result of https://integration.wikimedia.org/ci/job/mwext-testextension-zend/6834/console [20:48:17] legoktm: looks over [20:48:25] woot [20:48:31] aharoni: everything should be good then :) [20:55:17] 10Browser-Tests, 10CirrusSearch, 6Discovery: Upgrade CirrusSearch browser tests to use mediawiki_selenium 1.x - https://phabricator.wikimedia.org/T99653#1558638 (10dduvall) a:3dduvall [20:57:05] ty legoktm [20:57:50] legoktm: greg-g : thanks a lot, everything works! [20:58:15] :) [20:58:16] 10Continuous-Integration-Config, 10MediaWiki-extensions-ContentTranslation, 5ContentTranslation-Release6, 3LE-CX6-Sprint 2, 5Patch-For-Review: ContentTranslation is not running PHPUnit structure tests - https://phabricator.wikimedia.org/T109670#1558643 (10Legoktm) 5Open>3Resolved And {313a8632076462b... [21:11:18] There is a special place in hell for people who stuff perfectly normalized data as json into as single database column [21:14:59] 6RelEng-Admin, 3Team-Practices-This-Week: Write up experiences from the RelEng workshop to share with team - https://phabricator.wikimedia.org/T101570#1558726 (10KLans_WMF) 5Open>3Resolved [21:19:41] bd808: I was trying to start a fresh vagrant, got an ugly ruby stacktrace [21:20:17] https://phabricator.wikimedia.org/P1911 [21:20:20] ugh. just now? We just merged a few plugin changes [21:20:39] shitballs [21:20:44] that's my stuff [21:20:53] This was just cloned from master < 5min ago [21:20:55] ostriches: which vagrant version? [21:21:06] 1.6.5 [21:21:13] *nod* blame marxarelli [21:21:16] :) [21:21:19] oh. right. there. in the trace [21:21:32] get 'em! [21:21:41] <_< >_> [21:21:51] #blame-together [21:21:58] oh, right [21:22:04] ostriches: you're fault i guess [21:22:10] *your* [21:22:19] #together! [21:22:54] so provisioner.type is new in 1.7.0? [21:23:00] apparently [21:23:04] ffs [21:23:04] Too old? I can upgrade. [21:23:13] 1.7.4 seems latest [21:23:30] If we bumped min version to 1.7.0 life would be nicer [21:23:40] dunno many distros that have that though [21:23:50] gawd ostriches [21:23:50] you need paladox to update your laptop [21:23:58] yeah, but we'd be less friendly to distro package people [21:24:15] lol [21:24:18] trusty has 1.4 [21:24:19] http://packages.ubuntu.com/trusty/vagrant [21:26:51] where does that vm.provisioners object even come from. Trying to find it to see what the older version did [21:27:04] lib/vagrant/plugin/v2/provisioner.rb [21:27:53] which doesn't appear to have changed since 1.6.5 [21:28:00] But that doesn't have a type attribute in master even... [21:28:22] yeah, you're right [21:28:29] * marxarelli hops into debugger [21:30:01] it gets passed into machine::initialize [21:30:04] upgraded vagrant helped [21:30:05] :p [21:30:39] wait, we have both foreachwikiindblist and mwscriptwikiset? [21:34:42] plugins/kernel_v2/config/vm_provisioner.rb [21:34:44] `git diff v1.6.5 v1.7.4 -- plugins/kernel_v2/config/vm_provisioner.rb` [21:34:48] :) [21:35:31] looks like it used to be "name"? [21:36:11] maybe [21:36:28] looks like `id` was changed to `name` [21:36:37] i'll have to try it with 1.7 too [21:37:18] * marxarelli curses people who go through the trouble to version an api but then break stuff within the same version number [21:37:39] "versioned" [21:37:54] try playing in Composer guts sometime for real fun [21:38:13] if it's anything like Bundler, i think i'll stay far far away [21:38:57] so something like "if it has a type use that otherwise use name" might work? [21:39:28] makes your pretty ruby look like my gross hacks again ;) [21:39:52] :( waa wa [21:40:05] `name` is nil in 1.7 [21:40:36] but yeah, `provisioner.name || provisioner.type` should work [21:40:45] let me check 1.4 ... [21:43:26] *stab stab stab* [21:43:42] querying escaped slashes in json in a sql column [21:43:54] \\\\\\\\ [21:45:57] "remote-uri":"https:\/\/gerrit.wikimedia.org\/r\/p\/mediawiki\/core" [21:46:10] Trying to query ^ [21:46:23] ew [21:46:59] ostriches: php? or python? [21:47:07] python makes this easier [21:47:08] Just from `mysql` for starters! [21:47:10] Eventually PHP [21:48:15] you could be lazish and drop in wildcards for the slashs [21:48:18] *es [21:48:48] %gerrit.wikimedia.org%r%p%mediawiki%core [21:48:54] I thought about that [21:49:26] if you are already mucking about in a blob column it might not make things worse [21:49:38] Sadly it's a little *too* fuzzy with all those %s [21:50:27] wikimediawikipedia [21:51:36] __gerrit.wikimedia.org__r__p__mediawiki__core then? [21:52:45] \\\/gerrit.wikimedia.org\\\/r\\\/p\\\/mediawiki\\\/core should work unless there is another round of string processing [21:53:03] in which case you have to \\\\\\/ [21:54:51] Yerp [21:54:53] select callsign from repository where details like '%\\\\\\/gerrit.wikimedia.org\\\\\\/r\\\\\\/p\\\\\\/mediawiki\\\\\\/core"%'; [21:54:58] Got me my 1 result I wanted [21:57:19] What a disgustingly ugly query [23:21:08] marxarelli: around now? [23:21:39] jdlrobson: yep [23:21:41] marxarelli: any ideas why https://gerrit.wikimedia.org/r/#/c/232827/ is necessary? [23:21:52] and also why the browser resize is not working (ignores height) [23:22:13] did we update the chrome driver for that build? [23:23:07] i feel like i've seen this issue before.. [23:23:38] the browser resize doesn't work because there's no window manager being used with xvfb [23:24:09] why did it work before? [23:24:30] i don't think it did [23:24:31] everything broke yesterday/tuesday night and we have been unable to merge stuff since :/ [23:24:44] it's a current limitation of the mw-selenium job [23:24:55] worked here > https://integration.wikimedia.org/ci/job/mwext-mw-selenium/391/console :) [23:25:17] i'm talking about the window resize [23:25:24] yeh but that test passes there [23:25:27] now it doesn't [23:25:29] i.e. it's probably unrelated to the failure [23:25:46] so something /must/ have happened somewhere [23:25:55] yeah, totally [23:26:12] one of a million moving browser test parts [23:26:14] :) [23:26:28] do you have any theories about which one :-/ [23:27:37] not at the moment, but i can take a look [23:28:18] hmm ok in mean time i'll skip it [23:28:54] did you repro it locally? [23:31:14] jdlrobson: ah, thanks for the task! i've been meaning to file it [23:31:29] marxarelli: nope not locally :/ [23:31:55] 6Release-Engineering, 10MobileFrontend: Chrome window resizes without height in @integration tests - toggling test fails - https://phabricator.wikimedia.org/T109794#1559342 (10Jdlrobson) [23:31:59] probably because mw-vagrant is so slow :/ [23:32:06] no need to sleep there [23:32:25] :S [23:33:41] jdlrobson: does mobile login use xhr or is it a normal form submission? [23:37:10] jdlrobson: can repro it locally w/ chrome [23:37:20] marxarelli: interesting which version of chrome driver? [23:37:34] marxarelli: the login issue i can replicate [23:37:34] 2.10.267517 [23:37:38] and the timeout fixes it [23:37:53] it should just be a normal form submission [23:38:06] it's you library though that runs login no? :) (mediawiki selenium) [23:38:40] not the "I am logged into the mobile website" step [23:38:43] that's in MF [23:39:16] but yeah, it calls `visit(LoginPage).login_with` which is in mw-selenium [23:40:47] * marxarelli hates shared cucumber steps [23:45:46] jdlrobson: the call to `login_with` in the mobile login step skips a wait on logout_element [23:45:49] which is fine [23:46:02] but you probably want to follow it up with something that's mobile specific [23:46:13] just so you can be certain that the login was successful [23:46:29] the timeout makes it login though.. i'm very confused :/ [23:46:37] it seems like it aborts before it finishes [23:46:43] a `sleep` suffices, but it's hacky [23:46:49] oh i see what you mean [23:47:23] i really don't know what the heck is happening but now i have a new failure - https://integration.wikimedia.org/ci/job/mwext-mw-selenium/419/console [23:47:30] usually webdriver waits until the page is fully loaded but that isn't happening for some reason [23:47:53] i'm not sure how i can test the login completes.. [23:48:00] maybe there's an xhr request followed by JS navigation maybe? [23:48:29] oh i know. 1min [23:50:49] `is-authenticated` on document.body? [23:52:10] marxarelli: i'm on it [23:52:21] marxarelli: on a general note though we need to better organise these changes [23:52:29] they grind the teams productivity to a halt.. [23:52:37] what changes? [23:52:41] we didn't change anything? [23:52:44] if we moved parts around that caused this to happen [23:52:49] s/\?// [23:52:51] the fact we don't know what caused this is concerning [23:53:47] in reference to "marxarelli> one of a million moving browser test parts" (in that they were all passing and now suddenly they are breaking and stopping merges and we don't know why) [23:54:10] i assume someone committed something somewhere and it had a knock on effect here... [23:54:30] possibly [23:54:40] we need qa for our qa heh [23:54:49] could have been in mw core, any of the MF dependencies, or in MF itself [23:55:05] but it wasn't mw-selenium or the jjb job, i can tell ya that [23:55:25] your version of mw-selenium is actually versioned and the dependency is clearly locked :) [23:57:05] so any theories on what's happened? [23:57:18] did we merge something which didn't run the test job properly and borked everything? [23:57:19] fwict, mediawiki doesn't have a dependency system [23:57:38] it doesn't [23:57:46] i just don't get it.. :-/ [23:58:49] ok i think i gotta fix for this login issue [23:59:20] i mean, you could try git bisect and running the scenario, just to rule out changes in MF