[00:18:23] 10Beta-Cluster, 7HHVM, 5Patch-For-Review: Upgrade Beta Cluster tmh* host(s) to HHVM and Trusty - https://phabricator.wikimedia.org/T110707#1618831 (10bd808) Still waiting on a merge of https://gerrit.wikimedia.org/r/#/c/234699/ (Use backported ffmpeg for multimedia transcoding on Trusty). It was declined for... [00:22:52] 10Beta-Cluster: Parser cache (memcached?) broken in Beta Cluster - https://phabricator.wikimedia.org/T91310#1618841 (10Tgr) Can't reproduce anymore. [00:33:48] 10Beta-Cluster, 10QuickSurveys, 5Patch-For-Review, 3Reading-Web-Sprint-55-π: Get QuickSurveys enabled on beta cluster - https://phabricator.wikimedia.org/T110199#1618864 (10Jdlrobson) Confirmed working on: http://en.m.wikipedia.beta.wmflabs.org/wiki/Alcatraz_Island?quicksurvey=true http://en.m.wikipedia.be... [00:33:54] 10Beta-Cluster, 10QuickSurveys, 5Patch-For-Review, 3Reading-Web-Sprint-55-π: Get QuickSurveys enabled on beta cluster - https://phabricator.wikimedia.org/T110199#1618866 (10Jdlrobson) 5Open>3Resolved [00:40:03] 10Beta-Cluster, 10MediaWiki-extensions-OAuth, 10Pywikibot-OAuth, 7Pywikibot-network, 7Pywikibot-tests: "Nonce already used" regularly occurring on beta cluster - https://phabricator.wikimedia.org/T109173#1618894 (10Tgr) [[ https://graphite.wmflabs.org/render/?width=1500&height=1000&_salt=1441758892.639&f... [00:55:38] PROBLEM - Puppet staleness on integration-dev is CRITICAL 100.00% of data above the critical threshold [43200.0] [00:59:11] 10Gitblit-Deprecate, 6Release-Engineering: redirect gerrit repo paths to diffusion callsigns - https://phabricator.wikimedia.org/T110607#1618934 (10Spage) >>! In T110607#1614835, @hashar wrote: > What about having the Phabfile template to use the callsign? It is more or less meant to be an immutable human fr... [01:28:43] 10Gitblit-Deprecate, 6Release-Engineering: Diffusion replacement for tarfile download from git.wikimedia.org - https://phabricator.wikimedia.org/T111887#1618980 (10Spage) 3NEW [01:30:57] 10Gitblit-Deprecate, 6Release-Engineering: Update mediawiki.org templates to link to Diffusion, not gitblit - https://phabricator.wikimedia.org/T108864#1618987 (10Spage) I think this may also be blocked by mw.org extension pages' use of gitblit's "download a tarfile" functionality ({T111887}). [01:40:47] 10Gitblit-Deprecate, 6Release-Engineering: Diffusion replacement for tarfile download from git.wikimedia.org - https://phabricator.wikimedia.org/T111887#1619013 (10Legoktm) If these are extensions, can we link to ExtensionDistributor? [03:53:53] 10Deployment-Systems, 7Documentation: Jenkins-mwext-sync needs documentation - https://phabricator.wikimedia.org/T62793#1619271 (10Liuxinyu970226) [04:37:27] Yippee, build fixed! [04:37:27] Project browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-windows_7-internet_explorer-9-sauce build #556: FIXED in 45 min: https://integration.wikimedia.org/ci/job/browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-windows_7-internet_explorer-9-sauce/556/ [06:37:23] RECOVERY - Free space - all mounts on deployment-bastion is OK All targets OK [07:38:09] 10Continuous-Integration-Infrastructure, 6Discovery, 6operations, 7Blocked-on-Operations, 7Elasticsearch: Please backport ElasticSearch 1.7.x from wikimedia-trusty to wikimedia-precise for CI needs - https://phabricator.wikimedia.org/T111781#1619653 (10MoritzMuehlenhoff) a:3MoritzMuehlenhoff [07:56:04] 10Beta-Cluster, 10MediaWiki-extensions-OAuth, 10Pywikibot-OAuth, 7Pywikibot-network, 7Pywikibot-tests: "Nonce already used" regularly occurring on beta cluster - https://phabricator.wikimedia.org/T109173#1619707 (10jayvdb) [08:09:44] 10Browser-Tests, 10Continuous-Integration-Config, 10Wikidata: fix negative argument (ArgumentError) in browsertests - https://phabricator.wikimedia.org/T110510#1619746 (10zeljkofilipin) [08:12:16] 10Continuous-Integration-Infrastructure, 6Discovery, 6operations, 7Elasticsearch, 5Patch-For-Review: elasticsearch 1.6.0 fails to start after reboot - https://phabricator.wikimedia.org/T109497#1619752 (10MoritzMuehlenhoff) [08:12:19] 10Continuous-Integration-Infrastructure, 6Discovery, 6operations, 7Blocked-on-Operations, 7Elasticsearch: Please backport ElasticSearch 1.7.x from wikimedia-trusty to wikimedia-precise for CI needs - https://phabricator.wikimedia.org/T111781#1619750 (10MoritzMuehlenhoff) 5Open>3Resolved elasticsearch... [08:16:16] 10Continuous-Integration-Infrastructure, 6Discovery, 6operations, 7Blocked-on-Operations, 7Elasticsearch: Please backport ElasticSearch 1.7.x from wikimedia-trusty to wikimedia-precise for CI needs - https://phabricator.wikimedia.org/T111781#1619767 (10hashar) Thank you very much, will get it upgraded on... [08:20:50] !log attempting to git deploy integration/config from tin [08:20:54] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL, Master [08:27:07] !log upgraded elastic search from 1.6.0 to 1.7.1 on Jenkins Precise slaves https://phabricator.wikimedia.org/T109497 [08:27:10] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL, Master [08:27:27] 10Continuous-Integration-Infrastructure, 6Discovery, 6operations, 7Elasticsearch, 5Patch-For-Review: elasticsearch 1.6.0 fails to start after reboot - https://phabricator.wikimedia.org/T109497#1619800 (10hashar) Upgraded them: ``` root@integration-saltmaster:~# salt '*precise*' pkg.install elasticsearch... [08:28:13] !log rebooting integration-slave-precise-1014 to see whether elasticsearch runs properly https://phabricator.wikimedia.org/T109497 [08:28:16] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL, Master [08:31:22] !log removed cherry pick https://gerrit.wikimedia.org/r/#/c/233413/ "elasticsearch: ensure /var/run subdir exists" from integration puppetmaster https://phabricator.wikimedia.org/T109497 [08:31:26] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL, Master [08:33:55] 10Continuous-Integration-Infrastructure, 6Discovery, 6operations, 7Elasticsearch, 5Patch-For-Review: elasticsearch 1.6.0 fails to start after reboot - https://phabricator.wikimedia.org/T109497#1619815 (10hashar) I have rebooted integration-slave-precise1014 and it came back. Then I removed the Gerrit ch... [08:35:07] 10Continuous-Integration-Infrastructure, 6Discovery, 6operations, 7Elasticsearch, 5Patch-For-Review: elasticsearch 1.6.0 fails to start after reboot - https://phabricator.wikimedia.org/T109497#1619823 (10hashar) 5Open>3Resolved a:3hashar Actually ElasticSearch is started and the machines reboot jus... [08:47:07] is it not possible to run individual extensions' unit tests in isolation? [08:47:24] * twentyafterfour has been trying to reproduce phpunit error for a while now and I can't get the tests to run [08:47:44] (that is, trying to run them locally. I would think that would be trivial but apparently it isn't) [08:48:05] 10Beta-Cluster, 10MediaWiki-extensions-OAuth, 10Pywikibot-OAuth, 7Pywikibot-network, 7Pywikibot-tests: "Nonce already used" regularly occurring on beta cluster - https://phabricator.wikimedia.org/T109173#1619880 (10jayvdb) @Tgr, I am not sure what we can or should do to help, but if you can give us some... [08:50:09] 10Browser-Tests, 10Continuous-Integration-Config, 10Wikidata: fix negative argument (ArgumentError) in browsertests - https://phabricator.wikimedia.org/T110510#1619886 (10hashar) Looking at the indent method: ``` lang=ruby p re p indent_string p amount p indent_string * amount ``` ``` 08:47:59 And... [08:51:07] 10Browser-Tests, 10Continuous-Integration-Config, 10Wikidata: fix negative argument (ArgumentError) in browsertests - https://phabricator.wikimedia.org/T110510#1619890 (10hashar) ``` $ irb irb(main):001:0> p "x" * 2 "xx" => "xx" irb(main):002:0> p "x" * -2 ArgumentError: negative argument from (irb):2:in `... [09:21:04] 10Browser-Tests, 10Continuous-Integration-Config, 10Wikidata: fix negative argument (ArgumentError) in browsertests - https://phabricator.wikimedia.org/T110510#1619943 (10hashar) We attempted to debug it on the Jenkins slave itself but could not find why the source_indent would end up yelling -2 :-( [09:25:09] Project browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-os_x_10.9-safari-sauce build #716: FAILURE in 1 hr 15 min: https://integration.wikimedia.org/ci/job/browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-os_x_10.9-safari-sauce/716/ [09:28:52] 5Continuous-Integration-Scaling, 10Deployment-Systems, 6Labs, 10Labs-Infrastructure, 10Salt: Can not use git-deploy from tin.eqiad.wmnet to labnodepool1001.eqiad.wmnet - https://phabricator.wikimedia.org/T111925#1619993 (10hashar) 3NEW [10:05:27] 10Gitblit-Deprecate, 6Phabricator: Diffusion replacement for tarfile download from git.wikimedia.org - https://phabricator.wikimedia.org/T111887#1620080 (10hashar) [10:05:47] PROBLEM - Puppet staleness on deployment-eventlogging02 is CRITICAL 10.00% of data above the critical threshold [43200.0] [10:06:06] 10Gitblit-Deprecate, 6Phabricator: Diffusion replacement for tarfile download from git.wikimedia.org - https://phabricator.wikimedia.org/T111887#1620087 (10hashar) Moved out of #releng since it is already in our project #gitblit-deprecate. Added #phabricator since the request is related to Diffusion. [10:39:06] 10Continuous-Integration-Infrastructure, 10Ops-Access-Requests, 6operations, 5Patch-For-Review: Let contint-admins force run puppet with /usr/local/sbin/puppet-run - https://phabricator.wikimedia.org/T110943#1620139 (10hashar) Apparently the ops meeting ran out of time. So should be talked about again in t... [10:51:06] (03PS14) 10Hashar: dib: wikimedia-puppet element [integration/config] - 10https://gerrit.wikimedia.org/r/234975 (https://phabricator.wikimedia.org/T110735) [11:46:52] 10Gerrit-Migration, 10Gitblit-Deprecate, 3releng-201516-q1: Allow cloning of Phabricator hosted git repositories - https://phabricator.wikimedia.org/T128#1620386 (10mmodell) [11:47:39] 10Gerrit-Migration, 10Gitblit-Deprecate, 3releng-201516-q1: Allow cloning of Phabricator hosted git repositories - https://phabricator.wikimedia.org/T128#1844 (10mmodell) Current status: cloning over https works but ssh is blocked by {T100519} [13:13:42] 10Continuous-Integration-Infrastructure, 10Wikidata: Intermittent qunit failures (MessageBlobStore::insertMessageBlob failed, database locked during setup) - https://phabricator.wikimedia.org/T111530#1620549 (10JanZerebecki) Maybe this would be fixed by T90001? [13:16:32] (03CR) 1020after4: "I can't quite understand how it would be caused by ipv6 myself. It specifically happens with the sync-dir and sync-file subcommands, but n" [tools/scap] - 10https://gerrit.wikimedia.org/r/234687 (owner: 10BryanDavis) [13:16:42] 10Continuous-Integration-Infrastructure, 10Wikidata: Intermittent qunit failures (MessageBlobStore::insertMessageBlob failed, database locked during setup) - https://phabricator.wikimedia.org/T111530#1620551 (10JanZerebecki) [13:18:01] andrewbogott: good morning :-) [13:18:20] ‘morning! [13:18:21] sorry, I really thought we could use trebuchet from tin to reach out labnodepool1001 :/ [13:18:44] I’m only here for about 2 minutes but will be back a bit later. [13:21:00] take time for your breakfast :} [13:21:10] myself having a pairing session with tyler in roughly 40 mins [13:46:12] PROBLEM - Host mira is DOWN: CRITICAL - Host Unreachable (10.68.17.215) [13:50:24] (03PS15) 10Hashar: dib: wikimedia-puppet element [integration/config] - 10https://gerrit.wikimedia.org/r/234975 (https://phabricator.wikimedia.org/T110735) [14:06:30] yo yo yo [14:06:58] can we stagger the results of various build jobs? [14:07:01] f'rinstance [14:07:22] the gather extension has linters and unit tests that run in ~2 minutes [14:07:30] and browser tests that run in 10 minutes [14:07:53] i'd like the results of the linters and unit tests to show up asap [14:08:01] quick feedback is awesome [14:20:56] hashar: beta appears stuck when trying to update [14:20:58] https://integration.wikimedia.org/ci/job/beta-scap-eqiad/ [14:21:18] i am not sure how to fix [14:22:49] i could try to cancel and then click rebuild last [14:24:35] * aude tries [14:24:38] Project beta-update-databases-eqiad build #2802: FAILURE in 0.83 sec: https://integration.wikimedia.org/ci/job/beta-update-databases-eqiad/2802/ [14:24:54] it's going.... [14:25:44] hashar: is nodepool acting like you’d expect now? [14:25:53] Project beta-code-update-eqiad build #71635: FAILURE in 1 min 15 sec: https://integration.wikimedia.org/ci/job/beta-code-update-eqiad/71635/ [14:26:22] local changes in dumpInterwiki? [14:29:15] !log stashed local changes to dumpInterwiki in WikimediaMaintenance on deployment-bastion [14:29:19] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL, Master [14:46:12] Yippee, build fixed! [14:46:13] Project beta-code-update-eqiad build #71636: FIXED in 1 min 2 sec: https://integration.wikimedia.org/ci/job/beta-code-update-eqiad/71636/ [14:58:40] PROBLEM - Puppet failure on deployment-stream is CRITICAL 50.00% of data above the critical threshold [0.0] [15:00:54] andrewbogott: the puppet patches unlocked nodepool ! [15:01:06] andrewbogott: it is broken though but for some other reason I need to figure out [15:01:08] thanks!!!!!! [15:11:43] 10Gerrit-Migration, 6Engineering-Community, 3ECT-October-2015: How to prioritize code review of patches submitted by volunteers - https://phabricator.wikimedia.org/T78768#1620824 (10greg) (not a blocker for Gerrit migration to Differential) [15:13:15] 10Gerrit-Migration, 10Security-Reviews: Arcanist needs a security review before being deployed to the Wikimedia cluster - https://phabricator.wikimedia.org/T613#1620840 (10greg) p:5Low>3Normal [15:13:41] 10Continuous-Integration-Config, 7I18n: Configure banana checker for i18n files to run on all MediaWiki extensions (tracking) - https://phabricator.wikimedia.org/T94547#1166201 (10Prtksxna) [15:17:14] 10Gerrit-Migration: Review holders of commit rights in WMF deployed extensions - https://phabricator.wikimedia.org/T262#1620866 (10greg) p:5Low>3Lowest The point of this task was to use the "moment in time" during the migration to review +2 holders. My point of view: If it is important to do a review of who... [15:18:42] 10Differential, 10Gerrit-Migration, 15User-greg: Write draft "business case" for migration from Gerrit to Differential - https://phabricator.wikimedia.org/T111250#1620869 (10greg) [15:18:44] 10Continuous-Integration-Infrastructure, 10Differential, 10Gerrit-Migration, 3releng-201516-q1: Prototype CI integration with Differential - https://phabricator.wikimedia.org/T103127#1620868 (10greg) [15:18:46] 10Differential, 10Gerrit-Migration: You should be able to merge your own patches - https://phabricator.wikimedia.org/T99905#1620870 (10greg) [15:18:49] 10Differential, 10Gerrit-Migration, 6translatewiki.net, 7I18n: Train L10n-bot to work with Differential in Wikimedia Phabricator - https://phabricator.wikimedia.org/T92493#1620871 (10greg) [15:18:51] 10Differential, 10Gerrit-Migration: Phabricator and Arcanist versions must be kept in sync because of occasional breaking api changes between phabricator versions. - https://phabricator.wikimedia.org/T91422#1620872 (10greg) [15:18:53] 10Differential, 10Gerrit-Migration, 10Gitblit-Deprecate: GitHub->Phabricator import system - https://phabricator.wikimedia.org/T715#1620873 (10greg) [15:19:04] sorry for the spam, heh, killed wikibugs [15:19:07] 10Differential, 10Gerrit-Migration: Arc does not allow to land a commit from a local master branch that is ahead of the remote's master onto the remote's master - https://phabricator.wikimedia.org/T134#1620893 (10greg) [15:19:08] 10Differential, 10Gerrit-Migration: Find way to use Differential with plain git (i.e.: without requiring arc) - https://phabricator.wikimedia.org/T127#1620894 (10greg) [15:19:10] 10Differential, 10Gerrit-Migration: Running `arc diff` twice on the same commit creates another redundant diff within the same differential - https://phabricator.wikimedia.org/T137#1620892 (10greg) [15:19:12] 10Continuous-Integration-Infrastructure, 10Differential, 10Gerrit-Migration: Connect Differential code review with continuous integration - https://phabricator.wikimedia.org/T31#1620896 (10greg) [15:21:03] Yippee, build fixed! [15:21:04] Project beta-update-databases-eqiad build #2803: FIXED in 1 min 2 sec: https://integration.wikimedia.org/ci/job/beta-update-databases-eqiad/2803/ [15:24:09] thcipriani: the crazy sudo nodepool madness I had might be solved by https://gerrit.wikimedia.org/r/#/c/234483/ :D [15:24:19] become-nodepool ! [15:28:42] 10Differential, 10Gerrit-Migration, 10Gitblit-Deprecate: GitHub->Phabricator import system - https://phabricator.wikimedia.org/T715#1620922 (10greg) Just to be clear: The goal of this task is to import GH repos (and GH issues, maybe) to be used in Differential for code-review, right? (And also viewable throu... [15:28:55] 10Differential, 6Phabricator: GitHub->Phabricator import system - https://phabricator.wikimedia.org/T715#1620923 (10greg) [15:30:08] andrewbogott: I think I will get the nodepool.yaml configuration file out of puppet [15:30:21] andrewbogott: going to be rather painful to funnel all requests via ops +2 :D [15:31:48] 10Differential, 10Gerrit-Migration: Editing files and contributing changes via web - https://phabricator.wikimedia.org/T409#1620934 (10greg) >>! In T409#1268598, @JanZerebecki wrote: > According to T65847#1268528 this is something that is supported in gerrit 2.11. The current version (as of today) of our Gerr... [15:31:56] 10Differential: Editing files and contributing changes via web - https://phabricator.wikimedia.org/T409#1620935 (10greg) [15:33:42] RECOVERY - Puppet failure on deployment-stream is OK Less than 1.00% above the threshold [0.0] [15:39:23] 10Differential, 6Phabricator: GitHub->Phabricator import system - https://phabricator.wikimedia.org/T715#1620987 (10JanZerebecki) Yes not a blocker for #Gerrit-Migration. I think this task was about migrating projects from github to whatever Wikimedia uses. Now being able to use Differential to review commits... [15:56:43] 10Differential: Editing files and contributing changes via web - https://phabricator.wikimedia.org/T409#1621062 (10JanZerebecki) Having that feature in a released version we could upgrade to is something we lose. So technically it would be blocker. :) But for me personally there are more important things in a gi... [15:57:33] 10Differential, 10Gerrit-Migration, 10Security-Reviews: Arcanist needs a security review before being deployed to the Wikimedia cluster - https://phabricator.wikimedia.org/T613#1621066 (10csteipp) What is the timeline for this? [16:03:15] PROBLEM - Puppet failure on integration-slave-jessie-1001 is CRITICAL 100.00% of data above the critical threshold [0.0] [16:03:15] PROBLEM - Puppet failure on deployment-mx is CRITICAL 100.00% of data above the critical threshold [0.0] [16:03:15] PROBLEM - Puppet failure on deployment-parsoidcache02 is CRITICAL 100.00% of data above the critical threshold [0.0] [16:11:10] 10Differential, 10Gerrit-Migration, 10Security-Reviews: Arcanist security review (before being used in WMF deployments) - https://phabricator.wikimedia.org/T613#1621124 (10greg) [16:11:57] 10Differential, 10Gerrit-Migration, 10Security-Reviews: Arcanist security review (before being used in WMF deployments) - https://phabricator.wikimedia.org/T613#10132 (10greg) >>! In T613#1621066, @csteipp wrote: > What is the timeline for this? @mmodell: We probably won't use arcanist on tin.wmnet with our... [16:13:42] PROBLEM - Puppet staleness on deployment-restbase01 is CRITICAL 100.00% of data above the critical threshold [43200.0] [16:16:37] 10Differential, 10Gerrit-Migration, 10Security-Reviews: Arcanist security review (before being used in WMF deployments) - https://phabricator.wikimedia.org/T613#1621147 (10mmodell) Implementing differential does not necessitate that we use arc for deployments. Or, what @greg said. [16:19:17] 10Differential, 10Gerrit-Migration, 10Security-Reviews: Arcanist security review (before being used in WMF deployments) - https://phabricator.wikimedia.org/T613#1621164 (10greg) p:5Normal>3Lowest Changing priority accordingly (and removing the Gerrit-Migration project since this (being able to use arcani... [16:19:27] 10Differential, 10Security-Reviews: Arcanist security review (before being used in WMF deployments) - https://phabricator.wikimedia.org/T613#1621166 (10greg) [16:27:31] 10Differential, 10Security-Reviews: Arcanist security review (before being used in WMF deployments) - https://phabricator.wikimedia.org/T613#1621214 (10JanZerebecki) The copy of arcanist we use will always need to be in sync with the phabricator HEAD we use on phabricator.w.o at the time. Will each update of o... [16:27:39] (03PS1) 10Niedzielski: Remove quiet option on Android tests [integration/config] - 10https://gerrit.wikimedia.org/r/237133 [16:30:22] (03PS1) 10Paladox: Add jenkings test for DeletePagesForGood [integration/config] - 10https://gerrit.wikimedia.org/r/237138 [16:31:05] (03CR) 10Mholloway: [C: 031] Remove quiet option on Android tests [integration/config] - 10https://gerrit.wikimedia.org/r/237133 (owner: 10Niedzielski) [16:31:09] (03CR) 10Paladox: "This can be reviewed because it depends on no patch." [integration/config] - 10https://gerrit.wikimedia.org/r/237138 (owner: 10Paladox) [16:32:31] 10Differential, 10Security-Reviews: Arcanist security review (before being used in WMF deployments) - https://phabricator.wikimedia.org/T613#1621248 (10greg) >>! In T613#1621214, @JanZerebecki wrote: > The copy of arcanist we use will always need to be in sync with the phabricator HEAD we use on phabricator.w.... [16:36:37] greg-g: so if I understand that right i will need to use arc to submit patches, on the same machine as my production key, before we trust it enough to run it in this same production? [16:37:46] jzerebecki: we don't do security reviews of pidgin or firefox or whatever else is on your local machine that has your prod keys [16:37:52] it's a red herring [16:38:00] or git-review [16:38:14] or git itself [16:38:18] heh, touche [16:39:07] I don't know if they review some ssh client version or not, but I'm pretty sure they don't review every version in use on all machines with some sort of production key [16:39:37] 10Deployment-Systems, 3Scap3, 5Patch-For-Review: Scap3 should support rollback - https://phabricator.wikimedia.org/T109514#1621259 (10dduvall) [16:39:46] 10Deployment-Systems, 3Scap3, 5Patch-For-Review: Scap3 should support rollback - https://phabricator.wikimedia.org/T109514#1621265 (10thcipriani) [16:39:47] 10Deployment-Systems, 3Scap3: Scap3 should be able to deploy/rollback service config as part of deploy - https://phabricator.wikimedia.org/T109512#1621264 (10thcipriani) [16:45:40] andrewbogott: so nodepool is misconfigured and can't ssh to instances. So it keeps spawning some over and over which might overload labs [16:45:55] greg-g: those are signed by debian people [16:46:01] andrewbogott: I think the safest is to shutdown nodepool for now :-) might do with: ssh root@labnodepool1001.eqiad.wmnet systemctl stop nodepool [16:46:13] hashar_: won’t puppet restart it? [16:46:20] good point [16:46:22] let me check [16:46:49] andrewbogott: the base::service_unit has ensure => present [16:46:54] not sure if it actually put it back [16:48:17] * hashar_ digs in modules/wmflib/lib/puppet/parser/functions/ensure_service.rb [16:48:18] greg-g: i don't usually curl random.com | bash even though most people do [16:48:52] hashar_: yeah, puppet restart it [16:48:58] andrewbogott: so our ensure_service() method translates present to running. And yeah puppet would thus restart it I guess :-/ [16:49:03] that is lame [16:49:37] hashar_: I’m in the middle of an upgrade — I can disable puppet on that box or you can write a patch [16:49:48] andrewbogott: disabling puppet would do I guess [16:49:51] and stopping nodepool [16:49:55] will catch up tomorrow [16:49:58] sorry :( [16:50:50] jzerebecki: I think this issue is really "do what we do with git-review" and since we haven't internally reviewed git-review (we trust upstream) then we don't need to review Arcanist. I'll let chris chime in if he disagress though, of course :) [16:56:13] 10Differential, 10Security-Reviews: Arcanist security review (before being used in WMF deployments) - https://phabricator.wikimedia.org/T613#1621302 (10greg) Just keeping this task filled with the discussion from IRC: ``` 16:36 < jzerebeck> greg-g: so if I understand that right i will need to use arc to submi... [16:58:04] 10Beta-Cluster: Parser cache (memcached?) broken in Beta Cluster - https://phabricator.wikimedia.org/T91310#1621305 (10greg) 5Open>3Resolved [16:59:50] 10Differential, 6Phabricator: GitHub->Phabricator import system - https://phabricator.wikimedia.org/T715#1621333 (10Qgil) >>! In T715#1620922, @greg wrote: > (and GH issues, maybe) GitHub issues are a different story. I think I remember someone sharing some script for that in Phabricator upstream. [17:01:55] 10Differential, 6Phabricator: GitHub -> Differential import system - https://phabricator.wikimedia.org/T715#1621337 (10greg) [17:02:41] 10Differential, 6Phabricator: GitHub -> Differential import system - https://phabricator.wikimedia.org/T715#12096 (10greg) [17:03:13] 10Gerrit-Migration: Review holders of commit rights in WMF deployed extensions - https://phabricator.wikimedia.org/T262#1621351 (10Qgil) You created this task, so I guess you know where it comes from. :) My first question would be: do we have an actual problem with the current holders of commit rights? I'm not... [17:08:51] 10Gerrit-Migration: Review holders of commit rights in WMF deployed extensions - https://phabricator.wikimedia.org/T262#1621372 (10Krenair) I have a problem with ldap/wmf implicitly granting +2 rights in various places that it should not (there's a separate task for this). Hopefully that won't be possible with D... [17:11:21] 6Release-Engineering, 7Tracking: Update repositories that use mediawiki_selenium Ruby gem 1.x - https://phabricator.wikimedia.org/T94083#1621380 (10zeljkofilipin) [17:12:34] 10Gerrit-Migration: Review holders of commit rights in WMF deployed extensions - https://phabricator.wikimedia.org/T262#1621385 (10greg) >>! In T262#1621351, @Qgil wrote: > You created this task, so I guess you know where it comes from. :) 'twas a meeting that @Robla-WMF, myself, and Summana were in, but I for... [17:14:49] 10Gitblit-Deprecate, 6Phabricator: Diffusion replacement for tarfile download from git.wikimedia.org - https://phabricator.wikimedia.org/T111887#1621411 (10greg) >>! In T111887#1619013, @Legoktm wrote: > If these are extensions, can we link to ExtensionDistributor? I don't see why not. Does that cover all of... [17:17:20] 10Continuous-Integration-Infrastructure, 6Release-Engineering, 5Patch-For-Review: Repositories with Ruby code should be documented and appropriate Jenkins jobs should be running - https://phabricator.wikimedia.org/T1361#1621418 (10zeljkofilipin) a:3zeljkofilipin [17:18:38] 10Continuous-Integration-Infrastructure, 6Release-Engineering, 5Patch-For-Review: Repositories with Ruby code should be documented and appropriate Jenkins jobs should be running - https://phabricator.wikimedia.org/T1361#23935 (10zeljkofilipin) [17:27:03] 6RelEng-Admin, 15User-greg: Setup meeting with $people to discuss code hosting exception policy - https://phabricator.wikimedia.org/T109657#1621459 (10greg) Current list, after talking with Mark: * Brian G * Brion V * Bryan D * Daniel K * Gabriel * Chad * Faidon * Me [17:27:23] whee [17:30:53] 10Gitblit-Deprecate, 10Diffusion: URL to download tar/zip for each git commit/tag/branch - https://phabricator.wikimedia.org/T91429#1621483 (10greg) [17:30:55] 10Gitblit-Deprecate, 6Release-Engineering, 10Diffusion: Update mediawiki.org templates to link to Diffusion, not gitblit - https://phabricator.wikimedia.org/T108864#1621481 (10greg) [17:31:08] heh, I killed wikibugs again with my batch edits :) [17:41:50] 10Differential, 10Gerrit-Migration: GitHub->Phabricator bridge for new contributors - https://phabricator.wikimedia.org/T173#1621540 (10greg) Same reasoning from T715: >>! In T715#1620922, @greg wrote: > > ... this is a new feature (not something we have with Gerrit now) and thus not a blocker for the Gerrit... [17:42:28] 10Differential, 10Gerrit-Migration: GitHub -> Differential bridge for new contributors - https://phabricator.wikimedia.org/T173#1621544 (10greg) [17:42:37] 10Differential: GitHub -> Differential bridge for new contributors - https://phabricator.wikimedia.org/T173#2326 (10greg) [17:43:07] brion: sorry for the ping (and again) :) [17:43:29] :) [17:49:55] 10Differential, 10Diffusion: Support full text url instead of random names for url - https://phabricator.wikimedia.org/T111947#1621573 (10greg) [18:14:56] !log restarted nutcracker on mediawiki02 [18:14:59] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL, Master [19:08:57] (03CR) 10Polybuildr: "Bump." [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/228993 (owner: 10Legoktm) [19:30:00] greg-g: Tah-dah: https://www.mediawiki.org/wiki/MediaWiki_1.27/Roadmap [19:33:10] James_F: ty! :) [19:33:27] * James_F dislikes redlinks. ;-) [19:46:43] bd808: remind me to buy you $beverage of your choice for signing composer-merge-plulgin tags with your 4k key! [19:47:07] :) [19:48:48] 6Release-Engineering, 3Team-Practices-This-Week, 5Testing Initiative 2015: Talk to Greg and Arthur about Onboarding's role in establishing good testing practices/habits - https://phabricator.wikimedia.org/T108121#1622169 (10ggellerman) [19:51:39] addshore: How come you unsubscribed from the static analysis task? :o [20:05:12] James_F: https://www.mediawiki.org/w/index.php?title=MediaWiki_1.27%2FRoadmap&type=revision&diff=1878346&oldid=1878336 [20:05:26] :P [20:09:06] polybuildr: I'll look later today [20:09:37] polybuildr: I would feel a lot more confident if we had tests for this stuff :/ https://phabricator.wikimedia.org/T108458 [20:10:49] legoktm: hmm. [20:11:08] I'll merge it without tests, but it just means I need to do more manual testing :| [20:11:09] legoktm: also, what's with addshore unsubscribing/unclaiming all codesniffer tasks? [20:11:19] yeah, that's a pain. [20:11:25] he's busy :(((((( [20:11:41] ouch. so, retiring from active codesniffer development/review? :o [20:12:50] we probably just need to nag him harder [20:13:36] haha :D [20:13:42] new patch coming up btw. [20:13:47] (03PS1) 10Polybuildr: Add ignore list to PrefixedGlobalFunctionsSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/237247 (https://phabricator.wikimedia.org/T104501) [20:13:59] legoktm: feel free to review. :P [20:15:07] (03CR) 10Legoktm: "Is there a way we can make this list configurable in phpcs.xml instead of hardcoding it?" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/237247 (https://phabricator.wikimedia.org/T104501) (owner: 10Polybuildr) [20:15:43] (03CR) 10Polybuildr: "Good idea! Looking into it." [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/237247 (https://phabricator.wikimedia.org/T104501) (owner: 10Polybuildr) [20:17:07] 10Differential, 10Security-Reviews: Arcanist security review (before being used in WMF deployments) - https://phabricator.wikimedia.org/T613#1622313 (10JanZerebecki) I'm not saying don't trust upstream Arc. We trust Debian. What we can do with Debian packages, we should also do with PHP code. We should also ha... [20:20:32] 10Differential, 10Security-Reviews: Arcanist security review (before being used in WMF deployments) - https://phabricator.wikimedia.org/T613#1622320 (10Legoktm) For the record, git-review isn't installed on tin. Deployers use pure git to push to gerrit. [20:22:26] legoktm: Meh. :-) [20:23:34] I tried to follow the link and got very confused :P [20:25:37] 5Continuous-Integration-Scaling, 6Labs, 10Labs-Infrastructure: curl http://169.254.169.254/latest/meta-data/public-keys/ is unavailable - https://phabricator.wikimedia.org/T112001#1622352 (10hashar) 3NEW [20:31:11] legoktm: have a minute? [20:32:36] legoktm: okay, figured it out. [20:34:49] polybuildr: I don't, but what's up? :P [20:35:18] legoktm: was having trouble with passing parameters to a sniff, but now that's done. Issue is, how do we define value= [20:35:36] I'm trying to see if I can break up the XML and add child elements/tags with values in it, but haven't got there so far. [20:35:52] polybuildr: can you use newlines as a delimiter? [20:36:04] legoktm: well, I could even use commas [20:36:10] proper xml would be ideal but... [20:36:38] If I can find out how to set values using child elements of , then cool. [20:36:40] If not, though. [20:39:06] legoktm: ha. reading source to figure out how to use a library. :P https://github.com/squizlabs/PHP_CodeSniffer/blob/738a277586/CodeSniffer.php#L1166-L1180 [20:39:19] It allows for type="array" and then value="a,b,c" [20:39:24] there's another syntax in the source.. [20:39:28] trying to reverse engineer. :P [20:39:44] legoktm: oh, right. associate arrays. [20:39:52] *associative [20:39:57] [20:40:09] * legoktm grumbles about https://github.com/squizlabs/PHP_CodeSniffer/pull/669 [20:41:02] * polybuildr offers legoktm a hot beverage [20:48:11] legoktm: So, it's doable using that type="array" syntax and then a really long string as the value="". Does that make sense? [20:48:58] polybuildr: so it's comma separated? [20:49:03] legoktm: yeah. [20:49:15] with no => crap right? [20:49:22] its just a list not associative [20:49:22] phpcs handles that for us, and gives us an array in the sniff [20:49:27] ok [20:49:29] that's our choice, but yeah, we'll use just a list [20:49:30] sounds good to me :D [20:49:43] if we test xml for line lengths, this will fail though. :P [20:50:05] also, this means that all extensions will have to copy core's phpcs.xml to get these extra rules, right? [20:50:25] legoktm: ^ [20:50:55] (03CR) 10Polybuildr: [C: 04-1] "Good idea to read from phpcs.xml." [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/237247 (https://phabricator.wikimedia.org/T104501) (owner: 10Polybuildr) [20:50:56] polybuildr: but extensions shouldn't be creating global functions with the same names... [20:51:08] legoktm: oh, right. we were checking creation, not usage. [20:51:18] my bad. me sleepy. [20:51:22] :P [20:57:51] Ugh, Phabricator image loading is so slow. When browising image full-screen from a task it blinks out for 1-2 seconds. It seems every time an image loads it goes through another three-way redirect to create a brand new image url. So it's never a cache hit [20:58:03] 10Differential, 10Security-Reviews: Arcanist security review (before being used in WMF deployments) - https://phabricator.wikimedia.org/T613#1622486 (10mmodell) FWIW, The Arcanist upstream code changes fairly infrequently and those changes usually come in easy to review, bite-sized pieces. We host our own Arc... [20:58:04] so it's almost impossible to compare two images [20:59:59] legoktm: https://gist.github.com/polybuildr/4f91faa40e1b75ceda17/ [21:00:05] excuse the indentation please :P [21:00:21] The line include the standard and all the rules, I *think* [21:00:43] If I write line 4 after closing the rule on line 3, then I get a redeclaration error. [21:00:59] Any idea whether this is the right way to do it? [21:01:06] Probably isn't, because something somewhere is not working. :P [21:01:11] But do you know? [21:02:41] Oh, I know what the something somewhere was. Fixing that works. Hopefully will be able to tell whether this works. [21:03:31] polybuildr: I never played around with phpcs.xml style configuration heavily [21:03:44] legoktm: hmm, okay. and the docs don't help too much with deeper stuff. [21:03:55] the docs on custom sniffs are pretty poor [21:04:00] I mainly just look at the source [21:04:18] hmm, okay. [21:04:24] pick a random sniff that has the functionality you want to replicate and read it :P [21:04:25] I'm getting somewhere now, though, so should be okay. [21:04:31] haha :P alright. [21:14:23] (03PS2) 10Polybuildr: Add ignore list to PrefixedGlobalFunctionsSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/237247 (https://phabricator.wikimedia.org/T104501) [21:16:09] (03CR) 10Polybuildr: "PS2 reads from custom phpcs.xml. I haven't been able to test much, so please verify that this works. The tests should help with that." [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/237247 (https://phabricator.wikimedia.org/T104501) (owner: 10Polybuildr) [21:18:45] legoktm: Updated patch set. Also submitted another one to core. Added you as reviewer to both. [21:18:58] Please do verify manually once. Sleepy me is not a good programmer. :P [21:19:07] And goodnight! o/ [21:19:11] polybuildr: we need to do a phpcs release and upgrade before core is ready [21:19:15] polybuildr: good night! [21:19:31] legoktm: oh, right [21:19:41] but.. setting an extra parameter causes no harm afaik. [21:19:43] lemme check. [21:19:56] but I can use it to test :) [21:21:18] legoktm: Also, I'm confused about this "PHP Fatal error: Cannot redeclare class MediaWiki_Sniffs_NamingConventions_PrefixedGlobalFunctionsSniff" that turns up sometimes.... :P Some local configuration issue, *hopefully*. [21:22:16] okay, enough. I have a class in less than 5 hours. -_- [21:22:18] o/ [21:25:37] 10Beta-Cluster, 10MediaWiki-extensions-OAuth, 10Pywikibot-OAuth, 7Pywikibot-network, 7Pywikibot-tests: "Nonce already used" regularly occurring on beta cluster - https://phabricator.wikimedia.org/T109173#1622624 (10Tgr) >>! In T109173#1619880, @jayvdb wrote: > @Tgr, I am not sure what we can or should do... [22:15:39] Project beta-scap-eqiad build #69338: FAILURE in 1 min 23 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/69338/ [22:15:51] 10Differential, 6Phabricator: GitHub -> Differential import system - https://phabricator.wikimedia.org/T715#1622753 (10Ricordisamoa) Why are issues no longer part of the task? [22:25:17] Yippee, build fixed! [22:25:18] Project beta-scap-eqiad build #69339: FIXED in 1 min 11 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/69339/ [22:27:10] 10Beta-Cluster, 10MediaWiki-extensions-WikimediaMaintenance, 5Patch-For-Review: Check/update dumpInterwiki for beta usage - https://phabricator.wikimedia.org/T75906#1622788 (10jayvdb) p:5Normal>3High A broken interwikimap is preventing proper testing. [22:28:09] 6Release-Engineering, 3Team-Practices-This-Week, 5Testing Initiative 2015: Talk to Greg and Arthur about Onboarding's role in establishing good testing practices/habits - https://phabricator.wikimedia.org/T108121#1622794 (10ggellerman) Meeting with @Awjrichards @greg and @dduvall: Create onboarding generic... [22:29:12] 10Differential, 6Phabricator: GitHub -> Differential import system - https://phabricator.wikimedia.org/T715#1622806 (10greg) Sorry, I took it out based on Quim's comment, I'm not against it being a part of this task :) [22:35:18] Project beta-scap-eqiad build #69340: FAILURE in 1 min 12 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/69340/ [22:45:22] Yippee, build fixed! [22:45:23] Project beta-scap-eqiad build #69341: FIXED in 1 min 15 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/69341/ [23:04:30] 10Beta-Cluster, 10MediaWiki-extensions-WikimediaMaintenance, 5Patch-For-Review: Check/update dumpInterwiki for beta usage - https://phabricator.wikimedia.org/T75906#1622995 (10Krenair) >>! In T75906#1622788, @jayvdb wrote: > A broken interwikimap is preventing proper testing. Okay. Unfortunately changing ta... [23:06:11] 10Beta-Cluster, 10MediaWiki-extensions-OAuth, 10Pywikibot-OAuth, 7Pywikibot-network, 7Pywikibot-tests: "Nonce already used" regularly occurring on beta cluster - https://phabricator.wikimedia.org/T109173#1623008 (10jayvdb) 5Open>3Resolved a:3jayvdb I've seen four builds in a row without problems, s... [23:06:36] 10Beta-Cluster, 10MediaWiki-extensions-OAuth, 10Pywikibot-OAuth, 7Pywikibot-network, 7Pywikibot-tests: "Nonce already used" regularly occurring on beta cluster - https://phabricator.wikimedia.org/T109173#1623014 (10jayvdb) a:5jayvdb>3bd808 [23:10:17] (03PS1) 10Legoktm: Whitelist MZMcBride [integration/config] - 10https://gerrit.wikimedia.org/r/237293 [23:10:47] 10Beta-Cluster, 10MediaWiki-extensions-OAuth, 10Pywikibot-OAuth, 7Pywikibot-network, 7Pywikibot-tests: "Nonce already used" regularly occurring on beta cluster - https://phabricator.wikimedia.org/T109173#1623034 (10Tgr) Looks like the memcached graphite counts are a good way of tracking this after all (n... [23:13:00] (03CR) 10Jforrester: [C: 031] Whitelist MZMcBride [integration/config] - 10https://gerrit.wikimedia.org/r/237293 (owner: 10Legoktm) [23:16:57] (03CR) 10Alex Monk: [C: 031] Whitelist MZMcBride [integration/config] - 10https://gerrit.wikimedia.org/r/237293 (owner: 10Legoktm) [23:20:44] 10Browser-Tests, 6Release-Engineering-Team, 7Tracking: Move browser test alerts to responsible teams' channels from -releng (tracking) - https://phabricator.wikimedia.org/T89375#1623071 (10greg) [23:21:31] 10Beta-Cluster, 10QuickSurveys, 5Patch-For-Review, 3Reading-Web-Sprint-55-π: Get QuickSurveys enabled on beta cluster - https://phabricator.wikimedia.org/T110199#1623073 (10dr0ptp4kt) @jdlrobson, my feedback: It seems like the survey box should be aligned to the left for LTR and right for RTL Also, would... [23:24:22] (03CR) 10Legoktm: [C: 032] Add ignore list to PrefixedGlobalFunctionsSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/237247 (https://phabricator.wikimedia.org/T104501) (owner: 10Polybuildr) [23:24:46] (03Merged) 10jenkins-bot: Add ignore list to PrefixedGlobalFunctionsSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/237247 (https://phabricator.wikimedia.org/T104501) (owner: 10Polybuildr) [23:26:13] 10Browser-Tests, 6Release-Engineering-Team, 10Wikipedia-iOS-App-Product-Backlog, 3Wikipedia-Android-App: Create end-to-end automated test for Wikipedia native app(s) - https://phabricator.wikimedia.org/T90177#1623091 (10greg) For lack of a better home project (other than team) I'm putting this in #browser-... [23:41:46] greg-g: Who do I have to bribe/kill to fix wikitech's insane log-out length? [23:42:13] 10Gitblit-Deprecate: redirect gerrit repo paths to diffusion callsigns - https://phabricator.wikimedia.org/T110607#1623156 (10greg) [23:42:15] 10Gitblit-Deprecate, 10Diffusion: Update mediawiki.org templates to link to Diffusion, not gitblit - https://phabricator.wikimedia.org/T108864#1623157 (10greg) [23:42:16] more spam incoming [23:42:18] 10Browser-Tests, 5Testing Initiative 2015: Improve browser testing page with templates : Emphasize testing documentation on mediawiki.org - https://phabricator.wikimedia.org/T108110#1623158 (10greg) [23:42:26] James_F: uh... not sure? [23:42:37] 10Browser-Tests, 10Wikipedia-iOS-App-Product-Backlog, 3Wikipedia-Android-App: Create end-to-end automated test for Wikipedia native app(s) - https://phabricator.wikimedia.org/T90177#1623176 (10greg) [23:42:37] * James_F sighs. [23:42:42] 10Continuous-Integration-Infrastructure, 5Patch-For-Review, 7Tracking: doc.wikimedia.org: Generate documentation for release tags (tracking) - https://phabricator.wikimedia.org/T73062#1623178 (10greg) [23:42:45] 10Continuous-Integration-Infrastructure, 6operations, 5Patch-For-Review: Jenkins: Re-enable lint checks for Apache config in operations-puppet - https://phabricator.wikimedia.org/T72068#1623179 (10greg) [23:42:47] 10Beta-Cluster, 10Continuous-Integration-Config: Send beta cluster Jenkins alerts to betacluster-alert list - https://phabricator.wikimedia.org/T1125#1623184 (10greg) [23:42:49] 10Beta-Cluster, 7Tracking: create API level tests to monitor services on beta/test2wiki and also on production (tracking) - https://phabricator.wikimedia.org/T60353#1623183 (10greg) [23:42:50] It seems like the login cookie length is 1–2 hours or less. [23:42:51] 10Browser-Tests, 10Continuous-Integration-Infrastructure: Map operations/mediawiki-config/extension-list entries to Jenkins browser test job - https://phabricator.wikimedia.org/T456#1623190 (10greg) [23:43:04] James_F: what? not for me [23:43:19] So every time I follow a watchlist e-mail I'm (a) logged out and so (b) not re-setting the token. [23:43:28] greg-g: Hmm. [23:43:39] I have no idea, because I stay logged in for at least a week [23:45:04] Half the cookies set are session-length, but that seems normal? [23:45:06] Meh.