[00:09:51] ostriches: glarg. typo [00:09:56] sorry, i didn't test that [00:10:51] ostriches: git pull [00:12:54] ostriches: if you don't want to destroy and re-up you can just blow away the base container [00:13:06] `sudo lxc-destroy -fn scap-target-base` [00:13:17] a provision should pick it up from there [00:22:19] 10Deployment-Systems, 3Scap3, 5Patch-For-Review: Scap3 should support rollback - https://phabricator.wikimedia.org/T109514#1647688 (10thcipriani) [00:22:21] 3Scap3, 5Patch-For-Review: Scap3 should break up remote deploy tasks - https://phabricator.wikimedia.org/T109861#1647685 (10thcipriani) 5Open>3Resolved Patch merged, good framework in place for any further stage breakouts. Closing. [00:23:05] Can we land https://gerrit.wikimedia.org/r/#/c/238858/ before we all call it a day? :p [00:24:15] (03CR) 10Dduvall: [C: 032] Fix logging output from sudo_check_call [tools/scap] - 10https://gerrit.wikimedia.org/r/238858 (owner: 10Chad) [00:24:25] ostriches: ^ booya [00:24:28] go team! [00:24:40] (03Merged) 10jenkins-bot: Fix logging output from sudo_check_call [tools/scap] - 10https://gerrit.wikimedia.org/r/238858 (owner: 10Chad) [00:26:52] :) :) :) [00:28:02] 3Scap3: Allow batch_size to be configured for each deploy stage - https://phabricator.wikimedia.org/T112841#1647704 (10dduvall) 3NEW a:3dduvall [00:28:26] 3Scap3: Allow batch_size to be configured for each deploy stage - https://phabricator.wikimedia.org/T112841#1647714 (10dduvall) p:5Triage>3Low [00:29:12] 10Deployment-Systems, 3Scap3, 5Patch-For-Review: Improve scap's output - https://phabricator.wikimedia.org/T109858#1647717 (10demon) Landed https://gerrit.wikimedia.org/r/#/c/238858/ which helps the first point (more explicit errors from hosts on shell invocations). Still some work to be done on cleaning up... [00:31:38] I'm out for the evening. Gym, dinner, etc. Good work today everybody :D [00:33:30] word. [00:36:31] yeah, good stuff today [00:36:36] i'm out, too. night! [00:40:33] (03PS1) 10Dduvall: Support batch size configuration per stage [tools/scap] - 10https://gerrit.wikimedia.org/r/239016 (https://phabricator.wikimedia.org/T112841) [01:36:04] 10Beta-Cluster, 7HHVM, 5Patch-For-Review: Upgrade Beta Cluster tmh* host(s) to HHVM and Trusty - https://phabricator.wikimedia.org/T110707#1647834 (10Krenair) Is this done? [05:10:48] (03PS1) 1020after4: A context manager for managing nested loggers [tools/scap] - 10https://gerrit.wikimedia.org/r/239028 [05:11:06] (03CR) 10jenkins-bot: [V: 04-1] A context manager for managing nested loggers [tools/scap] - 10https://gerrit.wikimedia.org/r/239028 (owner: 1020after4) [05:18:16] (03PS2) 1020after4: A context manager for managing nested loggers [tools/scap] - 10https://gerrit.wikimedia.org/r/239028 [05:24:41] Krenair: you're a github wikimedia account admin, right? [05:24:46] yes [05:24:49] * greg-g nods [05:25:02] then yeah, that sucks (re the mirror setting) [05:25:13] talk to someone? who's got time for that?! [05:26:23] https://stackoverflow.com/questions/11370239/creating-an-official-github-mirror#answer-25340224 [05:27:07] 10Continuous-Integration-Infrastructure, 6Labs, 10Labs-Infrastructure: integration-slave-trusty-1014 and integration-slave-trusty-1017 instances can't boot anymore, ended up corrupted. Need rebuild - https://phabricator.wikimedia.org/T110052#1648007 (10Krinkle) [05:27:37] 10Continuous-Integration-Infrastructure, 6Labs, 10Labs-Infrastructure: integration-slave-trusty-1014 and integration-slave-trusty-1017 instances can't boot anymore, ended up corrupted. Need rebuild - https://phabricator.wikimedia.org/T110052#1648008 (10Krinkle) p:5Triage>3High [05:28:27] 10Continuous-Integration-Infrastructure, 6Labs, 10Labs-Infrastructure: integration-slave-trusty-1014 and integration-slave-trusty-1017 instances can't boot anymore, ended up corrupted. Need rebuild - https://phabricator.wikimedia.org/T110052#1567858 (10Krinkle) Status? T110506 seems to be resolved. We're on... [05:32:26] 10Continuous-Integration-Infrastructure: Garbage collect orphan jobs workspaces on slaves - https://phabricator.wikimedia.org/T94408#1648041 (10Krinkle) [05:35:01] 10Deployment-Systems, 10MediaWiki-extensions-LocalisationUpdate, 7I18n, 7Wikimedia-log-errors: l10n-update not updating Vector - https://phabricator.wikimedia.org/T103879#1648045 (10Nikerabbit) Honestly, I do not have time to debug localisation update issues on the production on my own. If there are suffi... [05:35:52] 10Continuous-Integration-Config, 10Analytics-EventLogging: Set up jsduck test job for EventLogging - https://phabricator.wikimedia.org/T88343#1648046 (10Krinkle) [06:18:57] 10Deployment-Systems, 10MediaWiki-extensions-LocalisationUpdate, 7I18n, 7Wikimedia-log-errors: l10n-update not updating Vector - https://phabricator.wikimedia.org/T103879#1648089 (10Nemo_bis) Usually reports come when it's too late, i.e. when some prominent feature/string is enabled that proves impossible... [07:37:19] good morning [07:49:50] !sal [07:49:50] https://tools.wmflabs.org/sal/releng [07:50:03] https://phabricator.wikimedia.org/T112821 [07:50:06] colordiff not found [07:50:18] zeljkof: we can fix it up :-} [07:50:33] hashar: please do :) [07:50:34] I have migrated the jjb diff job to the Nodepool instances [07:50:43] ah, that is the job that is moved [07:50:44] and the base image only includes apt and contint::packages::python class [07:50:48] so it is missing the colordiff [07:50:48] now it makes sense [07:51:07] so that needs a puppet patch :-} [07:51:22] bah, that was too easy ;) [07:51:41] modules/contint/manifests/packages.pp: package { 'colordiff': [07:51:50] and the image does not include contint::packages [07:54:24] 10Continuous-Integration-Infrastructure, 5Continuous-Integration-Scaling: colordiff: command not found - https://phabricator.wikimedia.org/T112821#1648214 (10hashar) I have migrated the Jenkins job integration-jjb-config-diff to the Nodepool instances. They for now only include the puppet classes: * apt * co... [07:54:34] zeljkof: that is probably a good puppet exercise for you :} [07:55:01] hashar: true [07:55:06] just finished something, let me jump on this [07:58:39] note you can't ssh to the instances [07:58:52] cause they are deleted just after the job has completed [07:58:54] so the context is gone [08:00:36] hashar: sure, makes sense [08:00:40] that is what lego noticed [08:02:12] ok, I thought it would be only including the colordiff package, but looks like some refactoring is needed [08:03:57] hashar: unrelated, I am finishing this [08:03:58] https://gerrit.wikimedia.org/r/#/c/237611/ [08:04:59] it depended on a change that did not merge because of a failed test, but I have done "recheck", everything was fine and the change got merged [08:05:08] (https://gerrit.wikimedia.org/r/#/c/237599/) [08:05:26] but how do I now get 237611 merged? [08:05:34] should I +2 the commit? [08:05:39] or do "recheck" there? [08:08:40] tried +2, let's see if it works [08:08:56] now back to T112821 [08:12:59] (03PS3) 1020after4: A context manager for managing nested loggers [tools/scap] - 10https://gerrit.wikimedia.org/r/239028 [08:13:23] twentyafterfour: great :-} [08:13:41] in #releng empire there is always someone awake [08:13:48] :) [08:21:55] 10Deployment-Systems, 5Patch-For-Review: Adopt Semantic Versioning format for WMF deploy branches beginning with 1.27.0-wmf.1 - https://phabricator.wikimedia.org/T67306#1648286 (10mmodell) [08:22:00] twentyafterfour: wait, it's like 4am for you? [08:22:09] 10Deployment-Systems, 5Patch-For-Review: Adopt Semantic Versioning format for WMF deploy branches beginning with 1.27.0-wmf.1 - https://phabricator.wikimedia.org/T67306#683803 (10mmodell) [08:24:12] hashar: this is what I have so far, looking where to apply the class to nodepool instances [08:24:12] https://gerrit.wikimedia.org/r/#/c/239044/ [08:30:38] zeljkof: in integration/config.git in /dib/ [08:30:41] there is some ciimage.pp [08:31:17] hashar: thanks, I was looking at modules/nodepool/manifests/init.pp [08:31:28] na that one is for the Nodepool service [08:35:32] 10Browser-Tests, 10Gather, 5Patch-For-Review, 5WMF-deploy-2015-09-15_(1.26wmf23), 5WMF-deploy-2015-09-22_(1.26wmf24): Fix easy problems reported by RuboCop in Gather - https://phabricator.wikimedia.org/T112099#1648323 (10zeljkofilipin) 5Open>3Resolved [08:49:29] (03PS1) 10Zfilipin: Make sure colordiff is installed on nodepool instances [integration/config] - 10https://gerrit.wikimedia.org/r/239047 (https://phabricator.wikimedia.org/T112821) [08:49:49] zeljkof: yeah that is how we would do it :-} [08:50:03] then we will need to refresh the base image [08:50:15] hashar: it was easier than expected, once I knew where too look :) [08:50:33] or the setup script that prepare the snapshot from which instances are booted [08:50:33] the process is more or less: [08:50:46] * use DIB to create a base image that is pushed to OpenStack [08:50:57] (03CR) 10Zfilipin: "Needs https://gerrit.wikimedia.org/r/#/c/239044/ to be merged." [integration/config] - 10https://gerrit.wikimedia.org/r/239047 (https://phabricator.wikimedia.org/T112821) (owner: 10Zfilipin) [08:51:15] * Nodepool periodically update that image by booting it, then running a setup script (somewhere in integration/config.git under /nodepool/ ). That script does not update the puppet repo nor does it run puppet [08:51:32] * When instance is booted, Nodepool executes a ready script (which is also in /nodepool/ ) [08:51:48] gotta write that down on [[wikitech:Nodepool]] [08:53:43] and chain merge a bunch of contint related puppet patches [08:58:03] https://wikitech.wikimedia.org/w/index.php?title=Nodepool&diff=178120&oldid=177963 [09:04:15] 10Gerrit-Migration, 10Gitblit-Deprecate, 10Diffusion: Define a process to import and create repositories - https://phabricator.wikimedia.org/T1009#1648413 (10Qgil) [09:04:19] 10Gerrit-Migration: Plan to migrate code review from Gerrit to Phabricator - https://phabricator.wikimedia.org/T18#1648414 (10Qgil) [09:04:21] 10Browser-Tests, 10QuickSurveys, 5Patch-For-Review, 3Reading-Web-Sprint-56-Four Lions: QA: Setup browser tests on beta cluster so we can share test articles - https://phabricator.wikimedia.org/T112204#1648416 (10phuedx) As I commented on [238981](https://gerrit.wikimedia.org/r/238981), I'm not too happy wi... [09:11:08] (03PS2) 10Zfilipin: Make sure colordiff is installed on nodepool instances [integration/config] - 10https://gerrit.wikimedia.org/r/239047 (https://phabricator.wikimedia.org/T112821) [09:20:02] zeljkof: for change in 223691 234254 238436 238438 238442; do git-review -x $change; done; [09:20:12] picks each change on the branch [09:20:42] nice [09:26:21] zeljkof: you can rebase the colordiff patch on top of https://gerrit.wikimedia.org/r/238442 [09:26:32] I made all the contint pending patches to be dependent on each other [09:26:48] hashar: will do, just to finish something [09:26:49] zeljkof: actually let me do it [09:26:54] hashar: go ahead [09:37:28] (03CR) 10Hashar: [C: 04-1] "Depends on https://gerrit.wikimedia.org/r/#/c/239044/" [integration/config] - 10https://gerrit.wikimedia.org/r/239047 (https://phabricator.wikimedia.org/T112821) (owner: 10Zfilipin) [09:37:43] zeljkof: I moved curl as well ( https://gerrit.wikimedia.org/r/#/c/239044/ ) [09:38:02] and have the packages::base class included from role::ci::slave::labs::common [09:38:10] so it is applied on all the slaves [09:39:43] hashar: looks good [09:40:48] zeljkof: and I added them to SWAT https://wikitech.wikimedia.org/w/index.php?title=Deployments&diff=178126&oldid=177957 [09:42:02] even better [09:42:09] good job, sir :) [09:42:43] er, I mean monsieur [09:47:55] (03PS1) 10Hashar: nodepool: document setup / ready scripts [integration/config] - 10https://gerrit.wikimedia.org/r/239058 [09:48:02] zeljkof: https://gerrit.wikimedia.org/r/239058 :D [09:50:26] (03CR) 10Zfilipin: [C: 032] nodepool: document setup / ready scripts [integration/config] - 10https://gerrit.wikimedia.org/r/239058 (owner: 10Hashar) [09:50:45] hashar: merged! [09:51:14] (03Merged) 10jenkins-bot: nodepool: document setup / ready scripts [integration/config] - 10https://gerrit.wikimedia.org/r/239058 (owner: 10Hashar) [09:55:17] zeljkof: wanna deploy it ? :D [09:55:33] those scripts are injected by nodepool in the snapshots and instances on boot [09:55:46] so they need to be kept up to date on labnodepool1001.eqiad.wmnet under /etc/nodepool/wikimedia [09:56:07] (yeah I need to write down more doc) [09:56:13] probably to upstream [09:57:16] hashar: sure, but I need to finish something, I am in the middle [10:00:33] 10Browser-Tests, 5Patch-For-Review, 5WMF-deploy-2015-09-22_(1.26wmf24): All repositories that have browser tests should be updated to the latest version of watir-webdriver - https://phabricator.wikimedia.org/T112748#1648502 (10zeljkofilipin) [10:01:50] hashar: ok, done, let's see how to deploy that [10:34:30] 10Continuous-Integration-Infrastructure: make CI able to run PHPUnit from composer instead of a system wide installation - https://phabricator.wikimedia.org/T112867#1648565 (10JanZerebecki) 3NEW [10:36:00] hashar: I can not ssh to labnodepool1001.eqiad.wmnet [10:36:08] ah [10:36:09] my ssh-fu is failing me [10:36:20] let me check the admin data [10:36:45] zeljkof: it is in puppet in the huge yaml file modules/admin/data/data.yaml [10:37:42] the rights are applied via hiera. So have to look at hieradata/hosts/labnodepool1001.yaml [10:37:47] which has: [10:37:51] admin::groups: [10:37:51] - contint-users [10:37:52] - contint-admins [10:38:10] and you are a member of that last group [10:38:47] zeljkof: review your ssh conf? You should proxy it via bast1001.wikimedia.org [10:39:28] hashar: looking [10:41:57] hm [10:42:15] looks like my laptop is configured correctly, but I have forgot to set up my desktop :/ [10:42:17] checking... [10:51:04] hashar: ok, something is wrong with my ssh key [10:51:11] or my mac [10:51:23] it does not accept my password :( [10:52:11] zeljkof: do you have your production private key at least ? [10:53:26] hashar: yes [10:53:47] not sure what is wrong, I remember having the same problem before [10:54:08] I am diffing ssh config files (laptop/desktop) now [10:54:16] and will try to ssh from desktop [11:11:59] hashar: lunch time, will continue in half an hour or so [11:23:54] 10Beta-Cluster, 10MediaWiki-extensions-SecurePoll: Extension:Secure Poll throws database error, when try to vote at beta cluster - https://phabricator.wikimedia.org/T112818#1648681 (10Reedy) Complaining about the centralauth.securepoll_lists table not existing https://github.com/wikimedia/mediawiki-extensions... [11:29:01] 10Beta-Cluster, 10MediaWiki-extensions-SecurePoll: Extension:Secure Poll throws database error, when try to vote at beta cluster - https://phabricator.wikimedia.org/T112818#1648689 (10Reedy) https://github.com/wikimedia/mediawiki-extensions-SecurePoll/blob/master/SecurePoll.sql#L211-L222 needs doing manually [11:31:29] How do I get onto the sql databases for labs? [11:31:36] sql enwiki is asking for a password? [11:32:44] Is the script just broken for labs/beta? [11:36:10] 10Beta-Cluster, 10MediaWiki-extensions-SecurePoll: Extension:Secure Poll throws database error, when try to vote at beta cluster - https://phabricator.wikimedia.org/T112818#1648694 (10Reedy) 5Open>3Resolved a:3Reedy ```lines=10 mysql> show tables; +---------------------------+ | Tables_in_centralauth... [11:55:33] 10Beta-Cluster: beta: set $wgCategoryCollation for languages - https://phabricator.wikimedia.org/T47525#1648713 (10Reedy) This should be easy to do... Do we want to just do it for all languages that have it set in production, then close this? Any newly created wikis, or when production wikis are migrated, we upd... [11:57:19] 10Beta-Cluster: beta: set $wgCategoryCollation for languages - https://phabricator.wikimedia.org/T47525#1648719 (10Reedy) Actually, as labs doesn't override the setting, any wiki that exists on labs will have it automatically set.... So >>! In T47525#518433, @Reedy wrote: > If you update wgCategoryCollation th... [11:58:00] ^ running [12:39:52] (03CR) 10Zfilipin: "I have tried to deploy the change, but failed. :/" [integration/config] - 10https://gerrit.wikimedia.org/r/239058 (owner: 10Hashar) [12:41:14] zeljkof: what is falling ? [12:41:24] ah [12:41:25] hashar: git pull [12:41:28] (03PS5) 10Amire80: Archive Narayam and WebFonts [integration/config] - 10https://gerrit.wikimedia.org/r/232726 (https://phabricator.wikimedia.org/T110178) [12:41:30] yeah [12:41:35] I think I need to use nodepool user, right? [12:41:36] (03CR) 10Amire80: "Ping :)" [integration/config] - 10https://gerrit.wikimedia.org/r/232726 (https://phabricator.wikimedia.org/T110178) (owner: 10Amire80) [12:41:36] look at who own the files under /etc/nodepool/wikimedia [12:42:00] zeljkof: I added a script 'become-nodepool' /usr/local/bin/become-nodepool [12:42:06] nodepool [12:42:24] $ ls -la .git/FETCH_HEAD [12:42:27] -rw-r--r-- 1 nodepool nodepool 1095 Sep 15 16:53 .git/FETCH_HEAD [12:42:28] * hashar writes doc [12:42:31] yeah [12:42:35] so invoke 'become-nodepool' [12:42:38] that runs sudo [12:42:46] reset HOME to /var/lib/nodepool [12:42:53] and put you in nodepool user homedir [12:42:54] so [12:43:00] become-nodepool [12:43:08] cd /etc/nodepool/wikimedia && git pull [12:43:45] hashar: done, now it works! [12:43:58] grats [12:44:52] doc updated https://wikitech.wikimedia.org/w/index.php?title=Nodepool&diff=178159&oldid=178139 [12:44:58] (03CR) 10Zfilipin: "zfilipin@labnodepool1001:/etc/nodepool/wikimedia$ become-nodepool" [integration/config] - 10https://gerrit.wikimedia.org/r/239058 (owner: 10Hashar) [12:45:29] hashar: looks like the problem was in ssh-agent on my machine [12:45:47] it did not want to store my ssh passphrase to mac keychain [12:46:38] 10Beta-Cluster: beta: set $wgCategoryCollation for languages - https://phabricator.wikimedia.org/T47525#1648820 (10Reedy) Done that. Though, I'm now running foreachwikiindblist all-labs.dblist updateCollation.php --force just to make sure everything is up to date. [12:47:27] once I have added the passphrase to the keychain using ssh-add from terminal, everything just worked [12:48:24] first I checked if I have the correct passphrase (with ssh-keygen) since my original assumption was that I was either making typos or having the wrong passphrase [12:48:29] anyway, works now :D [12:48:36] * zeljkof dances [12:54:16] (03PS2) 10Zfilipin: [WIP] Fallback on base password configuration [selenium] - 10https://gerrit.wikimedia.org/r/202777 (https://phabricator.wikimedia.org/T112279) (owner: 10Dduvall) [12:54:19] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Fallback on base password configuration [selenium] - 10https://gerrit.wikimedia.org/r/202777 (https://phabricator.wikimedia.org/T112279) (owner: 10Dduvall) [12:55:00] (03CR) 10Zfilipin: [C: 04-1] "Voting -1 because this is not yet ready to be merged." [selenium] - 10https://gerrit.wikimedia.org/r/202777 (https://phabricator.wikimedia.org/T112279) (owner: 10Dduvall) [12:58:51] 10Beta-Cluster: beta: set $wgCategoryCollation for languages - https://phabricator.wikimedia.org/T47525#1648834 (10Reedy) 5Open>3Resolved a:3Reedy And that's done. Any new wikis that get changed over in production, that exist in beta need the updateCollation.php script running in beta. Easy enough to track [13:00:10] Project browsertests-MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome-sauce build #788: FAILURE in 28 min: https://integration.wikimedia.org/ci/job/browsertests-MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome-sauce/788/ [13:00:49] (03CR) 10Zfilipin: [C: 04-1] "Voting -1 because this is not yet ready to be merged." [ruby/api] - 10https://gerrit.wikimedia.org/r/235390 (https://phabricator.wikimedia.org/T111133) (owner: 10Dduvall) [13:02:06] hashar: is there a reason this is still not merged? https://gerrit.wikimedia.org/r/#/c/200767/ [13:05:00] 10Beta-Cluster, 6operations, 7Performance: Need a way to simulate replication lag to test replag issues - https://phabricator.wikimedia.org/T40945#1648855 (10Reedy) T59583 is a dupe? [13:06:15] zeljkof: see my previous comment from July 8th [13:06:25] hashar: looking.. [13:06:28] >> The blind rebase doesn't take in account href: /regex/ selectors which might have been introduced in between. [13:06:30] >> I can't remember what I did at the time, but there is most probably a lot left that needs to be investigated and corrected. Potentially have to find another selector when the element lacks an ID. [13:06:41] hashar: no [13:06:43] gotta look again at the various features and figure out whether some are still using href [13:06:45] actually, I have checkec [13:06:47] checked [13:07:11] nothing is using regular expressions in mediawiki/core [13:07:14] and you most probably want to run it locally to confirm that none of the scenarii are suffering from the delay [13:07:27] also, tested, it ran faster :) [13:07:33] rebasing [13:07:40] might want to double check again then +2 it :) [13:07:53] I think I have left all those comments in gerrit :) [13:07:54] don't we run the @integration browser tests yet ? [13:08:00] not for core [13:08:13] I have it on my todo list [13:08:22] maybe something we can do tomorrow [13:08:28] it still has href: /foo/ [13:08:30] :-( [13:08:45] where? [13:08:57] I have checked, double checked, triple checked... [13:09:19] your comment from Sep 11th confuses me: [13:09:21] $ git grep -F ': /' -- '*.rb' [13:09:21] 10Beta-Cluster, 6Labs: beta-hhvm.wmflabs.org? - https://phabricator.wikimedia.org/T111657#1648873 (10Reedy) Just kill it! [13:09:25] tests/browser/features/support/pages/main_page.rb: a(:edit_link, href: /action=edit/) [13:09:26] (03CR) 10Zfilipin: "recheck" [integration/config] - 10https://gerrit.wikimedia.org/r/238974 (https://phabricator.wikimedia.org/T112204) (owner: 10Jdlrobson) [13:09:26] tests/browser/features/support/pages/main_page.rb: a(:printable_version_link, href: /printable=yes/) [13:09:26] tests/browser/features/support/pages/main_page.rb: a(:view_history_link, href: /action=history/) [13:09:26] tests/browser/features/support/pages/preferences_appearance_page.rb: a(:restore_default_link, href: /reset/) [13:09:28] tests/browser/features/support/pages/view_history_page.rb: a(:view_history_link, href: /action=history/) [13:09:28] tests/browser/features/support/pages/view_history_page.rb: a(:old_version_link, href: /oldid=/) [13:10:58] 10Browser-Tests, 5Patch-For-Review: Fix problems reported by RuboCop in Math - https://phabricator.wikimedia.org/T111184#1648876 (10Physikerwelt) Woudn't it be easier to combine all commits to one? [13:11:28] zeljkof: you state there is nothing left to do but your grep does show a bunch of href: /xxx/ :/ [13:11:57] hashar: let me see [13:12:37] sorry, that is me being bad in communication [13:12:47] $ grep '(' *|cut -d: -f3|cut -d\, -f2|sort|uniq -c [13:12:47] the grep shows what is there in master [13:12:47] 1 class [13:12:48] 5 css [13:12:48] 61 id [13:12:50] 2 text [13:12:50] $ [13:13:03] that is the selectors being used in tests/browser/features/support/pages/*.rb [13:13:05] and your patch has fixed all those [13:13:38] hashar: well, that is good, right, no moar hrefs? [13:14:29] zeljkof: yeah I guess you can +2 it [13:14:39] your comment definitely confused me last week [13:14:46] sorry : [13:14:48] :/ [13:14:50] that is probably why I skipped processing that change when I received the email [13:14:53] no worries :-} [13:14:58] it is solved now! [13:14:59] my communication skills [13:15:02] you know :) [13:15:10] CR+2 and I guess we will see the Core browsertests running slightly faster [13:15:14] ok, merging, one less thing to worry about [13:15:18] yes [13:15:23] will rerun them actually now [13:15:29] as soon as it is merged [13:15:52] gotta CR+2 it first :-} [13:17:02] hashar: http://cdn.arstechnica.net/wp-content/uploads/2014/02/shall-not-merge.jpg [13:18:01] I did +2 it, looks like the bot does not report here [13:18:09] we need moar bots [13:21:43] zeljkof: mediawiki/core.git spam is sent to #wikimedia-dev [13:22:43] it's amazing how may channels there are :) [13:23:04] zeljkof: I have documented the deployment of changes to /nodepool/scripts : https://wikitech.wikimedia.org/w/index.php?title=Nodepool&type=revision&diff=178171&oldid=178166 [13:23:20] thanks [13:23:40] well, let me check if I can ssh there from my laptop, just in case [13:23:46] now that I know what the problem is [13:26:01] zeljkof: I think I also documented how to ssh to an instance [13:26:19] gotta become-nodepool [13:26:36] then something like: ssh -i ~/.ssh/dib_jenkins_id_rsa.pub jenkins@10.x.x.x [13:26:44] there might be another way though [13:27:02] cause that one gives you a shell as jenkins user [13:27:37] * hashar digs in openstack help server ssh [13:30:24] 10Beta-Cluster, 6operations, 7Performance: Need a way to simulate replication lag to test replag issues - https://phabricator.wikimedia.org/T40945#1648924 (10Nemo_bis) >>! In T40945#1648855, @Reedy wrote: > T59583 is a dupe? That's a proposed solution, AFAIK. [13:30:29] 10Beta-Cluster: Make deployment prep have continuous replication lag - https://phabricator.wikimedia.org/T59583#1648926 (10Nemo_bis) [13:30:31] 10Beta-Cluster, 6operations, 7Performance: Need a way to simulate replication lag to test replag issues - https://phabricator.wikimedia.org/T40945#1648925 (10Nemo_bis) [13:32:28] ok, laptop also working fine now, everything configured [13:35:42] 10Beta-Cluster, 10Staging, 6Collaboration-Team-Backlog, 7Database: Use External Store on Beta Cluster - https://phabricator.wikimedia.org/T95871#1648943 (10Reedy) >>! In T95871#1431750, @hashar wrote: > @Mattflaschen External Store is a bit tricky. Gotta need to setup a few instances to hold the SQL datab... [13:43:26] 10Browser-Tests, 5Patch-For-Review: Fix problems reported by RuboCop in Math - https://phabricator.wikimedia.org/T111184#1648982 (10zeljkofilipin) @physikerwelt: I prefer small commits. If you prefer one larger commit, let me know. [13:45:36] (03PS3) 10Zfilipin: Setup QuickSurveys jenkins job [integration/config] - 10https://gerrit.wikimedia.org/r/238974 (https://phabricator.wikimedia.org/T112204) (owner: 10Jdlrobson) [13:47:00] 10Beta-Cluster, 10MediaWiki-extensions-SecurePoll: Extension:Secure Poll throws database error, when try to vote at beta cluster - https://phabricator.wikimedia.org/T112818#1648997 (10Luke081515) Works now, thanks @Reedy [13:48:16] (03CR) 10Zfilipin: [C: 04-1] "Voting -1 until https://phabricator.wikimedia.org/T112821 is resolved." [integration/config] - 10https://gerrit.wikimedia.org/r/238974 (https://phabricator.wikimedia.org/T112204) (owner: 10Jdlrobson) [13:49:35] (03CR) 10Zfilipin: "By the way, job is deployed and working fine, so I do not think delaying this merge blocks anything." [integration/config] - 10https://gerrit.wikimedia.org/r/238974 (https://phabricator.wikimedia.org/T112204) (owner: 10Jdlrobson) [13:59:58] zeljkof: go ahead and +2 https://gerrit.wikimedia.org/r/#/c/238974/ :-} [14:06:37] hashar: you are right, the change is simple, it can be merged [14:07:45] (03CR) 10Zfilipin: [C: 032] "+2 after talking with hashar on IRC. The commit is simple enough to be merged without the diff tool working." [integration/config] - 10https://gerrit.wikimedia.org/r/238974 (https://phabricator.wikimedia.org/T112204) (owner: 10Jdlrobson) [14:09:20] (03Merged) 10jenkins-bot: Setup QuickSurveys jenkins job [integration/config] - 10https://gerrit.wikimedia.org/r/238974 (https://phabricator.wikimedia.org/T112204) (owner: 10Jdlrobson) [14:10:39] Hi :D [14:11:36] Hi! [14:12:59] What is this mystical place I've stumbled into [14:13:14] You probably don't want to know [14:13:34] :p I don't know who I should mention it to but I found this IRC channel mentioned somewhere [14:13:42] the CI dashboard link found on this page is dead https://wikitech.wikimedia.org/wiki/Nova_Resource:Deployment-prep/How_code_is_updated [14:14:05] Which link? [14:14:13] https://integration.wikimedia.org/ci/view/Beta/ WFM? [14:14:20] https://integration.wikimedia.org/dashboard/ [14:14:42] The link you sent is probably what it should be changedto [14:14:48] Or just https://integration.wikimedia.org/ ? [14:16:50] based on the context of the page I'm assuming it should be https://integration.wikimedia.org/ci/view/Beta/ [14:17:09] but not 100% sure. :p I was interested in reading, and stumbled upon a dead link [14:24:52] (03CR) 10Zfilipin: [C: 04-1] "Looks good to me in general. Voting -1 because of merge conflict." [selenium] - 10https://gerrit.wikimedia.org/r/226950 (owner: 10Dduvall) [14:29:01] 10Beta-Cluster, 5Patch-For-Review: Beta cluster "test.wikipedia" thinks it is "test.wikimedia" - https://phabricator.wikimedia.org/T99156#1649120 (10Reedy) http://test.wikipedia.beta.wmflabs.org/wiki/Main_Page directly works http://test.wikipedia.beta.wmflabs.org/ ends up at http://test.wikimedia.beta.wmflabs... [14:32:52] (03PS2) 10Chad: Simplify logging in ssh module [tools/scap] - 10https://gerrit.wikimedia.org/r/238959 [14:32:55] (03PS4) 10Chad: A context manager for managing nested loggers [tools/scap] - 10https://gerrit.wikimedia.org/r/239028 (owner: 1020after4) [14:33:12] (03CR) 10jenkins-bot: [V: 04-1] Simplify logging in ssh module [tools/scap] - 10https://gerrit.wikimedia.org/r/238959 (owner: 10Chad) [14:34:11] (03CR) 10Zfilipin: "Voted -1 because this is not ready to be merged." [integration/config] - 10https://gerrit.wikimedia.org/r/230715 (https://phabricator.wikimedia.org/T67773) (owner: 10Dduvall) [14:36:17] (03CR) 10Chad: "I think we don't want PS4 here, accidentally'd some changes. Restoring PS3." [tools/scap] - 10https://gerrit.wikimedia.org/r/239028 (owner: 1020after4) [14:37:09] (03PS3) 10Chad: Simplify logging in ssh module [tools/scap] - 10https://gerrit.wikimedia.org/r/238959 [14:37:12] (03PS5) 10Chad: A context manager for managing nested loggers [tools/scap] - 10https://gerrit.wikimedia.org/r/239028 (owner: 1020after4) [14:39:42] (03PS4) 10Chad: Simplify logging in ssh module [tools/scap] - 10https://gerrit.wikimedia.org/r/238959 [14:49:10] (03PS1) 10Chad: Convert tasks.* to use context logger [tools/scap] - 10https://gerrit.wikimedia.org/r/239112 [15:01:01] (03CR) 1020after4: [C: 031] Convert tasks.* to use context logger (031 comment) [tools/scap] - 10https://gerrit.wikimedia.org/r/239112 (owner: 10Chad) [15:03:45] (03CR) 10Chad: Convert tasks.* to use context logger (031 comment) [tools/scap] - 10https://gerrit.wikimedia.org/r/239112 (owner: 10Chad) [15:03:51] twentyafterfour: silly python :) [15:04:35] (03CR) 1020after4: [C: 031] Simplify logging in ssh module (031 comment) [tools/scap] - 10https://gerrit.wikimedia.org/r/238959 (owner: 10Chad) [15:04:50] 10Browser-Tests, 5Patch-For-Review, 5WMF-deploy-2015-09-22_(1.26wmf24): All repositories that have browser tests should be updated to the latest version of watir-webdriver - https://phabricator.wikimedia.org/T112748#1649302 (10zeljkofilipin) [15:04:52] Yeah it is kinda silly [15:05:32] (03PS5) 10Chad: Simplify logging in ssh module [tools/scap] - 10https://gerrit.wikimedia.org/r/238959 [15:05:33] ostriches: turns out that 'from . import X' is totally different behavior from 'import X' [15:06:25] (03CR) 10Chad: [C: 031] "Working for me, was able to make 2 child patches that worked off of this. Want a 2nd set of eyes first before merging :)" [tools/scap] - 10https://gerrit.wikimedia.org/r/239028 (owner: 1020after4) [15:07:03] 'from . import X' requires X to be fully compiled before it returns. the other form kinda runs asynchronously and handles circular dependencies better. [15:07:09] twentyafterfour: I guess the last bit is just cleaning up the logger stuff in main.py that still uses that get_logger() jank [15:07:32] ostriches: yeah [15:08:06] get_logger is probably not needed now although it isn't bad to use that [15:08:27] the class context is fine within an instance of that class [15:09:44] the ctxLogger is always going to have the context of the calling function, rather than the class [15:10:15] (or the most recent "with" block, not necessarily the calling function) [15:10:26] 10Continuous-Integration-Infrastructure: handle composer require-dev together with mediawiki-vendor - https://phabricator.wikimedia.org/T112895#1649314 (10JanZerebecki) 3NEW [15:10:46] good morning US ! [15:11:16] Good morning hashar [15:11:18] * greg-g waves [15:15:37] 10Beta-Cluster, 6Labs: beta-hhvm.wmflabs.org? - https://phabricator.wikimedia.org/T111657#1649349 (10Krenair) 5Open>3Resolved a:3Krenair done [15:21:03] :) [15:23:03] 10Beta-Cluster, 10MediaWiki-extensions-SecurePoll: Extension:Secure Poll throws database error, when try to vote at beta cluster - https://phabricator.wikimedia.org/T112818#1649386 (10greg) Just to be sure: SecurePoll will always need those manual steps to setup correctly? iow: when we setup Yet Another Text C... [15:23:12] * hashar reads emails [15:27:07] (03CR) 1020after4: "I think we should convert it to use scap.log, but in that case maybe we should convert all the imports to use the same form for consistenc" [tools/scap] - 10https://gerrit.wikimedia.org/r/239112 (owner: 10Chad) [15:28:26] (03CR) 10Thcipriani: [C: 04-1] "Dan and I talked yesterday about this (and I talked to Filippo about it this morning): it would be fairly easy (and a Good Thing™) to keep" [tools/scap] - 10https://gerrit.wikimedia.org/r/238839 (https://phabricator.wikimedia.org/T109514) (owner: 10Dduvall) [15:36:42] 10Browser-Tests, 10QuickSurveys, 5Patch-For-Review, 3Reading-Web-Sprint-56-Four Lions: QA: Setup browser tests on beta cluster so we can share test articles - https://phabricator.wikimedia.org/T112204#1649496 (10Jdlrobson) See my comment. I agree I'm just not sure if that's possible in the mediawiki/config... [15:40:10] (03CR) 1020after4: "+1 for /srv/deployment-cache" [tools/scap] - 10https://gerrit.wikimedia.org/r/238839 (https://phabricator.wikimedia.org/T109514) (owner: 10Dduvall) [15:44:06] 10Browser-Tests, 5MW-1.26-release, 5Patch-For-Review: It takes about 20 seconds just to start a Sauce Labs browser - https://phabricator.wikimedia.org/T92613#1649505 (10hashar) For core it should be fixed now. I have manually triggered a build : https://integration.wikimedia.org/ci/job/browsertests-Core-en.w... [15:44:18] 10Browser-Tests, 5MW-1.26-release, 5Patch-For-Review, 7Tracking, 5WMF-deploy-2015-09-22_(1.26wmf24): Remove regular expressions in browser tests page element selectors - https://phabricator.wikimedia.org/T112291#1649506 (10hashar) For core it should be fixed now. I have manually triggered a build : https... [15:48:30] 10Browser-Tests, 10QuickSurveys, 5Patch-For-Review, 3Reading-Web-Sprint-56-Four Lions: QA: Setup browser tests on beta cluster so we can share test articles - https://phabricator.wikimedia.org/T112204#1649527 (10hashar) The Jenkins job has been deployed, albeit it is falling http://integration.wikimedia.or... [15:50:27] 10Browser-Tests, 10QuickSurveys, 5Patch-For-Review, 3Reading-Web-Sprint-56-Four Lions: QA: Setup browser tests on beta cluster so we can share test articles - https://phabricator.wikimedia.org/T112204#1649542 (10Jdlrobson) @hashar see discussion above. So essentially there is some configuration in tests/br... [15:57:12] (03CR) 10Hashar: [C: 031] Support batch size configuration per stage [tools/scap] - 10https://gerrit.wikimedia.org/r/239016 (https://phabricator.wikimedia.org/T112841) (owner: 10Dduvall) [15:59:14] thcipriani: hey :-} For the atomic system https://gerrit.wikimedia.org/r/#/c/238839/ , we could have the revisions namespaces by date/time for easy garbage collection [15:59:28] just a random idea [16:01:22] hashar: that's true. I think the way this is dealt with in capistrano and chef is keep 5 directories under `revs` and delete the oldest at deploy time if there are going to be > 5 [16:01:53] that might work yeah [16:02:06] if they get lost, we can still git checkout HEAD^^^^^^^ and deploy that [16:02:12] that is more or less a rollback as well [16:02:16] really 5 is more than we need, but I think that pattern should work. [16:02:48] a potential concern is the disk space used by a checkout of core + all extensions. No idea how many inodes and GB it takes per checkout [16:02:54] at least the .git is hard linked [16:02:58] yeah "rollback" for that patch is only auto-rollback. The behavior is too ambiguous for something like: deploy --rollback [16:03:21] if you guys are interested, you could ask the #net-ops how Juniper (router software) handles rollback [16:03:28] I haven't played with it for years [16:03:41] but I remember the command line was straight forward and made a lot of sense [16:04:34] thcipriani: an interesting feature is you could mark a configuration has valid [16:04:40] then do a bunch of deployment (1, 2 , 3 ) [16:04:48] and if something screw up and you have no idea what went wrong [16:04:58] you would rollback to the rescue save point [16:04:59] so [16:05:09] 0 (rescue), deploy 1, deploy 2, snowball effect building up, deploy 3 [16:05:14] OH no shit happens, what caused it ? [16:05:27] releng: no worries guys. We have a game save. [16:05:30] rollback rescue [16:05:36] releng: see? Safe! [16:05:48] would be for later [16:06:36] heh, yeah, that also gets around the problem of "rollback" as a command line argument having ambiguous/opaque behavior [16:09:34] !log rebase integration puppetmaster [16:11:22] 10Beta-Cluster, 10MediaWiki-extensions-SecurePoll: Extension:Secure Poll throws database error, when try to vote at beta cluster - https://phabricator.wikimedia.org/T112818#1649626 (10Reedy) >>! In T112818#1649386, @greg wrote: > Just to be sure: SecurePoll will always need those manual steps to setup correctl... [16:16:08] 10Beta-Cluster, 10MediaWiki-extensions-SecurePoll: Extension:Secure Poll throws database error, when try to vote at beta cluster - https://phabricator.wikimedia.org/T112818#1649635 (10greg) cool, thanks [16:22:05] (03PS3) 10Dduvall: Login helper for fast API-based authentication [selenium] - 10https://gerrit.wikimedia.org/r/226950 (https://phabricator.wikimedia.org/T112908) [16:22:45] (03CR) 10jenkins-bot: [V: 04-1] Login helper for fast API-based authentication [selenium] - 10https://gerrit.wikimedia.org/r/226950 (https://phabricator.wikimedia.org/T112908) (owner: 10Dduvall) [16:24:14] 10Browser-Tests, 5Patch-For-Review: Authenticate via the API for login steps - https://phabricator.wikimedia.org/T112908#1649654 (10dduvall) [16:25:10] 10Beta-Cluster, 5Patch-For-Review: Beta cluster "test.wikipedia" should be fully moved to "test.wikimedia" - https://phabricator.wikimedia.org/T99156#1649709 (10Reedy) [16:25:53] 10Beta-Cluster: Redirect test.wikipedia to test.wikimedia in beta - https://phabricator.wikimedia.org/T99156#1649714 (10Reedy) [16:26:40] 10Beta-Cluster: Redirect test.wikipedia to test.wikimedia in beta - https://phabricator.wikimedia.org/T99156#1286436 (10Reedy) [16:40:28] (03CR) 10CSteipp: [C: 031] "If it does what the commit message says, yay!" [selenium] - 10https://gerrit.wikimedia.org/r/226950 (https://phabricator.wikimedia.org/T112908) (owner: 10Dduvall) [16:40:36] 10Continuous-Integration-Infrastructure, 10Wikidata, 3Wikidata-Sprint-2015-09-15: [Bug] Intermittent qunit failures (MessageBlobStore::insertMessageBlob failed, database locked during setup) - https://phabricator.wikimedia.org/T111530#1649817 (10JanZerebecki) [16:51:33] (03PS1) 10JanZerebecki: Run qunit tests with mysql instead of sqlite [integration/config] - 10https://gerrit.wikimedia.org/r/239130 [16:57:33] (03PS1) 10Dduvall: WIP Proof of concept for disableLogs SauceLabs option [selenium] - 10https://gerrit.wikimedia.org/r/239132 (https://phabricator.wikimedia.org/T89353) [16:58:06] (03CR) 10jenkins-bot: [V: 04-1] WIP Proof of concept for disableLogs SauceLabs option [selenium] - 10https://gerrit.wikimedia.org/r/239132 (https://phabricator.wikimedia.org/T89353) (owner: 10Dduvall) [17:05:42] (03CR) 10Dduvall: "> I would have expected 2 calls, one to get the login csrf token, and the second to actually login. Hopefully that magic happens somewhere" [selenium] - 10https://gerrit.wikimedia.org/r/226950 (https://phabricator.wikimedia.org/T112908) (owner: 10Dduvall) [17:06:50] 10Continuous-Integration-Infrastructure, 10Wikidata, 3Wikidata-Sprint-2015-09-15: [Bug] Intermittent qunit failures (MessageBlobStore::insertMessageBlob failed, database locked during setup) - https://phabricator.wikimedia.org/T111530#1649905 (10JanZerebecki) I thought T90001 would fix this because it is int... [17:15:26] (03PS4) 10Dduvall: Login helper for fast API-based authentication [selenium] - 10https://gerrit.wikimedia.org/r/226950 (https://phabricator.wikimedia.org/T112908) [17:15:28] (03PS2) 10Dduvall: WIP Proof of concept for disableLogs SauceLabs option [selenium] - 10https://gerrit.wikimedia.org/r/239132 (https://phabricator.wikimedia.org/T89353) [17:17:45] (03CR) 10jenkins-bot: [V: 04-1] Login helper for fast API-based authentication [selenium] - 10https://gerrit.wikimedia.org/r/226950 (https://phabricator.wikimedia.org/T112908) (owner: 10Dduvall) [17:17:54] (03CR) 10jenkins-bot: [V: 04-1] WIP Proof of concept for disableLogs SauceLabs option [selenium] - 10https://gerrit.wikimedia.org/r/239132 (https://phabricator.wikimedia.org/T89353) (owner: 10Dduvall) [17:44:23] Two spaces or one after a sentence for our inline doc? [17:49:26] (03PS1) 10Legoktm: Whitelist MarcoAurelio [integration/config] - 10https://gerrit.wikimedia.org/r/239146 [17:50:48] AndyRussG: blank line? Or spaces? [17:51:54] (03CR) 10Legoktm: [C: 032] Whitelist MarcoAurelio [integration/config] - 10https://gerrit.wikimedia.org/r/239146 (owner: 10Legoktm) [17:52:04] (03CR) 10Alex Monk: [C: 031] Whitelist MarcoAurelio [integration/config] - 10https://gerrit.wikimedia.org/r/239146 (owner: 10Legoktm) [17:52:48] Reedy: hi! asking about spaces... There's a debate in language style circles about whether on the computer we should put one or two spaces after a period. Mostly it's resolved and people use one. Just reviewing some code where someone put two, and I was wondering if we have any standards on this silly nitpicky point. [17:53:08] I guess maybe we don't... I mean, I don't think we have standards for which regional English spellings to use, either... [17:53:12] I don't ever recall seeing we did [17:53:39] Reedy: hmm... thanks! :) [17:53:56] Rgg maybe I should get back to real code review ;p [18:00:43] (03Abandoned) 10JanZerebecki: Run qunit tests with mysql instead of sqlite [integration/config] - 10https://gerrit.wikimedia.org/r/239130 (owner: 10JanZerebecki) [18:05:59] (03PS5) 10Dduvall: Login helper for fast API-based authentication [selenium] - 10https://gerrit.wikimedia.org/r/226950 (https://phabricator.wikimedia.org/T112908) [18:06:01] (03PS3) 10Dduvall: WIP Proof of concept for disableLogs SauceLabs option [selenium] - 10https://gerrit.wikimedia.org/r/239132 (https://phabricator.wikimedia.org/T89353) [18:07:15] (03CR) 10jenkins-bot: [V: 04-1] Login helper for fast API-based authentication [selenium] - 10https://gerrit.wikimedia.org/r/226950 (https://phabricator.wikimedia.org/T112908) (owner: 10Dduvall) [18:07:20] (03CR) 10jenkins-bot: [V: 04-1] WIP Proof of concept for disableLogs SauceLabs option [selenium] - 10https://gerrit.wikimedia.org/r/239132 (https://phabricator.wikimedia.org/T89353) (owner: 10Dduvall) [18:12:26] (03Merged) 10jenkins-bot: Whitelist MarcoAurelio [integration/config] - 10https://gerrit.wikimedia.org/r/239146 (owner: 10Legoktm) [18:15:54] (03CR) 10jenkins-bot: [V: 04-1] Login helper for fast API-based authentication [selenium] - 10https://gerrit.wikimedia.org/r/226950 (https://phabricator.wikimedia.org/T112908) (owner: 10Dduvall) [18:16:08] !log deploying https://gerrit.wikimedia.org/r/239146 [18:17:53] (03CR) 10jenkins-bot: [V: 04-1] WIP Proof of concept for disableLogs SauceLabs option [selenium] - 10https://gerrit.wikimedia.org/r/239132 (https://phabricator.wikimedia.org/T89353) (owner: 10Dduvall) [18:22:34] (03PS7) 10Dduvall: Login helper for fast API-based authentication [selenium] - 10https://gerrit.wikimedia.org/r/226950 (https://phabricator.wikimedia.org/T112908) [18:22:36] (03PS5) 10Dduvall: WIP Proof of concept for disableLogs SauceLabs option [selenium] - 10https://gerrit.wikimedia.org/r/239132 (https://phabricator.wikimedia.org/T89353) [18:24:36] (03CR) 10jenkins-bot: [V: 04-1] Login helper for fast API-based authentication [selenium] - 10https://gerrit.wikimedia.org/r/226950 (https://phabricator.wikimedia.org/T112908) (owner: 10Dduvall) [18:27:18] (03CR) 10Dduvall: "recheck" [selenium] - 10https://gerrit.wikimedia.org/r/226950 (https://phabricator.wikimedia.org/T112908) (owner: 10Dduvall) [18:28:46] 10Continuous-Integration-Infrastructure: handle composer require-dev together with mediawiki-vendor - https://phabricator.wikimedia.org/T112895#1650264 (10JanZerebecki) One way would be to implement a composer update --only-dev. [18:43:30] 10Continuous-Integration-Infrastructure: handle composer require-dev together with mediawiki-vendor - https://phabricator.wikimedia.org/T112895#1650356 (10Legoktm) I was thinking of: clone mediawiki/vendor, add use composer-merge-plugin to include mediawiki/core's composer.json, and then run `composer install`,... [18:50:02] 10Beta-Cluster, 10Analytics-EventLogging, 10Fundraising-Backlog, 6Labs, and 3 others: Betawiki EventLogging data is disappearing? - https://phabricator.wikimedia.org/T112926#1650382 (10awight) 3NEW [18:52:42] 10Beta-Cluster, 6Labs, 10Ops-Access-Requests, 6operations: Add AWight and EWulczyn to the deployment-prep Nova project - https://phabricator.wikimedia.org/T112927#1650389 (10awight) 3NEW [18:54:38] 10Beta-Cluster, 10Analytics-EventLogging, 10Fundraising-Backlog, 6Labs, and 3 others: Betawiki EventLogging data is disappearing? - https://phabricator.wikimedia.org/T112926#1650405 (10Ottomata) eventlogging and database have been moved to deployment-eventlogging03 instance. Needed to upgrade from Precise... [18:57:19] 10Beta-Cluster, 6Labs, 10Ops-Access-Requests, 6operations: Add AWight and EWulczyn to the deployment-prep Nova project - https://phabricator.wikimedia.org/T112927#1650422 (10Krenair) Why is this in #Ops-Access-Requests and #operations? [18:59:25] 10Beta-Cluster, 6Labs, 10Ops-Access-Requests, 6operations: Add AWight and EWulczyn to the deployment-prep Nova project - https://phabricator.wikimedia.org/T112927#1650429 (10greg) 1) Beta Cluster, not beta labs (please rename your wikipage), see https://wikitech.wikimedia.org/wiki/Labs_labs_labs 2) no nee... [18:59:36] 10Beta-Cluster: Add AWight and EWulczyn to the deployment-prep Nova project - https://phabricator.wikimedia.org/T112927#1650430 (10greg) [19:02:07] 10Beta-Cluster: Add AWight and EWulczyn to the deployment-prep Nova project - https://phabricator.wikimedia.org/T112927#1650441 (10Krenair) I renamed it [19:03:59] 10Beta-Cluster, 6Labs: Add AWight and EWulczyn to the deployment-prep Nova project - https://phabricator.wikimedia.org/T112927#1650451 (10Krenair) Failed to add Awight to deployment-prep. Failed to add EWulczyn to deployment-prep. [19:04:08] 10Beta-Cluster, 6Labs: Add AWight and EWulczyn to the deployment-prep Nova project - https://phabricator.wikimedia.org/T112927#1650453 (10greg) Should be done, now. (And thanks for renaming :) ) [19:04:46] 10Beta-Cluster, 6Labs, 15User-greg: Add AWight and EWulczyn to the deployment-prep Nova project - https://phabricator.wikimedia.org/T112927#1650458 (10Krenair) a:3greg Ah, looks like @greg got there first [19:04:49] 10Beta-Cluster, 6Labs, 15User-greg: Add AWight and EWulczyn to the deployment-prep Nova project - https://phabricator.wikimedia.org/T112927#1650462 (10Krenair) 5Open>3Resolved [19:04:56] 10Beta-Cluster, 15User-greg: Add AWight and EWulczyn to the deployment-prep Nova project - https://phabricator.wikimedia.org/T112927#1650389 (10Krenair) [19:05:05] 10Beta-Cluster, 15User-greg: Add AWight and EWulczyn to the deployment-prep Nova project - https://phabricator.wikimedia.org/T112927#1650464 (10greg) Krenair: I just did it via: * https://wikitech.wikimedia.org/wiki/Special:NovaProject * clicking on "add member" in the members area (not projectadmin), worked [19:05:34] Krenair: heh, edit conflicts galore :) [19:05:40] :/ [19:07:06] Krenair: thanks for the help [19:07:12] 10Continuous-Integration-Infrastructure: handle composer require-dev together with mediawiki-vendor - https://phabricator.wikimedia.org/T112895#1650494 (10JanZerebecki) If one updated something in core but not vendor that would still lead to an update instead of a failed job. Doing that while merging the compose... [19:16:20] Krenair: cleanup: https://wikitech.wikimedia.org/wiki/Special:Contributions/Greg_Grossmeier ;) [19:25:27] (03CR) 10Legoktm: "Dependency has been merged." [integration/config] - 10https://gerrit.wikimedia.org/r/239047 (https://phabricator.wikimedia.org/T112821) (owner: 10Zfilipin) [19:25:44] 10Beta-Cluster, 10Analytics-EventLogging, 10Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, and 2 others: Beta Cluster EventLogging data is disappearing? - https://phabricator.wikimedia.org/T112926#1650603 (10greg) [19:28:04] 10Beta-Cluster, 10Analytics-EventLogging, 10Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, and 2 others: Beta Cluster EventLogging data is disappearing? - https://phabricator.wikimedia.org/T112926#1650613 (10AndyRussG) Many thanks @Ottomata!! K I see it now in /var/log/eventlogging/all-events.l... [19:28:30] 10Beta-Cluster, 10Analytics-EventLogging, 10Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, and 2 others: Beta Cluster EventLogging data is disappearing? - https://phabricator.wikimedia.org/T112926#1650620 (10greg) >>! In T112926#1650405, @Ottomata wrote: > What is the proper channel? * Absolut... [19:30:58] 10Beta-Cluster, 10Analytics-EventLogging, 10Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, and 2 others: Beta Cluster EventLogging data is disappearing? - https://phabricator.wikimedia.org/T112926#1650640 (10Ottomata) Ok, thanks. I think I migrated this service very hastily, since we were chan... [19:33:44] 10Beta-Cluster, 10Analytics-EventLogging, 10Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, and 2 others: Beta Cluster EventLogging data is disappearing? - https://phabricator.wikimedia.org/T112926#1650654 (10greg) I think it let's anyone email it. I clean the backlog daily, fwiw (thanks to `lis... [19:36:49] 10Beta-Cluster, 15User-greg: Add AWight and EWulczyn to the deployment-prep Nova project - https://phabricator.wikimedia.org/T112927#1650682 (10awight) [19:39:10] 6RelEng-Admin, 15User-greg: Update Master Project List (MPL) by end of Q1 / before Q2 FY 2015-2016 - https://phabricator.wikimedia.org/T108629#1650697 (10greg) 5Open>3Resolved a:3greg [19:51:40] (03PS1) 10Paladox: [LightweightRDFa] Add dependance on WikiEditor [integration/config] - 10https://gerrit.wikimedia.org/r/239189 [19:52:18] (03PS2) 10Paladox: [LightweightRDFa] Add dependance on WikiEditor [integration/config] - 10https://gerrit.wikimedia.org/r/239189 [19:52:44] (03PS3) 10Paladox: [LightweightRDFa] Add dependance on WikiEditor [integration/config] - 10https://gerrit.wikimedia.org/r/239189 (https://phabricator.wikimedia.org/T93727) [19:53:35] (03CR) 10Raimond Spekking: "removing myself as reviwer" [integration/config] - 10https://gerrit.wikimedia.org/r/239189 (https://phabricator.wikimedia.org/T93727) (owner: 10Paladox) [20:44:36] Project UploadWizard-api-commons.wikimedia.beta.wmflabs.org build #2597: FAILURE in 35 sec: https://integration.wikimedia.org/ci/job/UploadWizard-api-commons.wikimedia.beta.wmflabs.org/2597/ [20:48:01] 10Deployment-Systems, 10ContentTranslation-Deployments, 10MediaWiki-extensions-ContentTranslation, 7I18n: is shown instead of the actual message on Special:ContentTranslation in production - https://phabricator.wikimedia.org/T112964#1651145 (10Amire80) [20:53:21] (03CR) 10Dduvall: [C: 04-1] "This makes a lot more sense now that I'm seeing it applied and seems like a great overall improvement." (034 comments) [tools/scap] - 10https://gerrit.wikimedia.org/r/239028 (owner: 1020after4) [20:56:14] 10Differential, 10Gerrit-Migration: Document git-review -> arc mapping. - https://phabricator.wikimedia.org/T112967#1651221 (10cscott) 3NEW [20:56:42] 10Differential, 10Gerrit-Migration: Document git-review -> arc mapping. - https://phabricator.wikimedia.org/T112967#1651231 (10cscott) [20:56:44] 10Gerrit-Migration: Identify Arcanist showstoppers for wikimedians - https://phabricator.wikimedia.org/T597#1651230 (10cscott) [21:01:39] 10Continuous-Integration-Infrastructure, 10MediaWiki-extensions-ContentTranslation: ContentTranslation builds are failing with seemingly unrelated errors - 2015-09-17 - https://phabricator.wikimedia.org/T112968#1651244 (10Amire80) 3NEW [21:07:09] (03CR) 1020after4: "The only problem with just using the context manager without the global function is that you wouldn't be able to get a logger without crea" (034 comments) [tools/scap] - 10https://gerrit.wikimedia.org/r/239028 (owner: 1020after4) [21:08:07] (03PS1) 10Jforrester: Test the Score extension alongside VisualEditor [integration/config] - 10https://gerrit.wikimedia.org/r/239281 [21:08:21] legoktm: Could you sling that ^^^ into CI? [21:11:40] I heard he was super busy [21:15:15] Bah. [21:15:23] All the CI experts are always super-busy. [21:17:32] I'm super busy? [21:18:10] * James_F bows before super-busy legoktm. [21:20:02] (03CR) 10Dduvall: A context manager for managing nested loggers (031 comment) [tools/scap] - 10https://gerrit.wikimedia.org/r/239028 (owner: 1020after4) [21:20:48] twentyafterfour: sorry to nitpick about naming :) it's my nature [21:21:18] what do think about the decorator idea? [21:21:18] (03CR) 1020after4: "I'm going to refactor this to address the concerns Dan mentioned (above) and the discussion I had with Tyler just now via google Hangouts." [tools/scap] - 10https://gerrit.wikimedia.org/r/239028 (owner: 1020after4) [21:22:10] marxarelli: it's ok, I wasn't happy with the naming either. The decorator is a fine idea, I just hadn't gotten that far yet ;) [21:23:56] (03CR) 10Legoktm: [C: 04-1] "Dependencies should be added in zuul/ext_dependencies.py" [integration/config] - 10https://gerrit.wikimedia.org/r/239281 (owner: 10Jforrester) [21:27:59] 10Deployment-Systems, 6WMF-Legal, 7Documentation, 7Software-Licensing: mediawiki/tools/scap is lacking a license - https://phabricator.wikimedia.org/T94239#1651404 (10Ricordisamoa) [21:28:38] (03CR) 10Jdlrobson: [C: 031] Update WikidataPageBanner tests [integration/config] - 10https://gerrit.wikimedia.org/r/226913 (owner: 10Paladox) [21:31:19] 10Continuous-Integration-Infrastructure, 10MediaWiki-extensions-ContentTranslation: ContentTranslation builds are failing with seemingly unrelated errors - 2015-09-17 - https://phabricator.wikimedia.org/T112968#1651424 (10Legoktm) This is due to https://gerrit.wikimedia.org/r/#/c/235903/, a new test was added... [21:36:26] legoktm: Is that "instead" or "as well"? [21:45:49] 10Continuous-Integration-Infrastructure, 10MediaWiki-extensions-ContentTranslation: ContentTranslation builds are failing with seemingly unrelated errors - 2015-09-17 - https://phabricator.wikimedia.org/T112968#1651529 (10Amire80) Mmm... which are the files in our case? I can't (easily) see it in the Jenkins o... [21:49:09] 10Continuous-Integration-Infrastructure, 10MediaWiki-extensions-ContentTranslation: ContentTranslation builds are failing with seemingly unrelated errors - 2015-09-17 - https://phabricator.wikimedia.org/T112968#1651563 (10Legoktm) From https://integration.wikimedia.org/ci/job/mwext-testextension-zend/8926/cons... [21:50:37] anyone able to merge https://gerrit.wikimedia.org/r/#/c/239158/ so I can stop spamming the internal mailing list with failures..?? :) [22:02:49] legoktm: A one word answer will suffice. :-) [22:12:35] marxarelli: when you have a few minutes, could you please go over https://gerrit.wikimedia.org/r/239291 ? [22:12:57] marxarelli: it's a config change without which restbase stops working after a vagrant git-update [22:13:11] mobrovac: sure thing [22:13:21] grazie! [22:17:40] * James_F assumes instead. [22:17:40] (03PS2) 10Jforrester: Test the Score extension alongside VisualEditor [integration/config] - 10https://gerrit.wikimedia.org/r/239281 [22:18:57] James_F: yeah, instead. [22:19:05] Eurgh. [22:19:09] OK. [22:19:20] James_F: also, you wanted a one word answer, but "as well" is two :P [22:19:28] legoktm: "Former", "Latter". [22:19:39] hehe [22:20:03] Also, why are extensions missing from mediawiki-extensions.yaml? [22:20:25] (03PS3) 10Jforrester: Test the Score extension alongside VisualEditor [integration/config] - 10https://gerrit.wikimedia.org/r/239281 [22:22:08] Yippee, build fixed! [22:22:09] Project browsertests-MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome-sauce build #789: FIXED in 27 min: https://integration.wikimedia.org/ci/job/browsertests-MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome-sauce/789/ [22:35:47] James_F: for most extensions, they don't need an entry in the yaml file anymore, because zuul takes care of everything [22:36:15] the ones that are left are either non-voting or haven't been converted yet [22:36:19] (03CR) 10Legoktm: [C: 032] Test the Score extension alongside VisualEditor [integration/config] - 10https://gerrit.wikimedia.org/r/239281 (owner: 10Jforrester) [22:37:04] (03Merged) 10jenkins-bot: Test the Score extension alongside VisualEditor [integration/config] - 10https://gerrit.wikimedia.org/r/239281 (owner: 10Jforrester) [22:37:40] legoktm: Ah, OK. Thanks! [22:39:10] marxarelli: cheers [22:39:41] mobrovac: no problem [22:40:10] !log deploying https://gerrit.wikimedia.org/r/239281 [22:41:28] (03CR) 10Legoktm: "https://integration.wikimedia.org/ci/job/mwext-testextension-zend/8939/console Passed" [integration/config] - 10https://gerrit.wikimedia.org/r/239281 (owner: 10Jforrester)