[00:19:54] 10Browser-Tests, 5Patch-For-Review, 10reading-web-sprint-58-The-Sixth-Sense: Investigate QuickSurveys browser tests failures - https://phabricator.wikimedia.org/T113534#1729911 (10Jdlrobson) [00:20:09] 10Browser-Tests, 5Patch-For-Review, 10reading-web-sprint-58-The-Sixth-Sense: Investigate QuickSurveys browser tests failures - https://phabricator.wikimedia.org/T113534#1729913 (10Jdlrobson) a:3Jdlrobson Apparently not. [00:35:53] (03PS2) 10Paladox: Add composer-test for 6 extensions [integration/config] - 10https://gerrit.wikimedia.org/r/242350 (owner: 10Siebrand) [00:36:32] (03PS3) 10Paladox: Add composer-test for 6 extensions [integration/config] - 10https://gerrit.wikimedia.org/r/242350 (owner: 10Siebrand) [00:38:53] (03PS4) 10Paladox: Add composer-test for 4 extensions [integration/config] - 10https://gerrit.wikimedia.org/r/242350 (owner: 10Siebrand) [00:39:15] (03CR) 10Paladox: "Rebased and updated commit msg." [integration/config] - 10https://gerrit.wikimedia.org/r/242350 (owner: 10Siebrand) [01:11:28] 10MediaWiki-Codesniffer, 10Possible-Tech-Projects, 3Outreachy-Round-11: Outreachy proposal for : Improving static analysis tools for MediaWiki - https://phabricator.wikimedia.org/T115585#1729942 (10TasneemLo) a:3TasneemLo [03:03:08] (03CR) 10Chad: [C: 032] git-latest-wmf-branch [tools/release] - 10https://gerrit.wikimedia.org/r/244495 (owner: 1020after4) [03:03:29] (03Merged) 10jenkins-bot: git-latest-wmf-branch [tools/release] - 10https://gerrit.wikimedia.org/r/244495 (owner: 1020after4) [03:03:59] (03CR) 10Chad: [C: 032] Make make-extension-branches support skins [tools/release] - 10https://gerrit.wikimedia.org/r/246264 (owner: 10Chad) [03:04:21] (03Merged) 10jenkins-bot: Make make-extension-branches support skins [tools/release] - 10https://gerrit.wikimedia.org/r/246264 (owner: 10Chad) [03:06:46] Project browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-linux-firefox-sauce build #750: 04FAILURE in 16 min: https://integration.wikimedia.org/ci/job/browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-linux-firefox-sauce/750/ [03:15:46] (03PS1) 10Chad: Remove half-baked patchExport functionality [tools/release] - 10https://gerrit.wikimedia.org/r/246803 [03:16:05] (03CR) 10jenkins-bot: [V: 04-1] Remove half-baked patchExport functionality [tools/release] - 10https://gerrit.wikimedia.org/r/246803 (owner: 10Chad) [03:17:07] (03PS2) 10Chad: Remove half-baked patchExport functionality [tools/release] - 10https://gerrit.wikimedia.org/r/246803 [03:19:23] how was that supposed to work? [03:19:32] > patchRevisions = [] [03:19:32] > for patch in patchRevisions: [03:24:49] (03CR) 10Chad: [C: 032] Remove half-baked patchExport functionality [tools/release] - 10https://gerrit.wikimedia.org/r/246803 (owner: 10Chad) [03:25:10] (03Merged) 10jenkins-bot: Remove half-baked patchExport functionality [tools/release] - 10https://gerrit.wikimedia.org/r/246803 (owner: 10Chad) [03:38:26] (03PS1) 10Chad: pep8 fixes [tools/release] - 10https://gerrit.wikimedia.org/r/246804 [03:47:15] (03CR) 10Legoktm: [C: 04-1] pep8 fixes (031 comment) [tools/release] - 10https://gerrit.wikimedia.org/r/246804 (owner: 10Chad) [04:09:46] legoktm: That's half the fun, it didn't! :) [04:09:54] I saw how it would work in theory, but just didn't in practice. [04:10:03] I'm about 75% through rewriting it to be useful [04:10:18] :DDDDD [04:10:38] yeah, I think I saw the bug for that [04:13:48] Until I hit the point where make-release doesn't want to work on releases that haven't been tagged yet [04:13:52] * ostriches goes for a drink before continuing [05:17:16] PROBLEM - Puppet failure on deployment-cache-parsoid04 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [05:17:16] PROBLEM - Puppet failure on deployment-cache-mobile04 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [05:25:50] Yippee, build fixed! [05:25:50] Project browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-windows_7-internet_explorer-11-sauce build #573: 09FIXED in 23 min: https://integration.wikimedia.org/ci/job/browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-windows_7-internet_explorer-11-sauce/573/ [06:33:12] (03CR) 10Chad: pep8 fixes (031 comment) [tools/release] - 10https://gerrit.wikimedia.org/r/246804 (owner: 10Chad) [06:42:11] (03CR) 10Legoktm: pep8 fixes (031 comment) [tools/release] - 10https://gerrit.wikimedia.org/r/246804 (owner: 10Chad) [06:53:30] Project UploadWizard-api-commons.wikimedia.org build #2152: 04FAILURE in 30 sec: https://integration.wikimedia.org/ci/job/UploadWizard-api-commons.wikimedia.org/2152/ [07:30:11] 7Blocked-on-RelEng, 10Deployment-Systems, 3Scap3, 6Discovery: Create deployment for wikimedia/portals - https://phabricator.wikimedia.org/T114694#1730214 (10mmodell) When we initially discussed it in #wikimedia-releng on IRC, there were ~~shitloads of~~ several conflicting opinions and disagreements, leadi... [07:57:39] 5Continuous-Integration-Scaling, 7Tracking: [tracking] Disposable VMs need a cache for package managers - https://phabricator.wikimedia.org/T112560#1730232 (10hashar) [07:57:40] 10Continuous-Integration-Infrastructure, 5Continuous-Integration-Scaling: Evaluate devpi for caching Pypi python packages - https://phabricator.wikimedia.org/T114871#1730230 (10hashar) 5Open>3Resolved I have completed the evaluation. It works pretty much out of the box. [07:59:23] 5Continuous-Integration-Scaling, 7Tracking: [tracking] Disposable VMs need a cache for package managers - https://phabricator.wikimedia.org/T112560#1638442 (10hashar) I gave a try to Artifactory (similar to Sonatype Nexus) but support for npm/pip/gem is not included in the open source version. Looking at ups... [08:02:29] 5Continuous-Integration-Scaling, 7Tracking: [tracking] Disposable VMs need a cache for package managers - https://phabricator.wikimedia.org/T112560#1730234 (10hashar) Another idea was to setup a Squid proxy for https request and configure it to act as a man in the middle. That can be done using the Squid featu... [08:12:14] (03PS1) 10Chad: Implement patch support for make-release [tools/release] - 10https://gerrit.wikimedia.org/r/246809 (https://phabricator.wikimedia.org/T115493) [08:12:28] Wheeee [08:23:51] (03PS5) 10Hashar: Add composer-test and npm for 4 extensions [integration/config] - 10https://gerrit.wikimedia.org/r/242350 (owner: 10Siebrand) [08:24:05] (03CR) 10Hashar: "I have added npm while at it." [integration/config] - 10https://gerrit.wikimedia.org/r/242350 (owner: 10Siebrand) [08:28:07] (03CR) 10Hashar: [C: 032] Add composer-test and npm for 4 extensions [integration/config] - 10https://gerrit.wikimedia.org/r/242350 (owner: 10Siebrand) [08:29:10] (03Merged) 10jenkins-bot: Add composer-test and npm for 4 extensions [integration/config] - 10https://gerrit.wikimedia.org/r/242350 (owner: 10Siebrand) [08:33:12] Yippee, build fixed! [08:33:12] Project browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-os_x_10.9-safari-sauce build #753: 09FIXED in 23 min: https://integration.wikimedia.org/ci/job/browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-os_x_10.9-safari-sauce/753/ [08:36:00] (03CR) 10Hashar: "Done / deployed and all dependencies have been merged via +2 \O/" [integration/config] - 10https://gerrit.wikimedia.org/r/242350 (owner: 10Siebrand) [08:37:50] (03CR) 10Hashar: [C: 04-1] "All those jobs are legacy. We are migrating to solely use 'tox-jessie' which runs 'tox' and executes whatever env have been listed in tox" [integration/config] - 10https://gerrit.wikimedia.org/r/246776 (owner: 10Paladox) [08:45:15] (03CR) 10Hashar: [C: 04-1] "The EventLogging extension does not have any configuration for JSDuck. It would need a /jsduck.json to teach it what to run." [integration/config] - 10https://gerrit.wikimedia.org/r/246773 (https://phabricator.wikimedia.org/T88343) (owner: 10Paladox) [09:30:38] PROBLEM - Puppet failure on deployment-fluorine is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [10:07:33] 6Release-Engineering-Team, 6operations: Monitor Phabricator and Gerrit availability - https://phabricator.wikimedia.org/T115611#1730343 (10Aklapper) To some extend related: {T109279} [10:09:30] (03CR) 10Paladox: "@Hashar please could you review this." [integration/config] - 10https://gerrit.wikimedia.org/r/246712 (https://phabricator.wikimedia.org/T115061) (owner: 10Paladox) [10:11:23] (03CR) 10Paladox: "@Hashar please review this." [integration/config] - 10https://gerrit.wikimedia.org/r/245967 (owner: 10Paladox) [10:42:29] 10Browser-Tests, 7I18n, 5Patch-For-Review, 5WMF-deploy-2015-10-13_(1.27.0-wmf.3): Hacking: Load i18n messages from MediaWiki to browser tests - https://phabricator.wikimedia.org/T90577#1730373 (10Jhernandez) @zeljkofilipin Awesome! You should post to wikitech-l or wikimedia-engineering when this is complet... [10:57:34] 10MediaWiki-Codesniffer, 3Outreachy-Round-11: Outreachy proposal for : Improving static analysis tools for MediaWiki - https://phabricator.wikimedia.org/T115585#1730379 (10NiharikaKohli) [12:29:32] (03PS1) 10Bmansurov: Add dependencies to Cards and Related articles [integration/config] - 10https://gerrit.wikimedia.org/r/246818 [12:44:26] (03PS2) 10Bmansurov: Add dependencies to Cards and Related articles [integration/config] - 10https://gerrit.wikimedia.org/r/246818 [12:48:09] (03PS1) 10JanZerebecki: Add repo wikidata/query/deploy [integration/config] - 10https://gerrit.wikimedia.org/r/246819 [12:48:49] (03CR) 10jenkins-bot: [V: 04-1] Add repo wikidata/query/deploy [integration/config] - 10https://gerrit.wikimedia.org/r/246819 (owner: 10JanZerebecki) [12:49:25] (03PS3) 10Bmansurov: Add a template to Cards and Related articles [integration/config] - 10https://gerrit.wikimedia.org/r/246818 [12:51:09] (03CR) 10jenkins-bot: [V: 04-1] Add a template to Cards and Related articles [integration/config] - 10https://gerrit.wikimedia.org/r/246818 (owner: 10Bmansurov) [12:52:26] (03PS4) 10Bmansurov: Add templates to Cards and Related articles [integration/config] - 10https://gerrit.wikimedia.org/r/246818 [12:53:33] Yippee, build fixed! [12:53:34] Project UploadWizard-api-commons.wikimedia.org build #2153: 09FIXED in 32 sec: https://integration.wikimedia.org/ci/job/UploadWizard-api-commons.wikimedia.org/2153/ [12:54:19] (03CR) 10jenkins-bot: [V: 04-1] Add templates to Cards and Related articles [integration/config] - 10https://gerrit.wikimedia.org/r/246818 (owner: 10Bmansurov) [12:55:21] (03PS5) 10Bmansurov: Add templates to Cards and Related articles [integration/config] - 10https://gerrit.wikimedia.org/r/246818 [12:56:23] !log Added Cards and RelatedArticles to the shared jobs mediawiki-extensions-*' https://gerrit.wikimedia.org/r/#/c/246818/ [12:56:29] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL, Master [12:58:30] (03CR) 10JanZerebecki: [C: 04-2] "npm is not configured yet in this repo and the repo is currently directly pushed to." [integration/config] - 10https://gerrit.wikimedia.org/r/246819 (owner: 10JanZerebecki) [12:59:44] (03CR) 10Hashar: [C: 032] "I have refreshed the Jenkins jobs. Lets see what happens :-)" [integration/config] - 10https://gerrit.wikimedia.org/r/246818 (owner: 10Bmansurov) [12:59:54] (03PS2) 10JanZerebecki: Add repo wikidata/query/deploy [integration/config] - 10https://gerrit.wikimedia.org/r/246819 [13:01:55] (03Merged) 10jenkins-bot: Add templates to Cards and Related articles [integration/config] - 10https://gerrit.wikimedia.org/r/246818 (owner: 10Bmansurov) [13:03:07] (03CR) 10JanZerebecki: "@Smalyshev is it fine if we switch this repo from direct push to reviewed patches via gerrit and enable CI? I'd like to merge a few JS cha" [integration/config] - 10https://gerrit.wikimedia.org/r/246819 (owner: 10JanZerebecki) [13:18:01] (03PS1) 10Hashar: Revert RelatedArticles from the shared job [integration/config] - 10https://gerrit.wikimedia.org/r/246829 [13:19:14] (03CR) 10Hashar: "Cards is all fine." [integration/config] - 10https://gerrit.wikimedia.org/r/246818 (owner: 10Bmansurov) [13:19:33] (03CR) 10Hashar: [C: 032] "Job deployed" [integration/config] - 10https://gerrit.wikimedia.org/r/246829 (owner: 10Hashar) [13:22:37] (03Merged) 10jenkins-bot: Revert RelatedArticles from the shared job [integration/config] - 10https://gerrit.wikimedia.org/r/246829 (owner: 10Hashar) [13:55:00] (03PS2) 10Chad: pep8 fixes [tools/release] - 10https://gerrit.wikimedia.org/r/246804 [13:55:30] (03CR) 10jenkins-bot: [V: 04-1] pep8 fixes [tools/release] - 10https://gerrit.wikimedia.org/r/246804 (owner: 10Chad) [13:56:01] oh shut up jenkins [13:57:30] (03PS3) 10Chad: pep8 fixes [tools/release] - 10https://gerrit.wikimedia.org/r/246804 [14:04:50] 6Release-Engineering-Team, 6operations: Monitor Phabricator and Gerrit availability - https://phabricator.wikimedia.org/T115611#1730624 (10Dzahn) gerrit process monitoring: https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=ytterbium&service=gerrit+process phabricator http monitoring: http... [14:06:06] 6Release-Engineering-Team, 6operations: Monitor Phabricator and Gerrit availability - https://phabricator.wikimedia.org/T115611#1730626 (10Dzahn) Gerrit availabilty: http://status.wikimedia.org/8777/249692/Gerrit Phabricator availability: http://status.wikimedia.org/8777/388149/Phabricator probably additio... [14:09:33] ostriches: your text editor should report pep8 errors to you [14:09:39] would save a bunch of time [14:09:48] or you can add a local git commit hook that runs tox -eflake8 [14:15:18] I had a plugin for my editor that told me when I screwed up pep8 but it was too noisy :p [14:15:31] I was just running `pep8 .` :) [14:16:00] hashar: That commit was to fix standing pep8 issues in the code, not problems with a prev. commit either :) [14:28:52] hashar: Do you have a few minutes to give some CR on my python? [14:32:49] yaaaa [14:32:55] ostriches: sure ): [14:32:56] :) [14:35:48] Project browsertests-MobileFrontend-SmokeTests-linux-chrome-sauce build #294: 04FAILURE in 7 min 48 sec: https://integration.wikimedia.org/ci/job/browsertests-MobileFrontend-SmokeTests-linux-chrome-sauce/294/ [14:36:05] hashar: https://gerrit.wikimedia.org/r/#/q/owner:chad+is:open+(release+OR+core),n,z [14:36:21] hashar: 2 are mostly style fixes (the core one looks scarier than it is) [14:36:52] The make-release patch support I need today, but it needs some CR first :) [14:36:55] ahargh [14:37:00] pep8 on the poor zhtable .. [14:41:07] hashar: Heh, that one was fun to do :p [14:41:22] It's the /one/ python file we have in core, but it was formatted like MW code, lolol [14:42:21] (03CR) 10Hashar: "Instead of using a continuation marker '\' you can use parenthesis :-}" (031 comment) [tools/release] - 10https://gerrit.wikimedia.org/r/246804 (owner: 10Chad) [14:42:49] ostriches: one lame trick https://gerrit.wikimedia.org/r/#/c/246804/3/make-release/make-release.py,unified [14:43:17] (03CR) 10Chad: pep8 fixes (031 comment) [tools/release] - 10https://gerrit.wikimedia.org/r/246804 (owner: 10Chad) [14:43:36] hashar: I had () originally. lego suggested \ [14:43:40] ohh [14:43:43] my bad sorry :D [14:43:52] Either are fine by pep8, long as you get the indentation right [14:43:54] lets go with \ [14:44:26] (03CR) 10Hashar: [C: 032] "\ was suggest by Kunal so lets go !" [tools/release] - 10https://gerrit.wikimedia.org/r/246804 (owner: 10Chad) [14:44:43] maintenance/language/zhtable/Makefile.py I think I suggest that once upon a time [14:44:47] (03Merged) 10jenkins-bot: pep8 fixes [tools/release] - 10https://gerrit.wikimedia.org/r/246804 (owner: 10Chad) [14:47:31] ostriches: the patch support I have seen passing it around [14:47:34] as well as some discussions [14:47:51] ah that was on T115493 [14:48:08] Yep [14:48:31] if only we migrated out of submodules to a single repo with flattened hierarchy [14:48:34] that would make the patch stuff way easier [14:48:36] There was a half-implemented patch support that was based on fetching things from Gerrit, but I removed that last night in favor of this [14:49:13] any clue how such patches are handled in prod ? [14:49:35] Yes, make-wmf-branch handles them, or should, at least. [14:49:50] I am wondering if we could reuse the logic from there [14:50:04] They share no common code. [14:50:13] OH [14:50:21] /quit we use PHP [14:50:47] And make-release can be run by anybody, technically, to spit out a tarball. No reason they should need specifics from make-wmf-branch & friends. [14:51:08] (ie: joe anon could use it, if he wanted to spit out tarballs for his company or something) [14:51:19] good point [14:54:42] PROBLEM - Puppet staleness on deployment-restbase01 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [43200.0] [14:55:30] Switched to a new branch 'REL1_25' [14:55:30] Applying: SECURITY: [14:55:30] INFO:root:Finished applying patch /a/tools/release/make-release/patches/core/-REL1_25.patch [14:55:47] hashar: Copy+pasted from seeing it in action :) [14:58:02] Hmm, I wonder if glob.glob() sorts or if I should too. [14:58:36] Would be good to make sure we're applying patches in the same order they'd be seen on the fs. Then you can do things like 001-Foo [14:58:38] 002, [14:58:41] To enforce order [15:02:15] 7Blocked-on-RelEng, 10Deployment-Systems, 3Scap3, 6Discovery: Create deployment for wikimedia/portals - https://phabricator.wikimedia.org/T114694#1730769 (10Deskana) >>! In T114694#1730214, @mmodell wrote: > When we initially discussed it in #wikimedia-releng on IRC, there were ~~shitloads of~~ several con... [15:14:44] thcipriani: If you could also glance at https://gerrit.wikimedia.org/r/#/c/246809/, the more eyes the better since I wanna actually use it today. [15:14:46] 6Release-Engineering-Team, 6operations: Monitor Phabricator and Gerrit availability - https://phabricator.wikimedia.org/T115611#1730798 (10greg) Just to be sure: we are NOT talking about the traditional sense of HA (https://en.wikipedia.org/wiki/High_availability) with things like redundancy, quick failover, e... [15:14:55] (pinged because you're python guru :p) [15:15:28] heh, sure I can take a peek [15:16:04] glad my deception is working :P [15:16:26] (03CR) 10Hashar: [C: 04-1] "Great to see some support to deal with patches. I offer some python related advices, not a big deal." (036 comments) [tools/release] - 10https://gerrit.wikimedia.org/r/246809 (https://phabricator.wikimedia.org/T115493) (owner: 10Chad) [15:16:36] ostriches: did some review https://gerrit.wikimedia.org/r/#/c/246809/ [15:16:50] (03PS2) 10Paladox: [EventLogging] Add jsduck test [integration/config] - 10https://gerrit.wikimedia.org/r/246773 (https://phabricator.wikimedia.org/T88343) [15:17:00] ostriches: ahah reading the backlog that is quite fun. I caught glob.glob() sort issue as well :-} [15:17:43] ostriches: git format-patch should already prefix them with a serial number, so we just need to sort glob.glob() [15:18:02] I offered a few other python advices which are nit pick level honestly. [15:18:31] feel free to follow up with from releng import thcipriani as pythonreviewer [15:18:42] heh [15:19:43] git format-patch is nice [15:22:12] (03PS1) 10Paladox: [EventLogging] Update tox tests [integration/config] - 10https://gerrit.wikimedia.org/r/246845 [15:22:27] mobrovac: we will want to sprint a Restbase / cassandra for wmf CI :-} [15:22:52] 10Continuous-Integration-Config, 7WorkType-Maintenance: JJB: replace pyflakes / pep8 jobs with tox-jessie job - https://phabricator.wikimedia.org/T55354#1730817 (10Paladox) [15:23:36] hashar: as in rb/cass testing in jenkins on isolated ci? :P [15:23:46] mobrovac: yeah [15:23:53] hell yeah! [15:24:10] mobrovac: one of the trouble is figuring out a given job needs a given backend (e.g. cassandra, elasticsearch, postgresql etc) [15:24:16] hashar: please review https://gerrit.wikimedia.org/r/#/c/246845/ [15:24:47] hashar: and https://gerrit.wikimedia.org/r/#/c/246841/ and https://gerrit.wikimedia.org/r/#/c/246773/ [15:24:51] paladox: on it already :D [15:25:04] hashar: Ok thanks. [15:25:41] hashar: these patches fix the jenkins tests. [15:25:45] hashar: [15:25:47] hashar: couldn't we invent a config file of sorts for that? like need_isolation: true ; services: cassandra [15:25:51] hashar: https://gerrit.wikimedia.org/r/#/c/246710/ [15:26:06] hashar: https://gerrit.wikimedia.org/r/#/c/246712/ [15:26:29] hashar's gonna blow up from the pings! [15:28:23] (03CR) 10Hashar: "We will need a change to EventLogging tox.ini . See inline for indication :-)" (031 comment) [integration/config] - 10https://gerrit.wikimedia.org/r/246845 (owner: 10Paladox) [15:28:50] mobrovac: yeah kind of like Travis ? :-} [15:29:31] mobrovac: maybe we can just have them all installed and ready for use. We do not need so many backends anyway [15:29:45] ostriches: lgtm save what hashar said. I started to make the `os.path.join` comment for `get_patches_for_repo`, checked irc, refreshed gerrit, saw the comment I was about to make was already there and stated more clearly than what I was about to write :) [15:29:49] (03CR) 10Chad: "All good inline suggestions, commented one place where I think things are confusing." (031 comment) [tools/release] - 10https://gerrit.wikimedia.org/r/246809 (https://phabricator.wikimedia.org/T115493) (owner: 10Chad) [15:30:05] mobrovac: poke me about it next week, we can chat about it :-} [15:30:12] thcipriani: thx [15:30:31] thcipriani: feel free to +2 the patch [15:30:33] whenever it is amended [15:30:38] hashar: yup, sure thing, it's too late now to start diving deeper into the problem :P [15:30:47] aka don't wait for another review from me because that will not happen before monday [15:30:59] mobrovac: yeah gotta fly to school [15:31:32] :) [15:31:37] bon w-e hashar! [15:31:56] ostriches: yeah you can forget my comment about [ if patches: tag = self.version.branch ]  I was just thinking out loud :} [15:32:43] (03CR) 10Paladox: "Ok updated at https://gerrit.wikimedia.org/r/#/c/246846/" [integration/config] - 10https://gerrit.wikimedia.org/r/246845 (owner: 10Paladox) [15:32:53] hashar: If I rename the param/variable, it would be more clear. [15:33:00] Like "gitRef" or something [15:33:10] paladox: for https://gerrit.wikimedia.org/r/#/c/246841/ you will need to find someone familiar with JSDuck. Not sure whom but I know it is in use on at least MobileFrontend ( #wikimedia-mobile ) and VisualEditor / OOJS (no clue what the IRC channels are ) [15:33:56] (03PS3) 10Hashar: [EventLogging] Add jsduck test [integration/config] - 10https://gerrit.wikimedia.org/r/246773 (https://phabricator.wikimedia.org/T88343) (owner: 10Paladox) [15:35:04] hashar: Maybe florian knows about jsduck, I think he added the support to MobileFrontend but not sure about that. [15:37:47] (03CR) 10Hashar: [C: 04-1] "Good you thought about the branch: master filtering." (031 comment) [integration/config] - 10https://gerrit.wikimedia.org/r/246773 (https://phabricator.wikimedia.org/T88343) (owner: 10Paladox) [15:41:50] (03PS2) 10Chad: Implement patch support for make-release [tools/release] - 10https://gerrit.wikimedia.org/r/246809 (https://phabricator.wikimedia.org/T115493) [15:43:28] (03CR) 10Hashar: [C: 031] "@Renoirb this change makes the test suite to run composer install to grab dependencies instead of relying on our mediawiki/vendor.git (whi" [integration/config] - 10https://gerrit.wikimedia.org/r/246712 (https://phabricator.wikimedia.org/T115061) (owner: 10Paladox) [15:43:55] 10Continuous-Integration-Config, 5Patch-For-Review: replace Jenkins job mwext-testextension-zend by mwext-testextension-zend-composer - https://phabricator.wikimedia.org/T115061#1730876 (10hashar) a:3Paladox [15:44:05] paladox: all reviewed! [15:44:16] paladox: will probably review / deploy some over the week-end. But for now I am off [15:44:24] paladox: thanks again! [15:44:44] (03CR) 10Chad: "Addressed most inline comments." (032 comments) [tools/release] - 10https://gerrit.wikimedia.org/r/246809 (https://phabricator.wikimedia.org/T115493) (owner: 10Chad) [15:47:18] 6Release-Engineering-Team: Clone mediawiki into mediawiki-config when running test's via jenkins - https://phabricator.wikimedia.org/T115713#1730888 (10EBernhardson) 3NEW [15:48:06] 10Continuous-Integration-Config, 6Release-Engineering-Team: Clone mediawiki into mediawiki-config when running test's via jenkins - https://phabricator.wikimedia.org/T115713#1730898 (10hashar) [15:48:49] (03CR) 10Chad: [C: 032] "Lots of IRC feedback, being a rogue and self-merging :p" [tools/release] - 10https://gerrit.wikimedia.org/r/246809 (https://phabricator.wikimedia.org/T115493) (owner: 10Chad) [15:50:05] 6Release-Engineering-Team: Reduce production log errors to zero* - https://phabricator.wikimedia.org/T115630#1730914 (10greg) [15:50:11] (03Merged) 10jenkins-bot: Implement patch support for make-release [tools/release] - 10https://gerrit.wikimedia.org/r/246809 (https://phabricator.wikimedia.org/T115493) (owner: 10Chad) [15:51:16] greg-g: zero*, lol [15:51:49] :) [15:54:04] hashar: thanks [16:51:04] 10MediaWiki-Releasing, 6Release-Engineering-Team, 5Patch-For-Review, 7Security-Other, 7WorkType-NewFunctionality: Add patch support to make-release - https://phabricator.wikimedia.org/T115493#1731126 (10demon) [16:51:11] 10MediaWiki-Releasing, 6Release-Engineering-Team, 5Patch-For-Review, 7Security-Other, 7WorkType-NewFunctionality: Add patch support to make-release - https://phabricator.wikimedia.org/T115493#1731127 (10demon) 5Open>3Resolved [17:29:28] (03CR) 10Smalyshev: [C: 04-1] "This should be done to main repository (/wikidata/query/rdf) deploy one is for deployment only, and should match the main one." [integration/config] - 10https://gerrit.wikimedia.org/r/246819 (owner: 10JanZerebecki) [19:10:01] (03PS3) 10JanZerebecki: Add repo wikidata/query/deploy [integration/config] - 10https://gerrit.wikimedia.org/r/246819 [19:31:03] 10Beta-Cluster-Infrastructure, 6Labs, 10Labs-Infrastructure, 7Graphite, 7Shinken: Delete more specific deployment-prep graphite datapoints - https://phabricator.wikimedia.org/T111540#1731786 (10Krenair) @fgiunchedi: Ping [19:32:05] (03CR) 10Hashar: "The job first grab the various gems:" [integration/config] - 10https://gerrit.wikimedia.org/r/246268 (https://phabricator.wikimedia.org/T114860) (owner: 10Hashar) [19:35:53] (03CR) 10JanZerebecki: [C: 04-1] "Ok corrected the repo. This needs https://gerrit.wikimedia.org/r/#/c/246892/ to be merged first." [integration/config] - 10https://gerrit.wikimedia.org/r/246819 (owner: 10JanZerebecki) [19:36:13] (03CR) 10JanZerebecki: [C: 04-1] Add repo wikidata/query/deploy [integration/config] - 10https://gerrit.wikimedia.org/r/246819 (owner: 10JanZerebecki) [19:36:34] hashar: Lots of idle build slots :\ [19:37:17] ostriches: on Jenkins ? [19:37:34] Ya [19:37:40] looks like nothing can trigger mediawiki-core-qunit grr [19:38:02] * hashar blames Jenkins [19:38:19] Aw :( [19:38:29] https://integration.wikimedia.org/ci/job/mediawiki-core-doxygen-publish/ [19:38:33] it is throttled to only one run [19:38:37] that must have some side effects [19:39:01] such as holding a giant lock for all slots [19:40:33] Hmm, wonder if we could make it a bit smarter. If a new change comes in for the same branch, cancel the old job and do a new one. [19:41:47] it is triggered after each merge [19:41:53] we should probably just poll the repo instead [19:42:21] https://integration.wikimedia.org/ci/job/mediawiki-core-qunit/ [19:42:34] the build queue was showing a bunch of instances waiting for an available executor :/ [19:43:28] the Jenkins Throttle plugin is to blame I guess [19:44:04] hashar: Could just poll every 15m or so. [19:44:08] Takes about 10m to build. [19:44:11] yup [19:44:17] instead of triggering it on post merge [19:44:19] via Zuul [19:44:22] * ostriches nods [19:44:56] if I look at the build history https://integration.wikimedia.org/ci/job/mediawiki-core-qunit/buildTimeTrend [19:45:09] it seems to mostly trigger it on the same node [19:45:10] nodes [19:45:14] 1011 and 1015 [19:45:19] instead of spreading it to other slaves [19:50:09] ostriches: you should teach me the java build/dev environment one day :-} [19:50:58] hehe :) [19:51:56] so in short [19:52:02] that plugin https://wiki.jenkins-ci.org/display/JENKINS/Throttle+Concurrent+Builds+Plugin seems to mis behave [19:52:25] it is used to only have one occurrence of a job per node [19:53:00] and apparently Jenkins scheduler attempts to assign a job to a node that previously build it [19:53:10] so I guess the plugin queue the build [19:56:12] hashar: could you review https://gerrit.wikimedia.org/r/#/c/246426/ please. [19:56:46] hashar: Also review https://gerrit.wikimedia.org/r/#/c/245493/ please, It was request by Nikerabbit. [19:56:59] hashar: Also https://gerrit.wikimedia.org/r/#/c/245903/ too please. [19:58:54] hashar: It seems that https://integration.wikimedia.org/zuul/ is very slow merging the mediawiki patches. seems 44 mins now [19:59:14] paladox: in postmerge right ? [19:59:27] hashar: yes. [19:59:42] hashar: Seems that mediawiki-core-doxygen-publish test hasent started. [19:59:50] yeah [19:59:57] there is only one version of that job allowed to run [20:00:12] hashar: Oh ok. [20:00:24] which is rather lame [20:01:02] yes. Since there is a huge queue [20:24:53] !log disconnected / reconnected a bunch of trusty slaves. Seems some node executors were disabled/deadlocked [20:24:56] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL, Master [20:26:36] 6Release-Engineering-Team, 6Commons, 10MediaWiki-File-management, 10MediaWiki-Tarball-Backports, and 7 others: InstantCommons broken by switch to HTTPS - https://phabricator.wikimedia.org/T102566#1731944 (10Umherirrender) 5Open>3Resolved [20:32:08] hashar: it shows https://integration.wikimedia.org/zuul/ as test mediawiki-core-doxygen-publish is queued. Shoulden it be testing now since no other repo is being tested. [20:32:56] Also very slow on other tests since it shows mwext-Flow-testextension-hhvm and mwext-testextension-hhvm and npm as queued. [20:33:38] hashar: Seems most tests are showing as queued. [20:34:09] !log cancelled a bunch of https://integration.wikimedia.org/ci/job/mediawiki-core-doxygen-publish/ jobs. We keep rebuilding over and over REL* merged changes [20:34:16] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL, Master [20:40:17] 10Continuous-Integration-Config: Rewrite mediawiki-core-doxygen-publish Jenkins job to poll scm instead of being triggered by Zuul - https://phabricator.wikimedia.org/T115755#1731977 (10hashar) 3NEW [20:41:51] ostriches: I cancelled a bunch of doxygen jobs [20:42:02] mmk [20:42:17] and filled https://phabricator.wikimedia.org/T115755 [20:42:25] to change the job to poll the SCM [20:48:54] ostriches: bah Zuul adds them back :D [20:49:28] Bad zuul! [20:50:23] mass cancelling [20:51:43] !log Restarting Jenkins to remove potential dead locks before the week-end [20:51:46] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL, Master [20:52:09] Project browsertests-Flow-en.wikipedia.beta.wmflabs.org-linux-chrome-sauce build #798: 15ABORTED in 25 min: https://integration.wikimedia.org/ci/job/browsertests-Flow-en.wikipedia.beta.wmflabs.org-linux-chrome-sauce/798/ [21:00:09] hashar: Please could you merge https://gerrit.wikimedia.org/r/#/c/246426/ since Jforrester said that https://gerrit.wikimedia.org/r/#/c/246424/ can be merged once the composer-test is live. [21:05:09] paladox: sure [21:05:12] (03PS4) 10Hashar: [Flow] Update Jenkins tests [integration/config] - 10https://gerrit.wikimedia.org/r/246426 (owner: 10Paladox) [21:05:18] hashar: Thanks. [21:05:21] (03CR) 10Hashar: [C: 032] [Flow] Update Jenkins tests [integration/config] - 10https://gerrit.wikimedia.org/r/246426 (owner: 10Paladox) [21:05:40] paladox: can you add one for the REL1_26 branch as well please? :) [21:05:52] hashar: Ok will do that now. [21:06:55] hashar: Done at https://gerrit.wikimedia.org/r/#/c/246981/ now. [21:07:13] hashar: Could you also merge https://gerrit.wikimedia.org/r/#/c/246424/ please. [21:08:34] (03CR) 10Paladox: "Thanks." [integration/config] - 10https://gerrit.wikimedia.org/r/246426 (owner: 10Paladox) [21:09:38] (03Merged) 10jenkins-bot: [Flow] Update Jenkins tests [integration/config] - 10https://gerrit.wikimedia.org/r/246426 (owner: 10Paladox) [21:11:22] paladox: the .gitignore are a bit crazy [21:11:28] node_modules should be ignored [21:11:31] you removed it :D [21:11:39] and /vendor has some material in it [21:12:14] hashar: Oh, So it shoulden be node_modules, Should it be node_modules/** and same for vendor [21:12:27] (03PS1) 10Hashar: Revert "[Flow] Update Jenkins tests" [integration/config] - 10https://gerrit.wikimedia.org/r/246982 [21:12:35] (03CR) 10Hashar: [C: 032] Revert "[Flow] Update Jenkins tests" [integration/config] - 10https://gerrit.wikimedia.org/r/246982 (owner: 10Hashar) [21:12:57] paladox: you probably want to ask the Flow developers how they want to deal with those ignores [21:13:10] maybe some of the stuff in vendor should be moved [21:13:24] either to be provided via composer install (and for prod in mediawiki/vendor.git ) [21:13:39] or moved to a /lib/ directory [21:13:40] hashar: Ok well they said they wanted node_modules instead of node_modules/** per Jforrester and same for vendor. [21:15:47] paladox: the easiest would probably to only introduce the composer change for parallel-lint and leave the rest untouched [21:15:58] not there are some .php files under /vendor/ :-( [21:16:05] Ok. [21:18:41] So i should just add the composer -test and thats its so that. So i doint edit the .gitignore file. [21:19:06] hashar: Done only update .jshintignore file to add vendor and to remove a file that dosent exist anymore. [21:20:43] Yippee, build fixed! [21:20:44] Project browsertests-QuickSurveys-en.m.wikipedia.beta.wmflabs.org-linux-chrome-sauce build #36: 09FIXED in 4 min 42 sec: https://integration.wikimedia.org/ci/job/browsertests-QuickSurveys-en.m.wikipedia.beta.wmflabs.org-linux-chrome-sauce/36/ [21:20:54] paladox: I have added a few more people to review it [21:21:05] hashar: Ok thanks. [21:21:09] I am off gotta sleep :-} [21:27:03] (03Merged) 10jenkins-bot: Revert "[Flow] Update Jenkins tests" [integration/config] - 10https://gerrit.wikimedia.org/r/246982 (owner: 10Hashar) [21:27:46] (03PS1) 10Paladox: Revert "Revert "[Flow] Update Jenkins tests"" [integration/config] - 10https://gerrit.wikimedia.org/r/246983 [21:28:20] (03PS2) 10Paladox: [Flow] Update Jenkins tests [integration/config] - 10https://gerrit.wikimedia.org/r/246983 [21:31:28] (03PS1) 10Paladox: [RelatedArticles] Re add composer-test [integration/config] - 10https://gerrit.wikimedia.org/r/246984 [21:34:02] (03PS1) 10Paladox: [RelatedArticles] Move jshint to check: [integration/config] - 10https://gerrit.wikimedia.org/r/246986 [21:41:18] Project browsertests-Flow-en.wikipedia.beta.wmflabs.org-linux-chrome-sauce build #799: 04STILL FAILING in 39 min: https://integration.wikimedia.org/ci/job/browsertests-Flow-en.wikipedia.beta.wmflabs.org-linux-chrome-sauce/799/ [21:49:50] 10Browser-Tests, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 3Wikidata-Sprint-2015-10-13: failed Description with a too long value - https://phabricator.wikimedia.org/T115499#1732104 (10JanZerebecki) 5Open>3Invalid a:3JanZerebecki Maybe this was a error in communicating with saucelabs. The... [21:49:54] 10Browser-Tests, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: [Task] investigate failing Wikidata browsertests on jenkins - https://phabricator.wikimedia.org/T92619#1732107 (10JanZerebecki) [22:47:26] 6Release-Engineering-Team, 6Commons, 10MediaWiki-File-management, 10MediaWiki-Tarball-Backports, and 7 others: InstantCommons broken by switch to HTTPS - https://phabricator.wikimedia.org/T102566#1732200 (10BBlack) 5Resolved>3Open ^ Was the software released? We still haven't removed the exception itse... [23:54:48] (03PS1) 10XZise: [IMPROV] Test returned content first [integration/jenkins] - 10https://gerrit.wikimedia.org/r/247018