[03:15:54] Yippee, build fixed! [03:15:55] Project browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-linux-firefox-sauce build #759: 09FIXED in 25 min: https://integration.wikimedia.org/ci/job/browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-linux-firefox-sauce/759/ [03:23:27] Yippee, build fixed! [03:23:27] Project browsertests-MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox-sauce build #859: 09FIXED in 41 min: https://integration.wikimedia.org/ci/job/browsertests-MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox-sauce/859/ [03:27:39] (03PS1) 10Gergő Tisza: Add Composer and npm tests to OAuthAuthenticate [integration/config] - 10https://gerrit.wikimedia.org/r/248663 [03:28:31] (03PS2) 10Gergő Tisza: Add Composer and npm tests to OAuthAuthenticate [integration/config] - 10https://gerrit.wikimedia.org/r/248663 [03:57:12] 10MediaWiki-Codesniffer, 5Patch-For-Review: Add sniff for "if/while ( $a = foo() )" constructs in phpcs - https://phabricator.wikimedia.org/T92744#1751307 (10TasneemLo) @Physikerwelt I think these might be more appropriate and easy to read : ``` $line = fgetcsv( $csv_file ); if ( $line === NULL ) { // th... [04:24:28] Project browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-windows_7-internet_explorer-9-sauce build #602: 04FAILURE in 32 min: https://integration.wikimedia.org/ci/job/browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-windows_7-internet_explorer-9-sauce/602/ [05:27:36] Yippee, build fixed! [05:27:36] Project browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-windows_7-internet_explorer-11-sauce build #582: 09FIXED in 25 min: https://integration.wikimedia.org/ci/job/browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-windows_7-internet_explorer-11-sauce/582/ [07:00:36] 10MediaWiki-Codesniffer: Add elseif to SpaceAfterControlStructureSniff - https://phabricator.wikimedia.org/T116518#1751415 (10TasneemLo) [07:01:29] 10MediaWiki-Codesniffer: Add elseif to SpaceAfterControlStructureSniff - https://phabricator.wikimedia.org/T116518#1751409 (10TasneemLo) [08:32:56] Yippee, build fixed! [08:32:57] Project browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-os_x_10.9-safari-sauce build #762: 09FIXED in 22 min: https://integration.wikimedia.org/ci/job/browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-os_x_10.9-safari-sauce/762/ [09:14:40] 10MediaWiki-Codesniffer: SpaceyParanthesis bug - https://phabricator.wikimedia.org/T116519#1751509 (10TasneemLo) [09:24:07] (03PS2) 10TasneemLo: Tests: Revamp tests to UnitTests for each Sniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/237899 (https://phabricator.wikimedia.org/T92751) [09:24:10] (03CR) 10jenkins-bot: [V: 04-1] Tests: Revamp tests to UnitTests for each Sniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/237899 (https://phabricator.wikimedia.org/T92751) (owner: 10TasneemLo) [09:27:33] 10MediaWiki-Codesniffer: SpaceyParanthesis bug - https://phabricator.wikimedia.org/T116519#1751517 (10TasneemLo) [09:36:16] (03PS3) 10TasneemLo: Tests: Revamp tests to UnitTests for each Sniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/237899 (https://phabricator.wikimedia.org/T92751) [09:36:19] (03CR) 10jenkins-bot: [V: 04-1] Tests: Revamp tests to UnitTests for each Sniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/237899 (https://phabricator.wikimedia.org/T92751) (owner: 10TasneemLo) [09:41:11] (03PS4) 10TasneemLo: Tests: Revamp tests to UnitTests for each Sniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/237899 (https://phabricator.wikimedia.org/T92751) [09:50:06] (03CR) 10TasneemLo: "I've modified the testing infrastructure to the new one for all sniffs in PatchSet 4. I haven't read all the tests - and simply copied the" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/237899 (https://phabricator.wikimedia.org/T92751) (owner: 10TasneemLo) [10:04:35] 10MediaWiki-Codesniffer: phplint doesn't run on .inc files - https://phabricator.wikimedia.org/T116524#1751533 (10TasneemLo) 3NEW [14:34:14] (03PS1) 10Paladox: [CodeEditor] Update Jenkins tests [integration/config] - 10https://gerrit.wikimedia.org/r/248688 [14:35:08] (03PS2) 10Paladox: [CodeEditor] Update Jenkins tests [integration/config] - 10https://gerrit.wikimedia.org/r/248688 [16:03:14] PROBLEM - Puppet failure on integration-slave-jessie-1001 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [16:03:15] PROBLEM - Puppet failure on deployment-parsoidcache02 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [16:39:12] (03PS1) 10Paladox: [Popups] Update Jenkins tests [integration/config] - 10https://gerrit.wikimedia.org/r/248696 [16:39:41] (03PS2) 10Paladox: [Popups] Update Jenkins tests [integration/config] - 10https://gerrit.wikimedia.org/r/248696 [17:11:58] 10MediaWiki-Codesniffer: phplint doesn't run on .inc files - https://phabricator.wikimedia.org/T116524#1751875 (10Legoktm) Do we have .inc files in the repository? We can add `-e php,inc` to the command to make it include that file extension. [20:22:45] PROBLEM - Puppet staleness on deployment-restbase01 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [43200.0] [22:49:58] 10Continuous-Integration-Config, 6operations, 7Puppet: Disable 80 character line length check in puppet-lint - https://phabricator.wikimedia.org/T116552#1752145 (10scfc) [23:10:46] Project browsertests-Gather-en.m.wikipedia.beta.wmflabs.org-linux-chrome-sauce build #304: 04FAILURE in 13 min: https://integration.wikimedia.org/ci/job/browsertests-Gather-en.m.wikipedia.beta.wmflabs.org-linux-chrome-sauce/304/