[00:05:34] 6Release-Engineering-Team, 6operations: Rewrite http://download.wikimedia.org/mediawiki/ -> https://releases.wikimedia.org/mediawiki in less than 3 redirects - https://phabricator.wikimedia.org/T119679#1832891 (10Reedy) I should note that I've fixed the script that makes some of the release announcement emails... [00:08:37] ostriches: https://github.com/wikimedia/mediawiki-tools-release/blob/master/make-release/make-release.py#L662-L663 [00:08:47] *https://phabricator.wikimedia.org/diffusion/MW/browse/REL1_26/RELEASE-NOTES-1.26 [00:08:57] Did you fix that by hand, or have you an uncommited/unsubmitted live hack? :) [00:11:19] (03PS1) 10Reedy: We're always doing releases > 1.17 now [tools/release] - 10https://gerrit.wikimedia.org/r/255479 [00:12:43] (03PS1) 10Reedy: Use phab for release notes, not gitblit [tools/release] - 10https://gerrit.wikimedia.org/r/255481 [00:12:45] * Reedy makes a commit anyway [00:15:59] 10MediaWiki-Releasing, 6Developer-Relations: Make MW 1.27 a Long-Term-Release - https://phabricator.wikimedia.org/T119683#1832918 (10MarkAHershberger) 3NEW [00:16:22] Reedy: I copy+paste from the old message usually. [00:16:29] That output at the bottom is usually useless. [00:16:31] (it omits links) [00:17:16] It looks roughly the same [00:22:11] 10MediaWiki-Releasing, 6Developer-Relations: Make MW 1.27 a Long-Term-Release - https://phabricator.wikimedia.org/T119683#1832998 (10Jdforrester-WMF) >>! In T119683#1832955, @demon wrote: > Reverted for now. Needs wide discussion before we de-commit from doing LTSes. Can you point to where it was committed (o... [00:23:45] 10MediaWiki-Releasing, 6Developer-Relations: Make MW 1.27 a Long-Term-Release - https://phabricator.wikimedia.org/T119683#1833000 (10Legoktm) Thanks, I added the question mark because there was confusion during today's RfC meeting about whether 1.27 was going to be a LTS, and the implications that would have o... [00:25:50] 10MediaWiki-Releasing, 6Developer-Relations: Make MW 1.27 a Long-Term-Release - https://phabricator.wikimedia.org/T119683#1833005 (10demon) 5Open>3Resolved a:3demon >>! In T119683#1832998, @Jdforrester-WMF wrote: >>>! In T119683#1832955, @demon wrote: >> Reverted for now. Needs wide discussion before we... [00:26:17] 10MediaWiki-Releasing, 6Developer-Relations: Use WMF or MW email addresses to send release announcements - https://phabricator.wikimedia.org/T119685#1833011 (10MarkAHershberger) 3NEW [00:31:00] 10MediaWiki-Releasing, 6Developer-Relations: Use WMF or MW email addresses to send release announcements - https://phabricator.wikimedia.org/T119685#1833039 (10Krenair) 5Open>3declined a:3Krenair People should not be relying on email host to determine authenticity. [00:34:17] 10MediaWiki-Releasing, 6Developer-Relations: Make MW 1.27 a Long-Term-Release - https://phabricator.wikimedia.org/T119683#1833048 (10MarkAHershberger) >>! In T119683#1832998, @Jdforrester-WMF wrote: > Can you point to where it was committed (other than random fly-by edits by people who don't actually do the wo... [00:38:22] 10MediaWiki-Releasing, 6Developer-Relations: Use WMF or MW email addresses to send release announcements - https://phabricator.wikimedia.org/T119685#1833058 (10MarkAHershberger) >>! In T119685#1833039, @Krenair wrote: > People should not be relying on email host to determine authenticity. You're right, but th... [00:40:08] 10MediaWiki-Releasing, 6Developer-Relations: Use WMF or MW email addresses to send release announcements - https://phabricator.wikimedia.org/T119685#1833061 (10Krenair) >>! In T119685#1833058, @MarkAHershberger wrote: > Is your opinion the final one in determining that this request is declined? No, but I am a... [00:40:48] 10MediaWiki-Releasing, 6Developer-Relations: Use WMF or MW email addresses to send release announcements - https://phabricator.wikimedia.org/T119685#1833062 (10MarkAHershberger) (Note that while MyM was doing releases, we did ask for a WMF email address to use for them. So, yes, we made releases from a non WM... [00:45:03] 10MediaWiki-Releasing, 6Developer-Relations: Use WMF or MW email addresses to send release announcements - https://phabricator.wikimedia.org/T119685#1833080 (10Krenair) >>! In T119685#1833062, @MarkAHershberger wrote: > Note that while MyM was doing releases, we did ask for a WMF email address to use for them.... [00:48:28] 10MediaWiki-Releasing, 6Developer-Relations: Use WMF or MW email addresses to send release announcements - https://phabricator.wikimedia.org/T119685#1833085 (10Deskana) Creating a mediawiki.org email address for the purposes of announcing releases sounds sensible enough to me. [00:49:56] 10MediaWiki-Releasing, 6Developer-Relations: Use WMF or MW email addresses to send release announcements - https://phabricator.wikimedia.org/T119685#1833088 (10demon) 5declined>3Open +1 to decline, for the same reason I don't post to lists with my @wikimedia address, it's not who I am. I've always been in... [00:50:12] 10MediaWiki-Releasing, 6Developer-Relations: Use WMF or MW email addresses to send release announcements - https://phabricator.wikimedia.org/T119685#1833090 (10demon) 5Open>3declined Meh, did not mean to reopen. [00:56:37] 10MediaWiki-Releasing, 6Developer-Relations: Use WMF or MW email addresses to send release announcements - https://phabricator.wikimedia.org/T119685#1833093 (10MarkAHershberger) >>! In T119685#1833080, @Krenair wrote: > According to your logic, while you were doing them, they should have been coming from your... [00:58:10] 10MediaWiki-Releasing, 6Developer-Relations: Use WMF or MW email addresses to send release announcements - https://phabricator.wikimedia.org/T119685#1833099 (10Legoktm) > GPG-signing is part of the process of showing authenticity, but I would suggest that release announcments come from such a strange email add... [01:58:21] (03CR) 10Bmansurov: "Thanks, hashar!" [integration/config] - 10https://gerrit.wikimedia.org/r/255351 (owner: 10Bmansurov) [03:00:29] 6Release-Engineering-Team, 6operations: Rewrite http://download.wikimedia.org/mediawiki/ -> https://releases.wikimedia.org/mediawiki in less than 3 redirects - https://phabricator.wikimedia.org/T119679#1833203 (10Krinkle) I guess this related to the trailing slash redirect being handled by Apache, which respon... [03:52:13] Project browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-windows_7-internet_explorer-9-sauce build #634: 04FAILURE in 11 sec: https://integration.wikimedia.org/ci/job/browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-windows_7-internet_explorer-9-sauce/634/ [04:07:18] Project browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-windows_8.1-internet_explorer-11-sauce build #640: 04FAILURE in 17 sec: https://integration.wikimedia.org/ci/job/browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-windows_8.1-internet_explorer-11-sauce/640/ [06:36:45] (03CR) 10Legoktm: [C: 04-1] We're always doing releases > 1.17 now (031 comment) [tools/release] - 10https://gerrit.wikimedia.org/r/255479 (owner: 10Reedy) [06:37:01] (03CR) 10Legoktm: [C: 031] Use phab for release notes, not gitblit [tools/release] - 10https://gerrit.wikimedia.org/r/255481 (owner: 10Reedy) [07:09:11] Project browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-windows_8-internet_explorer-10-sauce build #233: 04FAILURE in 10 sec: https://integration.wikimedia.org/ci/job/browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-windows_8-internet_explorer-10-sauce/233/ [08:10:18] Project browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-os_x_10.9-safari-sauce build #794: 04FAILURE in 17 sec: https://integration.wikimedia.org/ci/job/browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-os_x_10.9-safari-sauce/794/ [08:24:49] 6Release-Engineering-Team, 10Browser-Tests-Infrastructure, 7Ruby, 7Tracking: Update repositories that use mediawiki_selenium Ruby gem to version 1.x - https://phabricator.wikimedia.org/T94083#1833332 (10zeljkofilipin) [08:24:50] 7Browser-Tests, 10Browser-Tests-Infrastructure, 10MediaWiki-extensions-MultimediaViewer, 5Patch-For-Review, 5WMF-deploy-2015-12-08_(1.27.0-wmf.8): Upgrade MultimediaViewer browser tests to use mediawiki_selenium 1.x - https://phabricator.wikimedia.org/T99659#1833331 (10zeljkofilipin) 5Open>3Resolved [08:26:26] 6Release-Engineering-Team, 10Browser-Tests-Infrastructure, 7Ruby, 7Tracking: Update repositories that use mediawiki_selenium Ruby gem to version 1.x - https://phabricator.wikimedia.org/T94083#1154455 (10zeljkofilipin) [09:18:07] 6Release-Engineering-Team, 6operations: Rewrite http://download.wikimedia.org/mediawiki/ -> https://releases.wikimedia.org/mediawiki in less than 3 redirects - https://phabricator.wikimedia.org/T119679#1833355 (10hashar) [09:27:15] 6Release-Engineering-Team, 6operations: Rewrite http://download.wikimedia.org/mediawiki/ -> https://releases.wikimedia.org/mediawiki in less than 3 redirects - https://phabricator.wikimedia.org/T119679#1833363 (10hashar) Seems the wiki got updated as https://www.mediawiki.org/wiki/Download points to https://re... [09:38:28] Yippee, build fixed! [09:38:28] Project browsertests-Echo-en.wikipedia.beta.wmflabs.org-linux-chrome-sauce build #685: 09FIXED in 1 min 27 sec: https://integration.wikimedia.org/ci/job/browsertests-Echo-en.wikipedia.beta.wmflabs.org-linux-chrome-sauce/685/ [09:51:42] When releasing new .0 MW tarballs, is there anywhere a checklist of steps to perform? [09:51:56] e.g. I just updated https://www.mediawiki.org/wiki/Template:DownloadMediaWiki and would like to add that to the list. [09:58:02] PROBLEM - App Server Main HTTP Response on deployment-mediawiki01 is CRITICAL: CRITICAL - Socket timeout after 10 seconds [10:02:53] RECOVERY - App Server Main HTTP Response on deployment-mediawiki01 is OK: HTTP OK: HTTP/1.1 200 OK - 39007 bytes in 0.662 second response time [10:09:59] andre__: guten tag [10:10:02] andre__: we have/had https://www.mediawiki.org/wiki/Release_checklist [10:11:26] andre__: and ^demon did a bunch of edits on the wiki https://www.mediawiki.org/wiki/Special:Contributions/%5Edemon [10:14:15] hashar: oh shaweeet! Merci beaucoup, je vais l'actualiser [10:25:35] andre__: je t'en prie [10:26:50] 7Browser-Tests, 10CirrusSearch, 6Discovery: Upgrade CirrusSearch browser tests to use mediawiki_selenium 1.x - https://phabricator.wikimedia.org/T99653#1833418 (10hashar) According to the single job we have https://integration.wikimedia.org/ci/job/browsertests-CirrusSearch-en.wikipedia.beta.wmflabs.org-linux... [10:30:29] 10Continuous-Integration-Config, 10MediaWiki-General-or-Unknown, 10MediaWiki-extensions-General-or-Unknown: Add grunt-concurrent to mediawiki/core and decide whether to add it to extensions (Improve grunt performance) - https://phabricator.wikimedia.org/T116988#1833428 (10hashar) p:5Triage>3Normal [10:30:42] 10Continuous-Integration-Config: Make debian-glue to use Gerrit as the upstream repository - https://phabricator.wikimedia.org/T117869#1833429 (10hashar) p:5Triage>3Low [10:36:27] 10Beta-Cluster-Infrastructure, 7Database: Investigate slow query logging/digest for Beta Cluster - https://phabricator.wikimedia.org/T116793#1833432 (10jcrespo) After reading T119461 and checking the number of warnings on production (https://gerrit.wikimedia.org/r/#/c/198661/) we should go with performance_sch... [10:36:53] 10Beta-Cluster-Infrastructure, 7Database: Investigate slow query logging/digest for Beta Cluster - https://phabricator.wikimedia.org/T116793#1833436 (10jcrespo) [10:38:14] 10Continuous-Integration-Config, 10Graphoid, 6Services, 5Patch-For-Review: Enable jenkins test & submit for graphoid repo - https://phabricator.wikimedia.org/T106668#1833446 (10hashar) 5Open>3stalled I have created a sub task to get the packages to be provisioned via puppet {T119693}. Meanwhile stalli... [10:39:46] 10Continuous-Integration-Config: Set up Jenkins jobs for phabricator/* repos - https://phabricator.wikimedia.org/T70263#1833458 (10hashar) p:5Normal>3Low [10:41:39] 10Continuous-Integration-Config, 5Patch-For-Review, 3Wikipedia-Android-App: java-mwapi: Add verification tasks when new patch gets uploaded - https://phabricator.wikimedia.org/T108735#1833461 (10hashar) @Niedzielski should we get a coverage report setup for `apps/android/java-mwapi` or is that project legacy... [11:02:16] zeljkof: looks like rake-jessie for operations/puppet.git is fast enough [11:02:26] zeljkof: no need to wait for Zuul git cache there [11:07:05] (03PS1) 10Hashar: Clean up ruby2.0-lint [integration/config] - 10https://gerrit.wikimedia.org/r/255521 [11:07:12] (03PS1) 10Gilles: Configure thumbor/vips-engine and thumbor/proxy-engine [integration/config] - 10https://gerrit.wikimedia.org/r/255522 (https://phabricator.wikimedia.org/T119184) [11:07:34] (03CR) 10Hashar: "Then we can delete https://integration.wikimedia.org/ci/job/ruby2.0lint/" [integration/config] - 10https://gerrit.wikimedia.org/r/255521 (owner: 10Hashar) [11:09:08] (03PS1) 10Hashar: Delete gembuild JJB templates [integration/config] - 10https://gerrit.wikimedia.org/r/255523 [11:09:54] (03CR) 10Hashar: [C: 032] Configure thumbor/vips-engine and thumbor/proxy-engine [integration/config] - 10https://gerrit.wikimedia.org/r/255522 (https://phabricator.wikimedia.org/T119184) (owner: 10Gilles) [11:10:00] gilles: thanks, will deploy it :-} [11:10:32] hashar: want to merge this then? ;) https://gerrit.wikimedia.org/r/#/c/252689/ [11:10:56] (03Merged) 10jenkins-bot: Configure thumbor/vips-engine and thumbor/proxy-engine [integration/config] - 10https://gerrit.wikimedia.org/r/255522 (https://phabricator.wikimedia.org/T119184) (owner: 10Gilles) [11:11:01] zeljkof: I guess so [11:11:10] zeljkof: do you have buy-in from ops ? :-} [11:13:02] hashar: sent mail to Yuvi and Alexandros, did not hear from them, but they did not complain ;) [11:13:13] and we have rubocop running for ops/puppet anyway [11:13:17] this will not change anything [11:14:01] ARHGHGRZORI [11:14:15] zuul can't run tests on the first commit of a repo :D [11:18:30] 10Continuous-Integration-Infrastructure, 7Zuul: zuul-merger fails on initial commit of a repo - https://phabricator.wikimedia.org/T119697#1833514 (10hashar) 3NEW [11:23:25] https://gerrit.wikimedia.org/r/#/c/252689/ needs rebase now :/ [11:23:58] running check experimental on the last merged change https://gerrit.wikimedia.org/r/#/c/255517/ [11:24:04] https://integration.wikimedia.org/ci/job/rake-jessie/1586/ [11:24:14] pass [11:24:32] so just rebase https://gerrit.wikimedia.org/r/#/c/252689/ and we should be fine :-} [11:28:35] hashar: https://gerrit.wikimedia.org/r/#/c/255431/ still ain't happy [11:28:57] grbmblbl [11:29:20] gilles: digging in zuul debug log :-} [11:30:52] IndexError: No item found with id u'origin/HEAD' [11:30:54] wtf [11:32:43] gilles: yeah the repo was left without any HEAD :/ [11:32:46] some bug in zuul [11:33:01] gilles: it passes now. I filled the task but I don't think I am going to spend time to fix it up [11:33:24] yeah I'll remember to merge a gitreview first, it will happen again for the other repo [11:35:04] 10Continuous-Integration-Infrastructure, 7Zuul: zuul-merger fails on initial commit of a repo - https://phabricator.wikimedia.org/T119697#1833538 (10hashar) Note that even after a change has been force merged and the patch rebased, the zuul-merger repo lacks a HEAD: ``` DEBUG zuul.Merger: Merging for change 25... [11:36:51] 10Continuous-Integration-Infrastructure, 7Zuul: zuul-merger fails on initial commit of a repo - https://phabricator.wikimedia.org/T119697#1833539 (10hashar) 5Open>3declined a:3hashar I am not going to bother fixing that. When CI is enabled on a repository which has no initial commit yet the workaround is... [11:36:59] gilles: I guess yes [11:37:23] gilles: in most case people creating a repo immediately send a dummy change with a .gitreview file [11:37:26] CI being setup later [11:37:39] so it is really a corner case :-/ [11:38:05] I've done my homework too early! [11:40:19] (03PS4) 10Hashar: [puppet] Add rake-jessie job to test [integration/config] - 10https://gerrit.wikimedia.org/r/252689 (https://phabricator.wikimedia.org/T110019) (owner: 10Zfilipin) [11:41:23] (03CR) 10Hashar: [C: 032] "I removed gate-and-submit. Ops do not use CR+2 to get changes merged, they rebase, wait for test then submit." [integration/config] - 10https://gerrit.wikimedia.org/r/252689 (https://phabricator.wikimedia.org/T110019) (owner: 10Zfilipin) [11:41:40] gilles: which is a good thing :-} [11:42:17] (03Merged) 10jenkins-bot: [puppet] Add rake-jessie job to test [integration/config] - 10https://gerrit.wikimedia.org/r/252689 (https://phabricator.wikimedia.org/T110019) (owner: 10Zfilipin) [11:48:16] (03PS2) 10Reedy: We're always doing releases > 1.17 now [tools/release] - 10https://gerrit.wikimedia.org/r/255479 [12:13:55] (03CR) 10Hashar: [C: 032] We're always doing releases > 1.17 now [tools/release] - 10https://gerrit.wikimedia.org/r/255479 (owner: 10Reedy) [12:14:26] (03Merged) 10jenkins-bot: We're always doing releases > 1.17 now [tools/release] - 10https://gerrit.wikimedia.org/r/255479 (owner: 10Reedy) [12:17:30] (03CR) 10Hashar: "Reedy: needs a rebase :-}" [tools/release] - 10https://gerrit.wikimedia.org/r/255481 (owner: 10Reedy) [12:17:49] DAMN IT GERRIT [12:18:38] Reedy: also chad was talking about phasing out call signs entirely [12:18:42] in favor of meaningful names [12:18:51] :) [12:18:57] still, it's using crappy gitblit links [12:44:30] (03PS2) 10Hashar: Clean up ruby2.0-lint [integration/config] - 10https://gerrit.wikimedia.org/r/255521 [12:44:46] (03CR) 10Hashar: [C: 032] Clean up ruby2.0-lint [integration/config] - 10https://gerrit.wikimedia.org/r/255521 (owner: 10Hashar) [12:46:09] (03Merged) 10jenkins-bot: Clean up ruby2.0-lint [integration/config] - 10https://gerrit.wikimedia.org/r/255521 (owner: 10Hashar) [12:48:26] (03PS2) 10Hashar: Delete gembuild JJB templates [integration/config] - 10https://gerrit.wikimedia.org/r/255523 [12:48:36] (03CR) 10Hashar: [C: 032] Delete gembuild JJB templates [integration/config] - 10https://gerrit.wikimedia.org/r/255523 (owner: 10Hashar) [12:50:38] (03Merged) 10jenkins-bot: Delete gembuild JJB templates [integration/config] - 10https://gerrit.wikimedia.org/r/255523 (owner: 10Hashar) [12:51:29] (03PS1) 10Hashar: Cleanup references to rubocop [integration/config] - 10https://gerrit.wikimedia.org/r/255531 [12:51:34] zeljkof: doing a bunch of cleanup in ci config [12:54:37] (03PS2) 10Reedy: Use phab for release notes, not gitblit [tools/release] - 10https://gerrit.wikimedia.org/r/255481 [12:54:49] (03CR) 10Hashar: [C: 032] Cleanup references to rubocop [integration/config] - 10https://gerrit.wikimedia.org/r/255531 (owner: 10Hashar) [13:00:22] hashar: learning js today :) https://www.codecademy.com/learn/javascript [13:02:23] (03PS2) 10Hashar: Cleanup references to rubocop [integration/config] - 10https://gerrit.wikimedia.org/r/255531 [13:02:36] (03CR) 10Hashar: [C: 032] Cleanup references to rubocop [integration/config] - 10https://gerrit.wikimedia.org/r/255531 (owner: 10Hashar) [13:04:18] (03Merged) 10jenkins-bot: Cleanup references to rubocop [integration/config] - 10https://gerrit.wikimedia.org/r/255531 (owner: 10Hashar) [13:51:47] Reedy: hey any idea who can help with a security bug with JS right now? [13:52:04] jzerebecki: Right now? Krinkle is probably a good bet [13:55:19] thx [14:03:06] (03CR) 10Hashar: [C: 032 V: 032] "build at https://people.wikimedia.org/~hashar/debs/zuul_2.1.0-60-g1cc37f7-wmf3precise1/" [integration/zuul] (debian/precise-wikimedia) - 10https://gerrit.wikimedia.org/r/255124 (https://phabricator.wikimedia.org/T97106) (owner: 10Hashar) [14:04:20] !log upgrading zuul on labs to 2.1.0-60-g1cc37f7-wmf3 ( https://review.openstack.org/#/c/249207/2 https://phabricator.wikimedia.org/T97106 ) [14:06:58] qa-morebots: [14:07:00] qa-morebots: ping [14:07:02] qa-morebots: pong [14:09:20] qa-morebots: ping [14:09:21] I am a logbot running on tools-exec-1211. [14:09:21] Messages are logged to https://tools.wmflabs.org/sal/releng. [14:09:21] To log a message, type !log . [14:09:24] !log upgrading zuul on labs to 2.1.0-60-g1cc37f7-wmf3 ( https://review.openstack.org/#/c/249207/2 https://phabricator.wikimedia.org/T97106 ) [14:09:28] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL, Master [14:10:00] !log Kicking stupid salt on integration box. We need a new orchestration system [14:10:03] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL, Master [14:13:19] (03CR) 10Hashar: [C: 032 V: 032] Merge branch 'debian/precise-wikimedia' into debian/jessie-wikimedia [integration/zuul] (debian/jessie-wikimedia) - 10https://gerrit.wikimedia.org/r/252934 (https://phabricator.wikimedia.org/T97106) (owner: 10Hashar) [14:24:42] (03PS1) 10Hashar: Merge branch 'debian/precise-wikimedia' into debian/trusty-wikimedia [integration/zuul] (debian/trusty-wikimedia) - 10https://gerrit.wikimedia.org/r/255541 (https://phabricator.wikimedia.org/T97106) [14:28:10] Yippee, build fixed! [14:28:10] Project browsertests-Echo-en.wikipedia.beta.wmflabs.org-linux-firefox-sauce build #702: 09FIXED in 2 min 9 sec: https://integration.wikimedia.org/ci/job/browsertests-Echo-en.wikipedia.beta.wmflabs.org-linux-firefox-sauce/702/ [14:28:11] (03CR) 10Hashar: [C: 032 V: 032] Merge branch 'debian/precise-wikimedia' into debian/trusty-wikimedia [integration/zuul] (debian/trusty-wikimedia) - 10https://gerrit.wikimedia.org/r/255541 (https://phabricator.wikimedia.org/T97106) (owner: 10Hashar) [14:34:43] (03PS1) 10Hashar: Merge branch 'debian/precise-wikimedia' into debian/jessie-wikimedia [integration/zuul] (debian/jessie-wikimedia) - 10https://gerrit.wikimedia.org/r/255543 (https://phabricator.wikimedia.org/T97106) [14:38:47] (03CR) 10Hashar: [C: 032 V: 032] Merge branch 'debian/precise-wikimedia' into debian/jessie-wikimedia [integration/zuul] (debian/jessie-wikimedia) - 10https://gerrit.wikimedia.org/r/255543 (https://phabricator.wikimedia.org/T97106) (owner: 10Hashar) [14:44:04] 10Continuous-Integration-Infrastructure, 5Patch-For-Review, 7Zuul: Upload new Zuul packages zuul_2.1.0-60-g1cc37f7-wmf3 on apt.wikimedia.org for Precise / Trusty / Jessie - https://phabricator.wikimedia.org/T119714#1833909 (10hashar) 3NEW a:3hashar [14:45:31] 10Continuous-Integration-Infrastructure, 5Patch-For-Review, 7Zuul: Zuul-cloner should use hard links when fetching from cache-dir - https://phabricator.wikimedia.org/T97106#1833932 (10hashar) I have cherry picked my patch and regenerated all packages. Now pending publishing to apt.wikimedia.org T119714 [15:16:48] greg-g_: hey I want to get a security patch for MobileFrontend deployed [15:17:38] jzerebecki: it's thanksgiving today in the US [15:18:06] I think security trumps all... [15:18:43] my comment was meant to be taken as "don't expect a reply soon" [15:18:50] but yes, I agree Reedy [15:19:03] heh, sorry :) [15:19:24] jzerebecki: We can get it deployed without an issue... I can do it, and am about... [15:21:40] Reedy: wait a bit I think one part of it is still wrong [15:21:54] jzerebecki: I wasn't going to do it without the OK from someone CR-ing it :) [15:22:02] Has Krinkle reviewed it? [15:22:23] he changed the commit message ;) [15:22:34] and I believe Greg said that all deploys (even security) had to be ok'ed by him... [15:23:15] heh [15:23:21] csteipp is aware [15:23:23] high prioity SWATs only [15:23:25] > (pre-approval from Greg needed) [15:23:32] "High Priority" means security and data loss [15:24:16] Reedy: I'd +1 except that I don't know the code base from a functionality perspective [15:24:30] I'm applying it now on mw1017 so that I can try it with X- debug header [15:24:40] I've got a test case on testwiki [15:29:15] Confirmed to solve the issue on test.wikidata [15:29:25] I only tested Special:Nearby though [15:29:33] I don't know how to check the other CategoryLookupInputWidget file [15:30:41] me neither [15:31:28] AndyRussG: pinging you as you might be interested in that there is a pending security deployment^^ [15:32:03] daniel is trying to create a test page for another of the cases [15:33:23] thedj: does that mean we should page / wake up greg-g_ ? [15:34:01] jzerebecki: Just blame me [15:34:02] jzerebecki: /me has no clue, i'm just quoting Greg's mail [15:35:49] k fine with me [15:36:30] I wouldn't want to bother him at this sort of time (to the point of waking him up if he's not already awake), but certainly keep him in the loop via an email etc [15:36:49] ack [15:36:58] I can't find a way to trigger the category interface [15:37:01] it's not used anywhere? [15:37:12] i'd say that if there are enough senior engineers of the various point of impact present to recover from potential issues.... [15:38:03] but he wrote it for a reason of course :) [15:38:04] o/ [15:38:18] DanielK_WMDE: I can't find a way to trigger the category interface [15:38:26] Do you know where it is used? [15:38:27] thedj: git reset HEAD --hard && sync-dir [15:38:28] ;) [15:38:32] Krinkle: nope [15:38:37] lol [15:38:58] The patch is live on mw1017 now [15:39:19] Krinkle: i just looked for "displaytitle", and tried to spot places where unescaped text was assigned to that [15:39:20] So if you use ChromeWikimediaDebug or otherwise pass the x wikimedia debug header, you can see the patch applied [15:39:35] DanielK_WMDE: yeah, but this one is unrelated, it's category display title [15:40:06] phuedx: ^^ conversation is in here [15:40:20] Krinkle: how is that unrelated? the displaytitle of a category is html, the title text of the category isn't. [15:40:39] jzerebecki: sorry wat? [15:40:41] DanielK_WMDE: No, it's not displayTitle as in {{DISPLAYTITLE}} or parser [15:40:54] DanielK_WMDE: This is just some random property in an object in a js class, used between two parts of the code [15:41:11] lower in the file you'll see it passed to OO UI 'label', which is a text field. [15:41:11] jzerebecki: you think it's something that could affect FR? [15:41:40] The value is set to unprefixed page title. It has nothing to do with "MediaWiki pageTitle" [15:41:41] I'm working today so I can look at stuff as needed [15:43:19] jzerebecki: DanielK_WMDE : Try it on https://doc.wikimedia.org/oojs-ui/master/js/#!/api/OO.ui.DecoratedOptionWidget [15:43:35] filling in a value results in the expected output when using option labels [15:43:44] live preview :) [15:44:07] Krinkle: so the code base uses "displaytitle" for several things, some of which are HTML, and some of which are not? [15:44:36] I didn't write it, but yes, someone unfortunately thought of 'displayTitle' as a suitable name for that property [15:44:40] it's not related in any way [15:44:48] AndyRussG: I don't think so. but as FR is the reason that there is a deployment freze and we will do a deployment for security reasons... this patch is the patch https://gerrit.wikimedia.org/r/#/c/255540/4 it is a change that affects the mobile search [15:44:50] it's just the title of the category displayed in the ui widget [15:45:00] * DanielK_WMDE shrugs [15:45:09] i don't really understand the code base [15:45:18] it would be preferrable if someone who did fixed the problem [15:45:24] AndyRussG: is FR being done on mobile? [15:45:30] There is no problem in the category widget [15:45:34] just leave that out of the patch [15:45:45] We can't even figure out where it's used [15:45:49] so there's no grounds for changing that now [15:46:49] Krinkle: if you can vouch for that, sure :) [15:47:26] Krinkle: i just updated the patch [15:48:38] Krinkle, DanielK_WMDE: the category widget is used in the categories overlay, which can be triggered in the beta mode of MFE [15:49:45] I find it interresting that MW accepts "This & That" as a page title, but not "This & That" :) [15:49:57] Krinkle: update to tin.eqiad.wmnet:/srv/patches/extensions/MobileFrontend/T119707.patch done [15:50:04] phuedx: thanks for the info! [15:50:39] phuedx: OK. Confirmed via https://en.m.wikipedia.org/wiki/Obama#/categories – not related to displayTitle bug [15:50:54] (after enabling beta in settings via hamburger menu) [15:51:17] did someone check live preview ? [15:51:26] if this is a displaytitle issue... [15:51:56] thedj: live preview doesn't have a way to edit the title. It just renders what the API gave it from the parser [15:52:05] and it's treated as html, which it should [15:52:34] jzerebecki: yes there are mobile FR campaigns active [15:52:35] thedj: the bug is that in mobile, some non-displaytitle values used as fallback for when there is no displaytitle are treated as html instead of text. [15:52:50] ok. don't know about the details of the isssue, so wanted to mention it, as i know it's used there. [15:52:54] while displaytitle supports html, it is sanitized html by the parser [15:52:59] anyway [15:53:09] Reedy: You syncing? [15:53:21] jzerebecki: Oh, you're doing it [15:53:22] OKay [15:53:27] Krinkle: I can, or if you're ontop of it, I'm happy for you to... [15:53:34] I just undid the patch in /srv/mediawiki-staging/php-1.27.0-wmf.7/extensions/MobileFrontend [15:53:40] the earlier version taht I put there to sync to mw1017 [15:53:47] jzerebecki: go ahead [15:54:41] Krinkle: no you go ahead reapply the patch from tin.eqiad.wmnet:/srv/patches/extensions/MobileFrontend/T119707.patch I never did a deployment, so this is not the right time to do my first [15:54:57] But you have access to tin? [15:54:58] Ok [15:55:02] I didn'tnow [15:55:07] yes i have the permissions [15:58:00] Krinkle: Are you doing it? :) [15:58:03] Yes [15:58:06] Thanks [16:00:02] sending mail now [16:03:34] (to ops-l) [16:05:51] thx everyone [16:11:53] thank you all [16:17:04] Krinkle: thanks for helping out! [17:22:07] 10Deployment-Systems, 10Architecture, 10Wikimedia-Developer-Summit-2016-Organization, 7Availability: WikiDev 16 working area: Software engineering - https://phabricator.wikimedia.org/T119032#1834257 (10daniel) [17:26:36] 10Deployment-Systems, 10Architecture, 10Wikimedia-Developer-Summit-2016-Organization, 7Availability: WikiDev 16 working area: Software engineering - https://phabricator.wikimedia.org/T119032#1834264 (10daniel) @RobLa-WMF It's unclear to me how the deployment process sessions fit into this topic area. There... [17:34:05] 10Deployment-Systems, 10Architecture, 10Wikimedia-Developer-Summit-2016-Organization, 7Availability: WikiDev 16 working area: Software engineering - https://phabricator.wikimedia.org/T119032#1834278 (10daniel) [17:56:03] 7Browser-Tests, 10Continuous-Integration-Config, 10Wikidata, 5Patch-For-Review, 3Wikidata-Sprint-2015-11-17: create a Wikibase browser test job running against a fresh MediaWiki installation - https://phabricator.wikimedia.org/T118284#1834290 (10JanZerebecki) We can still run the browser tests in Wikibas... [18:03:12] 10MediaWiki-Releasing, 6Developer-Relations: Use WMF or MW email addresses to send release announcements - https://phabricator.wikimedia.org/T119685#1834297 (10Kghbln) Not doing it via an official e-mail address also conveys that it is not done on behalf of anybody at WMF. I believe that there are people at WM... [18:14:13] 10Deployment-Systems, 10Architecture, 10Wikimedia-Developer-Summit-2016-Organization, 7Availability: WikiDev 16 working area: Software engineering - https://phabricator.wikimedia.org/T119032#1834310 (10daniel) [18:25:42] (03PS1) 10Paladox: Update squizlabs/php_codesniffer to 2.4.0 [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/255557 [18:28:53] (03PS1) 10Paladox: Update phpunit to 4.8.18 [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/255558 [18:30:45] (03CR) 10Paladox: "check experimental" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/255557 (owner: 10Paladox) [18:31:52] (03CR) 10Paladox: "check experimental" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/255558 (owner: 10Paladox) [18:34:52] (03PS2) 10Paladox: [RFC] allow paragraphed singled lines comments [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/247565 (owner: 10Hashar) [18:37:10] (03CR) 10jenkins-bot: [V: 04-1] [RFC] allow paragraphed singled lines comments [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/247565 (owner: 10Hashar) [18:38:54] (03PS3) 10Paladox: [RFC] allow paragraphed singled lines comments [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/247565 (owner: 10Hashar) [18:39:11] (03CR) 10Paladox: "Hopefully fixed the jenkins errors." [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/247565 (owner: 10Hashar) [18:40:24] (03PS4) 10Paladox: [RFC] allow paragraphed singled lines comments [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/247565 (owner: 10Hashar) [18:41:35] (03CR) 10Paladox: "Fixed errors." [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/247565 (owner: 10Hashar) [18:44:36] (03PS6) 10Paladox: Tests: Revamp tests to UnitTests for each Sniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/237899 (https://phabricator.wikimedia.org/T92751) (owner: 10TasneemLo) [18:44:46] (03CR) 10Paladox: "Rebased." [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/237899 (https://phabricator.wikimedia.org/T92751) (owner: 10TasneemLo) [19:13:08] (03PS5) 10Hashar: [RFC] allow paragraphed singled lines comments [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/247565 [19:13:57] (03CR) 10Hashar: "Revert back to patchset 1. The failure are expected, it is too highlight the current coding standard does not allow empty lines in a multi" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/247565 (owner: 10Hashar) [19:15:12] (03CR) 10jenkins-bot: [V: 04-1] [RFC] allow paragraphed singled lines comments [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/247565 (owner: 10Hashar) [20:05:42] (03PS1) 10Hashar: Mark mwext-.*-jslint has deprecated [integration/config] - 10https://gerrit.wikimedia.org/r/255563 [20:06:46] (03CR) 10jenkins-bot: [V: 04-1] Mark mwext-.*-jslint has deprecated [integration/config] - 10https://gerrit.wikimedia.org/r/255563 (owner: 10Hashar) [21:21:05] Yippee, build fixed! [21:21:06] Project browsertests-QuickSurveys-en.m.wikipedia.beta.wmflabs.org-linux-chrome-sauce build #82: 09FIXED in 5 min 4 sec: https://integration.wikimedia.org/ci/job/browsertests-QuickSurveys-en.m.wikipedia.beta.wmflabs.org-linux-chrome-sauce/82/ [22:08:05] (03CR) 10Hashar: "recheck" [integration/config] - 10https://gerrit.wikimedia.org/r/255563 (owner: 10Hashar) [22:12:22] 10Continuous-Integration-Infrastructure, 7Zuul: integration-zuul-layoutvalidation fails because of python-daemon 2.1 - https://phabricator.wikimedia.org/T119741#1834476 (10hashar) 3NEW [22:13:58] 10Continuous-Integration-Infrastructure, 7Zuul: integration-zuul-layoutvalidation fails because of python-daemon 2.1 - https://phabricator.wikimedia.org/T119741#1834484 (10hashar) p:5Triage>3Unbreak! a:3hashar [22:18:54] (03PS1) 10Hashar: wmf: pin python-daemon <2.1.0 [integration/zuul] (patch-queue/debian/precise-wikimedia) - 10https://gerrit.wikimedia.org/r/255656 (https://phabricator.wikimedia.org/T119741) [22:19:48] 10Continuous-Integration-Infrastructure, 5Patch-For-Review, 7Zuul: integration-zuul-layoutvalidation fails because of python-daemon 2.1 - https://phabricator.wikimedia.org/T119741#1834491 (10hashar) [22:25:07] (03PS1) 10Hashar: Pin python-daemon <2.1.0 [integration/zuul] (debian/precise-wikimedia) - 10https://gerrit.wikimedia.org/r/255657 (https://phabricator.wikimedia.org/T119741) [22:31:23] (03CR) 10Hashar: "recheck" [integration/config] - 10https://gerrit.wikimedia.org/r/255563 (owner: 10Hashar) [22:31:47] ah [22:33:38] (03CR) 10Hashar: [C: 032 V: 032] "That fix :)" [integration/zuul] (patch-queue/debian/precise-wikimedia) - 10https://gerrit.wikimedia.org/r/255656 (https://phabricator.wikimedia.org/T119741) (owner: 10Hashar) [22:34:27] (03CR) 10Hashar: [C: 032 V: 032] "Published on https://people.wikimedia.org/~hashar/debs/zuul_2.1.0-60-g1cc37f7-wmf4precise1/" [integration/zuul] (debian/precise-wikimedia) - 10https://gerrit.wikimedia.org/r/255657 (https://phabricator.wikimedia.org/T119741) (owner: 10Hashar) [22:35:05] !log Upgraded Zuul on labs Precise hosts to zuul_2.1.0-60-g1cc37f7-wmf4precise1 ( https://phabricator.wikimedia.org/T119741 ) [22:35:08] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL, Master [22:35:09] I so wanted to sleep [22:36:07] 10Continuous-Integration-Infrastructure, 5Patch-For-Review, 7Zuul: integration-zuul-layoutvalidation fails because of python-daemon 2.1 - https://phabricator.wikimedia.org/T119741#1834525 (10hashar) 5Open>3Resolved Solved by pinning `python-daemon<2.1.0` which is included in zuul_2.1.0-60-g1cc37f7-wmf4pr... [22:50:49] (03PS2) 10Hashar: Mark mwext-.*-jslint as deprecated [integration/config] - 10https://gerrit.wikimedia.org/r/255563 [22:51:02] (03CR) 10Hashar: "grammar :-(" [integration/config] - 10https://gerrit.wikimedia.org/r/255563 (owner: 10Hashar) [22:51:34] finally [22:51:35] wave [22:51:38] happy thanks giving