[00:06:41] 5Gerrit-Migration, 10Gitblit-Deprecate, 10Diffusion: Define a process to import and create repositories - https://phabricator.wikimedia.org/T1009#1843315 (10greg) **Proposal** * Create a #Repository-Admins group in Phabricator that gives members the needed permissions to create/edit/etc repositories in Phab.... [00:07:48] 5Gerrit-Migration, 10Gitblit-Deprecate, 10Diffusion: Define a process to import and create repositories - https://phabricator.wikimedia.org/T1009#1843317 (10greg) This will be documented here: https://www.mediawiki.org/wiki/Phabricator/Diffusion#Requesting_a_new_repository I've already taken a first stab at... [00:09:09] 5Gerrit-Migration, 10Gitblit-Deprecate, 10Diffusion: Define a process to import and create repositories - https://phabricator.wikimedia.org/T1009#1843318 (10chasemp) I would feel a better if we were backing up repo's hosted in Phab to somewhere not iridium before we do this. Right now it's a primary source... [00:09:45] 5Gerrit-Migration: Update Code Review related documentation on wiki pages - https://phabricator.wikimedia.org/T207#1843326 (10greg) p:5Low>3Normal [00:11:40] 5Gerrit-Migration: Update Code Review related documentation on wiki pages - https://phabricator.wikimedia.org/T207#2776 (10greg) [00:13:13] 6Release-Engineering-Team, 6Phabricator, 7Puppet: phabricator at labs is not up to date - https://phabricator.wikimedia.org/T117441#1843333 (10Negative24) @mmodell Thanks for your details (and icons to go with it :)). Shouldn't `sudo service apache2 restart` be used instead of the init V script? [00:13:50] 5Gerrit-Migration: Update Code Review related documentation on wiki pages - https://phabricator.wikimedia.org/T207#1843334 (10greg) Why do these pages live under "Gerrit"? * https://www.mediawiki.org/wiki/Gerrit/Code_review * https://www.mediawiki.org/wiki/Gerrit/Code_review/Getting_reviews It looks like mw:Git... [00:14:17] 6Release-Engineering-Team, 6Phabricator, 7Puppet: phabricator at labs is not up to date - https://phabricator.wikimedia.org/T117441#1843335 (10Negative24) p:5High>3Low [00:18:05] 5Gerrit-Migration: Update Code Review related documentation on wiki pages - https://phabricator.wikimedia.org/T207#1843340 (10greg) >>! In T207#1843334, @greg wrote: > It looks like mw:Git was redirected to mw:Gerrit, sadly. To be fair, the content of mw:Git wasn't the most useful: https://www.mediawiki.org/w/i... [00:22:48] 10Differential, 5Gerrit-Migration, 7Documentation: Create example workflows for differential showing old way and new way side by side - https://phabricator.wikimedia.org/T117058#1843359 (10greg) I created a stub of a page at https://www.mediawiki.org/wiki/Phabricator/Differential, we could probably document... [00:23:21] 5Gerrit-Migration: Define main tasks (epics) for code review in Phabricator - https://phabricator.wikimedia.org/T584#1843360 (10greg) [00:23:28] PROBLEM - Parsoid on deployment-parsoid05 is CRITICAL: Connection refused [00:23:34] 5Gerrit-Migration: Define main tasks (epics) for code review in Phabricator - https://phabricator.wikimedia.org/T584#1843361 (10greg) p:5Low>3Normal [00:26:27] 5Gerrit-Migration: Provide static dump of Gerrit - https://phabricator.wikimedia.org/T617#1843379 (10greg) p:5Low>3Normal [00:27:05] 5Gerrit-Migration, 7Epic: Align Wikimedia and Phabricator code review processes - https://phabricator.wikimedia.org/T167#1843382 (10greg) p:5Low>3Normal [00:28:30] RECOVERY - Parsoid on deployment-parsoid05 is OK: HTTP OK: HTTP/1.1 200 OK - 1514 bytes in 0.126 second response time [00:29:02] 5Gerrit-Migration, 10Analytics-Tech-community-metrics: Make MetricsGrimoire/korma support gathering Code Review statistics from Phabricator's Differential - https://phabricator.wikimedia.org/T118753#1843392 (10greg) "Bitergia to check out the the API of Differential." Is that a commitment from them? If so, wha... [00:31:55] 10Differential, 5Gerrit-Migration, 6translatewiki.net, 7I18n: Train L10n-bot to work with Differential in Wikimedia Phabricator - https://phabricator.wikimedia.org/T92493#1843410 (10greg) p:5Low>3Normal [00:34:39] 5Gerrit-Migration: Ability for a privileged application to provide test status of a commit - https://phabricator.wikimedia.org/T190#1843417 (10greg) >>! In T190#1842320, @mmodell wrote: > @greg: all we really need is to install arcanist on the jenkins slaves and this would work already. Just to be clear: if we... [00:34:54] 5Gerrit-Migration: Ability for a privileged application to provide test status of a commit - https://phabricator.wikimedia.org/T190#1843420 (10greg) p:5Low>3Normal [00:40:57] 10Differential, 5Gerrit-Migration: Arcanist installer for Windows - https://phabricator.wikimedia.org/T172#1843430 (10greg) [[ https://secure.phabricator.com/book/phabricator/article/arcanist/#installing-arcanist | These instructions ]] are pretty straight forward and comparable to [[ https://www.mediawiki.org... [00:41:04] 10Differential: Arcanist installer for Windows - https://phabricator.wikimedia.org/T172#1843432 (10greg) [00:41:21] 5Gerrit-Migration, 10Gitblit-Deprecate, 10Diffusion: Define a process to import and create repositories - https://phabricator.wikimedia.org/T1009#1843433 (10demon) >>! In T1009#1843318, @chasemp wrote: > I would feel a better if we were backing up repo's hosted in Phab to somewhere not iridium before we do t... [00:42:44] twentyafterfour: What's left to do is write some rewrite rules for text-lb like we did for svn.wm.o [00:42:48] I started on it earlier. [00:44:43] 10Differential, 5Gerrit-Migration: Running `arc diff` twice on the same commit creates another redundant diff within the same differential - https://phabricator.wikimedia.org/T137#1843440 (10greg) I personally don't see this as a blocker for migration. Is it annoying in some cases? maybe. Is it debatable of wh... [00:45:03] 10Differential, 5Gerrit-Migration, 10Security-Reviews: security review of phabricator.w.o before being used for git hosting and code review - https://phabricator.wikimedia.org/T117552#1843449 (10demon) I would also mention that Gerrit never underwent a security review either. [00:45:20] 10Continuous-Integration-Config, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Continuous integration for wikimedia/fundraising/civicrm-buildkit - https://phabricator.wikimedia.org/T120044#1843450 (10awight) 3NEW [00:55:38] 10Differential, 5Gerrit-Migration: Find way to use Differential with plain git (i.e.: without requiring arc) - https://phabricator.wikimedia.org/T127#1843486 (10greg) For the record, there's a differential upstream that would allow someone to create a new Differential by just pushing (using plain git) a new co... [00:57:28] 5Gerrit-Migration, 6Phabricator, 7Puppet: Configure backula to backup the /srv/phab/repos directory - https://phabricator.wikimedia.org/T120045#1843488 (10greg) 3NEW [00:58:18] 5Gerrit-Migration, 10Gitblit-Deprecate, 10Diffusion: Define a process to import and create repositories - https://phabricator.wikimedia.org/T1009#17455 (10greg) >>! In T1009#1843433, @demon wrote: >>>! In T1009#1843318, @chasemp wrote: >> I would feel a better if we were backing up repo's hosted in Phab to s... [00:59:04] 10Differential, 5Gerrit-Migration, 10Security-Reviews, 15User-greg: security review of phabricator.w.o before being used for git hosting and code review - https://phabricator.wikimedia.org/T117552#1843502 (10greg) 5Open>3declined a:3greg With that, I'm going to decline this for now. I'll let @csteipp... [01:02:40] 10Differential, 5Gerrit-Migration, 10Security-Reviews, 15User-greg: security review of phabricator.w.o before being used for git hosting and code review - https://phabricator.wikimedia.org/T117552#1843510 (10csteipp) Upstream runs a bug-bounty program specifically for phabricator (https://hackerone.com/pha... [01:12:16] 5Gerrit-Migration: Define main tasks (epics) for code review in Phabricator - https://phabricator.wikimedia.org/T584#1843538 (10greg) So, I'm still not sure of the usefullness of this. The original intent, I believe, was to get an idea of how 'hard' it was going to be to do this. (iow: "We have 5 epics worth of... [01:19:46] 5Gerrit-Migration: Define main tasks (epics) for code review in Phabricator - https://phabricator.wikimedia.org/T584#1843551 (10Jdforrester-WMF) >>! In T584#1843538, @greg wrote: > So, I'm still not sure of the usefullness of this. The original intent, I believe, was to get an idea of how 'hard' it was going to... [01:23:43] 5Gerrit-Migration, 15User-greg: Proof of concept of code review in Phabricator - https://phabricator.wikimedia.org/T560#1843579 (10greg) [01:23:46] 5Gerrit-Migration: Plan to migrate code review from Gerrit to Phabricator - https://phabricator.wikimedia.org/T18#1843580 (10greg) [01:23:48] 5Gerrit-Migration, 15User-greg: Define main tasks (epics) for code review in Phabricator - https://phabricator.wikimedia.org/T584#1843576 (10greg) 5Open>3Resolved a:3greg As such, marking as done. If you're curious about "What needs to happen to get this done?" go to the #Gerrit-migration workboard. [01:27:44] 5Gerrit-Migration, 6Phabricator, 5Patch-For-Review, 7Puppet: Configure backula to backup the /srv/phab/repos directory - https://phabricator.wikimedia.org/T120045#1843598 (10demon) 5Open>3Resolved a:3demon This should be all setup now. [01:28:02] 5Gerrit-Migration, 6Phabricator, 5Patch-For-Review, 7Puppet: Configure backula to backup the /srv/phab/repos directory - https://phabricator.wikimedia.org/T120045#1843602 (10Dzahn) I can confirm the bacula stuff has been installed on iridium, the phab server. If you want to really have this confirmed let's... [02:36:48] 5Gerrit-Migration: Ability for a privileged application to provide test status of a commit - https://phabricator.wikimedia.org/T190#1843724 (10mmodell) @greg: sort-of. We still have to configure which jobs run for differential revisions in each repository and make sure those jenkins jobs are calling back to phab... [02:38:59] so, crazy question... why are mediawiki extensions each in their own separate git repo? Couldn't the hundreds of them that aren't really under heavy development get merged into a single repo? [02:39:36] some of them need separate ACLs [02:40:18] 7Browser-Tests, 10VisualEditor, 10VisualEditor-ContentEditable: VisualEditor: Inserting some content in a QA script doesn't round-trip (null diff) - failure to inserting CE content into DM somehow? - https://phabricator.wikimedia.org/T55721#1843733 (10Jdforrester-WMF) 5Open>3Resolved a:3Jdforrester-WMF... [02:40:19] I think ExtensionDistributor relies on separate repos [02:40:25] right and any that need separate acl could have their own repos [02:41:54] I'm a few months too new to wikimedia to have used SVN a lot unfortunately [02:42:29] I imagine some of the pros/cons documentation around that migration mentioned this sort of thing [02:43:18] having everything in one place has it's advantages (up to the point where the repo becomes huge and unwieldy) [02:46:28] ostriches? [02:47:01] twentyafterfour, if you wanted to add anyone to a repository that's part of a group, you'd have to split it up again... histories will be messy [02:47:58] Can't deny someone such access because of your extension shared repository [02:48:35] what are the advantages, twentyafterfour? [02:50:26] VE's two repos have > 10k commits each. [02:50:40] There's a level of merging repos that gets unweildy. [02:50:45] (Also, spelling.) [02:52:37] twentyafterfour would be excluding VE because we grant additional people rights via custom ACLs [02:53:09] We have that extension-VisualEditor-staff group that doesn't really include all wmf people working on VE [02:56:45] It doesn't? [02:57:36] Oh, odd, it misses you and kemayo. We should fix that. [02:58:54] I miss svn [02:59:35] * Krenair kicks ostriches [03:00:24] * ostriches punches back. Hard [03:35:06] 10Differential, 5Gerrit-Migration, 7Documentation: Create example workflows for differential showing old way and new way side by side - https://phabricator.wikimedia.org/T117058#1843797 (10mmodell) @greg: you couldn't be more right. The information architecture of mediawiki documentation is horrendous. [03:42:14] 10Differential, 5Gerrit-Migration, 10Security-Reviews, 15User-greg: security review of phabricator.w.o before being used for git hosting and code review - https://phabricator.wikimedia.org/T117552#1843806 (10mmodell) I have been pulling from upstream on an almost regular schedule. Time between updates is i... [03:43:43] 6Release-Engineering-Team, 6Phabricator, 7Puppet: phabricator at labs is not up to date - https://phabricator.wikimedia.org/T117441#1843808 (10mmodell) >>! In T117441#1843333, @Negative24 wrote: > @mmodell Thanks for your details (and icons to go with it :)). > > Shouldn't `sudo service apache2 restart` be... [06:29:40] (03PS1) 10Smalyshev: Add tox to discovery-analytics project [integration/config] - 10https://gerrit.wikimedia.org/r/256383 [06:39:17] 10Differential, 5Gerrit-Migration, 7Documentation: Create example workflows for differential showing old way and new way side by side - https://phabricator.wikimedia.org/T117058#1843899 (10Luke081515) Maybe another problem: I don't know, how you want to control, who can review a patch. You can use blocking... [08:01:31] 10Differential, 5Gerrit-Migration, 7Documentation: Create example workflows for differential showing old way and new way side by side - https://phabricator.wikimedia.org/T117058#1844019 (10mmodell) @luke081515: I don't think we should have any bots doing merges with differential. [08:02:54] 10Differential: Support simple ("one-click") generation of cherry-pick Differentials between branches - https://phabricator.wikimedia.org/T117776#1844021 (10mmodell) cherry-picking should be avoided, not encouraged. [08:04:57] 10Differential, 5Gerrit-Migration: Document git-review -> arc mapping. - https://phabricator.wikimedia.org/T112967#1844026 (10mmodell) This is the same thing as T117058 [08:07:21] 10Differential, 5Gerrit-Migration, 7Documentation: Document gerrit workflows and demonstrate equivalent in arcanist workflows - https://phabricator.wikimedia.org/T117058#1844028 (10mmodell) [08:08:13] 10Differential, 5Gerrit-Migration, 7Documentation: Document gerrit workflows and demonstrate equivalent in arcanist workflows - https://phabricator.wikimedia.org/T117058#1765720 (10mmodell) [08:08:14] 10Differential, 5Gerrit-Migration: Document git-review -> arc mapping. - https://phabricator.wikimedia.org/T112967#1844029 (10mmodell) [08:39:55] 10Gitblit-Deprecate, 10Diffusion, 5Patch-For-Review: redirect gerrit repo paths to diffusion callsigns - https://phabricator.wikimedia.org/T110607#1844069 (10Liuxinyu970226) [08:56:18] zeljkof: good morning, do we need a check in today ? :D [08:56:35] hashar: good morning :D [08:56:37] after the 2 x 1 hour sessions from yesterday, I have not much to say [08:56:42] same here [08:56:51] we can skip the meeting today [08:57:57] good :) [08:58:59] 10Differential, 5Gerrit-Migration, 7Documentation: Document gerrit workflows and demonstrate equivalent in arcanist workflows - https://phabricator.wikimedia.org/T117058#1844086 (10hashar) >>! In T117058#1844019, @mmodell wrote: > @luke081515: I don't think we should have any bots doing merges with different... [09:03:42] hashar: do you want to cancel Wednesday meetings? since we have a meeting on Tuesday afternoon [09:03:54] zeljkof: yeah make sense [09:04:23] it's in your calendar, just remove Wednesday [09:06:44] 10Differential: Arcanist installer for Windows - https://phabricator.wikimedia.org/T172#1844091 (10hashar) 5Open>3declined a:3hashar From @greg link https://secure.phabricator.com/book/phabricator/article/arcanist/#installing-arcanist : ``` git clone https://github.com/phacility/libphutil.git git clone htt... [09:10:48] zeljkof: should we move the friday one to thursday ? [09:11:23] this way we get Monday checkin, Tuesday confs, Thursday checkin [09:11:26] hashar: sure [09:11:48] there is two days between Monday morning and Tuesday afternoon [09:12:22] then one full day Tuesday afternoon to Thursday morning [09:12:35] then two full days from Thursday morning to Monday morning [09:12:41] seems like a good coverage :) [09:13:11] yeah [09:13:12] done [09:13:19] great, thanks [09:15:00] and I added one for tomorrow [09:16:13] zeljkof: I am cancelling a few [09:16:30] hashar: holidays? [09:17:52] yeah [09:18:12] and I guess we will not be able to do any during beginning of january [09:19:07] !log beta-scap-eqiad is broken Permission denied (publickey). [09:19:10] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL, Master [09:19:39] oh [09:19:59] Reedy: when rebooting deployment-bastion one has to rearm the scap keyholder ! [09:24:14] !log key holder rearmed (hopefully) doc at https://wikitech.wikimedia.org/wiki/Keyholder [09:24:17] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL, Master [09:25:01] lets see what happens https://integration.wikimedia.org/ci/job/beta-scap-eqiad/80862/consoleFull [09:57:07] (03CR) 10Hashar: [C: 032] "Thanks!" [integration/config] - 10https://gerrit.wikimedia.org/r/256383 (owner: 10Smalyshev) [10:01:16] (03Merged) 10jenkins-bot: Add tox to discovery-analytics project [integration/config] - 10https://gerrit.wikimedia.org/r/256383 (owner: 10Smalyshev) [10:13:23] 10Differential, 5Gerrit-Migration, 7Documentation: Document gerrit workflows and demonstrate equivalent in arcanist workflows - https://phabricator.wikimedia.org/T117058#1844204 (10Luke081515) Another problem: Do we got a function, that we don't make all unit tests for new users? [10:15:01] beta-scap is fixed! [10:22:39] 10Deployment-Systems, 6operations: /srv/deployment wrong permissions on new installs - https://phabricator.wikimedia.org/T90588#1844221 (10fgiunchedi) 5Open>3Resolved a:3fgiunchedi looks like this was fixed, from `mw2208` freshly reimaged yesterday `drwxr-xr-x 3 root root 4096 Dec 1 13:55 /srv/deployme... [10:32:52] 10Continuous-Integration-Infrastructure, 5Continuous-Integration-Scaling, 5Patch-For-Review: Nodepool images need Gerrit mirror for git-clone performance - https://phabricator.wikimedia.org/T87294#1844252 (10hashar) The cache is generated when building the image: via `dib/elements/wikimedia/root.d/01-mirror-... [10:46:10] 10Deployment-Systems, 6Release-Engineering-Team, 5Patch-For-Review, 7user-notice: Move the train deployment from Thursday to Wednesday for some Wikipedia sites - https://phabricator.wikimedia.org/T115002#1844285 (10Johan) [10:52:22] 10Continuous-Integration-Infrastructure, 5Continuous-Integration-Scaling, 7Nodepool: Nodepool - https://phabricator.wikimedia.org/T120076#1844299 (10hashar) 3NEW [10:54:16] 10Continuous-Integration-Infrastructure, 5Continuous-Integration-Scaling, 7Nodepool: Nodepool - https://phabricator.wikimedia.org/T120076#1844312 (10hashar) [10:55:31] 5Continuous-Integration-Scaling, 7Nodepool: Document Nodepool statsd metrics - https://phabricator.wikimedia.org/T111503#1844319 (10Liuxinyu970226) [11:05:30] !log manually refreshed nodepool snapshot ( Image ci-jessie-wikimedia-1449053701 in wmflabs-eqiad is ready ) while investigating for https://phabricator.wikimedia.org/T120076 [11:05:33] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL, Master [11:05:35] 10Continuous-Integration-Infrastructure, 5Continuous-Integration-Scaling, 7Nodepool: Nodepool - https://phabricator.wikimedia.org/T120076#1844336 (10hashar) We can still manually update the snapshot though: ``` nodepool@labnodepool1001:~$ nodepool image-update wmflabs-eqiad ci-jessie-wikimedia 2015-12-02 10:... [11:06:33] !log restarting nodepool [11:06:36] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL, Master [11:09:02] 10Continuous-Integration-Infrastructure, 5Continuous-Integration-Scaling, 7Nodepool: Nodepool - https://phabricator.wikimedia.org/T120076#1844345 (10hashar) Restarted nodepool process on labnodepool1001.eqiad.wmnet [11:16:38] !log configure wmf-insecte to join #wikimedia-android-ci ( https://gerrit.wikimedia.org/r/#/c/254905/3/jjb/mobile.yaml,unified ) [11:16:41] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL, Master [11:17:14] though the bot is not around [11:17:14] grr [11:17:40] 5Testing-Initiative-2015, 10Browser-Tests-Infrastructure, 5Patch-For-Review: Experiment with browser testing in other software languages - https://phabricator.wikimedia.org/T108874#1844352 (10zeljkofilipin) [11:18:22] wmf-insecte: [11:18:22] hashar you may not issue bot commands in this chat! [11:18:23] ::} [11:19:39] 5Testing-Initiative-2015, 10Browser-Tests-Infrastructure, 5Patch-For-Review: Experiment with browser testing in other software languages - https://phabricator.wikimedia.org/T108874#1532739 (10zeljkofilipin) [11:20:23] 5Testing-Initiative-2015, 10Browser-Tests-Infrastructure, 5Patch-For-Review: Experiment with browser testing in other software languages - https://phabricator.wikimedia.org/T108874#1844357 (10zeljkofilipin) [11:23:55] 5Testing-Initiative-2015, 10Browser-Tests-Infrastructure, 5Patch-For-Review: Experiment with browser testing in other software languages - https://phabricator.wikimedia.org/T108874#1844358 (10zeljkofilipin) [11:24:52] (03PS1) 10Hashar: operations/puppet: add tox-jessie to experimental [integration/config] - 10https://gerrit.wikimedia.org/r/256397 [11:25:47] (03CR) 10Hashar: [C: 032] operations/puppet: add tox-jessie to experimental [integration/config] - 10https://gerrit.wikimedia.org/r/256397 (owner: 10Hashar) [11:25:54] 5Testing-Initiative-2015, 10Browser-Tests-Infrastructure, 5Patch-For-Review: Experiment with browser testing in other software languages - https://phabricator.wikimedia.org/T108874#1844361 (10zeljkofilipin) [11:29:05] (03Merged) 10jenkins-bot: operations/puppet: add tox-jessie to experimental [integration/config] - 10https://gerrit.wikimedia.org/r/256397 (owner: 10Hashar) [11:29:10] 5Testing-Initiative-2015, 10Browser-Tests-Infrastructure, 5Patch-For-Review: Experiment with browser testing in other software languages - https://phabricator.wikimedia.org/T108874#1844368 (10zeljkofilipin) [11:33:46] 5Testing-Initiative-2015, 10Browser-Tests-Infrastructure, 5Patch-For-Review: Experiment with browser testing in other software languages - https://phabricator.wikimedia.org/T108874#1844377 (10zeljkofilipin) [11:43:27] (03CR) 10Hashar: "Jenkins config is only done via the web interface :/ I have made the bot to join the channel. It is named "wmf-insecte" ("insecte" is fre" [integration/config] - 10https://gerrit.wikimedia.org/r/254905 (https://phabricator.wikimedia.org/T118098) (owner: 10Niedzielski) [11:43:31] (03PS4) 10Hashar: Move long running Android tests to periodic job [integration/config] - 10https://gerrit.wikimedia.org/r/254905 (https://phabricator.wikimedia.org/T118098) (owner: 10Niedzielski) [11:44:05] (03CR) 10Hashar: [C: 032] "Got deployed, that poll the scm and pass. So lets merge this in, we can adjust later on as needed." [integration/config] - 10https://gerrit.wikimedia.org/r/254905 (https://phabricator.wikimedia.org/T118098) (owner: 10Niedzielski) [11:44:21] 5Testing-Initiative-2015, 10Browser-Tests-Infrastructure, 5Patch-For-Review: Experiment with browser testing in other software languages - https://phabricator.wikimedia.org/T108874#1844397 (10zeljkofilipin) [11:45:43] (03Merged) 10jenkins-bot: Move long running Android tests to periodic job [integration/config] - 10https://gerrit.wikimedia.org/r/254905 (https://phabricator.wikimedia.org/T118098) (owner: 10Niedzielski) [11:48:01] 5Testing-Initiative-2015, 10Browser-Tests-Infrastructure, 5Patch-For-Review: Experiment with browser testing in other software languages - https://phabricator.wikimedia.org/T108874#1844407 (10zeljkofilipin) [11:48:19] 5Gerrit-Migration, 15User-greg: Define main tasks (epics) for code review in Phabricator - https://phabricator.wikimedia.org/T584#1844408 (10Qgil) Not that it matters but yes, I agree that the purpose of this task has been superseded by #Gerrit-Migration. When this task was created, our brains were still fille... [11:58:41] 5Gerrit-Migration: Update Code Review related documentation on wiki pages - https://phabricator.wikimedia.org/T207#1844427 (10Qgil) Now we have pages like [[ https://www.mediawiki.org/wiki/Phabricator/Project_management | Phabricator/Project_management ]]... I would not dig much into the past. :) In any case,... [11:59:02] 5Gerrit-Migration, 7Documentation: Update Code Review related documentation on wiki pages - https://phabricator.wikimedia.org/T207#1844428 (10Qgil) [13:17:38] (03Abandoned) 10Krinkle: Implement git-cache-update script [integration/jenkins] - 10https://gerrit.wikimedia.org/r/206074 (https://phabricator.wikimedia.org/T96687) (owner: 10Krinkle) [13:56:14] hashar: Can you look at https://gerrit.wikimedia.org/r/#/c/195021/ or close it? [14:55:26] PROBLEM - Puppet failure on wmfbranch is CRITICAL: CRITICAL: 40.00% of data above the critical threshold [0.0] [15:00:06] PROBLEM - Puppet failure on deployment-tin is CRITICAL: CRITICAL: 55.56% of data above the critical threshold [0.0] [15:32:35] 3Scap3, 3releng-201516-q2: [keyresult] Migrate all Service team owned services and MW deploys to scap3 - https://phabricator.wikimedia.org/T109926#1844858 (10thcipriani) [15:33:25] 3Scap3, 3releng-201516-q2: [keyresult] Migrate all Service team owned services and MW deploys to scap3 - https://phabricator.wikimedia.org/T109926#1844860 (10hashar) We would need sub tasks to also switch: * cxserver * graphoid * parsoid [16:29:55] (03PS2) 10Hashar: Integration tests with make-wmf-branch [integration/config] - 10https://gerrit.wikimedia.org/r/256413 [16:31:06] (03CR) 10jenkins-bot: [V: 04-1] Integration tests with make-wmf-branch [integration/config] - 10https://gerrit.wikimedia.org/r/256413 (owner: 10Hashar) [16:53:41] 10Deployment-Systems, 3Scap3, 10Parsoid: Deploy Parsoid with scap3 - https://phabricator.wikimedia.org/T120103#1845105 (10thcipriani) `deployment-parsoid05` and `deployment-cache-parsoid05` seem like likely deployment targets in beta. Looking at the `repo_config` salt pillar it seems like the transition from... [16:58:54] 10Deployment-Systems, 3Scap3, 10Parsoid: Deploy Parsoid with scap3 - https://phabricator.wikimedia.org/T120103#1845119 (10mobrovac) AFAIK, @hashar has got a special jenkins update job for that. [17:02:02] 10Deployment-Systems, 3Scap3, 10Parsoid: Deploy Parsoid with scap3 - https://phabricator.wikimedia.org/T120103#1845133 (10greg) >>! In T120103#1845119, @mobrovac wrote: > AFAIK, @hashar has got a special jenkins update job for that. https://integration.wikimedia.org/ci/view/Beta/job/beta-parsoid-update-eqia... [17:03:14] 10Deployment-Systems, 3Scap3, 10Parsoid: Deploy Parsoid with scap3 - https://phabricator.wikimedia.org/T120103#1845135 (10greg) And we do the same thing for cxserver [17:04:37] 10Deployment-Systems, 3Scap3, 10Parsoid: Deploy Parsoid with scap3 - https://phabricator.wikimedia.org/T120103#1845138 (10hashar) Parsoid is the one of the two backend services magically updated via Jenkins (the other is cxserver). The job is https://integration.wikimedia.org/ci/job/beta-parsoid-update-eqia... [17:04:59] mobrovac: thcipriani: jenkins for cxserver/parsoid is really lame [17:05:15] beta has one instance for each of cxserver / parsoid [17:05:17] not sca [17:05:33] so I made each instance to be jenkins slaves, and the job runs directly on the instance (not deployment-bastion) [17:05:47] from there it is git pull && rsync to /srv/deploy && service restart [17:05:47] 10Deployment-Systems, 3Scap3, 10Analytics, 6Analytics-Backlog, and 2 others: Deploy AQS with scap3 - https://phabricator.wikimedia.org/T114999#1845141 (10JAllemandou) >>! In T114999#1845008, @mobrovac wrote: >>>! In T114999#1844957, @greg wrote: >> (Off-topic-ish: There's no AQS project in Phab? Do all dev... [17:05:49] pretty lame [17:06:12] potentially we could get cxserver / parsoid deployed to the beta cluster scaXXX hosts [17:06:34] once happy with how the deploy part works, we can adjust the beta cluster varnishes to use the sca instances as backends [17:08:17] gotta rush out :-/ [17:08:20] later [17:18:53] 10Gitblit-Deprecate, 10Diffusion: Process to request the read-only mirror of a non-gerrit code repository in Diffusion - https://phabricator.wikimedia.org/T75983#1845171 (10greg) >>! In T75983#1843257, @greg wrote: >>>! In T75983#1842216, @demon wrote: >> Right now my inclination on repository requests (also i... [17:34:04] 10Gitblit-Deprecate, 10Diffusion: Process to request the read-only mirror of a non-gerrit code repository in Diffusion - https://phabricator.wikimedia.org/T75983#1845208 (10demon) Works for me :) [17:38:02] 10Gitblit-Deprecate, 10Diffusion, 15User-greg: Process to request the read-only mirror of a non-gerrit code repository in Diffusion - https://phabricator.wikimedia.org/T75983#1845211 (10greg) 5Open>3Resolved a:3greg [17:41:17] 10Gitblit-Deprecate, 10Wikimedia-Apache-configuration: Write redirect rules from gitweb URLs - https://phabricator.wikimedia.org/T43961#1845215 (10greg) [17:42:56] 10Gitblit-Deprecate, 10Diffusion, 15User-greg: Process to request the read-only mirror of a non-gerrit code repository in Diffusion - https://phabricator.wikimedia.org/T75983#1845218 (10mmodell) /me thinks that @greg just wants to bolster his closed-task count. [17:42:59] 10Gitblit-Deprecate, 10Wikimedia-Apache-configuration: Write redirect rules from gitweb to gitblit - https://phabricator.wikimedia.org/T43961#1845219 (10greg) [17:45:57] 10Gitblit-Deprecate, 10Diffusion: Update mediawiki.org templates to link to Diffusion, not gitblit - https://phabricator.wikimedia.org/T108864#1845223 (10Paladox) It seems to be done now. But echo is not working. Going to this link https://phabricator.wikimedia.org/r/project/mediawiki/extensions/Echo responds... [17:49:44] 10Gitblit-Deprecate, 10Diffusion, 5Patch-For-Review: redirect gerrit repo paths to diffusion callsigns - https://phabricator.wikimedia.org/T110607#1845227 (10Paladox) Could these redirects be set to active on phabricator because someone has changed the links to things like https://phabricator.wikimedia.org/r... [17:50:46] greg-g: it looks like https://gerrit.wikimedia.org/r/#/c/255422/ needs to be merged. Is that safe to deploy during our freeze? [17:50:48] 10Gitblit-Deprecate, 10Diffusion, 5Patch-For-Review: redirect gerrit repo paths to diffusion callsigns - https://phabricator.wikimedia.org/T110607#1845229 (10Paladox) Caused by https://www.mediawiki.org/w/index.php?title=Template:WikimediaDownload&oldid=1954487 [17:51:47] twentyafterfour: yeah, that's fine [17:51:55] luke usually gets those done during a swat [17:53:02] 5Gerrit-Migration, 10Gitblit-Deprecate, 6Release-Engineering-Team, 10Diffusion: Import all gerrit.wikimedia.org repositories with Diffusion - https://phabricator.wikimedia.org/T616#1845233 (10Paladox) Maybe a note should be added to https://www.mediawiki.org/wiki/Git/New_repositories/Requests so that an ad... [17:53:10] 10Gitblit-Deprecate, 10Diffusion, 5Patch-For-Review: redirect gerrit repo paths to diffusion callsigns - https://phabricator.wikimedia.org/T110607#1845234 (10greg) >>! In T110607#1845229, @Paladox wrote: > Caused by https://www.mediawiki.org/w/index.php?title=Template:WikimediaDownload&oldid=1954487 More us... [17:57:18] 5Gerrit-Migration, 10Gitblit-Deprecate, 6Release-Engineering-Team, 10Diffusion: Import all gerrit.wikimedia.org repositories with Diffusion - https://phabricator.wikimedia.org/T616#1845239 (10greg) >>! In T616#1845233, @Paladox wrote: > Maybe a note should be added to https://www.mediawiki.org/wiki/Git/New... [18:00:26] PROCS CRITICAL: 2 processes with regex args '^/usr/lib/git-core/git-daemon' [18:00:31] on gallium, the jenkins box [18:00:34] (03PS1) 10Niedzielski: Fix Android periodic test polling [integration/config] - 10https://gerrit.wikimedia.org/r/256453 [18:00:43] did we expect anything like that maybe? [18:00:46] or is it just crashed [18:00:52] 10Gitblit-Deprecate, 10Diffusion, 5Patch-For-Review: redirect gerrit repo paths to diffusion callsigns - https://phabricator.wikimedia.org/T110607#1845267 (10mmodell) done [18:00:57] i'll try to restart it ..but... [18:02:23] it fixed itself [18:07:11] 10Gitblit-Deprecate, 10Diffusion, 5Patch-For-Review: redirect gerrit repo paths to diffusion callsigns - https://phabricator.wikimedia.org/T110607#1845277 (10Paladox) Thanks. [18:07:28] 10Gitblit-Deprecate, 10Diffusion: Update mediawiki.org templates to link to Diffusion, not gitblit - https://phabricator.wikimedia.org/T108864#1845278 (10greg) >>! In T108864#1845223, @Paladox wrote: > It seems to be done now. But echo is not working. Going to this link https://phabricator.wikimedia.org/r/proj... [18:08:16] 5Gerrit-Migration, 10Gitblit-Deprecate: Update {{git file}} to link to diffusion - https://phabricator.wikimedia.org/T101358#1845282 (10greg) [18:08:18] 10Gitblit-Deprecate, 10Diffusion, 5Patch-For-Review: redirect gerrit repo paths to diffusion callsigns - https://phabricator.wikimedia.org/T110607#1845281 (10greg) 5Open>3Resolved [18:08:20] 10Gitblit-Deprecate, 10Wikimedia-Apache-configuration: Write redirect rules from gitweb to gitblit - https://phabricator.wikimedia.org/T43961#1845283 (10greg) [18:08:33] regarding that config change, I only asked because someone is inquiring about it in #wikimedia-devtools [18:08:42] * twentyafterfour should redirect them here I guess [18:09:33] twentyafterfour: yeah, saw that, was looking at it too when you pinged [18:10:10] twentyafterfour: btw, do we have a "redirect gitblit urls to diffusion" task yet? I see gerrit->diffusion and gitweb (yeah..) -> gitblit [18:10:52] I don't think there is a separate task, but we could repurpose one of the existing ones [18:11:27] 10Deployment-Systems, 10Wikimedia-General-or-Unknown, 6operations, 5Patch-For-Review, 15User-bd808: localisationupdate broken on wmf wikis by scap master-master sync changes - https://phabricator.wikimedia.org/T119746#1845293 (10bd808) >>! In T119746#1837536, @gerritbot wrote: > Change 255952 merged by O... [18:13:07] twentyafterfour: I'm just trying to clean up the gitblit-deprecate board a bit, and was confused that I didn't see one [18:14:40] 10Gitblit-Deprecate: A gerrit project's Access > "History:" links to gitblit - https://phabricator.wikimedia.org/T107981#1845302 (10greg) p:5Triage>3Normal [18:15:14] 10Deployment-Systems, 10Gitblit-Deprecate: Change commit links in Special:Version to link to diffusion - https://phabricator.wikimedia.org/T114074#1845308 (10greg) p:5Triage>3Normal [18:15:54] 10Gitblit-Deprecate, 10Diffusion: Update mediawiki.org templates to link to Diffusion, not gitblit - https://phabricator.wikimedia.org/T108864#1845315 (10greg) p:5Triage>3Normal [18:18:23] 10Gitblit-Deprecate, 10Diffusion, 15User-greg: Process to request the read-only mirror of a non-gerrit code repository in Diffusion - https://phabricator.wikimedia.org/T75983#1845327 (10Krenair) I don't think Phabricator provides a list of people ordered by tasks closed like (IIRC) Bugzilla did? [18:18:51] 10Gitblit-Deprecate: A gerrit project's Access > "History:" links to gitblit - https://phabricator.wikimedia.org/T107981#1845329 (10mmodell) currently it is not possible to browse refs like that in diffusion. [18:21:59] 10Gitblit-Deprecate, 6Phabricator: Commits being made in random users names (bad associations) - https://phabricator.wikimedia.org/T77959#1845348 (10greg) >>! In T77959#1091354, @Nemo_bis wrote: > I mean that in diffusion so far I only found diffusion's own interpretation of the metadata, but no way to see the... [18:22:28] 10Beta-Cluster-Infrastructure, 3Scap3, 6Analytics-Backlog, 6Services, 7WorkType-NewFunctionality: Set up AQS in Beta - https://phabricator.wikimedia.org/T116206#1845351 (10thcipriani) This morning @mobrovac and I setup `deployment-aqs01` on beta. Deployed via Scap3 successfully and without issue. The AQ... [18:23:03] 10Gitblit-Deprecate, 10Diffusion, 15User-greg: Process to request the read-only mirror of a non-gerrit code repository in Diffusion - https://phabricator.wikimedia.org/T75983#1845357 (10greg) >>! In T75983#1845218, @mmodell wrote: > /me thinks that @greg just wants to bolster his closed-task count. :P I rea... [18:25:39] 10Gitblit-Deprecate, 6Phabricator: Commits being made in random users names (bad associations) - https://phabricator.wikimedia.org/T77959#1845362 (10greg) Independently, we could prioritize this upstream task: https://secure.phabricator.com/T1731 ("Allow users to set their VCS names"), which would address part... [18:27:23] thcipriani: project manager mode: who's responsbile for those puppet changes for aqs? :) [18:28:25] greg-g: mobrovac and myself splitting. Cassandra == mobrovac. restbase == me, a patch I've got going. [18:29:07] greg-g: how should I make that explicit? [18:29:24] thcipriani: ah, as long as it's clear to you two is all that matters really :) [18:31:30] 10Gitblit-Deprecate, 6Phabricator: Commits being made in random users names (bad associations) - https://phabricator.wikimedia.org/T77959#1845390 (10greg) p:5High>3Normal [18:31:46] 10Gitblit-Deprecate, 6Phabricator: Commits being made in random users names (bad associations) - https://phabricator.wikimedia.org/T77959#832848 (10greg) p:5Normal>3High [18:32:49] 10Gitblit-Deprecate, 10MediaWiki-General-or-Unknown: Remove uses of git.wikimedia.org from MediaWiki - https://phabricator.wikimedia.org/T118307#1845399 (10greg) Anything other than Special:Version we should change? [18:48:00] 10Gitblit-Deprecate, 6Phabricator, 10Phabricator-Upstream, 6operations: PHD ensuring umask goodness - https://phabricator.wikimedia.org/T91648#1845440 (10greg) So, just to summarize, what needs to happen here now for us (WMF) going forward? is this blocking anything (this task is in the #gitblit-deprecate... [18:51:13] 5Gerrit-Migration: Plan to migrate code review from Gerrit to Phabricator - https://phabricator.wikimedia.org/T18#1845456 (10greg) [18:51:14] 5Gerrit-Migration, 10Gitblit-Deprecate, 10Diffusion, 15User-greg: Define a process to import and create repositories - https://phabricator.wikimedia.org/T1009#1845450 (10greg) 5Open>3Resolved a:3greg So, I think we're good here with the same output from {T75983}. [18:51:17] 10Gitblit-Deprecate, 6Phabricator, 10Phabricator-Upstream, 6operations: PHD ensuring umask goodness - https://phabricator.wikimedia.org/T91648#1845458 (10chasemp) AFA what can be done here, we could wrap phd in our own init script or something. But for #Gitblit-Deprecate I don't think this blocks? [18:58:20] 10Gitblit-Deprecate, 10MediaWiki-General-or-Unknown: Remove uses of git.wikimedia.org from MediaWiki - https://phabricator.wikimedia.org/T118307#1845501 (10demon) >>! In T118307#1845399, @greg wrote: > Anything other than Special:Version we should change? I think there's a few other stuff (mostly comments and... [19:01:00] 10Gitblit-Deprecate, 10MediaWiki-General-or-Unknown: Remove uses of git.wikimedia.org from MediaWiki - https://phabricator.wikimedia.org/T118307#1845506 (10greg) >>! In T118307#1845501, @demon wrote: > I think there's a few other stuff (mostly comments and the like). Comments are taken care of by the redirec... [19:02:24] 10Gitblit-Deprecate, 10MediaWiki-General-or-Unknown: Remove uses of git.wikimedia.org from MediaWiki - https://phabricator.wikimedia.org/T118307#1845523 (10greg) [19:02:43] 10Gitblit-Deprecate, 10MediaWiki-General-or-Unknown: Remove uses of git.wikimedia.org from MediaWiki - https://phabricator.wikimedia.org/T118307#1845528 (10demon) The *.rb comments look like they could get fixed in qa/browsertests and would be fine for any future creations of those files. [19:03:56] 10Gitblit-Deprecate, 10Diffusion: Allow search engines to crawl diffusion/ and other diffusion pages - https://phabricator.wikimedia.org/T76992#1845534 (10greg) From upstream discussion: >>! In [[ https://secure.phabricator.com/T4610#124876 | T4610#124876 ]], @20after4 wrote: > Very good suggestions, and I wi... [19:04:28] 10Gitblit-Deprecate, 10Diffusion: Allow search engines to crawl diffusion/ and other diffusion pages - https://phabricator.wikimedia.org/T76992#1845547 (10greg) p:5Lowest>3Normal [19:06:57] 10Gitblit-Deprecate, 10Diffusion: Replicate open patchsets to diffusion - https://phabricator.wikimedia.org/T89940#1845554 (10greg) p:5Low>3Normal [19:07:09] 10Gitblit-Deprecate, 10Diffusion: Allow search engines to crawl diffusion/ and other diffusion pages - https://phabricator.wikimedia.org/T76992#1845556 (10greg) p:5Normal>3Lowest (bad drag/drop on the workboard) [19:07:26] 10Gitblit-Deprecate, 10Diffusion: Replicate open patchsets to diffusion - https://phabricator.wikimedia.org/T89940#1845559 (10greg) p:5Normal>3Low (bad drag/drop on the workboard) [19:08:59] alright, #gitblit deprecate now also better groomed: https://phabricator.wikimedia.org/project/board/46/query/open/?order=priority [20:10:42] 10Deployment-Systems, 3Scap3, 10ContentTranslation-cxserver: Deploy CXServer with scap3 - https://phabricator.wikimedia.org/T120104#1845698 (10hashar) On beta, cxserver is currently refreshed via Jenkins jobs, the same way Parsoid is updated. See notes on T120103 [20:23:38] (03CR) 10Hashar: [C: 032] "Yup the git branch: parameter is for filtering polled branches. origin/master will cause it to only trigger build for that branch." [integration/config] - 10https://gerrit.wikimedia.org/r/256453 (owner: 10Niedzielski) [20:25:23] (03Merged) 10jenkins-bot: Fix Android periodic test polling [integration/config] - 10https://gerrit.wikimedia.org/r/256453 (owner: 10Niedzielski) [20:42:44] hey yall [20:42:55] there is an un committed change on deployment-puppetmaster puppet repo [20:42:57] looks like a scap thing [20:43:07] - file { "${dir}/deploy": [20:43:08] + file { $dir: [20:43:08] ensure => directory, [20:43:08] mode => '0775', [20:43:08] owner => $user, [20:43:08] group => 'wikidev', [20:43:09] } [20:43:10] + file { "${dir}/deploy": [20:43:10] + ensure => directory, [20:43:11] + mode => '0775', [20:43:11] + owner => $user, [20:43:12] + group => 'wikidev', [20:43:12] + require => File[$dir], [20:43:13] + } [20:43:13] can I reset it? [20:46:25] its been busting the git-sync-upstream script for a few hours [20:46:26] --- /usr/local/bin/git-sync-upstream 2015-12-02T20:20:01 [20:46:26] Local diffs detected. Commit your changes! [20:46:28] resetting it [20:46:59] thcipriani: ^ [20:47:07] (haven't yet...) [20:47:08] :) [20:47:11] asking in -labs too [20:48:08] ottomata: whoops, yeah, go ahead and revert that change. [20:48:10] k danke [20:48:25] sorry about that, minor tweaking this morning. [20:49:07] np [21:04:57] 10Continuous-Integration-Infrastructure: Track and graph mean time to merge - https://phabricator.wikimedia.org/T70114#1845855 (10greg) a:3hashar Now at https://grafana.wikimedia.org/dashboard/db/releng-kpis?panelId=2&fullscreen [21:05:03] 10Continuous-Integration-Infrastructure, 7Monitoring: Alert when Zuul/Gearman queue is stalled - https://phabricator.wikimedia.org/T70113#1845859 (10greg) [21:05:05] 10Continuous-Integration-Infrastructure: Track and graph mean time to merge - https://phabricator.wikimedia.org/T70114#1845857 (10greg) 5Open>3Resolved [21:05:11] 10Continuous-Integration-Infrastructure, 6Release-Engineering-Team, 7Zuul: Implement "Jenkins/Zuul queue wait" KPI - https://phabricator.wikimedia.org/T108750#1845860 (10greg) 5Open>3Resolved [21:05:12] 6RelEng-Admin, 15User-greg: Create KPIs for #releng-201516-Q2 - https://phabricator.wikimedia.org/T107905#1845861 (10greg) [21:05:58] 6RelEng-Admin, 15User-greg: Create KPIs for #releng-201516-Q2 - https://phabricator.wikimedia.org/T107905#1506866 (10greg) [21:06:00] 6Release-Engineering-Team, 15User-greg: Add all of the KPIs to a single dashboard - https://phabricator.wikimedia.org/T108744#1845862 (10greg) 5Open>3Resolved a:3greg Both now at https://grafana.wikimedia.org/dashboard/db/releng-kpis [21:06:09] 6RelEng-Admin, 15User-greg: Create KPIs for #releng-201516-Q2 - https://phabricator.wikimedia.org/T107905#1845867 (10greg) 5Open>3Resolved [21:26:30] 3releng-201516-q2: [keyresult] CI cluster responds to spike in queued builds by starting and registering additional jenkins slaves - https://phabricator.wikimedia.org/T111106#1845929 (10greg) The idea we talked about in our 1:1: * Spawn a lot of dummy commits for repos that are tested on nodepool, enough to cau... [21:34:33] 10Deployment-Systems, 3Scap3, 3releng-201516-q3: Migrate the MW weekly train deploy to scap3 - https://phabricator.wikimedia.org/T114313#1845958 (10greg) [21:34:47] 5Gerrit-Migration, 10Gitblit-Deprecate, 6Release-Engineering-Team, 3releng-201516-q3, and 5 others: [RfC]: Migrate code review / management to Phabricator from Gerrit - https://phabricator.wikimedia.org/T119908#1845959 (10greg) [21:34:53] 6Release-Engineering-Team, 3releng-201516-q3, 10Wikimedia-Developer-Summit-2016: Code-review migration to Differential status/discussion - https://phabricator.wikimedia.org/T114320#1845962 (10greg) [21:35:08] 5Continuous-Integration-Scaling, 3releng-201516-q3: [keyresult] Migrate majority of CI jobs to Nodepool (part 2) - https://phabricator.wikimedia.org/T119138#1845963 (10greg) [21:35:23] 10Continuous-Integration-Config, 5Continuous-Integration-Scaling, 3releng-201516-q3, 7WorkType-NewFunctionality: Migrate php composer (Zend and HHVM) CI jobs to Nodepool - https://phabricator.wikimedia.org/T119139#1845964 (10greg) [21:35:31] 10Continuous-Integration-Config, 5Continuous-Integration-Scaling, 3releng-201516-q3, 7WorkType-NewFunctionality: Migrate as many misc CI jobs as possible to Nodepool - https://phabricator.wikimedia.org/T119140#1845966 (10greg) [21:37:21] 3releng-201516-q2: [keyresult] Release MW 1.26 - https://phabricator.wikimedia.org/T110486#1845974 (10greg) 5Open>3Resolved [21:51:53] 5Continuous-Integration-Scaling, 3releng-201516-q2: [keyresult] CI cluster responds to spike in queued builds by starting and registering additional jenkins slaves - https://phabricator.wikimedia.org/T111106#1846053 (10hashar) @greg that sounds like a good test plan :-] [21:53:46] 10Deployment-Systems, 10Architecture, 10Wikimedia-Developer-Summit-2016-Organization, 7Availability: WikiDev 16 working area: Software engineering - https://phabricator.wikimedia.org/T119032#1846059 (10daniel) Note to self: Kaldari indicated {T113490} as a "must have". [21:55:52] (03PS1) 10Hashar: Exhaust nodepool 1 [integration/config] - 10https://gerrit.wikimedia.org/r/256579 [21:55:54] (03PS1) 10Hashar: Exhaust nodepool 2 [integration/config] - 10https://gerrit.wikimedia.org/r/256580 [21:55:56] (03PS1) 10Hashar: Exhaust nodepool 3 [integration/config] - 10https://gerrit.wikimedia.org/r/256581 [21:55:58] (03PS1) 10Hashar: Exhaust nodepool 4 [integration/config] - 10https://gerrit.wikimedia.org/r/256582 [21:56:00] (03PS1) 10Hashar: Exhaust nodepool 5 [integration/config] - 10https://gerrit.wikimedia.org/r/256583 [21:56:02] (03PS1) 10Hashar: Exhaust nodepool 6 [integration/config] - 10https://gerrit.wikimedia.org/r/256584 [21:56:04] (03PS1) 10Hashar: Exhaust nodepool 7 [integration/config] - 10https://gerrit.wikimedia.org/r/256585 [21:56:06] (03PS1) 10Hashar: Exhaust nodepool 8 [integration/config] - 10https://gerrit.wikimedia.org/r/256586 [21:56:08] (03PS1) 10Hashar: Exhaust nodepool 9 [integration/config] - 10https://gerrit.wikimedia.org/r/256587 [21:56:09] greg-g: ^^^ :D [21:56:10] (03PS1) 10Hashar: Exhaust nodepool 10 [integration/config] - 10https://gerrit.wikimedia.org/r/256588 [21:56:29] 10Beta-Cluster-Infrastructure, 3Scap3, 6Analytics-Backlog, 6Services, 7WorkType-NewFunctionality: Set up AQS in Beta - https://phabricator.wikimedia.org/T116206#1846067 (10Milimetric) @mobrovac: those sound like things I can do? Let me know if you've started on them yet, and if not please assign this to... [21:56:40] hashar: Magic files? [21:56:51] James_F: load testing in prod [21:56:53] :D [21:56:55] Ah, OK. [21:57:08] hah! [21:57:56] i [21:58:19] hashar: exhausting nodepool && exhausting yourself! :P [21:58:32] na [21:58:37] I took a nap a couple weeks ago :-} [21:58:40] hahaha [22:00:34] that goes too fast [22:02:13] so [22:02:20] I exhausted nodepool :/ [22:05:12] 5Continuous-Integration-Scaling, 3releng-201516-q2: [keyresult] CI cluster responds to spike in queued builds by starting and registering additional jenkins slaves - https://phabricator.wikimedia.org/T111106#1846082 (10hashar) I sent 12 patches against integration/config each triggering two jobs running on nod... [22:06:45] pool replenished [22:06:50] after 10 minutes :-/ [22:07:13] tl;dr: it is not fast enough / does not have burst capabilities [22:07:14] grr [22:17:03] 10Beta-Cluster-Infrastructure, 6Commons, 10MediaWiki-File-management, 6Multimedia, 5Patch-For-Review: Images with extra parameters (e.g. low-quality JPEG) are not rendered in beta - https://phabricator.wikimedia.org/T71757#1846118 (10Tgr) [22:19:56] greg-g: when you have a moment, could you please take a look at https://phabricator.wikimedia.org/T116786#1846123 ? [22:20:38] PROBLEM - git_daemon_running on gallium is CRITICAL: PROCS CRITICAL: 2 processes with regex args ^/usr/lib/git-core/git-daemon [22:21:56] ^^^ :-( [22:24:23] 10Beta-Cluster-Infrastructure, 6Commons, 10MediaWiki-File-management, 6Multimedia: Thumbnail generation should happen via the same setup in the beta cluster and in production (tracking) - https://phabricator.wikimedia.org/T84950#1846144 (10Ricordisamoa) [22:24:46] RECOVERY - git_daemon_running on gallium is OK: PROCS OK: 1 process with regex args ^/usr/lib/git-core/git-daemon [22:40:58] https://gerrit.wikimedia.org/r/256593 should fix the probe [22:41:30] nodepool is happy, sleep time :-} [22:49:53] 10Continuous-Integration-Infrastructure, 10Differential, 5Gerrit-Migration, 3releng-201516-q1: [keyresult] Prototype CI integration with Differential - https://phabricator.wikimedia.org/T103127#1846242 (10greg) Talked a bit with @mmodell about this in our 1:1 today. Thoughts are: * "prototyping" has been... [22:50:35] 10Continuous-Integration-Infrastructure, 10Differential, 5Gerrit-Migration, 3releng-201516-q1: [keyresult] Prototype CI integration with Differential - https://phabricator.wikimedia.org/T103127#1846244 (10greg) >>! In T103127#1846242, @greg wrote: > * a idea to port the scap jobs to nodepool (thus triggere... [22:52:21] 3releng-201516-q2, 3releng-201516-q3: [keyresult] Integrate Differential with our Continuous Integration infrastructure - https://phabricator.wikimedia.org/T112133#1846249 (10greg) [22:52:22] 10Continuous-Integration-Infrastructure, 10Differential, 5Gerrit-Migration: Connect Differential code review with continuous integration - https://phabricator.wikimedia.org/T31#1846250 (10greg) [22:52:35] 10Continuous-Integration-Infrastructure, 10Differential, 5Gerrit-Migration, 3releng-201516-q2, 3releng-201516-q3: Connect Differential code review with continuous integration - https://phabricator.wikimedia.org/T31#477 (10greg) [22:55:08] 10Differential: Support "one-click" rebasing of a Differential onto current master - https://phabricator.wikimedia.org/T117779#1846261 (10greg) [22:55:09] 10Differential: Support simple ("one-click") generation of cherry-pick Differentials between branches - https://phabricator.wikimedia.org/T117776#1846262 (10greg) [22:55:11] 10Differential, 10Diffusion: Support one-click creation of reverts in Differential/Diffusion - https://phabricator.wikimedia.org/T117774#1846263 (10greg) [22:55:15] 10Differential, 5Gerrit-Migration, 7Documentation: Document gerrit workflows and demonstrate equivalent in arcanist workflows - https://phabricator.wikimedia.org/T117058#1846260 (10greg) [22:56:57] 10Differential, 5Gerrit-Migration, 7Documentation: Document gerrit workflows and demonstrate equivalent in arcanist workflows - https://phabricator.wikimedia.org/T117058#1765720 (10greg) I removed these tasks as blockers of this, as they aren't blockers of documenting workflows. However, documenting how to d... [22:57:47] 10Differential, 10Phabricator-Upstream: Support "one-click" rebasing of a Differential onto current master - https://phabricator.wikimedia.org/T117779#1846278 (10greg) [22:58:12] 10Differential, 10Diffusion, 10Phabricator-Upstream: Support one-click creation of reverts in Differential/Diffusion - https://phabricator.wikimedia.org/T117774#1846279 (10greg) [23:03:18] 10Continuous-Integration-Infrastructure, 10Differential, 5Gerrit-Migration, 3releng-201516-q1: [keyresult] Prototype CI integration with Differential - https://phabricator.wikimedia.org/T103127#1846318 (10demon) >>! In T103127#1846244, @greg wrote: >>>! In T103127#1846242, @greg wrote: >> * a idea to port... [23:03:32] greg-g: Hehe ^^ [23:05:35] 10Continuous-Integration-Infrastructure, 10Differential, 5Gerrit-Migration, 3releng-201516-q1: [keyresult] Prototype CI integration with Differential - https://phabricator.wikimedia.org/T103127#1846322 (10mmodell) @demon: yes but that means installing arc on build slaves which means packaging arcanist. >>... [23:06:37] twentyafterfour: Why does it have to be packaged to go on the slaves? [23:06:43] 10Differential, 5Gerrit-Migration, 15User-greg: "Open Revisions Affecting These Files" does not indicate direction of dependency - https://phabricator.wikimedia.org/T179#1846323 (10greg) 5Open>3Invalid a:3greg > **avive** wrote on `2014-05-10 22:12:53 (UTC)` > > Phab doesn't automatically understand g... [23:07:00] ostriches: I don't know, isn't that a requirement? [23:07:07] No? [23:07:14] I don't know how to get it there other than packaging and adding it in puppet [23:07:15] I don't see why it would be for the slaves. [23:07:28] install via git in puppet like we do with bunches of other shit? [23:07:32] git::clone{}? [23:10:46] hmm well that's easy enough I suppose, if that's acceptable [23:10:59] twentyafterfour: Reverting diffusion links on gerrit for now. Biggest problem I'm seeing is urlencoding of /'s [23:11:08] eg: https://phabricator.wikimedia.org/r/branch/mediawiki%2Fcore 404s. [23:11:11] Arcanist is "packaged" in brew. [23:11:16] 5Gerrit-Migration, 10Analytics-Tech-community-metrics: Make MetricsGrimoire/korma support gathering Code Review statistics from Phabricator's Differential - https://phabricator.wikimedia.org/T118753#1846331 (10greg) >>! In T118753#1843392, @greg wrote: > "Bitergia to check out the the API of Differential." Is... [23:11:29] Could it be packaged by Phacility for Debian? [23:11:34] James_F: Ok awesome, then we'll just switch our slaves to use OSX and it'll be all packaged up :D [23:11:46] ostriches: Wait for the second half of the comment. :-P [23:11:58] ostriches: so where is the urlencoding happening? I'm sure I can apply some decoding on my side [23:12:21] Probably gerrit urlencoding them if memory serves. [23:12:27] It's been $some_time since I fucked with this [23:12:41] 10Differential, 5Gerrit-Migration, 10Phabricator-Upstream: Differential notification emails lack headers for repository and state change - https://phabricator.wikimedia.org/T117186#1846332 (10greg) [23:12:47] well can you not revert for a minute and we'll test it? [23:12:51] or is it too late? [23:13:06] Eh, too late. We can always rerevert lmao [23:17:04] 10Differential, 5Gerrit-Migration, 10Phabricator-Upstream: Differential notification emails lack headers for repository and state change - https://phabricator.wikimedia.org/T117186#1846349 (10greg) Reported upstream as https://secure.phabricator.com/T9891 [23:17:21] 10Differential, 5Gerrit-Migration, 10Phabricator-Upstream: Differential notification emails lack headers for repository and state change - https://phabricator.wikimedia.org/T117186#1846350 (10greg) [23:24:21] We're seeing some bizarre CI errors, can anyone help? https://gerrit.wikimedia.org/r/#/c/256603/ [23:24:47] James_F: https://packages.qa.debian.org/p/phabricator.html [23:26:53] ostriches: it's strange, the 404 seems to be generated by the proxy, it's not a 404 from phabricator [23:27:41] I bet I know why, it's probably the same weird proxy behavior we've hit before. [23:27:48] as soon as I urlencode anything in that path it 404s with a plain (not phabricator-styled) error page [23:29:16] ostriches: do you know how it was fixed before? [23:29:30] marxarelli: and/or thcipriani: can you take a look at awight's issue above? [23:29:45] I don't know that issue, if it's common or anything [23:30:17] AllowEncodedSlashes NoDecode [23:30:17] RewriteEngine On [23:30:17] RewriteCond %{REQUEST_URI} !^/robots.txt$ [23:30:17] RewriteRule ^/(.*) http://127.0.0.1:8080/$1 [NE,P] [23:30:18] I've seen that before, the only solution was to rebase the patch locally [23:30:18] I've never seen that before, either. I wonder if it's something to with repo state on gallium? [23:30:23] twentyafterfour: Bleh ^^^ [23:30:44] (what we did before with slashes, I hate slashes. slashes are dumb) [23:31:12] We *could* replace it with like ! or something non-pathy and have Phab rewrite it for us :) [23:31:19] *something else non-pathy [23:31:33] ostriches: but how do you get gerrit to use something other than a slash? [23:31:42] awight: try rebasing locally [23:31:43] There's a config var for it we haven't set. [23:31:44] But could. [23:32:12] specifically for the project namespace delimiter? [23:32:26] Well, when linking to them from the UI, yeah [23:32:39] ok lets do that, I guess [23:32:57] Lemme restore the original patch with that added too [23:32:58] how about just using . ? [23:33:32] or unencoded slashes ;) [23:33:37] . could work too, I was gonna go with ! because it's unlikely to get urlencode munged and very very unlikely to appear in a directory name. [23:33:42] (it's impossible in Windows iirc...) [23:34:01] * ostriches mumbles something again about slashes being dumb :)) [23:34:15] well it only has to not be used in our gerrit project names, and that list is clean (no special characters, other than slash) [23:35:14] Leah eh? [23:35:19] :) [23:36:08] Valid values are the characters *, ( and ). [23:36:16] twentyafterfour: ^ meh [23:36:19] Go with * I suppose? [23:36:27] ok [23:36:27] greg-g: ok thx [23:36:28] ( and ) scares me [23:36:43] , or * are both fine with me [23:37:09] I'm not entirely sure if that's an acceptable value or just a comma in a list. [23:37:11] lmao [23:37:18] btw, I don't have access to gallium, apparently, so I can't check out the repo state [23:37:33] twentyafterfour: Oh, I can fix this. [23:37:36] There's also gitweb.urlEncode [23:37:38] Defaults true [23:37:52] ohhh [23:38:27] Probably explains about 95% of the problems we had decoding /'s in gitblit in retrospect tbh. [23:39:46] greg-g: Creepy! Now that I've rebased to real master, the rebase button appears. Bad news bears. [23:40:02] rebasing kills kittens or something [23:40:09] no no, that's freebasing [23:40:16] hahah [23:40:27] greg-g: it's true, I tried it on my kitten once [23:40:27] I always forget those extra F and Es [23:40:48] twentyafterfour: you just made me literal lol more than I have in a long time from IRC [23:40:49] * Reedy wonders how many kittens Paladox has killed [23:40:51] s/kitten/canary/ [23:40:55] twentyafterfour: https://gerrit.wikimedia.org/r/#/c/256605/ [23:41:02] * ostriches has a kitten in a coalmine [23:41:09] Wait, now I'm confused too! [23:41:10] :D [23:41:33] * ostriches makes afternoon coffee [23:41:56] * twentyafterfour makes coffee too [23:47:19] * greg-g goes away to send off family, bbl